[00:00:51] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer embed drop-down menu stupidity - 10https://bugzilla.wikimedia.org/70918 (10MZMcBride) 3NEW p:3Unprio s:3normal a:3None You can see attachment 16492 for reference. This screenshot is from 3MediaWiki extensions / 3PdfHandler: configuration problems with windows paths with blanks/spaces - 10https://bugzilla.wikimedia.org/70083#c23 (10carchaias) The path to the file (d:\MediawikiTestwiki_Images/f/f0/0003_1110_Technische_Dokumentation.pdf) is correct, but there is no entry within the thumb-part (... [06:58:14] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer: Closing MediaViewer results in black, undismissable page - 10https://bugzilla.wikimedia.org/70756#c16 (10Erik Moeller) Confirmed fixed (tested in FF32 and Chrome35). [07:08:44] 3MediaWiki extensions / 3MultimediaViewer: via attribution link provides wrong mediaviewer link - 10https://bugzilla.wikimedia.org/69956#c6 (10Erik Moeller) Confirmed, works as advertised. [07:33:55] (03CR) 10Gilles: [C: 032 V: 032] Fix relative UW funnel numbers [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/160682 (owner: 10Gergő Tisza) [07:36:18] (03CR) 10Gilles: [C: 032 V: 032] Remove useless columns from ordinal chart [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/160684 (owner: 10Gergő Tisza) [07:39:06] (03CR) 10Gilles: [C: 032] Add relative timeseries [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/160779 (owner: 10Gergő Tisza) [07:39:09] (03CR) 10jenkins-bot: [V: 04-1] Add relative timeseries [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/160779 (owner: 10Gergő Tisza) [07:41:30] (03PS2) 10Gilles: Add relative timeseries [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/160779 (owner: 10Gergő Tisza) [07:42:21] (03CR) 10Gilles: [C: 032] Add relative timeseries [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/160779 (owner: 10Gergő Tisza) [07:42:26] (03Merged) 10jenkins-bot: Add relative timeseries [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/160779 (owner: 10Gergő Tisza) [07:47:34] (03CR) 10Hashar: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150585 (owner: 10Gilles) [08:00:37] pginer: please check out https://gerrit.wikimedia.org/r/#/c/160041/6 again [08:00:57] I've added another comment about why it looks weird for the panel to follow the scroll and not the icon [08:01:20] repro steps: apply the patch, open the "use this file" panel, start scrolling [08:04:53] the panel should close when scrolling. Even when the share panel was attached to the metadata panel, that would be preferred. Now that it is attached to the image it looks very broken otherwise [08:06:21] (03CR) 10Gilles: [C: 04-1] "The last timeseries shows nothing, but I'm not sure if it's not caused by the TSV itself, which contains some "NULL" values for September " [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/160785 (owner: 10Gergő Tisza) [08:11:20] (03CR) 10Gilles: "Filed a card for the data collection issue: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/894" [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/160785 (owner: 10Gergő Tisza) [08:13:49] pginer: that doesn't very usable, accidental scrolls can happen, and if you're in the middle of doing something in the panel that would be frustrating [08:14:14] it seems like a hacky patch to the usability issue. what's wrong with things following the panel? [08:14:14] yes, that was what I was checking [08:14:23] Embed code canbe a problem [08:14:52] if you scroll and reach the end, the scrolling bubbles and it would make the panel diasppear [08:15:15] Fixing the position and let the metadata panel cover the share panel seems the simple approach [08:15:43] right, but even if there wasn't a scrollable element, people with approximate scrolling/pointing skills would run into the problem too [08:16:13] we're expert pointers/clickers, average people have a more fuzzy mouse/trackpad usage [08:17:07] I was thinking on having a treshold (making it disappear when it was about to get covered), but with scrollable elments, I think that it would be definitely problematic in any case. [08:17:12] right, so putting the popup behind the panel, works for me [08:18:15] you know that wouldn't be a problem if the page scrolled naturally ;) [08:18:33] nothing would cover anything else, in that context [08:19:44] related to that, we have an interesting testing session where the user got lost because the “X” close button was covered by the usertesting.com instructions. [08:20:00] A “natural” scrolling would hide the “X” button as soon as you scroll [08:20:12] only if you don't make the X position fixed [08:20:54] there would be value to keeping the top buttons always in view over the image, even if part of the image is scrolled out of view [08:21:34] I can update my old natural scroll prototype to see how it feels [08:21:40] but then you’ll have similar issues on how to deal with such floating elements [08:22:17] not really, because the top buttons don't take that much height. you'd have to be severely height-constrained to not see any of the image anymore [08:22:19] are they going to cover the information part? how is the share panel going to display when ou scroll and leave little room for it [08:22:20] ? [08:22:57] ideally the popup should open downwards if there's more room below it than above it [08:23:09] I'm not sure OOUI does that [08:23:50] another possibility that hasn't been explored is to stop having popups. add the share opens inline inside the panel, given the room we've freed there [08:24:09] or, a different popup approach [08:24:16] with a fullscreen-ish popup [08:24:23] like what you'd get inside a vimeo video, for example [08:24:34] when the sharing features take over the entire page, as a dark overlay [08:24:57] have you seen the new action stats? there's interesting stuff about what gets used and what doesn't [08:25:12] (03CR) 10Pginer: [C: 04-1] "Some comments:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160041 (owner: 10MarkTraceur) [08:25:14] http://multimedia-metrics.wmflabs.org/dashboards/mmv (scroll down) [08:26:13] ignore "select html original" on the embed graph, it's a OOUI limitation where we have to select that option when the tab is open, and it creates an event I couldn't get rid of [08:26:47] there are a few interesting things: people are significantly using the size options on download [08:27:14] but almost not at all on the wikitext embed [08:28:06] html code is used a lot more than wikitext, which I take as a sign that the wikitext we propose might not be the wikitext people are really interested in. this goes back to the filename request people keep making. I think we're not providing what people need for on wiki activities [08:28:43] people are using the size options on html embed as well, quite a bunch [08:29:36] the share url is copied about as much as html and wikitext combined. I would have expected more [08:32:20] ah, and of course the footer links usage is limited (see the new metrics in the top graph. eg. help page, discuss page, etc.). [08:32:59] but all is relative, people visit the discuss page about twice as much as the wikitext gets copied [08:34:39] anyway, back to the scroll/popup issue, it seems to me like we're trying to find workaround to make parts that don't fit together work together. MV doesn't particularly need popups in the first place, they're just a means to an end, and maybe people could access those features differently [08:35:42] the z-index change you suggest is a workaround, it's still clunky to look at [08:38:47] there are different interaction patterns that can be applied each one has its pros and cons. A “modal” panel would add additional friction to the user interaction. the popups reinforce the meaning of the side icons by being connected to them. [08:40:04] this could all live below the fold [08:40:05] In our last round of tests we had a popup for disabling Media viewer, and the panel could overlap it too, but that didn’t happen because when users were focused on an action from the popup they didn’t accessed the panel for more info. [08:40:56] if according to the stats, the "use this file" stuff is used about as much as the tiny links at the very bottom of the footer, making those features below-the-fold might not impact usage that much [08:41:10] plus you can still have icons that would scroll you to where the action happens, for example [08:42:36] the problem with the tests is that people are following a pretty defined track (they are told to disable it at that point), it's not that representative of people poking around more randomly [08:43:01] With the analytics we have always the issue of not knowing if users are accessing it all hey want to (thus low numbers mean we can make them less prominent), or users are not aware of the features (and low numbers mean we should try to make them easier to discover) [08:43:44] tgr you there? [08:43:59] Steinsplitter: hi [08:44:31] With the below the fold info I keep hearing that the poblem is discoverability but access numbers are similar to the full-sceen action which users seemed to be able to discover without problems on tests. [08:44:35] pginer: keeping the icons and moving the contents of the popup below the fold wouldn't affect discoverability negatively. in fact it might increase it, if the featurea are available in the panel without having to click on the icons [08:44:43] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer doesn't work with .djvu files - 10https://bugzilla.wikimedia.org/70912#c1 (10Tisza Gergő) MediaViewer does not support paged media at the moment. [08:45:05] the icons would just act as an above-the-fold discoverability hook [08:46:06] and combined with natural scrolling, the image would almost never get covered by anything (the only thing left is the disable popup, really). I think that could have a non-negligible psychological impact [08:46:12] tgr: pm'ed you :) [08:46:16] the image/the rest [08:46:26] a better separation, instead of having things overlap each other [08:46:59] I can prototype that, the challenge is to establish the connection. You click an icon, and a panel with several elements open, and we need to draw the attention of the user towards a specific one. [08:47:12] and while we've conveniently swept tablets under the carpet so far, making things inline is more touch screen friendly [08:48:08] pginer: most of them have an input box, don't they? if we focus on it, it'd be highlighted [08:48:41] in fact I'm pretty sure that the browser would take care of scrolling as well on a focus even. athough the lack of animation might be a bit jarring [08:48:54] *event [08:50:39] I’m not sue that would be enough for users not getting lost. [08:51:12] it largely depend on how the below-the-fold area is oganized [08:54:24] (03PS3) 10Gilles: [WIP] Natural scrolling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150561 [08:54:27] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Natural scrolling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150561 (owner: 10Gilles) [08:54:37] ^ now with position: fixed for the top icons [08:55:19] pginer: what do you think about the wikitext stats? [08:56:05] i.e. lower usage than html, very low usage of size options compared to download and html [08:56:06] the reuse panel already has a tabbed interface, how about adding a new tab like "info" and making the metadata panel tabbed? [08:56:39] gi11es: doesn't that just mean there are a lot more readers than editors? [08:57:32] html embed code entails being a bit more active than just being a reader [08:57:43] presumably it's people who are putting this on their blog or similar [08:57:58] btw one thing I have been considering for the metadata cleanup drive is adding an "alt" field to the information template [08:58:04] One hypothesis is that the wikitext is used to add an image to an article, which normally happens after uploading the image. When viewing images from articles those are already added. So the remaining usecase is to add them to a different language version or a similar article [08:58:17] that would make wikitext embed more useful than it is now [08:58:31] we still don't know what people need the plain filename exactly for [08:58:44] maybe that's a community workflow investigation we could put guillom on? [08:58:48] gi11es: maybe we could ask? :) [08:59:17] HTML embed is useful to reuse the image outside of Wikipedia [08:59:17] right, but there's a bit of community legwork involved to get that information [08:59:25] just start a thread on multimedia/comons-l IMO [09:00:25] pginer: I'm not sure that this connection between people uploading stuff to commons and that content's use in articles is that strong [09:00:58] sure, some people will set out to add an image to an article and do that, but there's also people who will search commons for something appropriate instead of producing an image of their own [09:01:16] I'd tend to imagine that the latter is easier for people who are focused on the article's content [09:01:29] I would guess that's the huge majority [09:01:39] which one? [09:01:51] people looking for images on Commons [09:02:01] then again, MV is disabled on Commons [09:02:53] it'd be interesting to know how many people copying the wikitext end up cleaning up to turn it into something else... (eg. filename) [09:03:01] copying images from another language version of the same article is also very typical, but I think an experienced editor would use wikitext to do that [09:03:15] Visual Editor’s insert image does not require Wikitext’s embed [09:03:27] I mean, open the article for editing, copy the image wikitext, paste it into the local article [09:03:41] and beginners use VisualEditor anyway [09:04:02] we don't support VE at all currently [09:04:25] ot WE doesn't support MV at all, depending on how you look at it ;) [09:04:27] VE [09:04:42] and the wikitext editor opens a dialog that asks you for Filename, caption.. [09:04:56] what format does the VE image insert expect? [09:05:17] James_F|Away: ^^ [09:05:40] They have a search image panel, which I suggested several times they should support image URL (direct and the one used by our share panel) [09:05:57] Not sure if they did something related to that [09:09:31] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer does not support IE8 - 10https://bugzilla.wikimedia.org/70932 (10Tisza Gergő) 3NEW p:3Unprio s:3normal a:3None IE 8 is a grade A browser [1], MediaViewer should support it eventually. [09:10:29] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer does not support IE8 - 10https://bugzilla.wikimedia.org/70932#c1 (10Tisza Gergő) (In reply to Tisza Gergő from comment #0) > IE 8 is a grade A browser [1], MediaViewer should support it eventually. [1] https://www.mediawiki.org/wiki/Compatibility#Browse... [09:12:17] 3MediaWiki extensions / 3MultimediaViewer: SVG icons in MediaViewer should have a fallback - 10https://bugzilla.wikimedia.org/70933 (10Tisza Gergő) 3NEW p:3Unprio s:3normal a:3None MediaWiki supports a background-image-svg mixin to detect browser support and fall back to PNG when SVG backgrounds are... [09:12:30] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer does not support IE8 - 10https://bugzilla.wikimedia.org/70932 (10Tisza Gergő) [09:12:31] 3MediaWiki extensions / 3MultimediaViewer: SVG icons in MediaViewer should have a fallback - 10https://bugzilla.wikimedia.org/70933 (10Tisza Gergő) [09:13:14] 3MediaWiki extensions / 3MultimediaViewer: SVG icons in MediaViewer should have a fallback - 10https://bugzilla.wikimedia.org/70933 (10Tisza Gergő) [09:13:16] 3MediaWiki extensions / 3MultimediaViewer: SVG icons cannot be automatically transformed to PNG - 10https://bugzilla.wikimedia.org/70654 (10Tisza Gergő) [09:14:39] gi11es: https://bugzilla.wikimedia.org/show_bug.cgi?id=64935 [09:22:30] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer embed drop-down menu stupidity - 10https://bugzilla.wikimedia.org/70918#c1 (10Tisza Gergő) Confirmed on Chrome 37 / Ubuntu. I remember this error back from when we created the reuse panel; it's somehow related to not calling one of the OOUI setup functi... [09:23:15] 3MediaWiki extensions / 3PagedTiffHandler: Array to string conversion in TransformationalImageHandler.php:167 - 10https://bugzilla.wikimedia.org/70902#c3 (10Andre Klapper) (In reply to Sam Reed (reedy) from comment #2) > So presumably it's actually the extension at fault -> moving to its component [09:23:31] 3MediaWiki / 3File management: Undefined $scaler in TransformationalImageHandler::rotate() - 10https://bugzilla.wikimedia.org/70903 (10Andre Klapper) p:5Unprio>3Low [09:27:14] (03CR) 10Pginer: "Some comments:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/150561 (owner: 10Gilles) [09:42:15] 3MediaWiki extensions / 3MultimediaViewer: MV broken in Internet Explorer 8 on WMF sites - 10https://bugzilla.wikimedia.org/70553 (10Andre Klapper) [09:42:15] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer does not support IE8 - 10https://bugzilla.wikimedia.org/70932 (10Andre Klapper) [09:50:09] 3MediaWiki extensions / 3MultimediaViewer: MV broken in Internet Explorer 8 on WMF sites - 10https://bugzilla.wikimedia.org/70553#c11 (10Tisza Gergő) 5PATC>3RESO/FIX Should be fixed in https://gerrit.wikimedia.org/r/159265 . The fix will be deployed to wikipedias tomorrow. [09:56:08] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer embed text area cannot be resized in-browser - 10https://bugzilla.wikimedia.org/70915#c1 (10Tisza Gergő) OOUI textInputWidgets have resize:none by default. We could override that, but given that the whole panel is fairly small and non-dynamic, I don't se... [09:59:37] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer embed text area is too small, should be made taller/larger - 10https://bugzilla.wikimedia.org/70914#c1 (10Tisza Gergő) The box is there to copy the text, not to read it. Especially the HTML embed text can be arbitrarily long, if we want to make it visibl... [11:59:09] 3MediaWiki / 3Uploading: SVG encoding get blocked (windows-1252, with wrong/unspecific warning) - 10https://bugzilla.wikimedia.org/70937 (10PRO) 3NEW p:3Unprio s:3normal a:3None I got an ERROR unspecific warning: "This file contains HTML or script code that may be erroneously interpreted by a web bro... [11:59:50] 3MediaWiki / 3Uploading: SVG upload get blocked on correct encoding (windows-1252, with wrong/unspecific warning) - 10https://bugzilla.wikimedia.org/70937 (10PRO) [12:00:36] 3MediaWiki / 3Uploading: SVG upload get blocked on correct encoding (windows-1252, with wrong/unspecific warning) - 10https://bugzilla.wikimedia.org/70937 (10PRO) [12:00:37] 3MediaWiki / 3Uploading: Scripted SVG checks blacklist all filter attributes, even if local to current svg doc - 10https://bugzilla.wikimedia.org/67044 (10PRO) [13:05:36] (03CR) 1001tonythomas: [C: 031] Renamed 'Credit' to 'FileSource' [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/107368 (https://bugzilla.wikimedia.org/57189) (owner: 10Amruthasangeeth) [13:07:37] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer embed text area cannot be resized in-browser - 10https://bugzilla.wikimedia.org/70915#c2 (10MZMcBride) (In reply to Tisza Gergő from comment #1) > OOUI textInputWidgets have resize:none by default. I don't understand why this is. It seems to directly de... [13:10:37] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer embed text area is too small, should be made taller/larger - 10https://bugzilla.wikimedia.org/70914#c2 (10MZMcBride) (In reply to Tisza Gergő from comment #1) > The box is there to copy the text, not to read it. Especially the HTML embed > text can be ar... [14:00:37] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer embed text area is too small, should be made taller/larger - 10https://bugzilla.wikimedia.org/70914#c3 (10Tisza Gergő) It could be made slightly larger, sure. It could not be made large enough to show the full HTML code for an average image - it tends to... [14:11:21] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer embed text area cannot be resized in-browser - 10https://bugzilla.wikimedia.org/70915#c3 (10Tisza Gergő) Created attachment 16504 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16504&action=edit embed HTML textbox resized to show all text (In re... [14:12:52] 3MediaWiki / 3Uploading: SVG upload get blocked on correct encoding (windows-1252, with wrong/unspecific warning) - 10https://bugzilla.wikimedia.org/70937#c1 (10Tisza Gergő) I am not sure I understand the role of encoding in this bug. Do you get the error with some encoding but not with another one? [14:49:21] (03CR) 10Gilles: [C: 04-1] "Needs rebase" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/159625 (https://bugzilla.wikimedia.org/46741) (owner: 10MarkTraceur) [15:19:21] pginer: Are we still using alpha for anything important? [15:20:17] I wanted to pull the latest work on the UI changes, but I can hold off [15:20:43] We were using it as a way to expose the prototype we tested. Since that was related with the consltation, it may no longer be needed. [15:20:48] Sweet [15:25:32] (03PS1) 10Gergő Tisza: Fix EventLogging schema declarations [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/160972 [15:26:30] (03CR) 10Gergő Tisza: "Could not test locally because EL is broken in vagrant but this seems to be the only change that could have caused problems." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/160972 (owner: 10Gergő Tisza) [15:30:06] (03CR) 10Gilles: [C: 032] Fix EventLogging schema declarations [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/160972 (owner: 10Gergő Tisza) [15:30:33] (03CR) 10jenkins-bot: [V: 04-1] Fix EventLogging schema declarations [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/160972 (owner: 10Gergő Tisza) [15:30:55] I've been preparing the mingle stuff a bit more than usual [15:31:01] I saw that! [15:31:11] I've moved a few things to the current sprint which I think will be non-controversial to pick up [15:31:13] I'm 100% a fan [15:31:44] I think there will be roughly 5 points left to pick from the cycle pile [15:36:26] (03PS2) 10Gergő Tisza: Fix EventLogging schema declarations [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/160972 [15:36:45] (03CR) 10Gergő Tisza: "recheck; error seems unrelated." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/160972 (owner: 10Gergő Tisza) [15:37:23] * bd808 peeks in an smiles happily at how different work planning seems in MM 1 year later [15:38:21] (03CR) 10Gergő Tisza: [C: 032] "per Gilles" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/160972 (owner: 10Gergő Tisza) [15:38:49] (03Merged) 10jenkins-bot: Fix EventLogging schema declarations [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/160972 (owner: 10Gergő Tisza) [15:40:25] we should probably backport that [15:45:20] tgr: Add it to the SWAT this afternoon, I can take it [15:45:31] If Ed and Roan don't bogart the SWAT again. [15:45:32] cool, thanks [15:53:53] gi11es, tgr: I'm not sure I understand what you mean by "what format does the VE image insert expect?", sorry. [15:55:04] James_F: When you paste in HTML that contains an image, I imagine [15:55:14] I assumed there was a way to paste an file's URL, filename or similar information about it to add it to the article [15:55:22] is there just a search box to find the image on commons? [15:55:45] Ah. No, you can't paste HTML with images ( and
elements are blacklisted on paste except for VE sources). [15:56:09] Yes, which uses the search API (so filenames work, most of the time, as do things on the description page). [15:56:44] gi11es: can we pick up https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/473 ? [15:57:02] the embed image size fix will be a bit painful without that [15:59:23] sure [16:03:05] Can someone please review https://gerrit.wikimedia.org/r/160978 and https://gerrit.wikimedia.org/r/160979 ? [16:03:26] Trying to get the vips scaler tiff code guided throug [16:05:37] 3MediaWiki / 3Uploading: SVG upload get blocked on correct encoding (windows-1252, with wrong/unspecific warning) - 10https://bugzilla.wikimedia.org/70937#c2 (10Chris Steipp) Currently, we only allow encodings: $safeXmlEncodings = array( 'UTF-8', 'ISO-8859-1', 'ISO-8859-2', 'UTF-16', 'UT... [16:12:24] 3MediaWiki extensions / 3UploadWizard: Special:UploadWizard is 503 on beta labs commons - 10https://bugzilla.wikimedia.org/70942 (10Chris McMahon) 3NEW p:3Unprio s:3major a:3None As a logged in user, go to http://commons.wikimedia.beta.wmflabs.org/wiki/Special:UploadWizard Get system error page wi... [16:13:38] 3MediaWiki extensions / 3UploadWizard: Special:UploadWizard is 503 on beta labs commons - 10https://bugzilla.wikimedia.org/70942#c1 (10Chris McMahon) Seems to have started doing this 16 Sept [16:14:27] marktraceur: is MMV known to be busted for IE8 right now? [16:14:33] Uhh [16:14:37] 3MediaWiki / 3Uploading: SVG upload get blocked on correct encoding (windows-1252, with wrong/unspecific warning) - 10https://bugzilla.wikimedia.org/70937#c3 (10PRO) (In reply to Tisza Gergő from comment #1) Yes, the [[Windows-1252]] encoding is preferred by the W3C (validator) to encoding="ISO-8859-1", also... [16:14:38] yes [16:14:43] Apparently yes. [16:14:56] tgr marktraceur OK, just checking: https://integration.wikimedia.org/ci/view/BrowserTests/view/-All/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-windows_7-internet_explorer-8-sauce/lastCompletedBuild/testReport/ [16:15:10] other browsers look OK [16:15:25] There's a bug for IE8 https://bugzilla.wikimedia.org/show_bug.cgi?id=70932 [16:15:25] :) [16:19:19] Reedy: I heard a rumor that MMV did work in IE8, thus we made the test build for it [17:13:45] chrismcmahon: we actually want to test that MMV doesn't work in IE8 (i.e. doesn't even open) [17:13:51] it's blacklisted and meant to stay that way [17:14:11] and recently it got accidentally un-blacklisted, which resulted in IE8 users getting a broken MMV instead of going to the file page like they used to [17:14:18] gi11es: OK, thanks [17:15:35] for actual IE8 support we're mostly blocked on OOUI's IE8 support right now [17:16:01] the rest that needs fixing isn't that bad (providing PNG fallbacks for the SVG icons, mostly) [17:17:21] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer does not support IE8 - 10https://bugzilla.wikimedia.org/70932#c4 (10Gilles Dubuc) To be picked up when this becomes a priority: https://gerrit.wikimedia.org/r/#/c/159468/ [17:22:06] 3MediaWiki / 3File management: Undefined $scaler in TransformationalImageHandler::rotate() - 10https://bugzilla.wikimedia.org/70903#c3 (10Umherirrender) 5PATC>3RESO/FIX successfully merged [17:40:55] (03CR) 10Rillke: "FYI, there is an empty repo for this purpose now: https://gerrit.wikimedia.org/r/#/admin/projects/mediawiki/extensions/DetectLanguage" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/152177 (owner: 10Rillke) [17:50:58] chrismcmahon: I should give you a better opportunity to tell me that betalabs requires security/performance review before I just go ahead and do it [17:51:52] marktraceur: betalabs extensions require a security review... [17:51:58] marktraceur: I usually just alert Chris Steipp for that stuff, he should get security review as a matter of routine [17:52:05] KK [17:52:13] I guess I'll be waiting anyway, then. [17:52:37] marktraceur: I think we are a little loose about security review for extensions already on beta, unless there is some major change happening. [17:52:51] Well, it's a new extension. [17:53:11] what extension is it? [17:53:17] marktraceur: yeah, new extensions get the full treatment. what extension? [17:54:01] marktraceur: the long-standing policy is that extensions don't go on beta labs until they have a production release date scheduled [17:54:25] ImageMetrics [17:54:41] errr [17:54:47] didn't that pass security review already? [17:54:58] https://bugzilla.wikimedia.org/show_bug.cgi?id=70789#c1 [17:55:08] Oh [17:55:09] Er [17:55:24] Victory [17:55:29] So I'll write that patch then. [17:56:21] 3MediaWiki extensions / 3PagedTiffHandler: Array to string conversion in TransformationalImageHandler.php:167 - 10https://bugzilla.wikimedia.org/70902#c6 (10Umherirrender) 5PATC>3RESO/FIX successfully merged [18:05:57] (03PS2) 10MarkTraceur: WIP make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 [18:06:30] (03CR) 10jenkins-bot: [V: 04-1] WIP make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [18:10:58] (03PS10) 10MarkTraceur: Make "more details" button bigger 'n' prettier [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 [18:11:20] (03CR) 10MarkTraceur: "Added the mw-ui classes, yay!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 (owner: 10MarkTraceur) [18:12:34] (03PS11) 10MarkTraceur: Make "more details" button bigger 'n' prettier [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 [18:12:37] gi11es, marktraceur - just double checking, are we targeting the 4PM swat window to get out a fix for https://bugzilla.wikimedia.org/show_bug.cgi?id=70918 ? [18:12:57] Believe so [18:13:01] kk [18:13:18] Er, wait, maybe not [18:13:43] I think tgr was adding a different patch. [18:15:59] (03PS3) 10MarkTraceur: WIP make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 [18:16:55] (03CR) 10jenkins-bot: [V: 04-1] WIP make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [19:21:47] Eloquence, marktraceur: that's a different bug (UW logging is broken) [19:26:32] tgr, ok - but since we have a bit of UI breakage in MV I just would like to make sure we prioritize this highly [19:27:42] sure, but it still needs to be fixed, the other patch is on master and just needs a backport [19:28:00] kk [19:31:00] (03PS1) 10Gergő Tisza: Fix EventLogging schema declarations [extensions/UploadWizard] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161026 [19:31:37] (03PS1) 10Gergő Tisza: Fix EventLogging schema declarations [extensions/UploadWizard] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161027 [19:34:19] (03CR) 10jenkins-bot: [V: 04-1] Fix EventLogging schema declarations [extensions/UploadWizard] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161026 (owner: 10Gergő Tisza) [19:34:22] (03CR) 10jenkins-bot: [V: 04-1] Fix EventLogging schema declarations [extensions/UploadWizard] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161027 (owner: 10Gergő Tisza) [19:36:03] (03CR) 10Gergő Tisza: [C: 032 V: 032] "Error caused by tests not existing in this branch" [extensions/UploadWizard] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161027 (owner: 10Gergő Tisza) [19:36:24] (03CR) 10Gergő Tisza: [C: 032 V: 032] "Error caused by tests not existing in this branch" [extensions/UploadWizard] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161026 (owner: 10Gergő Tisza) [20:27:10] gi11es: is https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/862 good to go? [21:13:51] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer embed drop-down menu stupidity - 10https://bugzilla.wikimedia.org/70918 (10Erik Moeller) p:5Unprio>3High s:5normal>3major [21:18:13] (03PS4) 10MarkTraceur: Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 [21:18:32] Only 600 lines added! [21:18:41] Well, 300 if you subtract the removals. [21:18:45] (03CR) 10jenkins-bot: [V: 04-1] Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [21:18:53] Bollocks, still need to mess with the tests. [21:44:20] (03PS5) 10MarkTraceur: Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 [21:44:59] (03CR) 10jenkins-bot: [V: 04-1] Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [21:45:21] What [21:45:25] Urgh [21:56:18] view original file on thumbnail click must be the most annoying MediaViewer feature so far [21:56:38] I mistakenly click on the damn thing about twice an hour [21:57:26] and then vagrant takes a minute to load the article again for some reason [22:02:31] Ugh, it looks like position: fixed plays merry hell with what elements are placed over which [22:03:41] Aha, just stick it in the image wrapper. [22:03:43] Muahahaha [22:10:38] (03PS7) 10MarkTraceur: Make the reuse button part of the canvas [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160041 [22:10:53] (03PS12) 10MarkTraceur: Make "more details" button bigger 'n' prettier [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 [22:11:17] (03CR) 10jenkins-bot: [V: 04-1] Make the reuse button part of the canvas [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160041 (owner: 10MarkTraceur) [22:11:32] (03CR) 10jenkins-bot: [V: 04-1] Make "more details" button bigger 'n' prettier [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 (owner: 10MarkTraceur) [22:17:05] (03PS1) 10Gergő Tisza: Fix garbled dropdown text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161104 (https://bugzilla.wikimedia.org/70918) [22:17:19] marktraceur, gi11es: ^^ plz review [22:17:25] K [22:18:13] Huh, how does that fix the text? [22:18:14] Weird [22:18:41] by not overwriting the hook that was used internally by ooui [22:20:07] Ahh. [22:20:15] Brilliant [22:21:06] (03CR) 10MarkTraceur: [C: 032] Fix garbled dropdown text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161104 (https://bugzilla.wikimedia.org/70918) (owner: 10Gergő Tisza) [22:21:18] tgr: Want to make me a backport and I can claim SWAT? :) [22:21:32] sure [22:21:43] (03Merged) 10jenkins-bot: Fix garbled dropdown text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161104 (https://bugzilla.wikimedia.org/70918) (owner: 10Gergő Tisza) [22:22:06] I'll deal with fixing tests and rebasing the UI change patches tomorrow [22:25:11] (03PS1) 10Gergő Tisza: Fix garbled dropdown text [extensions/MultimediaViewer] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161107 (https://bugzilla.wikimedia.org/70918) [22:25:42] (03PS1) 10Gergő Tisza: Fix garbled dropdown text [extensions/MultimediaViewer] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161109 (https://bugzilla.wikimedia.org/70918) [22:26:10] hm [22:26:30] not sure if wmf20 is worth bothering with [22:26:54] oh well, a day is a day [22:27:37] Not like I'm doing anything else. :) [22:28:36] (03CR) 10Gergő Tisza: [C: 032] Fix garbled dropdown text [extensions/MultimediaViewer] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161109 (https://bugzilla.wikimedia.org/70918) (owner: 10Gergő Tisza) [22:28:39] (03CR) 10Gergő Tisza: [C: 032] Fix garbled dropdown text [extensions/MultimediaViewer] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161107 (https://bugzilla.wikimedia.org/70918) (owner: 10Gergő Tisza) [22:29:14] (03Merged) 10jenkins-bot: Fix garbled dropdown text [extensions/MultimediaViewer] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161109 (https://bugzilla.wikimedia.org/70918) (owner: 10Gergő Tisza) [22:29:17] (03Merged) 10jenkins-bot: Fix garbled dropdown text [extensions/MultimediaViewer] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161107 (https://bugzilla.wikimedia.org/70918) (owner: 10Gergő Tisza) [22:30:45] aw crap, forgot to commit half of that patch [22:32:58] (03PS1) 10Gergő Tisza: Fix patch which fixes the reuse dropdowns [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161112 (https://bugzilla.wikimedia.org/70918) [22:33:57] marktraceur: ^^ [22:34:55] Cool. [22:35:25] (03CR) 10MarkTraceur: [C: 032] Fix patch which fixes the reuse dropdowns [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161112 (https://bugzilla.wikimedia.org/70918) (owner: 10Gergő Tisza) [22:36:02] (03Merged) 10jenkins-bot: Fix patch which fixes the reuse dropdowns [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161112 (https://bugzilla.wikimedia.org/70918) (owner: 10Gergő Tisza) [22:36:40] (03PS1) 10Gergő Tisza: Fix patch which fixes the reuse dropdowns [extensions/MultimediaViewer] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161115 (https://bugzilla.wikimedia.org/70918) [22:37:04] (03PS1) 10Gergő Tisza: Fix patch which fixes the reuse dropdowns [extensions/MultimediaViewer] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161116 (https://bugzilla.wikimedia.org/70918) [22:37:25] (03CR) 10Gergő Tisza: [C: 032] Fix patch which fixes the reuse dropdowns [extensions/MultimediaViewer] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161115 (https://bugzilla.wikimedia.org/70918) (owner: 10Gergő Tisza) [22:37:58] (03CR) 10Gergő Tisza: [C: 032] Fix patch which fixes the reuse dropdowns [extensions/MultimediaViewer] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161116 (https://bugzilla.wikimedia.org/70918) (owner: 10Gergő Tisza) [22:38:03] (03Merged) 10jenkins-bot: Fix patch which fixes the reuse dropdowns [extensions/MultimediaViewer] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161115 (https://bugzilla.wikimedia.org/70918) (owner: 10Gergő Tisza) [22:38:38] (03Merged) 10jenkins-bot: Fix patch which fixes the reuse dropdowns [extensions/MultimediaViewer] (wmf/1.24wmf20) - 10https://gerrit.wikimedia.org/r/161116 (https://bugzilla.wikimedia.org/70918) (owner: 10Gergő Tisza) [22:52:32] tgr: No UW update? [22:52:44] should be there [22:52:47] Oh, I see, a different one [22:53:10] should have been a single changeset? [22:53:14] No no [22:53:15] didn't think of that [22:54:14] It's perfect the way it is [22:54:15] I thought you abandoned the UW update, but it was the wmf20 one [23:54:01] (03PS1) 10Gergő Tisza: Fix UploadWizard logging some more, maybe [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161137 [23:54:10] marktraceur: ^^ [23:54:48] "maybe" fun [23:55:02] EventLogging is borked on mw-vagrant, UW on beta commons is borked completely - testing stuff in production is fun [23:55:33] (03CR) 10MarkTraceur: [C: 032] Fix UploadWizard logging some more, maybe [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161137 (owner: 10Gergő Tisza) [23:55:59] Heh [23:56:00] (03Merged) 10jenkins-bot: Fix UploadWizard logging some more, maybe [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161137 (owner: 10Gergő Tisza) [23:56:06] if I run mw.loader.using('schema.UploadWizardStep') the logging starts working, so it's some trivial setup issue [23:56:26] but it's hard to figure out blind what exactly [23:57:23] I'm cloning MV's EL setup now, so that hopefully works [23:57:55] Cool. [23:58:38] except it won't because MV lazy-loads dependencies :(