[00:01:26] eh, wtf [00:01:43] Still no luck? [00:01:48] let me fix beta and vagrant first, UW logging can wait another day [00:01:49] Maybe it's time to wait for tomorrow. [00:01:51] Yeah [00:02:08] Honestly I shouldn't have taken Roan's patch either, but here we are [00:02:24] 3MediaWiki extensions / 3MultimediaViewer: mediaviewer icons inconsistent and not using Wikifont assets - 10https://bugzilla.wikimedia.org/65919 (10Jared Zimmerman (WMF)) 5NEW>3RESO/INV [00:42:21] 3MediaWiki extensions / 3UploadWizard: Special:UploadWizard is 503 on beta labs commons - 10https://bugzilla.wikimedia.org/70942#c2 (10Tisza Gergő) MW-Vagrant with UW master and core master gives Fatal error: $this is null in /vagrant/mediawiki/includes/media/Bitmap.php on line 406 [00:47:20] 3MediaWiki extensions / 3UploadWizard: Special:UploadWizard is 503 on beta labs commons - 10https://bugzilla.wikimedia.org/70942#c3 (10Bryan Davis) (In reply to Chris McMahon from comment #1) > Seems to have started doing this 16 Sept (In reply to Tisza Gergő from comment #2) > MW-Vagrant with UW master and... [00:48:36] 3MediaWiki extensions / 3UploadWizard: Special:UploadWizard is 503 on beta labs commons - 10https://bugzilla.wikimedia.org/70942#c4 (10Tisza Gergő) Caused by https://gerrit.wikimedia.org/r/#/c/158926/ Probably tested on a stable branch, the function changed to non-static a few months ago: https://gerrit.wiki... [00:49:51] 3MediaWiki extensions / 3UploadWizard: Special:UploadWizard is 503 on beta labs commons - 10https://bugzilla.wikimedia.org/70942#c5 (10Tisza Gergő) nvm, Bryan is right, git blame reports author times. [00:53:07] (03PS1) 10Catrope: Followup f695323: correct path for ef26c7a [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161147 [00:54:13] (03CR) 10Krinkle: [C: 032] Followup f695323: correct path for ef26c7a [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161147 (owner: 10Catrope) [00:55:36] (03Merged) 10jenkins-bot: Followup f695323: correct path for ef26c7a [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161147 (owner: 10Catrope) [01:08:17] (03PS1) 10Gergő Tisza: Fix static call of non-static function [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161151 (https://bugzilla.wikimedia.org/70942) [04:55:06] 3MediaWiki extensions / 3TimedMediaHandler: Allowed memory size of 183500800 bytes exhausted (tried to allocate 2018670161 bytes). - 10https://bugzilla.wikimedia.org/53840#c4 (10Ryan Kaldari) 5RESO/INV>3REOP p:5Low>3High I get the same error any time I try to upload an OGG audio file via https://comm... [05:01:37] 3MediaWiki extensions / 3TimedMediaHandler: Allowed memory size of 183500800 bytes exhausted (tried to allocate 2018670161 bytes). - 10https://bugzilla.wikimedia.org/53840#c5 (10Ryan Kaldari) The error seems to happen in _decodeBareCommentsHeader(), which parses the comments header in the ogg file. This head... [05:06:53] 3MediaWiki extensions / 3TimedMediaHandler: Allowed memory size of 183500800 bytes exhausted (tried to allocate 2018670161 bytes). - 10https://bugzilla.wikimedia.org/53840#c6 (10Ryan Kaldari) I think what's happening is that the function is choking when trying to parse the encoded COVERART comment, which is... [05:26:33] (03PS1) 10Kaldari: Protect against exceeding memory errors when parsing Ogg files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161174 (https://bugzilla.wikimedia.org/53840) [05:26:53] (03CR) 10jenkins-bot: [V: 04-1] Protect against exceeding memory errors when parsing Ogg files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161174 (https://bugzilla.wikimedia.org/53840) (owner: 10Kaldari) [05:30:57] (03PS2) 10Kaldari: Protect against exceeding memory errors when parsing Ogg files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161174 (https://bugzilla.wikimedia.org/53840) [05:31:10] (03CR) 10jenkins-bot: [V: 04-1] Protect against exceeding memory errors when parsing Ogg files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161174 (https://bugzilla.wikimedia.org/53840) (owner: 10Kaldari) [05:33:13] (03PS3) 10Kaldari: Protect against exceeding memory errors when parsing Ogg files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161174 (https://bugzilla.wikimedia.org/53840) [05:35:58] (03CR) 10jenkins-bot: [V: 04-1] Protect against exceeding memory errors when parsing Ogg files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161174 (https://bugzilla.wikimedia.org/53840) (owner: 10Kaldari) [05:38:42] (03PS4) 10Kaldari: Protect against exceeding memory errors when parsing Ogg files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161174 (https://bugzilla.wikimedia.org/53840) [05:41:26] (03PS5) 10Kaldari: Protect against exceeding memory errors when parsing Ogg files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161174 (https://bugzilla.wikimedia.org/53840) [05:41:39] (03CR) 10jenkins-bot: [V: 04-1] Protect against exceeding memory errors when parsing Ogg files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161174 (https://bugzilla.wikimedia.org/53840) (owner: 10Kaldari) [05:45:36] 3MediaWiki extensions / 3TimedMediaHandler: Allowed memory size of 183500800 bytes exhausted (tried to allocate 2018670161 bytes). - 10https://bugzilla.wikimedia.org/53840#c8 (10Ryan Kaldari) For some reason, if I try to set any kind of size limit on the comments (even 100 MB), it causes several unit tests t... [06:05:13] (03CR) 10Gilles: [C: 032] Fix static call of non-static function [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161151 (https://bugzilla.wikimedia.org/70942) (owner: 10Gergő Tisza) [06:05:46] (03Merged) 10jenkins-bot: Fix static call of non-static function [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161151 (https://bugzilla.wikimedia.org/70942) (owner: 10Gergő Tisza) [06:24:20] 3MediaWiki extensions / 3TimedMediaHandler: Allowed memory size of 183500800 bytes exhausted (tried to allocate 2018670161 bytes). - 10https://bugzilla.wikimedia.org/53840#c9 (10Ryan Kaldari) In the meantime, I was able to upload the Ogg file by removing the cover art from the file. [06:29:00] (03CR) 10Gilles: "I'm pretty sure that the test files used by the unit test are running into your new condition, and as a result the expect metadata they co" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161174 (https://bugzilla.wikimedia.org/53840) (owner: 10Kaldari) [06:34:51] (03CR) 10Kaldari: "The test files it's failing on are only 11 KB and 300 KB, so I guess $comment_length is just not accurate." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161174 (https://bugzilla.wikimedia.org/53840) (owner: 10Kaldari) [06:37:56] (03CR) 10Kaldari: "oops, $comment_length is an array. Doh!" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161174 (https://bugzilla.wikimedia.org/53840) (owner: 10Kaldari) [06:42:36] (03PS6) 10Kaldari: Protect against exceeding memory errors when parsing Ogg files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161174 (https://bugzilla.wikimedia.org/53840) [06:45:36] 3MediaWiki extensions / 3TimedMediaHandler: Allowed memory size of 183500800 bytes exhausted (tried to allocate 2018670161 bytes). - 10https://bugzilla.wikimedia.org/53840#c10 (10Ryan Kaldari) Got the unit tests passing with the fix. It's now skipping any comments that are longer than 10 KB, which should be... [07:24:32] (03CR) 10Gilles: "Actually, I've just realized that this change is in the middle of File_ogg, which has been packaged separately: https://github.com/pear/Fi" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/161174 (https://bugzilla.wikimedia.org/53840) (owner: 10Kaldari) [07:44:36] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer embed drop-down menu stupidity - 10https://bugzilla.wikimedia.org/70918 (10Tisza Gergő) 5PATC>3RESO/FIX [09:15:08] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer should use mediawiki-ui styling - 10https://bugzilla.wikimedia.org/70990 (10Tisza Gergő) 3NEW p:3Unprio s:3minor a:3None Especially the reuse panel which uses OOUI's very different styles now, but there are other things to fix as well. [09:16:06] 3MediaWiki extensions / 3MultimediaViewer: mmv dialog Embed panel glitches - 10https://bugzilla.wikimedia.org/64206#c1 (10Tisza Gergő) The first point is bug 67835 and bug 70915. Opened bug 70990 about the third point. [09:16:21] 3MediaWiki extensions / 3UploadWizard: Special:UploadWizard is 503 on beta labs commons - 10https://bugzilla.wikimedia.org/70942 (10Andre Klapper) p:5Unprio>3High [09:18:51] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer embed text area cannot be resized in-browser - 10https://bugzilla.wikimedia.org/70915#c4 (10Tisza Gergő) I am inclined to close this in favor of bug 64713. I agree that it would be good to be able to read the text without copypasting it into a notebook.... [09:19:36] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer embed text area cannot be resized in-browser - 10https://bugzilla.wikimedia.org/70915#c5 (10Tisza Gergő) Um, that's bug 67835. [09:21:52] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer embed text area is too small, should be made taller/larger - 10https://bugzilla.wikimedia.org/70914 (10Tisza Gergő) [09:21:52] 3MediaWiki extensions / 3MultimediaViewer: It should be possible to read boilerplate texts without copypasting them into another application - 10https://bugzilla.wikimedia.org/67835 (10Tisza Gergő) [09:46:51] 3MediaWiki extensions / 3UploadWizard: Special:UploadWizard is 503 on beta labs commons - 10https://bugzilla.wikimedia.org/70942 (10Tisza Gergő) 5PATC>3RESO/FIX [09:51:26] gi11es: adding error logging to UW before the end of WLM slipped through the cracks [09:51:40] mind if I add a scope increase card for that? [09:51:53] sure, go ahead [13:00:15] (03PS1) 10Gergő Tisza: Fix UploadWizard logging for reals [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161229 [13:03:21] (03CR) 10Gergő Tisza: "Data collection should be fixed now, although that will not make past NULLs go away." [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/160785 (owner: 10Gergő Tisza) [13:04:40] gi11es: can you review https://gerrit.wikimedia.org/r/#/c/161229/ today? I would like to backport it [13:15:02] gi11es: the public tsv files on stat1 are owned by you and are chmod 644 [13:15:16] can you set a more permissive umask? [13:15:40] hm, I guess that should go into the generation script [13:16:21] 3MediaWiki extensions / 3TimedMediaHandler: Allowed memory size of 183500800 bytes exhausted (tried to allocate 2018670161 bytes). - 10https://bugzilla.wikimedia.org/53840 (10Andre Klapper) [13:24:06] 3MediaWiki / 3Uploading: Unable to upload OGV, Wikipedia thinks it is OGX - 10https://bugzilla.wikimedia.org/67335#c6 (10Andre Klapper) 5UNCO>3RESO/WOR Unfortunately closing this report as no further information has been provided. supervegetauk2001: Please feel free to reopen this report if you can prov... [13:26:51] 3MediaWiki / 3Uploading: When $wgAllowCopyUploads and $wgCopyUploadsFromSpecialUpload are true, the filename of the source is no longer copied into the "destination filename" field - 10https://bugzilla.wikimedia.org/59095#c2 (10Andre Klapper) 5NEW>3RESO/WOR Unfortunately closing this report as no further... [13:27:21] 3MediaWiki / 3File management: simultaneous thumbnailing of images with external programs - 10https://bugzilla.wikimedia.org/16346#c2 (10Andre Klapper) 5UNCO>3RESO/WOR Unfortunately closing this report as no further information has been provided. Michael: Please feel free to reopen this report if you ca... [13:27:21] 3MediaWiki / 3File management: Allow images in galleries to have their own borders - 10https://bugzilla.wikimedia.org/16457 (10Andre Klapper) p:5Low>3Lowest [13:42:55] (03CR) 10Gergő Tisza: "Removing null rows does not fix the graph." [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/160785 (owner: 10Gergő Tisza) [14:32:01] (03CR) 10Gergő Tisza: "The graph config itself is fine; it works with the absolute datasource as expected." [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/160785 (owner: 10Gergő Tisza) [14:58:15] (03PS1) 10Pginer: Adjust metadata panel colors [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161242 [15:22:13] (03PS8) 10MarkTraceur: Make the reuse button part of the canvas [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160041 [15:22:27] (03PS13) 10MarkTraceur: Make "more details" button bigger 'n' prettier [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 [15:52:19] (03PS2) 10Gergő Tisza: Add relative timeseries [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/160785 [15:53:10] https://gerrit.wikimedia.org/r/#/c/160785/1..2/datasources/uw_funnel_relative.json -> took barely more than a half day [15:53:18] debugging limn is a real charmer [16:35:06] (03PS2) 10Brian Wolff: Fix API help for query=videoinfo [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/157619 (https://bugzilla.wikimedia.org/55744) [16:36:30] bawolff isn't on IRC? :( [16:37:24] Gah, bawolfffff [16:52:54] (03PS6) 10MarkTraceur: Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 [16:53:23] (03CR) 10jenkins-bot: [V: 04-1] Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [17:00:00] (03CR) 10Gilles: [C: 032] Fix UploadWizard logging for reals [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161229 (owner: 10Gergő Tisza) [17:00:40] (03Merged) 10jenkins-bot: Fix UploadWizard logging for reals [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161229 (owner: 10Gergő Tisza) [17:07:02] tgr: hat chmod value do you want? [17:07:06] *what [17:11:27] (03CR) 10Gilles: [C: 032 V: 032] "Tested locally. I'll take care of deploying it." [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/160785 (owner: 10Gergő Tisza) [17:12:21] (03CR) 10Gilles: "Deployed" [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/160785 (owner: 10Gergő Tisza) [17:14:23] (03PS7) 10MarkTraceur: Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 [17:14:26] (03CR) 10jenkins-bot: [V: 04-1] Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [17:14:55] I don't know why Jenkins dislikes that merge [17:15:07] (03PS9) 10MarkTraceur: Make the reuse button part of the canvas [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160041 [17:15:13] (03PS14) 10MarkTraceur: Make "more details" button bigger 'n' prettier [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 [17:16:03] bawolff!!! [17:16:06] (03PS8) 10MarkTraceur: Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 [17:16:21] OK FINALLY. [17:16:37] !!! [17:16:56] gi11es, tgr, the download/share/more details patches should all be set to review [17:16:59] (03CR) 10jenkins-bot: [V: 04-1] Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [17:17:02] I hate CSS for the record [17:17:05] Oh fuck you jenkins [17:18:14] bawolff: if you could take a look at my latest response here: https://bugzilla.wikimedia.org/show_bug.cgi?id=67525 that would be swell, that change has been blocked for a while [17:18:48] (03PS9) 10MarkTraceur: Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 [17:19:04] Oh sorry, must of missed the email notification for that bug [17:19:50] I'll update alpha so pginer can play with things [17:20:21] bawolff: could you respond to https://gerrit.wikimedia.org/r/#/c/154868/2/includes/filerepo/file/ArchivedFile.php,cm ? [17:20:24] bawolff: do you have any idea about https://lists.wikimedia.org/pipermail/wikitech-l/2014-September/078643.html ? [17:20:42] pginer: Play with alpha now and it'll be the latest :) [17:20:51] 3MediaWiki / 3Uploading: Generate thumbnails based on buckets - 10https://bugzilla.wikimedia.org/67525#c17 (10Bawolff (Brian Wolff)) For testing VIPS I was using: $wgVipsOptions = array( array( 'conditions' => array( 'mimeType' => 'image/png',... [17:21:43] marktraceur: are you aiming for a SWAT today? [17:22:28] Ehhhhh [17:22:35] Hmm, I should have probably uploaded the example scaled so you could see what I see [17:22:36] gi11es: umask 664 would be fine IMO [17:22:39] We *could*, but I don't think we should [17:22:43] marktraceur: button looks good and consistent with mw-ui styles [17:22:56] pginer: It's actually using the classes now :) [17:22:57] tgr: umm, I'm not sure [17:23:08] I still would recommend removing the tooltip [17:24:07] I’m talking about acceptance criteria #4 in https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/830 [17:24:21] pginer: Noted! [17:24:38] I think I'm going to run some errands but I'll be back in an hour or so to fix the stuff you guys review [17:26:46] (03PS1) 10Gilles: chmod tsvs upon creation [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/161267 [17:27:51] marktraceur: in that case I'll pass on the review today, I want to do UW error logging for today's SWAT [17:27:58] KK [17:28:59] I'll take a look [17:29:54] these icons are still blurry for me on ffox. rub-your-eyes-check-your-eyesight blurry [17:30:07] the X is very sharp in comparison [17:30:30] I know that it seems like it's the browser's fault, but people are likely to complain about that issue [17:30:48] (03CR) 10Gergő Tisza: [C: 032] "Thanks!" [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/161267 (owner: 10Gilles) [17:30:52] (03Merged) 10jenkins-bot: chmod tsvs upon creation [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/161267 (owner: 10Gilles) [17:31:15] Weird. [17:31:25] pginer: ^ [17:31:26] gi11es: I'll play with it when I get back - leave a note? [17:31:30] sure [17:32:39] (03CR) 10Gilles: [C: 04-1] "The new icons still look very blurry on firefox: https://www.dropbox.com/s/3vvialtrtjqs7l4/Screenshot%202014-09-18%2019.31.54.png?dl=0" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [17:33:36] (03CR) 10Gilles: "The pointer is too close to the icon: https://www.dropbox.com/s/pojlwcqpt2a0nit/Screenshot%202014-09-18%2019.33.21.png?dl=0 (firefox)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [17:33:37] Remove background-size: 24px 24px; [17:33:43] That seems to be the culprit [17:34:03] I think we don’t needed, and by removing the CSS from the inspector makes the icon sharp [17:34:27] (03CR) 10Gilles: "Download's contents are centered (firefox), is that on purpose? https://www.dropbox.com/s/7lgyvfton2m6goq/Screenshot%202014-09-18%2019.33." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [17:34:45] I’m not sure which kind of resizing Firefox is trying to attempt but if we can just set the size of the element, that should be enough, right? [17:35:39] elements in the download panel should be left aligned, for scannability. As they were before the splitting [17:36:01] pau, can you add those comments to gerrit? [17:36:26] sure [17:40:26] (03CR) 10Gilles: "The dropdown in download has some height weirdness on hover and sports a horizontal scrollbar at the bottom (firefox): https://dl.dropboxu" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [17:41:42] (03CR) 10Gilles: "The CSS of the attribution area seems to be broken (firefox): https://www.dropbox.com/s/jmw6nggj7swmia1/Screenshot%202014-09-18%2019.40.59" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [17:42:45] (03CR) 10Gilles: [C: 032] Make "more details" button bigger 'n' prettier [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 (owner: 10MarkTraceur) [17:42:59] (03CR) 10Bartosz Dziewoński: "Follow-up: https://gerrit.wikimedia.org/r/#/c/161147/" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/159361 (https://bugzilla.wikimedia.org/70615) (owner: 10Bartosz Dziewoński) [17:43:06] (03CR) 10Gilles: [C: 031] Make "more details" button bigger 'n' prettier [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 (owner: 10MarkTraceur) [17:43:44] (03CR) 10Gilles: [C: 04-1] "The content look way too close to the header's divider, considering the large amount of whitespace available below: https://www.dropbox.co" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160041 (owner: 10MarkTraceur) [17:50:07] 3MediaWiki / 3Uploading: Generate thumbnails based on buckets - 10https://bugzilla.wikimedia.org/67525#c18 (10Bawolff (Brian Wolff)) Created attachment 16513 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16513&action=edit My test screenshot file, 800px normal (no bucket) scaling with image magick 8... [17:53:09] (03CR) 10Pginer: "The button looks good and consistent, but I have several comments on other elements:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 (owner: 10MarkTraceur) [17:54:21] 3MediaWiki / 3Uploading: Generate thumbnails based on buckets - 10https://bugzilla.wikimedia.org/67525#c19 (10Bawolff (Brian Wolff)) Created attachment 16514 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16514&action=edit 800px chained scaling using image magick Using chaining (Note, only 1 interme... [17:57:06] 3MediaWiki / 3Uploading: Generate thumbnails based on buckets - 10https://bugzilla.wikimedia.org/67525#c20 (10Bawolff (Brian Wolff)) Created attachment 16515 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16515&action=edit 800px chained, scaling using vips Using chained with vips (1280->1024->800).... [18:00:33] (03CR) 10Pginer: "- the attribution panel seems broken. The button group for selecting format don't look as such, and the sub-panel should not cover the oth" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 (owner: 10MarkTraceur) [18:01:24] Am I commenting on the wrong patchset? [18:01:59] tgr: Really hacky solution to the hook into parser thing, is that you could look if the parser options have the limit report enabled [18:06:41] (03CR) 10Pginer: "I pasted these comments in the "button parchset" but I'm coping them here since this may be the correct patchset:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160041 (owner: 10MarkTraceur) [18:06:49] bawolff: that's a bit too hacky for comfort I think [18:07:00] could be disabled on 3rd party wikis and so on [18:07:04] yeah probably [18:07:31] I actually don't think the limit reporting thing is configurable (right now), but no guarantee that won't change [18:17:23] Would hooking into ParserAfterTidy, then checking that $parser->getTitle()->getNamespace() == NS_FILE && !$parser->getOptions()->getIsSectionPreview() && !$parser->getOptions()->getInterfaceMessage() [18:17:28] be a little better? [18:17:31] still super hacky [18:20:37] (03CR) 10Gergő Tisza: "I clobbered this somehow with the followup. Will redo." [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/160682 (owner: 10Gergő Tisza) [18:20:58] tgr: Keeping in mind that (excepting things from $wgOut->addWikiText, but that usually sets the interface flag), that adding categories to non-pages usually has no affect, so some false positives wouldn't be horrible [18:21:12] that still feels icky [18:25:51] 3MediaWiki extensions / 3TimedMediaHandler: Expose media metadata consistently to API through query=imageinfo and/or query=videoinfo - 10https://bugzilla.wikimedia.org/55941 (10Bawolff (Brian Wolff)) 5PATC>3RESO/FIX [18:27:36] (03PS1) 10Gergő Tisza: Redo lost commit for overview fix [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/161285 [18:37:20] (03CR) 10Gilles: [C: 032] Redo lost commit for overview fix [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/161285 (owner: 10Gergő Tisza) [18:37:47] (03Merged) 10jenkins-bot: Redo lost commit for overview fix [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/161285 (owner: 10Gergő Tisza) [18:39:20] bawolff: did you see my comment on https://gerrit.wikimedia.org/r/#/c/154868/ ? [18:39:34] not yet [18:39:45] ok [18:39:51] also, do you think that's even a good idea? [18:40:06] (the whole implementing global image review) [18:41:38] I'd rather just fix ArchiveFile to not be super sketchy [18:42:33] But that's not directly related to your patch, so I could do that as a separate change [18:43:38] Your suggested thing with turning false to null might be a good idea as a sanity thing in addition [18:44:05] ok [18:44:31] * legoktm does [18:47:06] (03PS1) 10Gergő Tisza: Dedicated page for UW funnel analysis [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/161290 [18:50:22] bawolff: I don't think getInterfaceMessage is reliable, not all system messages are in the interface language [18:50:39] Commons AFAIK has a bunch of custom $wgForceUIMsgAsContentMsg settings [18:51:24] I tried ParserAfterTidy with the section preview filter, and ended up with five of each category per page [18:51:51] so I think those categories can end up being tracked even if something else than the main content is being parsed [18:52:47] getInterfaceMessage definitely is not reliable for it, but it will catch a bunch of cases [18:53:46] Most importantly, things added to the file page by OutputPage [18:53:56] if it's so hard to find a place for manipulating parser output of the main content, then I think a new hook makes sense [18:54:13] I think you're probably right [18:54:22] I found a bunch of old bugzilla tickets where people try to use ParserAfterTidy and don't understand what happens [19:36:06] Ugh, you guys did a lot of review [19:36:10] * marktraceur trudges on [19:43:50] (03CR) 10MarkTraceur: "Padding added to the panes so they aren't so close to the header. Patchset incoming. Also played with the size of the panel so download do" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160041 (owner: 10MarkTraceur) [19:43:59] (03PS10) 10MarkTraceur: Make the reuse button part of the canvas [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160041 [19:44:48] (03CR) 10MarkTraceur: "Oh, also the opacity thing should be working now." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160041 (owner: 10MarkTraceur) [19:45:13] (03PS15) 10MarkTraceur: Make "more details" button bigger 'n' prettier [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 [19:45:36] (03CR) 10MarkTraceur: "Rebased. Most of Pau's comments apply to the parent or child patches." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 (owner: 10MarkTraceur) [19:47:25] (03PS1) 10Gergő Tisza: Fix UploadWizard logging some more, maybe [extensions/UploadWizard] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161336 [19:48:28] (03CR) 10jenkins-bot: [V: 04-1] Fix UploadWizard logging some more, maybe [extensions/UploadWizard] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161336 (owner: 10Gergő Tisza) [19:49:20] (03PS2) 10Gergő Tisza: Fix UploadWizard logging some more, maybe Change-Id: Ib6f722dfe904f3107041ef2c52a51eae5eeb9571 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/862 (cherry picked from commit e2eb1f793a7496974291d3bda984001ee3b5c570) [extensions/UploadWizard] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161336 [19:49:47] (03CR) 10jenkins-bot: [V: 04-1] Fix UploadWizard logging some more, maybe Change-Id: Ib6f722dfe904f3107041ef2c52a51eae5eeb9571 Mingle: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/862 (cherry picked from commit e2eb1f793a7496974291d3bda984001ee3b5c570) [extensions/UploadWizard] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161336 (owner: 10Gergő Tisza) [19:50:39] (03CR) 10Gergő Tisza: [C: 032 V: 032] "npm tests are missing in this branch." [extensions/UploadWizard] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161336 (owner: 10Gergő Tisza) [20:03:57] (03PS1) 10Gergő Tisza: Fix UploadWizard logging for reals [extensions/UploadWizard] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161343 [20:04:25] (03CR) 10jenkins-bot: [V: 04-1] Fix UploadWizard logging for reals [extensions/UploadWizard] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161343 (owner: 10Gergő Tisza) [20:05:51] (03CR) 10Gergő Tisza: [C: 032 V: 032] "npm failure is due to branch mismatch" [extensions/UploadWizard] (wmf/1.24wmf21) - 10https://gerrit.wikimedia.org/r/161343 (owner: 10Gergő Tisza) [20:08:00] (03CR) 10MarkTraceur: "Things fixed in the next patchset:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [20:08:28] (03PS10) 10MarkTraceur: Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 [20:37:28] (03PS1) 10MarkTraceur: Move dialogs to the left, make arrows point right [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161348 [22:21:03] (03PS1) 10Gergő Tisza: Log errors [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/161363 [23:38:28] bawolff: woo thanks!