[00:29:50] marktraceur: late in the day, but any chance this is an MMV bug? https://bugzilla.wikimedia.org/show_bug.cgi?id=71210 [00:29:58] * marktraceur looks [00:31:05] chrismcmahon: I don't see the issue on that page, where is the next button [01:03:38] 3MediaWiki / 3Uploading: Can't upload file with non-ASCII name (eg cyrillic) on Windows host - 10https://bugzilla.wikimedia.org/1780 (10Sumana Harihareswara) [09:50:34] (03PS1) 10Pginer: Show initially part of the below the fold area [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162560 [09:50:36] (03CR) 10Gilles: QA: Refactored performance tests (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162469 (owner: 10Dduvall) [09:52:26] (03PS2) 10Pginer: Show initially part of the below the fold area [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162560 [09:56:33] (03CR) 10Gilles: [C: 032] Add shadow when scrolling panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162281 (owner: 10Pginer) [09:57:11] (03Merged) 10jenkins-bot: Add shadow when scrolling panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162281 (owner: 10Pginer) [09:59:48] (03PS3) 10Gilles: Show initially part of the below the fold area [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162560 (owner: 10Pginer) [10:00:17] (03CR) 10Gilles: [C: 032] Show initially part of the below the fold area [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162560 (owner: 10Pginer) [10:00:56] (03Merged) 10jenkins-bot: Show initially part of the below the fold area [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162560 (owner: 10Pginer) [10:06:55] (03CR) 10Gilles: [C: 032] Fix missing tutorial steps in the funnel logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162499 (owner: 10Gergő Tisza) [10:09:57] (03Merged) 10jenkins-bot: Fix missing tutorial steps in the funnel logging [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162499 (owner: 10Gergő Tisza) [10:12:01] (03CR) 10Gilles: [C: 031] Style fixes for the UI changes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 (owner: 10MarkTraceur) [10:12:27] pginer: did marktraceur fix all the things you wanted on his changesets? [10:12:48] (03CR) 10Gilles: [C: 031] Make "more details" button bigger 'n' prettier [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 (owner: 10MarkTraceur) [10:13:19] Most of them. I think there is only one detail remaining. [10:13:34] https://gerrit.wikimedia.org/r/#/c/161996/ is the one you need to apply to check all the things [10:13:39] what do you think is left to do? [10:13:57] Keeping the download panel open when going through a sequence of images. [10:14:05] that works for me now [10:14:09] can you check if it does for you? [10:14:10] I’m ok with that being a separate patchset/story for the future [10:14:18] I wa trying in alpha [10:14:22] was [10:14:38] I can put the latest version on alpha now if that's easier for you [10:14:58] I can check the patchset locally [10:15:11] alright [10:15:18] all I'd do on alpha is git pull that changeset anyway [10:15:44] ok, thanks. that will be useful to try a wider variety of images [10:16:41] done, alpha should have the latest now [10:23:19] I found an issue. Which patchset should I comment that on? [10:23:34] doesn't really matter, the one I've linked to is fine [10:23:37] they're all interdependent anyway [10:24:01] When you click on the “share” icon, you cannot close the panel by clicking outside of it. It works fine if you previously clicked the “download” icon. [10:24:49] ah, that explains why marktraceur couldn't repro, it has to be the first thing you do, right? [10:25:03] yes [10:26:55] hmmm I foresee a small visual issue now that your 12px above the fold changeset has been merged. we can't see it here because I haven't rebased those changesets, but it means that when opening the share/embed dialog, its bottom will always be cut off [10:27:12] behind the scroll panel [10:29:25] have you tried that? [10:29:37] I applied the following and I don’t see the issue: $(".mw-mmv-above-fold").css("height",72).css("min-height",72) [10:30:00] (but I’m not sure if that is the only change my modification on theLESS code has impact to) [10:30:36] oh, it shrinks the height too, I missed that [10:30:41] I thought it just scrolled it higher [10:30:52] all is fine, then [10:31:33] The impact it may have is with the down chevron overlapping a long credit description. [10:33:30] It is still somewhat readable an the user can click on it (or scroll) to view the whole text. [10:34:23] we may want to go ahead and remove the pointing down chevron (or wait until we implement the ellipsis to expand compacted texts). [10:41:27] (03CR) 10Pginer: "Some more comments:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161996 (owner: 10MarkTraceur) [11:13:34] (03PS1) 10Pginer: Layout adjustments to reduce overlap with chevron [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162566 [11:14:07] I made some small adjustments to reduce the mentioned issue [14:03:04] (03CR) 10Gilles: [C: 032] Layout adjustments to reduce overlap with chevron [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162566 (owner: 10Pginer) [14:03:52] (03Merged) 10jenkins-bot: Layout adjustments to reduce overlap with chevron [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162566 (owner: 10Pginer) [14:07:45] tgr: can you review https://gerrit.wikimedia.org/r/#/c/157157/ one last time? the follow-up cards were files last week [14:08:23] tgr: same for https://gerrit.wikimedia.org/r/#/c/162227/ where I've addressed your concern [14:09:56] marktraceur: are you around? I'm about to look into fixing the last issues pginer brought up. just want to make sure you're not already online and working on them [14:12:00] I'm here, yeah, but not working [14:12:05] About to skip away for breakfast [14:12:07] hmmm weekly engineering email states that fabrice is awway today, but g+ calendar invite shows him as a "yes" [14:12:18] I wonder if he just accepted every instance, though [14:12:23] I thought he was back by today [14:12:31] He definitely accepted every instance. [14:12:38] so, we can't tell :) [14:12:42] Of course not [14:12:48] That would be no fun, gi11es [14:12:53] Way too easy. [14:14:05] Eloquence: FYI, see above, we don't know if fabrice is really going to be back for today's meeting [14:14:58] ah, his autoresponse email from 9 days ago does state he'd be back today [14:15:03] but the engineering email is more recent [14:15:20] mystery... [14:30:27] marktraceur: seems like the logging events were overlooked for the new dialogs. I'll start with fixing that [14:30:46] right now it seems like only the use this file close event still works and it's applied to share/embed [14:31:05] makes sense to keep using it, we'll need a new one for download, though [14:44:32] (03PS14) 10Gilles: Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [14:45:11] (03CR) 10Gilles: "Fixed the ActionLogger events for open/closing the 2 dialogs" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [14:58:07] Cool [15:02:42] (03PS15) 10Gilles: Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [15:03:13] (03CR) 10Gilles: "Fixed the bug found by Pau where clicking on the background would close "use this file" if it was the first dialog to be open." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [15:05:56] (03PS16) 10Gilles: Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [15:06:27] (03CR) 10Gilles: "Implemented Pau's request whereby clicking on the navigation arrows doesn't close the dialogs." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [15:07:16] (03PS5) 10Gilles: Move dialogs to the left, make arrows point right [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161348 (owner: 10MarkTraceur) [15:08:10] (03PS10) 10Gilles: Style fixes for the UI changes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 (owner: 10MarkTraceur) [15:08:58] (03PS7) 10Gilles: Move focus event handlers to mmv.ui.Element [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161996 (owner: 10MarkTraceur) [15:11:23] pginer: your latest concerns should be addressed and testable on alpha [15:13:47] yes, everything seems working now. Thanks [15:21:17] perfect, then alpha will be the demo for the meeting and we can swat this if the PM is happy [15:23:14] marktraceur: you'll need to review my changes to https://gerrit.wikimedia.org/r/160814 [15:29:33] KK [15:36:28] (03CR) 10Gergő Tisza: [C: 032] "Tested, works fine." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162227 (https://bugzilla.wikimedia.org/71160) (owner: 10Gilles) [15:36:46] I'll do it after our meetings [15:37:06] (03Merged) 10jenkins-bot: Make options of a custom campaign field parseable [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/162227 (https://bugzilla.wikimedia.org/71160) (owner: 10Gilles) [17:28:38] (03CR) 10Dduvall: QA: Refactored performance tests (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162469 (owner: 10Dduvall) [18:43:25] All right, meetings over (FOR NOWWWW) so I'm going to go find noms [21:03:37] (03CR) 10MarkTraceur: [C: 031] Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [21:04:32] All right, I can't reproduce the download dialog bug [21:04:48] Oh, there it is, you have to close the whole viewer [21:04:55] * marktraceur investigates [21:06:19] Fast fix. [21:06:20] (03PS1) 10MarkTraceur: Fix bug where download dialog doesn't unattach [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162760 [21:06:24] I'll start merging stuff now [21:06:49] So we can make the cut tomorrow. [21:06:57] Spam ahoy [21:07:46] (03CR) 10MarkTraceur: [C: 032] "Basically trivial change, needed for UX improvements" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162760 (owner: 10MarkTraceur) [21:08:49] (03CR) 10MarkTraceur: [C: 032] "+1'd already, patch 7 is a rebase" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161996 (owner: 10MarkTraceur) [21:09:13] (03CR) 10MarkTraceur: [C: 032] "+1'd already, patch 10 is a rebase" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 (owner: 10MarkTraceur) [21:09:48] (03CR) 10MarkTraceur: [C: 032] "+1'd already, patch 5 is a rebase" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161348 (owner: 10MarkTraceur) [21:10:25] (03CR) 10MarkTraceur: [C: 032] "+2ing because gilles already +1'd my patchsets and I'm in favour of his changes. Pau's concerns seem to have been addressed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [21:10:50] (03CR) 10MarkTraceur: [C: 032] "Translating +1 to +2 to get this string of commits merged" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 (owner: 10MarkTraceur) [21:11:28] (03CR) 10MarkTraceur: [C: 032] "First patch in a string, +2ing because Gilles has +1ed and all concerns have been addressed in the dependent patches." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160041 (owner: 10MarkTraceur) [21:11:33] This is going to be fun [21:11:52] fabriceflorin, heads up, there will be 7 patches heading to beta over the next half hour or so [21:12:06] Very exciting times. [21:12:12] (03Merged) 10jenkins-bot: Make the reuse button part of the canvas [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160041 (owner: 10MarkTraceur) [21:12:16] Also, fabriceflorin, I was hoping we could set up a bouncer for you. [21:12:20] (03Merged) 10jenkins-bot: Make "more details" button bigger 'n' prettier [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/158660 (owner: 10MarkTraceur) [21:12:22] (03Merged) 10jenkins-bot: Make the download pane into its own dialog [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/160814 (owner: 10MarkTraceur) [21:12:32] Hm, maybe faster than a half hour [21:14:19] Did I murder Jenkins [21:14:51] (03Merged) 10jenkins-bot: Move dialogs to the left, make arrows point right [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161348 (owner: 10MarkTraceur) [21:14:53] (03Merged) 10jenkins-bot: Style fixes for the UI changes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161496 (owner: 10MarkTraceur) [21:14:56] Nope! [21:15:00] (03Merged) 10jenkins-bot: Move focus event handlers to mmv.ui.Element [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/161996 (owner: 10MarkTraceur) [21:15:04] (03Merged) 10jenkins-bot: Fix bug where download dialog doesn't unattach [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162760 (owner: 10MarkTraceur) [21:15:20] OK, fabriceflorin, ten minutes from now those changes will definitely be on betawikis [21:16:39] marktraceur: Good news about fixing the download dialog bug and the other patches! Let me know when they are ready to test. [21:16:55] Literally the next ten minutes. [21:17:32] OK, will check them at 2:27pm PT. [21:17:49] Is this a good place to test? http://en.wikipedia.beta.wmflabs.org/wiki/Lightbox_demo [21:18:05] Should be [21:18:15] Unless something goes horribly, terribly wrong [21:18:17] * marktraceur knocks on wood [21:24:22] tgr: i finally got access to stat1003! think you could point me toward the right database for mmv metrics? [21:25:04] marktraceur: As discussed, I added this card for removing the duplicate ‘More details’ panel in the current sprint: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/909 [21:26:08] Right [21:26:19] I can probably knock that out right now, and gi11es can merge 'er tonight [21:26:27] Super. [21:27:13] marktraceur: What do you mean about setting up a ‘bouncer’ for me? [21:28:21] fabriceflorin: You may notice that a lot of users never log off of IRc [21:28:25] IRC* [21:28:32] Sometimes that's because they have clients always logged in (like me) [21:28:47] But a lot of people use a special software that runs on a server, that they can connect to with their local clientsn [21:29:04] That software is called a "bouncer", named so because it bounces messages from the server to you. [21:29:20] Ah, thanks for explaining this. [21:29:38] No problem [21:29:51] So...Chad has actually been working on a solution for us [21:30:00] So the solution I was going to test on you may not be our best option [21:30:11] I'll ask him if he's ready for others yet. [21:31:01] Yes, that would be cool. Though I have noticed that my new Mifi device is a lot better than the previous one, so I can now stay on IRC a lot longer while on the bus, even in low-bandwidth areas. [21:35:53] marktraceur: I am testing the new changes on beta now, and have a question about the ‘More details’ button. It seems to be a bit different in style from Pau’s mockups on the original card, in two ways: 1) the blue background is a lot lighter, making it look like it’s disabled; 2) the font seems to be bolder. Did the two of you discuss those stylistic changes? If not, you might consider a closer implementation to the [21:35:53] mockups, as shown on this Mingle ticket: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/830 [21:36:32] He specifically told me to use the mw-ui classes and I did [21:37:40] marktraceur: OK, let’s check with him in the AM, to make sure it works for him before we roll out to all the wikis next week. I’ll send an email so he can check it overnite. [21:44:54] (03PS1) 10MarkTraceur: Remove duplicate details link in metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162765 [21:45:10] marktraceur: The Download and Share functions work well for me. The only tweak I would recommend would be to display the first part of the attribution credits when you click on ‘You need to attribute the author’, then ‘Plain’ or ‘HTML’ tabs (instead of showing the last part of the credit, as seems to be the case now). [21:45:22] Shablam. [21:45:32] Oh, hm [21:45:58] fabriceflorin: I don't *think* we can control that but it's something we've had on our wishlist I think [21:46:17] I guess we could do a fake text selection that selected the first bit and then deselected. [21:46:30] fabriceflorin: Want to make a card for that? [21:46:31] :D [21:46:42] So, when I click on ‘Plain’ or ‘HTML’, I see this: “ August_2013).jpg#mediaviewer/File:The_Bridge_(August_2013).jpg “ … when I would expect to see this: "The Bridge (August 2013)" by Frank Schulenburg … “ [21:46:52] Right [21:46:58] Sure, happy to file it as a bug. [21:48:00] Other than that, I think we [21:48:11] … we’re in good shape. [21:48:27] Cool beans [21:48:33] We'll see it on mw.o tomorrow [21:49:11] I just accepted the download card #841, cannot reproduce the issue we experienced this morning. [21:49:20] Cool [21:53:27] marktraceur: I’m also experiencing a usability issue when I try to close the download and share panels. If I try to click outside these panels to close them, sometimes I accidentally open the original image in a separate tab, if my cursor is over the image. To address this, I would like to ask Pau to think of a more intuitive solution for closing the panels, like a ‘close’ X button inside the panels. [21:53:43] ...wait [21:53:50] We were supposed to have fixed that. [21:54:47] marktraceur: Perhaps this issue came back after we added the ‘enlarge’ feature when you hover the image? [21:54:48] fabriceflorin: It definitely shouldn't be doing that [21:54:59] No, I specifically made sure that wouldn't happen [21:55:02] Are you using Chrome? [21:55:26] No, I can't repro in Chrome either [21:55:29] Yes, Chrome version 37 on a Mac. [21:55:34] fabriceflorin: Are you clicking outside the panel, or double-clicking? [21:55:51] I am just clicking outside the panel. [21:55:56] Because if you're double-clicking that's user error. Maybe user error we should anticipate, but user error nonetheless...oh. [21:55:59] Hrm [21:56:03] That doesn't make any sense [21:56:48] It only happens when the Share/Embed panel is up, not with the Download panel. [21:57:20] fabriceflorin: Given I can't repro in Chrome, I'm going to tentatively say it's a non-issue but if we can figure out what it is then we can deal with it [21:57:33] So if the Embed panel is open, I see the cursor turn into a magnifying glass, and clicking on the image takes me directly to the original file in a separate tab. [21:57:42] I definitely don't see that [21:57:48] fabriceflorin: On first load of the lightbox/dialog? [21:58:50] No, that was after browsing very extensively. If I try it on the first load, it appears to work. Let me test a bit more to see when it starts to happen. [21:59:13] Oh, moving with the dialog makes it happen. [21:59:18] OK, we have repro steps, a bug card would be nice [22:00:47] Yeah, if I click on the right arrow to go to the next image with the embed panel open, then I start seeing the magnifying glass cursor. Let me investigate a bit more, and file a bug once I can reproduce it. [22:01:03] I just did by hitting the right button [22:01:08] Should be fine in the instructions [22:01:23] Hm, maybe the right button twice. [22:05:39] Yeah, clicking on the right button doesn’t close the embed panel for me either. But it doesn’t seem as big of an issue as opening up the original file on a separate page, which can be more overwhelming for casual users. [22:10:50] marktraceur : The good news is that I cannot reproduce my earlier issue of going straight to the original file when you click over the image. What I can reproduce is that the magnifier cursor icon appears as soon as I hit the right arrow with the embed panel; but clicking the first time no longer takes me to the original file, I have to click twice for that to happen. [22:11:39] So I will not file a bug for that until I can reproduce it consistently. [22:22:20] marktraceur: FYI, I just filed #911 as a bug for left-aligning attribution credits in the download panel : https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/911 [22:35:55] 3MediaWiki / 3Uploading: Chunked upload of TIFF files - 10https://bugzilla.wikimedia.org/71256 (10jeblad) 3NEW p:3Unprio s:3normal a:3None Created attachment 16576 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16576&action=edit Error report as shown on Special:Upload Chunked upload of TIFF... [22:40:07] 3MediaWiki / 3File management: Upload should disallow SVGs with third-party content in style elements (not just style attributes) - 10https://bugzilla.wikimedia.org/69008#c24 (10Markus Glaser) 5PATC>3RESO/FIX Published the security fix in the tarballs. As of now, this bug can be publicly accessible. [22:45:08] 3MediaWiki / 3Uploading: Chunked upload of TIFF files - 10https://bugzilla.wikimedia.org/71256#c1 (10jeblad) Strangly enough, the file show up in Uploads after some time and seems to work. https://commons.wikimedia.org/wiki/File:Oslo_byarkiv,_Grosch_1830-%C3%A5rene,_001_004.tif [23:18:26] fabriceflorin: I figured out why...we delete and replace the image element on next/prev navigation, so the classes get disappeared, but the dialogOpen value stays - so the cursor changes but the click behaviour doesn't [23:18:30] Pushing a fix now [23:19:41] (03PS1) 10MarkTraceur: Fix dialog class [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/162793 [23:40:55] marktraceur: Cool. Let me know when I can test that fix on the cursor issue. [23:42:59] Probably not 'til tomorrow [23:43:15] tgr, gi11es, play nose goes for review overnight? :D https://gerrit.wikimedia.org/r/162793 [23:46:32] Hey Mark, check your email inbox with my list of UI questions which we might want to discuss with Pau. I have since read through the Gerrit notes about some of those questions ( https://gerrit.wikimedia.org/r/#/c/158660/ ), and now understand that the bold font and dark line at the bottom are specified by our styleguide here: https://tools.wmflabs.org/styleguide/desktop/section-2.html [23:47:11] But I do not see a rationale for the muted color on the ‘More details’ button, which is not consistent with the styleguide, and makes the button look disabled and the white lettering hard to read. Do you remember how we arrived at that decision to mute the button color, rather than match the styleguide’s darker blue color? From my perspective, this is something we should address before we release to all wikis, unless [23:47:11] there is a good reason for muting the color.