[01:53:45] 3MediaWiki extensions / 3VipsScaler: Use VipsScaler to scale TIFFs - 10https://bugzilla.wikimedia.org/52045#c20 (10Bawolff (Brian Wolff)) So this is now live on commons experimentally. There are some really large files (>350 megapixel) that still appear to time out. It gives broken results for [[File:Ameli... [02:45:34] 3MediaWiki extensions / 3VipsScaler: Use VipsScaler to scale TIFFs - 10https://bugzilla.wikimedia.org/52045#c21 (10Bawolff (Brian Wolff)) Experimentation locally suggests that running things through vips im_clip2fmt tempInput.v finalOutput.png 2 may fix the issue mentioned in comment 2 (For reference, the... [03:20:15] 3MediaWiki extensions / 3VipsScaler: Use VipsScaler to scale TIFFs - 10https://bugzilla.wikimedia.org/52045#c22 (10Bawolff (Brian Wolff)) (In reply to Bawolff (Brian Wolff) from comment #21) > Experimentation locally suggests that running things through > > vips im_clip2fmt tempInput.v finalOutput.png 2 >... [10:21:15] 3MediaWiki extensions / 3VipsScaler: Use VipsScaler to scale TIFFs - 10https://bugzilla.wikimedia.org/52045#c23 (10Kelson [Emmanuel Engelhart]) I can confirm that all huge TIFF pictures which are in: https://commons.wikimedia.org/wiki/Category:Media_contributed_by_Zentralbibliothek_Z%C3%BCrich_%28original_pi... [11:35:21] (03PS1) 10Gergő Tisza: [WIP] Cog icon & mw.ui styling for expand button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 [11:35:23] (03PS1) 10Gergő Tisza: [WIP] Show popup when the user visits a file page the first time after disabling MMV [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 [11:36:07] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Show popup when the user visits a file page the first time after disabling MMV [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 (owner: 10Gergő Tisza) [11:50:55] (03PS2) 10Gergő Tisza: [WIP] Show popup when the user visits a file page the first time after disabling MMV [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 [12:48:15] (03CR) 10Gilles: [C: 032] Fix ImageMetrics schema [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/164427 (owner: 10Gergő Tisza) [12:50:32] (03CR) 10jenkins-bot: [V: 04-1] Fix ImageMetrics schema [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/164427 (owner: 10Gergő Tisza) [13:01:52] (03PS1) 10Gilles: Update actions schema version and add new actions [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/164545 [13:02:17] (03CR) 10Gilles: [C: 032] "Tested by tunneling to the SQL server" [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/164545 (owner: 10Gilles) [13:02:22] (03Merged) 10jenkins-bot: Update actions schema version and add new actions [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/164545 (owner: 10Gilles) [13:11:36] (03PS1) 10Gilles: Add new actions for download popup [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/164546 [13:12:17] (03CR) 10Gilles: [C: 032] "Tested with local limn pointing to production tsvs" [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/164546 (owner: 10Gilles) [13:12:42] (03CR) 10Gilles: [V: 032] Add new actions for download popup [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/164546 (owner: 10Gilles) [13:13:40] Hey. Someone pointed out https://en.wikipedia.org/wiki/Phi#mediaviewer/File:Phi_uc_lc.svg to me [13:14:19] When you click the download button, why does it show 'You need to attribute the author'? [14:17:01] Krenair: excellent point, we just display that for every image but we could make an exception for PD [14:17:21] Well, that would make sense. [14:17:41] I'll file a bug and create a mingle card for it [14:18:07] cool. please CC me [14:19:21] https://commons.wikimedia.org/wiki/Commons:Credit_line seems relevant [14:19:33] 3MediaWiki extensions / 3MultimediaViewer: Attribution prompts shown on PD fikles - 10https://bugzilla.wikimedia.org/71611 (10Gilles Dubuc) 3NEW p:3Unprio s:3normal a:3None We show the "please attribute the author" message in the download menu as well as include the uploader's information in the embe... [14:19:45] 3MediaWiki extensions / 3MultimediaViewer: Attribution prompts shown on PD files - 10https://bugzilla.wikimedia.org/71611 (10Gilles Dubuc) [14:20:04] thanks [14:21:00] 3MediaWiki extensions / 3MultimediaViewer: Attribution prompts shown on PD files - 10https://bugzilla.wikimedia.org/71611#c1 (10Alex Monk) For example: https://en.wikipedia.org/wiki/Phi#mediaviewer/File:Phi_uc_lc.svg See also https://commons.wikimedia.org/wiki/Commons:Credit_line [14:22:00] 3MediaWiki extensions / 3MultimediaViewer: Attribution prompts shown on PD files - 10https://bugzilla.wikimedia.org/71611#c2 (10Gilles Dubuc) https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/935 [14:49:15] 3MediaWiki / 3Uploading: Internal error: Could not determine if the copy succeeded. - 10https://bugzilla.wikimedia.org/43967#c10 (10Nemo) Just got this on https://commons.wikimedia.org/wiki/File:Practica_D._magistri_V00241_00000004.tif Error console says the following, dunno if related: 2 Validation error... [15:45:00] 3MediaWiki / 3Uploading: Chunked upload of SVGs triggers INVALIDXML exception, but file is valid - 10https://bugzilla.wikimedia.org/65724#c7 (10Brad Jorsch) 5UNCO>3NEW It isn't anything unique to large SVGs, any SVG will trigger this problem. I've been testing locally with SVGs like the following (and ve... [15:57:08] "fun" fact, the 500 for requesting a thumbnail that is too large only works for images that aren't soft-rotated: https://upload.wikimedia.org/wikipedia/commons/thumb/9/9b/WikiCon_2014_Fotoexkursion_%28170%29.JPG/5000000000px-WikiCon_2014_Fotoexkursion_%28170%29.JPG [15:59:17] at least it's not 5000000000px wide [15:59:54] right... it just means that funny requests end up as duplicates of the original in varnish [16:00:04] which is probably where the idea of the 500 came from originally [16:00:35] the reason they're getting through is that the 500's check is "is the thumb the same image as the original?" [16:01:24] I'm not sure what's best between getting rid of the 500 or making it work for soft-rotated images... [16:02:07] I'm going to make prerendering not request those, of course, otherwise it would be gratuitous varnish space waste [16:02:37] there are two bugs here IMO [16:02:46] although one of them is considered a feature [16:03:03] that soft-rotated images do not return 500 for sizes > original [16:03:24] and that non-soft-rotated images return 500 for size = original [16:04:02] the latter is to save thumbnail space, I presume, but it makes the URL behavior even more erratic than it originally is [16:04:21] request a size, roll a dice... [16:04:46] besides, at some point we want to switch to showing thumbnails all the time [16:05:32] linking to the original file makes everything unnecessarily complex, and there is a lot of post-processing that could be done to images [16:05:59] like author into EXIF, better compression, interlacing... [16:06:32] for prerendering, can't you just use transform()? [16:06:40] I see that bawolff had the foresight of capping size requests for SVGs, it seems: https://upload.wikimedia.org/wikipedia/commons/thumb/b/b0/Letters_SVG.svg/500000000000px-Letters_SVG.svg.png [16:06:42] that would be the most robust solution IMO [16:06:58] a couple of days ago that was still spewing an entertaining error about the resizing going our of memory [16:07:13] out [16:08:27] tgr: not in production, because the job servers aren't the same as the image resizing ones. when using the non-http method, the code does use transform [16:09:36] if there is a 404 handler, and you don't pass RENDER_NOW, transform() will basically just return an URL AFAIK [16:09:58] and if there is no 404 handler, using the http method doesn't make much sense anyway [16:10:58] but that assumes the job server having the same config as the image server [16:11:21] for the 404 handler [16:11:38] it does, but it would be weird if they didn't [16:12:29] it could easily go unnoticed, the job servers don't serve images [16:12:41] the configuration tells how the wiki works; if you scale it vertically and use separate machines for separate subtasks, it's still the same wiki [16:13:20] for WMF servers, everything uses InitializeSettings.php/CommonSettings.php and that is only split by wiki name [16:15:08] anyway, the job servers doing transform() is not unusual, it's called from the parser in the process of getting the thumbnail HTML markup [16:15:44] and the parser is run from the job queue e.g. when you edit a template and all pages transcluding it have to be updated in the background [16:22:29] 3MediaWiki / 3Uploading: Internal error: Could not determine if the copy succeeded. - 10https://bugzilla.wikimedia.org/43967#c11 (10Bawolff (Brian Wolff)) (In reply to Gilles Dubuc from comment #9) > I confirm that this is probably coming from chunked upload-specific APIs. > More specifically "checkStatus",... [18:23:02] (03PS1) 10Gilles: E2E tests for download menu [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164607 [22:52:14] 3MediaWiki / 3Uploading: SVG upload get blocked on correct encoding (windows-1252, with wrong/unspecific warning) - 10https://bugzilla.wikimedia.org/70937#c6 (10Chris Steipp) (In reply to Bawolff (Brian Wolff) from comment #4) > windows-1252 is almost the same as ISO-8859-1 (just c0 and c1 control > characte...