[07:55:13] hmmm wikibugs bot doesn't seem to be configured to report ImageMetrics bugs here [07:56:27] yep https://github.com/wikimedia/labs-tools-pywikibugs/blob/master/channels.py [07:58:43] https://gerrit.wikimedia.org/r/165438 [08:07:30] I'm fixing the ImageMetrics bug, btw [08:11:06] (03PS1) 10Gilles: Don't try to log metrics if it's not an image [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/165441 (https://bugzilla.wikimedia.org/71780) [08:14:18] (03CR) 10jenkins-bot: [V: 04-1] Don't try to log metrics if it's not an image [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/165441 (https://bugzilla.wikimedia.org/71780) (owner: 10Gilles) [08:16:43] (03PS2) 10Gilles: Don't try to log metrics if it's not an image [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/165441 (https://bugzilla.wikimedia.org/71780) [08:17:37] (03CR) 10jenkins-bot: [V: 04-1] Don't try to log metrics if it's not an image [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/165441 (https://bugzilla.wikimedia.org/71780) (owner: 10Gilles) [08:18:56] portuguese jenkins isn't being nice [08:20:12] (03CR) 10Gilles: "No idea why this is failing like that, qunit works just fine locally" [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/165441 (https://bugzilla.wikimedia.org/71780) (owner: 10Gilles) [08:20:49] (03CR) 10Gilles: "recheck" [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/165441 (https://bugzilla.wikimedia.org/71780) (owner: 10Gilles) [08:30:24] (03PS1) 10Gilles: Empty commit to check Jenkins' sanity [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/165448 [08:31:17] (03CR) 10jenkins-bot: [V: 04-1] Empty commit to check Jenkins' sanity [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/165448 (owner: 10Gilles) [08:43:37] (03PS2) 10Gilles: Empty commit to check Jenkins' sanity [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/165448 [08:45:59] (03CR) 10jenkins-bot: [V: 04-1] Empty commit to check Jenkins' sanity [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/165448 (owner: 10Gilles) [08:46:53] (03PS3) 10Gilles: Empty commit to check Jenkins' sanity [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/165448 [08:47:48] (03CR) 10jenkins-bot: [V: 04-1] Empty commit to check Jenkins' sanity [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/165448 (owner: 10Gilles) [09:00:16] tgr: gi11es: so the ImageMetrics-qunit job never worked apparently and die with a cryptic error [09:00:28] should we prevent it from voting while the issue is being figured out ? [09:00:52] hashar: yes, thanks [09:01:00] I can just run the tests locally for now [09:01:08] (03PS4) 10Gilles: Empty commit to check Jenkins' sanity [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/165448 [09:01:12] do they pass locally ? [09:01:20] yes [09:01:35] note Jenkins run the extension standalone (there is no other extensions installed) and it uses the tip of mediawiki/core master branch [09:02:07] (03CR) 10jenkins-bot: [V: 04-1] Empty commit to check Jenkins' sanity [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/165448 (owner: 10Gilles) [09:02:13] it's possible that some dependency of ImageMetrics is not specified [09:02:23] would turning off all roles on vagrant be an equivalent setup? [09:03:38] tgr: the thing is, it fails even when I comment out all the ImageMetrics qunit tests [09:06:17] I made the qunit job non voting [09:06:27] if ImageMetrics has some dependencies upon other extensions, they need to be specified [09:08:01] I'm gradually turning all extensions off on my vm to try and reproduce the issue [09:08:49] and I have no clue what qunit test module 'test.module1' is [09:09:30] I think that's part of core [09:09:46] from the read me require_once( "$IP/extensions/EventLogging/EventLogging.php" ); // dependency [09:09:53] or it's qunit's own qunit tests, something like that [09:09:53] apparently EventLogging is a dependency [09:10:16] the qunit job attach wfDebug() log output to the job page https://integration.wikimedia.org/ci/job/mwext-ImageMetrics-qunit/9/ [09:10:25] sometime there are useful error messages there [09:10:31] https://integration.wikimedia.org/ci/job/mwext-ImageMetrics-qunit/9/artifact/log/mw-debug-www.log.gz [09:11:07] I had a glance at those files, didn't see anything [09:11:35] ditto [09:13:01] adding EventLogging as a dependency [09:16:30] gi11es: that was it [09:16:37] the qunit test depends on EventLogging extensions [09:16:37] ah, you beat me to it :) thanks [09:16:38] https://integration.wikimedia.org/ci/job/mwext-ImageMetrics-qunit/10/console [09:16:43] the question then is [09:17:11] do you want the tests to be depending upon EventLogging ? Or should they mock it :D [09:17:21] or gracefully fallback [09:18:10] the tests should depend on it [09:18:31] the documentation for the extension clearly states that EventLogging needs to be turned on [09:18:43] yeah but the test might be made to mock EventLogging [09:19:00] but yeah I would not bother and require Eventlogging [09:19:29] ah yeah, sure, I think we actually do mock it for the MV tests [09:21:15] I am mocking it in the tests, but maybe the PHP setup code depends on it [09:21:59] I have proposed a change to Jenkins job configuration https://gerrit.wikimedia.org/r/#/c/165456/1/mediawiki-extensions.yaml,unified [09:22:09] which would add EventLogging as a dependency to both the PHPUnit and the Qunit job [09:22:26] the loader script does mw.loader.using( 'ext.imageMetrics'... [09:22:27] we can have it only loaded on qunit job [09:23:05] that's the live script, not the test, not sure if there is a way to mock it out [09:23:17] probably not [09:23:23] the sound way to handle that would be to set up mocks server-side [09:23:34] the question now is: do you want EventLogging to be installed when running the PHPUnit test ? [09:23:45] or should we not install it and rely exclusively on Mocking? [09:24:22] CI wise, adding a dependency is not an issue :] [09:25:39] commented on the jjb change https://gerrit.wikimedia.org/r/#/c/165456/1/mediawiki-extensions.yaml,unified [09:26:50] (03CR) 10Hashar: "recheck" [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/165448 (owner: 10Gilles) [09:27:36] we would need something like $resourceLoader->mockModule('ext.imageMetrics.loader')->withEmptyScript() [09:28:14] anyway, for now just add the dependency, there is no clean way to make sure the real, unmocked logging in the onload handler does not run [09:29:52] you are the boss :-] [09:30:00] I am not even sure I still understand how RL works nowadays hehe [09:30:10] I commented on https://bugzilla.wikimedia.org/show_bug.cgi?id=71782#c8 with the status as of now [09:30:14] feel free to mark fixed [09:30:30] the qunit job is passing and EventLogging is added as a dependency [09:30:44] patchset that have a -2 can be retested by commenting in Gerrit: 'recheck' [09:30:50] nature's call be back soon [09:33:17] isn't there a username whitelist for recheck? [09:41:57] (03CR) 10Gergő Tisza: "recheck" [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/164427 (owner: 10Gergő Tisza) [09:49:53] (03CR) 10Gergő Tisza: "Re-+2 per Gilles" [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/164427 (owner: 10Gergő Tisza) [09:50:02] ooh, I can recheck, nice. [09:50:10] thanks for the help, hashar! [10:02:12] tgr: you are welcome. Feel free to mark the bug fixed :] [10:09:43] 3MediaWiki extensions / 3UploadWizard: UploadWizard should not register ResourceLoaderFileModule objects - 10https://bugzilla.wikimedia.org/71768 (10Andre Klapper) p:5Unprio>3Normal [10:12:28] 3MediaWiki extensions / 3TimedMediaHandler: Appends link to Kaltura - 10https://bugzilla.wikimedia.org/23965#c18 (10Andre Klapper) (In reply to Ryan Kaldari from comment #17) > This is going to be addressed by the next version of the player Where's "the next version of the player" defined/explained? When is... [11:47:13] 3MediaWiki / 3File management: Moving files results in broken descriptions and deleted images - 10https://bugzilla.wikimedia.org/40927#c26 (10Andre Klapper) 5PATC>3RESO/FIX (In reply to Andre Klapper from comment #25) > All patches merged - what's left to do here? No reply to comment 25. Assuming this b... [13:16:21] marktraceur: could you have a look and close the tasks that have been done in https://phabricator.wikimedia.org/project/view/19/ ? (if any) [13:21:49] (03CR) 10Gilles: "recheck" [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/165441 (https://bugzilla.wikimedia.org/71780) (owner: 10Gilles) [13:30:15] 3MediaWiki extensions / 3CommonsMetadata: PHP notices in hhvm.log - 10https://bugzilla.wikimedia.org/71793 (10Gilles Dubuc) 3NEW p:3Unprio s:3normal a:3None Oct 8 13:25:10 mw1019: #012Notice: Undefined index: coordinates in /srv/mediawiki/php-1.25wmf2/extensions/CommonsMetadata/DataCollector.php on... [13:34:49] (03PS1) 10Gilles: Fix PHP notices complaining about missing array indices [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/165476 (https://bugzilla.wikimedia.org/71793) [13:36:55] (03CR) 10Gilles: [C: 032] Fix ImageMetrics schema [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/164427 (owner: 10Gergő Tisza) [13:37:21] (03Merged) 10jenkins-bot: Fix ImageMetrics schema [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/164427 (owner: 10Gergő Tisza) [13:38:21] (03Abandoned) 10Gilles: Empty commit to check Jenkins' sanity [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/165448 (owner: 10Gilles) [13:39:35] (03PS1) 10Brion VIBBER: Work in progress: ogv.js media player for Safari/IE (1 of 3) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165477 (https://bugzilla.wikimedia.org/61823) [13:39:41] (03PS1) 10Brion VIBBER: Work in progress: ogv.js media player for Safari/IE (2 of 3) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://bugzilla.wikimedia.org/61823) [13:39:46] (03PS1) 10Brion VIBBER: Work in progress: ogv.js media player for Safari/IE (3 of 3) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165479 (https://bugzilla.wikimedia.org/61823) [13:40:48] (03Abandoned) 10Brion VIBBER: Work in progress: early testing of integration with ogv.js media player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/145756 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [13:44:31] (03PS2) 10Brion VIBBER: Work in progress: ogv.js media player for Safari/IE (2 of 3) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://bugzilla.wikimedia.org/61823) [13:44:53] the split, itshappening.gif [13:47:00] (03PS2) 10Brion VIBBER: Work in progress: ogv.js media player for Safari/IE (3 of 3) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165479 (https://bugzilla.wikimedia.org/61823) [13:52:38] (03CR) 10Gilles: "ogvjs.js triggers a bunch of jslinting errors. TMH is in a poor state in terms of JS linting, though. Are you keen on making ogv.js comply" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165477 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [13:53:51] (03CR) 10Brion VIBBER: "ogv.js is a bit of manually-edited code plus a few hundred kb of compiler-generated gibberish... :D it's not likely to ever pass the linte" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165477 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [13:54:42] (03CR) 10Gilles: [C: 031] "Sounds good to me. This is good to +2 whenever you don't want this to be WIP anymore." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165477 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [13:57:51] Keegan: what's the link to the Win7/IE11 regression bug (if there's one)? can't find it on bugzilla [13:58:12] I hadn't filed it yet, one sec... [13:58:19] and the saucelabs machine e2e I've set up for that OS/browser combination succeeds, unfortunately [13:58:29] https://www.mediawiki.org/wiki/Talk:Multimedia/About_Media_Viewer#Position_on_page_is_lost_after_navigation [13:59:03] oh... the use case described is after coming back from the original [13:59:31] this is different than browsing back from media viewer without opening the original [13:59:52] I see [14:00:37] we'd have to build something specific for that, like storing the scroll position in local storage or something [14:00:42] this happens in all browsers [14:00:50] * Keegan probably shoulda just copied the info over to bugzilla first [14:00:56] I'll file it [14:05:43] gi11es: https://bugzilla.wikimedia.org/show_bug.cgi?id=71796 [14:05:45] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer: Scroll position is lost on original page after accessing the original file - 10https://bugzilla.wikimedia.org/71796 (10Keegan Peterzell) 3NEW p:3Unprio s:3normal a:3None When a user clicks on an image in a page to open Media Viewer and then pro... [14:07:28] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer: Scroll position is lost on original page after accessing the original file - 10https://bugzilla.wikimedia.org/71796#c1 (10Gilles Dubuc) This is default browser behavior when reopening a hash link through the history. We can build something specific to... [14:07:39] (03CR) 10Gergő Tisza: [C: 032] Fix PHP notices complaining about missing array indices [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/165476 (https://bugzilla.wikimedia.org/71793) (owner: 10Gilles) [14:07:47] (03Merged) 10jenkins-bot: Fix PHP notices complaining about missing array indices [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/165476 (https://bugzilla.wikimedia.org/71793) (owner: 10Gilles) [14:18:31] (03CR) 10Gilles: [C: 032] "The transcodes don't seem to be particularly sorted in the UI, and Brian has implemented a proper sorting mechanism when it comes to picki" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165243 (https://bugzilla.wikimedia.org/71705) (owner: 10Brion VIBBER) [14:18:44] (03Merged) 10jenkins-bot: Quick add of full-HD (1080p) transcode configs for TMH [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165243 (https://bugzilla.wikimedia.org/71705) (owner: 10Brion VIBBER) [14:21:41] (03CR) 10Siebrand: "i18n/L10n reviewed." (033 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165243 (https://bugzilla.wikimedia.org/71705) (owner: 10Brion VIBBER) [14:22:27] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165479 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [14:22:53] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://bugzilla.wikimedia.org/61823) (owner: 10Brion VIBBER) [14:24:12] This is wonky. But then again, it's because of the file page crazy, I think: https://www.mediawiki.org/wiki/Talk:Multimedia/About_Media_Viewer#Show_title_of_work [14:24:49] the title shown on the file page is in german [14:25:25] if you use wikipedia in german, I guess it'd show up in media viewer [14:25:26] Right, that's what I'm thinking is the issue [14:25:53] gi11es: Sure, looking [14:26:02] Let's see if adding English fixes it [14:26:12] For English, at least :/ [14:26:16] Aw, who deleted the project image [14:26:18] Lame [14:28:00] marktraceur: it just wasn't ported over by the import bot [14:29:30] gi11es: Two were done, marked as such [14:29:32] One is in dev [14:29:36] But none are moving :( [14:29:57] Er, I mean, I moved three, but they aren't going anywhere else. [14:31:49] Hmm, I added English but the title still isn't showing up https://www.mediawiki.org/wiki/Talk:Multimedia/About_Media_Viewer#mediaviewer/File:Fran%C3%A7ois_Clouet_004.jpg [14:32:06] It's not a cache thing because it doesn't show in this file either https://commons.wikimedia.org/wiki/File:Franz_Xaver_Winterhalter_Napoleon_III.jpg#mediaviewer/File:Franz_Xaver_Winterhalter_Napoleon_III.jpg [14:32:19] Perhaps I should stop trying to think as my brain is rapidly slowing down [14:33:00] the currywurst energy is all used up [14:33:28] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer: Scroll position is lost on original page after accessing the original file - 10https://bugzilla.wikimedia.org/71796#c2 (10Tisza Gergő) This should not be the default behavior for at least some browsers, as they normally cache the page state in memory f... [14:33:55] playing with phabricator == procrastinating jet lag effects [14:34:27] tee-hee [14:35:43] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer: Scroll position is lost on original page after accessing the original file - 10https://bugzilla.wikimedia.org/71796#c3 (10Gilles Dubuc) I think the cache is doing what it's supposed to. If you have media viewer open, the page scroll is 0. So at the tim... [14:36:13] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer: Scroll position is lost on original page after accessing the original file - 10https://bugzilla.wikimedia.org/71796#c4 (10Gilles Dubuc) I.e. the browser can't be aware that media viewer "isn't really the page". [14:36:44] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer: Scroll position is lost on original page after accessing the original file - 10https://bugzilla.wikimedia.org/71796#c5 (10Tisza Gergő) As for storing page location in localStorage, we are building hack upon hack to pretend we have a zoom function. If t... [14:38:29] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer: Scroll position is lost on original page after accessing the original file - 10https://bugzilla.wikimedia.org/71796#c6 (10Gilles Dubuc) I didn't suggest that we should implement this hack, I'm just listing possibilities for posterity :) I personally th... [14:40:43] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer: Scroll position is lost on original page after accessing the original file - 10https://bugzilla.wikimedia.org/71796#c7 (10Tisza Gergő) (In reply to Gilles Dubuc from comment #3) > I think the cache is doing what it's supposed to. If you have media view... [14:41:28] 3MediaWiki extensions / 3MultimediaViewer: Media Viewer: Scroll position is lost on original page after accessing the original file - 10https://bugzilla.wikimedia.org/71796#c8 (10Gilles Dubuc) On the topic of relying on the browser, I guess then the solution is to close Media Viewer's UI like ninjas onbefore... [14:42:13] 3MediaWiki / 3Uploading: Special:Upload uses duplicate IDs - 10https://bugzilla.wikimedia.org/71689#c2 (10Patrick Westerhoff) 5NEW>3RESO/DUP Already fixed. https://gerrit.wikimedia.org/r/#/c/88443/ *** This bug has been marked as a duplicate of bug 40889 *** [14:42:14] 3MediaWiki / 3Uploading: IDREF attribute for references an unknown ID "wpSourceTypeFile" - 10https://bugzilla.wikimedia.org/40889#c14 (10Patrick Westerhoff) *** Bug 71689 has been marked as a duplicate of this bug. *** [14:44:24] (03CR) 10Gergő Tisza: [C: 032] Don't try to log metrics if it's not an image [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/165441 (https://bugzilla.wikimedia.org/71780) (owner: 10Gilles) [14:44:56] (03Merged) 10jenkins-bot: Don't try to log metrics if it's not an image [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/165441 (https://bugzilla.wikimedia.org/71780) (owner: 10Gilles) [14:50:20] Keegan: seems like CommonsMetadata doesn't fall back to the template title when there's no description [14:50:32] eg. https://commons.wikimedia.org/wiki/File:Augusta_von_Preussen.jpg [14:51:18] not sure the template title is used at all, at the moment, in fact [14:51:43] the MV "title" is the file name stripped of its extension, and below the fold it's caption and template description [14:52:11] we're going to revisit that anyway in the new caption logic for what's displayed above the fold [14:53:31] All right, I'll followup along those lines [14:53:33] Thanks! [14:53:50] gi11es: it's not used at all [15:19:35] (03CR) 10Brian Wolff: "As reported on commons, this is categorizing file redirects as missing metadata." (031 comment) [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/160580 (owner: 10Gergő Tisza) [15:33:10] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [17:45:03] gi11es, tgr - Aaron says his script ran and it's done with, I unblocked #827 and marked the SoS card done. Let me know if I need to do anything else. [18:20:43] 3MediaWiki extensions / 3UploadWizard: Upload Wizard rejects valid license templates - 10https://bugzilla.wikimedia.org/65229#c4 (10Alex Nordstrom) Created attachment 16715 --> https://bugzilla.wikimedia.org/attachment.cgi?id=16715&action=edit Add 'free screenshot' to 'licenseTagFilters' Isn't this all th... [18:50:30] 3MediaWiki / 3Uploading: illegally named upload files not handled consistently. - 10https://bugzilla.wikimedia.org/27980#c5 (10mickeyf) 5RESO/WOR>3REOP I understand (3-1/2 years and several version later) that this is a somewhat obscure issue, and low priority. However: UX perspective - If a user of Med... [18:52:17] hm, jenkins has decided to teach me Spanish. [18:52:28] I got that too... [18:52:29] Duration: 5 minutos 53 segundos [18:52:47] Can that be leaking from some spanish language test? [18:52:54] Maybe [18:53:06] El Jenkinso [19:40:07] (03CR) 10Brian Wolff: "Note, its likely that this will hit time limits when transcoding longer videos to 1080p (We already sort of have a problem with that on 72" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165243 (https://bugzilla.wikimedia.org/71705) (owner: 10Brion VIBBER) [19:54:53] (03PS1) 10Brian Wolff: Only add tracking categories to "real" file pages [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/165591 [19:58:55] marktraceur: gi11es: (and I suppose of interest to basile) Any chance that https://gerrit.wikimedia.org/r/#/c/165591/ could be reviewed today and perhaps deployed in swat? It takes a while for things to fall out of a tracking category if they no longer match, but don't have any edit (or template being edited) to cause the condition not to match, so it would be better if the criteria was... [19:58:57] ...fixed asap before too much stuff gets stuck in the tracking cat [19:59:33] * bawolff brb [20:04:40] (03CR) 10MarkTraceur: Add viewing options panel (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [20:04:44] (03PS10) 10MarkTraceur: Add viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 [21:07:20] tgr: Any chance you could look at https://gerrit.wikimedia.org/r/#/c/165591/ - be cool if we could swat it to prevent false positives showing up in tracking category [21:18:37] bawolff: looking; thanks for writing that patch! [21:18:49] thanks [21:19:13] If you haven't seen, their's been some discussion on commons about the tracking cats [21:19:20] Mostly just Fae being Fae [21:19:53] I have seen it, didn't have time for much else yet [21:37:52] (03CR) 10Gergő Tisza: [C: 032] "Thanks for fixing it, Bawolff!" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/165591 (owner: 10Brian Wolff) [21:38:55] ^^ bawolff +1, thanks for catching those issues so quickly [21:40:21] Eloquence: I didn't catch, it was a guy on commons [21:40:47] Sort of thing that's very easy to over look, but seems obvious after its pointed out [21:40:57] s/catch/fix/ :) [21:42:00] (03Merged) 10jenkins-bot: Only add tracking categories to "real" file pages [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/165591 (owner: 10Brian Wolff) [21:44:12] (03PS1) 10Gergő Tisza: Only add tracking categories to "real" file pages [extensions/CommonsMetadata] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/165636 [21:44:37] (03CR) 10Gergő Tisza: [C: 032] Only add tracking categories to "real" file pages [extensions/CommonsMetadata] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/165636 (owner: 10Gergő Tisza) [21:44:44] (03Merged) 10jenkins-bot: Only add tracking categories to "real" file pages [extensions/CommonsMetadata] (wmf/1.25wmf2) - 10https://gerrit.wikimedia.org/r/165636 (owner: 10Gergő Tisza) [21:45:31] Whee, thanks, was just about to make a cherry-pick commit [21:50:08] (03PS1) 10MarkTraceur: Fix font size in MonoBook [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/165642 [21:56:49] tgr: Should I add this to the list of SWAT deployments, or are you taking care of it? [21:57:05] I'm doing it [21:58:38] cool. thanks :)