[08:07:07] 3MediaWiki extensions / 3MultimediaViewer: (possibly spurious) "Could not load image data http" errors on beta labs - 10https://bugzilla.wikimedia.org/72162#c1 (10Gilles Dubuc) I suspect this is still beta being unreliable because of HHVM hiccups. We've had sporadic errors like that ever since HHVM was rolle... [08:08:07] 3MediaWiki extensions / 3TimedMediaHandler: Division by zero in WebVideoTranscode.php on line 923 - 10https://bugzilla.wikimedia.org/69444#c7 (10Gilles Dubuc) 5NEW>3RESO/FIX I'm pretty sure that Bawolff wrote that commit in response to this bug. [09:04:52] 3MediaWiki extensions / 3ImageMetrics: Error on video file pages - 10https://bugzilla.wikimedia.org/71780#c3 (10Gilles Dubuc) Hello, pywikibot [09:05:39] 3MediaWiki extensions / 3ImageMetrics: Error on video file pages - 10https://bugzilla.wikimedia.org/71780 (10Gilles Dubuc) 5PATC>3RESO/FIX [09:08:30] (03PS16) 10Gilles: Add viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [09:08:57] (03CR) 10Gilles: "This is just a rebase, I didn't touch any code." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [09:09:54] (03PS2) 10Gilles: Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [09:10:08] (03CR) 10Gilles: "Just rebasing..." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [09:10:32] (03CR) 10jenkins-bot: [V: 04-1] Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [09:47:22] (03CR) 10Gergő Tisza: [C: 04-1] "Expand icon needs to be fixed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 (owner: 10Gergő Tisza) [09:48:23] fyi, I'm writing e2e tests for marktraceur's viewing options test changeset [11:47:24] 3MediaWiki extensions / 3TimedMediaHandler: TMH player defaults to very small .ogv even when it has native webm playback - 10https://bugzilla.wikimedia.org/61760#c14 (10Andre Klapper) 5PATC>3RESO/FIX No reply to comment 13. All patches mentioned in this report were merged or abandoned - assuming this bu... [12:16:53] (03PS3) 10Gilles: Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [12:17:38] (03CR) 10jenkins-bot: [V: 04-1] Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [12:17:59] (03CR) 10Gilles: "Added some E2E tests, might add more" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [13:08:53] (03PS4) 10Gilles: Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [13:09:33] (03CR) 10jenkins-bot: [V: 04-1] Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [13:10:39] (03CR) 10Gilles: "This should cover everything in terms of E2E. Back to you for QUnit!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [13:12:05] (03PS7) 10Gilles: Cog icon & mw.ui styling for expand button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 (owner: 10Gergő Tisza) [13:12:48] (03CR) 10jenkins-bot: [V: 04-1] Cog icon & mw.ui styling for expand button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 (owner: 10Gergő Tisza) [13:14:14] (03CR) 10Gilles: "Just a rebase. Pointed it to the tests changeset so that we have a single chain of commits instead of a tree. The tests are almost done, M" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 (owner: 10Gergő Tisza) [16:46:07] 3MediaWiki extensions / 3MultimediaViewer: (possibly spurious) "Could not load image data http" errors on beta labs - 10https://bugzilla.wikimedia.org/72162#c2 (10Chris McMahon) 17 October: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-linux-chrome-sauce... [17:02:08] marktraceur: ping [17:19:03] (03PS5) 10Gilles: Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [17:25:54] 3MediaWiki extensions / 3MultimediaViewer: flipping through images in Media Viewer produces error: could not load thumbnail data - 10https://bugzilla.wikimedia.org/72190 (10etonkovidova) a:3None [17:38:11] (03PS6) 10Gilles: Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [17:38:50] (03CR) 10Gilles: "Added some QUnit coverage" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [17:38:54] (03CR) 10jenkins-bot: [V: 04-1] Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [17:39:23] 3MediaWiki extensions / 3MultimediaViewer: flipping through images in Media Viewer produces error: could not load thumbnail data - 10https://bugzilla.wikimedia.org/72190#c1 (10Tisza Gergő) 5NEW>3RESO/DUP *** This bug has been marked as a duplicate of bug 67651 *** [17:39:23] 3MediaWiki extensions / 3MultimediaViewer: MediaViewer does not work on Beta - 10https://bugzilla.wikimedia.org/67651#c2 (10Tisza Gergő) *** Bug 72190 has been marked as a duplicate of this bug. *** [17:49:37] 3MediaWiki extensions / 3MultimediaViewer: (possibly spurious) "Could not load image data http" errors on beta labs - 10https://bugzilla.wikimedia.org/72162#c3 (10Tisza Gergő) Probably a HTTP 500 on the imageinfo API call. The last test run was Oct 17, 2014 7:29:05 AM. The Apache log for deployment-mediawiki... [18:05:07] gi11es: Pong [18:05:19] Sorry, was at lunch [18:05:25] marktraceur: I'm finishing up some qunit stuff on your test changeset [18:05:32] almost done [18:05:33] Oh, OK [18:05:37] Sweet [18:05:44] It might need some changes based on my refactoring [18:05:54] tgr was displeased with the repetitive code. [18:06:42] I had bitten the bullet and done it because everything was ever so slightly different, but the new version is coming [18:06:55] gi11es: Do you need CR, or advice, or just my awareness? [18:08:22] I just wanted to avoid both working on the same stuff at once [18:08:27] Right [18:08:44] Do we have other MMV stuff in the pipeline? /me checks mingle [18:08:52] most of what I've written should still apply after your changes [18:09:08] Cool. [18:13:18] (03PS7) 10Gilles: Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [18:13:58] (03CR) 10jenkins-bot: [V: 04-1] Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [18:15:29] (03PS8) 10Gilles: Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [18:16:41] Around 15:00 local time I may need to switch focus to OpenHatch, I'm helping mentor some people tomorrow and apparently "Wikipedia" is one of the project topics people wanted covered [18:16:46] Sigh. [18:16:53] This is what I get for being nice [18:34:26] Weird. [18:34:33] I'm seeing a bug locally, not sure if it's for real yet [18:36:22] I'll upload the latest [18:36:38] (03PS17) 10MarkTraceur: Add viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 [18:36:59] It didn't get better ;_; [18:37:19] (03CR) 10jenkins-bot: [V: 04-1] Add viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [18:37:31] Arghhhh [18:39:56] (03PS18) 10MarkTraceur: Add viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 [18:39:59] I'm not sure what the doc-test is on about [18:55:47] (03PS4) 10Gergő Tisza: Show popup when the user visits a file page the first time after disabling MMV [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 [18:56:16] (03PS5) 10Gergő Tisza: Show popup when the user visits a file page the first time after disabling MMV [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 [18:57:33] (03CR) 10jenkins-bot: [V: 04-1] Show popup when the user visits a file page the first time after disabling MMV [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 (owner: 10Gergő Tisza) [18:57:58] (03PS8) 10Gergő Tisza: Cog icon & mw.ui styling for expand button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 [18:58:12] (03PS6) 10Gergő Tisza: Show popup when the user visits a file page the first time after disabling MMV [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 [18:59:02] (03CR) 10jenkins-bot: [V: 04-1] Show popup when the user visits a file page the first time after disabling MMV [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 (owner: 10Gergő Tisza) [18:59:08] 3MediaWiki extensions / 3MultimediaViewer: In VE, while adding any image using Firefox getting the error "Image corrupt or truncated" in Betalabs - 10https://bugzilla.wikimedia.org/72115 (10Greg Grossmeier) a:3None [19:01:17] Oh, doc-test lied to me. [19:01:19] Fantastic. [19:01:45] gi11es: I think we should be set, I'm going to begin the task of fixing the tests. [19:01:53] I think there's still...something to do there [19:02:07] I took out some of the methods - I might put them back for testing, but not sure yet [19:05:32] (03PS19) 10MarkTraceur: Add viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 [19:06:34] (03CR) 10jenkins-bot: [V: 04-1] Add viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [19:06:52] (03PS9) 10MarkTraceur: Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 [19:07:37] (03CR) 10jenkins-bot: [V: 04-1] Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [19:10:21] Well, it's rebased anyway [19:10:25] Now to find out what broke [19:13:37] (03CR) 10MarkTraceur: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [19:13:43] Jenkins, you're a lying harlot [19:16:43] OK, those pass at least [19:19:43] (03PS10) 10MarkTraceur: Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 [19:19:45] (03PS20) 10MarkTraceur: Add viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 [19:19:51] Now the functions are back, let's see how it goes [19:20:23] (03CR) 10jenkins-bot: [V: 04-1] Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [19:21:03] OK, need some tweaks in the $text mentions but otherwise should be good [19:25:30] > $(...).triggerHandler(...) is undefined [19:25:43] tgr: Didn't you suggest that? Do you know why it would happen? [19:26:07] Last issue, I think. [19:26:28] you have to call it on the exact same element [19:26:40] Pretty sure I did. [19:27:06] The document object, both places [19:27:08] not sure then, let me finish the popup and I'll check [19:27:10] OK [19:27:12] I'll push the latest [19:27:23] (03PS11) 10MarkTraceur: Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 [19:28:05] (03CR) 10jenkins-bot: [V: 04-1] Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [19:28:22] (03PS7) 10Gergő Tisza: Show popup when the user visits a file page the first time after disabling MMV [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 [19:28:33] I'll trade you. :) [19:29:00] (03CR) 10jenkins-bot: [V: 04-1] Show popup when the user visits a file page the first time after disabling MMV [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 (owner: 10Gergő Tisza) [19:35:50] (03PS8) 10Gergő Tisza: Show popup when the user visits a file page the first time after disabling MMV [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 [19:36:28] (03CR) 10jenkins-bot: [V: 04-1] Show popup when the user visits a file page the first time after disabling MMV [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 (owner: 10Gergő Tisza) [20:16:14] (03CR) 10MarkTraceur: "Minor issues here. Will -1 child patchset if issues persist." (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 (owner: 10Gergő Tisza) [20:16:42] (03CR) 10MarkTraceur: [C: 04-1] "See ps7" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 (owner: 10Gergő Tisza) [20:18:13] OK, time to work on some bug triage for tomorrow [20:18:22] I'll stop and deal with CR if it exists [20:18:48] Oh, hashar - I'm seeing some intermittent Jenkins failures of the qunit tests that aren't there on recheck, has Jenkins been hitting the blow again? [20:19:57] marktraceur: no clue [20:20:19] marktraceur: the underlying infrastructure Zuul / Jenkins seems to be working just fine [20:20:34] so that might be just that patch / a job / the instance the test ran on etc. Need trace! :D [20:20:44] Let me find the specific failure [20:21:08] hashar: https://integration.wikimedia.org/ci/job/mwext-MultimediaViewer-qunit/2629/console [20:23:20] that is Java ? [20:23:41] ah no just super long URLs hehe [20:24:01] marktraceur: "Unfinished animations: 1" is a recurring issue iirc [20:24:21] (03PS9) 10Gergő Tisza: Show popup when the user visits a file page the first time after disabling MMV [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 [20:25:04] (03CR) 10jenkins-bot: [V: 04-1] Show popup when the user visits a file page the first time after disabling MMV [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 (owner: 10Gergő Tisza) [20:25:27] marktraceur: Matthew filled a bug about it https://bugzilla.wikimedia.org/show_bug.cgi?id=68884 but you would probably need Timo to have a look at it. I am pretty sure he already commented/documented it somewhere [20:25:32] Fun. [20:25:33] unfinished animations has to do with sinon.js messing with the timer, I think [20:26:19] not much more I can do I am afraid [20:33:50] (03PS10) 10Gergő Tisza: Show popup when the user visits a file page the first time after disabling MMV [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 [20:35:29] (03CR) 10Gergő Tisza: Show popup when the user visits a file page the first time after disabling MMV (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 (owner: 10Gergő Tisza) [20:40:53] 3MediaWiki / 3Uploading: The column us_props is missing from the mediawiki.uploadstash table with PostgreSQL - 10https://bugzilla.wikimedia.org/63893#c5 (10Mark Holmquist) Is this fixed, now? [20:45:22] marktraceur: re $.triggerHandler, I think the problem is that you use that but mock $.trigger in the tests [20:45:55] Oh! [20:46:03] I didn't do that, gi11es did, but easy to fix [20:47:07] (03PS12) 10MarkTraceur: Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 [20:47:10] Bam, done. [20:47:45] (03CR) 10jenkins-bot: [V: 04-1] Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [20:48:03] Gorram it [20:49:22] also, the mock should return something I suppose? [20:49:36] or the code should handle not getting back a deferred [20:50:10] Oh, right. [20:53:49] Ta daaa [20:54:03] (03PS13) 10MarkTraceur: Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 [20:57:06] (03PS9) 10Gergő Tisza: Cog icon & mw.ui styling for expand button [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164529 [20:57:13] (03PS11) 10Gergő Tisza: Show popup when the user visits a file page the first time after disabling MMV [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/164530 [21:52:31] (03CR) 10Gilles: [C: 04-1] Add viewing options panel (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [21:56:05] (03CR) 10MarkTraceur: Add viewing options panel (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [22:07:20] (03CR) 10Gilles: Add viewing options panel (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [22:07:46] Agh [22:07:50] gi11es: Isn't that a problem? [22:08:37] I don't think so, the point of DI is that we should be able to instantiate those where we need them [22:08:55] they're pretty shallow, aren't they? always getting their values form the source? [22:08:55] KK. [22:09:03] I wasn't totally sure [22:09:13] if they're doing caching of any kind, it can be made "static" (shared across instances) [22:10:00] Right. [22:10:13] yeah, glancing at the code, they wouldn't get out of sync [22:14:21] OK, I'll fix 'er [22:20:18] (03PS21) 10MarkTraceur: Add viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 [22:21:16] (03CR) 10MarkTraceur: Add viewing options panel (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [22:21:18] (03CR) 10jenkins-bot: [V: 04-1] Add viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [22:21:40] Arghhh [22:21:46] marktraceur: you left the config object in mmv.js? [22:21:55] might be what it's complaining about [22:22:05] No, the config object in mmv.js is used other places [22:22:11] I messed up a variable somehow [22:22:11] ah, I see [22:22:32] (03PS22) 10MarkTraceur: Add viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 [22:29:45] (03PS14) 10Gilles: Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [22:30:36] (03CR) 10jenkins-bot: [V: 04-1] Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [22:31:15] (expected, I only rebased) [22:32:04] Oh. [22:34:08] I'm going to fix it [22:34:21] Awesome [22:34:27] gi11es: It's late there! [22:34:40] Well past beer o'clock. [22:34:54] well, like I said in my email, I have to do my monday's workload over the weekend [22:35:00] Ah right [22:35:05] gi11es: Good luck, by the way [22:47:25] (03PS15) 10Gilles: Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [22:48:13] (03PS23) 10Gilles: Add viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/148880 (owner: 10MarkTraceur) [22:48:57] (03PS16) 10Gilles: Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [22:52:00] (03CR) 10jenkins-bot: [V: 04-1] Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [22:53:36] (03PS17) 10Gilles: Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur) [23:27:41] (03PS18) 10Gilles: Add tests for viewing options panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/166783 (owner: 10MarkTraceur)