[09:25:52] (03CR) 10Gilles: "My point was that you can try to call the function and then resort to something like what you're doing now if the function still returns s" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169919 (owner: 10Gergő Tisza) [09:40:46] (03CR) 10Gilles: [C: 032] Display a placeholder text when author and source are missing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169697 (owner: 10Gergő Tisza) [09:41:31] (03Merged) 10jenkins-bot: Display a placeholder text when author and source are missing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169697 (owner: 10Gergő Tisza) [09:48:55] (03CR) 10Gilles: [C: 032] Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur) [09:49:30] (03Merged) 10jenkins-bot: Make tutorial step a controller and UI class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/151785 (owner: 10MarkTraceur) [09:55:56] (03CR) 10Gilles: Move setSkipTutorialPreference to Tutorial class (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153413 (owner: 10MarkTraceur) [10:01:53] (03PS8) 10Gilles: Move setSkipTutorialPreference to Tutorial class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153413 (owner: 10MarkTraceur) [10:02:48] (03CR) 10Gilles: [C: 032] Move setSkipTutorialPreference to Tutorial class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153413 (owner: 10MarkTraceur) [10:03:21] (03Merged) 10jenkins-bot: Move setSkipTutorialPreference to Tutorial class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153413 (owner: 10MarkTraceur) [10:03:37] (03PS8) 10Gilles: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [10:33:43] (03CR) 10Gilles: [C: 04-1] "I get a JS error when I attempt to go from deeds to details:" (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [11:58:56] 3MediaWiki / 3File management: Upload new file version: Auto convert image file format - Add info afterwards - 10https://bugzilla.wikimedia.org/72555#c4 (10Andre Klapper) p:5Unprio>3Low Exact and specific steps to reproduce still welcome. (There are several ways to upload files etc.) Or posting on https:... [12:06:42] 3MediaWiki / 3Uploading: Add chunked upload support to standard Special:Upload for files larger than POST limit - 10https://bugzilla.wikimedia.org/72768 (10Andre Klapper) p:5Unprio>3Normal [12:16:13] 3MediaWiki extensions / 3PdfHandler: Not working on MW1.23 - 10https://bugzilla.wikimedia.org/72349#c3 (10mrmax) (In reply to mrmax from comment #2) > (In reply to Andre Klapper from comment #1) > > Have you asked on https://www.mediawiki.org/wiki/Project:Support_desk yet? > > Have you checked http://www.med... [15:14:32] * marktraceur is looking forlornly at UploadWizard again today [15:19:49] (03CR) 10Gergő Tisza: "It doesn't return anything and does DOM manipulation. I'm not sure that function is the one that actually gets passed, but in general I wo" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169919 (owner: 10Gergő Tisza) [16:02:26] Ugh, the upload handling stuff is so nasty [16:02:45] Checking global state in the upload objects is not cool [16:07:41] 3MediaWiki / 3File management: Upload new file version: Auto convert image file format - Add info afterwards - 10https://bugzilla.wikimedia.org/72555#c5 (10Subfader) 5UNCO>3RESO/WON Closing. As said, I found out the non-working MIME detection caused this. [16:20:07] (03PS1) 10MarkTraceur: Move showTooManyFilesWarning to the wizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 [16:46:08] (03PS1) 10MarkTraceur: Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 [16:47:35] (03PS1) 10MarkTraceur: Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 [16:47:41] Just shovel it all out of the bloody upload objects [17:08:12] 3MediaWiki extensions / 3PdfHandler: Not working on MW1.23 - 10https://bugzilla.wikimedia.org/72349#c4 (10Andre Klapper) I'd recommend to also give https://www.mediawiki.org/wiki/Project:Support_desk and maybe https://www.mediawiki.org/wiki/Extension_talk:PdfHandler a try... For general debug info: http://w... [17:14:44] (03CR) 10jenkins-bot: [V: 04-1] Move showTooManyFilesWarning to the wizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 (owner: 10MarkTraceur) [17:16:01] (03CR) 10jenkins-bot: [V: 04-1] Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 (owner: 10MarkTraceur) [17:16:05] (03CR) 10jenkins-bot: [V: 04-1] Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 (owner: 10MarkTraceur) [17:19:18] (03PS12) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [17:19:32] (03PS6) 10MarkTraceur: Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 [17:19:39] (03PS2) 10MarkTraceur: Remove reservedIndex [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170170 [17:19:44] (03PS2) 10MarkTraceur: Move showTooManyFilesWarning to the wizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 [17:23:32] (03CR) 10jenkins-bot: [V: 04-1] Move showTooManyFilesWarning to the wizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 (owner: 10MarkTraceur) [17:24:43] (03PS2) 10MarkTraceur: Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 [17:24:58] (03PS2) 10MarkTraceur: Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 [17:25:17] (03CR) 10jenkins-bot: [V: 04-1] Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 (owner: 10MarkTraceur) [17:25:31] (03CR) 10jenkins-bot: [V: 04-1] Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 (owner: 10MarkTraceur) [17:26:07] (03PS3) 10MarkTraceur: Move showTooManyFilesWarning to the wizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 [17:26:19] (03PS3) 10MarkTraceur: Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 [17:26:23] (03PS3) 10MarkTraceur: Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 [17:26:35] Rebase hellllll [17:27:16] (03CR) 10jenkins-bot: [V: 04-1] Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 (owner: 10MarkTraceur) [17:27:20] (03CR) 10jenkins-bot: [V: 04-1] Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 (owner: 10MarkTraceur) [17:27:30] Damn it [17:28:27] (03CR) 10Bartosz Dziewoński: "I expect that the doc-test will start passing after OOUI is update in core MediaWiki." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/170179 (https://bugzilla.wikimedia.org/70968) (owner: 10Bartosz Dziewoński) [17:28:32] (03PS4) 10MarkTraceur: Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 [17:28:45] (03PS4) 10MarkTraceur: Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 [17:30:57] 3MediaWiki / 3File management: Upload new file version: Auto convert image file format - Add info afterwards - 10https://bugzilla.wikimedia.org/72555 (10Andre Klapper) 5RESO/WON>3RESO/INV [18:34:28] 3MediaWiki extensions / 3PdfHandler: Not working on MW1.23 - 10https://bugzilla.wikimedia.org/72349#c5 (10mrmax) (In reply to Andre Klapper from comment #4) > I'd recommend to also give > https://www.mediawiki.org/wiki/Project:Support_desk and maybe > https://www.mediawiki.org/wiki/Extension_talk:PdfHandler... [18:52:55] Cheese and rice, those opt-out numbers are crazypants [18:53:38] interesting short thread/idea here: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_%28idea_lab%29#Less_intrusive_video_player_icon [18:54:18] (just regarding the "play icon" overlay. To somehow make it less dominating.) [18:54:23] Interesting [18:57:12] 3MediaWiki extensions / 3PdfHandler: Not working on MW1.23 - 10https://bugzilla.wikimedia.org/72349#c6 (10mrmax) Ok, I was able to activate debug log file and I guess I have the same problem like: https://bugzilla.wikimedia.org/show_bug.cgi?id=72044 [19:02:09] quiddity: Maybe pginer would be interested... [19:03:25] does he normally do IRC, or should I email it to him? [19:09:22] He sometimes does, but multimedia-l is probably best [19:25:48] * marktraceur cracks knuckles, strips more crap out of Upload objects [19:38:03] (03PS1) 10MarkTraceur: Move makePreviewsFlag out of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170385 [19:38:46] (03CR) 10jenkins-bot: [V: 04-1] Move makePreviewsFlag out of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170385 (owner: 10MarkTraceur) [19:59:42] (03PS2) 10MarkTraceur: Move makePreviewsFlag out of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170385 [20:06:15] (03PS1) 10MarkTraceur: Move extra-file handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170389 [20:06:28] Only 9 commits long? I can definitely hit 10 today. [20:12:28] (03CR) 10MarkTraceur: "Hm, I swear I fixed that. Like seven times. Let me try one more time." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 (owner: 10MarkTraceur) [20:14:53] (03PS9) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [20:15:03] (03PS13) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [20:15:26] (03PS10) 10MarkTraceur: Make details and deed steps more sane [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153431 [20:15:34] (03PS14) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [20:15:48] (03PS7) 10MarkTraceur: Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 [20:15:54] (03PS3) 10MarkTraceur: Remove reservedIndex [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170170 [20:15:57] (03PS4) 10MarkTraceur: Move showTooManyFilesWarning to the wizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 [20:16:02] (03PS5) 10MarkTraceur: Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 [20:16:05] (03PS5) 10MarkTraceur: Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 [20:16:09] (03PS3) 10MarkTraceur: Move makePreviewsFlag out of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170385 [20:16:14] (03PS2) 10MarkTraceur: Move extra-file handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170389 [20:16:37] ...they all needed to be rebased [20:34:14] (03CR) 10MarkTraceur: [C: 031] "Feel free to +2 if you want; I don't want to merge if I5fc37429a7dc7a8f1517fa42375cd140d7d11674 is required for this to work right." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169719 (owner: 10Gergő Tisza) [20:36:52] (03CR) 10MarkTraceur: [C: 031] "Code looks fine, address design issues then +2 at will" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 (owner: 10Gergő Tisza) [20:38:37] (03PS3) 10MarkTraceur: Remove below-the-fold description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169865 (owner: 10Gergő Tisza) [20:48:58] (03CR) 10MarkTraceur: [C: 031] "Once child commits go in, this should be fine." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169865 (owner: 10Gergő Tisza) [21:12:05] (03CR) 10MarkTraceur: [C: 031] "gi11es: If you can test this, I trust you to, I still don't have a testing setup for Flickr uploads, but the code looks fine and seems lik" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/168556 (https://bugzilla.wikimedia.org/65423) (owner: 10Gilles) [21:12:46] tgr: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/719 <-- is this still not finished? [21:58:26] 3MediaWiki / 3File management: Error generating thumbnail - OOM on progressive jpeg - 10https://bugzilla.wikimedia.org/69377#c3 (10Vera de Kok) Flickr2Commons didn't transfer a lot of the images from this photographer. Is this caused by the same problem + something that can be fixed? [23:01:28] marktraceur: You there? [23:02:12] James_F: No. What's up? [23:02:39] marktraceur: https://gerrit.wikimedia.org/r/#/c/170179/ fixes a breaking change in OOUI: https://gerrit.wikimedia.org/r/#/c/170171/ [23:03:04] marktraceur: We've merged the former, but I wanted to check it was OK to pull this through and merge that or if it would be bad for your team at this point. [23:03:17] Err. We've merged the /latter/. [23:06:35] James_F: Test it and go nuts, I don't think we're touching that right now [23:06:57] OK. [23:25:50] (03PS2) 10Jforrester: Change OO.ui.InlineMenuWidget → OO.ui.DropdownWidget for OOUI upgrade [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/170179 (https://bugzilla.wikimedia.org/70968) (owner: 10Bartosz Dziewoński) [23:26:40] (03CR) 10jenkins-bot: [V: 04-1] Change OO.ui.InlineMenuWidget → OO.ui.DropdownWidget for OOUI upgrade [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/170179 (https://bugzilla.wikimedia.org/70968) (owner: 10Bartosz Dziewoński) [23:35:39] (03CR) 10Jforrester: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/170179 (https://bugzilla.wikimedia.org/70968) (owner: 10Bartosz Dziewoński) [23:37:40] (03CR) 10Jforrester: "Hmm. :-(" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/170179 (https://bugzilla.wikimedia.org/70968) (owner: 10Bartosz Dziewoński)