[00:22:00] (03PS1) 10Ori.livneh: Fix: "Undefined index: bandwidth" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/170867 [07:23:27] 3MediaWiki extensions / 3PdfHandler: PdfHandler: Incorrect aspect ratio of the preview images. - 10https://bugzilla.wikimedia.org/22194#c24 (10Thorsten) Problem reported on https://commons.wikimedia.org/wiki/COM:FORUM several times in the past few weeks for 1) https://commons.wikimedia.org/wiki/File:Yamaguch... [08:05:25] 3MediaWiki extensions / 3PdfHandler: PdfHandler: Incorrect aspect ratio of the preview images. - 10https://bugzilla.wikimedia.org/22194#c25 (10Ankry) This file: https://pl.wikisource.org/wiki/Plik:Maryan_Smoluchowski-O_atmosferze_ziemi_i_planet.pdf is also still displayed with wrong aspect ratio. Any timeli... [09:50:27] pginer: you said the metadata panel does not open when you click the ellipsis, can you provide reproduction steps for that? [09:50:52] with the 169785 changeset [10:09:51] tgr, steps are just to click a very long caption. I created a sequence of screenshots: http://imgur.com/a/anr6z [10:10:10] The image I used is File:El_Greco_View_of_Toledo.jpg [10:10:59] The captionI used has 515 characters (in 87 words) [10:33:41] (03CR) 10Gilles: [C: 04-1] "Still happens: https://www.dropbox.com/s/vx5iq6qa6jrxcok/Screenshot%202014-11-04%2011.32.49.png?dl=0" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [10:34:45] (03CR) 10Gilles: [C: 032] Fix: "Undefined index: bandwidth" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/170867 (owner: 10Ori.livneh) [10:35:08] (03Merged) 10jenkins-bot: Fix: "Undefined index: bandwidth" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/170867 (owner: 10Ori.livneh) [11:22:45] (03PS5) 10Gergő Tisza: Make the ellipsis of truncated texts more prominent [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 [11:23:20] (03CR) 10Gergő Tisza: "Fixed non-ellipsis-related design issues." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 (owner: 10Gergő Tisza) [14:53:11] (03CR) 10Anomie: Add i18n for API module help (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169844 (owner: 10Anomie) [15:34:47] (03PS1) 10Cmcmahon: QA: date created is now a required field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170932 [15:35:10] Well, it always was. [15:35:21] (03CR) 10Cmcmahon: [C: 032] "maintenance" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170932 (owner: 10Cmcmahon) [15:35:43] (03CR) 10MarkTraceur: QA: date created is now a required field (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170932 (owner: 10Cmcmahon) [15:35:50] Self +2! [15:35:51] Shaaaaame [15:36:03] (03Merged) 10jenkins-bot: QA: date created is now a required field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170932 (owner: 10Cmcmahon) [16:25:18] 3MediaWiki / 3File management: Duplicate-archive files not detected (previously deleted files when uploading identical [SHA1] files) when file extension is upper case - 10https://bugzilla.wikimedia.org/72070#c1 (10Umherirrender) see also bug 41858 [16:29:10] This makes no sense [16:29:26] The conditional is true [16:29:33] So it should be passed in and toggle the class [16:34:51] Oh, it's because I forgot a step. I hate computers sometimes [16:35:02] (03PS20) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [16:35:07] A lot of the time* [16:40:07] (03CR) 10jenkins-bot: [V: 04-1] Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [16:40:13] Shush jenkins. [16:41:09] (03PS21) 10MarkTraceur: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 [16:43:27] (03CR) 10Gilles: [C: 032] Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [16:44:13] Woohoo [16:45:19] http://media.tumblr.com/495a233ca1a3f6518c51d530337cd986/tumblr_inline_n6btpuMZiP1qafrh6.gif [16:45:34] Hah [16:49:34] (03Merged) 10jenkins-bot: Move updateFileCounts to the upload controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/153632 (owner: 10MarkTraceur) [16:50:01] (03PS8) 10Gilles: Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 (owner: 10MarkTraceur) [16:54:29] I guess I should take Roan's suggestions...well, they were stylistic. I'm pretty much OK without them. [17:00:04] if it shortens the code, I'm all for it [17:00:21] Aww. [17:00:27] Merger says do it, do it. v.v [17:01:37] is it just me, or are we getting a lot more ML spam than we used to? [17:01:45] A little bit [17:01:55] Maybe someone posted it in The Wrong Place. [17:02:58] you mean that encyclopaedia that keeps asking me for money? [17:04:04] Could be [17:09:12] I probably won't move them to proper methods, though [17:41:31] (03CR) 10Gilles: [C: 04-1] "The caption expands automatically when I scroll down. Was that requested? I don't see it on the Mingle ticket nor in Pau's comments." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 (owner: 10Gergő Tisza) [17:45:16] (03CR) 10Gilles: [C: 031] Replace filename with caption/description [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169719 (owner: 10Gergő Tisza) [17:46:18] (03CR) 10Gilles: "Rather, it seems to be pre-existing behavior that was there for long filenames, that we might not want to keep with the new ellipsis mecha" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 (owner: 10Gergő Tisza) [17:46:57] pginer: when you have a second, please clarify what you want done in regards to auto-expand on that ticket ^ [17:47:26] gi11es: yeah, that was added when truncation of long titles / credits was introduced, it was just hard to find a long title until now [17:55:08] (03PS9) 10MarkTraceur: Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 [17:55:12] gi11es: All you, mate [18:03:12] (03PS4) 10MarkTraceur: Remove reservedIndex [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170170 [18:29:38] : Hey gi11es tgr : How are things going on the Media Viewer front? Does the new ellipsis design from pginer look like it’s going to address our issues with showing long captions above the fold? Would you like me to test anything yet? Also, were we able to revert the layout changes for this week’s deploys? [18:31:21] the revert was done for commons, and if the ellipsis implementation isn't complete by tomorrow we'll do the same for the next deploy window [18:33:27] I cannot figure out for the life of me what NSID stands for [18:33:35] Logically it should be namespace [18:33:39] But it's used to identify USERS. [18:33:42] WTF is this [18:33:54] Eff it, I'll just say user id [18:35:12] (03CR) 10Gilles: [C: 032] Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 (owner: 10MarkTraceur) [18:35:53] (03Merged) 10jenkins-bot: Move stupid DOM-bound events to OO EE syntax [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170131 (owner: 10MarkTraceur) [18:36:29] (03PS2) 10MarkTraceur: Add i18n for API module help [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169844 (owner: 10Anomie) [18:37:00] (03CR) 10MarkTraceur: [C: 032] "Minor changes, given I pretty much directly fixed the issues I'm +2ing the rest. Thanks anomie!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169844 (owner: 10Anomie) [18:38:40] (03Merged) 10jenkins-bot: Add i18n for API module help [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/169844 (owner: 10Anomie) [18:38:44] Yay. [18:40:44] Hm, we still haven't merged https://gerrit.wikimedia.org/r/127460 [18:40:49] The SHA-1 storage patch [18:40:55] gi11es, tgr, should we do that soon? [18:41:12] someone need to review my additions [18:41:28] Ah. [18:41:32] Aaron, maybe. [18:41:42] presumably, Aaron, since he found issues I wouldn't have found myself [18:41:49] Right. [18:41:55] Where's Aaron when you need 'im [18:49:25] (03CR) 10MarkTraceur: [C: 04-1] "Needs a serious rebase." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/47837 (https://bugzilla.wikimedia.org/43408) (owner: 10Nischayn22) [19:01:55] marktraceur (and others) [19:02:13] Yeeeees? [19:02:25] marktraceur (and others): https://gerrit.wikimedia.org/r/170907 in VisualEditor may be of mild interest. A customer for UploadWizard-as-a-service, when it's available. :-) [19:02:34] Ugh [19:02:38] @todo [19:02:39] (03CR) 10Gilles: [C: 032] "If it breaks someone's workflow, I'm sure we'll hear about it." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170170 (owner: 10MarkTraceur) [19:02:42] (Sorry, over-enthusiastic keyboard.) [19:03:07] gi11es: That's the spirit! [19:03:15] (03Merged) 10jenkins-bot: Remove reservedIndex [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170170 (owner: 10MarkTraceur) [19:03:16] obligatory xkcd comic: http://xkcd.com/1172/ [19:03:17] marktraceur: Hey, I laughed. [19:03:55] tgr: <3 [19:05:08] marktraceur: next one can't be autorebased [19:05:11] by gerrit anyway [19:05:16] Yeah, I know [19:05:19] I'll do it [20:07:32] gi11es: Thanks for the update about the Media Viewer improvements, much appreciated. :) Please let me know if I can help test the work in progress at any point. [20:11:28] *sigh* what's going on with sound files [20:13:44] possibly only broken on my cell phone [20:44:30] 3MediaWiki extensions / 3TimedMediaHandler: Audio player not shown on android native browser - 10https://bugzilla.wikimedia.org/72975 (10Bawolff (Brian Wolff)) 3NEW p:3Unprio s:3normal a:3None Probably related to 9649253f6b8329 ---- On my cell phone, when browsing the desktop site, the media player... [21:58:02] (03PS5) 10MarkTraceur: Move showTooManyFilesWarning to the wizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 [21:58:15] (03PS6) 10MarkTraceur: Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 [21:58:22] (03PS6) 10MarkTraceur: Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 [23:41:35] (03PS6) 10Gergő Tisza: [WIP] Make the ellipsis of truncated texts more prominent [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 [23:42:22] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Make the ellipsis of truncated texts more prominent [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/169785 (owner: 10Gergő Tisza)