[00:05:51] <wikibugs>	 3MediaWiki / 3File management: Download this file link on description page (particularly relevant to svg) - 10https://bugzilla.wikimedia.org/25148#c3 (10Tisza Gergő) bug 25695 added a download URL, so the only thing needed is to expose that URL in a link. Marking as easy.
[00:10:36] <wikibugs>	 3MediaWiki / 3File management: File description page thumbnail click versus EXIF rotation, mustRender() - 10https://bugzilla.wikimedia.org/31366#c9 (10Tisza Gergő) 5PATC>3NEW This could be solved by linking to a full-size thumbnail instead of the original file if mustRender() is true. See bug 65383 for a...
[00:10:36] <wikibugs>	 3MediaWiki / 3File management: Serve thumbnails even for the original size of a jpeg or png - 10https://bugzilla.wikimedia.org/65383 (10Tisza Gergő)
[00:20:50] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: Support upload of audio-only WebM files (Vorbis audio track but no video) - 10https://bugzilla.wikimedia.org/72996#c1 (10Derk-Jan Hartman) 1: Warnings, fixed by Reedy due from Bug 73112 2: The MimeMagic.php of core is not able to recognize the contents of WebM file...
[00:22:10] <grrrit-wm>	 (03PS1) 10TheDJ: Support WebM Vorbis files in the player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174325 (https://bugzilla.wikimedia.org/72996) 
[00:29:37] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: Media handler interface is misaligned inside a table - 10https://bugzilla.wikimedia.org/72758#c1 (10Derk-Jan Hartman) Created attachment 17166   --> https://bugzilla.wikimedia.org/attachment.cgi?id=17166&action=edit aligns when applying appropriate styling  It's no...
[00:29:50] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: Media handler interface is misaligned inside a table - 10https://bugzilla.wikimedia.org/72758 (10Derk-Jan Hartman) 5NEW>3RESO/INV
[00:34:21] <grrrit-wm>	 (03PS2) 10TheDJ: Make sure jquery.ui.dialog is loaded if there are pop up videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108472 (https://bugzilla.wikimedia.org/72437) (owner: 10Brian Wolff)
[00:34:24] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make sure jquery.ui.dialog is loaded if there are pop up videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/108472 (https://bugzilla.wikimedia.org/72437) (owner: 10Brian Wolff)
[00:49:37] <wikibugs>	 3MediaWiki extensions / 3MultimediaViewer: Media Viewer should display licensetpl_attr instead of author when set (by {{Credit line}} and other templates) - 10https://bugzilla.wikimedia.org/65445#c18 (10Guillaume Paumier) I've followed up at https://commons.wikimedia.org/wiki/Template_talk:Credit_line#Incons...
[00:51:33] <grrrit-wm>	 (03PS1) 10TheDJ: Add audio/webm to Special:TimedMediaHandler [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174333 
[08:46:07] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Dependency fix [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174300 (owner: 10TheDJ)
[08:46:22] <grrrit-wm>	 (03Merged) 10jenkins-bot: Dependency fix [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174300 (owner: 10TheDJ)
[09:01:59] <gi11es>	 marktraceur: tgr: either of you available to oversee the backport of a change during a SWAT? I can't attend my usual SWAT window today
[09:02:08] <gi11es>	 for https://gerrit.wikimedia.org/r/#/c/172969/
[09:15:06] <tgr>	 gi11es: I can do that in the Thursday 00-01h CET window if that's OK
[09:16:42] <gi11es>	 yeah that works for me
[09:16:45] <tgr>	 gi11es: what do you think about using ImageMetrics for https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/999 ?
[09:17:14] <tgr>	 it helps avoid extension proliferation, plus security review + deployment of a new extension is a pain in the ass
[09:17:35] <gi11es>	 it crossed my mind, but we might need to rename it. it's not about images in this case
[09:18:04] <gi11es>	 also, there's some stuff we tend to always do when we use EL (add country when available, etc.) that we might consider moving to EL itself
[09:18:35] <tgr>	 well ImageRelatedMetrics would have sounded silly, but that's really what the extension is about
[09:19:08] <gi11es>	 not even image related here :) UIMetrics I guess would be appropriate for a name that covers both
[09:19:13] <tgr>	 I would like to add a bunch of other loosely related metrics in the future, eg. what do people click on when they are on a file description page
[09:20:15] <tgr>	 IMO screen size is strongly related to images, which is not to say it cannot be used for other things
[09:20:33] <tgr>	 but it is needed to make informed decisions about default thumb size etc.
[09:20:47] <gi11es>	 there aren't any images in wikidata, they're really only interested in how they should design their UI best
[09:29:44] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Support WebM Vorbis files in the player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174325 (https://bugzilla.wikimedia.org/72996) (owner: 10TheDJ)
[09:29:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Support WebM Vorbis files in the player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174325 (https://bugzilla.wikimedia.org/72996) (owner: 10TheDJ)
[09:31:35] <wikibugs>	 3MediaWiki extensions / 3PdfHandler: Linker::makeImageLink: File: .... .pdf does not allow inline display - 10https://bugzilla.wikimedia.org/72044 (10Gilles Dubuc) 5NEW>3RESO/FIX
[09:37:40] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Add audio/webm to Special:TimedMediaHandler [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174333 (owner: 10TheDJ)
[09:39:00] <grrrit-wm>	 (03PS1) 10Gilles: Avoid undefined index warnings on $states array [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174385 
[09:41:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add audio/webm to Special:TimedMediaHandler [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174333 (owner: 10TheDJ)
[09:50:19] <grrrit-wm>	 (03CR) 10Gilles: "What you suggest introduces maintenance burden, whenever someone calls .off() on the shared object, they're likely to disable handlers in " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173916 (owner: 10Gilles)
[09:51:00] <grrrit-wm>	 (03CR) 10Gilles: "UI element instance, rather, not class." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173916 (owner: 10Gilles)
[09:52:21] <grrrit-wm>	 (03CR) 10Gilles: Turn mmv-next/mmv-prev into OO events (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173916 (owner: 10Gilles)
[10:08:42] <grrrit-wm>	 (03PS5) 10Gilles: Turn mmv-next/mmv-prev into OO events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173916 
[10:09:31] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Turn mmv-next/mmv-prev into OO events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173916 (owner: 10Gilles)
[10:11:37] <grrrit-wm>	 (03PS6) 10Gilles: Turn mmv-next/mmv-prev into OO events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173916 
[10:15:08] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: Support upload of audio-only WebM files (Vorbis audio track but no video) - 10https://bugzilla.wikimedia.org/72996#c4 (10Derk-Jan Hartman) 5PATC>3NEW So 3 is solved now !  We probably have a few more codec variants like webm opus with similar problems, and that...
[10:23:35] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: Audio player not shown on android native browser - 10https://bugzilla.wikimedia.org/72975#c1 (10Derk-Jan Hartman) Or possibly due to http://code.google.com/p/android/issues/detail?id=19436
[10:25:24] <wikibugs>	 3MediaWiki extensions / 3MultimediaViewer: Tipsy doesn't close when closing MultimediaViewer - 10https://bugzilla.wikimedia.org/72516 (10Gilles Dubuc) a:3Gilles Dubuc
[10:25:51] <wikibugs>	 3MediaWiki extensions / 3MultimediaViewer: Tipsy doesn't close when closing MultimediaViewer - 10https://bugzilla.wikimedia.org/72516#c2 (10Gilles Dubuc) I can finally reproduce this, yay
[10:30:09] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: Squished thumbnails for non standard resolution videos - 10https://bugzilla.wikimedia.org/47478#c2 (10Derk-Jan Hartman) This seems fixed now ? Can you confirm Reedy ?
[10:31:23] <wikibugs>	 3MediaWiki extensions / 3MultimediaViewer: Media Viewer ignores EXIF rotation - 10https://bugzilla.wikimedia.org/68320 (10Tisza Gergő)
[10:31:23] <wikibugs>	 3MediaWiki / 3File management: Image rotation issues (tracking) - 10https://bugzilla.wikimedia.org/31504 (10Tisza Gergő)
[10:31:51] <wikibugs>	 3MediaWiki / 3File management: Thumbnail chaining broken for soft-rotated images - 10https://bugzilla.wikimedia.org/73352 (10Tisza Gergő)
[10:31:55] <wikibugs>	 3MediaWiki / 3File management: Image rotation issues (tracking) - 10https://bugzilla.wikimedia.org/31504 (10Tisza Gergő)
[10:46:50] <grrrit-wm>	 (03PS1) 10Gilles: Get rid of phantom tipsy bubbles that can appear after closing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174388 (https://bugzilla.wikimedia.org/72516) 
[10:47:33] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Get rid of phantom tipsy bubbles that can appear after closing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174388 (https://bugzilla.wikimedia.org/72516) (owner: 10Gilles)
[10:53:53] <wikibugs>	 3MediaWiki / 3File management: Image rotation issues (tracking) - 10https://bugzilla.wikimedia.org/31504 (10Tisza Gergő)
[10:53:59] <wikibugs>	 3MediaWiki / 3File management: Mirrored EXIF rotations are not applied to thumbnails - 10https://bugzilla.wikimedia.org/73602 (10Tisza Gergő) 3NEW p:3Unprio s:3trivia a:3None EXIF allows 8 possible values for the Orientation field: 0°, 90°, 180°, 270°, and the same four for the mirror image of the or...
[10:59:49] <grrrit-wm>	 (03CR) 10Gilles: [C: 04-1] "Introduces other issues, investigating" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174388 (https://bugzilla.wikimedia.org/72516) (owner: 10Gilles)
[11:02:55] <gi11es>	 https://github.com/briancray/tooltipsy/blob/master/tooltipsy.source.js#L43 fuck you, tipsy
[11:08:35] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: Media handler interface is misaligned inside a table - 10https://bugzilla.wikimedia.org/72758#c2 (10Helder) Created attachment 17171   --> https://bugzilla.wikimedia.org/attachment.cgi?id=17171&action=edit The triangle does not align if the player is inside a table...
[11:13:55] <grrrit-wm>	 (03PS2) 10Gilles: Get rid of phantom tipsy bubbles that can appear after closing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174388 (https://bugzilla.wikimedia.org/72516) 
[11:37:07] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: Media handler interface is misaligned inside a table - 10https://bugzilla.wikimedia.org/72758#c3 (10Diego Queiroz) (In reply to Helder from comment #2) > Created attachment 17171 [details] > The triangle does not align if the player is inside a table >  > I don't t...
[12:03:06] <marktraceur>	 gi11es: Yeah sure
[12:03:36] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: Media handler interface is misaligned inside a table - 10https://bugzilla.wikimedia.org/72758 (10Helder) 5RESO/INV>3REOP
[12:33:20] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: Script error mw.EmbedPlayerNative.js at line 0 - 10https://bugzilla.wikimedia.org/56353#c6 (10Derk-Jan Hartman) At the end of the play, this is triggered:  // dont show credits for audio elements, // seek to begining instead if( embedPlayer.isAudio() ){     embedPl...
[12:46:15] <grrrit-wm>	 (03PS1) 10TheDJ: Fix undefined error on end of play of native <audio> [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174407 (https://bugzilla.wikimedia.org/56353) 
[12:54:21] <wikibugs>	 3MediaWiki / 3File management: Mirrored EXIF rotations are not applied to thumbnails - 10https://bugzilla.wikimedia.org/73602 (10Andre Klapper) p:5Unprio>3Normal
[13:40:05] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: Namespace mw.MwEmbedSupport methods - 10https://bugzilla.wikimedia.org/60295#c1 (10Derk-Jan Hartman) Some of them I confused several times over the past 3 days. Some of them don't even have namespacing over their RL module names.  On my list of 'todos at some point...
[13:51:36] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: Wrong character encoding of URL provided to media player - 10https://bugzilla.wikimedia.org/56538#c5 (10Derk-Jan Hartman) No longer able to reproduce. Anyone else ?
[14:05:36] <wikibugs>	 3MediaWiki extensions / 3PdfHandler: Linker::makeImageLink: File: .... .pdf does not allow inline display - 10https://bugzilla.wikimedia.org/72044#c17 (10carchaias) I tried the same (adding $wgPdfHandlerDpi = '150'; to LocalSettings.php, reupload a file). But when delete a file and reupload in Wiki I get a p...
[14:51:20] <wikibugs>	 3MediaWiki extensions / 3UploadWizard: Extract heading (=Direction of image) from EXIF/metadata and add it to location template - 10https://bugzilla.wikimedia.org/37925#c4 (10El Grafo) The relevant EXIF field seems to be Exif.GPSInfo.GPSImgDirection – it contains the heading in degrees, which could be direct...
[14:59:35] <wikibugs>	 3MediaWiki extensions / 3UploadWizard: Extract heading (=Direction of image) from EXIF/metadata and add it to location template - 10https://bugzilla.wikimedia.org/37925#c5 (10El Grafo) Addendum: The template does not only accept the camera heading in degrees (0-359) but also letter combinations like SE for s...
[15:03:36] <wikibugs>	 3MediaWiki / 3File management: Download this file link on description page (particularly relevant to svg) - 10https://bugzilla.wikimedia.org/25148#c4 (10Andre Klapper) Gergő: Would that be a potential Google Code-In task that you could imagine to mentor? See https://www.mediawiki.org/wiki/Google_Code-in_2014...
[15:16:34] <grrrit-wm>	 (03PS1) 10Lokal Profil: Fix typo in API message [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/174418 
[15:34:20] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: Wrong character encoding of URL provided to media player - 10https://bugzilla.wikimedia.org/56538#c6 (10Bawolff (Brian Wolff)) I fixed a similar issue a whileback, maybe it fixed this one.
[15:35:43] <grrrit-wm>	 (03PS12) 10MarkTraceur: Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 
[15:35:51] <marktraceur>	 gi11es: Misreading conditionals, sigh, sorry about that
[15:38:03] <grrrit-wm>	 (03CR) 10Nemo bis: [C: 031] "Thanks!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/174418 (owner: 10Lokal Profil)
[15:39:17] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Fix typo in API message [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/174418 (owner: 10Lokal Profil)
[15:39:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix typo in API message [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/174418 (owner: 10Lokal Profil)
[17:40:15] <tgr>	 ahh, damn
[17:40:28] <tgr>	 I was so sure the meetings start at 10 SF time
[17:41:33] <marktraceur>	 :)
[17:41:50] <marktraceur>	 tgr: You have to do all the work this week, sorry
[17:52:06] <wikibugs>	 3MediaWiki extensions / 3UploadWizard: beta labs: "error while storing the file in the stash.' - 10https://bugzilla.wikimedia.org/73229 (10Greg Grossmeier) p:5Unprio>3Highes
[17:52:25] <marktraceur>	 greg-g: Your face is highest priority
[17:52:50] <marktraceur>	 We're waiting on logs for that.
[17:53:23] <greg-g>	 yeah, just talking with Reedy about it now
[17:53:27] <marktraceur>	 KK
[17:53:35] <marktraceur>	 Tell Reedy to fix LDAP too
[17:53:40] <greg-g>	 looks related: https://bugzilla.wikimedia.org/show_bug.cgi?id=73206
[17:53:42] <Reedy>	 Fuck LDAP.
[17:55:55] <greg-g>	 marktraceur: and what do you mean waiting on logs for it?
[17:56:17] <greg-g>	 Add wgDebugLog group for FSFileBackend is merged
[17:56:19] <marktraceur>	 greg-g: The patch in 73229 adds log entries for when the bug occurs, to my understanding
[17:56:27] <marktraceur>	 But doesn't fix the bug
[17:56:30] <greg-g>	 'tis merged
[17:56:32] <marktraceur>	 Right
[17:56:37] <marktraceur>	 So we need someone to trigger the bug again
[17:56:38] <greg-g>	 so you have logs, no?
[17:56:40] <greg-g>	 I just did
[17:56:43] <marktraceur>	 In order to find out what...oh!
[17:56:44] <greg-g>	 go look!
[17:56:47] <marktraceur>	 Well, gi11es, fix it, christ
[17:56:50] <greg-g>	 hah
[17:57:03] <greg-g>	 just uh, try to upload a file with UW, pretty simple repro case
[17:57:06] <marktraceur>	 NO SLEEP, ONLY BUGS
[17:57:12] <marktraceur>	 Wait, *any* file?
[17:57:13] <marktraceur>	 What
[17:57:22] <greg-g>	 I tried a png, if it matters
[17:57:40] <gi11es>	 you're talking about different things
[17:57:46] <greg-g>	 heh, of course
[17:57:55] <gi11es>	 beta being broken != the bug I added log calls for
[17:58:05] <gi11es>	 beta being broken is the LDAP thing
[17:58:11] <greg-g>	 well dammit, that makes things harder
[17:58:15] <greg-g>	 :)
[17:58:26] * marktraceur attempts to breathe again
[17:58:27] <greg-g>	 anywho, I made the stash error appear, if that helps
[17:59:32] <gi11es>	 oh yes I added a log call to that too... that was before I knew that it was the apache user thing
[17:59:47] <gi11es>	 by the time I discovered the source antoine introduced me to the known apache user issue
[17:59:55] <gi11es>	 anyway, you know what to do :)
[18:00:28] <greg-g>	 wait, I do? what do I do? :)
[18:00:38] <marktraceur>	 Bust a move
[18:00:59] <greg-g>	 which known apache user issue?
[18:01:02] <gi11es>	 magic magic unix user magic
[18:01:09] <gi11es>	 Reedy knows
[18:01:23] <greg-g>	 heh
[18:01:38] <gi11es>	 https://bugzilla.wikimedia.org/show_bug.cgi?id=73206 for details
[18:03:40] <greg-g>	 he knows-ish for that one
[18:04:06] <gi11es>	 he's trying, he'll get a chocolate medal for effort
[18:04:09] <greg-g>	 that's what we were talking about first, then I read the UW stash error one and was "well crap, that ain't good at all!"
[18:04:28] <gi11es>	 and it's actually the same thing!
[18:04:36] <greg-g>	 liar!
[18:04:47] <gi11es>	 in fact, there's more, because anything trying to write files on commons beta will fail miserably
[18:05:01] <gi11es>	 so that dude at the hackathon couldn't work with gwtoolset anymore
[18:05:08] <gi11es>	 much to his finnish sadness
[18:05:12] <greg-g>	 Dan
[18:05:21] <gi11es>	 Ari
[18:05:23] <greg-g>	 oh, Dan's not Finnish
[18:05:40] <marktraceur>	 Dan was in Asia for some reason IIRC
[18:05:57] <gi11es>	 *some reason*
[18:06:34] <marktraceur>	 Murdering kittens maybe. Dan could not be reached for comment. That kitten murdering bastard. Allegedly.
[18:06:48] <gi11es>	 according to a reliable source on 4chan
[18:07:15] <marktraceur>	 (4chan|wikipedia): Hey, at least we aren't (wikipedia|4chan)!
[18:11:29] <gi11es>	 tgr: https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=135011&oldid=135009
[18:13:36] <wikibugs>	 3MediaWiki / 3File management: Serve thumbnails even for the original size of a jpeg or png - 10https://bugzilla.wikimedia.org/65383#c6 (10C. Scott Ananian) Having had some additional experience with OCG, I'm leaning more toward comment 4 -- I've seen a lot of really terribly-encoded files, with crazy densit...
[19:00:17] <tgr>	 do we have a card for investigating the browser test failures?
[19:01:09] <tgr>	 the last success was over a week ago, they seem to fail at opening the download panel
[19:15:35] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Get rid of phantom tipsy bubbles that can appear after closing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174388 (https://bugzilla.wikimedia.org/72516) (owner: 10Gilles)
[19:16:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Get rid of phantom tipsy bubbles that can appear after closing [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174388 (https://bugzilla.wikimedia.org/72516) (owner: 10Gilles)
[19:23:18] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Make sure that the metadata panel isn't expanded by default in IE [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/172953 (https://bugzilla.wikimedia.org/73337) (owner: 10Gilles)
[19:23:22] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Make sure that the metadata panel isn't expanded by default in IE [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/172953 (https://bugzilla.wikimedia.org/73337) (owner: 10Gilles)
[19:23:25] <marktraceur>	 Booooo
[19:23:42] <marktraceur>	 gi11es: You crazy guy, it needs a rebase
[19:23:44] <tgr>	 we have now: https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/1008
[19:24:01] <marktraceur>	 tgr: I think it's probably 73337
[19:24:06] <marktraceur>	 Slash #996
[19:24:18] <marktraceur>	 Which just needs a rebase
[19:25:00] <tgr>	 ah, cool, missed that one
[19:25:09] <tgr>	 I'll delete the other card then
[19:25:43] <marktraceur>	 Rockin'
[19:42:14] <grrrit-wm>	 (03PS8) 10Gergő Tisza: Add marker parameter to image requests coming from MediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173641 (owner: 10Gilles)
[19:47:08] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 04-1] Add marker parameter to image requests coming from MediaViewer (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173641 (owner: 10Gilles)
[19:53:20] <wikibugs>	 3MediaWiki extensions / 3MultimediaViewer: Tipsy doesn't close when closing MultimediaViewer - 10https://bugzilla.wikimedia.org/72516#c5 (10Tisza Gergő) 5PATC>3RESO/FIX Doesn't seem to happen any more.
[20:05:35] <wikibugs>	 3MediaWiki / 3File management: Download this file link on description page (particularly relevant to svg) - 10https://bugzilla.wikimedia.org/25148#c5 (10Tisza Gergő) Sure. Should I sign up as a mentor?
[20:07:44] <marktraceur>	 tgr: I think I prefer your solution to #973, should I merge that or do you and gi11es want to have at it for a bit first?
[20:17:24] <wikibugs>	 3MediaWiki extensions / 3PdfHandler: Linker::makeImageLink: File: .... .pdf does not allow inline display - 10https://bugzilla.wikimedia.org/72044#c18 (10Tisza Gergő) Carchaias, sounds like a permission problem. The directory is presumably your system default directory for temporary files. (See [[mw:Manual:$...
[20:24:20] <wikibugs>	 3MediaWiki extensions / 3PdfHandler: Linker::makeImageLink: File: .... .pdf does not allow inline display - 10https://bugzilla.wikimedia.org/72044#c19 (10Tisza Gergő) I'm not convinced this is fixed. $wgPdfHandlerDpi has 150 as its default value (and that default has been added seven years ago), setting that...
[20:48:43] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 04-1] "I think this will count two unviews for every lightbox close." (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173515 (owner: 10Gilles)
[21:01:39] <grrrit-wm>	 (03CR) 10Gergő Tisza: "...no it won't because it has a no-dupe flag. Still the handler should be removed on exit IMO. (The mere existence of a beforeunload handl" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173515 (owner: 10Gilles)
[21:54:53] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 031] "Removing -1 since the problematic code is removed in the next commit. Feel free to +2 if that commit is going to be merged (I wasn't sure " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173515 (owner: 10Gilles)
[22:19:54] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 04-1] "* say the user clicks next, prev, next, prev, then this code will log 5 image views instead of logging 2 with the times summed up. Depdend" (038 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173640 (owner: 10Gilles)
[22:29:34] <grrrit-wm>	 (03CR) 10Gergő Tisza: Track the most recent upload time for duration events (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/171228 (owner: 10Gilles)
[22:42:54] <tgr>	 marktraceur: you should ask gi11es 
[22:43:07] <tgr>	 unsurprisingly, I prefer my solution as well :)
[22:43:08] <marktraceur>	 Okiee.
[22:43:42] <tgr>	 although I did forget to apply the fix to the commonmetadata API, but no one uses that anyway
[22:43:54] <marktraceur>	 Indeed
[22:44:32] <tgr>	 I can do that in a followup
[22:56:37] <wikibugs>	 3MediaWiki extensions / 3PdfHandler: Linker::makeImageLink: File: .... .pdf does not allow inline display - 10https://bugzilla.wikimedia.org/72044#c20 (10Rob Kam) LocalSettings.php: require_once "$IP/extensions/PdfHandler/PdfHandler.php"; $wgPdfPostProcessor = $wgImageMagickConvertCommand; // defined via Ima...
[23:10:50] <wikibugs>	 3MediaWiki extensions / 3PdfHandler: Linker::makeImageLink: File: .... .pdf does not allow inline display - 10https://bugzilla.wikimedia.org/72044#c21 (10Tisza Gergő) And if you remove that line from LocalSettings.php, PDF uploads break again? Also, could you test what happens if you set it as a number and n...
[23:59:50] <wikibugs>	 3MediaWiki extensions / 3PdfHandler: Linker::makeImageLink: File: .... .pdf does not allow inline display - 10https://bugzilla.wikimedia.org/72044#c22 (10Rob Kam) I think it's not $wgPdfHandlerDpi = '150'; - I've removed that from LocalSettings,php and uploaded a pdf. It's dimensions are then given as 0 × 0...