[00:03:26] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] "> On average the odds that the JS is already loaded for the first image should be the same regardless of the image's upload date." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/171228 (owner: 10Gilles)
[00:04:16] <grrrit-wm>	 (03Merged) 10jenkins-bot: Track the most recent upload time for duration events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/171228 (owner: 10Gilles)
[00:44:35] <wikibugs>	 3MediaWiki extensions / 3PdfHandler: Linker::makeImageLink: File: .... .pdf does not allow inline display - 10https://bugzilla.wikimedia.org/72044#c23 (10Tisza Gergő) That makes sense, wfShellExec() uses proc_get_status(). Thanks for getting to the bottom of that!  If you think a clearer warning would have b...
[00:57:52] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: "vid is undefined" or "Cannot read property 'readyState' of undefined" after playing an audio file - 10https://bugzilla.wikimedia.org/67403 (10Derk-Jan Hartman)
[00:57:52] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: Script error mw.EmbedPlayerNative.js at line 0 - 10https://bugzilla.wikimedia.org/56353 (10Derk-Jan Hartman)
[01:00:03] <grrrit-wm>	 (03PS3) 10Jforrester: Update OOjs UI Class Names (549ff9ab7d) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173987 (owner: 10Trevor Parscal)
[01:00:51] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Update OOjs UI Class Names (549ff9ab7d) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173987 (owner: 10Trevor Parscal)
[01:05:03] <grrrit-wm>	 (03PS4) 10Gergő Tisza: Update OOjs UI Class Names (549ff9ab7d) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173987 (owner: 10Trevor Parscal)
[01:08:11] <grrrit-wm>	 (03CR) 10Jforrester: [C: 032] Update OOjs UI Class Names (549ff9ab7d) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173987 (owner: 10Trevor Parscal)
[01:09:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: Update OOjs UI Class Names (549ff9ab7d) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173987 (owner: 10Trevor Parscal)
[01:11:39] <James_F>	 tgr: Looks to work fine with the updates. Good to know our breaking change didn't. :-)
[01:21:05] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: PHP notice in hhvm.log - 10https://bugzilla.wikimedia.org/73112 (10Derk-Jan Hartman) 5PATC>3RESO/FIX
[01:24:37] <wikibugs>	 3MediaWiki / 3File management: Thumbnail chaining broken for soft-rotated images - 10https://bugzilla.wikimedia.org/73352 (10Tisza Gergő) 5PATC>3RESO/FIX
[01:26:32] <tgr>	 James_F: thanks for updating!
[01:27:16] <James_F>	 tgr: Always happy to help. :-)
[01:30:03] <grrrit-wm>	 (03PS3) 10Gergő Tisza: Make sure that the metadata panel isn't expanded by default in IE [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/172953 (https://bugzilla.wikimedia.org/73337) (owner: 10Gilles)
[01:45:07] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: Media handler interface is misaligned inside a table - 10https://bugzilla.wikimedia.org/72758#c4 (10Derk-Jan Hartman) The button offset is caused by the display:table of the .ui-helper-clearfix::before produced by ui-helper-clearfix on the controlbar.  these days,...
[07:38:38] <wikibugs>	 3MediaWiki extensions / 3PdfHandler: Linker::makeImageLink: File: .... .pdf does not allow inline display - 10https://bugzilla.wikimedia.org/72044#c24 (10carchaias) I tested some more. This php error from Comment #17 doesnot come from pdf-handler. It is a problem with all reuploads of deletetd files , also j...
[09:40:22] <grrrit-wm>	 (03CR) 10TheDJ: [C: 032] Avoid undefined index warnings on $states array [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174385 (owner: 10Gilles)
[09:40:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Avoid undefined index warnings on $states array [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174385 (owner: 10Gilles)
[10:57:23] <wikibugs>	 3MediaWiki extensions / 3PdfHandler: Linker::makeImageLink: File: .... .pdf does not allow inline display - 10https://bugzilla.wikimedia.org/72044#c25 (10Rob Kam) @Tisza Gergő I've also had a few other problems caused by the disable_functions in php.ini. I've added a note on the extension page to watch out f...
[13:17:41] <grrrit-wm>	 (03CR) 10Gilles: "The next one can't be merged yet, we need an endpoint to receive the HEAD requests. Currently it hits the image url, but that's not ideal " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173515 (owner: 10Gilles)
[13:18:27] <grrrit-wm>	 (03CR) 10Gilles: "Although, we can merge it and just not turn it on yet... probably a better thing to do rather than let it rot for a while and introduce a " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173515 (owner: 10Gilles)
[13:29:58] <grrrit-wm>	 (03CR) 10Gilles: "Resize and fullscreen shouldn't be logged separately. You're not looking at a different file (in the wiki page sense of the term) when you" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173640 (owner: 10Gilles)
[13:35:52] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Make sure that the metadata panel isn't expanded by default in IE [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/172953 (https://bugzilla.wikimedia.org/73337) (owner: 10Gilles)
[13:36:38] <grrrit-wm>	 (03Merged) 10jenkins-bot: Make sure that the metadata panel isn't expanded by default in IE [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/172953 (https://bugzilla.wikimedia.org/73337) (owner: 10Gilles)
[14:30:17] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Fix undefined error on end of play of native <audio> [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174407 (https://bugzilla.wikimedia.org/56353) (owner: 10TheDJ)
[14:31:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix undefined error on end of play of native <audio> [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174407 (https://bugzilla.wikimedia.org/56353) (owner: 10TheDJ)
[14:32:37] <wikibugs>	 3MediaWiki extensions / 3TimedMediaHandler: Script error mw.EmbedPlayerNative.js at line 0 - 10https://bugzilla.wikimedia.org/56353#c9 (10Gilles Dubuc) I could reproduce the JS error and Derk-Jan's changeset fixed it. Not sure if it was the original issue, though.
[14:35:01] <gi11es>	 tgr|away: test failiures were due to the IE bug where the metadata panel is open by default.
[14:35:54] <gi11es>	 tgr|away: test failiures were due to the IE bug where the metadata panel was open by default. It was hiding the download button and making the download buttons fail as a result (because the click intended for the download icon didn't reach it)
[14:44:08] <gi11es>	 hmmm, the wiki loves africa banner's images are getting picked up by Media Viewer. now for every image I open in an article on enwiki, it gets preprended in media viewer's navigation list by a picture of couscous and the WLA logo
[14:45:21] <gi11es>	 we should probably blacklist the centralNotice div
[14:57:35] <grrrit-wm>	 (03PS9) 10Gilles: Add marker parameter to image requests coming from MediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173641 
[14:57:50] <grrrit-wm>	 (03CR) 10Gilles: Add marker parameter to image requests coming from MediaViewer (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173641 (owner: 10Gilles)
[15:03:16] <grrrit-wm>	 (03PS1) 10Gilles: Blacklist site notice banner images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174698 
[15:03:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Blacklist site notice banner images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174698 (owner: 10Gilles)
[15:03:45] <grrrit-wm>	 (03CR) 10Gilles: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174698 (owner: 10Gilles)
[15:14:28] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 (owner: 10MarkTraceur)
[15:15:10] <grrrit-wm>	 (03CR) 10Gilles: "Needs rebase, gerrit can't do the automatic one." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 (owner: 10MarkTraceur)
[15:15:13] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move a global starting handler out of uwu [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170349 (owner: 10MarkTraceur)
[15:18:40] <wikibugs>	 3MediaWiki extensions / 3UploadWizard: blank title throws error: "mw.Title: Could not parse title ".jpg"" - 10https://bugzilla.wikimedia.org/39642#c4 (10Andre Klapper) 5ASSI>3NEW a:5Nischay Nahata>3None Nischay Nahata: I am resetting the assignee of this issue to default because there has been no sig...
[15:18:53] <wikibugs>	 3MediaWiki extensions / 3UploadWizard: UploadWizard Flickr on Wikimedia Commons should use {{Flickr source}} and {{Flickr author}} templates - 10https://bugzilla.wikimedia.org/43408#c12 (10Andre Klapper) 5ASSI>3NEW a:5Nischay Nahata>3None Nischay Nahata: I am resetting the assignee of this issue to d...
[15:26:37] <grrrit-wm>	 (03CR) 10Hashar: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174698 (owner: 10Gilles)
[15:28:31] <grrrit-wm>	 (03CR) 10Gilles: "Yay, thanks!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174698 (owner: 10Gilles)
[15:35:23] <wikibugs>	 3MediaWiki / 3Uploading: key 'rsion=' is not in a proper format - 10https://bugzilla.wikimedia.org/41306#c3 (10John Mark Vandenberg) Is this still occurring? If so, has a bug been raised in the clients issue tracker?
[15:46:05] <marktraceur>	 gi11es: Did the thumbnail reference thing go out last night OK?
[15:46:21] <gi11es>	 I haven't had time to test it yet
[15:48:21] <marktraceur>	 Ah, all right
[15:52:37] <grrrit-wm>	 (03PS9) 10MarkTraceur: Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 
[16:24:30] <grrrit-wm>	 (03PS7) 10Gilles: Track how long users are viewing images for [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173640 
[16:25:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Track how long users are viewing images for [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173640 (owner: 10Gilles)
[16:25:41] <gi11es>	 marktraceur: the changeset's summary states "move" but I only see new code
[16:25:57] <marktraceur>	 ...oh?
[16:26:18] <gi11es>	 deleted code might have gotten lost in the rebase
[16:26:27] <marktraceur>	 Weird
[16:26:39] <marktraceur>	 I'll try that again in a sec
[16:27:30] <grrrit-wm>	 (03PS8) 10Gilles: Track how long users are viewing images for [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173640 
[16:28:32] <grrrit-wm>	 (03CR) 10Gilles: Track how long users are viewing images for (038 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173640 (owner: 10Gilles)
[16:36:29] <gi11es>	 marktraceur: tested last night's deploy, it works
[16:36:41] <marktraceur>	 Sweet!
[16:37:00] <marktraceur>	 gi11es: Is that the last step or do we still need to change the thumbnailers to use the references?
[16:37:31] <gi11es>	 the thumbnailers are using the chaining, for all wikis except commons
[16:37:45] <gi11es>	 I'll do commons next week, just to leave some time for bug reports to come in, if any
[16:39:26] <marktraceur>	 Neato
[16:45:13] <grrrit-wm>	 (03PS10) 10MarkTraceur: Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 
[16:45:16] <marktraceur>	 Fail sauce
[16:45:20] <marktraceur>	 Should be more better though
[16:49:07] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 (owner: 10MarkTraceur)
[16:49:14] <grrrit-wm>	 (03PS6) 10Gilles: Move makePreviewsFlag out of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170385 (owner: 10MarkTraceur)
[16:49:47] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move global remove handling out of UWU [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170350 (owner: 10MarkTraceur)
[16:52:12] <grrrit-wm>	 (03PS1) 10Gilles: Backport IE and tipsy bugfixes [extensions/MultimediaViewer] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174714 (https://bugzilla.wikimedia.org/72516) 
[16:53:13] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Backport IE and tipsy bugfixes [extensions/MultimediaViewer] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174714 (https://bugzilla.wikimedia.org/72516) (owner: 10Gilles)
[16:53:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Backport IE and tipsy bugfixes [extensions/MultimediaViewer] (wmf/1.25wmf9) - 10https://gerrit.wikimedia.org/r/174714 (https://bugzilla.wikimedia.org/72516) (owner: 10Gilles)
[16:59:46] <grrrit-wm>	 (03PS1) 10Gilles: Backport IE and tipsy bugfixes [extensions/MultimediaViewer] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174718 (https://bugzilla.wikimedia.org/72516) 
[17:02:35] <grrrit-wm>	 (03CR) 10Gilles: [C: 032] Backport IE and tipsy bugfixes [extensions/MultimediaViewer] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174718 (https://bugzilla.wikimedia.org/72516) (owner: 10Gilles)
[17:03:19] <grrrit-wm>	 (03Merged) 10jenkins-bot: Backport IE and tipsy bugfixes [extensions/MultimediaViewer] (wmf/1.25wmf8) - 10https://gerrit.wikimedia.org/r/174718 (https://bugzilla.wikimedia.org/72516) (owner: 10Gilles)
[17:10:26] <rillke>	 Hey bd808, breakpoint debugging mediawiki inside vagrant with Eclipse, I now run into the issue that the source code of the index.php doen't match the source code I provide to Eclipse for debugging from the shared folder (VM: /var/www/w/index.php <> Hostsystem: X:\vagrant\mediawiki\index.php)
[17:10:38] <rillke>	 Do you have an idea how to resolve that?
[17:10:41] <marktraceur>	 Wow, look at alla that CR
[17:12:10] <marktraceur>	 Oh, gi11es, did I tell you that csteipp poked us in SoS about the SHA-1 thing?
[17:12:45] <gi11es>	 marktraceur: the card's in the current sprint
[17:13:34] <marktraceur>	 Yup, just saying
[17:15:32] <rillke>	 bd808: To be clear, Eclipse is running on the host system, not in the VM and is connected through port 9000 to the VM in which XDebug runs. Now I wonder how to expose the /var/www/w/ directory to Eclipse.
[17:17:29] <bd808>	 rillke: hmmm... I think there is a bug open asking for that somewhere
[17:18:18] * rillke is looking for the bug
[17:23:52] <grrrit-wm>	 (03CR) 10Gilles: [C: 04-1] Move makePreviewsFlag out of UploadWizard (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170385 (owner: 10MarkTraceur)
[17:30:46] <bd808>	 rillke: https://bugzilla.wikimedia.org/show_bug.cgi?id=70907
[17:33:03] <rillke>	 thanks :)
[17:35:37] <wikibugs>	 3MediaWiki extensions / 3MultimediaViewer: Tipsy doesn't close when closing MultimediaViewer - 10https://bugzilla.wikimedia.org/72516 (10Tisza Gergő) 5PATC>3RESO/FIX
[19:06:01] <grrrit-wm>	 (03CR) 10Gergő Tisza: "> Although, we can merge it and just not turn it on yet..." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173515 (owner: 10Gilles)
[19:22:13] <grrrit-wm>	 (03CR) 10Gergő Tisza: Track how long users are viewing images for (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173640 (owner: 10Gilles)
[19:37:14] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 04-1] "> I think that trying to build a breakdown of thumbnail" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173640 (owner: 10Gilles)
[20:03:42] <grrrit-wm>	 (03PS1) 10Cmcmahon: QA: wait for element to appear [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174790 
[20:35:22] <marktraceur>	 gi11es: I'm not sure I agree with your analysis in the makePreviews thing
[20:35:32] <marktraceur>	 Batched uploads need to get the makePreviews flag too
[20:35:49] <marktraceur>	 I can pass that in, but it won't just be one method call
[20:41:31] <grrrit-wm>	 (03PS7) 10MarkTraceur: Move makePreviewsFlag out of UploadWizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170385 
[21:16:32] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] QA: wait for element to appear [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174790 (owner: 10Cmcmahon)
[21:18:25] <grrrit-wm>	 (03Merged) 10jenkins-bot: QA: wait for element to appear [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174790 (owner: 10Cmcmahon)
[21:22:03] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Add marker parameter to image requests coming from MediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173641 (owner: 10Gilles)
[21:24:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add marker parameter to image requests coming from MediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173641 (owner: 10Gilles)
[21:45:44] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Blacklist site notice banner images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174698 (owner: 10Gilles)
[22:03:09] <grrrit-wm>	 (03Merged) 10jenkins-bot: Blacklist site notice banner images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174698 (owner: 10Gilles)
[22:14:21] <grrrit-wm>	 (03PS5) 10Gergő Tisza: Make all truncatable text clickable when some text is untruncated [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/172550 
[23:21:38] <grrrit-wm>	 (03CR) 10Gilles: "When I tested this during the hackathon it seemed to me like those HEAD requests took significantly longer that the EL ones. But I have ca" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173515 (owner: 10Gilles)
[23:22:35] <grrrit-wm>	 (03CR) 10Gilles: "Thanks!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174790 (owner: 10Cmcmahon)
[23:24:41] <grrrit-wm>	 (03CR) 10Gilles: "This still needs to be updated to reflect the new design instructions from the card, right?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/172550 (owner: 10Gergő Tisza)
[23:29:38] <grrrit-wm>	 (03CR) 10Gilles: "> Fair enough, but then shouldn't you ping the full image URL or the description page URL instead of the thumbnail URL? Or is that URL goi" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173640 (owner: 10Gilles)
[23:34:36] <grrrit-wm>	 (03PS9) 10Gilles: Track how long users are viewing images for [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173640 
[23:34:40] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Track how long users are viewing images for [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173640 (owner: 10Gilles)
[23:35:40] <grrrit-wm>	 (03CR) 10Gilles: Track how long users are viewing images for (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173640 (owner: 10Gilles)
[23:35:49] <grrrit-wm>	 (03CR) 10Gilles: Track how long users are viewing images for (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173640 (owner: 10Gilles)
[23:37:23] <grrrit-wm>	 (03PS4) 10Gilles: Track image "unviews" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173515 
[23:39:48] <grrrit-wm>	 (03PS10) 10Gilles: Track how long users are viewing images for [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173640 
[23:42:37] <wikibugs>	 3MediaWiki extensions / 3CommonsMetadata: Ignore EXIF data in CommonsMetadata - 10https://bugzilla.wikimedia.org/71719#c5 (10Guillaume Paumier) After encountering more and more of these, like https://de.wikibooks.org/wiki/Datei%3ABenutzerMKabel.jpg , I'm starting to agree with you.   I still believe a handfu...
[23:57:00] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Indeed, I'll finish this later today (almost done with the reviews)." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/172550 (owner: 10Gergő Tisza)