[00:05:12] (03CR) 10Gilles: Move makePreviewsFlag out of UploadWizard (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170385 (owner: 10MarkTraceur) [00:10:53] (03CR) 10Gergő Tisza: [C: 032] Track image "unviews" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173515 (owner: 10Gilles) [00:11:10] (03CR) 10Gergő Tisza: [C: 032] Track how long users are viewing images for [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173640 (owner: 10Gilles) [00:11:39] (03Merged) 10jenkins-bot: Track image "unviews" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173515 (owner: 10Gilles) [00:11:58] (03Merged) 10jenkins-bot: Track how long users are viewing images for [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173640 (owner: 10Gilles) [00:32:45] (03CR) 10Gergő Tisza: "Tested, works." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/168556 (https://bugzilla.wikimedia.org/65423) (owner: 10Gilles) [08:53:01] (03CR) 10Gilles: "I've just kept the settings currently used for Flickr: https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FUploadWizard/5bc457812c0b96" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/168556 (https://bugzilla.wikimedia.org/65423) (owner: 10Gilles) [10:07:53] (03PS1) 10Gilles: Rename Performance to PerformanceLogger [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174928 [10:49:39] (03CR) 10Gergő Tisza: [C: 032] Make flickr import use postWithToken instead of iframe transport [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/168556 (https://bugzilla.wikimedia.org/65423) (owner: 10Gilles) [10:50:18] (03Merged) 10jenkins-bot: Make flickr import use postWithToken instead of iframe transport [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/168556 (https://bugzilla.wikimedia.org/65423) (owner: 10Gilles) [11:11:28] (03CR) 10Gergő Tisza: [C: 032] Rename Performance to PerformanceLogger [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174928 (owner: 10Gilles) [11:12:11] (03Merged) 10jenkins-bot: Rename Performance to PerformanceLogger [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174928 (owner: 10Gilles) [11:26:02] (03PS1) 10Gilles: [WIP] Track the most recent upload time for performance events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174933 [11:26:48] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Track the most recent upload time for performance events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174933 (owner: 10Gilles) [11:28:34] (03PS2) 10Gilles: [WIP] Track the most recent upload time for performance events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174933 [11:29:20] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Track the most recent upload time for performance events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174933 (owner: 10Gilles) [11:31:54] (03PS3) 10Gilles: [WIP] Track the most recent upload time for performance events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174933 [11:32:39] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Track the most recent upload time for performance events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174933 (owner: 10Gilles) [13:56:37] Morning all [13:56:48] I have to go to the DMV today to make my car less Californian [13:58:00] Wish me luck... [17:12:17] marktraceur: I need to go to the DMV to make myself more Californian :) [17:12:44] * guillom has heard many horror stories about the DMV. [17:15:53] It's not that bad. [17:16:03] guillom: Go there prepared to wait, and get there at the asscrack of dawn. [17:16:25] AKA 08:00 I think. [17:18:54] Soon, I will not have to deal with people saying "Oh, California, whatcha doin' out here?" [17:19:01] LIVING. I AM LIVING HERE. [17:19:12] :D [18:13:33] (03CR) 10Krinkle: [C: 032] Make the private modules of TMH pass jshint [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/173513 (owner: 10TheDJ) [18:13:36] (03CR) 10jenkins-bot: [V: 04-1] Make the private modules of TMH pass jshint [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/173513 (owner: 10TheDJ) [18:13:40] (03PS2) 10Krinkle: Remove superfluous parseInt() [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/174097 (owner: 10TheDJ) [18:19:27] marktraceur: I have a question about a card you created. [18:19:28] Sigh [18:19:41] I'm not sure https://bugzilla.wikimedia.org/show_bug.cgi?id=35354 is an issue anymore [18:19:52] Unsupported characters get blacklisted by UW from what I can tell [18:19:58] marktraceur: Didn't you hear? We fixed all the bugs! [18:20:07] Krinkle: Missed *that* email [18:20:13] All of 'em. Closed. This is the end of the world as we know it. We're bug free. [18:20:17] Yay! [18:20:27] Krinkle: Good timing to start killing Bugzilla, then. [18:20:59] We now have tickets. And phabpretzels. [18:25:19] gi11es, tgr|away, do either of you remember looking at that bug, or was it just me? I can't repro, so I'm marking as unconfirmed for now. [19:19:32] Ugh, more test failures? [20:13:03] (03PS6) 10Gergő Tisza: Make all truncatable text clickable when some text is untruncated [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/172550 [20:13:46] (03CR) 10Gergő Tisza: "fixed click-between-the-lines issue and outdated documentation for the truncate component." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/172550 (owner: 10Gergő Tisza) [20:14:11] (03PS7) 10Gergő Tisza: Make all truncatable text clickable when some text is untruncated [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/172550 [21:50:50] marktraceur: I don't know about bug 35354 specifically, but I have seen a lot of badfilename errors happening in the details step (ie. when the file is moved out from stash) in the funnel tracking [21:51:13] that suggests some sort of logic error as those bugs should be caught earlier [21:51:40] that was back in August, I can recheck if you think it was fixed recently [21:52:45] also a lot of UploadStashFileNotFoundExceptions, which I assume is some sort of session timeout thing [21:53:19] the bugzilla ticket seems to be about a mix of those and other stash errors, so not entirely useful [21:54:46] Hm, OK. [21:55:07] pginer: re https://wikimedia.mingle.thoughtworks.com/projects/multimedia/cards/983 , what should be the truncate behavior when using prev/next? [21:55:07] tgr: I don't think there's anything we can do about session timeouts... [21:55:31] marktraceur: well, not using the session for the stash, eventually [21:56:15] on the short term, just check how session timeouts are actually handled by UW [21:57:02] the bug description suggests that the file is not uploaded but the file page is created or something like [21:57:08] ...that [21:57:56] although the report is two years old and there is no way to tell from the funnel logs if that is still happening now, so might not be an issue anymore [21:58:42] but it's definitely worth testing UW locally with a very short session timout IMO to see how reasonably it handles the error [21:59:54] pginer: nevermind, text should always be untruncated when the metadata panel is fully or partially open, right? [22:00:13] looks like I introduced a but with the patch for preserving panel position [22:00:41] ...bug... [22:02:10] tgr, you are right [22:02:23] truncation works together with the open state of the panel [22:02:56] Panel open -> text expanded [22:03:03] Panel closed -> text collapsed