[00:02:14] (03PS3) 10Gergő Tisza: Close panel on canvas click + fullscreen mouseleave [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/175189 [01:40:22] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Faster access to file names in MediaViewer - https://phabricator.wikimedia.org/T76680#820357 (10Tgr) [01:41:19] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Faster access to file names in MediaViewer - https://phabricator.wikimedia.org/T76680#808969 (10Tgr) [01:42:52] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Faster access to file names in MediaViewer - https://phabricator.wikimedia.org/T76680#820362 (10Tgr) [02:29:11] (03CR) 10Gergő Tisza: [C: 032] "Holy crap I made the preloading code complicated." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174933 (owner: 10Gilles) [02:30:16] (03Merged) 10jenkins-bot: Track the most recent upload time for performance events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/174933 (owner: 10Gilles) [02:44:23] 3Design, MediaWiki-extensions-MultimediaViewer, Multimedia: Fix 'Licensed under Fair Use' credits - https://phabricator.wikimedia.org/T76030#820423 (10Fabrice_Florin) [02:44:42] 3Design, MediaWiki-extensions-MultimediaViewer, Multimedia: Fix 'Licensed under Fair Use' credits - https://phabricator.wikimedia.org/T76030#788495 (10Fabrice_Florin) [02:48:36] 3Design, MediaWiki-extensions-MultimediaViewer, Multimedia: Fix 'Licensed under Fair Use' credits - https://phabricator.wikimedia.org/T76030#820425 (10Fabrice_Florin) [02:53:34] 3Design, MediaWiki-extensions-MultimediaViewer, Multimedia: Fix 'Licensed under Fair Use' credits - https://phabricator.wikimedia.org/T76030#820430 (10LuisV_WMF) [03:52:47] 3Design, MediaWiki-extensions-MultimediaViewer, Multimedia: Fix 'Licensed under Fair Use' credits - https://phabricator.wikimedia.org/T76030#820490 (10Fabrice_Florin) [04:01:24] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Faster access to file names in MediaViewer - https://phabricator.wikimedia.org/T76680#820492 (10Fabrice_Florin) To help finalize the design for this feature, we're inviting feedback from casual and experienced editors on these questions: **1. Is this file name... [04:01:56] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Faster access to file names in MediaViewer - https://phabricator.wikimedia.org/T76680#820493 (10Fabrice_Florin) [04:22:11] 3Design, MediaWiki-extensions-MultimediaViewer, Multimedia: Fix 'Licensed under Fair Use' credits - https://phabricator.wikimedia.org/T76030#820544 (10LuisV_WMF) I'm just concerned that I can wordsmith this to properly handle the US concept of fair use, but basically all of the nuance will be lost as soon as it... [06:48:56] 3Design, MediaWiki-extensions-MultimediaViewer, Multimedia: Fix 'Licensed under Fair Use' credits - https://phabricator.wikimedia.org/T76030#820650 (10Tgr) [06:56:10] 3MediaWiki-extensions-MultimediaViewer: MediaViewer do not recognize as public domain images when licensetpl_short is set to "PD" - https://phabricator.wikimedia.org/T76836#820662 (10Kwj2772) [07:01:32] (03PS1) 10Gergő Tisza: Recognize "PD" as public domain in lincense names [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/177750 [08:06:48] 3MediaWiki-extensions-UploadWizard, Multimedia: Extract heading (=Direction of image) from EXIF/metadata and add it to location template - https://phabricator.wikimedia.org/T39925#820750 (10Gilles) 5Resolved>3Open >>! In T39925#819650, @SJu wrote: > My new Sony DSC-HX400V camera stores camera direction in Ex... [08:07:36] 3MediaWiki-extensions-UploadWizard, Multimedia: Extract heading (=Direction of image) from EXIF/metadata and add it to location template - https://phabricator.wikimedia.org/T39925#417001 (10Gilles) [08:11:55] 3MediaWiki-Uploading, Multimedia: Some API action=upload & filekey requests take >30 seconds to complete - https://phabricator.wikimedia.org/T36785#820765 (10Gilles) [08:20:51] (03CR) 10Gilles: [C: 04-1] "I still see "almost finished" for 10-15 seconds on a single file upload. That shouldn't happen at all if it's a rounding problem to begin " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/177298 (owner: 10MarkTraceur) [08:28:50] 3Design, MediaWiki-extensions-MultimediaViewer, Multimedia: Fix 'Licensed under Fair Use' credits - https://phabricator.wikimedia.org/T76030#820812 (10LuisV_WMF) Pau, what's the maximum character count I can practically use here? [08:30:15] (03CR) 10Gilles: [C: 04-1] "Clicking on the download or the share icon triggers a JS error and the corresponding panel doesn't open:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/175189 (owner: 10Gergő Tisza) [08:30:22] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Let users collapse a description by clicking on it again, after expanding it - https://phabricator.wikimedia.org/T76029#820815 (10Gilles) [08:33:11] 3MediaWiki-extensions-MultimediaViewer, Multimedia: MediaViewer do not recognize as public domain images when licensetpl_short is set to "PD" - https://phabricator.wikimedia.org/T76836#820823 (10Gilles) [08:33:33] 3MediaWiki-extensions-MultimediaViewer, Multimedia: MediaViewer do not recognize as public domain images when licensetpl_short is set to "PD" - https://phabricator.wikimedia.org/T76836#820662 (10Gilles) [08:33:56] 3MediaWiki-extensions-CommonsMetadata, Multimedia: MediaViewer do not recognize as public domain images when licensetpl_short is set to "PD" - https://phabricator.wikimedia.org/T76836#820662 (10Gilles) [08:34:07] 3MediaWiki-extensions-CommonsMetadata, Multimedia: MediaViewer do not recognize as public domain images when licensetpl_short is set to "PD" - https://phabricator.wikimedia.org/T76836#820827 (10Gilles) a:3Tgr [08:34:31] (03CR) 10Gilles: [C: 032] Recognize "PD" as public domain in lincense names [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/177750 (owner: 10Gergő Tisza) [08:34:40] 3MediaWiki-extensions-CommonsMetadata, Multimedia: MediaViewer do not recognize as public domain images when licensetpl_short is set to "PD" - https://phabricator.wikimedia.org/T76836#820662 (10Gilles) [08:34:40] (03Merged) 10jenkins-bot: Recognize "PD" as public domain in lincense names [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/177750 (owner: 10Gergő Tisza) [08:35:44] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Update limn to point to new schemas - https://phabricator.wikimedia.org/T76453#820834 (10Gilles) 5Open>3Resolved The stats are back, this can be closed now. [09:30:04] 3MediaWiki-Uploading, Multimedia: Warning: was not stored with SHA-1 metadata - https://phabricator.wikimedia.org/T76487#820929 (10fgiunchedi) [09:39:57] 3MediaWiki-Uploading, Multimedia: Warning: was not stored with SHA-1 metadata - https://phabricator.wikimedia.org/T76487#820930 (10fgiunchedi) FWIW this seems to match up in what we are seeing in swift, increased POSTs {F18943} [12:06:00] (03PS4) 10Gergő Tisza: Close panel on canvas click + fullscreen mouseleave [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/175189 [13:14:40] (03PS1) 10Thiemo Mättig (WMDE): Remove all readOnly usability blockages [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/177786 [13:20:41] Wow, that's insane [13:21:02] gi11es: Yesplz, test file if you don't mind [13:21:17] Maybe it's because of chunking somehow, I dunno [13:24:50] (03CR) 10Gergő Tisza: "I did a rebase; that should have fixed it as this is an unrelated OOJS-UI version incompatibility. Unfortunately I can't test as my vagran" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/175189 (owner: 10Gergő Tisza) [14:37:07] 3MediaWiki-extensions-UploadWizard, Multimedia: Extract heading (=Direction of image) from EXIF/metadata and add it to location template - https://phabricator.wikimedia.org/T39925#821301 (10SJu) >>! In T39925#820750, @Gilles wrote: >>>! In T39925#819650, @SJu wrote: >> My new Sony DSC-HX400V camera stores camera... [14:52:21] 3MediaWiki-Uploading, Multimedia: Clicking on non-existing image link does not redirect to upload anymore - https://phabricator.wikimedia.org/T30891#821330 (10Aklapper) [14:52:23] 3Multimedia, MediaWiki-File-management: Anchor tag surrounding a thumbnail's img tag no longer has a title attribute. - https://phabricator.wikimedia.org/T22712#821333 (10Aklapper) [14:52:25] 3Multimedia, MediaWiki-File-management: [REGRESSION] File comment with source information no longer added to thumbnails - https://phabricator.wikimedia.org/T44368#821334 (10Aklapper) [14:52:26] 3MediaWiki-Uploading, Multimedia: [Regression] broke Edittools for Special:Upload - https://phabricator.wikimedia.org/T33682#821332 (10Aklapper) [14:52:27] 3Multimedia, MediaWiki-extensions-TimedMediaHandler: Can't mark new timed texts as patrolled - https://phabricator.wikimedia.org/T44364#821335 (10Aklapper) [14:52:30] 3Multimedia, MediaWiki-extensions-MultimediaViewer: when no license and/or attribution is known disable reuse suggestion - https://phabricator.wikimedia.org/T71557#821337 (10Aklapper) [15:02:27] (03CR) 10Se4598: "tested in FF, I don't see a (major) difference." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/177786 (owner: 10Thiemo Mättig (WMDE)) [15:32:58] Gods, I should have made coffee by now [15:42:45] 3MediaWiki-extensions-UploadWizard, Multimedia: Extract heading (=Direction of image) from EXIF/metadata and add it to location template - https://phabricator.wikimedia.org/T39925#821479 (10El_Grafo) [16:21:46] gi11es: I don't see anything terribly wrong on my side, using several 30+MB OGV files..."almost finished" lasts for maybe a few seconds, but I think we can attribute that to slight inaccuracies in the guessing algorithm. [16:22:32] You can only be so accurate when you're estimating based on the historical rates during the session [16:24:36] 3MediaWiki-extensions-UploadWizard, Multimedia: status bar reports "Finished!" long before upload is finished - https://phabricator.wikimedia.org/T62483#821543 (10MarkTraceur) [16:24:55] 3MediaWiki-extensions-UploadWizard, Multimedia: status bar reports "Finished!" long before upload is finished - https://phabricator.wikimedia.org/T62483#821544 (10MarkTraceur) [17:04:20] 3MediaWiki-Core-Team, MediaWiki-extensions-GWToolset, Multimedia: Upload stopps regularly - https://phabricator.wikimedia.org/T76450#821582 (10hoo) [17:05:39] 3MediaWiki-extensions-UploadWizard, Multimedia: Extract heading (=Direction of image) from EXIF/metadata and add it to location template - https://phabricator.wikimedia.org/T39925#821591 (10SJu) [17:07:22] 3MediaWiki-Core-Team, MediaWiki-extensions-GWToolset, Multimedia: Upload stopps regularly - https://phabricator.wikimedia.org/T76450#821593 (10hoo) Now I found something, not sure how relevant it is: ``` error=GWToolset\Jobs\UploadMediafileJob::run: <Other contributors: A media file with the identical title... [17:41:06] 3Design, MediaWiki-extensions-MultimediaViewer, Multimedia: Fix 'Licensed under Fair Use' credits - https://phabricator.wikimedia.org/T76030#821631 (10Pginer-WMF) If I understand tis correctly, the goal is to (a) communicate more clearly that this is not a feely licensed file, and (b) make the attribution text c... [19:29:37] 3MediaWiki-extensions-CommonsMetadata, Multimedia: MediaViewer do not recognize as public domain images when licensetpl_short is set to "PD" - https://phabricator.wikimedia.org/T76836#821972 (10Tgr) 5Open>3Resolved Patch was merged, will go live on the 17th. [19:42:53] 3MediaWiki-extensions-CommonsMetadata, Multimedia: Images without source field set don't end up in the tracker category - https://phabricator.wikimedia.org/T73957#822133 (10Tgr) 5Open>3stalled Not a code issue; reported at https://commons.wikimedia.org/wiki/Template_talk:Information#Fake_machine_readable_data [19:44:19] 3MediaWiki-extensions-MultimediaViewer, Multimedia: "You need to attribute the author" is wrong in case of CC0/Public Domain files - https://phabricator.wikimedia.org/T70687#822163 (10Tgr) 5Open>3Resolved a:3Tgr [19:46:32] 3MediaWiki-extensions-CommonsMetadata, Multimedia: Files with title set get incorrectly added to Category:Files with no machine-readable description - https://phabricator.wikimedia.org/T73950#822200 (10Tgr) [19:48:06] 3MediaWiki-extensions-CommonsMetadata, Multimedia: Files with title set get incorrectly added to Category:Files with no machine-readable description - https://phabricator.wikimedia.org/T73950#753159 (10Tgr) Currently CommonsMetadata does not make any distinction between the title field of the template and the EX... [19:51:50] 3MediaWiki-extensions-CommonsMetadata, Multimedia: CommonsMetadata should parse EXIF dates - https://phabricator.wikimedia.org/T66014#822284 (10Tgr) [19:52:02] 3MediaWiki-extensions-CommonsMetadata, Multimedia: CommonsMetadata should parse EXIF dates - https://phabricator.wikimedia.org/T66014#686421 (10Tgr) [19:55:23] 3MediaWiki-extensions-CommonsMetadata, Multimedia: Author and license extraction fails on the German Wikipedia for local files - https://phabricator.wikimedia.org/T71496#822323 (10Tgr) 5Open>3Resolved a:3Tgr Closing this; the example works now, and in general these issues are being taken care of as part of... [20:01:09] 3MediaWiki-extensions-CommonsMetadata, Multimedia: More PHP notices in hhvm.log - https://phabricator.wikimedia.org/T75107#822370 (10Tgr) 5Open>3Resolved a:3Tgr This was fixed by the patch (thanks, Reedy!), I presume. [20:02:31] 3MediaWiki-extensions-CommonsMetadata, Multimedia: Prefer information templates that are about the file - https://phabricator.wikimedia.org/T74084#822389 (10Tgr) [20:02:32] 3MediaWiki-extensions-CommonsMetadata, Multimedia: Book data overwriting image data - https://phabricator.wikimedia.org/T59310#822388 (10Tgr) [20:03:20] 3MediaWiki-extensions-CommonsMetadata, Multimedia: Figure out what to do with non-free CC licenses - https://phabricator.wikimedia.org/T59320#822390 (10Tgr) [20:07:19] 3MediaWiki-extensions-CommonsMetadata, Multimedia: Figure out what to do with non-free CC licenses - https://phabricator.wikimedia.org/T59320#822432 (10Tgr) 5Open>3Resolved > One possible solution would be to weight licenses somehow, so API users can just take the first and be assured that that is the least... [20:11:37] 3MediaWiki-extensions-CommonsMetadata, Multimedia: data labels in imageinfo API don't make sense - https://phabricator.wikimedia.org/T71914#822461 (10Tgr) Given how much the structured data project lags behind, I would be inclined to fix this now. @Anomie, is there any guidance on how such a breaking change to t... [20:16:08] 3MediaWiki-extensions-CommonsMetadata, Multimedia: "commons-metadata" is indicated as a source for categories even when they are not from commons - https://phabricator.wikimedia.org/T59260#822472 (10Tgr) [20:17:50] 3MediaWiki-extensions-CommonsMetadata, Multimedia: Warning text about missing author/source gets parsed as author/source name in Commons templates - https://phabricator.wikimedia.org/T73957#822476 (10Tgr) [20:18:51] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Media viewer fails to give credit to all people in specific circumstances - https://phabricator.wikimedia.org/T68606#822478 (10Tgr) [20:19:42] 3MediaWiki-extensions-UploadWizard, Multimedia: status bar reports "Finished!" long before upload is finished - https://phabricator.wikimedia.org/T62483#822479 (10Fabrice_Florin) I have experienced this issue a number of times on my end, even with relatively small files. Here's a screenshot of a recent case, w... [20:21:02] gi11es marktraceur tgr I have been going through repos updating our browser tests to use more modern syntax for assertions. I'd like to do MMV and UW next if you don't mind, it'll be several commits per repo. [20:22:14] 3Multimedia, MediaWiki-extensions-MultimediaViewer: when no license and/or attribution is known disable reuse suggestion - https://phabricator.wikimedia.org/T71557#822481 (10Tgr) [20:22:46] 3Multimedia, MediaWiki-extensions-MultimediaViewer: when no license and/or attribution is known disable reuse suggestion - https://phabricator.wikimedia.org/T71557#722028 (10Tgr) Not really a regression as MediaViewer never did this. [20:22:57] 3Multimedia, MediaWiki-extensions-MultimediaViewer: when no license and/or attribution is known disable reuse suggestion - https://phabricator.wikimedia.org/T71557#822484 (10Tgr) [20:23:35] 3Design, MediaWiki-extensions-MultimediaViewer, Multimedia: Fix 'Licensed under Fair Use' credits - https://phabricator.wikimedia.org/T76030#822493 (10Tgr) >>! In T76030#821631, @Pginer-WMF wrote: > (which I'm not sure if we can say that you must, should, or may attribute the author on these kind of files). Mu... [20:25:20] chrismcmahon: No objections here. Let us know if you need code review! [20:28:35] marktraceur: will do. it's pretty straightforward stuff, and the MMV are really well-written to begin with [20:29:17] marktraceur: I've done Echo, Flow, VisualEditor, and MobileFrontend so far. Refactoring is fun. :-) [20:37:02] 3Design, MediaWiki-extensions-MultimediaViewer, Multimedia: Fix 'Licensed under Fair Use' credits - https://phabricator.wikimedia.org/T76030#822522 (10Fabrice_Florin) [20:53:38] chrismcmahon: fine by me, I'll be happy to review them [20:54:00] marktraceur: hold on for the test file... [20:54:49] marktraceur: https://www.dropbox.com/s/dvj6dauplp03kvq/Escape_The_Castle%21%21.ogv?dl=0 [21:08:09] gi11es: thanks, probably make my first commits Monday [21:28:34] (03CR) 10Gergő Tisza: "Verified working." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/175189 (owner: 10Gergő Tisza) [21:29:07] 3Multimedia, MediaWiki-extensions-MultimediaViewer: when no license and/or attribution is known disable reuse suggestion - https://phabricator.wikimedia.org/T71557#822627 (10JanZerebecki) It is compared to the file page. It is also compared to MediaViewer not suggesting reuse. This bug has wider implications tha... [21:30:21] gi11es: I have no more problem with that than I did with the seven other big OGVs I tested with... [21:50:21] 3Multimedia, MediaWiki-extensions-MultimediaViewer: when no license and/or attribution is known disable reuse suggestion - https://phabricator.wikimedia.org/T71557#822669 (10Tgr) [22:12:44] 3Design, MediaWiki-extensions-MultimediaViewer, Multimedia: Fix 'Licensed under Fair Use' credits - https://phabricator.wikimedia.org/T76030#822693 (10LuisV_WMF) [23:28:17] 3Design, MediaWiki-extensions-MultimediaViewer, Multimedia: Fix 'Licensed under Fair Use' credits - https://phabricator.wikimedia.org/T76030#822831 (10Tgr) [23:34:44] 3MediaWiki-extensions-CommonsMetadata, Multimedia: CommonsMetadata should parse EXIF dates - https://phabricator.wikimedia.org/T66014#822837 (10Catrope) [23:37:01] 3MediaWiki-extensions-CommonsMetadata, Multimedia: CommonsMetadata should parse EXIF dates - https://phabricator.wikimedia.org/T66014#822843 (10Tgr) See also T63701 [23:49:03] 3Multimedia, MediaWiki-File-management: images .htaccess file makes images inaccessible - https://phabricator.wikimedia.org/T64289#822873 (10kaldari) 5Open>3Resolved a:3kaldari