[00:29:47] tgr, marktraceur: Something I've been wondering for a while. How do you get the caption to display when you click on an image and read it in MediaViewer? [00:30:08] tgr, marktraceur: That information isn't returned by the CommonsMetadata API (which makes sense, because it's not actually on the file page at all) [00:40:12] Deskana: We pull it from the DOM when it's present... [00:40:20] Eugh [00:40:27] Deskana: Or at least, we did. Maybe we took it out in the last round of budgetary cutbacks [00:40:50] Hacky [00:46:35] Deskana: parsing HTML is the easy way to go if the result will be displayed on a web page anyway, because so many things can influence the wikitext -> HTML transformation, and by the time it becomes useable, there isn't any connection to the file anymore, other than DOM structure [00:46:55] Yeah, it makes sense [00:46:59] (which should be skinable, but isn't) [00:47:03] I'm just an apps purist. I only like using API output. ;-) [00:47:18] I don't live in the real world :P [00:47:53] parsoid might make this saner as it can map wikitext fragments to HTML fragments, or so I heard [00:48:04] haven't looked at it closely yet [00:49:01] anyway writing an API that returns the captions on a page should not be hard [00:49:19] not harder than writing an API in general, anyway [00:50:54] we could just combine the parsing code from CommonsMetadata and MediaViewer [00:52:44] ideally, you would store that information at parsing time instead of tracing it back from HTML, but the HTML generation code for images is very far from ideal, so not sure that's possible without major refactoring [09:22:48] (03CR) 10Gilles: [C: 032] Add "almost finished" message and remove parseInts [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/177298 (owner: 10MarkTraceur) [09:23:54] (03Merged) 10jenkins-bot: Add "almost finished" message and remove parseInts [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/177298 (owner: 10MarkTraceur) [09:26:14] (03CR) 10Gilles: [C: 032] Remove superfluous write of ensureEventHandlersAreSetUp flag [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178257 (owner: 10Gergő Tisza) [09:27:18] (03Merged) 10jenkins-bot: Remove superfluous write of ensureEventHandlersAreSetUp flag [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178257 (owner: 10Gergő Tisza) [09:46:56] (03CR) 10Gilles: [C: 04-1] "With the changeset applied, using Chrome pointed to beta, I always get these failures: https://phabricator.wikimedia.org/P131" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178205 (owner: 10Cmcmahon) [09:47:56] (03CR) 10Thiemo Mättig (WMDE): [C: 031] "Love it, thanks a lot!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178219 (owner: 10Gergő Tisza) [09:52:41] (03CR) 10Gilles: [C: 032] Rough logging of metadata panel scrolling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/175622 (owner: 10Gergő Tisza) [09:53:51] (03Merged) 10jenkins-bot: Rough logging of metadata panel scrolling [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/175622 (owner: 10Gergő Tisza) [09:59:01] (03CR) 10Gilles: [C: 04-1] "Simple clicking no longer selects all the text in firefox. There's also funny stuff happening when switching between plain and html inside" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178219 (owner: 10Gergő Tisza) [10:22:19] (03CR) 10Gilles: [C: 04-1] "Can't test it anyway because Firefogg support is broken on master. I'll file a ticket for that." (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178210 (owner: 10MarkTraceur) [10:29:25] (03CR) 10Gilles: "This broke Firefogg support: https://phabricator.wikimedia.org/T77973?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 (owner: 10MarkTraceur) [10:34:54] (03CR) 10Gilles: [C: 04-1] "When trying to upload a few files:" (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178207 (owner: 10MarkTraceur) [10:37:54] (03CR) 10Gilles: [C: 04-1] "When trying to import from flickr (which uses this transport), the interface goes blank and the image never appears." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178223 (owner: 10MarkTraceur) [10:38:44] (03CR) 10Gilles: Replace IframeTransport callbacks with OOJS events (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178223 (owner: 10MarkTraceur) [15:25:30] (03PS10) 10Cmcmahon: QA: update tests for RSpec3 syntax etc. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178205 [15:33:19] (03CR) 10Cmcmahon: "Gilles, thanks for checking Chrome. The original version was running slowly enough that it did not have to wait for elements like mmv_down" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178205 (owner: 10Cmcmahon) [15:35:57] (03CR) 10MarkTraceur: "Probably the uploadToAdd removal. I'm on it." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/170343 (owner: 10MarkTraceur) [15:53:44] gi11es: Can you confirm what your issue with Firefogg is? I'm seeing a warning that it's not installed when it is. [15:57:56] yes that's the problem [15:58:20] I've git bisected to make sure that it's the changeset I've pointed you to that actually broke it [15:59:03] instead of having firefogg pick up the file when it's selected and do its thing, it incorrectly shows the warning [16:00:27] KK [16:05:26] (03CR) 10Gilles: [C: 04-1] "I figured it was something like that. I still see a few failures for the last scenarios: https://phabricator.wikimedia.org/P133" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178205 (owner: 10Cmcmahon) [16:13:28] marktraceur: I think you can unmute wikibugs for real now :) I can't think of any batch editing I would do now [16:13:39] Oh, sorry [16:13:52] I'll still close duplicates and such, but not at a rate that should be noisy [16:14:00] Yeah. [16:14:09] gi11es: Did I tell you you nearly crashed my VPS yesterday? [16:14:16] how? [16:14:28] ~/mail/Phabricator/new got filled with messages [16:14:31] I hit my inode limit [16:14:49] for a few thousand emails? [16:14:58] Apparently. [16:15:04] it wasn't worse than the batch editing I did last week in terms of quantity [16:15:04] I'm not totally sure that's the only cause [16:15:51] But I did turn off phabricator emails now [16:22:12] 3Multimedia, MediaWiki-File-management: Thumbnail rendering for specific size ranges fails - https://phabricator.wikimedia.org/T77950#833718 (10Gilles) [16:31:30] 3UploadWizard-Refactoring, Multimedia, MediaWiki-extensions-UploadWizard: Refactor the transport system - https://phabricator.wikimedia.org/T77124#833732 (10Gilles) [16:32:39] 3Multimedia, MediaWiki-File-management: JPG thumbnail chaining leads to over sharpened thumbnails - https://phabricator.wikimedia.org/T76983#833736 (10El_Grafo) Sounds like a plan. But I've got a feeling that people who are not used to judge the quality of sharpening might simply prefer the one they percieve as... [16:40:22] 3Multimedia, MediaWiki-File-management: JPG thumbnail chaining leads to over sharpened thumbnails - https://phabricator.wikimedia.org/T76983#833759 (10Gilles) [16:47:02] 3Multimedia, MediaWiki-File-management: JPG thumbnail chaining leads to over sharpened thumbnails - https://phabricator.wikimedia.org/T76983#833767 (10Smial) [16:52:45] 3Multimedia, MediaWiki-File-management: JPG thumbnail chaining leads to over sharpened thumbnails - https://phabricator.wikimedia.org/T76983#833773 (10Gilles) [16:57:57] 3Multimedia, MediaWiki-File-management: JPG thumbnail chaining leads to over sharpened thumbnails - https://phabricator.wikimedia.org/T76983#833783 (10Gilles) [17:13:22] Ugh kill me now [17:13:40] mw.UploadWizard.config (static) gets set in the constructor for mw.UploadWizard [17:15:43] Just gonna wait for this transcode/upload to finish and then I'll upload the patch. [17:16:28] (03CR) 10Cmcmahon: "Yeah, still a couple of issues to sort out, I have one more update on the way." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178205 (owner: 10Cmcmahon) [17:20:05] Hm, further progress bar silliness [17:20:28] gi11es: The progress bar follows the encoding process, says "Finished!", then goes back to "Uploading..." [17:20:38] Things for another patch. [17:20:45] (03PS1) 10MarkTraceur: Fix Firefogg config order [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178540 [17:20:49] * marktraceur philes a phlask [17:22:10] 3Multimedia, MediaWiki-extensions-UploadWizard: Firefogg encoding process affects the progress bar too much - https://phabricator.wikimedia.org/T78012#833878 (10MarkTraceur) [17:22:17] (03CR) 10jenkins-bot: [V: 04-1] Fix Firefogg config order [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178540 (owner: 10MarkTraceur) [17:22:19] pginer: I wonder if you have any thoughts on that [17:23:38] pginer: We could have two progress bars (one for encoding, another for uploading) or we could do a progress bar for each upload's encoding, or we could just say "encoding..." and leave them in the dark...but I don't think there's any way to estimate how long the encoding process will take relative to the upload, before uploading starts anyway [17:23:54] So a one-bar solution will always be inaccurate. Vastly so. [17:24:02] stfu jenkins [17:24:36] (03PS2) 10MarkTraceur: Fix Firefogg config order [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178540 [17:24:38] Oh, that's actually good news. [17:35:17] the progress bar's alsways done that with firefogg [17:35:34] Yeah, which is why I'm not thinking it's urgent, but it seems like confusing UX [17:41:00] Oh, herp, if you overwrite the prototype, it screws with inheritance. [17:41:03] Curse you neilk. [17:45:51] (03PS2) 10MarkTraceur: Replace FDT callbacks with OOJS events [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178207 [17:45:59] Multiply patch size by ten! MUAHAHAH. [17:52:20] gi11es: What gives you the impression that EE is supposed to be a mixin? [18:14:23] (03PS2) 10MarkTraceur: Replace IframeTransport callbacks with OOJS events [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178223 [18:15:08] (03CR) 10jenkins-bot: [V: 04-1] Replace IframeTransport callbacks with OOJS events [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178223 (owner: 10MarkTraceur) [18:16:36] (03PS3) 10MarkTraceur: Replace IframeTransport callbacks with OOJS events [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178223 [18:22:01] OK, confirmed in -visualeditor. [18:23:28] (03PS4) 10MarkTraceur: Replace IframeTransport callbacks with OOJS events [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178223 [18:26:35] (03PS3) 10MarkTraceur: Replace Firefogg callbacks with OOJS events [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178210 [18:26:38] Thanks for the catch gi11es [19:56:09] 3Multimedia, MediaWiki-extensions-UploadWizard: Work on refactoring uploadwizard - https://phabricator.wikimedia.org/T77853#834247 (10Tgr) Maybe this should be turned into a tracking bug? [20:02:13] (03PS1) 10MarkTraceur: Change existing inheritClass calls to mixinClass [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178587 [20:02:38] (03CR) 10MarkTraceur: "gi11es, fixed the existing inheritClass calls here:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178210 (owner: 10MarkTraceur) [20:14:01] 3Multimedia, MediaWiki-File-management: JPG thumbnail chaining leads to over sharpened thumbnails - https://phabricator.wikimedia.org/T76983#834393 (10Tgr) >>! In T76983#833053, @Gilles wrote: > Sadly it's not just a single command, the sharpening depends on the distance in terms of size between the source image... [20:19:12] 3Multimedia, MediaWiki-File-management: JPG thumbnail chaining leads to over sharpened thumbnails - https://phabricator.wikimedia.org/T76983#834459 (10Tgr) >>! In T76983#826852, @Rillke wrote: > Addressing the sharpening issue in general: > Some people will likely kill me for proposing this but what about a `|sh... [20:48:19] 3Multimedia, MediaWiki-extensions-UploadWizard: Make the step UI and controller classes more self-contained - https://phabricator.wikimedia.org/T78057#834597 (10MarkTraceur) [20:48:33] (03PS1) 10MarkTraceur: Move some details UI stuff out of the Wizard UI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178604 [21:04:19] (03PS11) 10Cmcmahon: QA: update tests for RSpec3 syntax etc. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178205 [21:04:21] (03PS1) 10MarkTraceur: Move some upload step UI stuff out of ui.Wizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178642 [21:04:37] Argh. [21:05:25] (03CR) 10MarkTraceur: [C: 04-1] "Just a sec." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178642 (owner: 10MarkTraceur) [21:06:12] (03CR) 10jenkins-bot: [V: 04-1] Move some upload step UI stuff out of ui.Wizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178642 (owner: 10MarkTraceur) [21:07:22] (03PS2) 10MarkTraceur: Move some upload step UI stuff out of ui.Wizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178642 [21:08:04] (03CR) 10jenkins-bot: [V: 04-1] Move some upload step UI stuff out of ui.Wizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178642 (owner: 10MarkTraceur) [21:12:19] (03PS3) 10MarkTraceur: Move some upload step UI stuff out of ui.Wizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178642 [21:28:31] 3Multimedia, UI-Standardization, MediaWiki-ResourceLoader, MediaWiki-File-management: Create a variant of SvgHandler suitable for T76473 - https://phabricator.wikimedia.org/T76477#801529 (10matmarex) [22:03:07] 3Multimedia, MediaWiki-extensions-MultimediaViewer: SVG icons in MediaViewer should have a fallback - https://phabricator.wikimedia.org/T72933#835030 (10Jdforrester-WMF) Might {T76473} be relevant? That's going to add SVG->PNG fallback ability inside MW without needing to ship PNG assets, so that the OOUI framew... [22:17:53] 3Multimedia, MediaWiki-extensions-MultimediaViewer: SVG icons in MediaViewer should have a fallback - https://phabricator.wikimedia.org/T72933#835102 (10Tgr) [22:19:59] 3Multimedia, MediaWiki-extensions-MultimediaViewer: SVG icons in MediaViewer should have a fallback - https://phabricator.wikimedia.org/T72933#835120 (10Tgr) [22:24:25] (03PS1) 10MarkTraceur: Move detailsValid to details step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/178672 [22:29:13] Oh, good [22:29:33] I was about to say "gah, the SHA-1 patch is still sitting at the top of our queue", but actually it's because Gilles has been working on it [22:29:40] Good job, excellent to see movement [22:44:42] 3Multimedia, Parsoid, MediaWiki-File-management: Use content hash based image / thumb URLs - https://phabricator.wikimedia.org/T66214#835224 (10GWicke) [23:01:01] (03PS4) 10Gergő Tisza: Fix overzealous textarea click handler [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178219 [23:02:21] (03CR) 10jenkins-bot: [V: 04-1] Fix overzealous textarea click handler [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178219 (owner: 10Gergő Tisza) [23:36:36] (03CR) 10Gergő Tisza: "Mostly fixed. Firefox still fails to select the text on every even click (but works correctly on every odd click) - that's apparently a kn" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178219 (owner: 10Gergő Tisza) [23:45:15] 3MediaWiki-extensions-MultimediaViewer, Mobile-Web: [Tracking] Consolidate code for MediaViewer across desktop and mobile - https://phabricator.wikimedia.org/T65504#835439 (10Jdlrobson) [23:49:47] (03PS5) 10Gergő Tisza: Fix overzealous textarea click handler [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178219 [23:50:54] (03CR) 10jenkins-bot: [V: 04-1] Fix overzealous textarea click handler [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178219 (owner: 10Gergő Tisza)