[14:06:54] 3MediaWiki-extensions-MultimediaViewer, Multimedia: MediaViewer should ignore generated captions on special pages - https://phabricator.wikimedia.org/T85234#942974 (10Namit) a:3Namit [15:52:59] Arright, let's see what I get to spend today on [16:05:50] Whoa tgr|away reviewed all the things [16:15:22] (03PS3) 10MarkTraceur: Add tests for mw.fileApi [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181169 [16:15:46] (03CR) 10MarkTraceur: Add tests for mw.fileApi (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181169 (owner: 10MarkTraceur) [16:16:12] (03CR) 10jenkins-bot: [V: 04-1] Add tests for mw.fileApi [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181169 (owner: 10MarkTraceur) [16:16:45] (03CR) 10MarkTraceur: "I guess that part of the code is still using some old method of getting the description text...on it" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181425 (owner: 10MarkTraceur) [16:28:56] (03PS2) 10MarkTraceur: Sanitize | characters in descriptions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181425 [16:39:03] (03PS3) 10MarkTraceur: Add tests for upload step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180541 [16:39:06] (03CR) 10jenkins-bot: [V: 04-1] Add tests for upload step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180541 (owner: 10MarkTraceur) [16:47:33] (03PS4) 10MarkTraceur: Add tests for upload step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180541 [16:48:28] (03PS4) 10Gergő Tisza: Add tests for mw.fileApi [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181169 (owner: 10MarkTraceur) [16:48:45] (03PS5) 10MarkTraceur: Add tests for mw.fileApi [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181169 [16:49:45] (03CR) 10Gergő Tisza: [C: 032] Add tests for upload step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180541 (owner: 10MarkTraceur) [16:49:54] Heh [16:50:09] (03CR) 10Gergő Tisza: [C: 032] Add tests for mw.fileApi [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181169 (owner: 10MarkTraceur) [16:50:15] tgr|away: I think I undid your rebase [16:50:26] (03Merged) 10jenkins-bot: Add tests for upload step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180541 (owner: 10MarkTraceur) [16:51:00] (03Merged) 10jenkins-bot: Add tests for mw.fileApi [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181169 (owner: 10MarkTraceur) [16:56:49] Oh! [16:56:53] I understand everything now [16:57:01] apiDeferred.reject( 'http', { [16:57:19] From the mw.Api code. That's why our error messages always say "http" [17:06:11] (03PS4) 10MarkTraceur: Add tests for tutorial step object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180521 [17:06:14] (03CR) 10jenkins-bot: [V: 04-1] Add tests for tutorial step object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180521 (owner: 10MarkTraceur) [17:07:09] (03PS5) 10MarkTraceur: Add tests for tutorial step object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180521 [17:17:11] (03CR) 10Gergő Tisza: [C: 032] Add tests for tutorial step object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180521 (owner: 10MarkTraceur) [17:17:50] (03Merged) 10jenkins-bot: Add tests for tutorial step object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180521 (owner: 10MarkTraceur) [17:21:09] (03CR) 10Gergő Tisza: [C: 04-1] "I still see a normal pipe in the "To use the file in a wiki, copy this text into a page:" field." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181425 (owner: 10MarkTraceur) [17:26:22] tgr: There *should* be at least one pipe in that field [17:26:34] [[File:...|thumb|]] [17:27:24] I mean, the | inside is not changed to {{!}} [17:27:30] or a HTML entity or whatever [17:28:20] Huh. [17:28:21] Weird. [17:37:56] http://etherpad.wikimedia.org/p/multimedia-weekly-meeting-2015-12-24 [17:44:44] Bam, weekly meeting. [18:00:18] (03PS1) 10Namit: Ignore generated captions on special file related pages [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/181747 [18:17:53] tgr: Were you importing a flickr photo with a description already? [18:18:20] Because if so, that would explain everything [18:18:49] (03PS3) 10MarkTraceur: Sanitize | characters in descriptions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181425 [18:18:55] Try that on for size. [18:22:05] 3Multimedia, MediaWiki-File-management: Display file format of preview if different format from original file - https://phabricator.wikimedia.org/T58546#943303 (10m4tx) a:3m4tx [18:23:16] 3Multimedia, MediaWiki-File-management: bitdepth of UploadStashFile is wrong - https://phabricator.wikimedia.org/T36952#943304 (10polybuildr) I can't seem to find where the bit depth is being stored for an `UnregisteredLocalFile`. I don't seem to be able to find it in the database, which is what the implementati... [18:38:59] The Week of Fast Meetings [18:39:17] A 12-minute planning meeting, an 8-minute SoS [18:39:30] At this rate robla and I will only talk for 5 minutes in our 1:1 [18:40:45] heh...when have I been known to talk for 5 minutes about anything? [18:50:57] marktraceur: so uh, I didn't think this through when I wrote the comment [18:51:07] {{!}} will still break thumbnail markup [18:51:38] It will? [18:51:43] it's already transcluded by the time basic wikitext markup is interpreted [18:51:52] Hmu [18:51:54] Hm.* [18:52:10] so I suppose replacing with a HTML entity is the least painless way to go [18:52:34] | would be the alternative but that looks nasty [18:52:43] Tchyeah no [18:52:58] | is slightly less awful [18:53:27] (03PS4) 10MarkTraceur: Sanitize | characters in descriptions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181425 [18:53:51] (03PS5) 10MarkTraceur: Sanitize | characters in descriptions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181425 [18:53:57] (test change) [19:26:22] tgr: Did you see my ping in -commons? Someone thinks they have a missing file. [19:29:59] 3Multimedia, MediaWiki-extensions-UploadWizard: Titles with percent signs don't get sanitized and are not understood for some reason - https://phabricator.wikimedia.org/T85290#943354 (10MarkTraceur) 3NEW a:3MarkTraceur [20:05:54] (03PS1) 10MarkTraceur: Move title sanitization into new method [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181760 [20:06:21] (03PS2) 10MarkTraceur: Move title sanitization into new method [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181760 [20:07:06] (03CR) 10jenkins-bot: [V: 04-1] Move title sanitization into new method [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181760 (owner: 10MarkTraceur) [20:12:32] Ugh, it's not even working, I hate computers [20:18:54] ...for some reason my blacklist is firing on these files [20:31:24] UploadWizard is stupid [20:36:15] WHY ARE WE SETTING THE FILENAME IN FIFTEEN DIFFERENT PLACES. [20:36:25] GOD DAMN IT. [20:38:27] (03CR) 10Gergő Tisza: [C: 032] "Thanks for the patch!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/181747 (owner: 10Namit) [20:39:23] (03Merged) 10jenkins-bot: Ignore generated captions on special file related pages [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/181747 (owner: 10Namit) [20:39:26] (03PS3) 10MarkTraceur: Move title sanitization into new method [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181760 [20:39:29] Ugh holy christ I hate this [20:59:19] bd808: what's the best way to set a variable in a vagrant puppet module and use it in a role? [20:59:32] just write it to a temporary file or is there something nicer? [20:59:58] I want to autogenerate a Sentry group and then set the group API key in the extension config [21:00:17] hmmm [21:01:06] So you need to exec a command and then query the db? [21:01:56] That sounds a bit like you want a custom fact [21:01:56] I could just use the command's standard output as well [21:02:27] but you need to get the value on every puppet run, not just the first [21:02:45] yes, that's why I was thinking of writing to a file [21:02:50] is it possible to set the api key? [21:02:59] I don't think so [21:03:22] well, technically it might be [21:03:34] it's just the site key + the group DB id [21:03:55] I think what you want is a custom fact -- https://docs.puppetlabs.com/facter/2.3/custom_facts.html [21:04:03] but making assumptions about DB ids is not nice [21:04:15] but if you can find a way to declare rather than query it would be cleaner [21:05:31] writing something to a file and then reading it later would be pretty hacky [21:06:15] there is this code snippet for querying which looks great but cannot be run every time [21:06:18] https://sentry.readthedocs.org/en/latest/faq/index.html#how-do-i [21:07:00] I could write another script for querying but if there is a way to persist facts or variables, that would be a lot easier [21:08:21] You could do it with a file that gets written to /etc/something I guess [21:09:00] (03CR) 10MarkTraceur: Add tests for tutorial step object (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/180521 (owner: 10MarkTraceur) [21:09:08] so the exec would declare that is creates that file (and populates it) and then the config could depend on the exec and read the file contents. [21:09:09] how about writing the script output to a fact file? [21:09:45] yeah that might work too. It's all fighting how puppet wants to work. :/ [21:10:01] although I don't suppose a fact can depend on a resource [21:11:04] no, and theat's where things go off the rails. I've worked with puppet repos before that needed to be run "until things stop changing" because of weird dependency loops. it's not fun [21:11:31] but the same will be a problem with a DB query based fact as well, how do I make it sure the fact is read after the DB was updated? [21:11:49] or are facts always read as late as possible? [21:14:27] I'm not sure actually. I don't know if all facts are materialized at once or as queried [21:16:03] I've thought about a similarly goofy thing where puppet code would make a hiera variable exist but I haven't played around to see if it really works or not [21:18:21] I'd still kind of lear towards using a script that forceable sets the api key in the sentry database if possible [21:18:25] *lean [21:24:53] the key is actually something like 'http://dsn@domain/groupid' [21:25:15] I can probably set the dsn, what I don't like is setting the groupid [21:26:13] of course as long as you start with an empty DB it will always be 1, but meh [21:30:20] stackoverflow claims facts are always collected before the catalog is created so they won't be useful here [21:33:18] That seems likely and would match with my previous "run until it's stable" bad puppet experiences [21:34:10] I guess I'll just go with assuming id=1 [21:34:16] The puppet stuff at $DAYJOB-1 had classes that exported facts that other classes depended on and thus became non-deterministic and sad [21:36:03] tgr: It might be worth picking ori's brain about this. He tens to have good puppet ideas [21:36:06] *tends