[00:35:19] <grrrit-wm>	 (03PS7) 10Sn1per: Show custom Attribution line instead of Author/Credit when available [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 
[00:36:15] <GEOFBOT>	 It works now muahahahahahahahah ^^^^^
[01:24:38] <m4tx>	 tgr: could you have a look at http://www.google-melange.com/gci/task/view/google/gci2014/5789703173308416 please? :)
[01:38:53] <wikibugs>	 3Multimedia, MediaWiki-extensions-MultimediaViewer: Media Viewer should display Attribution instead of author when set (by {{Credit line}} and other templates) - https://phabricator.wikimedia.org/T67445#946516 (10Sn1per)
[01:49:30] <wikibugs>	 3Multimedia, MediaWiki-extensions-MultimediaViewer: Handle Template:Multiple_image in MediaViewer - https://phabricator.wikimedia.org/T85354#946517 (10m4tx) While the implementation for English Wikipedia could 'just work', there are probably dozens of other wikis that have this template as well, but the HTML gen...
[03:05:43] <grrrit-wm>	 (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182038 (owner: 10M4tx)
[03:06:02] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182038 (owner: 10M4tx)
[05:35:16] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 04-1] Change "view terms" to "hide terms" once clicked (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182038 (owner: 10M4tx)
[06:29:43] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 04-1] "You need to fix/expand the tests for the affected classes (except probably metadataPanel which does not have decent test coverage)." (033 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 (owner: 10Sn1per)
[06:52:49] <grrrit-wm>	 (03PS1) 10Unicodesnowman: Ignore events with modifier keys [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182052 
[06:57:02] <grrrit-wm>	 (03PS2) 10Unicodesnowman: Specify media type for interface messages [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/181810 
[06:58:30] <wikibugs>	 3Continuous-Integration, MediaWiki-extensions-MultimediaViewer, Multimedia: MediaViewer Qunit job is not executed for new changesets - https://phabricator.wikimedia.org/T85434#946624 (10Tgr) 3NEW
[07:00:23] <wikibugs>	 3Continuous-Integration, MediaWiki-extensions-MultimediaViewer, Multimedia: MediaViewer Qunit job is not executed for new changesets - https://phabricator.wikimedia.org/T85434#946630 (10Legoktm) qunit and phpunit tests don't run for non-whitelisted users. If you had +2'd the patch, they would run (and hopefully...
[07:00:53] <grrrit-wm>	 (03CR) 10Legoktm: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 (owner: 10Sn1per)
[07:01:15] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Reported the lack of tests as T85434; I couldn't find the reason. Sorry about that; you can run the tests manually by visiting the wiki pa" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 (owner: 10Sn1per)
[07:02:10] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Show custom Attribution line instead of Author/Credit when available [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 (owner: 10Sn1per)
[07:16:15] <wikibugs>	 3Continuous-Integration, MediaWiki-extensions-MultimediaViewer, Multimedia: MediaViewer Qunit job is not executed for new changesets - https://phabricator.wikimedia.org/T85434#946653 (10Tgr) 5Open>3Invalid a:3Tgr Wow, I was totally unaware. Is there a task about improving this behavior? I can see how runni...
[08:33:06] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] "Thanks for the patch!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182052 (owner: 10Unicodesnowman)
[08:33:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: Ignore events with modifier keys [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182052 (owner: 10Unicodesnowman)
[08:33:56] <wikibugs>	 3MediaWiki-extensions-MultimediaViewer, Multimedia: Ignore events with modifier keys - https://phabricator.wikimedia.org/T68329#946693 (10Unicodesnowman) 5Open>3Resolved a:3Unicodesnowman
[08:39:29] <wikibugs>	 3MediaWiki-extensions-MultimediaViewer, Multimedia: Handle Template:Multiple_image in MediaViewer - https://phabricator.wikimedia.org/T85354#946698 (10Tgr) Parsoid outputs `<figure>` (see T64594 although I don't know if the HTML snippet there is still up-to-date) for normal thumbnails, not sure about using `<fig...
[08:41:40] <wikibugs>	 3Multimedia, MediaWiki-extensions-VipsScaler: VipsScaler should pass jshint - https://phabricator.wikimedia.org/T63643#946700 (10Tgr) 5Open>3Resolved a:3Tgr
[09:01:40] <wikibugs>	 3MediaWiki-extensions-Score: ext:Score can't create a vorbis file - https://phabricator.wikimedia.org/T85439#946714 (10Crochet.david) 3NEW
[10:35:46] <grrrit-wm>	 (03PS2) 10M4tx: Change "view terms" to "hide terms" once clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182038 
[10:44:28] <grrrit-wm>	 (03PS1) 10Unicodesnowman: Parse standard date formats with wfTimestamp() [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/182061 
[10:48:04] <grrrit-wm>	 (03CR) 10Unicodesnowman: "It'd probably be useful to have a test that tests parsing of a EXIF datatime, however I haven't been able to find any files on commons tha" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/182061 (owner: 10Unicodesnowman)
[11:16:06] <wikibugs>	 3MediaWiki-Uploading: No error handling for File::transform() in SpecialUpload::getDescriptionSection() - https://phabricator.wikimedia.org/T85409#946892 (10Paladox) Hi i managed to get the video to upload now but i am not sure why the error was showing sometimes.
[11:33:49] <grrrit-wm>	 (03CR) 10Siebrand: [C: 032] "Thanks!" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/181810 (owner: 10Unicodesnowman)
[11:34:18] <grrrit-wm>	 (03Merged) 10jenkins-bot: Specify media type for interface messages [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/181810 (owner: 10Unicodesnowman)
[11:37:27] <grrrit-wm>	 (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182038 (owner: 10M4tx)
[12:45:37] <wikibugs>	 3MediaWiki-Uploading: No error handling for File::transform() in SpecialUpload::getDescriptionSection() - https://phabricator.wikimedia.org/T85409#947009 (10Aklapper) 5Open>3stalled Please provide error logs when this happens (and reset the status of this task from stalled to open); otherwise this cannot be...
[16:13:36] <wikibugs>	 3Multimedia, MediaWiki-extensions-UploadWizard: Refactor details UI code so it's less repetitive and nasty - https://phabricator.wikimedia.org/T76388#947186 (10MarkTraceur) 5Open>3Resolved
[16:14:49] <wikibugs>	 3MediaWiki-extensions-UploadWizard, Multimedia: Test step controllers - https://phabricator.wikimedia.org/T78792#853361 (10MarkTraceur) I still need to rebase https://gerrit.wikimedia.org/r/181116 and then it needs merging.
[16:15:52] <grrrit-wm>	 (03PS3) 10MarkTraceur: Add unit tests for Thanks step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181116 
[16:30:33] * marktraceur has overextended his usefulness for the day
[16:40:17] <marktraceur>	 I feel crappy
[16:40:26] <marktraceur>	 I will be around, but probably not too responsive
[16:51:37] <grrrit-wm>	 (03PS8) 10Sn1per: Show custom Attribution line instead of Author/Credit when available [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 
[16:51:49] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Show custom Attribution line instead of Author/Credit when available [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 (owner: 10Sn1per)
[16:54:51] <grrrit-wm>	 (03PS9) 10Sn1per: Show custom Attribution line instead of Author/Credit when available [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 
[16:55:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Show custom Attribution line instead of Author/Credit when available [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 (owner: 10Sn1per)
[17:01:05] <grrrit-wm>	 (03PS10) 10Sn1per: Show custom Attribution line instead of Author/Credit when available [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 
[17:01:19] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Show custom Attribution line instead of Author/Credit when available [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 (owner: 10Sn1per)
[17:01:35] <marktraceur>	 ...having trouble?
[17:14:51] <GEOFBOT>	 marktraceur: lol
[17:14:57] <GEOFBOT>	 I get a jshint error
[17:15:00] <marktraceur>	 I see that
[17:15:08] <GEOFBOT>	 Confusing use of '!'
[17:15:20] <GEOFBOT>	 on if ( attribution && !(authorCount > 1) ) {
[17:15:40] <marktraceur>	 Well that *is* confusing
[17:15:48] <marktraceur>	 GEOFBOT: authorCount <= 1
[17:15:59] <GEOFBOT>	 oh.
[17:16:02] <GEOFBOT>	 derp *facepalm*
[17:16:16] <marktraceur>	 Our dunce hat is at the cleaners :P
[17:16:18] <GEOFBOT>	 thanks
[17:16:28] <marktraceur>	 GEOFBOT: My pleasure!
[17:16:38] <grrrit-wm>	 (03PS11) 10Sn1per: Show custom Attribution line instead of Author/Credit when available [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 
[17:17:07] <GEOFBOT>	 brb
[17:20:20] <GEOFBOT>	 marktraceur: could you run a junit on that patchset
[17:20:32] <marktraceur>	 junit?
[17:20:34] <marktraceur>	 Or qunit?
[17:20:42] <GEOFBOT>	 my bad 
[17:20:43] <GEOFBOT>	 qunit
[17:20:46] <GEOFBOT>	 ugh i am so bad at this stuff
[17:21:01] <marktraceur>	 No problem :)
[17:21:49] <marktraceur>	 Gotta boot my vm.
[17:22:19] <GEOFBOT>	 can't you just comment 'recheck' on gerrit or something
[17:23:56] <marktraceur>	 Hm, maybe
[17:24:18] <grrrit-wm>	 (03CR) 10MarkTraceur: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 (owner: 10Sn1per)
[17:24:46] <marktraceur>	 GEOFBOT: You can also run the qunit tests on your wiki
[17:25:06] <grrrit-wm>	 (03PS12) 10Sn1per: Show custom Attribution line instead of Author/Credit when available [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 
[17:25:11] <GEOFBOT>	 oh yea
[17:25:14] <GEOFBOT>	 derp again
[17:25:18] <GEOFBOT>	 sighhhhhh :P
[17:25:21] <marktraceur>	 GEOFBOT: http://www.mediawiki.org/wiki/Manual:JavaScript_unit_testing
[17:25:38] <grrrit-wm>	 (03CR) 10MarkTraceur: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 (owner: 10Sn1per)
[17:26:30] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Show custom Attribution line instead of Author/Credit when available [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 (owner: 10Sn1per)
[17:26:39] <marktraceur>	 Aw.
[17:26:39] <grrrit-wm>	 (03PS13) 10Sn1per: Show custom Attribution line instead of Author/Credit when available [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 
[17:26:48] <GEOFBOT>	 that should fix it ^^
[17:26:58] <GEOFBOT>	 forgot to change total amount of tests :P
[17:27:07] <grrrit-wm>	 (03CR) 10MarkTraceur: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 (owner: 10Sn1per)
[17:28:41] <GEOFBOT>	 hooray it worked
[17:29:11] <GEOFBOT>	 thanks again marktraceur
[17:30:43] <marktraceur>	 No problem :)
[19:50:16] <grrrit-wm>	 (03PS1) 10Paladox: Update dependencies for MwEmbedSupport [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/182094 
[19:50:29] <grrrit-wm>	 (03PS2) 10Paladox: Update dependencies for MwEmbedSupport [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/182094 
[20:36:43] <wikibugs>	 3Multimedia, MediaWiki-extensions-CommonsMetadata: Prefer information templates that are about the file - https://phabricator.wikimedia.org/T74084#947637 (10Tgr) 5Resolved>3Open Reopening. {{Book}} should not be ignored when there are no other templates on the page, it would cause lack of attribution for e.g...
[20:36:45] <wikibugs>	 3Multimedia, MediaWiki-extensions-MultimediaViewer: Display "and X more authors" when appropriate - https://phabricator.wikimedia.org/T74082#947639 (10Tgr)
[20:46:09] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 04-1] "Looks good, thanks! There is a small logic issue left to fix; authorCount is not always set, the parameter documentation is wrong on that " (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 (owner: 10Sn1per)
[20:56:10] <grrrit-wm>	 (03PS14) 10Sn1per: Show custom Attribution line instead of Author/Credit when available [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 
[21:01:32] <grrrit-wm>	 (03CR) 10Gergő Tisza: "The tests for DataCollector can take arbitrary input so this should not be a problem." (031 comment) [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/182061 (owner: 10Unicodesnowman)
[21:01:37] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 04-1] Parse standard date formats with wfTimestamp() [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/182061 (owner: 10Unicodesnowman)
[21:14:15] <wikibugs>	 3Multimedia, MediaWiki-extensions-MultimediaViewer: Fix documentation of mmv.model.Image fields in MediaViewer - https://phabricator.wikimedia.org/T85475#947708 (10Tgr) 3NEW
[21:14:39] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] "Thanks for the patch!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 (owner: 10Sn1per)
[21:14:57] <wikibugs>	 3Multimedia, MediaWiki-extensions-MultimediaViewer: Media Viewer should display Attribution instead of author when set (by {{Credit line}} and other templates) - https://phabricator.wikimedia.org/T67445#947714 (10Tgr) 5Open>3Resolved
[21:15:34] <grrrit-wm>	 (03Merged) 10jenkins-bot: Show custom Attribution line instead of Author/Credit when available [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182037 (owner: 10Sn1per)
[21:26:06] <wikibugs>	 3pywikibot-core, MediaWiki-API, MediaWiki-File-management: FileRepo::getInfo() information is very different depending on the subclass in use for each repo - https://phabricator.wikimedia.org/T85153#947736 (10Anomie) >>! In T85153#943695, @XZise wrote: > Now one question I have is if it is possible to use shared...
[21:37:48] <wikibugs>	 3Multimedia, MediaWiki-extensions-MultimediaViewer: Backport MediaViewer to MediaWiki 1.23 LTS - https://phabricator.wikimedia.org/T85193#947772 (10Aklapper)
[21:47:35] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Add unit tests for Thanks step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181116 (owner: 10MarkTraceur)
[21:48:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: Add unit tests for Thanks step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/181116 (owner: 10MarkTraceur)
[22:03:32] <wikibugs>	 3pywikibot-core, MediaWiki-API, MediaWiki-File-management: FileRepo::getInfo() information is very different depending on the subclass in use for each repo - https://phabricator.wikimedia.org/T85153#947827 (10Tgr) >>! In T85153#947736, @Anomie wrote: > Theoretically yes, although I'm not aware of any implementat...
[22:13:59] <grrrit-wm>	 (03CR) 10Gergő Tisza: "Looks good, there is a small issue with the test." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182038 (owner: 10M4tx)
[22:14:06] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 04-1] Change "view terms" to "hide terms" once clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182038 (owner: 10M4tx)
[22:23:23] <grrrit-wm>	 (03PS3) 10M4tx: Change "view terms" to "hide terms" once clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182038 
[22:28:41] <wikibugs>	 3Multimedia, MediaWiki-extensions-CommonsMetadata: Prefer information templates that are about the file - https://phabricator.wikimedia.org/T74084#947896 (10Tgr) GCI task: https://www.google-melange.com/gci/task/view/google/gci2014/5908351913295872
[22:36:59] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] "Thanks for the patch!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182038 (owner: 10M4tx)
[22:37:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: Change "view terms" to "hide terms" once clicked [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182038 (owner: 10M4tx)
[22:38:30] <wikibugs>	 3Multimedia, MediaWiki-extensions-MultimediaViewer: "View terms" should switch to "Hide terms" once clicked - https://phabricator.wikimedia.org/T71233#947911 (10Tgr) 5Open>3Resolved
[22:45:07] <wikibugs>	 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard lacks path from it to other sister projects - https://phabricator.wikimedia.org/T78524#947926 (10Aklapper) 5Open>3stalled
[23:11:58] <wikibugs>	 3Multimedia, MediaWiki-extensions-MultimediaViewer: Handle Template:Multiple_image in MediaViewer - https://phabricator.wikimedia.org/T85354#947964 (10m4tx) It looks like W3C's HTML reference does not say anything about putting multiple images in one `<figure>` (it just say 'flow content', which may be almost an...
[23:46:01] <wikibugs>	 3Multimedia, MediaWiki-extensions-MultimediaViewer: Handle Template:Multiple_image in MediaViewer - https://phabricator.wikimedia.org/T85354#948054 (10Tgr) The standard requires `<figcaption>` to be the first or last element, so only one `<figcaption>` per `<figure>`. When you have three images with three captio...