[02:02:46] 3MediaWiki-extensions-PagedTiffHandler, Multimedia: On top of file page is shown: bool(false) NULL - https://phabricator.wikimedia.org/T85651#951669 (10Legoktm) [02:31:36] (03PS1) 10Unicodesnowman: Log right-clicks on the image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182399 [02:58:11] (03CR) 10Gergő Tisza: [C: 032] "Thanks for the patch!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182399 (owner: 10Unicodesnowman) [02:59:05] (03Merged) 10jenkins-bot: Log right-clicks on the image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/182399 (owner: 10Unicodesnowman) [03:21:05] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Measure how often users right-click the image in MediaViewer - https://phabricator.wikimedia.org/T75962#951693 (10Unicodesnowman) 5Open>3Resolved a:3Unicodesnowman [03:51:25] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Measure how often users right-click the image in MediaViewer - https://phabricator.wikimedia.org/T75962#951710 (10Tgr) 5Resolved>3Open We still need to update the dashboard. [03:52:39] (03PS1) 10Gergő Tisza: Add image right clicks to stats [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/182404 [04:45:29] tgr_: the phpunit tests have a lot of errors [04:45:36] for CommonsMetadata [04:46:18] "No informationFields type in template data" [05:09:25] (03PS5) 10Sn1per: [WIP] Use metadata from Blacklisted templates if they're alone [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/182371 [05:12:03] GEOFBOT: maybe something is set up wrong? unit tests are run every time when new code is merged so they are rarely broken on master [05:12:21] They work in master [05:12:26] I forgot ot say sorry [05:12:35] I added something but I don't know where I screwed up [05:13:12] happy new year btw [05:13:13] ah, ok [05:13:37] I still have 3 hours to go :) [05:13:55] you mean the new test you added is broken? or the existing ones? [05:14:33] somehow [05:14:40] by adding my new test [05:14:46] 11 other tests failed [05:14:54] along with the new test [05:17:13] $data2 should be outside of the foreach [05:17:42] but in general that code is a bit overcomplicated, you don't need two arrays [05:18:39] the original idea was fine, just walk through the array and unset any book fields if the count is not 1 [05:37:44] tgr_: The master version of CommonsMetadata handles {{Other date}} differently than the version on Commons [05:37:47] is that expected? [05:38:32] On Commons: between ... [05:38:40] On master: 1943-04-19 [05:41:13] (03PS6) 10Sn1per: Use metadata from Blacklisted templates if they're alone [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/182371 [05:41:22] If so, then everything is done :D ^^^ [05:50:31] good night, talk to you guys tomorrow [09:32:21] (03CR) 10Gergő Tisza: [C: 04-1] "Code style issues; the logic looks good." (034 comments) [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/182371 (owner: 10Sn1per) [09:34:45] (03CR) 10Gergő Tisza: "Re: your IRC question, yeah, the change in date handling has just been merged to master." [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/182371 (owner: 10Sn1per) [13:25:59] 3MediaWiki-File-management, Multimedia: More prominent display of other format available for download in image description pages - https://phabricator.wikimedia.org/T64305#951822 (10RuchirangaW) I am all new to Wikimedia development and am willing to be a contributor. I wish to work on this bug as my first fix. [16:32:59] (03PS7) 10Sn1per: Use metadata from Blacklisted templates if they're alone [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/182371 [17:06:39] (03PS8) 10Sn1per: Use metadata from Blacklisted templates if they're alone [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/182371 [17:20:52] Happy Public Domain Day! https://twitter.com/Wikimedia_BE/status/550699110144421888 [17:20:59] (is about multimedia :p ) [17:40:12] :D [17:40:45] happy new year too [20:44:34] 3MediaWiki-Uploading, Multimedia: Upload SVG checks blacklist filter attributes, even if local to current svg doc - https://phabricator.wikimedia.org/T69044#952038 (10Perhelion)