[00:10:31] (03PS1) 10M4tx: Fix download panel not showing on rclick after pressing esc [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/184520 (https://phabricator.wikimedia.org/T86389) [00:32:27] 3Multimedia, Analytics, MediaWiki-extensions-MultimediaViewer: Collect more data in MediaViewer network performance logging - https://phabricator.wikimedia.org/T86609#972548 (10Tgr) 3NEW [00:36:13] (03CR) 10Gergő Tisza: [C: 032] Fix download panel not showing on rclick after pressing esc [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/184520 (https://phabricator.wikimedia.org/T86389) (owner: 10M4tx) [00:46:06] (03Merged) 10jenkins-bot: Fix download panel not showing on rclick after pressing esc [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/184520 (https://phabricator.wikimedia.org/T86389) (owner: 10M4tx) [00:46:52] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Open state of download panel gets messed up in MediaViewer - https://phabricator.wikimedia.org/T86389#972571 (10Tgr) Needs backport to `wmf/1.25wmf14`. [00:47:21] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Open state of download panel gets messed up in MediaViewer - https://phabricator.wikimedia.org/T86389#972572 (10Tgr) [01:00:46] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Open state of download panel gets messed up in MediaViewer - https://phabricator.wikimedia.org/T86389#972584 (10Tgr) @m4tx: do you want to do the backport? Not part of the GCI task (so don't hesitate to say no if you are not interested :) just in case you want... [01:05:32] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Open state of download panel gets messed up in MediaViewer - https://phabricator.wikimedia.org/T86389#972589 (10m4tx) @tgr sure, why not! Although, what timezone do you mean by "Tuesday"? Cause I will be able to do it probably after 4pm UTC. :P [01:20:20] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Open state of download panel gets messed up in MediaViewer - https://phabricator.wikimedia.org/T86389#972632 (10Tgr) See the [[ https://wikitech.wikimedia.org/wiki/Deployments | deployment schedule ]] - it should fit into one of the SWAT deployments before the... [02:59:36] (03PS1) 10Unicodesnowman: Display the file name in metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/184541 (https://phabricator.wikimedia.org/T76680) [04:00:28] (03CR) 10Unicodesnowman: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/184541 (https://phabricator.wikimedia.org/T76680) (owner: 10Unicodesnowman) [04:33:34] (03CR) 10Unicodesnowman: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/184541 (https://phabricator.wikimedia.org/T76680) (owner: 10Unicodesnowman) [08:36:00] (03CR) 10Gergő Tisza: [C: 04-1] "Looks good, but there are some small LESS errors, and there should be an empty*() function for the filename (when you navigate to the next" (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/184541 (https://phabricator.wikimedia.org/T76680) (owner: 10Unicodesnowman) [08:51:02] (03CR) 10Unicodesnowman: "Thanks for the CI whitelist request!" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/184541 (https://phabricator.wikimedia.org/T76680) (owner: 10Unicodesnowman) [08:53:35] (03PS2) 10Unicodesnowman: Display the file name in metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/184541 (https://phabricator.wikimedia.org/T76680) [09:10:03] 3Multimedia, MediaWiki-extensions-Extensions-requests: Implement delinker functionality as a MediaWiki extension - https://phabricator.wikimedia.org/T86483#972989 (10Steinsplitter) If there is disagreement to create a extension, at least the bot needs a rewrite. I have the feeling that the bot dies soon (big err... [09:32:19] (03CR) 10Gergő Tisza: Display the file name in metadata panel (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/184541 (https://phabricator.wikimedia.org/T76680) (owner: 10Unicodesnowman) [09:33:33] (03CR) 10Gergő Tisza: [C: 032] "Thanks for the patch! If there are other bugs annoying you, you can always request a GCI task for them :)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/184541 (https://phabricator.wikimedia.org/T76680) (owner: 10Unicodesnowman) [09:35:06] (03Merged) 10jenkins-bot: Display the file name in metadata panel [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/184541 (https://phabricator.wikimedia.org/T76680) (owner: 10Unicodesnowman) [09:38:21] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Faster access to file names in MediaViewer - https://phabricator.wikimedia.org/T76680#973053 (10Tgr) 5Open>3Resolved [10:29:08] 3MediaWiki-extensions-GWToolset, Multimedia: "HTTP request timed out" for large files - https://phabricator.wikimedia.org/T86024#973126 (10Lokal_Profil) [10:37:34] tgr, there isn't a distinct mmv-open event, right? should I create one? [12:12:51] 3Multimedia, MediaWiki-extensions-MultimediaViewer: MultimediaViewer should not leave so many history entries when closed - https://phabricator.wikimedia.org/T64266#973239 (10Unicodesnowman) I've created a [[ https://www.mediawiki.org/wiki/User:Unicodesnowman/T64266Prototype.js | prototype ]] for approach D. To... [13:59:08] (03PS1) 10M4tx: Fix download panel not showing on rclick after pressing esc [extensions/MultimediaViewer] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184630 (https://phabricator.wikimedia.org/T86389) [14:04:09] (03PS2) 10Gergő Tisza: Fix download panel not showing on rclick after pressing esc [extensions/MultimediaViewer] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184630 (https://phabricator.wikimedia.org/T86389) (owner: 10M4tx) [14:06:45] unicodesnowman: if you feel it helps, sure [14:07:35] but for a prototype, it's worth keeping things as simple as possible [14:07:50] the code doesn't have to be nice as long as it works [14:08:51] since it might be thrown away anyway in the end if the user tests don't work out [14:09:16] yep. I've done the prototype with the events -- originally I did it in a ugly / naive way, however that breaks down if the user presses 'Forward' [14:09:34] so I needed to detect when it's opened/closed [14:09:36] you could check the current URL to see if the viewer is open or something like that [14:10:06] also, I think MVBootstrap.hash gets an extra flag for open [14:11:09] hm, not really [14:11:37] the browserHistory is called in MMVB.internalHashChange unfortunately [14:11:44] anyway, already done the prototype :) [14:12:54] I would still go with window.location.hash.indexOf( '#mediaviewer/')!==0 [14:13:36] but if a new event looks like the best solution, there is nothing wrong with creating one [14:14:19] (03CR) 10Gergő Tisza: [C: 032] Fix download panel not showing on rclick after pressing esc [extensions/MultimediaViewer] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184630 (https://phabricator.wikimedia.org/T86389) (owner: 10M4tx) [14:14:58] I'll go with hash.indexof() then, will be a lot simpler. feels a little dirty, but as you said, it's a prototype [14:15:55] (03CR) 10Gergő Tisza: "There is a "Cherry-pick to" button in Gerrit at the top of the file list which makes this step a little easier." [extensions/MultimediaViewer] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184630 (https://phabricator.wikimedia.org/T86389) (owner: 10M4tx) [14:16:21] (03Merged) 10jenkins-bot: Fix download panel not showing on rclick after pressing esc [extensions/MultimediaViewer] (wmf/1.25wmf14) - 10https://gerrit.wikimedia.org/r/184630 (https://phabricator.wikimedia.org/T86389) (owner: 10M4tx) [14:25:17] unicodesnowman: this seems to use replaceState instead of pushState when you exit the viewer [14:25:38] (looking at the userscript version with mmv-open) [14:28:20] ah oops, i've only tried exiting the viewer with the back button instead of 'x' [14:30:05] i didn't even realize there was a close button tbh [14:32:38] Whoa [14:32:52] unicodesnowman: You are a fascinating data point. [14:33:14] I'm sure the politically correct thing to say would have been "special snowflake" [14:33:29] unicodesnowman: Also try the escape button. [14:34:32] marktraceur, lol [14:44:29] tgr, updated userscript [14:55:08] thanks! [14:55:52] 3Multimedia, MediaWiki-extensions-MultimediaViewer: MultimediaViewer should not leave so many history entries when closed - https://phabricator.wikimedia.org/T64266#973683 (10Tgr) >>! In T64266#973239, @Unicodesnowman wrote: > I've created a [[ https://www.mediawiki.org/wiki/User:Unicodesnowman/T64266Prototype.j... [14:56:24] 3Multimedia, Analytics, MediaWiki-extensions-MultimediaViewer: Collect more data in MediaViewer network performance logging - https://phabricator.wikimedia.org/T86609#973685 (10Gilles) [15:04:21] 3Multimedia, Analytics, MediaWiki-extensions-MultimediaViewer: Find a robust way of filtering local cache hits out of performance figures - https://phabricator.wikimedia.org/T86672#973711 (10Gilles) 3NEW [15:36:49] 3Multimedia, Analytics, MediaWiki-extensions-MultimediaViewer: Fix filter differentiating between varnish hits and misses in performance queries - https://phabricator.wikimedia.org/T86675#973778 (10Gilles) 3NEW a:3Gilles [16:11:47] 3Multimedia, Beta-Cluster, MediaWiki-extensions-Sentry: Deploy Sentry on beta cluster - https://phabricator.wikimedia.org/T78807#973862 (10greg) [16:19:09] 3Multimedia, MediaWiki-extensions-Sentry: Quick/short security review of Extension:Sentry - https://phabricator.wikimedia.org/T86677#973876 (10greg) 3NEW a:3csteipp [16:19:20] 3Multimedia, Beta-Cluster, MediaWiki-extensions-Sentry: Deploy Sentry on beta cluster - https://phabricator.wikimedia.org/T78807#973883 (10greg) @tgr tells me that this extension will change a lot between now and deployment to production, but I'd like @csteipp to do a cursory glance at the idea of the extension... [16:20:04] (03PS1) 10Gilles: Fix filter differentiating between varnish hits and misses [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/184646 (https://phabricator.wikimedia.org/T86675) [16:24:22] well that's too many hours spent in SQL and writing an email... [16:25:50] Any time spent in SQL is too much time spent in SQL. [16:26:15] well I did find actionable things [16:26:23] the bottom line is that averages are misleading [16:28:32] I'm curious to see if getting rid of the extreme buckets would have a measurable effect on the amount of varnish misses. but we'll probably get the answer without having to touch the buckets by logging the requested width [16:29:34] there's possible low-hanging fruit there, people with either tiny windows or giant ones might be skewing the stats through their slower experience [16:30:19] anecdotally speaking, fabrice has a large retina monitor, right? [16:52:34] 3MediaWiki-extensions-UploadWizard, Multimedia: Move newUpload to the Upload step controller - https://phabricator.wikimedia.org/T86679#973962 (10MarkTraceur) 3NEW a:3MarkTraceur [16:53:13] (03PS1) 10MarkTraceur: Move showTooManyFilesWarning to Upload step and ui [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/184686 (https://phabricator.wikimedia.org/T86679) [17:06:05] (03CR) 10Gilles: [C: 032] Apply coding conventions for JavaScript [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/184383 (owner: 10Gerrit Patch Uploader) [17:19:11] (03PS1) 10MarkTraceur: Move progress bar handling to upload step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/184688 (https://phabricator.wikimedia.org/T86679) [17:19:16] * marktraceur moves ALL THE THINGS [17:21:14] I think that's enough. I think I might be able to move newUpload now. [17:21:22] Maybe...maybe one more. [17:37:07] 3MediaWiki-API, Multimedia: API does not fail gracefully when data is too large to display - https://phabricator.wikimedia.org/T86611#974012 (10Anomie) [17:38:52] 3MediaWiki-API, Multimedia: API does not fail gracefully when data is too large to display - https://phabricator.wikimedia.org/T86611#972595 (10Anomie) A more useful test url is [[https://commons.wikimedia.org/w/api.php?action=query&continue=%7C%7C&iistart=2015-01-10T00:54:36Z&prop=imageinfo&titles=File%3A%D0%A1... [19:55:50] 3Wikimedia-Media-storage, Multimedia: Thumbnails for specific PDF file on Commons not generated: "no decode delegate for this image format" - https://phabricator.wikimedia.org/T72734#974385 (106thCommonSense) >>! In T72734#952161, @Bawolff wrote: >>>! In T72734#946929, @Aklapper wrote: >>>>! In T72734#764455, @T... [19:56:02] Well *that* was fun [19:56:14] Commons decided not to play nice with a mw.config update, fixed now [20:44:25] (03PS1) 10MarkTraceur: Move updateFileCounts to the step controllers [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/184739 (https://phabricator.wikimedia.org/T86679) [20:44:27] Now THAT was annoying. [20:44:37] Oh, man, there's gonna be a qunit failure isn't there. [20:45:51] (03CR) 10jenkins-bot: [V: 04-1] Move updateFileCounts to the step controllers [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/184739 (https://phabricator.wikimedia.org/T86679) (owner: 10MarkTraceur) [20:45:54] Crap [20:59:56] (03PS2) 10MarkTraceur: Move updateFileCounts to the step controllers [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/184739 (https://phabricator.wikimedia.org/T86679) [21:01:08] (03CR) 10jenkins-bot: [V: 04-1] Move updateFileCounts to the step controllers [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/184739 (https://phabricator.wikimedia.org/T86679) (owner: 10MarkTraceur) [21:02:57] (03PS3) 10MarkTraceur: Move updateFileCounts to the step controllers [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/184739 (https://phabricator.wikimedia.org/T86679) [21:08:12] (03PS1) 10M4tx: Improve error messages UI for Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/184753 (https://phabricator.wikimedia.org/T77272) [21:08:39] (03CR) 10jenkins-bot: [V: 04-1] Improve error messages UI for Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/184753 (https://phabricator.wikimedia.org/T77272) (owner: 10M4tx) [21:10:37] (03PS2) 10M4tx: Improve error messages UI for Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/184753 (https://phabricator.wikimedia.org/T77272)