[00:01:21] 3MediaWiki-extensions-Extensions-requests, Multimedia: Implement delinker functionality as a MediaWiki extension - https://phabricator.wikimedia.org/T86483#977845 (10Ricordisamoa) >>! In T86483#975785, @Magnus wrote: > - Probably PHP, unless anyone objects :-) Any good, current Wiki editing libraries out there... [01:42:11] 3Multimedia, MediaWiki-API: API does not fail gracefully when data is too large to display - https://phabricator.wikimedia.org/T86611#978409 (10Magog_the_Ogre) Addendum: actually I think it's impossible to continue the query at all, even if the bot understands the error. The only way to get around it is to remov... [03:17:45] (03PS1) 10Unicodesnowman: Show (tm) symbol if applicable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185119 (https://phabricator.wikimedia.org/T77717) [04:15:33] 3Multimedia, MediaWiki-API: API does not fail gracefully when data is too large to display - https://phabricator.wikimedia.org/T86611#978609 (10Tgr) Is this specific to the imageinfo API or have you seen this behavior at other places? [04:39:36] (03CR) 10Gergő Tisza: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185119 (https://phabricator.wikimedia.org/T77717) (owner: 10Unicodesnowman) [04:40:32] (03CR) 10jenkins-bot: [V: 04-1] Show (tm) symbol if applicable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185119 (https://phabricator.wikimedia.org/T77717) (owner: 10Unicodesnowman) [04:45:55] (03PS2) 10Unicodesnowman: Show (tm) symbol if applicable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185119 (https://phabricator.wikimedia.org/T77717) [04:54:58] (03CR) 10Gergő Tisza: "recheck" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185119 (https://phabricator.wikimedia.org/T77717) (owner: 10Unicodesnowman) [05:06:38] (03CR) 10Gergő Tisza: [C: 04-1] "You should also add Restrictions to the mmv.provider.ImageInfo field whitelist. (It won't cause a problem to add it even if it is not prov" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185119 (https://phabricator.wikimedia.org/T77717) (owner: 10Unicodesnowman) [05:15:33] (03PS3) 10Unicodesnowman: Show (tm) symbol if applicable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185119 (https://phabricator.wikimedia.org/T77717) [05:24:19] (03CR) 10Gergő Tisza: [C: 04-1] "Sorry, I forgot to mention this in the task description, but could you add a tooltip saying "Trademarked"? (We use tipsy for tooltips.) Ot" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185119 (https://phabricator.wikimedia.org/T77717) (owner: 10Unicodesnowman) [05:24:40] (03CR) 10Gergő Tisza: "Other than that, it's all good." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185119 (https://phabricator.wikimedia.org/T77717) (owner: 10Unicodesnowman) [05:51:15] tgr, a new i18n message I've added to i18n/en.json and i18n/qqq.json does not show up, it displays as "" [05:51:50] in the JS, if I refer to any other key it works fine, and if I change another key it works as well. is there anything I'm missing for adding a new i18n message? [05:56:39] you need to add it to the resource module definition [06:05:13] thanks! [06:10:38] (03PS4) 10Unicodesnowman: Show (tm) symbol if applicable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185119 (https://phabricator.wikimedia.org/T77717) [06:50:34] unicodesnowman: can you also add the new field to the model/provider unit tests? [06:50:38] 3Multimedia, Project-Creators: Create sprint projects for Multimedia - https://phabricator.wikimedia.org/T86857#978761 (10Qgil) p:5Triage>3Normal One or two members of the Multimedia team should request permissions to create projects. See #Project-Creators . [06:50:41] sorry for not spotting that earlier [07:01:26] (03CR) 10Gergő Tisza: [C: 04-1] "oops, I forgot about the tests. Can you expand the model and provider tests for the new field? (The MetadataPanel is mess and not properly" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185119 (https://phabricator.wikimedia.org/T77717) (owner: 10Unicodesnowman) [07:06:17] (03PS5) 10Unicodesnowman: Show (tm) symbol if applicable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185119 (https://phabricator.wikimedia.org/T77717) [07:06:27] heh, qunit is quite verbose [07:15:36] (03CR) 10Gergő Tisza: [C: 032] Show (tm) symbol if applicable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185119 (https://phabricator.wikimedia.org/T77717) (owner: 10Unicodesnowman) [07:16:23] (03CR) 10jenkins-bot: [V: 04-1] Show (tm) symbol if applicable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185119 (https://phabricator.wikimedia.org/T77717) (owner: 10Unicodesnowman) [07:17:28] oh hmm [07:17:54] that's a super annoying feature of qunit [07:21:38] (03PS6) 10Unicodesnowman: Show (tm) symbol if applicable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185119 (https://phabricator.wikimedia.org/T77717) [07:24:16] (03CR) 10Gergő Tisza: [C: 032] Show (tm) symbol if applicable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185119 (https://phabricator.wikimedia.org/T77717) (owner: 10Unicodesnowman) [07:25:24] (03Merged) 10jenkins-bot: Show (tm) symbol if applicable [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185119 (https://phabricator.wikimedia.org/T77717) (owner: 10Unicodesnowman) [07:25:33] yay! [08:05:57] (03CR) 10Raimond Spekking: [C: 032] file name -> filename [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/184943 (owner: 10Siebrand) [08:06:57] (03Merged) 10jenkins-bot: file name -> filename [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/184943 (owner: 10Siebrand) [08:08:33] (03CR) 10Raimond Spekking: [C: 032] file name -> filename [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/184957 (owner: 10Siebrand) [08:09:29] (03Merged) 10jenkins-bot: file name -> filename [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/184957 (owner: 10Siebrand) [09:09:30] 3MediaWiki-extensions-Extensions-requests, Multimedia: Implement delinker functionality as a MediaWiki extension - https://phabricator.wikimedia.org/T86483#978940 (10Magnus) Well, the current Delinker is written in Python, and this bug exists because no one is maintaining it, so Python is actually the one langua... [12:44:14] 3MediaWiki-extensions-Extensions-requests, Multimedia: Implement delinker functionality as a MediaWiki extension - https://phabricator.wikimedia.org/T86483#979313 (10Steinsplitter) >>! In T86483#977845, @Ricordisamoa wrote: > Maintaining is quite a big word, but I think the Pywikibot team could have a look at th... [12:50:51] 3MediaWiki-extensions-Extensions-requests, Multimedia: Implement delinker functionality as a MediaWiki extension - https://phabricator.wikimedia.org/T86483#979316 (10Steinsplitter) >>! In T86483#978940, @Magnus wrote: > If someone wants to seriously maintain the Python Delinker, please let me know so I don't was... [13:33:54] (03CR) 10Gilles: [C: 032] Generate pageview stats [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/179872 (https://phabricator.wikimedia.org/T78189) (owner: 10Gergő Tisza) [13:34:02] (03Merged) 10jenkins-bot: Generate pageview stats [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/179872 (https://phabricator.wikimedia.org/T78189) (owner: 10Gergő Tisza) [13:40:00] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Pass extra GET parameter for Media Viewer preload requests - https://phabricator.wikimedia.org/T86914#979407 (10Gilles) 3NEW a:3Gilles [13:50:57] 3MediaWiki-extensions-Extensions-requests, Multimedia: Implement delinker functionality as a MediaWiki extension - https://phabricator.wikimedia.org/T86483#979433 (10Fae) Steinsplitter, why not go ahead. We all rely on Magnus' best judgement anyway. //Tangent//: It is interesting seeing varied points of view ab... [14:15:36] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Pass extra GET parameter for Media Viewer preload requests - https://phabricator.wikimedia.org/T86914#979482 (10Gilles) a:5Gilles>3None [14:37:52] 3MediaWiki-extensions-Extensions-requests, Multimedia: Implement delinker functionality as a MediaWiki extension - https://phabricator.wikimedia.org/T86483#979517 (10Steinsplitter) >>! In T86483#979433, @Fae wrote: > Steinsplitter, why not go ahead. We all rely on Magnus' best judgement anyway. Agree :). Added... [15:14:00] (03CR) 10MarkTraceur: "Patch on the way" (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/184739 (https://phabricator.wikimedia.org/T86679) (owner: 10MarkTraceur) [15:14:08] (03PS4) 10MarkTraceur: Move updateFileCounts to the step controllers [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/184739 (https://phabricator.wikimedia.org/T86679) [15:33:54] ARGH [15:34:13] I forgot that mw.UploadWizardUpload objects still expect a wizard object to be passed in [15:34:17] So I guess I have to kill that first [15:34:40] But first, work on other stuff. I think there's something in code review... [15:52:02] (03PS3) 10MarkTraceur: Move DeedPreview to the deed step controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/183654 (https://phabricator.wikimedia.org/T86227) [15:53:58] gi11es: Well, I just tried uploading with more files than our screenshot on the bug tried, and no repro [15:54:15] Wait...it's not a number of files, it's a size total [15:54:17] Derp [15:57:44] yeah total size is what triggers the thumbnail-on-click [15:57:49] but it works fine for me locally [15:59:12] I'm trying on Commons [15:59:21] It's what, 10MB for the cutoff? [15:59:27] I got show thumbnail links [15:59:46] If you don't click them before the uploads finish, you don't get a thumbnail for the entire process, which is annoying, but not a bug [16:00:01] Or a usability bug at worst [16:09:11] 3Multimedia, MediaWiki-File-management: More prominent display of other format available for download in image description pages - https://phabricator.wikimedia.org/T64305#979651 (10RuchirangaW) >>! In T64305#968851, @Tgr wrote: >>>! In T64305#968414, @RuchirangaW wrote: >> @Tgr >> I did not quite understand wha... [16:13:19] 3Multimedia, MediaWiki-extensions-UploadWizard: Flickr upload button broke the regular 'Select Files' button at the Commons upload wizard - https://phabricator.wikimedia.org/T86680#979658 (10MarkTraceur) OSeveno, can you load https://commons.wikimedia.org/wiki/Special:UploadWizard?debug=true and try that again?... [16:14:14] 3Multimedia, MediaWiki-extensions-UploadWizard: Flickr upload button broke the regular 'Select Files' button at the Commons upload wizard - https://phabricator.wikimedia.org/T86680#979660 (10MarkTraceur) Oh, wait - that issue was probably related to the HotCat debacle yesterday...so you might not be able to repr... [17:17:00] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard: Mwe-upwiz-details-error-count appears to be not parsed - https://phabricator.wikimedia.org/T66944#979797 (10Krenair) [17:18:03] Oh my god this is a mess. [20:00:18] tgr: How long do we cache CMD responses? Deskana is asking in -mobile. [20:13:17] marktraceur: answered there [20:13:50] marktraceur: T86680 seems like an eventlogging issue; mind if I deassign you and move it over? [20:14:07] Sure! [20:14:31] I thought it was an issue with HotCat like yesterday [20:15:06] no, Rillke is right about it being adblock-related [20:15:42] KK [20:15:46] EventLogging started to use navigator.sendBeacon recently and apparently that can throw an exception sometimes [20:33:51] (03PS1) 10MarkTraceur: Move duplicate error handling to the wizard class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/185237 [20:33:57] Oh, that's gonna fail. [20:34:43] (03CR) 10jenkins-bot: [V: 04-1] Move duplicate error handling to the wizard class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/185237 (owner: 10MarkTraceur) [20:34:51] 3Wikipedia-App-Android-App, MediaWiki-extensions-CommonsMetadata, Multimedia: Images in the image viewer in the Android app shouldn't display out of date descriptions - https://phabricator.wikimedia.org/T86955#980199 (10Tgr) [20:46:52] 3Wikipedia-App-Android-App, MediaWiki-extensions-CommonsMetadata, Multimedia: Images in the image viewer in the Android app shouldn't display out of date descriptions - https://phabricator.wikimedia.org/T86955#980246 (10Tgr) I discussed this with Aaron a while ago and he recommended using the shared memcached po... [20:59:08] (03PS2) 10MarkTraceur: Move duplicate error handling to the wizard class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/185237 [20:59:52] (03CR) 10MarkTraceur: "For the record, this will look much nicer when it's in the step controller instead of the Wizard class." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/185237 (owner: 10MarkTraceur) [22:06:10] marktraceur, u here? [22:06:26] Yup! What's up? [22:06:59] images via uploadwizaed/flickr were auto-licenced....but not from today? [22:07:27] i uplaoded an image using the upwz/f and it was not licenced [22:07:34] Hm. [22:07:40] Maybe the change from...thedj? [22:07:47] I can't remember, but let me check. [22:07:50] comets: Which image? [22:07:58] http://commons.wikimedia.org/wiki/File:Ricardo_Lagos_meets_with_Hugo_Swire_January_2015.jpg [22:08:24] uploaded via upwiz/flickr [22:08:44] Looks licensed to me? Oh, you did it manually probably [22:09:07] flickr reviewed i.e [22:09:15] No, it's CC-BY 2.0 [22:09:20] comets: Yeah, that was added recently [22:09:40] uhm why? [22:09:59] only trusted users and admins have access to upwiz/flickr [22:10:55] commons.wikimedia.org/wiki/File:Pakistani_Prime_Minister_Sharif_Shakes_Hands_With_Secretary_Kerry_Before_Bilateral_Meeting_in_Islamabad.jpg < uplaoded that a few days ago, it came licenced ("by the UploadWizard Extension") [22:11:11] http://commons.wikimedia.org/wiki/File:Pakistani_Prime_Minister_Sharif_Shakes_Hands_With_Secretary_Kerry_Before_Bilateral_Meeting_in_Islamabad.jpg [22:12:23] comets: https://gerrit.wikimedia.org/r/158887 [22:12:26] if it won't upload licenced and verified, i'm better off using flickr2commons then..does the same thing.. [22:12:55] Probably. [22:13:04] At least for now. [22:13:44] thedj, only licvence reviwers and admisn have access to that tool, no one ELSE..there was no need to do this .. [22:14:01] We can revert it. [22:14:14] I want thedj to chime in first, but I'm happy to do that. [22:15:21] 3Wikipedia-App-Android-App, MediaWiki-extensions-CommonsMetadata, Multimedia: Images in the image viewer in the Android app shouldn't display out of date descriptions - https://phabricator.wikimedia.org/T86955#980655 (10Tgr) > Actual: The image's description is cached for 12 hours Uh, seems like it's actually c... [22:15:22] just creates more hassle for licence reviewers now .. [22:18:53] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Pass extra GET parameter for Media Viewer preload requests - https://phabricator.wikimedia.org/T86914#980661 (10Tgr) Isn't that what `$wgMediaViewerImageQueryParameter` is for? [22:22:53] 3Wikipedia-App-Android-App, MediaWiki-extensions-CommonsMetadata, Multimedia: Images in the image viewer in the Android app shouldn't display out of date descriptions - https://phabricator.wikimedia.org/T86955#980669 (10Deskana) >>! In T86955#980655, @Tgr wrote: >> Actual: The image's description is cached for 1... [22:25:10] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Pass extra GET parameter for Media Viewer preload requests - https://phabricator.wikimedia.org/T86914#980681 (10Tgr) I.e., is this any different from T77882? [22:27:24] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Hackathon: add marker parameter to mediaviewer's image requests - https://phabricator.wikimedia.org/T77882#980693 (10Tgr) [22:27:26] 3Analytics, Multimedia: Per-file view stats - https://phabricator.wikimedia.org/T77541#980692 (10Tgr) [22:27:27] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Hackathon: track how long people are looking at a given image - https://phabricator.wikimedia.org/T77881#980695 (10Tgr) [22:27:28] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Hackathon: track image "unviews" - https://phabricator.wikimedia.org/T77878#980694 (10Tgr) [22:27:34] 3Analytics, Multimedia: Per-file view stats - https://phabricator.wikimedia.org/T77541#829103 (10Tgr) [22:32:41] 3Wikipedia-App-Android-App, MediaWiki-extensions-CommonsMetadata, Multimedia: Images in the image viewer in the Android app shouldn't display out of date descriptions - https://phabricator.wikimedia.org/T86955#980731 (10Tgr) For Wikimedia wikis, the patch above should make all updates immediate. Is this an urgen... [23:26:47] (03PS1) 10Gergő Tisza: Show page view / image view comparison [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/185336 (https://phabricator.wikimedia.org/T78189) [23:47:45] (03PS14) 10Gergő Tisza: Use promises for getting image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 (https://phabricator.wikimedia.org/T51988) (owner: 10MarkTraceur)