[00:23:26] 3MediaWiki-extensions-UploadWizard, Multimedia: "|" in Flickr description truncates it - https://phabricator.wikimedia.org/T78336#983379 (10Tgr) Reverted, backported. People put stuff like `{{w|foo}}` in descriptions, and that should continue to work. Seems hard to do without doing some lightweight wikitext pars... [00:25:07] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard Flickr (tracking) - https://phabricator.wikimedia.org/T45450#983398 (10Tgr) [00:36:57] 3MediaWiki-extensions-UploadWizard, Multimedia: "|" in Flickr description truncates it - https://phabricator.wikimedia.org/T78336#983414 (10Ricordisamoa) Escaping `|` as `{{!}}` (like @MarkTraceur [[ //commons.wikimedia.org/wiki/?diff=142317021 | did ]]) should do the job, since the latter is a core parser funct... [00:48:50] 3MediaWiki-extensions-UploadWizard, Multimedia: "|" in Flickr description truncates it - https://phabricator.wikimedia.org/T78336#983424 (10Tgr) >>! In T78336#983414, @Ricordisamoa wrote: > Escaping `|` as `{{!}}` (like @MarkTraceur [[ //commons.wikimedia.org/wiki/?diff=142317021 | did ]]) should do the job, sin... [01:48:13] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard: File name is not allowed - https://phabricator.wikimedia.org/T87062#983533 (10Tgr) Thanks for the details! [01:55:38] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard: File name is not allowed - https://phabricator.wikimedia.org/T87062#983545 (10Tgr) Is this really a bug? Uploads failing due to title blacklist issues after one has went through the effort to fill out the description is a weird thing and seems to be r... [01:56:38] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard: File name is not allowed - https://phabricator.wikimedia.org/T87062#983547 (10Tgr) Eh, stupid question. I still had the old upload form in mind. In UW you can't rename the file until the description step... [02:04:32] 3MediaWiki-extensions-GWToolset, Multimedia: GWT seems to be currently broken - https://phabricator.wikimedia.org/T87040#983562 (10Tgr) ``` tgr@terbium:/usr/local/apache/common/php-1.25wmf14$ mwscript showJobs.php --wiki=commonswiki --group | grep -i gwt gwtoolsetUploadMetadataJob: 1 queued; 0 claimed (0 active,... [02:51:01] (03PS1) 10Gergő Tisza: Fix date field name [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/185600 (https://phabricator.wikimedia.org/T78189) [02:53:01] (03PS2) 10Gergő Tisza: Fix date field name [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/185600 (https://phabricator.wikimedia.org/T78189) [04:41:30] 3MediaWiki-extensions-Extensions-requests, Multimedia: Implement delinker functionality as a MediaWiki extension - https://phabricator.wikimedia.org/T86483#983603 (10Glaisher) @Magnus Is it possible to extend the functionality for local (non-Commons) files? [07:14:59] unicodesnowman: are you sure? we can find less boring tasks :) [07:15:25] tgr, I'm interested in doing less boring tasks as well, but I've never backported something so I'd like to try that too :) [07:17:29] assigned [07:22:42] tgr, thanks. what about this as possibly another GCI task? https://phabricator.wikimedia.org/T77752 [07:23:58] I'm not convinced we want to do that [07:24:23] there are better ways of excluding images [07:25:09] I guess,that could catch tiny thumbnails too [07:25:38] have you tried writing browser tests? [07:25:47] or vagrant roles? [07:27:35] no; they sound interesting [07:31:33] https://phabricator.wikimedia.org/T77726 might also be interesting although it's a bit open-ended and probably larger than the average GCI task [07:34:22] Use the Guided Tour software to implement [07:35:18] https://phabricator.wikimedia.org/T77373 is a browser test task that should be relatively straightforward [07:35:40] alternatively, marktraceur can probably suggest missing tests for UploadWizard [07:36:05] nvm, that one has a patch already [07:36:50] https://phabricator.wikimedia.org/T77851 might be interesting [07:37:03] although you did an EventLogging task already, right? [07:37:07] hm, I'm interested in the guided tour one. I'm happy to do larger tasks actually [07:37:12] yeah [07:38:38] well, I'll make tasks for browser testing, vagrant/puppet and GuidedTour, and you can take your pick :) [07:39:11] I'm just not so sure how to handle the "Only show the Guided Tour the first time they see the new version" part.. store a flag per-user somehow? [07:39:14] great, thank you :) [07:40:34] well, there isn't going to be a new version for a long time so that point is moot [07:40:49] but you would store a cookie or localStorage flag [07:41:32] we usually use localStorage in MediaViewer [07:42:05] cookies are added to every request the browser sends to the server so they generate network overhead [07:43:24] ah. could be slightly annoying for users who use it on multiple devices, but I guess a per-user store won't be worth the effort and overhead [07:44:13] it's not that much effort, but you can't do that for anonymous users [07:44:35] if you mean "user" in the MediaWiki sense [07:45:35] besides, cross-wiki user flags are not supported at the moment, so it wouldn't be that much confusing [07:46:42] the main source of confusion is that users cross over to Commons when looking at images, and suddenly the settings are different [07:46:42] true [07:47:25] but all wikis have separate DBs and browsers are really strict about cross-domain settings so there is no easy solution for that [07:47:52] e.g. if you want to disable MediaViewer, you have to do it for every wiki you use [07:48:13] not a great user experience, but that's how it is [07:48:22] yeah. I forgot that part about individual wikis basically being its own instance, except for global logins [07:58:37] 3MediaWiki-extensions-Score, Multimedia, MediaWiki-Vagrant: Create vagrant role for Score extension - https://phabricator.wikimedia.org/T87089#983705 (10Tgr) 3NEW [08:00:05] are you using vagrant already? [08:04:08] no, I've never dealt with it before [08:05:55] I'm actually a little bit stuck on the backporting one, I'm not sure where this part https://gerrit.wikimedia.org/r/#/c/165476/1/DataCollector.php is in REL1_23 [08:07:09] 3MediaWiki-extensions-Score, Multimedia, MediaWiki-Vagrant: Create vagrant role for Score extension - https://phabricator.wikimedia.org/T87089#983715 (10Tgr) GCI task: https://www.google-melange.com/gci/task/view/google/gci2014/5785132589907968 [08:09:08] you were missing out then, it makes many things much easier [08:09:29] you definitely don't want to work on browser tests without it, for example [08:14:15] heh, looks like it. I'm pretty much in the dark ages with this sort of stuff [08:14:37] eh crap [08:14:51] I should have read that bug report carefully [08:15:04] he says "beyond REL1_23" [08:15:12] so is actually using a later version [08:16:01] well, um [08:16:15] you can backport to 1.24 then [08:17:01] that's not something we normally do, since 1.23 is a long-term support release and the ones after are normal releases and those only get security fixes [08:18:05] but you will see how backporting works just as well [08:18:49] I'm happy to unclaim the task if it won't be very useful / conventional? [08:19:05] ooh, diffusion links actually work in phabricator now [08:21:00] well 1.24 is the current stable version of MediaWiki, so I guess it's useful after all [08:21:37] whether it's useful to Kghbln who reported the bug, I don't know [08:22:01] it's not clear whether he uses REL1_24 or just some random revision [08:27:14] yeah, I was wrong, REL1_24 should clearly be supported per https://www.mediawiki.org/wiki/Version_lifecycle [08:27:21] (03PS1) 10Unicodesnowman: Fix PHP notices complaining about missing array indices [extensions/CommonsMetadata] (REL1_24) - 10https://gerrit.wikimedia.org/r/185620 (https://bugzilla.wikimedia.org/71793) [08:27:52] ah, okay. just didn't want to break convention if it's not something that's normally done [08:36:14] it's not normally done in the "too much work" sense [08:36:40] I would still +2 changesets if someone else did it :) [08:37:10] anyway, I can't count til 25 and did not realize 1.24 is the current stable branch [08:37:50] backporting bugfixes there is something that should be done normally, although in practices it does not happen much :( [08:38:15] for multimedia extensions anyway [08:38:40] it's hard to keep track of what should go where [08:40:13] so the secret easy way to do this is to open the original changeset, click "cherry-pick to", type the branch name, and you are done [08:40:28] ...which should probably be documented better [08:40:42] although that would have been really boring :) [08:40:56] wow.. that's super easy. and yeah, I like my command line :P [08:41:24] did you run the tests? [08:41:51] IIRC the automation doesn't work with old branches [08:42:52] it doesn't? I ran the tests fine I think, 1 skipped [08:43:20] oh do you mean jenkins tests not working with old branches [08:44:42] yes [08:44:49] the phpunit tests ran fine for me [08:45:09] it mismatches extension and core version, I think [08:45:34] re backporting.. at least security patches are backported (I hope!) [08:45:42] (03CR) 10Gergő Tisza: [C: 032] "Thanks for the backport!" [extensions/CommonsMetadata] (REL1_24) - 10https://gerrit.wikimedia.org/r/185620 (https://bugzilla.wikimedia.org/71793) (owner: 10Unicodesnowman) [08:45:55] (03Merged) 10jenkins-bot: Fix PHP notices complaining about missing array indices [extensions/CommonsMetadata] (REL1_24) - 10https://gerrit.wikimedia.org/r/185620 (https://bugzilla.wikimedia.org/71793) (owner: 10Unicodesnowman) [08:48:05] 3MediaWiki-extensions-CommonsMetadata, Multimedia: PHP Notice: Undefined index: DataCollector.php on line 128 - https://phabricator.wikimedia.org/T86032#983726 (10Tgr) 5Open>3Resolved a:3Tgr The fix has been [[ https://gerrit.wikimedia.org/r/185620 | backported ]] to 1.24. [08:48:29] 3MediaWiki-extensions-CommonsMetadata, Multimedia: PHP Notice: Undefined index: DataCollector.php on line 128 - https://phabricator.wikimedia.org/T86032#983729 (10Tgr) a:5Tgr>3Unicodesnowman [08:48:34] it's neat how extension release schedules are sync'd to mediawiki releases [08:49:19] pretty much the only sane way to maintain compatibility [08:49:50] when a core API changes, you update extensions real-time, and then matching versions are guaranteed to work together [08:53:53] yeah. I've done some pywikibot coding, and it's full of switches for MW versions, not to mention switches for python 2 and python 3 [08:54:58] then again, that's an end-user tool, not an extension [08:59:57] 3MediaWiki-extensions-MultimediaViewer, Multimedia, MediaWiki-extensions-GuidedTour: Create a Guided Tour for Media Viewer - https://phabricator.wikimedia.org/T77726#983735 (10Tgr) GCI task: https://www.google-melange.com/gci/task/view/google/gci2014/5303627765776384 [09:02:56] thank you for mentoring and setting up tasks by the way :) [09:06:49] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Create an E2E test for the metadata panel in MediaViewer - https://phabricator.wikimedia.org/T87090#983748 (10Tgr) 3NEW [09:14:52] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Create an E2E test for the metadata panel in MediaViewer - https://phabricator.wikimedia.org/T87090#983757 (10Tgr) GCI task: https://www.google-melange.com/gci/task/view/google/gci2014/5887572190429184 [09:16:27] now to find an org admin who is awake [09:28:30] 3MediaWiki-extensions-CommonsMetadata, Multimedia: PHP Notice: Undefined index: DataCollector.php on line 128 - https://phabricator.wikimedia.org/T86032#983766 (10Kghbln) Great, thank you for dealing with this. What about REL1_23? [09:34:18] 3MediaWiki-extensions-CommonsMetadata, Multimedia: PHP Notice: Undefined index: DataCollector.php on line 128 - https://phabricator.wikimedia.org/T86032#983767 (10Unicodesnowman) The code that causes this notice doesn't exist in //REL1_23//. I think your version is beyond REL1_24? [09:42:07] unicodesnowman: the tasks are uo [09:42:11] *up* [09:45:49] 3MediaWiki-extensions-CommonsMetadata, Multimedia: PHP Notice: Undefined index: DataCollector.php on line 128 - https://phabricator.wikimedia.org/T86032#983775 (10Kghbln) No, just a little beyond REL1_23 (see the exact version in my original post). However if the code is not there it cannot be fixed. :) I shoul... [12:20:56] 3MediaWiki-extensions-PdfHandler, Multimedia: "Error generating thumbnail" for a specific PDF file (gs OOM'ing?) - https://phabricator.wikimedia.org/T61668#983841 (10infinite-dao) The problem is, that the PDF is probably not correct and the GhosScript puts out some messages ``` wget "https://upload.wikimedia.org... [12:28:44] 3MediaWiki-extensions-Extensions-requests, Multimedia: Implement delinker functionality as a MediaWiki extension - https://phabricator.wikimedia.org/T86483#983844 (10Multichill) Delinked myself from the tools account. Good luck. [12:57:30] 3MediaWiki-File-management, Multimedia: Include at least some EXIF metadata in resized pictures - https://phabricator.wikimedia.org/T20871#983862 (10Hasenlaeufer) [13:19:59] 3MediaWiki-File-management, Multimedia: Include at least some EXIF metadata in resized pictures - https://phabricator.wikimedia.org/T20871#983927 (10Hasenlaeufer) My first action here at Phabricator was to update the URL at task description to the archive location. No I read "Hasenlaeufer set Security to none."... [13:36:27] 3MediaWiki-File-management, Multimedia: Include at least some EXIF metadata in resized pictures - https://phabricator.wikimedia.org/T20871#983934 (10Ciencia_Al_Poder) @Hasenlaeufer Nothing wrong. That change is done automatically for tasks that were imported from bugzilla, if nobody else edited them after the mi... [15:32:47] 3MediaWiki-File-management, Multimedia: More prominent display of other format available for download in image description pages - https://phabricator.wikimedia.org/T64305#983976 (10Bawolff) If you look in the media handler class you will notice a mustRender method. That controls if the file is always converted... [16:26:45] 3MediaWiki-extensions-Extensions-requests, Multimedia: Implement delinker functionality as a MediaWiki extension - https://phabricator.wikimedia.org/T86483#983991 (10Ahonc) I suggest that also need option when there is temporary deletion of image (for example for history merging or splitting). In such case Delin... [16:34:59] 3MediaWiki-extensions-Extensions-requests, Multimedia: Implement delinker functionality as a MediaWiki extension - https://phabricator.wikimedia.org/T86483#984003 (10Steinsplitter) >>! In T86483#983991, @Ahonc wrote: > I suggest that also need option when there is temporary deletion of image (for example for his... [17:03:40] 3MediaWiki-extensions-Extensions-requests, Multimedia: Implement delinker functionality as a MediaWiki extension - https://phabricator.wikimedia.org/T86483#984008 (10Alan) **Bug** :-( https://he.wikipedia.org/wiki/%D7%A9%D7%99%D7%97%D7%AA_%D7%9E%D7%A9%D7%AA%D7%9E%D7%A9:CommonsDelinquent //Hi, edits made by thi... [17:47:25] 3MediaWiki-extensions-GWToolset, Multimedia: GWT seems to be currently broken - https://phabricator.wikimedia.org/T87040#984019 (10Tgr) ``` tgr@tin:~$ redis-cli -a $REDISPWD -h rdb1003 hget commonswiki:jobqueue:gwtoolsetUploadMetadataJob:h-data `redis-cli -a $REDISPWD -h rdb1003 lrange commonswiki:jobqueue:gwtoo... [17:55:11] 3MediaWiki-extensions-GWToolset, Multimedia: White list request: www.doria.fi by National Library of Finland - https://phabricator.wikimedia.org/T87104#984022 (10Artturimatias) 3NEW [20:12:42] 3MediaWiki-extensions-Extensions-requests, Multimedia: Re-implement functionality of old CommonsDelinker bot - https://phabricator.wikimedia.org/T86483#984120 (10Magnus) Increased delay time to 4 min after deletion, and fixed the he.wp bug (I think).