[07:16:01] 3MediaWiki-extensions-GWToolset, Multimedia: GWT seems to be currently broken - https://phabricator.wikimedia.org/T87040#986394 (10dan-nl) @Tgr, is the constant PHP_SAPI defined in production? when a job is run by the job runner, is that constant set to 'cli'? line 441 and 565 of GWToolset/includes/Handlers/Fo... [07:41:53] 3MediaWiki-extensions-GWToolset, Multimedia: GWT seems to be currently broken - https://phabricator.wikimedia.org/T87040#986401 (10Tgr) ``` tgr@terbium:~$ cd /usr/local/apache/common/php-1.25wmf14 tgr@terbium:/usr/local/apache/common/php-1.25wmf14$ mwscript eval.php commonswiki > echo PHP_SAPI; cli ``` Not sure... [07:43:37] (03PS1) 10Phoenix303: Removed the second scrollbar appeared while loading images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185963 (https://phabricator.wikimedia.org/T77889) [13:35:41] 3MediaWiki-extensions-TimedMediaHandler, Multimedia: No way to get to file page of audio file from a gallery - https://phabricator.wikimedia.org/T87056#986639 (10Josve05a) p:5High>3Unbreak! [15:35:32] 3Multimedia: TIFF thumbnailing fails and page count is wrong - https://phabricator.wikimedia.org/T87236#986670 (10Lokal_Profil) 3NEW [15:38:39] 3Multimedia: TIFF thumbnailing fails and page count is wrong - https://phabricator.wikimedia.org/T87236#986678 (10Bawolff) We have a bug with tiff files that have 16 bit colour channels when > 50 mp which sounds likexwhat you describe [15:40:00] 3MediaWiki-extensions-GWToolset, Multimedia: "HTTP request timed out" for large files - https://phabricator.wikimedia.org/T86024#986679 (10Lokal_Profil) I have started uploading these files manually (well using python). The underlying problem in GWToolset still remains though. [16:28:54] 3Multimedia: TIFF thumbnailing fails and page count is wrong - https://phabricator.wikimedia.org/T87236#986708 (10Lokal_Profil) Ah, thanks. Is this the same as T54045 or is there another ticket? Will create thumbnails manually then and tag with {{LargeTIFF}}. [16:32:11] 3Multimedia: TIFF thumbnailing fails and page count is wrong - https://phabricator.wikimedia.org/T87236#986710 (10Bawolff) Its the same as T54045#546265 (Arguably though, that comment should be broken out into a separate bug). btw, to tell if its that bug, or something else, on the exif section of the image pag... [16:34:59] 3Multimedia: TIFF thumbnailing fails and page count is wrong - https://phabricator.wikimedia.org/T87236#986714 (10Lokal_Profil) Thanks for the tip. Is the two-page issue also created by the same bug? [16:37:47] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Pass extra GET parameter for Media Viewer preload requests - https://phabricator.wikimedia.org/T86914#986718 (10ezachte) The url's are already different in most cases, as different contexts will usually use different image sizes. In https://en.wikipedia.org/wi... [16:38:19] 3Multimedia: TIFF thumbnailing fails and page count is wrong - https://phabricator.wikimedia.org/T87236#986720 (10Lokal_Profil) Btw. I assume simply running convert x.tif y.png should give me something which should thumbnail correctly, or will there be a similar issue with the png? [16:40:49] 3Multimedia: TIFF thumbnailing fails and page count is wrong - https://phabricator.wikimedia.org/T87236#986730 (10Bawolff) >>! In T87236#986714, @Lokal_Profil wrote: > Thanks for the tip. Is the two-page issue also created by the same bug? I'm not sure what the cause of the two page thing is, but its unrelated.... [17:32:18] Huh, the more I look at this, the more I think the thumbnail callback doesn't get a list of anything [17:36:16] 3Wikimedia-Site-requests, Multimedia: White list request: www.doria.fi by National Library of Finland - https://phabricator.wikimedia.org/T87104#986808 (10Glaisher) [17:47:21] 3MediaWiki-extensions-GWToolset, Multimedia: GWT seems to be currently broken - https://phabricator.wikimedia.org/T87040#986827 (10Krenair) Well, assuming it's this straight forward: ```krenair@mw1001:~$ php -a Welcome to HipHop Debugger! Type "help" or "?" for a complete list of commands. Note: no server speci... [17:56:28] Krinkle|detached: It's OK to pass deferred.reject as a callback to another function without proxying, right? [17:56:34] There's some relevant magic, I think [18:10:15] (03CR) 10MarkTraceur: "Testing locally, will upload soon" (0316 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 (https://phabricator.wikimedia.org/T51988) (owner: 10MarkTraceur) [18:22:45] 3MediaWiki-extensions-TimedMediaHandler, Multimedia: No way to get to file page of audio file from a gallery - https://phabricator.wikimedia.org/T87056#986886 (10Aklapper) CC'ing patch author of https://gerrit.wikimedia.org/r/#/c/181810/ (just in case it's related). Similar/related tasks: {T43762}, {T33583}. N... [18:50:33] marktraceur: Yes. [18:50:44] marktraceur: No magic, they;re just not instance methods but object properties. [18:50:54] detachable [18:51:02] the same way a regular value can be detached from any object. [18:53:54] K [18:53:56] tgr: ^^ [19:34:21] (03CR) 10Krinkle: [C: 04-1] Use promises for getting image info (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 (https://phabricator.wikimedia.org/T51988) (owner: 10MarkTraceur) [19:36:11] (03CR) 10Krinkle: Use promises for getting image info (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 (https://phabricator.wikimedia.org/T51988) (owner: 10MarkTraceur) [19:36:21] Thanks for looking Krinkle [20:05:03] (03CR) 10Krinkle: Use promises for getting image info (034 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 (https://phabricator.wikimedia.org/T51988) (owner: 10MarkTraceur) [21:02:44] marktraceur: the point is that whether a function references 'this' or not is an implementation detail and not part of the jQuery API contract, so it's safer in the long term to not make any assumptions [21:03:00] I'm not questioning that it works right now [21:07:13] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Pass extra GET parameter for Media Viewer preload requests - https://phabricator.wikimedia.org/T86914#987432 (10Tgr) Which is why I did not object to using query parameters to differentiate between MediaViewer, file page, thumbnails etc. But preloading and non-... [21:13:02] tgr: Not sure if Krinkle can answer that [21:21:03] 3MediaWiki-extensions-TimedMediaHandler, Multimedia: No way to get to file page of audio file from a gallery - https://phabricator.wikimedia.org/T87056#987450 (10Tgr) p:5Unbreak!>3High So far it does not seem this was broken - it is probably simply how TMH works. So if it was not a huge problem in the last t... [21:26:42] 3MediaWiki-extensions-TimedMediaHandler, Multimedia: No way to get to file page of audio file from a gallery - https://phabricator.wikimedia.org/T87056#987465 (10Tgr) [21:49:15] (03PS1) 10Gergő Tisza: Take sampling into account for NavigationTiming [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/186089 (https://phabricator.wikimedia.org/T78189) [21:49:18] (03CR) 10jenkins-bot: [V: 04-1] Take sampling into account for NavigationTiming [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/186089 (https://phabricator.wikimedia.org/T78189) (owner: 10Gergő Tisza) [21:49:45] (03PS2) 10Gergő Tisza: Take sampling into account for NavigationTiming [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/186089 (https://phabricator.wikimedia.org/T78189) [21:53:11] (03PS1) 10Gergő Tisza: Script to clean up the generated files [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/186090 [21:58:12] 3Librarization, Multimedia, MediaWiki-Uploading: Make SVG sanitization into a library - https://phabricator.wikimedia.org/T86874#987544 (10Aklapper) [22:00:18] 3Librarization, Multimedia, MediaWiki-Uploading: Make SVG sanitization into a library - https://phabricator.wikimedia.org/T86874#987548 (10Aklapper) > This could be a good gsoc project. Anybody willing to (co-)mentor? Please go ahead and add it to [[ https://www.mediawiki.org/wiki/Google_Summer_of_Code_2015#Fea... [22:23:20] tgr: Which method? [22:23:23] (regarding 'this') [22:24:15] Using 'this' in a method is not an anti-pattern in general. There's many very good and valid uses of it. However there are most certainly cases where it should not be used. It's not a case of 'this' overal being good and bad. SOmetimes it's required and good, sometimes it's possible but bad. [22:24:39] 3MediaWiki-Core-Team, Multimedia: SHA-1 file name support - https://phabricator.wikimedia.org/T1210#987628 (10aaron) 5Open>3stalled [22:43:54] Krinkle: I am just saying I would generally prefer $.on('foo', $.proxy(deferred, 'reject')) over $.on('foo', deferred.reject) since the first is guaranteed to work and the second depends on how jQuery.Deferred is implemented and that might change in the long term [22:44:42] cf. console.log for which Chrome broke direct referencing at some point [22:56:10] (03PS15) 10MarkTraceur: Use promises for getting image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 (https://phabricator.wikimedia.org/T51988) [23:10:27] Rrg, can't repro, gi11es is probably still on a plane or something [23:10:50] In two hours I'm sure we'll discover he can't repro either for some reason [23:11:54] (03CR) 10MarkTraceur: "I can't repro, would you mind checking for JS errors in your console and repeating the exact steps you took?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/184739 (https://phabricator.wikimedia.org/T86679) (owner: 10MarkTraceur) [23:13:44] tgr: There is no need to gurantee anything. It has a built-in gurantee of the very reason not to have to wrap it. Wrapping it is just over-engineering for no reason that adds confusion suggesting it needs it. [23:14:00] console is a class with methods. Binding to instances is always required in that kind of scenario. [23:14:06] But not for plain objects. [23:14:42] For many patterns it's useful to do things consistently. But there this is taking it too far. There's a line after which it's confusing to do so.