[00:07:10] (03PS3) 10MarkTraceur: Move duplicate error handling to the wizard class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/185237 [01:56:17] (03CR) 10Gergő Tisza: "Thanks for the patch!" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185963 (https://phabricator.wikimedia.org/T77889) (owner: 10Phoenix303) [01:58:45] 3MediaWiki-extensions-MultimediaViewer, Multimedia: A second scroll bar appears when loading images - https://phabricator.wikimedia.org/T77889#988160 (10Tgr) The patch suppresses the scrollbar (thanks Phoenix303!), but it was just the symptom of some deeper breakage - the image visibly changes dimensions when it... [01:59:21] (03CR) 10Gergő Tisza: [C: 032] Removed the second scrollbar appeared while loading images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185963 (https://phabricator.wikimedia.org/T77889) (owner: 10Phoenix303) [02:00:32] (03Merged) 10jenkins-bot: Removed the second scrollbar appeared while loading images [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185963 (https://phabricator.wikimedia.org/T77889) (owner: 10Phoenix303) [02:08:36] 3MediaWiki-extensions-MultimediaViewer, Multimedia: A second scroll bar appears when loading images - https://phabricator.wikimedia.org/T77889#988173 (10Tgr) [02:12:08] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Size of preview and real image does not match in MediaViewer - https://phabricator.wikimedia.org/T87295#988179 (10Tgr) 3NEW [02:12:30] 3MediaWiki-extensions-MultimediaViewer, Multimedia: A second scroll bar appears when loading images - https://phabricator.wikimedia.org/T77889#988190 (10Tgr) >>! In T77889#988160, @Tgr wrote: > The patch suppresses the scrollbar (thanks Phoenix303!), but it was just the symptom of some deeper breakage - the imag... [02:12:47] 3MediaWiki-extensions-MultimediaViewer, Multimedia: A second scroll bar appears when loading images - https://phabricator.wikimedia.org/T77889#988192 (10Tgr) 5Open>3Resolved a:3Tgr [02:12:48] 3MediaWiki-extensions-MultimediaViewer, Multimedia: MediaViewer image/screen sizing problems (tracking) - https://phabricator.wikimedia.org/T78211#988194 (10Tgr) [02:17:20] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Make MediaViewer providers abortable - https://phabricator.wikimedia.org/T86834#988197 (10Tgr) Given the promise caching system we use, this would also mean uncaching the request, and so should only ever be done for promises which have not resolved yet. (Or hav... [05:33:36] 3MediaWiki-extensions-MultimediaViewer, Multimedia: MultimediaViewer does not seem to make any use of an image alternative text - https://phabricator.wikimedia.org/T66518#988407 (10Tgr) [05:33:37] 3MediaWiki-extensions-MultimediaViewer, Multimedia: MediaViewer should preserve ALT attribute of the image - https://phabricator.wikimedia.org/T75923#988408 (10Tgr) [05:37:31] (03PS7) 10Gergő Tisza: Fix overzealous textarea click handler [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178219 [05:37:34] (03CR) 10jenkins-bot: [V: 04-1] Fix overzealous textarea click handler [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178219 (owner: 10Gergő Tisza) [05:43:08] (03PS8) 10Gergő Tisza: Fix overzealous textarea click handler [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178219 [05:44:02] (03CR) 10jenkins-bot: [V: 04-1] Fix overzealous textarea click handler [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178219 (owner: 10Gergő Tisza) [05:49:13] (03PS9) 10Gergő Tisza: Fix overzealous textarea click handler [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178219 [05:49:58] (03CR) 10jenkins-bot: [V: 04-1] Fix overzealous textarea click handler [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178219 (owner: 10Gergő Tisza) [05:57:22] (03CR) 10Gergő Tisza: "I figured out a new method, which seems to work in both Chrome and Firefox: do the delayed select on a focus event, but also add a one-tim" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178219 (owner: 10Gergő Tisza) [06:00:39] (03CR) 10Gergő Tisza: "Plus, it broke a seemingly unrelated test." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178219 (owner: 10Gergő Tisza) [06:06:32] 3Analytics, Wikimedia-General-or-Unknown, Multimedia: Cache multimedia limn JSON datasources - https://phabricator.wikimedia.org/T75611#988472 (10Tgr) [07:29:25] 3MediaWiki-extensions-TimedMediaHandler, Multimedia: Link to file description page is undiscoverable or completely missing - https://phabricator.wikimedia.org/T45747#988559 (10Nemo_bis) [07:40:10] 3MediaWiki-File-management, Multimedia: Making license and author information api accessible - https://phabricator.wikimedia.org/T27624#293536 (10Nemo_bis) [09:13:11] 3Multimedia: TIFF thumbnailing fails and page count is wrong - https://phabricator.wikimedia.org/T87236#988629 (10Lokal_Profil) [09:13:14] 3MediaWiki-extensions-VipsScaler, Multimedia: Use VipsScaler to scale TIFFs - https://phabricator.wikimedia.org/T54045#988630 (10Lokal_Profil) [10:36:20] 3Multimedia, MediaWiki-Uploading: Special:Upload fails to deal with too long filenames - https://phabricator.wikimedia.org/T87313#988670 (10Lokal_Profil) 3NEW [10:44:02] 3MediaWiki-extensions-UploadWizard, Multimedia: Special:UploadWizard gives undescriptive erro message upon too long filename - https://phabricator.wikimedia.org/T87314#988678 (10Lokal_Profil) 3NEW [11:08:18] 3Wikidata, Structured-Multimedia-Data, Multimedia: Create mockup for first-time user experience - https://phabricator.wikimedia.org/T77847#988701 (10adrianheine) [11:10:18] 3Multimedia, MediaWiki-Uploading: Bad-prefix triggered differently in API compared to Upload and UploadWizard - https://phabricator.wikimedia.org/T87315#988702 (10Lokal_Profil) 3NEW [11:16:11] 3Multimedia, MediaWiki-Uploading: Bad-prefix triggered differently in API compared to Upload and UploadWizard - https://phabricator.wikimedia.org/T87315#988711 (10Lokal_Profil) Upon closer inspection shows thhat the testing is implemented completely differently in the three modes: Testing with "P1100961.JPG":... [11:25:41] 3Multimedia, MediaWiki-Uploading: Upload warning "non-descriptive name" too strict - https://phabricator.wikimedia.org/T25806#988717 (10Lokal_Profil) This blacklist is still to strict. The "Scan" prefix for example blocks any filename starting with "Scandinavia" [12:21:30] 3Multimedia: TIFF images acquiring an extra page - https://phabricator.wikimedia.org/T87318#988749 (10Lokal_Profil) 3NEW [12:22:03] 3Multimedia: TIFF thumbnailing fails and page count is wrong - https://phabricator.wikimedia.org/T87236#986670 (10Lokal_Profil) two-page issue broken out T87318 [12:22:34] 3Multimedia: TIFF images acquiring an extra page - https://phabricator.wikimedia.org/T87318#988749 (10Lokal_Profil) [12:22:36] 3MediaWiki-File-management, Multimedia: TIFF handling (tracking) - https://phabricator.wikimedia.org/T64466#988761 (10Lokal_Profil) [14:14:28] (03PS1) 10Gilles: [WIP] Variant logging [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/186158 (https://phabricator.wikimedia.org/T87184) [14:15:35] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Variant logging [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/186158 (https://phabricator.wikimedia.org/T87184) (owner: 10Gilles) [14:18:03] (03PS1) 10Gilles: Collect thumbnail width in the performance log [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/186160 (https://phabricator.wikimedia.org/T86609) [14:18:50] (03CR) 10jenkins-bot: [V: 04-1] Collect thumbnail width in the performance log [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/186160 (https://phabricator.wikimedia.org/T86609) (owner: 10Gilles) [14:21:05] (03CR) 10Gilles: [C: 032] Script to clean up the generated files [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/186090 (owner: 10Gergő Tisza) [14:21:15] (03CR) 10Gilles: [V: 032] Script to clean up the generated files [analytics/multimedia/config] - 10https://gerrit.wikimedia.org/r/186090 (owner: 10Gergő Tisza) [14:22:38] (03CR) 10Gilles: [C: 032] Take sampling into account for NavigationTiming [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/186089 (https://phabricator.wikimedia.org/T78189) (owner: 10Gergő Tisza) [14:22:41] (03Merged) 10jenkins-bot: Take sampling into account for NavigationTiming [analytics/multimedia] - 10https://gerrit.wikimedia.org/r/186089 (https://phabricator.wikimedia.org/T78189) (owner: 10Gergő Tisza) [14:45:57] 3MediaWiki-extensions-GWToolset, Multimedia: GWT seems to be currently broken - https://phabricator.wikimedia.org/T87040#989048 (10dan-nl) @Krenair, thanks for checking it. @Tgr, i'll try and replicate the issue locally as soon as i can get some free time. the main issue i see at the moment is the log entry its... [15:01:08] (03PS2) 10Gilles: Collect thumbnail width in the performance log [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/186160 (https://phabricator.wikimedia.org/T86609) [15:01:59] (03CR) 10jenkins-bot: [V: 04-1] Collect thumbnail width in the performance log [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/186160 (https://phabricator.wikimedia.org/T86609) (owner: 10Gilles) [15:21:46] (03PS3) 10Gilles: Collect thumbnail width in the performance log [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/186160 (https://phabricator.wikimedia.org/T86609) [15:23:27] (03PS2) 10Gilles: [WIP] Variant logging [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/186158 (https://phabricator.wikimedia.org/T87184) [15:24:14] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Variant logging [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/186158 (https://phabricator.wikimedia.org/T87184) (owner: 10Gilles) [15:30:15] (03PS3) 10Gilles: [WIP] Variant logging [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/186158 (https://phabricator.wikimedia.org/T87184) [15:58:26] (03PS4) 10Gilles: [WIP] Variant logging [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/186158 (https://phabricator.wikimedia.org/T87184) [15:59:08] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Variant logging [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/186158 (https://phabricator.wikimedia.org/T87184) (owner: 10Gilles) [16:02:11] (03PS5) 10Gilles: Variant logging [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/186158 (https://phabricator.wikimedia.org/T87184) [16:02:54] (03CR) 10jenkins-bot: [V: 04-1] Variant logging [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/186158 (https://phabricator.wikimedia.org/T87184) (owner: 10Gilles) [16:04:29] (03PS6) 10Gilles: Variant logging [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/186158 (https://phabricator.wikimedia.org/T87184) [16:23:33] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Rephrase message "multimediaviewer-permission-title" - https://phabricator.wikimedia.org/T66804#989133 (10Joyceg) Can I take up this task? [16:29:46] 3MediaWiki-extensions-CommonsMetadata, Multimedia, Wikipedia-App-Android-App: Images in the image viewer in the Android app shouldn't display out of date descriptions - https://phabricator.wikimedia.org/T86955#989149 (10Deskana) [16:31:48] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Rephrase message "multimediaviewer-permission-title" - https://phabricator.wikimedia.org/T66804#989158 (10Deskana) >>! In T66804#989133, @Joyceg wrote: > Can I take up this task? Given that the above patch was merged, I think this may be resolved. @MarkTraceur? [20:39:05] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Size of preview and real image does not match in MediaViewer - https://phabricator.wikimedia.org/T87295#989281 (10Phoenix303) I have looked upon this issue. What i can figure it out is that the metadatapanel "top" property changes. Can you please give me some g... [22:00:33] (03PS1) 10Phoenix303: Match size of preview and real image [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/186212 (https://phabricator.wikimedia.org/T87295) [22:02:17] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Size of preview and real image does not match in MediaViewer - https://phabricator.wikimedia.org/T87295#989324 (10Phoenix303) I have submitted the patch. Please let me know if there is any problem with the patch.