[00:33:44] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Improve reliability of cucumber tests - https://phabricator.wikimedia.org/T87831#1000150 (10Gilles) 3NEW a:3Gilles [00:46:34] (03PS1) 10Gilles: Attempt to improve reliability of cucumber tests [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/187302 (https://phabricator.wikimedia.org/T87831) [00:51:29] 3MediaWiki-extensions-MultimediaViewer, Mobile-Web, Multimedia: Mobile Web and Multimedia viewer should use same hash fragment - https://phabricator.wikimedia.org/T87769#1000201 (10Gilles) p:5Triage>3Normal [00:57:12] (03CR) 10Gilles: [C: 032] Add 'license-name' matching SPDX conventions [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/187266 (owner: 10Ricordisamoa) [00:57:34] (03Merged) 10jenkins-bot: Add 'license-name' matching SPDX conventions [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/187266 (owner: 10Ricordisamoa) [01:41:38] (03PS1) 10Gilles: Fix formdata filename field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187317 (https://phabricator.wikimedia.org/T87538) [01:42:14] 3Multimedia, MediaWiki-extensions-UploadWizard: That file type is forbidden: ogg - https://phabricator.wikimedia.org/T87538#1000282 (10Gilles) a:3Gilles [01:42:20] 3Multimedia, MediaWiki-extensions-UploadWizard: UploadWizard: File name is not allowed - https://phabricator.wikimedia.org/T87062#1000283 (10Gilles) a:3Gilles [04:42:12] tgr: Timing-Allow-Origin: * was indeed deployed on jan 7th [04:50:16] would this extra header result in busted cache on the clients? [04:52:14] having the extra perf data shouldn't influence the amount of image requests tracked, at least I don't see what in our code would do that [04:52:48] the SQL query for the image graphs only looks at event_type and event_total, both of which should be there regardless of the CORS policy [05:07:05] ok, so it's definitely the new header causing this: [05:07:07] SELECT COUNT(*) AS count, SUBSTR(timestamp, 1, 8) AS datestring FROM MultimediaViewerNetworkPerformance_10774577 WHERE event_type = 'image' AND event_country = 'CN' AND event_tcp IS NOT NULL GROUP BY datestring [05:07:35] the entire extra influx of entries is records that have the performance data [05:08:11] on frwiki it's too small to be noticeable, for example [05:10:26] oh, I think I get it [05:10:41] if ( stats.request === 0 ) { [05:10:42] return; [05:10:42] } [05:11:08] without CORS, this was probably happening every time for people who had browsers that were perf-capable [05:11:41] they were getting picked by the sample, the perf entry was found, but it looked like a local cache hit despite not being one, because the lack of CORS policy censored the entry [05:13:06] and maybe browser adoption difference between countries is what reshuffled the distribution of slow/fast hits in our stats [05:14:23] seems like the first potential culprit that answers all the questions, anyway [05:15:19] also the big double-whammy that made this super visible is the thing we found earlier where chinese traffic was way oversampled [05:15:32] it all makes sense now [14:01:47] (03PS1) 10Namit: "View in browser" link limited to the text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/187371 (https://phabricator.wikimedia.org/T87427) [17:40:07] 3MediaWiki-File-management, Multimedia, Beta-Cluster: Thumbnail 404s get cached - https://phabricator.wikimedia.org/T69056#1001060 (10greg) [17:41:48] Ugh, alarm [17:41:51] What have I missed [17:41:54] Oh, nothing. [17:41:56] Super [17:42:00] * marktraceur heads into UW [17:43:18] (03PS1) 10MarkTraceur: Use OOUI checkboxes for metadata copying [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187415 [17:44:14] (03CR) 10Gilles: [C: 032] "View in browser" link limited to the text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/187371 (https://phabricator.wikimedia.org/T87427) (owner: 10Namit) [17:59:12] (03Merged) 10jenkins-bot: "View in browser" link limited to the text [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/187371 (https://phabricator.wikimedia.org/T87427) (owner: 10Namit) [18:11:18] gi11es: Have you been able to run the browser tests on firefox recently? [18:11:34] Trying to figure out if my mediawiki is still borked or if it's a bug [18:19:21] marktraceur: https://phabricator.wikimedia.org/T87446#1001121 [18:22:36] marktraceur: for MMV or for UW? I can take a look... [18:25:16] UW [18:25:28] James_F: That's the one [18:25:31] Shit. [18:25:34] Yeah. [18:36:10] marktraceur: not sure, I think I last ran them in chrome [18:36:12] marktraceur: UW or Media Viewer? [18:36:19] ah, just read the backscroll [18:36:21] gi11es: James_F is right about the bug being the problem [18:36:26] cool [18:38:26] marktraceur: can you review my UW fix for the ogv thing? if it works we'll need to backport it [18:38:47] https://gerrit.wikimedia.org/r/#/c/187317/ [18:39:13] Sure [18:39:50] 3MediaWiki-extensions-MultimediaViewer, Multimedia: "VIew in browser" link in download panel overflows - https://phabricator.wikimedia.org/T87427#1001208 (10Gilles) p:5Triage>3Normal [18:40:06] gi11es: "If it works"? [18:40:19] Like, test it on beta? [18:40:34] sure, and just reviewing the patch to begin with :) [18:40:40] Ah, I see. [18:40:41] you're more familiar with those functions than I am [18:40:46] Yeah, I wrote them. :) [18:41:42] (03CR) 10MarkTraceur: [C: 032] Fix formdata filename field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187317 (https://phabricator.wikimedia.org/T87538) (owner: 10Gilles) [18:47:23] (03Merged) 10jenkins-bot: Fix formdata filename field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187317 (https://phabricator.wikimedia.org/T87538) (owner: 10Gilles) [18:53:34] marktraceur: yeah, test seems to be OK in Firefox but in recent times Selenium driver for Chrome is unhappy about other elements being "on top" in a z-index way. I'll see if I can fix that, might be tricky. [19:21:54] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Record performance log hits regardless of ResourceTiming data contents - https://phabricator.wikimedia.org/T87877#1001364 (10Gilles) 3NEW a:3Gilles [19:23:37] (03PS1) 10Gilles: Record performance log hits regardless of ResourceTiming data contents [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/187451 (https://phabricator.wikimedia.org/T87877) [19:26:53] 3MediaWiki-extensions-MultimediaViewer, Multimedia: "VIew in browser" link in download panel overflows - https://phabricator.wikimedia.org/T87427#1001390 (10Gilles) a:3Namit [19:32:01] 3MediaWiki-extensions-CommonsMetadata, Multimedia: Convert CommonsMetadata to use extension registration - https://phabricator.wikimedia.org/T87900#1001490 (10Legoktm) [19:33:04] 3MediaWiki-extensions-GlobalUsage, Multimedia: Convert GlobalUsage to use extension registration - https://phabricator.wikimedia.org/T87925#1001591 (10Legoktm) [19:33:06] 3Multimedia, MediaWiki-extensions-GWToolset: Convert GWToolset to use extension registration - https://phabricator.wikimedia.org/T87928#1001604 (10Legoktm) [19:33:08] 3MediaWiki-extensions-ImageMap, Multimedia: Convert ImageMap to use extension registration - https://phabricator.wikimedia.org/T87929#1001609 (10Legoktm) [19:33:09] 3MediaWiki-extensions-ImageMetrics, Multimedia: Convert ImageMetrics to use extension registration - https://phabricator.wikimedia.org/T87930#1001614 (10Legoktm) [19:33:53] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Convert MultimediaViewer to use extension registration - https://phabricator.wikimedia.org/T87943#1001667 (10Legoktm) [19:34:12] (03CR) 10Gilles: [C: 04-1] "This seems to affect the file page as well, which doesn't look very nice, considering that the text below is left-aligned: https://www.dro" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/187094 (owner: 10Kaldari) [19:34:16] 3MediaWiki-extensions-PagedTiffHandler, Multimedia: Convert PagedTiffHandler to use extension registration - https://phabricator.wikimedia.org/T87952#1001704 (10Legoktm) [19:34:29] 3MediaWiki-extensions-PdfHandler, Multimedia: Convert PdfHandler to use extension registration - https://phabricator.wikimedia.org/T87957#1001725 (10Legoktm) [19:34:44] 3MediaWiki-extensions-Score, Multimedia: Convert Score to use extension registration - https://phabricator.wikimedia.org/T87970#1001780 (10Legoktm) [19:34:59] 3MediaWiki-extensions-TimedMediaHandler, Multimedia: Convert TimedMediaHandler to use extension registration - https://phabricator.wikimedia.org/T87981#1001825 (10Legoktm) [19:35:10] 3Multimedia, MediaWiki-extensions-UploadWizard: Convert UploadWizard to use extension registration - https://phabricator.wikimedia.org/T87988#1001859 (10Legoktm) [19:35:13] 3MediaWiki-extensions-VipsScaler, Multimedia: Convert VipsScaler to use extension registration - https://phabricator.wikimedia.org/T87991#1001872 (10Legoktm) [19:36:19] marktraceur: did you see that jenkins was unhappy about your parent UW OOUI changeset? [19:37:41] Uh [19:37:59] No, I didn't see that, I'm dealing with too much stuff at the moment [19:38:19] Oh, wait, yes, I did [19:38:22] It seemed bogus [19:38:29] 3Multimedia, MediaWiki-extensions-UploadWizard: Convert UploadWizard to use extension registration - https://phabricator.wikimedia.org/T87988#1001957 (10Legoktm) [19:38:31] 3MediaWiki-extensions-VipsScaler, Multimedia: Convert VipsScaler to use extension registration - https://phabricator.wikimedia.org/T87991#1001954 (10Legoktm) [19:38:46] (03CR) 10MarkTraceur: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187238 (owner: 10MarkTraceur) [19:38:49] 3MediaWiki-extensions-TimedMediaHandler, Multimedia: Convert TimedMediaHandler to use extension registration - https://phabricator.wikimedia.org/T87981#1001964 (10Legoktm) [19:39:30] 3MediaWiki-extensions-Score, Multimedia: Convert Score to use extension registration - https://phabricator.wikimedia.org/T87970#1001975 (10Legoktm) [19:39:46] 3MediaWiki-extensions-PdfHandler, Multimedia: Convert PdfHandler to use extension registration - https://phabricator.wikimedia.org/T87957#1001988 (10Legoktm) [19:39:51] 3MediaWiki-extensions-PagedTiffHandler, Multimedia: Convert PagedTiffHandler to use extension registration - https://phabricator.wikimedia.org/T87952#1001993 (10Legoktm) [19:40:08] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Convert MultimediaViewer to use extension registration - https://phabricator.wikimedia.org/T87943#1002002 (10Legoktm) [19:40:33] 3MediaWiki-extensions-ImageMetrics, Multimedia: Convert ImageMetrics to use extension registration - https://phabricator.wikimedia.org/T87930#1002015 (10Legoktm) [19:40:36] 3Multimedia, MediaWiki-extensions-GWToolset: Convert GWToolset to use extension registration - https://phabricator.wikimedia.org/T87928#1002017 (10Legoktm) [19:40:39] 3MediaWiki-extensions-ImageMap, Multimedia: Convert ImageMap to use extension registration - https://phabricator.wikimedia.org/T87929#1002016 (10Legoktm) [19:40:44] 3MediaWiki-extensions-GlobalUsage, Multimedia: Convert GlobalUsage to use extension registration - https://phabricator.wikimedia.org/T87925#1002020 (10Legoktm) [19:42:32] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Convert MultimediaViewer to use extension registration - https://phabricator.wikimedia.org/T87943#1002071 (10Gilles) a:3Gilles [19:43:15] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Convert MultimediaViewer to use extension registration - https://phabricator.wikimedia.org/T87943#1001667 (10Gilles) p:5Triage>3Normal [19:43:28] 3Multimedia, MediaWiki-extensions-UploadWizard: "|" in Flickr description truncates it - https://phabricator.wikimedia.org/T78336#1002076 (10Gilles) p:5Unbreak!>3Low [19:55:27] gi11es: Works now! https://gerrit.wikimedia.org/r/187238 [19:55:36] qunit was being annoying for some reason [19:56:17] 3Multimedia, MediaWiki-extensions-UploadWizard: Convert UploadWizard to use extension registration - https://phabricator.wikimedia.org/T87988#1001859 (10Gilles) p:5Triage>3Low [19:56:20] 3Multimedia, MediaWiki-extensions-UploadWizard: Convert UploadWizard to use extension registration - https://phabricator.wikimedia.org/T87988#1002134 (10Gilles) a:3Gilles [19:57:01] 3MediaWiki-extensions-MultimediaViewer, Multimedia: Convert MultimediaViewer to use extension registration - https://phabricator.wikimedia.org/T87943#1002138 (10Gilles) p:5Normal>3Low [20:00:04] 3MediaWiki-extensions-CommonsMetadata, Multimedia: Convert CommonsMetadata to use extension registration - https://phabricator.wikimedia.org/T87900#1002151 (10Legoktm) [20:05:02] (03CR) 10Gergő Tisza: [C: 032] "And it probably did not even filter cache hits since those still take a few milliseconds." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/187451 (https://phabricator.wikimedia.org/T87877) (owner: 10Gilles) [20:06:03] (03Merged) 10jenkins-bot: Record performance log hits regardless of ResourceTiming data contents [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/187451 (https://phabricator.wikimedia.org/T87877) (owner: 10Gilles) [20:28:49] (03PS1) 10Gilles: [WIP] Convert to use extension registration [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187471 (https://phabricator.wikimedia.org/T87988) [20:29:20] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Convert to use extension registration [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187471 (https://phabricator.wikimedia.org/T87988) (owner: 10Gilles) [20:30:42] (03CR) 10Gilles: [C: 04-1] "@legoktm i18n doesn't work, and there's a nasty notice coming from ExtensionProcessor.php about something that looks to be the cause." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187471 (https://phabricator.wikimedia.org/T87988) (owner: 10Gilles) [20:33:41] yay bugs! [20:34:09] * legoktm will look after lunch [21:58:31] (03CR) 10Legoktm: "The conversion script doesn't handle namespaces well, I'll look into fixing that." (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187471 (https://phabricator.wikimedia.org/T87988) (owner: 10Gilles) [22:07:30] (03CR) 10Gergő Tisza: [C: 04-1] [WIP] Convert to use extension registration (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187471 (https://phabricator.wikimedia.org/T87988) (owner: 10Gilles) [22:07:45] (03PS1) 10Legoktm: Get rid of $wgUpwizDir and use __DIR__ directly [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187574 [22:10:42] (03CR) 10Legoktm: [WIP] Convert to use extension registration (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187471 (https://phabricator.wikimedia.org/T87988) (owner: 10Gilles) [22:37:51] (03PS2) 10Gilles: [WIP] Convert to use extension registration [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187471 (https://phabricator.wikimedia.org/T87988) [22:38:08] (03CR) 10Gilles: [WIP] Convert to use extension registration (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187471 (https://phabricator.wikimedia.org/T87988) (owner: 10Gilles) [22:38:35] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Convert to use extension registration [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187471 (https://phabricator.wikimedia.org/T87988) (owner: 10Gilles) [22:40:37] (03CR) 10Gilles: [C: 032] Get rid of $wgUpwizDir and use __DIR__ directly [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187574 (owner: 10Legoktm) [22:41:33] (03Merged) 10jenkins-bot: Get rid of $wgUpwizDir and use __DIR__ directly [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187574 (owner: 10Legoktm) [22:41:52] (03PS3) 10Gilles: [WIP] Convert to use extension registration [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187471 (https://phabricator.wikimedia.org/T87988) [22:42:46] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Convert to use extension registration [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187471 (https://phabricator.wikimedia.org/T87988) (owner: 10Gilles) [22:44:45] (03PS4) 10Gilles: [WIP] Convert to use extension registration [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187471 (https://phabricator.wikimedia.org/T87988) [22:45:23] (03CR) 10Gilles: [WIP] Convert to use extension registration (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187471 (https://phabricator.wikimedia.org/T87988) (owner: 10Gilles) [22:45:28] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Convert to use extension registration [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187471 (https://phabricator.wikimedia.org/T87988) (owner: 10Gilles) [22:55:20] 3Multimedia, MediaWiki-extensions-UploadWizard: Flickr import is a one-way street - https://phabricator.wikimedia.org/T88020#1002623 (10Gilles) 3NEW [22:56:01] (03CR) 10Gilles: "Pau needs to review this, I have a feeling there are pixels he'll like to push. Please ping him." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187238 (owner: 10MarkTraceur)