[00:03:42] <wikibugs>	 3Multimedia, Security-Reviews, MediaWiki-extensions-Sentry: Quick/short security review of Extension:Sentry - https://phabricator.wikimedia.org/T86677#1019781 (10csteipp) I talked through the privacy aspects with Tgr, and as long as access to the collection server is restricted to start, we should be ok on that....
[00:24:30] <wikibugs>	 3Multimedia, MediaWiki-extensions-TimedMediaHandler: TimedMediaHandler jenkins PHPUnit tests fail: depends on MwEmbedSupport extension - https://phabricator.wikimedia.org/T88729#1019827 (10hashar)
[00:30:08] <wikibugs>	 3Multimedia, MediaWiki-extensions-TimedMediaHandler: TimedMediaHandler jenkins PHPUnit tests fail: depends on MwEmbedSupport extension - https://phabricator.wikimedia.org/T88729#1019837 (10hashar) integration/config.git jjb/mediawiki-extensions.yaml has: ```      - TimedMediaHandler:         dependencies: 'MwEmb...
[00:33:27] <tgr>	 Keegan|Away: added some inline comments to the commonsdata update etherpad
[00:36:14] <wikibugs>	 3Multimedia, MediaWiki-extensions-TimedMediaHandler: TimedMediaHandler jenkins PHPUnit tests fail: depends on MwEmbedSupport extension - https://phabricator.wikimedia.org/T88729#1019854 (10hashar) Good news I can reproduce the issue on my local setup:  ```` $ ls extensions/ MwEmbedSupport     TimedMediaHandler $...
[00:44:34] <wikibugs>	 3Multimedia, MediaWiki-extensions-TimedMediaHandler: TimedMediaHandler jenkins PHPUnit tests fail: depends on MwEmbedSupport extension - https://phabricator.wikimedia.org/T88729#1019886 (10Yurik) shouldn't we simply move to extension.json per @legoktm?
[00:52:30] <wikibugs>	 3Multimedia, operations, MediaWiki-extensions-GWToolset: Can Commons support a mass upload of 14 million files (1.5 TB)? - https://phabricator.wikimedia.org/T88758#1019904 (10Tgr) The earlier overload issues weren't related to upload batch size, but rather to image size, and in theory should not happen again (al...
[00:55:04] <wikibugs>	 3Multimedia, Security-Reviews, MediaWiki-extensions-Sentry: Quick/short security review of Extension:Sentry - https://phabricator.wikimedia.org/T86677#1019917 (10Tgr) >>! In T86677#1019781, @csteipp wrote: > @Tgr, who on multimedia is responsible for making sure that any security fixes in upstream will get deplo...
[00:57:16] <wikibugs>	 3Multimedia, Beta-Cluster, MediaWiki-extensions-Sentry: Deploy Sentry on beta cluster - https://phabricator.wikimedia.org/T78807#1019922 (10csteipp)
[00:57:19] <wikibugs>	 3Multimedia, Security-Reviews, MediaWiki-extensions-Sentry: Quick/short security review of Extension:Sentry - https://phabricator.wikimedia.org/T86677#1019920 (10csteipp) 5Open>3Resolved
[01:45:27] <tgr>	 greg-g: can I go on and schedule a deploy slot for https://phabricator.wikimedia.org/T78807 ?
[02:33:19] <wikibugs>	 3Multimedia, MediaWiki-extensions-Sentry: Automated tests for Sentry error logging - https://phabricator.wikimedia.org/T88078#1020038 (10Tgr) Created [[ https://www.mediawiki.org/wiki/Extension:Buggy | Extension:Buggy ]] which provides the tests needed for the report in T88399.
[03:00:42] <grrrit-wm>	 (03CR) 10Gergő Tisza: "> TODO: actually test this (should be possible with the commons vagrant role)." [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/188743 (https://phabricator.wikimedia.org/T86955) (owner: 10Gergő Tisza)
[03:01:41] <wikibugs>	 3Multimedia, MediaWiki-File-management: "thumb.php" should not throw fatal MWException when missing query parameters - https://phabricator.wikimedia.org/T88508#1020064 (10Tgr) a:3Tgr
[03:01:51] <wikibugs>	 3Multimedia, MediaWiki-File-management: Add ForeignDBFile method to get timestamp of last modification of file description page - https://phabricator.wikimedia.org/T88648#1020065 (10Tgr) a:3Tgr
[03:02:00] <wikibugs>	 3Multimedia, MediaWiki-extensions-Sentry: Automated tests for Sentry error logging - https://phabricator.wikimedia.org/T88078#1020066 (10Tgr) a:3Tgr
[03:02:07] <wikibugs>	 3Multimedia, operations: Errors when generating thumbnails should result in HTTP 400, not HTTP 500 - https://phabricator.wikimedia.org/T88412#1020067 (10Tgr) a:3Tgr
[03:06:37] <grrrit-wm>	 (03CR) 10Gergő Tisza: [C: 032] Icon updates [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/188929 (owner: 10Pginer)
[03:07:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: Icon updates [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/188929 (owner: 10Pginer)
[03:46:57] <wikibugs>	 3Multimedia, MediaWiki-extensions-Sentry: Improve Sentry coverage - https://phabricator.wikimedia.org/T88399#1020072 (10Tgr)
[03:47:48] <wikibugs>	 3Multimedia, MediaWiki-extensions-Sentry: Improve Sentry coverage - https://phabricator.wikimedia.org/T88399#1010676 (10Tgr)
[03:49:25] <Keegan>	 thanks, tgr
[04:46:30] <wikibugs>	 3Multimedia, Beta-Cluster, MediaWiki-extensions-Sentry: Deploy Sentry on beta cluster - https://phabricator.wikimedia.org/T78807#1020105 (10greg) @tgr go ahead and deploy this anytime on beta cluster tomorrow during the day or next week.
[06:53:29] <wikibugs>	 3Multimedia, Beta-Cluster, MediaWiki-extensions-Sentry: Deploy Sentry extension on beta cluster - https://phabricator.wikimedia.org/T78807#1020222 (10Tgr)
[06:54:32] <tgr>	 marktraceur: if you have some free time on friday, could you look at https://gerrit.wikimedia.org/r/#/c/181439/ ?
[06:54:55] <tgr>	 i'd like to get a +1 on it before I deploy it
[08:02:38] <wikibugs>	 3Multimedia, Structured-Multimedia-Data, Wikimedia-Hackathon-2015: Categories are metadata - https://phabricator.wikimedia.org/T87686#1020279 (10Lydia_Pintscher) What @Tgr said. Categories as they are are associated with pages and not topics. They are also completely different across languages/cultures. So I'd s...
[08:58:53] <wikibugs>	 3Multimedia, operations, MediaWiki-extensions-GWToolset: Can Commons support a mass upload of 14 million files (1.5 TB)? - https://phabricator.wikimedia.org/T88758#1020333 (10fgiunchedi) thanks for the heads up @harej ! space-wise we are in the process of expanding our swift cluster capacity in T1268 and current...
[09:21:23] <wikibugs>	 3Multimedia, operations, MediaWiki-extensions-GWToolset: Can Commons support a mass upload of 14 million files (1.5 TB)? - https://phabricator.wikimedia.org/T88758#1020359 (10Harej) The timeline is whatever you tell me it is. ;)  In any case, the plan was to start off small and then increment from there. Nothing...
[09:23:24] <wikibugs>	 3Multimedia, operations, MediaWiki-extensions-GWToolset: Can Commons support a mass upload of 14 million files (1.5 TB)? - https://phabricator.wikimedia.org/T88758#1020364 (10Reedy) >>! In T88758#1020359, @Harej wrote: > The timeline is whatever you tell me it is. ;) >  > In any case, the plan was to start off s...
[09:32:23] <wikibugs>	 3Multimedia, operations, MediaWiki-extensions-GWToolset: Can Commons support a mass upload of 14 million files (1.5 TB)? - https://phabricator.wikimedia.org/T88758#1020366 (10fgiunchedi) >>! In T88758#1020359, @Harej wrote: > The timeline is whatever you tell me it is. ;) >  > In any case, the plan was to start...
[13:40:39] <grrrit-wm>	 (03PS6) 10Unicodesnowman: Add interactive tour of Media Viewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185670 (https://phabricator.wikimedia.org/T77726) 
[13:44:25] <grrrit-wm>	 (03CR) 10Unicodesnowman: "Thanks for the feedback! This patch should address all the issues except the tour retaking - I'll have some time investigating it over the" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/185670 (https://phabricator.wikimedia.org/T77726) (owner: 10Unicodesnowman)
[14:39:56] <wikibugs>	 3Multimedia, Analytics: Video view counts? - https://phabricator.wikimedia.org/T88775#1020605 (10Tbayer)
[14:41:17] <wikibugs>	 3Multimedia, Analytics: Video view counts? - https://phabricator.wikimedia.org/T88775#1020132 (10Tbayer) I understand that it's indeed about Commons, and guess that Multimedia and Analytics might be relevant projects.
[15:02:23] <wikibugs>	 3Multimedia, Structured-Multimedia-Data, Wikimedia-Hackathon-2015: Edit image metadata in remote repositories from the downstream wiki - https://phabricator.wikimedia.org/T88685#1020627 (10Lydia_Pintscher) We'll not be anywhere near to supporting structured data on Commons in time for the hackathon. What could b...
[15:16:45] <wikibugs>	 3Multimedia, MediaWiki-extensions-GWToolset, MediaWiki-API: Result set of recentchanges gets padded with void data - https://phabricator.wikimedia.org/T88783#1020647 (10Anomie) Adding the 'loginfo' parameter to the query reveals that these are far from "void data"; in fact, they all appear to be log entries from...
[15:17:19] <wikibugs>	 3Multimedia, MediaWiki-extensions-GWToolset: Result set of recentchanges gets padded with void data - https://phabricator.wikimedia.org/T88783#1020650 (10Anomie)
[16:50:39] <grrrit-wm>	 (03PS1) 10MarkTraceur: Remove "upload" and "wizard" references from UWUI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/189026 
[16:52:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Remove "upload" and "wizard" references from UWUI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/189026 (owner: 10MarkTraceur)
[18:04:22] <marktraceur>	 How did that test ever work
[18:04:23] <marktraceur>	 wtf
[18:04:28] <marktraceur>	 It's the same object
[18:06:48] <marktraceur>	 Ah, good catch qunit
[18:10:02] <grrrit-wm>	 (03PS2) 10MarkTraceur: Remove "upload" and "wizard" references from UWUI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/189026 
[19:21:33] <wikibugs>	 3Multimedia, Mobile-Apps, MediaWiki-extensions-MultimediaViewer: Add a data- attribute with the file's title to [[File: elements - https://phabricator.wikimedia.org/T88825#1021126 (10MarkTraceur) 3NEW
[19:22:51] <wikibugs>	 3Multimedia, Mobile-Apps, MediaWiki-extensions-MultimediaViewer: Add a data- attribute with the file's title to [[File: elements - https://phabricator.wikimedia.org/T88825#1021140 (10brion) cc'ing Gabriel to check in on the Parsoid HTML compatibility side.
[19:24:33] <wikibugs>	 3Multimedia, Mobile-Apps, MediaWiki-extensions-MultimediaViewer: Add a data- attribute with the file's title to [[File: elements - https://phabricator.wikimedia.org/T88825#1021154 (10GWicke) The Parsoid spec is here: https://www.mediawiki.org/wiki/Parsoid/MediaWiki_DOM_spec#Images  The ./ prefix is easy to strip...
[19:26:40] <wikibugs>	 3Multimedia, Mobile-Apps, MediaWiki-extensions-MultimediaViewer: Add a data- attribute with the file's title to [[File: elements - https://phabricator.wikimedia.org/T88825#1021156 (10brion) Relative path with ./ prefix is probably about as easy to deal with as pure-title, and would be needed for handling links i...
[19:28:03] <wikibugs>	 3Multimedia, Mobile-Apps, MediaWiki-extensions-MultimediaViewer: Add a data- attribute with the file's title to [[File: elements - https://phabricator.wikimedia.org/T88825#1021158 (10GWicke)
[19:33:33] <wikibugs>	 3Multimedia, Mobile-Apps, MediaWiki-extensions-MultimediaViewer: Add a data- attribute with the file's title to [[File: elements - https://phabricator.wikimedia.org/T88825#1021176 (10brion) Note also we should make sure these appear on <video>/<audio> from TimedMediaHandler for consistency (or on their wrapper e...
[20:00:04] <wikibugs>	 3Multimedia, MediaWiki-extensions-GWToolset: Result set of recentchanges gets padded with void data - https://phabricator.wikimedia.org/T88783#1021285 (10McZusatz) >>! In T88783#1020647, @Anomie wrote: > these are far from "void data"; in fact, they all appear to be log entries from #MediaWiki-extensions-GWTools...
[20:13:07] <wikibugs>	 3Multimedia, MediaWiki-extensions-GWToolset: GWToolset is flooding logs on Commons with poorly-constructed log entries - https://phabricator.wikimedia.org/T88783#1021310 (10Anomie)
[21:12:21] <marktraceur>	 Oh man, less. I missed less.
[21:12:34] <marktraceur>	 (I'm reviewing some of the patches in needs code review)
[21:14:41] <marktraceur>	 tgr: Any particular reason you're doing $thing.empty().append.apply( $thing, ... ) instead of just .append( ... )?
[21:14:49] <marktraceur>	 I think empty is chainable
[21:15:11] <marktraceur>	 Oh, because you have indeterminate arguments
[21:15:14] <marktraceur>	 Never mind...
[21:23:49] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] "Great!" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178059 (https://phabricator.wikimedia.org/T76030) (owner: 10Gergő Tisza)
[21:26:27] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add functions to display/remove a warning in the dialogs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178059 (https://phabricator.wikimedia.org/T76030) (owner: 10Gergő Tisza)
[21:26:52] <marktraceur>	 Aw.
[21:27:42] <grrrit-wm>	 (03CR) 10MarkTraceur: [C: 032] Fix up HookHandler documentation [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/188501 (owner: 10Gergő Tisza)
[21:27:58] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix up HookHandler documentation [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/188501 (owner: 10Gergő Tisza)
[21:28:10] <grrrit-wm>	 (03CR) 10MarkTraceur: "recheck" [extensions/CommonsMetadata] - 10https://gerrit.wikimedia.org/r/188743 (https://phabricator.wikimedia.org/T86955) (owner: 10Gergő Tisza)
[21:30:32] <marktraceur>	 Urgh, this is going to be hard as *hell* to test
[21:30:56] <marktraceur>	 Oh, tests failed anyway
[21:31:05] <marktraceur>	 Oh, core dependency.
[21:33:00] <wikibugs>	 3Multimedia, MediaWiki-extensions-UploadWizard: That file type is forbidden: ogg - https://phabricator.wikimedia.org/T87538#1021533 (10MarkTraceur) 5Open>3Resolved I believe this is fixed!
[22:10:31] <wikibugs>	 3Multimedia, MediaWiki-extensions-GWToolset: GWToolset is flooding logs on Commons with poorly-constructed log entries - https://phabricator.wikimedia.org/T88783#1021709 (10Tgr) 5Open>3Resolved a:3Tgr >>! In T88783#1021285, @McZusatz wrote: > I never saw such log entries before and in the last 30 days ther...
[22:32:45] <grrrit-wm>	 (03CR) 10Umherirrender: "test failure is T88729" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/188831 (https://phabricator.wikimedia.org/T88697) (owner: 10Dbrant)
[22:38:37] <tgr>	 marktraceur: thanks for the reviews!
[22:38:44] <tgr>	 can you also look at You can, however, throttle client side: if loading the 1st image took over X, do not proceed with subsequent images. Info about loading times of resources is available through a new API (same API  we use to measure times in media viewer): http://www.w3.org/TR/resource-timing/
[22:38:53] <tgr>	 oops, copypaste fail
[22:38:57] <marktraceur>	 Heh
[22:39:05] <tgr>	 https://gerrit.wikimedia.org/r/#/c/181439/
[22:39:08] <marktraceur>	 Yes I can look at your clipboard!
[22:39:17] <tgr>	 I would deploy it today then
[22:39:33] <marktraceur>	 Can't, Friday
[22:39:40] <marktraceur>	 Unless greg-g is like GOTTA HAVE IT
[22:40:05] <tgr>	 greg said it's fine
[22:40:13] <marktraceur>	 ...wheeere
[22:40:25] <tgr>	 then again, there is no reason not to wait until Monday I guess
[22:40:43] <marktraceur>	 Also did he know that I will be deploying it at 16:40 local time on Friday? Or was this earlier, when I would still be around and sober for a few hours
[22:41:11] <tgr>	 https://phabricator.wikimedia.org/T78807#1020105
[22:41:30] <marktraceur>	 Mighty exciting
[22:41:33] <marktraceur>	 OK, fine
[22:41:53] <tgr>	 it's not urgent at all, so Monday is just as fine
[22:42:03] <marktraceur>	 So...IIRC I only need to sync this as a courtesy, nothing needs to be done for beta
[22:42:13] <marktraceur>	 If I'm wrong, may the Gods be merciful
[22:42:52] <tgr>	 that was my impression as well
[22:43:03] <tgr>	 "Whenever your change to operations/mediawiki-config.git is merged, it will be deployed by Jenkins job beta-mediawiki-config-update-eqiad as described above." https://wikitech.wikimedia.org/wiki/Nova_Resource:Deployment-prep/How_code_is_updated#How_to_add_a_new_extension_on_beta
[22:43:10] <marktraceur>	 Yup
[22:43:17] <marktraceur>	 But I should sync it just the same
[22:45:46] <marktraceur>	 tgr: See -operations, yer patch needs a rebase
[22:49:53] <tgr>	 marktraceur: rebased
[22:54:57] <wikibugs>	 3Multimedia, Mobile-Apps, MediaWiki-extensions-MultimediaViewer: Add a data- attribute with the file's title to [[File: elements - https://phabricator.wikimedia.org/T88825#1021853 (10GWicke) @brion: Agreed.
[23:01:03] <wikibugs>	 3Multimedia, Wikimedia-Media-storage, Wikimedia-OTRS: Provide a clickthrough workflow for file copyright email permissions - https://phabricator.wikimedia.org/T88620#1021856 (10Matthewrbowker) p:5Triage>3Normal a:3Matthewrbowker
[23:20:04] <tgr>	 bd808: could you add SENTRY_ALLOW_ORIGIN = "*" to the sentry-beta config?
[23:28:13] <tgr>	 marxarelli: what do you think of https://phabricator.wikimedia.org/T88356 ? is that a sane way towards better vagrant documentation?
[23:37:05] <marxarelli>	 tgr: that's an interesting idea
[23:37:36] <marxarelli>	 tgr: we also have `vagrant roles info <role>` which shows any inline documentation for the puppet role class
[23:38:01] <marxarelli>	 which we could use as an entry point
[23:38:29] <marxarelli>	 and perhaps we could display that info when the role is enabled
[23:39:55] <marxarelli>	 tgr: i'll comment in the task :)
[23:47:44] <bd808>	 tgr: Which config? On the scabby beta instance I made?
[23:49:27] <tgr>	 bd808: yes, in sentry.conf.py
[23:49:56] <tgr>	 I am working on a proper puppet config, honest :)
[23:50:04] <bd808>	 tgr: glad to add it, but do you not have access to that host?
[23:50:27] <tgr>	 don't think so but lemme check
[23:50:38] <bd808>	 deployment-sentry2.eqiad.wmflabs
[23:50:55] <tgr>	 oh, it's in the deployment project?
[23:50:59] <tgr>	 I should have then
[23:51:04] <bd808>	 should be the same as any deployment-prep host for access rights
[23:51:19] <bd808>	 *nod* go forth and do what you need!
[23:51:32] <bd808>	 software is in /srv/sentry