[00:07:22] is beta half-dead somehow? [00:07:44] I get a bunch of 403s for script URLs [00:08:49] It may have not been completely restarted yet after the labs outage [00:09:19] I know the db server was down for a while. Might check in #-releng [00:14:25] tgr: the db servers came up a little while ago, been OK for me [00:17:00] chrismcmahon: probably not DB-related, bits.beta.wmflabs.org is returning 403 on some queries [00:17:11] both PHP and direct asset access [00:17:34] maybe the vagrant cache got messed up during the outage [00:19:34] 3UI-Standardization, Multimedia, MediaWiki-extensions-MultimediaViewer: Adjust Media Viewer download menu colors - https://phabricator.wikimedia.org/T89520#1045250 (10Tgr) The background color changes are all upstream, the only thing I changed is the color of the secondary text on the selected option, to better... [00:20:24] we do cache some types of non-200 results in varnish but typically not for very long (<5 mins as I recall) [00:21:24] a cold restart of the varnish servers in beta doesn't really hurt anything. I don't remember all the right magic to do it though. I'm seen hashar log it. Instructions are probably on wikitech somewhere [00:21:37] *I've seen [00:25:40] 3MediaWiki-extensions-Extensions-requests, Possible-Tech-Projects, Multimedia: Allow smoother and easier Wikimedia Commons pictures discovery - https://phabricator.wikimedia.org/T59805#1045269 (10Tgr) >>! In T59805#1043108, @Qgil wrote: >>>! In T59805#633421, @Tgr wrote: >> MultimediaViewer is very much a moving... [00:27:30] bd808: https://phabricator.wikimedia.org/T89159 ? [00:49:50] tgr: I think there is another way to drop the whole cache. That is a one-url-a-time forced eviction [00:50:53] `varnishadm "ban req.url ~ /"` might get rid of them all [00:52:37] note that a ban like that doesn't actually purge anything but varnish checks the ban list after an cache hit and if the hit object is older than the ban it ignores the hit [01:01:15] so we need "ban req.http.host == bits.beta.wmflabs.org && req.url == /" I guess? [01:06:27] 3Multimedia, MediaWiki-extensions-MultimediaViewer: MediaViewer crops bottom of images - https://phabricator.wikimedia.org/T89631#1045383 (10Tgr) [01:06:36] 3Multimedia, MediaWiki-extensions-MultimediaViewer: MediaViewer sometimes sets wrong aspect ratio in IE 11 / Win7 - https://phabricator.wikimedia.org/T89679#1045384 (10Tgr) [01:08:09] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Mobile Web and Multimedia viewer should use same hash fragment - https://phabricator.wikimedia.org/T87769#1045387 (10Tgr) [01:08:28] 3Multimedia, MediaWiki-extensions-Sentry: Add error id generation to mw.errorLogging - https://phabricator.wikimedia.org/T89384#1045388 (10Tgr) [01:08:52] 3Multimedia, MediaWiki-extensions-Sentry: Catch uncaught exceptions with Sentry - https://phabricator.wikimedia.org/T88874#1045391 (10Tgr) [01:09:01] 3MediaWiki-Vagrant, Multimedia, MediaWiki-extensions-Sentry: Vagrantize Sentry - https://phabricator.wikimedia.org/T84957#1045392 (10Tgr) [01:09:13] 3MediaWiki-Vagrant, Multimedia, MediaWiki-extensions-Sentry: Vagrantize Sentry - https://phabricator.wikimedia.org/T84957#934575 (10Tgr) [01:09:55] 3Multimedia, MediaWiki-extensions-Sentry: Add error id generation to mw.errorLogging - https://phabricator.wikimedia.org/T89384#1035078 (10Tgr) [01:10:12] 3Multimedia, MediaWiki-extensions-Sentry: Catch uncaught exceptions with Sentry - https://phabricator.wikimedia.org/T88874#1022186 (10Tgr) [01:10:24] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Mobile Web and Multimedia viewer should use same hash fragment - https://phabricator.wikimedia.org/T87769#1045399 (10Tgr) [01:10:54] 3UI-Standardization, Multimedia, MediaWiki-extensions-MultimediaViewer: Adjust Media Viewer download menu colors - https://phabricator.wikimedia.org/T89520#1045401 (10violetto) @Pau, I hope this [[ https://phabricator.wikimedia.org/M34/64/ | M64 ]] helps. Let me know if it doesn't. [01:11:44] 3MediaWiki-Vagrant, Multimedia, MediaWiki-extensions-Sentry: Vagrantize Sentry - https://phabricator.wikimedia.org/T84957#1045407 (10Tgr) [01:12:45] 3Multimedia, MediaWiki-extensions-Sentry: Catch uncaught exceptions with Sentry - https://phabricator.wikimedia.org/T88874#1045415 (10Tgr) [01:12:55] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Mobile Web and Multimedia viewer should use same hash fragment - https://phabricator.wikimedia.org/T87769#1045416 (10Tgr) [01:13:06] 3Multimedia, MediaWiki-extensions-MultimediaViewer: MediaViewer crops bottom of images - https://phabricator.wikimedia.org/T89631#1045417 (10Tgr) [01:13:12] 3MediaWiki-Vagrant, Multimedia, MediaWiki-extensions-Sentry: Vagrantize Sentry - https://phabricator.wikimedia.org/T84957#1045419 (10bd808) >>! In T84957#1009925, @Tgr wrote: > I am running into various permissions-related trouble, e.g. `ImproperlyConfigured: Could not write to directory: /vagrant/logs/sentry.ma... [01:13:21] 3Multimedia, MediaWiki-extensions-MultimediaViewer: MediaViewer sometimes sets wrong aspect ratio in IE 11 / Win7 - https://phabricator.wikimedia.org/T89679#1045420 (10Tgr) [03:41:17] (03PS1) 10Gergő Tisza: Browser test for chunked uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191246 (https://phabricator.wikimedia.org/T89289) [03:41:52] (03CR) 10jenkins-bot: [V: 04-1] Browser test for chunked uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191246 (https://phabricator.wikimedia.org/T89289) (owner: 10Gergő Tisza) [03:50:33] (03PS2) 10Gergő Tisza: Browser test for chunked uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191246 (https://phabricator.wikimedia.org/T89289) [03:51:04] (03CR) 10jenkins-bot: [V: 04-1] Browser test for chunked uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191246 (https://phabricator.wikimedia.org/T89289) (owner: 10Gergő Tisza) [04:22:30] (03PS3) 10Gergő Tisza: Browser test for chunked uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191246 (https://phabricator.wikimedia.org/T89289) [04:25:15] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard does not handle invalid names - https://phabricator.wikimedia.org/T89792#1045604 (10Tgr) 3NEW [04:57:41] 3MediaWiki-extensions-UploadWizard, Multimedia: Default license in preferences not respected for multi-file uploads going through the per-file license picking step - https://phabricator.wikimedia.org/T89717#1045667 (10Romaine) >>! In T89717#1043746, @Gilles wrote: > Thank you for the extra information, I can rep... [06:35:34] 3MediaWiki-extensions-Extensions-requests, Possible-Tech-Projects, Multimedia: Allow smoother and easier Wikimedia Commons pictures discovery - https://phabricator.wikimedia.org/T59805#1045818 (10Nemo_bis) 5Open>3stalled [08:09:21] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard does not handle invalid names - https://phabricator.wikimedia.org/T89792#1045916 (10Gilles) Files without an extension are perfectly valid in some operating systems. [08:11:52] 3MediaWiki-extensions-UploadWizard, Multimedia: Default license in preferences not respected for multi-file uploads going through the per-file license picking step - https://phabricator.wikimedia.org/T89717#1045917 (10Gilles) Thanks for the extra info, I'll test the "upload more files" scenario to see if there's... [08:18:25] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard does not handle invalid names - https://phabricator.wikimedia.org/T89792#1045919 (10Gilles) I actually can't repro on master with a JPG lacking an extension (OS X/firefox). It uploads fine and UW seems to add the extension in the UI. Maybe in your cas... [08:36:55] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard does not handle invalid names - https://phabricator.wikimedia.org/T89792#1045925 (10Tgr) Attached the test file I was using (with master). It's the one generated by the chunked upload browser test. {F42903} [08:37:43] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard does not handle invalid names - https://phabricator.wikimedia.org/T89792#1045926 (10Tgr) Invisible pixel is invisible... F42903 [08:49:05] 3MediaWiki-extensions-UploadWizard, Multimedia: Default license in preferences not respected for multi-file uploads going through the per-file license picking step - https://phabricator.wikimedia.org/T89717#1045936 (10Gilles) Seems to work fine in the "upload more files" scenario with my fix applied. [08:57:22] 3MediaWiki-extensions-UploadWizard, Multimedia: Default license in preferences not respected for multi-file uploads going through the per-file license picking step - https://phabricator.wikimedia.org/T89717#1045951 (10Romaine) Thanks [09:28:31] (03CR) 10Gilles: [C: 032] "Seems to work fine now, maybe it was caused by beta gremlins." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/186543 (https://phabricator.wikimedia.org/T86119) (owner: 10MarkTraceur) [09:29:40] (03Merged) 10jenkins-bot: Add browser test for "upload more files" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/186543 (https://phabricator.wikimedia.org/T86119) (owner: 10MarkTraceur) [09:39:42] (03CR) 10Gilles: [C: 04-1] Browser test for chunked uploads (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191246 (https://phabricator.wikimedia.org/T89289) (owner: 10Gergő Tisza) [09:39:58] (03PS4) 10Gilles: Browser test for chunked uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191246 (https://phabricator.wikimedia.org/T89289) (owner: 10Gergő Tisza) [09:46:53] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard does not handle invalid names - https://phabricator.wikimedia.org/T89792#1045998 (10Gilles) Can you upload it somewhere else? I can't find a way to download and save the actual image in phabricator, I keep getting an HTML error served instead. [09:48:06] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard does not handle invalid names - https://phabricator.wikimedia.org/T89792#1045999 (10Gilles) I did reproduce your issue, however, by picking a text file with no extension. [09:49:54] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Share panel tab interface broken in Media Viewer - https://phabricator.wikimedia.org/T89531#1046004 (10Gilles) 5Open>3Resolved [09:58:34] 3Multimedia: Show warning about privacy/security issues on PDF file pages - https://phabricator.wikimedia.org/T89765#1046011 (10Gilles) Isn't that something that could be filtered/sanitized at the upload stage? That's how we usually deal with file formats that can contain code/phone home features. [10:02:21] 3Analytics, Multimedia, MediaWiki-extensions-MultimediaViewer: Get rid of sync AJAX calls in MediaViewer - https://phabricator.wikimedia.org/T89533#1046016 (10Gilles) a:3Tgr This task ought to be renamed. [10:11:16] 3MediaWiki-extensions-UploadWizard, Multimedia: Browser tests no longer work on Chrome - https://phabricator.wikimedia.org/T86770#1046025 (10Gilles) [10:11:28] 3MediaWiki-extensions-UploadWizard, Multimedia: Browser test for flickr import - https://phabricator.wikimedia.org/T86120#1046026 (10Gilles) [10:12:41] 3Multimedia: Change browser tests for skip preference to use login redirects - https://phabricator.wikimedia.org/T87462#1046030 (10Gilles) Can you explain a little bit about how this would work? I'm not familiar with login redirects. We now have the need to set several preferences in different tests, this would... [10:12:50] 3Multimedia: Change browser tests for skip preference to use login redirects - https://phabricator.wikimedia.org/T87462#1046031 (10Gilles) [10:14:36] 3Analytics, Multimedia, MediaWiki-extensions-MultimediaViewer: Get rid of sync AJAX calls in MediaViewer - https://phabricator.wikimedia.org/T89533#1046033 (10Gilles) [10:15:38] 3MediaWiki-extensions-UploadWizard, Multimedia: Browser test for "copy file metadata" - https://phabricator.wikimedia.org/T89356#1046034 (10Gilles) [10:15:56] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard does not handle invalid names - https://phabricator.wikimedia.org/T89792#1046037 (10Aklapper) >>! In T89792#1045998, @Gilles wrote: > I can't find a way to download and save the actual image in phabricator, I keep getting an HTML error served instead.... [10:17:07] 3MediaWiki-extensions-UploadWizard, Multimedia: Default license in preferences not respected for multi-file uploads going through the per-file license picking step - https://phabricator.wikimedia.org/T89717#1046040 (10Gilles) [10:17:14] 3Analytics, Multimedia, MediaWiki-extensions-MultimediaViewer: Set up varnish 204 beacon endpoint for virtual media views and use it in Media Viewer - https://phabricator.wikimedia.org/T89088#1046041 (10Gilles) [10:17:21] 3Multimedia, MediaWiki-extensions-MultimediaViewer: "Clicking the image closes the download menu" browser test failing on IE - https://phabricator.wikimedia.org/T89087#1046042 (10Gilles) [10:17:26] 3Quality-Assurance, MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard browser test for chunked upload - https://phabricator.wikimedia.org/T89289#1046043 (10Gilles) [10:20:13] 3MediaWiki-extensions-UploadWizard, Multimedia: Browser tests no longer work on Chrome - https://phabricator.wikimedia.org/T86770#1046049 (10Gilles) [10:20:48] 3MediaWiki-extensions-UploadWizard, Multimedia: Browser tests no longer work on Chrome - https://phabricator.wikimedia.org/T86770#976023 (10Gilles) It's certainly a matter of waiting for the right things, or short of that being possible, adding sleeps. [10:21:05] 3MediaWiki-extensions-UploadWizard, Multimedia: Browser tests no longer work on Chrome - https://phabricator.wikimedia.org/T86770#1046051 (10Gilles) a:5MarkTraceur>3None [10:21:13] 3Multimedia: Change browser tests for skip preference to use login redirects - https://phabricator.wikimedia.org/T87462#1046053 (10Gilles) a:5MarkTraceur>3None [10:21:31] 3MediaWiki-extensions-UploadWizard, Multimedia: Browser test for flickr import - https://phabricator.wikimedia.org/T86120#1046054 (10Gilles) a:5MarkTraceur>3None [10:21:55] 3Multimedia: Change browser tests for skip preference to use login redirects - https://phabricator.wikimedia.org/T87462#991812 (10Gilles) [10:22:04] 3MediaWiki-extensions-UploadWizard, Multimedia: Browser test for flickr import - https://phabricator.wikimedia.org/T86120#961818 (10Gilles) [10:22:20] 3Analytics, Multimedia, MediaWiki-extensions-MultimediaViewer: Get rid of sync AJAX calls in MediaViewer - https://phabricator.wikimedia.org/T89533#1046059 (10Gilles) [10:22:33] 3MediaWiki-extensions-UploadWizard, Multimedia: Browser test for "copy file metadata" - https://phabricator.wikimedia.org/T89356#1046061 (10Gilles) [10:22:47] 3Quality-Assurance, MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard browser test for chunked upload - https://phabricator.wikimedia.org/T89289#1046063 (10Gilles) [10:23:15] 3MediaWiki-extensions-UploadWizard, Multimedia: Default license in preferences not respected for multi-file uploads going through the per-file license picking step - https://phabricator.wikimedia.org/T89717#1046064 (10Gilles) [10:23:28] 3Analytics, Multimedia, MediaWiki-extensions-MultimediaViewer: Set up varnish 204 beacon endpoint for virtual media views and use it in Media Viewer - https://phabricator.wikimedia.org/T89088#1046065 (10Gilles) [10:23:36] 3Multimedia, MediaWiki-extensions-MultimediaViewer: "Clicking the image closes the download menu" browser test failing on IE - https://phabricator.wikimedia.org/T89087#1046066 (10Gilles) [10:43:59] 3Multimedia, MediaWiki-extensions-MultimediaViewer: Performance logging graphs suffer tiny sample size starting feb 12th - https://phabricator.wikimedia.org/T89814#1046081 (10Gilles) 3NEW a:3Gilles [10:45:51] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard does not handle invalid names - https://phabricator.wikimedia.org/T89792#1046091 (10Gilles) Look at what it actually saves, the contents of the file is the HTML of an expired token error page. [11:06:30] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard does not handle invalid names - https://phabricator.wikimedia.org/T89792#1046115 (10Aklapper) @Gilles: Not here, it's a valid PNG with my steps above in FF. [11:18:12] gi11es, please change the visibility of projects like https://phabricator.wikimedia.org/project/edit/1059/ to Public, so everyone can see them. I see no reason to restrict that to "All [logged in] users" [11:18:37] 3UI-Standardization, Multimedia, MediaWiki-extensions-MultimediaViewer: Adjust Media Viewer download menu colors - https://phabricator.wikimedia.org/T89520#1046127 (10Pginer-WMF) Thanks @Tgr and @violetto for the clarifications. I think it makes sense to use the standard styling for dropdowns, so that when it ev... [11:46:48] 3Multimedia, MediaWiki-extensions-MultimediaViewer: MediaViewer should have special handling for images which link to other images - https://phabricator.wikimedia.org/T75902#1046150 (10Edokter) Another possible solution is auto-logic is too complicated: add some directive for MediaViewer to image syntax pointing... [14:57:55] 3Multimedia: Show warning about privacy/security issues on PDF file pages - https://phabricator.wikimedia.org/T89765#1046322 (10Anomie) Apparently PDF has so many ways to hide such content that detecting such files is a hard problem. See https://blog.avast.com/2011/04/22/another-nasty-trick-in-malicious-pdf/ for... [15:39:45] (03CR) 10MarkTraceur: Add browser test for "copy file metadata" feature (034 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/190511 (https://phabricator.wikimedia.org/T89356) (owner: 10MarkTraceur) [15:46:59] (03PS1) 10Cmcmahon: QA: update Ruby gems [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191348 [15:48:31] marktraceur: do you mind merging https://gerrit.wikimedia.org/r/#/c/191348 ? It's just maintenance, modern Firefoxes object to something we used to when logging in. [15:48:39] someone from multimedia team around or should I "hack" into (aka. join) https://phabricator.wikimedia.org/project/sprint/profile/48/ ? [15:50:09] it's publicly joinable [15:50:16] Krenair: It [15:50:33] about https://phabricator.wikimedia.org/project/sprint/profile/1059/ , not all user editable and not public visible [15:50:51] Sigh. [15:51:04] Who decided it was a good idea to restrict actions to a project that's publicly joinable? [15:51:08] so, before joining multimedia team, I would like to nicely ask :) [15:53:13] It looks like gi11es set that up [15:55:34] yes, I already pinged him 4 hours ago ;) I saw that (displayed as) "restricted project" last night while browsing trough tasks. [15:56:12] but unfortunately the phabs update broke that link, looks like the multimedia team is now also a "sprint" (URL) [16:00:09] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard does not handle invalid names - https://phabricator.wikimedia.org/T89792#1046576 (10Gilles) Can either of you just email it to me? :) [16:01:20] (03CR) 10Gilles: [C: 032] QA: update Ruby gems [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191348 (owner: 10Cmcmahon) [16:01:28] gi11es is active right now... [16:02:16] (03Merged) 10jenkins-bot: QA: update Ruby gems [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191348 (owner: 10Cmcmahon) [16:03:54] se4598: I'm not sure what you want to do, the sprint project is publicly visible now [16:04:23] gi11es, https://phabricator.wikimedia.org/project/sprint/profile/1059/ is only visible to logged in users [16:04:47] oh, gotcha [16:04:48] done [16:05:04] "all users" is kind of misleading [16:06:43] yes, that's known. also Krenair noted that is a bit pointless to restrict (edit|join) of projects/sprints to teams, which are joinable by everyone [16:08:04] there's a difference between having to join a team, and wondering what's involved, and just messing with our board to try things out [16:08:23] yeah, there are pro and cons :) [16:08:28] gi11es, seems you accidently removed the sprint attributes O.o [16:08:58] I guess it's not ticked when editing, could be a bug or related to moving to the new version [16:09:44] 3MediaWiki-extensions-GWToolset, Multimedia, Beta-Cluster: Creating directory with special characters - https://phabricator.wikimedia.org/T75725#1046604 (10Lena) Hi everyone. I'm sorry if this sounds harsh but I really need to say it. This bug has been opened three months ago, and prevents me from uploading hi... [16:09:45] it should be a sprint again [16:10:15] yeah, some internal software inconsistency probably [16:10:33] thanks, that's it from me :) [16:27:10] 3MediaWiki-extensions-GWToolset, Multimedia, Beta-Cluster: Creating directory with special characters - https://phabricator.wikimedia.org/T75725#1046712 (10Gilles) Just to give you a bit of perspective, #multimedia is staffed by 3 engineers. We have 20+ extensions to maintain and currently a backlog of approxim... [16:32:36] 3MediaWiki-extensions-GWToolset, Multimedia, Beta-Cluster: Creating directory with special characters - https://phabricator.wikimedia.org/T75725#1046748 (10Lena) Gilles it's really ok that this bug will not be corrected any time soon. (Well no it's not but it's not your fault :) I understand the burden of unders... [16:33:43] (03PS1) 10Cmcmahon: QA: wait for second upload control to appear [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191355 [16:34:20] (03CR) 10jenkins-bot: [V: 04-1] QA: wait for second upload control to appear [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191355 (owner: 10Cmcmahon) [16:38:15] (03PS2) 10Cmcmahon: QA: wait for second upload control to appear [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191355 [16:38:38] (03PS5) 10Gilles: Respect preferences' default license when picking a license per file [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191191 (https://phabricator.wikimedia.org/T89717) [16:39:59] (03CR) 10Gilles: [C: 032] QA: wait for second upload control to appear [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191355 (owner: 10Cmcmahon) [16:40:08] (03CR) 10jenkins-bot: [V: 04-1] Respect preferences' default license when picking a license per file [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191191 (https://phabricator.wikimedia.org/T89717) (owner: 10Gilles) [16:41:21] (03PS6) 10Gilles: Respect preferences' default license when picking a license per file [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191191 (https://phabricator.wikimedia.org/T89717) [16:41:54] (03CR) 10jenkins-bot: [V: 04-1] Respect preferences' default license when picking a license per file [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191191 (https://phabricator.wikimedia.org/T89717) (owner: 10Gilles) [16:43:07] (03PS7) 10Gilles: Respect preferences' default license when picking a license per file [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191191 (https://phabricator.wikimedia.org/T89717) [16:44:44] (03Merged) 10jenkins-bot: QA: wait for second upload control to appear [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191355 (owner: 10Cmcmahon) [16:47:51] (03PS8) 10Gilles: Respect preferences' default license when picking a license per file [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191191 (https://phabricator.wikimedia.org/T89717) [16:57:38] (03CR) 10Gilles: [C: 04-1] "Note that the browser tests will (correctly) fail against commons beta because the bugfix is part of the same changeset." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191191 (https://phabricator.wikimedia.org/T89717) (owner: 10Gilles) [16:59:00] marktraceur: tgr|away: cucumber pro-tip, it's possible to run a single scenario with this syntax [16:59:03] cucumber features/upload_wizard_preferences.feature:19 [16:59:25] where 19 is the line number of the scenario declaration in the feature file [17:03:37] Neat. [17:08:19] marktraceur: are there any synchronous AJAX calls in UW? [17:08:30] There shouldn't be anymore [17:08:40] I think we had...at least one, but I thought I murdered it [17:08:42] when I press next on the release right page to go to the per-file license stuff it feels like one [17:08:53] but maybe I'm imagining things [17:08:57] I'll check [17:09:21] when dealing wit a multifile upload [17:09:37] I don't see anything that sets async to false [17:09:47] I'll dig in the deeds code real quick [17:09:48] alright, then, good news :) [17:11:02] Maybe it's the copymetadata interface getting built or something [17:11:09] gi11es: It just feels sluggish? Does your browser freeze up? [17:11:25] yeah [17:11:32] Weeeird. [17:11:43] I'll try profiling it quick too [17:12:01] firefox, though, which has a tendency to do this [17:12:38] Yeah [17:12:42] also, regarding my attempt to get rid of the sleep on the learn page, do you think it's possible that the next button's click handler get added "late"? [17:13:00] I tried waiting for the tutorial image to appear instead of sleeping, but when I did the click on the next button seemed to noop [17:13:06] Hm, maybe [17:13:36] I'll try tracking down where that handler is added [17:13:44] gi11es: In the tutorial UI constructor [17:13:49] Which is fired pretty quick [17:13:58] But not on page load, and maybe not on that element's render [17:14:07] is the tutorial image part of the DOM served by PHP, though? [17:14:13] Hrmm [17:14:19] I *think* so [17:14:20] I don't think so [17:14:24] there's a spinner first [17:14:31] or maybe it's there but hidden until loaded? [17:14:35] or something crazy like that [17:14:37] That's what I would guess [17:16:21] yeah looks like it's served with the page [17:16:50] and I'm guessing the spinner/image JS logic is independent of the next button's setup [17:17:14] gi11es: For some reason the update function for moving the file input is still firing while moving to the describe page... [17:17:22] Gotta stop that, UW [17:17:46] oh, the good old follows-your-cursor trick? [17:18:44] I am glad to see you all working on this :-) [17:18:44] No, the one that covers an element [17:18:56] There's a great function for cancelling it, but nothing ever bloody calls it [17:19:05] hah! the spinner is being removed before the handlers are initialized [17:19:10] we can just move that [17:19:12] Oh, hrmph [17:19:15] Good call [17:20:30] I'll WIP this browser test patch that I'm screwing with and run to add a call to cancel position tracking in the upload step's moveFrom [17:20:45] (03PS3) 10MarkTraceur: WIP Add browser test for "copy file metadata" feature [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/190511 (https://phabricator.wikimedia.org/T89356) [17:20:50] (03CR) 10jenkins-bot: [V: 04-1] WIP Add browser test for "copy file metadata" feature [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/190511 (https://phabricator.wikimedia.org/T89356) (owner: 10MarkTraceur) [17:21:12] Oh, it doesn't even have one yet, super [17:22:49] It is *so much nicer* to just have a framework that makes sense and change things within it [17:24:47] chrismcmahon: I'm allergic to sleeps, there's always a way :) [17:25:06] the way is often long and painful, though [17:25:27] gi11es: I don't like them either. Thanks for considering changing the design of the app being tested. :-) [17:26:09] it's a last resort, but here it seems straightforward enough [17:26:16] really, truly needing a sleep() is almost always a sign of something screwy in the underlying design. [17:26:35] yeah, something is happening with no user notification that it's the case [17:33:01] marktraceur: meeting time [17:33:05] Yeah, omv [17:33:07] omw [17:42:57] https://phabricator.wikimedia.org/tag/%C2%A7multimedia-sprint-2015-02-18/ [17:44:28] 3§Multimedia-Sprint-2015-02-18, Multimedia, MediaWiki-extensions-MultimediaViewer: Performance logging graphs suffer tiny sample size starting feb 12th - https://phabricator.wikimedia.org/T89814#1047111 (10Gilles) [17:45:04] 3§Multimedia-Sprint-2015-02-18, MediaWiki-extensions-UploadWizard, Multimedia: Refactor and fix the move-to-cover method on UploadWizardUploadInterfaces - https://phabricator.wikimedia.org/T89855#1047116 (10MarkTraceur) 3NEW a:3MarkTraceur [17:45:29] 3§Multimedia-Sprint-2015-02-18, MediaWiki-extensions-UploadWizard, Multimedia: Refactor and fix the move-to-cover method on UploadWizardUploadInterfaces - https://phabricator.wikimedia.org/T89855#1047125 (10MarkTraceur) [17:45:37] 3§Multimedia-Sprint-2015-02-18, MediaWiki-extensions-UploadWizard, Multimedia: Refactor and fix the move-to-cover method on UploadWizardUploadInterfaces - https://phabricator.wikimedia.org/T89855#1047116 (10MarkTraceur) [17:52:36] 3§Multimedia-Sprint-2015-02-18, Multimedia, MediaWiki-extensions-MultimediaViewer: MediaViewer sometimes sets wrong aspect ratio in IE 11 / Win7 - https://phabricator.wikimedia.org/T89679#1047143 (10Tgr) a:3Tgr [17:52:45] 3§Multimedia-Sprint-2015-02-18, Multimedia, MediaWiki-extensions-MultimediaViewer: MediaViewer crops bottom of images - https://phabricator.wikimedia.org/T89631#1047144 (10Tgr) a:3Tgr [18:15:53] tgr, gi11es, anything important for SoS? I haven't been in a while [18:21:13] marktraceur: Sentry is still an interdependency with JS core and with ops and/or releng, but not blocked ATM; Krinkle has been doing reviews and greg-g said he'll think about ops support [18:21:56] * greg-g nods [18:23:48] marktraceur, gi11es: current firefox/chrome complain loudly about sync AJAX calls on the console, if you don't see that it's probably something else [18:26:09] Yeah, I think it's just the polling for moving the file input [18:26:12] Which is stupid [18:27:06] It got called 276 times in 7 seconds between the deed and describe steps, something is wrong [18:27:23] Unless I'm reading the report wron [18:27:24] g. [18:28:22] Or maybe it's the click handler, not sure [18:28:27] I'll look at both [18:29:29] gi11es: chrismcmahon: is there a task for the 1 sec sleep issue? [18:33:04] tgr: not that I know of [18:33:08] maybe? [18:35:36] chrismcmahon: would you like to make one? :) [18:36:12] it's hard to figure out what's going on just from passing references [18:36:26] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard does not handle invalid names - https://phabricator.wikimedia.org/T89792#1047261 (10Tgr) Right click on view file and select save. (T87083) [18:37:11] is it related to / same as https://phabricator.wikimedia.org/T86770 ? [19:10:14] 3Multimedia: Show warning about privacy/security issues on PDF file pages - https://phabricator.wikimedia.org/T89765#1047367 (10Tgr) T89745 has some details but in general there doesn't seem to be any library claiming to reliably identify such files, just various experimental tools / research projects. There are... [19:17:32] 3Multimedia, MediaWiki-extensions-GWToolset, Beta-Cluster: Creating directory with special characters - https://phabricator.wikimedia.org/T75725#1047421 (10Tgr) https://phabricator.wikimedia.org/project/sprint/profile/1015/ has a nice priority/expected arrival chart, I wonder if it would make sense to do somethi... [19:18:41] 3Multimedia, MediaWiki-extensions-GWToolset, Beta-Cluster: Creating directory with special characters - https://phabricator.wikimedia.org/T75725#1047428 (10Tgr) As a workaround, you can try to register another user for this, although as Jean-Fred said, GWT does not seem to have any problem with `é` in usernames. [19:18:53] Should really go get lunch... [19:58:25] 3MediaWiki-extensions-UploadWizard, Multimedia: Fatal error: Call to a member function inNamespace() on a non-object in CampaignHooks.php on line 174 - https://phabricator.wikimedia.org/T62051#1047593 (10Chad) [19:58:58] 3MediaWiki-File-management, Multimedia: Duplicate-archive files not detected (previously deleted files when uploading identical [SHA1] files) when file extension is upper case - https://phabricator.wikimedia.org/T74070#1047600 (10Umherirrender) 5Open>3Resolved Fix will be part of MediaWiki1.25wmf19, see http... [20:00:52] 3Multimedia, MediaWiki-extensions-MultimediaViewer: MediaViewer should have special handling for images which link to other images - https://phabricator.wikimedia.org/T75902#1047626 (10Tgr) Thumbnail syntax is horribly complicated already, both in terms of specification and parsing code. I would definitely not w... [20:05:07] 3§Multimedia-Sprint-2015-02-18, Analytics, Multimedia, MediaWiki-extensions-MultimediaViewer: Get rid of artifical click delay in MediaViewer - https://phabricator.wikimedia.org/T89533#1047695 (10Tgr) [20:06:58] 3MediaWiki-extensions-GlobalUsage, Multimedia: Lock wait timeout exceeded in GlobalUsage::insertLinks - https://phabricator.wikimedia.org/T30600#1047732 (10Chad) [20:45:15] (03PS1) 10Chad: CampaignHooks: protect against OutputPage not having a title [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191404 (https://phabricator.wikimedia.org/T62051) [20:54:22] (03CR) 10Alex Monk: [C: 032] CampaignHooks: protect against OutputPage not having a title [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191404 (https://phabricator.wikimedia.org/T62051) (owner: 10Chad) [20:55:06] (03Merged) 10jenkins-bot: CampaignHooks: protect against OutputPage not having a title [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191404 (https://phabricator.wikimedia.org/T62051) (owner: 10Chad) [21:37:11] 3MediaWiki-extensions-UploadWizard, Multimedia: Fatal error: Call to a member function inNamespace() on a non-object in CampaignHooks.php on line 174 - https://phabricator.wikimedia.org/T62051#1048141 (10Krenair) 5Open>3Resolved a:3Krenair Should work fine now. [21:37:35] 3MediaWiki-extensions-UploadWizard, Multimedia: Fatal error: Call to a member function inNamespace() on a non-object in CampaignHooks.php on line 174 - https://phabricator.wikimedia.org/T62051#1048146 (10Krenair) a:5Krenair>3Chad [23:05:25] 3Multimedia, MediaWiki-extensions-MultimediaViewer: MediaViewer should have special handling for images which link to other images - https://phabricator.wikimedia.org/T75902#1048370 (10Edokter) You wouldn't have to expand anything (except perhaps as alias for `|link=`); it would only be there for MediaViewer to... [23:08:12] 3Multimedia, MediaWiki-extensions-MultimediaViewer: MediaViewer should have special handling for images which link to other images - https://phabricator.wikimedia.org/T75902#1048375 (10Tgr) MediaViewer parses the HTML, not the wikitext. [23:25:20] 3MediaWiki-extensions-UploadWizard, Multimedia: UploadWizard preview file is not resized - https://phabricator.wikimedia.org/T89908#1048454 (10Tgr) 3NEW [23:44:59] (03PS5) 10Gergő Tisza: Browser test for chunked uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/191246 (https://phabricator.wikimedia.org/T89289)