[00:12:45] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Uploading: Upload errors (through all ways) at Wikimedia Commons - https://phabricator.wikimedia.org/T92790#1120369 (10Rillke) 3NEW [00:48:42] did that connection timeout patch get merged yet ? [00:50:28] Unknown error: "unknown" [01:05:55] thedj: I'm not sure, do you know which changeset or task that would be? [03:22:07] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Uploading: Upload errors (through all ways) at Wikimedia Commons - https://phabricator.wikimedia.org/T92790#1120496 (10Tgr) I tried to upload a 2MB file on a mobile connection and it worked; more detailed description / reproduction steps would... [04:37:02] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Uploading: Upload errors (through all ways) at Wikimedia Commons - https://phabricator.wikimedia.org/T92790#1120569 (10Tgr) As far as I can see with some grepping, the only thing that can produce this exact message is an API error with the err... [04:47:57] thedj: it did not [05:21:43] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Problems with UploadWizard - https://phabricator.wikimedia.org/T92734#1120621 (10Tgr) > Sometimes, when the window for selecting files opens, none of the thumbnails of the files are displayed. That window is handled by the OS, so it's unlikely we c... [05:23:20] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: UploadWizard does not preserve the order of the images between upload and later steps - https://phabricator.wikimedia.org/T92801#1120622 (10Tgr) 3NEW [05:24:30] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Problems with UploadWizard - https://phabricator.wikimedia.org/T92734#1120632 (10Tgr) 5Open>3Invalid a:3Tgr I moved file ordering to T92801, preview problems are duplicate, file open dialog issues are invalid - closing this ticket. [07:35:42] Morning. I'd appreciate if someone could comment on https://commons.wikimedia.org/wiki/Commons:Village_pump#Upload_Wizard_getting_worse_and_worse to sort out the user's UW problems a bit [08:15:03] (03PS1) 10Gilles: Fix comment incorrectly referencing bugzilla [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/197004 [08:16:01] (03CR) 10Gilles: Update links to issue tracker (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/183883 (https://phabricator.wikimedia.org/T86315) (owner: 10Aklapper) [08:23:05] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Problems with UploadWizard - https://phabricator.wikimedia.org/T92734#1120739 (10Jacklee) What are indexing settings? [08:30:50] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: UploadWizard does not preserve the order of the images between upload and later steps - https://phabricator.wikimedia.org/T92801#1120743 (10Gilles) If I remember correctly, they currently end up ordered on the describe step by how soon each upload e... [08:32:48] 6Multimedia, 10MediaWiki-extensions-UploadWizard: "Maximum number of concurrent upload" isn't respected - https://phabricator.wikimedia.org/T92809#1120744 (10Gilles) 3NEW [08:37:10] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Failure on "Download menu.Attribution area can be closed" browser test - https://phabricator.wikimedia.org/T92810#1120752 (10Gilles) 3NEW [09:01:27] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Failure on "Download menu.Attribution area can be closed" browser test - https://phabricator.wikimedia.org/T92810#1120764 (10Gilles) I can reproduce the issue on saucelabs with Linux Chrome. The download menu never comes up. I can't reproduce the issue loca... [10:05:19] 6Multimedia, 10MediaWiki-extensions-WikibaseRepository, 10Structured-Multimedia-Data, 10Wikidata, 7Tracking: user interface for structured data on Commons - https://phabricator.wikimedia.org/T76016#1120912 (10Lydia_Pintscher) [10:32:33] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Wrong Image Link - https://phabricator.wikimedia.org/T92816#1120975 (10Asuslike) 3NEW [11:02:15] 6Multimedia, 6Commons, 10Structured-Multimedia-Data, 10Wikidata, and 2 others: Store media information for files on Wikimedia Commons as structured data - https://phabricator.wikimedia.org/T68108#1121066 (10Steinsplitter) [11:09:38] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Uploading: Upload errors (through all ways) at Wikimedia Commons - https://phabricator.wikimedia.org/T92790#1121080 (10Rillke) 5Open>3stalled >>! In T92790#1120569, @Tgr wrote: > And they wouldn't effect `Special:Upload` anyway.) Users re... [11:41:03] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Wrong Image Link - https://phabricator.wikimedia.org/T92816#1121161 (10Gilles) Hi, could you provide a link to the image? [11:43:32] (03CR) 10Ricordisamoa: [C: 031] Fix comment incorrectly referencing bugzilla (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/197004 (owner: 10Gilles) [11:49:48] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Wrong Image Link - https://phabricator.wikimedia.org/T92816#1121166 (10Asuslike) Ok, i think is fixed now, don't know why it does not show up 20 minutes ago, it was that article: http://it.wikipedia.org/wiki/Open_Systems_Interconnection Referring to that im... [11:50:01] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Wrong Image Link - https://phabricator.wikimedia.org/T92816#1121167 (10Asuslike) 5Open>3Resolved a:3Asuslike [11:55:29] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Failure on "Download menu.Attribution area can be closed" browser test - https://phabricator.wikimedia.org/T92810#1121170 (10Gilles) So far it resembles an issue that I thought had been fixed by pointing to the newer version of Chrome. The tooltip for the d... [11:55:37] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 3Multimedia-Sprint-2015-03-11: Failure on "Download menu.Attribution area can be closed" browser test - https://phabricator.wikimedia.org/T92810#1121171 (10Gilles) [11:55:43] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 3Multimedia-Sprint-2015-03-11: Failure on "Download menu.Attribution area can be closed" browser test - https://phabricator.wikimedia.org/T92810#1121172 (10Gilles) a:3Gilles [11:55:48] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 3Multimedia-Sprint-2015-03-11: Failure on "Download menu.Attribution area can be closed" browser test - https://phabricator.wikimedia.org/T92810#1120752 (10Gilles) p:5Triage>3Low [12:00:27] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Wrong Image Link - https://phabricator.wikimedia.org/T92816#1121176 (10Gilles) The data you see in Media Viewer is cached server-side, so when you update the metadata on the file page, it can take a bit of time for it to propagate (i.e. Media Viewer will ke... [12:02:21] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Wrong Image Link - https://phabricator.wikimedia.org/T92816#1121178 (10Asuslike) Ok, now it's clear! Thanks for answering! [12:04:54] marktraceur: do you have any thought on the guy who asked on our ML how to neutralise parts of UW, like the license picking? [12:05:22] since you're trying to make things as decouple as possible right now, it would be good to know how difficult it would be to patch UW into behaving like he wants [12:05:36] it should be easier now than it used to be, but I'm not sure how hard it still is [12:08:54] (03CR) 10Gilles: [C: 04-1] "Just stopped at the first big question I found, this isn't a thorough review" (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://phabricator.wikimedia.org/T74675) (owner: 10TheDJ) [12:25:42] (03CR) 10Gilles: [C: 032] "Nice work!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/193485 (https://phabricator.wikimedia.org/T90771) (owner: 10MarkTraceur) [12:26:56] (03Merged) 10jenkins-bot: Move detailsErrorCount to details step UI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/193485 (https://phabricator.wikimedia.org/T90771) (owner: 10MarkTraceur) [12:44:57] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Problems with UploadWizard - https://phabricator.wikimedia.org/T92734#1121240 (10Aklapper) >>! In T92734#1120739, @Jacklee wrote: > What are indexing settings? This refers to any settings whether to create and show thumbnails in your operating syst... [13:08:10] (03CR) 10Gilles: [C: 032] Move the rest of detailsSubmit to the controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/194953 (https://phabricator.wikimedia.org/T90771) (owner: 10MarkTraceur) [13:08:53] (03Merged) 10jenkins-bot: Move the rest of detailsSubmit to the controller [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/194953 (https://phabricator.wikimedia.org/T90771) (owner: 10MarkTraceur) [13:09:26] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 3Multimedia-Sprint-2015-03-11, 5Patch-For-Review: Move details-related methods on mw.UploadWizard.prototype to the details step - https://phabricator.wikimedia.org/T90771#1121254 (10Gilles) Is there more to do, or should this be moved to "ready for testing"? [14:30:55] gi11es: Looking... [14:34:51] gi11es: I guess he could just replace the license array with a single license that's auto-chosen. [14:34:56] But it doesn't "skip" it. [14:35:12] Giving somebody that power is actually probably not too hard - it would be hacky at first but you could do it. [14:35:41] At least for licenses. Skipping the tutorial is also trivial, but skipping the describe step would be hard. [14:35:54] You could also skip the "thanks" step and dump the user right back in "upload". [14:36:08] (I wouldn't recommend adding a config option for skipping the upload step.) [14:37:28] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Problems with UploadWizard - https://phabricator.wikimedia.org/T92734#1121421 (10Jacklee) Thanks. Is it really a problem with the browser, though? I only seem to get that problem when using the UploadWizard. [14:39:14] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: UploadWizard does not preserve the order of the images between upload and later steps - https://phabricator.wikimedia.org/T92801#1121423 (10Jacklee) I tried altering concurrent uploads to 1 but that doesn't seem to help in getting files to upload in... [14:52:36] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Problems with UploadWizard - https://phabricator.wikimedia.org/T92734#1121453 (10Tgr) >>! In T92734#1121421, @Jacklee wrote: > Thanks. Is it really a problem with the browser, though? I only seem to get that problem when using the UploadWizard. Wit... [14:59:42] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Wrong Image Link - https://phabricator.wikimedia.org/T92816#1121468 (10Tgr) We removed internal caching from the API (or to be more precise we automatically purge it when needed). We still cache API requests in Varnish and in the browser for 24 hours, and a... [15:31:48] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Uploading: Upload errors (through all ways) at Wikimedia Commons - https://phabricator.wikimedia.org/T92790#1121578 (10Rillke) 5stalled>3Open > Yes, I still have the problem. I also tried Special:Upload but after the same amount of time (c... [16:25:49] gi11es: good call on the embed behavior btw. I had tested that before, but failed to realise that it was working because it linked to commons, due to instantcommons :) [16:49:44] 6Multimedia, 6operations: Add monitoring of upload rate on commons to icingia alerts - https://phabricator.wikimedia.org/T92322#1121882 (10fgiunchedi) is the number of uploads already in graphite somewhere? that'd make creating the alarm very easy. [18:34:16] 6Multimedia, 6operations: Add monitoring of upload rate on commons to icingia alerts - https://phabricator.wikimedia.org/T92322#1122382 (10Tgr) In theory, all hooks and API requests are logged to graphite; [[ https://www.mediawiki.org/wiki/Manual:Hooks/FileUpload | FileUpload ]] and [[ https://www.mediawiki.or... [18:47:18] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Uploading: Upload errors (through all ways) at Wikimedia Commons - https://phabricator.wikimedia.org/T92790#1122464 (10Tgr) >>! In T92790#1121578, @Rillke wrote: > I was unable to reproduce it. Is it possible that there is a mis-configured pro... [19:10:26] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Uploading: Upload errors (through all ways) at Wikimedia Commons - https://phabricator.wikimedia.org/T92790#1122532 (10Rillke) > To make sure that the problem isn't on my side (router, virus software etc) I uploaded the same file to a Coppermi... [19:38:14] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Uploading: Upload errors (through all ways) at Wikimedia Commons - https://phabricator.wikimedia.org/T92790#1122703 (10Tgr) >>! In T92790#1122532, @Rillke wrote: > What should I suggest them to retrieve the HTTP status code from Special:Upload... [19:46:18] O.O this handler/transport business is going to be big. [19:47:06] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Uploading: Upload errors (through all ways) at Wikimedia Commons - https://phabricator.wikimedia.org/T92790#1122747 (10Tgr) I uploaded a 2MB file, throttling the speed with [[ http://www.charlesproxy.com/ | Charles ]] for the first 10 min, and... [19:49:23] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Uploading: Upload errors (through all ways) at Wikimedia Commons - https://phabricator.wikimedia.org/T92790#1122765 (10Tgr) At any rate, these are probably two different errors - I doubt the unknown API error is caused by the same issue as the... [20:45:17] (03CR) 10TheDJ: Improve live loading and ResourceLoader behavior (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://phabricator.wikimedia.org/T74675) (owner: 10TheDJ) [21:08:38] 6Multimedia, 10MediaWiki-File-management, 7Technical-Debt: Return status from streamFile - https://phabricator.wikimedia.org/T92903#1123152 (10Tgr) 3NEW [21:21:33] Strict Standards: Declaration of OggHandlerTMH::formatMetadata() should be compatible with MediaHandler::formatMetadata($image, $context = false) [21:23:53] ah i see there was a change by umherirender [21:26:45] hi there, multimedia folks [21:27:18] i've got a question about the data-file-height, data-file-width attributes in the HTML [21:27:42] when are they added? do they end up being cached with the rest of the PHP-generated HTML for the page? [21:28:01] and if they are cached, how do they get updated if/when the referenced image changes? [21:28:08] (03PS1) 10TheDJ: Pass context to FormatMetadata class on ImagePage [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/197211 [21:30:17] marktraceur etc: ^ see above questions :) [21:31:18] this is in the context of https://phabricator.wikimedia.org/T64881 where we (parsoid) are trying to figure out how to represent that info .. and what the implications are [21:32:17] cscott: it looks like MultimediaViewer ext adds these on via a hook, and they should get saved with the parser cache output if i understand correctly [21:32:46] which I presume means that it is 'eventually consistent', ergo, after job queue is done [21:32:54] so invalidation should be the same as for the ‘width’/‘height’ attributes etc, not sure what the situation is eactly [21:32:57] brion, but if the original image is changed, does the cached html get invalidated / purged? [21:33:06] yeah i’m less certain on that [21:33:21] it *should* but i don’t know for a fact offhand [21:33:46] brb [21:34:09] "etc" actually does not hilight :) [21:34:54] they are added via the ThumbnailBeforeProduceHTML hook [21:36:02] (03PS15) 10TheDJ: Improve live loading and ResourceLoader behavior [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://phabricator.wikimedia.org/T74675) [21:37:18] if the image size changes, the page is invalidated, because MediaWiki needs to insert width/height HTML attributes in the img tag [21:38:05] tgr: ok, that makes sense. [21:38:12] I would guess the page is invalidated if any image on it changes, even if it happens to have the same dimensions, but never actually checked that [21:38:54] same aspect ratio, I mean, the original dimensions of course don't matter for a thumbnail [21:40:03] also as far as I know there are plans to replace file names with sha1 hashes generated from (unscaled) file content eventually, if that happens, the page needs to be invalidated on every upload anyway [21:40:16] aaron can tell more about that [21:43:21] cscott: note that displaying an image without making an imageinfo API call is tricky business even if you know the original size [21:43:53] yes, but parsoid handles much of that already. [21:44:10] MediaViewer still messes up EXIF rotations for example: https://phabricator.wikimedia.org/T70320 [21:44:15] but feel free to convince the VE folks that https://phabricator.wikimedia.org/T64881 is a bad idea :) [21:45:18] it's a good idea, just harder than it looks [21:45:33] MediaViewer injects those attributes for the same reason [21:46:55] an extra API call to fetch the URL adds around 0.5 sec to image display time, needs to be cached differently, an outdated cache gets really messy - it's a significant performance improvement if you can get rid of it [21:47:35] imo parsoid’s direct output should be very generic, only specifying the given filename and parameters for the image [21:47:50] any actual sizing and generation of ,