[00:06:33] (03PS1) 10Bartosz Dziewoński: Recover from 'badtoken' error when uploading [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208044 (https://phabricator.wikimedia.org/T71691) [00:06:36] (03CR) 10jenkins-bot: [V: 04-1] Recover from 'badtoken' error when uploading [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208044 (https://phabricator.wikimedia.org/T71691) (owner: 10Bartosz Dziewoński) [00:11:05] (03CR) 10Bartosz Dziewoński: "The "Add more files" button (mwe-upwiz-add-file-n) is now not being shown for some reason, after uploading a file." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187238 (owner: 10MarkTraceur) [00:22:09] (03CR) 10Jforrester: [C: 031] Remove incredibly weird message override for 'mwe-upwiz-code-unknown' [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208016 (owner: 10Bartosz Dziewoński) [04:32:42] 6Multimedia, 10MediaWiki-API: API does not fail gracefully when data is too large to display - https://phabricator.wikimedia.org/T86611#1251373 (10Magog_the_Ogre) Anomie et al.: I'm very sorry. I've been sloppy and turned this bug report into a mess. Any chance we can go back to looking at just the infinite l... [12:50:40] James_F|Away: Geez, no pressure indeed. [14:13:25] 6Multimedia, 10MediaWiki-extensions-CommonsMetadata: When using UploadWizard, - https://phabricator.wikimedia.org/T97770#1251848 (10Smuconlaw) 3NEW [14:13:52] (03Abandoned) 10MarkTraceur: WIP: Pulling init stuff into lightweight module [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/110599 (owner: 10MarkTraceur) [14:14:22] (03Abandoned) 10MarkTraceur: WIP Better module management [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/121310 (owner: 10MarkTraceur) [14:14:42] (03Abandoned) 10MarkTraceur: WIP fix share tabs' select events [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/123833 (owner: 10MarkTraceur) [14:14:58] 6Multimedia, 10MediaWiki-extensions-CommonsMetadata: When using UploadWizard, thumbnails fail to appear or files are missing on the "Release rights" webpage - https://phabricator.wikimedia.org/T97770#1251856 (10Smuconlaw) [14:16:42] (03CR) 10MarkTraceur: "For posterity:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/129548 (owner: 10MarkTraceur) [14:17:16] (03Abandoned) 10MarkTraceur: Add events for upload page [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/84213 (owner: 10MarkTraceur) [14:18:23] 6Multimedia, 10MediaWiki-extensions-CommonsMetadata: When using UploadWizard, thumbnails fail to appear or files are missing on the "Release rights" webpage - https://phabricator.wikimedia.org/T97770#1251860 (10Smuconlaw) [14:18:42] (03Abandoned) 10MarkTraceur: Clean up the jsduck docs after first two patches [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/70919 (https://bugzilla.wikimedia.org/49989) (owner: 10MarkTraceur) [14:18:53] (03Abandoned) 10MarkTraceur: Add UWUI to the jsduck docs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/70925 (https://bugzilla.wikimedia.org/49989) (owner: 10MarkTraceur) [14:19:12] (03Abandoned) 10MarkTraceur: (bug 37302) Only fire startUploads once, after all files are ready [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/22047 (owner: 10MarkTraceur) [14:19:33] (03Abandoned) 10MarkTraceur: Add "remove file" in the details step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/9549 (https://bugzilla.wikimedia.org/32247) (owner: 10MarkTraceur) [14:19:50] (03Abandoned) 10MarkTraceur: WIP Remove jquery.hashchange, add hasher [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/134954 (owner: 10MarkTraceur) [14:20:29] (03CR) 10MarkTraceur: [C: 04-1] "Similar to parent commit, I will not abandon this, but it's not ready for primetime, and I'm not able to maintain it now." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/140760 (owner: 10MarkTraceur) [14:20:46] (03Abandoned) 10MarkTraceur: Massive refactor [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/68835 (https://bugzilla.wikimedia.org/39746) (owner: 10MarkTraceur) [14:21:31] (03Abandoned) 10MarkTraceur: WIP add deed events [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/157854 (owner: 10MarkTraceur) [14:24:22] 6Multimedia, 10MediaWiki-extensions-CommonsMetadata: When using UploadWizard, thumbnails fail to appear or files are missing on the "Release rights" webpage - https://phabricator.wikimedia.org/T97770#1251863 (10Smuconlaw) I just retried the uploading process, and one of the files failed to upload with the erro... [15:04:47] marktraceur: Abandoning all the things? :-( [15:06:59] 6Multimedia, 10MediaWiki-extensions-CommonsMetadata: When using UploadWizard, thumbnails fail to appear or files are missing on the "Release rights" webpage - https://phabricator.wikimedia.org/T97770#1251944 (10Smuconlaw) This is what the Web console recorded on one failed attempt: Image corrupt or truncated:... [15:07:24] James_F: i made him. i'm evil that way. [15:08:00] James_F: why do we have two slightly different magnifying glass icons in OOUI? :( [15:08:38] MatmaRex: Because at least one of them isn't very good. [15:08:57] MatmaRex: And replacing the existing one with a much much bigger one was a disruptive breaking change I didn't think made sense. [15:09:27] yeah, but we replaced and added all the other icons and that one is now positively tiny. [15:10:17] i spent some time yesterday redrawing it https://gerrit.wikimedia.org/r/#/c/208062/ having no idea we have a dupe [15:21:33] It was originally an indicator. [15:21:42] Back when we didn't split them. [15:21:53] It then didn't get moved when we split them, I think. [16:03:45] (03PS4) 10MarkTraceur: [Very WIP] Only use one file input, use Upload objects to represent upload process [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/192809 (https://phabricator.wikimedia.org/T96916) [16:03:47] I'm pausing this one. [16:03:50] It's too complex. [16:04:19] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Move the interface for adding new files to a new UI class and refactor things around it - https://phabricator.wikimedia.org/T89855#1252128 (10MarkTraceur) a:5MarkTraceur>3None I'm pausing this task, as I've been stuck on it for some time. I'll come back to... [16:04:40] (03CR) 10jenkins-bot: [V: 04-1] [Very WIP] Only use one file input, use Upload objects to represent upload process [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/192809 (https://phabricator.wikimedia.org/T96916) (owner: 10MarkTraceur) [16:07:25] marktraceur: You just can't handle the truth! [16:08:50] James_F: Hrm? [16:15:30] marktraceur: Never mind. [16:15:34] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Make setUploadFilled into an event from UWUI, do things in UWU and UW - https://phabricator.wikimedia.org/T289#1252151 (10MarkTraceur) 5Open>3Invalid a:3MarkTraceur Duplicate of T93888 [16:15:37] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Refactor UploadWizard to be maintainable - https://phabricator.wikimedia.org/T96906#1252154 (10MarkTraceur) [16:20:07] (03PS3) 10MarkTraceur: Move setUploadFilled into the file step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/199749 (https://phabricator.wikimedia.org/T93888) [16:20:52] (03CR) 10jenkins-bot: [V: 04-1] Move setUploadFilled into the file step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/199749 (https://phabricator.wikimedia.org/T93888) (owner: 10MarkTraceur) [16:21:00] ...hm [16:33:31] marktraceur: i looked at https://gerrit.wikimedia.org/r/205719 . i think we should try to make it look more like the "VForm" design. that's what we were generally using for OOUI interfaces, in the demo and in VE. [16:34:09] marktraceur: for comparison, i tried to enable that for Special:PasswordReset. before: http://i.imgur.com/ibRdVVO.png after: http://i.imgur.com/NB9P3gh.png [16:34:14] marktraceur: mind if i amend? [16:34:49] Errrm [16:34:51] MatmaRex: Sure! [16:43:59] (03PS4) 10MarkTraceur: Move setUploadFilled into the file step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/199749 (https://phabricator.wikimedia.org/T93888) [18:30:47] (03PS18) 10MarkTraceur: Use promises for getting image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 (https://phabricator.wikimedia.org/T51988) [20:16:57] (03PS1) 10MarkTraceur: Add 'default' environment for browser tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208265 [20:17:00] marxarelli: ^^ [20:19:08] (03CR) 10Dduvall: [C: 031] "That should work." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208265 (owner: 10MarkTraceur) [20:22:38] marxarelli: You have leave to +2... [20:23:07] (03CR) 10Dduvall: [C: 032] Add 'default' environment for browser tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208265 (owner: 10MarkTraceur) [20:23:22] blam-o [20:23:50] thanks! [20:24:41] (03Merged) 10jenkins-bot: Add 'default' environment for browser tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208265 (owner: 10MarkTraceur) [20:24:52] (03PS19) 10MarkTraceur: Use promises for getting image info [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/146604 (https://phabricator.wikimedia.org/T51988) [22:13:32] marktraceur: i poked at your OOUI for HTMLForm patch. https://gerrit.wikimedia.org/r/205719 [22:14:33] marktraceur: i ended up touching a bunch of stuff, so i expect a full ruthless review from you. i am not quite done yet, too. ;) [22:14:45] aw shoot, i accidentally rebased it. let me un-rebase [22:16:44] OK then! [22:18:53] marktraceur: https://gerrit.wikimedia.org/r/#/c/205719/3..5 [22:19:13] marktraceur: nice for testing: https://gerrit.wikimedia.org/r/#/c/208285/ [22:19:41] MatmaRex: :-) [22:30:45] Noted, thanks :) [22:53:10] 6Multimedia, 10MediaWiki-DjVu, 10MediaWiki-General-or-Unknown, 10incident-20150423-Commons, and 2 others: img_metadata queries for Djvu files regularly saturate s4 slaves - https://phabricator.wikimedia.org/T96360#1253752 (10faidon) This has been happening over and over again for all this time (happened ju... [23:07:15] marktraceur: discovered and rediscovered a couple of OOUI bugs, added blockers to https://phabricator.wikimedia.org/T85291 . i'll try to get them fixed before monday, and then bug James_F|Away to do a OOUI point release [23:08:21] MatmaRex: K, fun [23:08:40] I may not be available this weekend very much, hopefully I can help with code review or whatever on Monday [23:09:01] sure. wouldn't ask you to do stuff over weekend [23:09:09] it's just me having a weird week schedule [23:13:36] We've all been there :) [23:33:48] 6Multimedia, 10MediaWiki-DjVu, 10MediaWiki-General-or-Unknown, 10incident-20150423-Commons, and 2 others: img_metadata queries for Djvu files regularly saturate s4 slaves - https://phabricator.wikimedia.org/T96360#1253818 (10aaron) It probably just hits < $this->pageCount( $image ) )>> and loa...