[04:11:08] 6Multimedia, 10MediaWiki-extensions-PdfHandler, 5WMF-deploy-2015-05-06_(1.26wmf5): Convert PdfHandler to use extension registration - https://phabricator.wikimedia.org/T87957#1259743 (10Ricordisamoa) [10:46:36] (03CR) 10Gilles: [C: 032] Conversion to using WAN cache [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/207897 (https://phabricator.wikimedia.org/T93141) (owner: 10Aaron Schulz) [10:47:33] (03Merged) 10jenkins-bot: Conversion to using WAN cache [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/207897 (https://phabricator.wikimedia.org/T93141) (owner: 10Aaron Schulz) [10:58:35] (03PS1) 10Prtksxna: mwCoolCats: Use action=opensearch instead of getCategoriesByPrefix() [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208932 (https://phabricator.wikimedia.org/T40785) [10:59:59] (03CR) 10jenkins-bot: [V: 04-1] mwCoolCats: Use action=opensearch instead of getCategoriesByPrefix() [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208932 (https://phabricator.wikimedia.org/T40785) (owner: 10Prtksxna) [11:03:28] (03PS2) 10Prtksxna: mwCoolCats: Use action=opensearch instead of getCategoriesByPrefix() [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208932 (https://phabricator.wikimedia.org/T40785) [11:08:11] (03CR) 10Bartosz Dziewoński: "It can not possibly be. Seriously." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208016 (owner: 10Bartosz Dziewoński) [11:08:16] (03PS2) 10Bartosz Dziewoński: Remove incredibly weird message override for 'mwe-upwiz-code-unknown' [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208016 [11:09:17] (03CR) 10Bartosz Dziewoński: [C: 032] "Please work this time." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208016 (owner: 10Bartosz Dziewoński) [11:09:39] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Better category tools - https://phabricator.wikimedia.org/T77561#1260144 (10Prtksxna) Details? Was this discussed elsewhere? [11:11:18] (03Merged) 10jenkins-bot: Remove incredibly weird message override for 'mwe-upwiz-code-unknown' [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208016 (owner: 10Bartosz Dziewoński) [11:11:56] (03CR) 10Bartosz Dziewoński: "THERE. The issue with tests might be worth tracking down, since it happened on some other commits too." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208016 (owner: 10Bartosz Dziewoński) [11:16:23] 6Multimedia, 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-UploadWizard: UploadWizard mwext-qunit job bogus failures: "mw.fileApi isPreviewableFile FAILED: afterEach failed on isPreviewableFile: Unfinished AJAX requests: 1" - https://phabricator.wikimedia.org/T98130#1260165 (10matmarex) 3N... [11:17:20] (03PS2) 10Bartosz Dziewoński: Remove some dead code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208009 [11:17:40] (03CR) 10Bartosz Dziewoński: [C: 032] "Looks bogus to me. Filed T98130" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208009 (owner: 10Bartosz Dziewoński) [11:17:47] (03CR) 10Bartosz Dziewoński: "T98130" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208016 (owner: 10Bartosz Dziewoński) [11:18:40] (03Merged) 10jenkins-bot: Remove some dead code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208009 (owner: 10Bartosz Dziewoński) [11:32:19] 6Multimedia, 10VisualEditor: VisualEditor doesn't handle paragraph breaks in image captions editor correctly - https://phabricator.wikimedia.org/T98132#1260191 (10Amire80) 3NEW [11:41:13] MatmaRex: How are we doing the transition to OOjs UI? Is it going to be one big patch? Should I start replacing small things like buttons and textboxes already? [11:42:33] prtksxna: looks like we're starting with small steps, yeah. marktraceur actually submitted some patches already [11:42:43] https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/UploadWizard,n,z [11:43:45] prtksxna: we'll also need to deal with Jon's https://gerrit.wikimedia.org/r/206493 , which transitions stuff to HTML templates instead [11:43:47] Sweet :) [11:44:13] MatmaRex: Didn't you decide to leave a comment on that? [11:44:21] right now i'm fixing tests which are accidentally asynchronous and thus fail randomly from time to time [11:44:24] i did leave a comment [11:44:55] i think the changeset was duplicated at some point [11:44:59] or something [11:45:01] hrmph [11:45:56] yep https://gerrit.wikimedia.org/r/#/c/205269/ [11:45:57] (03CR) 10Bartosz Dziewoński: "(Copying my comment from https://gerrit.wikimedia.org/r/#/c/205269/ for posterity:)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/206493 (https://phabricator.wikimedia.org/T96520) (owner: 10Jdlrobson) [11:46:14] (y) [11:46:46] MatmaRex marktraceur: I think I'll work on the design of the select widget tomorrow. [11:46:57] yay [11:47:05] Let me know if you'd rather have me doing something else. [11:47:28] I don't want to jump into design without having a better understanding of what the extension does and how it does it. [11:47:36] I think I'll be ready by the end of this week [11:47:38] marktraceur: ^ [11:48:17] yeah, i also need to get a better graps of uploadwizard. but that'll probably have to wait till next week, i have a bunch of stuff that came up, work-related and not [11:48:47] MatmaRex: Oh, university stuff? [11:49:34] mostly [11:52:51] 6Multimedia, 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-UploadWizard: UploadWizard mwext-qunit job bogus failures: "mw.fileApi isPreviewableFile FAILED: afterEach failed on isPreviewableFile: Unfinished AJAX requests: 1" - https://phabricator.wikimedia.org/T98130#1260242 (10matmarex) I t... [12:06:49] (03PS1) 10Bartosz Dziewoński: mw.FormDataTransport: Make it possible to skip the 3000 ms timeout in tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208938 (https://phabricator.wikimedia.org/T98130) [12:08:39] (03CR) 10jenkins-bot: [V: 04-1] mw.FormDataTransport: Make it possible to skip the 3000 ms timeout in tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208938 (https://phabricator.wikimedia.org/T98130) (owner: 10Bartosz Dziewoński) [12:08:43] 6Multimedia, 10Continuous-Integration-Infrastructure, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: UploadWizard mwext-qunit job bogus failures: "mw.fileApi isPreviewableFile FAILED: afterEach failed on isPreviewableFile: Unfinished AJAX requests: ... - https://phabricator.wikimedia.org/T98130#1260263 [12:09:30] (03CR) 10Bartosz Dziewoński: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208938 (https://phabricator.wikimedia.org/T98130) (owner: 10Bartosz Dziewoński) [12:51:06] (03PS2) 10Bartosz Dziewoński: mw.FormDataTransport: Make it possible to skip the 3000 ms timeout in tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208938 (https://phabricator.wikimedia.org/T98130) [12:51:53] (03CR) 10jenkins-bot: [V: 04-1] mw.FormDataTransport: Make it possible to skip the 3000 ms timeout in tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208938 (https://phabricator.wikimedia.org/T98130) (owner: 10Bartosz Dziewoński) [12:52:06] oh fuck you [12:52:07] i hate this [13:05:42] prtksxna: Sounds fine to me [13:07:02] marktraceur: hey. you wrote these tests, can you tell me what are they trying to assert? [13:07:13] marktraceur: especially the second-to-last case in 'checkStatus' test [13:07:19] (see failing patches above) [13:08:39] * marktraceur checks [13:11:11] marktraceur: [13:11:13] [15:09] i'm only talking about 'checkStatus' test, all others are probably mostly fine [13:11:13] [15:09] while 'checkStatus' is undeniably broken [13:11:13] [15:09] it is not supposed to be async, everything that is normally async is mocked to be sync, except for the setTimeout(…, 3000) [13:11:13] [15:09] when i fix that, it goes into infinite recursion [13:11:13] [15:10] and when i fix *that*, it starts failing assertions [13:11:48] that's how i arrived at wondering wtf do these assertion check [13:11:51] MatmaRex: I guess whether the API calls get set up properly. Maybe we could nix them as being too implementation-specific or fix them to assert something different [13:13:17] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: UploadWizard mwext-qunit job bogus failures: "mw.fileApi isPreviewableFile FAILED: afterEach failed on isPreviewableFile: Unfinished AJAX requests: 1" - https://phabricator.wikimedia.org/T98130#1260387 (10Krinkle) [13:15:47] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: UploadWizard mwext-qunit job bogus failures: "mw.fileApi isPreviewableFile FAILED: afterEach failed on isPreviewableFile: Unfinished AJAX requests: 1" - https://phabricator.wikimedia.org/T98130#1260395 (10Krinkle) At this point this doesn't... [13:17:38] marktraceur: is there a reason https://commons.wikimedia.org/wiki/File:Sintel_movie_4K.webm is not transcoding ? [13:18:52] Probably. [13:19:11] marktraceur: what to shed some light please ? [13:19:16] *want [13:19:33] matanya: Well, first off, I don't know a whole lot about the transcoding process. [13:19:40] So I'm going to need to look at it for a sec. [13:19:44] And probably get some coffee. [13:20:00] so you transcode coffee to code ? :) [13:20:04] Or I could bother someone else if it's not super-urgent [13:20:20] And they would be able to help you without scratching their heads for 15 minutes [13:20:50] no rush, just wondering. bawolff is the right address ? [13:24:33] I was going to ask AaronSchulz, but he's not here either. [13:28:52] marktraceur: see -operations [13:37:06] (03PS3) 10Bartosz Dziewoński: mw.FormDataTransport: Make it possible to skip the 3000 ms timeout in tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208938 (https://phabricator.wikimedia.org/T98130) [13:37:20] hallelujah [13:37:31] sinon is by far the worst JS library i have ever worked with [13:37:42] Really? [13:37:50] the magic method i needed to call to make that work is not even documented anywhere [13:37:59] resetBehavior [13:38:04] Ugh, yeah, it's bad. [13:38:18] to wipe the stuff set by .onFirstCall().returns( postd.promise() ).onSecondCall().returns( postd2.promise() ) [13:38:34] unlike the stuff set by .returns( postd.promise() ); [13:38:47] which, you might think, reset() wipes [13:38:49] but actually not [13:38:55] it is wiped when you call .returns() again [13:39:33] debugging this was a total pain in the butt, because literally everything sinon uses has .toString() overridden, or something [13:39:41] so printing it to console didn't show anything useful [13:39:52] it also apparently iterates over properties of window like, all the time [13:40:06] so every time i looked at the console, i had 500 new deprecation warnings in it [13:40:09] Hahaha [14:29:44] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: UploadWizard mwext-qunit job bogus failures: "mw.fileApi isPreviewableFile FAILED: afterEach failed on isPreviewableFile: Unfinished AJAX requests: 1" - https://phabricator.wikimedia.org/T98130#1260627 (10matmarex) Yeah, it's a mistake in U... [14:33:37] (03PS2) 10Bartosz Dziewoński: Recover from 'badtoken' error when uploading [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208044 (https://phabricator.wikimedia.org/T71691) [14:57:36] 6Multimedia, 10MediaWiki-File-management, 7Upstream: Exif values retrieved incorrectly if they appear before IFD - https://phabricator.wikimedia.org/T97253#1260717 (10Lupo) And what's the upstream bug report? I think every "upstream" issue should have an upstream bug report, and mention it here, too. Perha... [15:08:49] Ugh. [15:11:01] is there a list of people with shell ? [15:33:57] (03PS1) 10Gilles: Explicitly define module position [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/208974 (https://phabricator.wikimedia.org/T97410) [15:34:09] matanya: Yes. Somewhere. [15:34:17] matanya: https://meta.wikimedia.org/wiki/System_administrators maybe [15:57:43] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Ability to recover from an Expired session (badtoken) - https://phabricator.wikimedia.org/T71691#1260839 (10Jdforrester-WMF) p:5Normal>3High [16:11:32] Are there major changes planned for the Commons upload UX? [16:11:43] Keegan ^ [16:12:12] Hi ragesoss. marktraceur, that's for you I believe [16:14:06] ragesoss: "Planned" for what time horizon? [16:14:09] The reason I'm asking is that Wiki Ed is getting ready to order a bunch of our print brochures, to stock up for the next 18 months or so. I think most of the material is likely to still be more-or-less accurate, except for the Illustrating Wikipedia brochure that walks through the Upload Wizard. [16:14:19] Ah. [16:14:21] Yeah… [16:14:22] Hmm. [16:14:42] In 18 months' time we'll have uploading-in-editor and a bunch of things. [16:14:54] (Or my name's not Jimbo Forrester, blah blah blah.) [16:15:06] James_F: and what about in 12 months? 6 months? [16:15:12] best guess is fine. [16:15:19] ragesoss: Probably within 6 months' time. [16:15:43] Also more minor tweaks to UploadWizard are likely. [16:15:55] okay. so, we'll order fewer of that one and plan on reassessing whether it needs to be redesigned later. [16:15:59] thanks James_F. [16:16:07] * James_F nods. [16:16:11] Happy to help. [16:20:00] Uploading in editor, 6 months sounds like a decent estimate. Changes to the actual flow of UW probably won't come until after that, if at all. [16:20:05] Mostly it will stay the same. [16:21:21] thanks much marktraceur. [16:27:14] Of course. [19:18:36] (03CR) 10MarkTraceur: [C: 032] Recover from 'badtoken' error when uploading [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208044 (https://phabricator.wikimedia.org/T71691) (owner: 10Bartosz Dziewoński) [19:19:29] (03Merged) 10jenkins-bot: Recover from 'badtoken' error when uploading [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208044 (https://phabricator.wikimedia.org/T71691) (owner: 10Bartosz Dziewoński) [19:19:57] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Ability to recover from an Expired session (badtoken) - https://phabricator.wikimedia.org/T71691#1262085 (10MarkTraceur) I assume we need one more patch once the blocker is fixed? [19:21:04] (03PS4) 10MarkTraceur: mw.FormDataTransport: Make it possible to skip the 3000 ms timeout in tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208938 (https://phabricator.wikimedia.org/T98130) (owner: 10Bartosz Dziewoński) [19:22:57] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review, 7user-notice: Ability to recover from an Expired session (badtoken) - https://phabricator.wikimedia.org/T71691#1262092 (10Jdforrester-WMF) [19:26:11] 6Multimedia, 10MediaWiki-General-or-Unknown: Add title field to tag - https://phabricator.wikimedia.org/T4316#1262111 (10Whatamidoing-WMF) [19:37:11] (03CR) 10MarkTraceur: [C: 032] mw.FormDataTransport: Make it possible to skip the 3000 ms timeout in tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208938 (https://phabricator.wikimedia.org/T98130) (owner: 10Bartosz Dziewoński) [19:40:14] (03CR) 10jenkins-bot: [V: 04-1] mw.FormDataTransport: Make it possible to skip the 3000 ms timeout in tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208938 (https://phabricator.wikimedia.org/T98130) (owner: 10Bartosz Dziewoński) [19:40:55] whattttttt [19:43:52] What indeed [19:44:03] Oh, no, that's stupid [19:44:21] Almost certainly bogus [19:44:29] (03CR) 10MarkTraceur: "Resetting." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208938 (https://phabricator.wikimedia.org/T98130) (owner: 10Bartosz Dziewoński) [19:44:35] (03CR) 10MarkTraceur: [C: 032] mw.FormDataTransport: Make it possible to skip the 3000 ms timeout in tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208938 (https://phabricator.wikimedia.org/T98130) (owner: 10Bartosz Dziewoński) [19:45:30] (03Merged) 10jenkins-bot: mw.FormDataTransport: Make it possible to skip the 3000 ms timeout in tests [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/208938 (https://phabricator.wikimedia.org/T98130) (owner: 10Bartosz Dziewoński) [19:45:38] Ta-daaa [19:48:19] Amazing. [19:48:26] That's me all around. [19:48:35] * James_F was talking about MatmaRex. ;-P [19:51:07] https://gerrit.wikimedia.org/r/#/q/status:open+project:mediawiki/extensions/UploadWizard+-message:WIP,n,z has a bunch of stuff. [19:52:00] James_F: I see how it is. [19:52:18] But yes, a lot of it is blocked or I got frustrated with. This is some big stuff. [19:52:25] marktraceur: Some is epic-rebase stuff. [19:52:32] 12 months old? Whee. [19:52:46] Yeah [19:52:58] A lot of that is not applicable anymore...wait, what did I forget to abandon [19:53:04] Like "Massive Refactor" is no longer helpful [19:53:09] Because I did it a better way. [19:53:41] The jquery audits might be a noble effort but will become less useful as we switch to OOUI [19:53:54] So I might just say "meh" to those [19:54:58] * James_F nods. [19:55:07] In fact I'm going to meh them right now. [19:55:49] :o [19:57:23] (03Abandoned) 10MarkTraceur: jquery audit of mw.ApiUploadHandler.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86803 (https://bugzilla.wikimedia.org/53245) (owner: 10MarkTraceur) [19:57:23] (03Abandoned) 10MarkTraceur: jquery audit of mw.DestinationChecker.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86804 (https://bugzilla.wikimedia.org/53245) (owner: 10MarkTraceur) [19:57:23] (03Abandoned) 10MarkTraceur: jquery audit of mw.GroupProgressBar.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86810 (https://bugzilla.wikimedia.org/53245) (owner: 10MarkTraceur) [19:57:23] (03Abandoned) 10MarkTraceur: jquery audit of mw.ErrorDialog.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86805 (https://bugzilla.wikimedia.org/53245) (owner: 10MarkTraceur) [19:57:23] (03Abandoned) 10MarkTraceur: jquery audit and code convention fixes for mw.UWUI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/86814 (https://bugzilla.wikimedia.org/53245) (owner: 10MarkTraceur) [19:57:23] (03Abandoned) 10MarkTraceur: jquery audit for mw.UploadWizard.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/88124 (https://bugzilla.wikimedia.org/53245) (owner: 10MarkTraceur) [20:00:23] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 7JavaScript, 5Patch-For-Review, and 2 others: Audit jQuery use in UploadWizard - https://phabricator.wikimedia.org/T55245#1262252 (10MarkTraceur) Current status: All pending patches abandoned, anticipating that we will fix this as we migrate to OOUI. [20:44:17] (03CR) 10MarkTraceur: "I disagree." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187238 (owner: 10MarkTraceur) [20:47:40] (03CR) 10MarkTraceur: "Patch coming." (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187238 (owner: 10MarkTraceur) [20:47:48] (03PS4) 10MarkTraceur: Replace buttons with OOUI button widgets [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187238 [20:47:51] (03CR) 10jenkins-bot: [V: 04-1] Replace buttons with OOUI button widgets [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187238 (owner: 10MarkTraceur) [20:58:42] I know, Jenkins, chillax [21:10:14] (03PS5) 10MarkTraceur: Replace buttons with OOUI button widgets [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187238 [21:10:37] (03CR) 10MarkTraceur: "Outstanding issue with metadata copying, I think" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187238 (owner: 10MarkTraceur) [21:11:15] (03CR) 10jenkins-bot: [V: 04-1] Replace buttons with OOUI button widgets [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187238 (owner: 10MarkTraceur)