[06:11:47] <_1_samuels> hi [06:24:24] 6Multimedia, 10MediaWiki-DjVu, 10MediaWiki-General-or-Unknown, 10incident-20150423-Commons, and 3 others: img_metadata queries for Djvu files regularly saturate s4 slaves - https://phabricator.wikimedia.org/T96360#1278568 (10aaron) >>! In T96360#1276379, @Anomie wrote: >>>! In T96360#1236196, @GWicke wrote... [06:53:32] 6Multimedia, 10MediaWiki-DjVu, 10MediaWiki-General-or-Unknown, 10incident-20150423-Commons, and 3 others: img_metadata queries for Djvu files regularly saturate s4 slaves - https://phabricator.wikimedia.org/T96360#1278589 (10Springle) jftr, S4 had ~2 hours of this again today. Mostly googlebot IPs. [08:19:50] 6Multimedia, 10MediaWiki-DjVu, 10MediaWiki-General-or-Unknown, 10incident-20150423-Commons, and 3 others: img_metadata queries for Djvu files regularly saturate s4 slaves - https://phabricator.wikimedia.org/T96360#1278663 (10aaron) /srv/mediawiki/w/index.php;MediaWiki::run;MediaWiki::main;MediaWiki::perfor... [10:59:15] Not confused between comboBoxWidget and dropDownWidget any more. [10:59:31] Drop down is mostly done, combo might take a bit more time. [11:02:10] prtksxna: Nice. [11:02:18] prtksxna: (Which bit of UW uses this?) [11:02:28] James_F: You're up extremely early! [11:02:47] James_F: Language selector for the description has a dropdown. [11:02:49] prtksxna: Not for London. :-) [11:02:52] prtksxna: Ah, right. [11:02:58] James_F: Ah :) [11:35:18] (03PS3) 10Florianschmidtwelzow: Change callback handling of mw.confirmCloseWindow [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/207445 [11:36:09] (03CR) 10jenkins-bot: [V: 04-1] Change callback handling of mw.confirmCloseWindow [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/207445 (owner: 10Florianschmidtwelzow) [14:03:21] MatmaRex: You breakin' my patchset over there, buddy? [14:04:50] marktraceur: i have no idea why that started failing now [14:05:38] Maybe it was a fluke [14:05:46] except it was twice [14:05:52] ...oh [14:07:23] seems that master is broken, actually. fun [14:08:31] Woohoo. [14:09:31] marktraceur: i filed two "supertasks" to https://phabricator.wikimedia.org/T85291 , about more OOUIHTMLForm stuff to do after we merge this [14:10:53] marktraceur: also, i just noticed (taking some screenshots for https://phabricator.wikimedia.org/T74715), HTMLSelectField doesn't select the selected option in OOUI mode. i think we need to pass 'value' => $value somewhere. [14:12:31] Hrm, OK [14:12:38] MatmaRex: Comment so I don't forget? [14:13:22] marktraceur: also. the submit button is type=button and not type=submit, so it doesn't submit D: [14:13:24] let me just amend [14:14:52] K. [14:44:25] marktraceur: https://phabricator.wikimedia.org/T74715#1279614 yay [14:44:54] \o/ [14:46:04] marktraceur: can you test out https://gerrit.wikimedia.org/r/#/c/205720/ with the latest version of the core patch, and verify that all forms are submittable, buttons clickable, values settable, etc etc? i couldn't figure out how to set up the extension locally [14:46:49] Sure! [14:50:10] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 6Mobile-Web: Remove upload interface code from MobileFrontend - https://phabricator.wikimedia.org/T98874#1279637 (10Jdlrobson) 3NEW [14:53:00] ...fatal error [14:53:04] Probably my fault somehow [14:54:19] Composer update. [14:57:01] MatmaRex: Checkboxes may not be settable... [14:57:21] Submitted a form with errors...oh, wait, no, just that checkbox [14:59:03] CheckMatrix worked fine though [15:03:27] marktraceur: reviewing https://gerrit.wikimedia.org/r/#/c/187238/ now. in second step ("Upload"), i get the Flickr button with that patch, and don't get it without it. expected? [15:03:56] (both before and after choosing a file to upload in the regular way) [15:04:16] Hm. [15:04:35] MatmaRex: Maybe I messed up the permissions check somewhere - will try after htmlform [15:05:31] marktraceur: also, apparently UploadWizard will not let the user upload a file, if a file with the same contents was previously deleted? interesting [15:06:47] marktraceur: in third step, i get the "Next" button before choosing a license. (it doesn't do anything) [15:07:31] MatmaRex: Complaints about that all the time, we should probably revive the override patch [15:07:57] MatmaRex: Just add comments about failures, I'll fix 'em [15:08:16] right, will dump this on the changeset [15:08:36] also, some of the text fields are invisible :o (no border, no background) looks like a preexisting issue [15:09:04] Oh my. [15:09:22] http://i.imgur.com/ZE1SP7n.png [15:09:30] * marktraceur looks exasperated at his code [15:09:36] Where does getOOUI even get called [15:10:52] (i'm not sure how that happens… seems to be specific to old Opera 12, so probably a non-issue in practice) [15:11:04] marktraceur: uh, it's dynamic [15:11:17] I half-remember writing that, it was a long time ago :P [15:11:23] marktraceur: $value->$getFieldHtmlMethod( $v ) in HTMLForm [15:12:49] Aha. [15:13:12] // Conveniently, PHP method names are case-insensitive. [15:13:16] * marktraceur tears out hair [15:14:43] heh, i think i wrote that comment [15:15:02] previously it did some even sicker stuff trying to uppercase the method name [15:15:13] Yeah. [15:16:26] Looks like the checkbox might not be getting the click event or something [15:16:58] It doesn't submit a value [15:17:06] Oh, wait [15:18:16] The name was missing but that didn't fix it... [15:18:26] Bugs: 2 Mark: 1 [15:20:09] (03CR) 10Bartosz Dziewoński: [C: 04-1] "* in second step ("Upload"), i get the Flickr button with the patch, and don't get it without it." (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187238 (owner: 10MarkTraceur) [15:35:37] marktraceur: trivialities, removing some code: https://gerrit.wikimedia.org/r/210374 https://gerrit.wikimedia.org/r/210375 [15:36:09] Fun, once I figure out why this checkbox is an asshole, I'll do that [15:40:33] As far as I can tell, HTMLForm or ContextSource is reversing the checked value before it gets to the getInputOOUI method [15:43:49] 6Multimedia: Fatal error: Object does not implement ArrayAccess in /srv/mediawiki/php-master/extensions/FeaturedFeeds/FeaturedFeeds.body.php on line 38 - https://phabricator.wikimedia.org/T98884#1279897 (10thcipriani) 3NEW a:3aaron [15:44:10] MatmaRex: Think you could take a look? I'll upload the name fix at least [15:46:24] looking [15:51:57] 6Multimedia, 10MediaWiki-DjVu, 10MediaWiki-General-or-Unknown, 10incident-20150423-Commons, and 3 others: img_metadata queries for Djvu files regularly saturate s4 slaves - https://phabricator.wikimedia.org/T96360#1279956 (10GWicke) > It might make sense to revert those 1 of those patches, since it still h... [15:52:50] 6Multimedia: Fatal error: Object does not implement ArrayAccess in /srv/mediawiki/php-master/extensions/FeaturedFeeds/FeaturedFeeds.body.php on line 38 - https://phabricator.wikimedia.org/T98884#1279962 (10greg) More WAN fallout, methinks: https://phabricator.wikimedia.org/rEFFD3f6c055fd214e9d20a4ba460d49cc5985f... [15:53:07] 6Multimedia: Fatal error: Object does not implement ArrayAccess in /srv/mediawiki/php-master/extensions/FeaturedFeeds/FeaturedFeeds.body.php on line 38 - https://phabricator.wikimedia.org/T98884#1279964 (10greg) p:5Triage>3Unbreak! [15:54:04] 6Multimedia, 10MediaWiki-extensions-FeaturedFeeds: Fatal error: Object does not implement ArrayAccess in /srv/mediawiki/php-master/extensions/FeaturedFeeds/FeaturedFeeds.body.php on line 38 - https://phabricator.wikimedia.org/T98884#1279897 (10greg) [16:00:21] 6Multimedia, 10MediaWiki-extensions-FeaturedFeeds: Fatal error: Object does not implement ArrayAccess in /srv/mediawiki/php-master/extensions/FeaturedFeeds/FeaturedFeeds.body.php on line 38 - https://phabricator.wikimedia.org/T98884#1279996 (10Gilles) a:5aaron>3Gilles [16:00:39] marktraceur: fairly sure it should work. can you share $wgGroupPermissions config for OAuth? the extension page on MW.org has no simple example to copy paste [16:01:56] (nevermind, got it) [16:11:37] marktraceur: Heads up, new styling change in the new release of OOjs UI going into core now (yes, I know it's out of sequence) - the styling of buttons' hover states has changed. [16:12:08] OK, should be fine [16:12:24] marktraceur: bah, debugged that. https://gerrit.wikimedia.org/r/#/c/205719/15/includes/htmlform/HTMLCheckField.php,cm [16:12:30] (also found unrelated bug in CheckMatrix) [16:13:01] Thanks MatmaRex [16:15:20] {{done}} [16:22:19] Sigh. [16:25:46] 6Multimedia, 10MediaWiki-extensions-FeaturedFeeds, 5Patch-For-Review: Fatal error: Object does not implement ArrayAccess in /srv/mediawiki/php-master/extensions/FeaturedFeeds/FeaturedFeeds.body.php on line 38 - https://phabricator.wikimedia.org/T98884#1280110 (10Gilles) I still see the fatal, does it really... [16:26:23] marktraceur: hmm, one last thing. right now the OOUI version doesn't display error messages anywhere (from getErrorsAndErrorClass()). not sure if that should be a blocker? [16:26:32] Maybe... [16:26:38] Yeah, we should probably do that. [16:26:43] marktraceur: we'd probably want to display them in nice tooltips or something, which we currently don't really have a way to do [16:26:52] but we can probably just dump them somewhere near the fields for the time bing [16:26:53] being* [16:27:25] Maybe it's time to make a Good Way for that to happen [16:27:44] Rather than hack it together and wait [16:27:45] there is a bug or five about implementing that in OOUI somewhere [16:28:02] Nice Tool Tips™ would be nice, yes. [16:28:14] Or "like Tipsy but accessible". [16:29:23] mmmmeh. [16:30:25] marktraceur: my proposal: in HTMLFormField::getOOUI(), instead of `return $field`, do `return $field . $errors` (and update docs to say that it returns a string now) [16:30:36] Sure [16:30:37] and file a bug about making this not suck [16:30:56] (probably needs to be done the same in subclasses too) [16:32:02] I think just getOOUI is fine [16:32:42] oh, we don't override that anywhere, only getInputOOUI. neat. [16:32:46] Yup [16:33:03] Done. [16:34:07] soooo… i should merge it now, i guess? :D [16:34:38] MatmaRex: Does it work? Go for it. [16:35:01] and we should probably announce how awesome we are and that you can start *carefully* using it in extensions [16:35:07] 6Multimedia, 10MediaWiki-extensions-FeaturedFeeds, 5Patch-For-Review: Fatal error: Object does not implement ArrayAccess in /srv/mediawiki/php-master/extensions/FeaturedFeeds/FeaturedFeeds.body.php on line 38 - https://phabricator.wikimedia.org/T98884#1280157 (10Gilles) 5Open>3Resolved [16:35:07] Hmmm. [16:35:16] Maybe use it properly in core once first, as a demo? [16:36:50] James_F: mark has a commit that uses it in OAuth, we could probably merge https://gerrit.wikimedia.org/r/#/c/208285/ for core (although i haven't verified this carefully, and it touches some scary stuff like PasswordReset) [16:37:47] James_F: generally if you use this, you should carefully verify that all buttons are clickable, all fields can be typed in, all data actually gets submitted, and so on; since we might have missed some important line of code somewhere. if all that works correctly, you're good to go with your form. [16:38:06] * James_F nods. [16:38:29] marktraceur: Why does the OAuth patch change the appearance so much? [16:43:02] marktraceur: James_F: builds are failing all over again, so i'm going to go eat dinner and hopefully merge it when i get back. [16:46:12] James_F: I wasn't going for appearance parity, we can tweak it if you like perhaps [16:47:52] MatmaRex: +1, merge away if the tests work [16:54:08] MatmaRex: Fun. Sounds good. [16:54:24] marktraceur: "Parity" is not needed, but a bit closer would be nice. [16:54:41] marktraceur: Especially for a security screen. Nice for users to not be suspicious. [16:55:20] James_F: OK, will tweak [16:55:33] marktraceur: No need to spend much time on it, though. [16:57:21] 6Multimedia, 10MediaWiki-DjVu, 10MediaWiki-General-or-Unknown, 10incident-20150423-Commons, and 3 others: img_metadata queries for Djvu files regularly saturate s4 slaves - https://phabricator.wikimedia.org/T96360#1280210 (10aaron) I was looking at 54816e2071fc3e38ad581a264967bd46cbb3647e. And the problem... [17:21:12] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler: Fatal error: Stack overflow in TestApiUploadVideo::testUploadVideoFiles - https://phabricator.wikimedia.org/T71051#1280267 (10Paladox) [17:33:14] (03PS1) 10Paladox: Fix php strict error [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210397 (https://phabricator.wikimedia.org/T64135) [17:33:24] (03PS2) 10Paladox: Fix php strict error [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210397 (https://phabricator.wikimedia.org/T64135) [17:34:15] (03CR) 10Manybubbles: [C: 031] Fix php strict error [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210397 (https://phabricator.wikimedia.org/T64135) (owner: 10Paladox) [17:45:32] MatmaRex: Gosh. [17:46:30] :o [17:48:49] We can still tweak it, nothing uses it yet [17:50:02] is something wrong with the patch? [17:50:27] MatmaRex: Style isn't really the same - James_F wants the pages relating to security to at least be the same as they were [17:51:32] well, obviously it's not the same, but i'm not sure what you'd like to do about it [17:51:45] CSS hacks I guess [17:51:54] Not that I'd like to, but it might be helpful [17:52:03] if the theme needs fixes, they are easily applied upstream [17:52:22] "pages relating to security" – talking about the OAuth pages? [17:53:33] Possibly? Maybe login too [17:53:35] Register [17:54:08] (03CR) 10Manybubbles: [C: 04-1] "So now that I look more closely - the definition of the method being overwritten is:" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210397 (https://phabricator.wikimedia.org/T64135) (owner: 10Paladox) [17:54:11] MatmaRex: It was more that we could tweak the OAuth dialog a little to look a bit more like the existing one. [17:54:21] MatmaRex: Not that lots of things need changing in general. [17:54:53] correct me if i'm wrong, but the dialog doesn't use a HTMLForm? it was hand-coded last i looked [17:55:14] i mean the dialog like "phabricator wants you to authorize blahblah" [17:55:18] Hand-coded MW-UI-ish. [17:55:19] Yeah. [17:55:48] So for example it has a lurid green button, but the screenshot of Mark's patch just had it be a pale white one. [17:58:44] James_F: MediaWiki theme's design is changing literally every week, so if you want that to be static, we should probably not use OOUI for it at all… [18:04:21] (03CR) 10Paladox: "Nope I didn't test it I just looked through code thinking this fixed it." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210397 (https://phabricator.wikimedia.org/T64135) (owner: 10Paladox) [18:05:26] (03CR) 10Paladox: "Do I just copy the code from core of mediawiki since it is different in there." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210397 (https://phabricator.wikimedia.org/T64135) (owner: 10Paladox) [18:36:22] 6Multimedia, 10MediaWiki-extensions-MwEmbedSupport, 10MediaWiki-extensions-TimedMediaHandler, 7Technical-Debt: Namespace mw.MwEmbedSupport methods - https://phabricator.wikimedia.org/T62295#1280455 (10Paladox) [18:37:29] 6Multimedia, 10MediaWiki-extensions-MwEmbedSupport, 10MediaWiki-extensions-TimedMediaHandler, 7Performance: MwEmbedSupport injects too many JavaScript configuration variables - https://phabricator.wikimedia.org/T60082#1280458 (10Paladox) [18:38:35] 6Multimedia, 10MediaWiki-extensions-MwEmbedSupport, 10MediaWiki-extensions-TimedMediaHandler: MwEmbedSupport doesn't work with non standard layouts - https://phabricator.wikimedia.org/T47918#1280460 (10Paladox) [19:07:13] (03PS1) 10Paladox: Add support for 4K videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210407 (https://phabricator.wikimedia.org/T98694) [19:07:16] (03CR) 10jenkins-bot: [V: 04-1] Add support for 4K videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210407 (https://phabricator.wikimedia.org/T98694) (owner: 10Paladox) [19:07:30] (03PS2) 10Paladox: Add support for 4K videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210407 (https://phabricator.wikimedia.org/T98694) [19:07:33] (03CR) 10jenkins-bot: [V: 04-1] Add support for 4K videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210407 (https://phabricator.wikimedia.org/T98694) (owner: 10Paladox) [19:09:58] (03PS3) 10Paladox: Add support for 4K videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210407 (https://phabricator.wikimedia.org/T98694) [19:13:30] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler: Enable 1080p (aka full-hd) support in TMH - https://phabricator.wikimedia.org/T73705#1280548 (10Paladox) a:3brion [20:02:04] (03CR) 10Brion VIBBER: [C: 04-1] "I'd recommend dropping the OGV output at this resolution; H.264 or WebM will do a better job encoding and we won't be using the Javascript" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210407 (https://phabricator.wikimedia.org/T98694) (owner: 10Paladox) [20:15:02] (03PS4) 10Paladox: Add support for 4K videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210407 (https://phabricator.wikimedia.org/T98694) [20:19:06] (03CR) 10Paladox: "Shoulden there be OGV support just in case someone wants to use 4k in ogv format." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210407 (https://phabricator.wikimedia.org/T98694) (owner: 10Paladox) [20:35:25] (03PS27) 10Paladox: ogv.js media player for desktop Safari/IE (2 of 2) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://phabricator.wikimedia.org/T63823) (owner: 10Brion VIBBER) [20:39:00] (03CR) 10Paladox: "Needs support for edge in Microsoft Edge Microsoft new browser and browser engine." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://phabricator.wikimedia.org/T63823) (owner: 10Brion VIBBER) [20:39:20] (03PS28) 10Paladox: ogv.js media player for desktop Safari/IE (2 of 2) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://phabricator.wikimedia.org/T63823) (owner: 10Brion VIBBER) [20:48:18] 6Multimedia, 10MediaWiki-DjVu, 10MediaWiki-General-or-Unknown, 10incident-20150423-Commons, and 3 others: img_metadata queries for Djvu files regularly saturate s4 slaves - https://phabricator.wikimedia.org/T96360#1280883 (10aaron) Ignore the last 3 gerrit comments. [21:02:14] (03CR) 10Brion VIBBER: "Should work in Edge, lemme test the current patch version..." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://phabricator.wikimedia.org/T63823) (owner: 10Brion VIBBER) [21:02:38] 6Multimedia, 10MediaWiki-extensions-GWToolset, 10Wikimedia-Site-requests: Upload images to Commons using description provided in spreadsheet. - https://phabricator.wikimedia.org/T88957#1280949 (10Dereckson) @Hispalois @Tgr Meanwhile, https://commons.wikimedia.org/wiki/User:Wmigda/Anuta_upload_script could he... [21:04:14] (03CR) 10Brion VIBBER: "Note that the IE-specific checks in the code are looking for the Flash plugin for audio -- which is not needed on Edge as Web Audio is sup" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://phabricator.wikimedia.org/T63823) (owner: 10Brion VIBBER) [21:40:07] (03PS29) 10Brion VIBBER: ogv.js media player for desktop Safari/IE/Edge (2 of 2) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/165478 (https://phabricator.wikimedia.org/T63823) [21:45:09] (03CR) 10Paladox: [C: 031] Add support for 4K videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210407 (https://phabricator.wikimedia.org/T98694) (owner: 10Paladox) [21:45:18] (03PS5) 10Paladox: Add support for 4K videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210407 (https://phabricator.wikimedia.org/T98694) [21:45:37] (03PS4) 10Paladox: Add extensions.json, empty PHP entry point, remove i18n shim [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210176 (https://phabricator.wikimedia.org/T87981) [21:46:09] (03CR) 10Paladox: [C: 031] Add extensions.json, empty PHP entry point, remove i18n shim [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210176 (https://phabricator.wikimedia.org/T87981) (owner: 10Paladox) [22:25:06] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 5Patch-For-Review: PHP strict standards error on TimedMediaHandler - https://phabricator.wikimedia.org/T64135#1281122 (10Krinkle) >>! @Manybubbles wrote > PHP Strict standards: Declaration of ForeignApiQueryAllPages::titlePartToKey() should be compatible...