[00:53:55] 6Multimedia, 10Beta-Cluster, 10MediaWiki-extensions-GWToolset, 7HHVM, 5Patch-For-Review: GWToolset XML upload fails with “The file that was uploaded exceeds the upload_max_filesize and/or the post_max_size directive in php.ini” on hhvm 3.6 - https://phabricator.wikimedia.org/T97415#1281332 (10Dzahn) 5Re... [00:58:57] 6Multimedia, 10Beta-Cluster, 10MediaWiki-extensions-GWToolset, 7HHVM, 5Patch-For-Review: GWToolset XML upload fails with “The file that was uploaded exceeds the upload_max_filesize and/or the post_max_size directive in php.ini” on hhvm 3.6 - https://phabricator.wikimedia.org/T97415#1281349 (10Dzahn) 17:5... [01:06:21] 6Multimedia, 10Beta-Cluster, 10MediaWiki-extensions-GWToolset, 7HHVM, 5Patch-For-Review: GWToolset XML upload fails with “The file that was uploaded exceeds the upload_max_filesize and/or the post_max_size directive in php.ini” on hhvm 3.6 - https://phabricator.wikimedia.org/T97415#1281355 (10Dzahn) 18:0... [01:11:19] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Upload Wizard - You can only upload files with a size of up to -1 B. - https://phabricator.wikimedia.org/T98933#1281358 (10Dzahn) 3NEW [01:14:23] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Upload Wizard - You can only upload files with a size of up to -1 B. - https://phabricator.wikimedia.org/T98933#1281368 (10Dzahn) [01:14:48] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Upload Wizard - You can only upload files with a size of up to -1 B. - https://phabricator.wikimedia.org/T98933#1281372 (10Dzahn) p:5Triage>3Unbreak! [01:15:55] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Upload Wizard - You can only upload files with a size of up to -1 B. - https://phabricator.wikimedia.org/T98933#1281358 (10Dzahn) 17:51 < andrewbogott> Yo, does everyone already know that the Commons upload wizard is broken? 17:51 < andrewbogott> "You can only... [01:17:37] 6Multimedia, 10Beta-Cluster, 10MediaWiki-extensions-GWToolset, 7HHVM, 5Patch-For-Review: GWToolset XML upload fails with “The file that was uploaded exceeds the upload_max_filesize and/or the post_max_size directive in php.ini” on hhvm 3.6 - https://phabricator.wikimedia.org/T97415#1281381 (10Dzahn) p:5... [01:24:31] 6Multimedia, 10Beta-Cluster, 10MediaWiki-extensions-GWToolset, 7HHVM, 5Patch-For-Review: GWToolset XML upload fails with “The file that was uploaded exceeds the upload_max_filesize and/or the post_max_size directive in php.ini” on hhvm 3.6 - https://phabricator.wikimedia.org/T97415#1281389 (10Legoktm) 5... [01:29:49] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Upload Wizard - You can only upload files with a size of up to -1 B. - https://phabricator.wikimedia.org/T98933#1281399 (10bd808) Running HHVM in cli mode works on mw1070: ``` bd808@mw1070:~$ php -r 'echo ini_get( "upload_max_filesize" ),... [01:30:07] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 7HHVM, 5Patch-For-Review, 7Upstream: Upload Wizard - You can only upload files with a size of up to -1 B. - https://phabricator.wikimedia.org/T98933#1281400 (10bd808) [01:33:16] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 7HHVM, 5Patch-For-Review, 7Upstream: Upload Wizard - You can only upload files with a size of up to -1 B. - https://phabricator.wikimedia.org/T98933#1281402 (10Legoktm) p:5Unbreak!>3High Hack fixed UW on commons, no longer UBN. Still needs a proper fix. [01:34:21] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 7HHVM, 5Patch-For-Review, 7Upstream: Upload Wizard - You can only upload files with a size of up to -1 B. - https://phabricator.wikimedia.org/T98933#1281405 (10Dzahn) It works again after https://gerrit.wikimedia.org/r/210636 was deployed 18:30 < logms... [04:20:13] Whatever happened to the selenium tests for upload wizard (I thought such things existed) [04:23:33] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 7HHVM, 5Patch-For-Review, 7Upstream: Upload Wizard - You can only upload files with a size of up to -1 B. - https://phabricator.wikimedia.org/T98933#1281487 (10Bawolff) Sorry, I should have looked into this when I saw the gwtoolset bug. At the time, I saw... [04:41:16] bawolff: They do! What patch broke it? [04:41:44] marktraceur: Well I just don't see them in the RC on commons beta [04:42:03] And also, today's bug would have been caught by them much earlier if they were running (I think) [04:42:07] ...huh, maybe someone turned them off [04:42:52] Or, and here's a thought, maybe I'm not paying attention to them [04:42:58] * marktraceur whips self [04:43:51] :) [04:44:55] Is there a mailing list for them, or who do they notify? [04:45:24] There must be a list [04:45:25] I'm on it [04:45:46] I think there were rumblings about having auto-bug-reporting but hashar is working on separating different bits of testing first, I think [04:45:59] multimedia-alerts has no archives, otherwise I'd assume its that [04:47:05] - MultimediaViewer: &emails-multimedia [04:47:05] multimedia-alerts@lists.wikimedia.org qa-alerts@lists.wikimedia.org [04:47:12] bawolff: maybe it just doesn't keep archives? [04:47:20] oh [04:47:21] - UploadWizard: &emails-UploadWizard [04:47:21] multimedia-alerts@lists.wikimedia.org qa-alerts@lists.wikimedia.org [04:47:25] still same group [04:49:01] yeah, I guess its there https://lists.wikimedia.org/pipermail/qa-alerts/2015-May/019413.html [04:49:18] * bawolff draws conclusion, that maybe these browser test things are super overrated [05:06:26] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 7HHVM, 5Patch-For-Review, 7Upstream: Upload Wizard - You can only upload files with a size of up to -1 B. - https://phabricator.wikimedia.org/T98933#1281505 (10Legoktm) Upstream bug is https://github.com/facebook/hhvm/issues/4993 [09:08:59] is upload wizard broken ? UploadWizard uses JavaScript for an improved interface. Your browser either does not support JavaScript or has JavaScript turned off, so we are showing you a simple upload form. [09:14:46] matanya: Its not supposed to be. Where are you seeing this? [09:15:17] prtksxna: i get it on uploadwizard page (spaecial:upload) once every few minutes [09:16:11] matanya: Sorry, I didn't realize that commons was the only wiki with the extension enabled. [09:18:51] matanya: Strange. I don't see it happening here. What browser/os are you on? [09:19:06] firefox on linux [09:20:38] * prtksxna tries with FF [09:22:03] Looks alright on MacOS. [09:22:50] matanya: The error isn't consistent for you, right? [09:22:59] yes [09:23:44] I took a look at the logs and I can't see anything that could have caused this. There wasn't going to be a commit message saying "Breaking JS support in unpredictable ways" anyway :P [09:24:06] lol [09:24:26] Well commons community would be rioting if its broken in production, or do you just mean on master [09:26:39] master (53059a2) is working on FF on MacOS [09:28:30] prtksxna: I don't know, don't have a smart way to reproduce apart from many refreshes [09:29:24] prtksxna: "NS_ERROR_DOM_QUOTA_REACHED: Persistent storage maximum size reached" DOMException [NS_ERROR_DOM_QUOTA_REACHED: "Persistent storage maximum size reached" [09:29:24] code: 1014 [09:29:24] nsresult: 0x805303f6 [09:29:24] location: https://commons.wikimedia.org/w/load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=20150512T181929Z:174] [09:31:02] prtksxna: also: https://dpaste.de/XyQ6 [09:31:46] does that help prtksxna ? [09:35:15] matanya: Taking a look now. My computer timed out :\ [09:36:58] * prtksxna shakes fist at localStorage [09:40:22] FF seems to have a different limit than Chrome… [09:40:25] brb [09:52:27] matanya: A local solution would be clearing your cache [09:52:47] prtksxna: did that, and the other one popped up (https://dpaste.de/XyQ6) [09:54:34] matanya: Can you run localStorage.clear() in your dev console? [09:55:49] undefined [09:55:53] matanya: That is strange, OO is clearly defined as a dependency, and has been since Mon Dec 8. [09:56:00] matanya: Cool [09:57:00] prtksxna: it is still happenning even after clearing [09:57:25] matanya: Not "NS_ERROR_DOM_QUOTA_REACHED: Persistent storage maximum size reached", right? [09:57:32] yes, that [09:57:53] /o\ [09:57:55] but the OO is more worring [09:58:32] Can you type "OO" in your console? [09:58:45] * prtksxna is unable to reproduce any of it here :( [09:59:19] Object { initClass: oo.initClass(), inheritClass: oo.inheritClass(), mixinClass: oo.mixinClass(), getProp: oo.getProp(), setProp: oo.setProp(), cloneObject: oo.cloneObject(), getObjectValues: oo.getObjectValues(), compare: oo.compare(), copy: oo.copy(), getHash: oo.getHash(), 9 more… } [09:59:37] prtksxna: might it be a load order issue ? [10:00:30] matanya: It could, but looking at https://github.com/wikimedia/mediawiki-extensions-UploadWizard/blob/master/UploadWizardHooks.php#L530, I am not sure how. [10:01:49] I've hear Resource Loader does take up a lot of localStorage, and if you're running out of that, it might be failing at doing its job right [10:02:00] Which is why OO isn't loaded on time either. [10:02:46] prtksxna: so fixing the local storage for firefox seems to be the right action, is it ? [10:04:17] The way I am looking at it, yes. Create a phab task I guess, marktraceur would have much a better understanding of this anyway. [10:05:00] localStorage is basically broken richt now [10:05:15] there is SO much in it, if you use more than one WMF site. [10:06:30] thedj: thanks for pointing that out. [10:06:36] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Upload Wizard fails to load with: "NS_ERROR_DOM_QUOTA_REACHED: Persistent storage maximum size reached" - https://phabricator.wikimedia.org/T98948#1281806 (10Matanya) 3NEW [10:09:07] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Upload Wizard fails to load with: "NS_ERROR_DOM_QUOTA_REACHED: Persistent storage maximum size reached" - https://phabricator.wikimedia.org/T98948#1281817 (10Matanya) [10:09:29] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Upload Wizard fails to load with: "NS_ERROR_DOM_QUOTA_REACHED: Persistent storage maximum size reached" - https://phabricator.wikimedia.org/T98948#1281820 (10Prtksxna) [10:11:27] matanya: Do you want to leave a comment noting that it isn't consistent and how one could attempt to reproduce it? [10:12:05] prtksxna: i don't really know, i just did million hard refreshes. [10:12:40] matanya: Mention that :) [10:16:17] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Upload Wizard fails to load with: "NS_ERROR_DOM_QUOTA_REACHED: Persistent storage maximum size reached" - https://phabricator.wikimedia.org/T98948#1281848 (10Matanya) In addition: It is hard to reproduce, as it doesn't happen any time. The only way is to try ha... [10:16:19] done [11:02:21] (03PS4) 10Florianschmidtwelzow: Change callback handling of mw.confirmCloseWindow [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/207445 [11:03:15] (03CR) 10jenkins-bot: [V: 04-1] Change callback handling of mw.confirmCloseWindow [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/207445 (owner: 10Florianschmidtwelzow) [11:18:02] (03PS5) 10Florianschmidtwelzow: Change callback handling of mw.confirmCloseWindow [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/207445 [11:21:01] (03CR) 10Florianschmidtwelzow: "Sorry for my delay." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/207445 (owner: 10Florianschmidtwelzow) [12:41:08] 6Multimedia, 10MediaWiki-File-management, 7Upstream: Exif values retrieved incorrectly if they appear before IFD - https://phabricator.wikimedia.org/T97253#1282032 (10McZusatz) >>! In T97253#1260717, @Lupo wrote: > I think every "upstream" issue should have an upstream bug report, and mention it here, too.... [14:44:51] 6Multimedia, 10MediaWiki-File-management, 7Upstream: Exif values retrieved incorrectly if they appear before IFD - https://phabricator.wikimedia.org/T97253#1282202 (10TheDJ) > Why took it 5 years for the bug to reach us? Was there an update of our php to an affected version in the last 30 to 60 days? @McZus... [14:50:42] (03CR) 10TheDJ: [C: 04-1] Change callback handling of mw.confirmCloseWindow (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/207445 (owner: 10Florianschmidtwelzow) [14:54:34] (03PS6) 10Florianschmidtwelzow: Change callback handling of mw.confirmCloseWindow [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/207445 [14:54:59] (03CR) 10Florianschmidtwelzow: Change callback handling of mw.confirmCloseWindow (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/207445 (owner: 10Florianschmidtwelzow) [15:22:48] (03CR) 10TheDJ: [C: 032] Change callback handling of mw.confirmCloseWindow [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/207445 (owner: 10Florianschmidtwelzow) [15:23:40] (03Merged) 10jenkins-bot: Change callback handling of mw.confirmCloseWindow [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/207445 (owner: 10Florianschmidtwelzow) [16:17:27] Hmmm...guess there may be a dependency race condition somewhere [16:17:32] I'll try to flush it out [16:22:51] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Upload Wizard fails to load with: "NS_ERROR_DOM_QUOTA_REACHED: Persistent storage maximum size reached" - https://phabricator.wikimedia.org/T98948#1282496 (10MarkTraceur) I'm guessing a missing RL dependency race condition. Fixing. [16:24:33] (03PS1) 10MarkTraceur: Add oojs to uwui.Step dependencies [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/210707 (https://phabricator.wikimedia.org/T98948) [16:25:36] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Upload Wizard fails to load because of RL dependency race condition - https://phabricator.wikimedia.org/T98948#1282501 (10MarkTraceur) [16:34:23] (03CR) 10Prtksxna: [C: 032] Add oojs to uwui.Step dependencies [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/210707 (https://phabricator.wikimedia.org/T98948) (owner: 10MarkTraceur) [16:34:45] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Upload Wizard fails to load because of RL dependency race condition - https://phabricator.wikimedia.org/T98948#1282516 (10Prtksxna) a:3MarkTraceur [16:37:46] matanya: I was looking at the dependencies of uw.controller.Step and not uw.ui.Step :\ [16:38:01] marktraceur: ^ [16:38:16] * prtksxna facepalms [16:38:23] Yup yup [16:41:35] (03CR) 10jenkins-bot: [V: 04-1] Add oojs to uwui.Step dependencies [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/210707 (https://phabricator.wikimedia.org/T98948) (owner: 10MarkTraceur) [16:42:28] Cocknuggets [16:42:35] Jenkins is borked. [16:43:01] (03CR) 10Prtksxna: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/210707 (https://phabricator.wikimedia.org/T98948) (owner: 10MarkTraceur) [16:43:22] (03PS2) 10Prtksxna: Add oojs to uw.ui.Step dependencies [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/210707 (https://phabricator.wikimedia.org/T98948) (owner: 10MarkTraceur) [16:45:47] * prtksxna is in a stare-off with Gerrit [16:46:13] (03CR) 10Prtksxna: [C: 031] Add oojs to uw.ui.Step dependencies [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/210707 (https://phabricator.wikimedia.org/T98948) (owner: 10MarkTraceur) [16:46:32] (03CR) 10Prtksxna: [C: 032] Add oojs to uw.ui.Step dependencies [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/210707 (https://phabricator.wikimedia.org/T98948) (owner: 10MarkTraceur) [16:50:28] (03CR) 10jenkins-bot: [V: 04-1] Add oojs to uw.ui.Step dependencies [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/210707 (https://phabricator.wikimedia.org/T98948) (owner: 10MarkTraceur) [16:58:20] marktraceur: I have no idea what jenkins is up to. [16:59:00] https://phabricator.wikimedia.org/T98980 [17:01:15] (03CR) 10Paladox: Add support for 4K videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210407 (https://phabricator.wikimedia.org/T98694) (owner: 10Paladox) [17:05:52] (03CR) 10Prtksxna: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/210707 (https://phabricator.wikimedia.org/T98948) (owner: 10MarkTraceur) [17:40:23] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 5Patch-For-Review: Support ogv.js in player - https://phabricator.wikimedia.org/T63823#1282766 (10Paladox) [17:49:37] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler: Upgrade Timed Media Handler for Kaltura v2 Integration - https://phabricator.wikimedia.org/T77150#1282799 (10Paladox) [17:50:13] 6Multimedia, 10MediaWiki-extensions-MwEmbedSupport, 10MediaWiki-extensions-TimedMediaHandler: Upgrade Timed Media Handler for Kaltura v2 Integration - https://phabricator.wikimedia.org/T77150#826199 (10Paladox) [17:53:09] (03PS7) 10Paladox: Update dependencies for MwEmbedSupport [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/182094 [18:05:53] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 5Patch-For-Review: PHP strict standards error on TimedMediaHandler - https://phabricator.wikimedia.org/T64135#1282864 (10Anomie) 5Open>3Resolved a:3Gilles [18:05:58] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 5Patch-For-Review: PHP strict standards error on TimedMediaHandler - https://phabricator.wikimedia.org/T64135#650127 (10Anomie) >>! In T64135#1281122, @Krinkle wrote: > It seems @anomie can't reproduce this warning I didn't know I tried? > and the sour... [18:06:48] (03Abandoned) 10Anomie: Fix php strict error [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210397 (https://phabricator.wikimedia.org/T64135) (owner: 10Paladox) [18:40:43] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 6Mobile-Web, 5Patch-For-Review: Remove upload interface code from MobileFrontend - https://phabricator.wikimedia.org/T98874#1283003 (10kaldari) Before we remove all the mobile-specific uploading code, I think we should make Special:Upload usable as an alter... [19:51:00] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 6Mobile-Web, 5Patch-For-Review: Remove upload interface code from MobileFrontend - https://phabricator.wikimedia.org/T98874#1283218 (10Jdlrobson) Special:Upload is perfectly suitable in current form for 3rd parties. Special: Upload is styled fine on standa... [19:51:21] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 6Mobile-Web, 5Patch-For-Review: Remove upload interface code from MobileFrontend - https://phabricator.wikimedia.org/T98874#1283221 (10Jdlrobson) Note: with respect to the JS we shouldn't rely on JavaScript for this sort of thing. I seem to remember a bug a... [20:01:55] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 6Mobile-Web, 5Patch-For-Review: Remove upload interface code from MobileFrontend - https://phabricator.wikimedia.org/T98874#1283255 (10kaldari) Created a new ticket for fixing up Special:Upload: T99003 [20:10:30] (03PS6) 10Paladox: Add support for 4K videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210407 (https://phabricator.wikimedia.org/T98694) [20:31:26] 6Multimedia, 10MediaWiki-File-management, 5Patch-For-Review: Fatal error: Object does not implement ArrayAccess in /srv/mediawiki/php-master/includes/filerepo/file/LocalFile.php on line 258 - https://phabricator.wikimedia.org/T98754#1283358 (10aaron) 5Open>3Resolved [20:52:42] 6Multimedia, 10MediaWiki-Extension-Requests: Making license and author information api accessible - https://phabricator.wikimedia.org/T27624#1283452 (10Josve05a) @Nemo_bis is this problem (whatever it was) resolved? If so, can it be removed as a blocker on {T87268}?