[05:20:37] 6Multimedia, 10MediaWiki-Uploading: Ability to block users from uploading files or EmailUser only - https://phabricator.wikimedia.org/T6995#1440011 (10Bugreporter) [06:53:02] (03Abandoned) 10Brion VIBBER: Add opus support to OGV video [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/211725 (https://phabricator.wikimedia.org/T75150) (owner: 10Paladox) [07:47:01] 6Multimedia, 10MediaWiki-File-management, 10Wikimedia-Video, 7Performance: Convert animated images (animGIF, APNG) to HTML5 video - https://phabricator.wikimedia.org/T105276#1440219 (10Tgr) 3NEW [07:49:30] 6Multimedia, 10MediaWiki-File-management, 10Wikimedia-Video, 7Performance: Convert animated images (animGIF, APNG) to HTML5 video - https://phabricator.wikimedia.org/T105276#1440246 (10Bawolff) Are current support for video gives a rather poor user experiance imo. I think we should fix that first. [08:14:33] My mediawiki installation is doing the same thing again, not loading any JS :\ [08:18:06] I sometimes have that issue when i turn on $wgDebugComments [08:19:49] (03PS37) 10Paladox: Add support for 4K videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/210407 (https://phabricator.wikimedia.org/T98694) [08:20:27] bawolff: Not the case here [08:25:23] bawolff: It was because I wasn't loading an extension properly. Still using require_once instead of wfLoadExtension [08:25:40] That doesn't sound like a very good failure mode [08:25:54] At least I didn't have to vagrant destroy, like last time. [08:26:08] * prtksxna blames legoktm [08:41:01] A misconfigured extension is causing the same problem too. Well I am assumings it misconfigured, I am not seeing any errors but not loading it solved the problem [08:41:27] And ?debug=true doesn't show the debug bar, I guess because it needs JavaScript. [11:33:50] marktraceur: The api.uploadToStash promise isn't resolving. Is this something to do with the new patchset or a mistake I might have made. [11:33:53] s/./? [11:37:11] marktraceur: Not working for the gadget either [11:40:51] 6Multimedia, 10MediaWiki-File-management, 6Performance-Team, 5Patch-For-Review, 7Swift: Investigate Swift replacement for thumbnails - https://phabricator.wikimedia.org/T77697#1440832 (10Gilles) @Bblack are you ok with isolating thumbnails into their first varnish cache as a first step, to see if the hit... [11:44:44] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 6Performance-Team: Reduce amount of thumbnail buckets - https://phabricator.wikimedia.org/T102870#1440844 (10Gilles) >>! In T102870#1430704, @BBlack wrote: > It may be that there are 640 links in cached HTML, which could take ~30 days to fall out of varni... [12:02:17] marktraceur: https://github.com/prtksxna/UploadUI [12:03:18] marktraceur: We should talk soon, I am not if what I am doing is right [12:03:40] (03CR) 10Krinkle: Reduce number of RL modules in MultimediaViewer (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/220621 (https://phabricator.wikimedia.org/T103706) (owner: 10Gilles) [12:04:04] (03CR) 10Krinkle: "I won't pretend to know anything about this module structure. If it works it works. The overall direction certainly looks right, but I'll " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/220621 (https://phabricator.wikimedia.org/T103706) (owner: 10Gilles) [13:18:43] prtksxna: I think there may have been a bug...let me upload a new version for you [13:22:52] prtksxna: All set now, the promises should resolve as expected now [13:23:01] At least I think so. [13:23:15] I may be having a small bug in my promise comprehension matrix today. [13:58:32] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: "file corrupt" errors on Commons upload when transferring from Flickr - https://phabricator.wikimedia.org/T105224#1441251 (10Aklapper) [15:16:26] 6Multimedia, 10MediaWiki-API, 5MW-1.26-release, 5Patch-For-Review, and 2 others: PHP Notice: "Undefined index: value in includes/filerepo/file/ForeignAPIFile.php:201" - https://phabricator.wikimedia.org/T103781#1441520 (10Anomie) The API part of this is done with the merge of Lego's patch. Does anyone wan... [15:43:28] marktraceur: hi. sorry for disappearing, i still have no proper internet connection (i'm tethering). i'm going through backlog and will merge your upload stuff probably. let me know what you need (especially if it can be done while i'm mostly offline, eh.) [15:43:41] OK! [15:55:21] MatmaRex: I'm going to double-check something quick [15:57:31] no hurry, everything takes so fucking long on this connection [15:58:07] We're good now [15:58:16] I rebased it all and double-checked something about promises [16:08:17] prtksxna: I'm going to set up your extension and see what it's up to [16:08:49] prtksxna: Does it give me a tool or do I need a POC gadget? [16:29:55] 6Multimedia, 10MediaWiki-API, 5MW-1.26-release, 5Patch-For-Review, and 2 others: PHP Notice: "Undefined index: value in includes/filerepo/file/ForeignAPIFile.php:201" - https://phabricator.wikimedia.org/T103781#1441822 (10demon) p:5Triage>3Normal [16:37:45] marktraceur: It'll add a link like your gadget does [16:38:51] marktraceur: I am going to sleep now [16:39:02] marktraceur: Will you be available for our meeting later? [16:39:49] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 5Patch-For-Review, 7Technical-Debt, 7Wikimedia-log-errors: [mmv.lightboxinterface] Warning: 'webkitMovementX' is deprecated. Please use 'movementX' instead. - https://phabricator.wikimedia.org/T104758#1441889 (10demon) p:5Triage>3Normal [16:53:11] 6Multimedia, 10MediaWiki-API, 5MW-1.26-release, 5Patch-For-Review, and 2 others: PHP Notice: "Undefined index: value in includes/filerepo/file/ForeignAPIFile.php:201" - https://phabricator.wikimedia.org/T103781#1441987 (10demon) Backported to 1.25 in above ^ [16:53:53] marktraceur: looks good apart from the badToken logic, it's not correct [16:54:35] marktraceur: if getEditToken() itself fails, there's no token, no need to reject it with badToken() [16:55:37] marktraceur: but getToken() caches the tokens forever. so we need to handle the case where a token was fetched hours ago, we get a token successfully from getToken(), but when we try the upload, it turns out the token is no longer valid [16:56:47] MatmaRex: Ah, fair enough [16:57:00] I assumed if any of the promises in the chain failed we might as well invalidate the token [16:57:22] marktraceur: this should generally happen around the same places where we do deferred.reject() [16:57:56] marktraceur: i mean, calling badToken() in the places you call it is not a bug, but it should be a no-op, if i correctly remember how this owrks [16:58:03] would be a no-op* [16:58:21] ┌[；`||～,]┐ z z Z [16:58:29] MatmaRex: A no-op for the case where the getEditToken promise is rejected, but not where other things in the chain are [16:58:46] hm. okay. [16:59:01] I guess I can change it, but seems a mite silly :) [16:59:17] But I can see why you would want it that way [17:05:45] 6Multimedia, 10MediaWiki-ContentHandler, 10MediaWiki-extensions-UploadWizard: Moving From NS_USER to NS_CAMPAIGN leaves the page with the wrong content model - https://phabricator.wikimedia.org/T104408#1442056 (10Tgr) Maybe fixed by https://gerrit.wikimedia.org/r/#/c/222043? Haven't looked at the page move c... [17:09:26] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: "file corrupt" errors on Commons upload when transferring from Flickr - https://phabricator.wikimedia.org/T105224#1442061 (10Tgr) [17:13:55] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: "file corrupt" errors on Commons upload when transferring from Flickr - https://phabricator.wikimedia.org/T105224#1442096 (10Tgr) `Special:Upload` gives > This file contains HTML or script code that may be erroneously interpreted by a web browser. S... [17:37:07] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 10Sentry, 7Epic, and 2 others: Deploy Sentry (JavaScript error logging) to production, configured to log only UploadWizard - https://phabricator.wikimedia.org/T91649#1442261 (10Tgr) [18:19:24] 6Multimedia, 6Performance-Team, 10Wikimedia-Site-requests, 6operations: Please offer larger image thumbnail sizes in Special:Preferences - https://phabricator.wikimedia.org/T65440#1442365 (10Krinkle) p:5Triage>3Normal [18:53:29] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: "file corrupt" errors on Commons upload when transferring from Flickr - https://phabricator.wikimedia.org/T105224#1442519 (10Magnus) Error message is: "This file might be corrupt, or have the wrong extension." [18:54:43] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: "file corrupt" errors on Commons upload when transferring from Flickr - https://phabricator.wikimedia.org/T105224#1442527 (10Magnus) Also, are we seriously blocking JPEG uploads because there //might// be HTML in some EXIF field? [19:42:15] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 5Patch-For-Review, 5WMF-deploy-2015-07-07_(1.26wmf13): MediaViewer cannot be closed in Microsoft Edge - https://phabricator.wikimedia.org/T104381#1442641 (10Dstoreymsft) A fix for this issue has been accepted into MS Edge and should be included in the W... [19:51:05] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: "file corrupt" errors on Commons upload when transferring from Flickr - https://phabricator.wikimedia.org/T105224#1442660 (10Tgr) >>! In T105224#1442527, @Magnus wrote: > Also, are we seriously blocking JPEG uploads because there //might// be HTML i... [19:54:08] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: "file corrupt" errors on Commons upload when transferring from Flickr - https://phabricator.wikimedia.org/T105224#1442680 (10Tgr) >>! In T105224#1442519, @Magnus wrote: > Error message is: > > "This file might be corrupt, or have the wrong extensio... [19:54:47] 6Multimedia, 6Commons, 10MediaWiki-API, 10MediaWiki-File-management, 10MediaWiki-extensions-UploadWizard: "file corrupt" errors on Commons upload when transferring from Flickr - https://phabricator.wikimedia.org/T105224#1442698 (10Tgr) [19:58:39] 6Multimedia, 6Commons, 10MediaWiki-API, 10MediaWiki-File-management, 10MediaWiki-extensions-UploadWizard: Upload API gives unhelpful error when an upload trips the XSS filter - https://phabricator.wikimedia.org/T105224#1442721 (10Tgr) [20:15:29] 6Multimedia, 6Performance-Team, 10Wikimedia-Site-requests, 6operations: Please offer larger image thumbnail sizes in Special:Preferences - https://phabricator.wikimedia.org/T65440#1442794 (10Gilles) These are the sizes currently used by Media Viewer: 320, 800, 1024, 1280, 1920, 2560, 2880 Adding any of t... [21:13:31] (03CR) 10Gilles: Reduce number of RL modules in MultimediaViewer (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/220621 (https://phabricator.wikimedia.org/T103706) (owner: 10Gilles) [21:32:51] (03PS6) 10Gilles: Reduce number of RL modules in MultimediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/220621 (https://phabricator.wikimedia.org/T103706) [21:33:06] (03CR) 10Gilles: Reduce number of RL modules in MultimediaViewer (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/220621 (https://phabricator.wikimedia.org/T103706) (owner: 10Gilles) [21:37:11] (03CR) 10Gilles: "> Any reason to keep all the small reuse modules and some of the mmv.ui stuff?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/220621 (https://phabricator.wikimedia.org/T103706) (owner: 10Gilles) [21:41:20] prtksxna: I just noticed your meeting invitation...I can do it but I'll be hangout-ing from a party. Maybe we should reschedule. [21:54:00] MatmaRex: They don't work? [21:54:40] Oh. [21:54:42] I get it now [21:54:47] I was confused clearly [21:54:56] if you actually have a bad token, you'll never hit that code path which calls badToken() to clear it [21:59:25] (03PS7) 10Gilles: Reduce number of RL modules in MultimediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/220621 (https://phabricator.wikimedia.org/T103706) [22:00:44] (03CR) 10Gilles: "> I think it's good practice to separate bootstrap and bootstrap.autostart (the only module that actually does something, apart from loadi" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/220621 (https://phabricator.wikimedia.org/T103706) (owner: 10Gilles) [22:06:23] (03Abandoned) 10Brion VIBBER: Add vp9 support to webm [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/211729 (owner: 10Paladox) [22:07:22] (03PS8) 10Gilles: Reduce number of RL modules in MultimediaViewer [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/220621 (https://phabricator.wikimedia.org/T103706) [23:49:50] 6Multimedia, 6Performance-Team, 10Wikimedia-Site-requests, 6operations: Please offer larger image thumbnail sizes in Special:Preferences - https://phabricator.wikimedia.org/T65440#1443620 (10Bawolff) Isnt that the point of that extra attribute with the 2x sizes, we already serve?