[06:40:02] (03PS24) 10TheDJ: Improve live loading and ResourceLoader behavior [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://phabricator.wikimedia.org/T74675) [07:38:44] James_F|Away: http://commons.wikimedia.beta.wmflabs.org/wiki/File:Kitty-video-90MB.ogv [07:38:55] that one works on Safari now :) [07:42:32] marktraceur: interesting usage pattern of upload: https://commons.wikimedia.org/wiki/Commons:Upload_Wizard_feedback#Everything_got_deleted.21_.22Stashed_files_not_found.22 [07:43:15] interesting case of "Users would never do that ! Until they do" :) [08:49:07] 6Multimedia, 10MediaWiki-File-management, 7Upstream: Exif values retrieved incorrectly if they appear before IFD - https://phabricator.wikimedia.org/T97253#1505774 (10Colin) I'd like to add my voice to those requesting this fix ASAP. We've had yet another post to the Village Pump from users wondering why the... [09:17:56] 6Multimedia: Superfluous border line in thumbnail - https://phabricator.wikimedia.org/T107742#1505791 (10Aklapper) [09:22:35] 6Multimedia, 10MediaWiki-General-or-Unknown: Release thumbnail changes - https://phabricator.wikimedia.org/T77894#1505794 (10Aklapper) > I can see larger thumbnails by default What does that mean? T65440#1467035 ? T51357 ? Which specific "new thumbnail border changes" (link) is this about? [09:23:12] 6Multimedia, 10Wikimedia-Media-storage: Superfluous border line in thumbnail - https://phabricator.wikimedia.org/T107742#1505800 (10Aklapper) p:5Triage>3Lowest [09:27:26] 6Multimedia, 10Continuous-Integration-Infrastructure, 6operations, 5Patch-For-Review: Investigate impact of switching from ffmpeg to libav (ffmpeg is not in Jessie) - https://phabricator.wikimedia.org/T103335#1505843 (10fgiunchedi) @brion @hashar I've uploaded ffmpeg `7:2.7.2-1~wmf1` to `trusty-wikimedia`... [09:45:10] 6Multimedia, 10Continuous-Integration-Infrastructure, 6operations, 5Patch-For-Review: Investigate impact of switching from ffmpeg to libav (ffmpeg is not in Jessie) - https://phabricator.wikimedia.org/T103335#1505869 (10fgiunchedi) also `ffmpeg2theora` has been rebuilt with ffmpeg and uploaded to `trusty-w... [10:16:48] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 6operations: Support VP9 in TMH (Unable to decode) - https://phabricator.wikimedia.org/T55863#1505913 (10fgiunchedi) @mczusatz looks like only NASA_-_Earth_from_Orbit_2013.webm is able to get fully transcoded, if you'd like to test it yourself as well ge... [11:37:54] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 10UI-Standardization: No space between "Next" button and the "Skip this step in the future" checkbox label in Special:UploadWizard - https://phabricator.wikimedia.org/T107779#1506035 (10matmarex) a:3matmarex [12:00:42] (03CR) 10Bartosz Dziewoński: "https://gerrit.wikimedia.org/r/229112" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/228296 (https://phabricator.wikimedia.org/T97426) (owner: 10Bartosz Dziewoński) [12:06:11] MatmaRex: Why doesn't the isValid() method reject the promise it returns instead of resolving it and returning false? [12:06:36] MatmaRex: How do I check if a group of TextInputWidgets are valid? [12:06:51] prtksxna: no idea. it's a very weird api, we have a bug somewhere [12:07:08] hmm… maybe something like: [12:11:12] MatmaRex: Hm, ok [12:11:27] prtksxna: http://pastebin.com/p5qiDmK9 [12:11:31] MatmaRex: Also, is there a way to stack stuff horizontally in ooui? [12:12:23] prtksxna: not yet! [12:12:35] MatmaRex: Thanks! This would be so much easier if it would just reject the promise :| [12:12:41] MatmaRex: Are there plans? [12:13:53] prtksxna: yeah, i think i'm going to write it… today? a few things came up that could use it recently [12:14:12] \o/ [12:14:15] Awesome! [12:14:17] MatmaRex: Will it be a config for PanelLayout [12:14:19] prtksxna: i was thinking of a "FlowLayout", that would put display: inline-block on all its children, and display them in a line [12:14:58] i'm wondering if it would be more convenient to make it a Widget [12:15:01] hmm [12:15:21] Why not extend one of the existing layouts, stack and panel seem like good candidates [12:16:13] MatmaRex: Why would it be a widget? [12:20:33] prtksxna: hmm [12:20:41] MatmaRex: Should I use the solution you pastied, or are there plans to fix that isValid api? [12:21:58] If its easy enough you could point me to the task and I'll take a stab at it [12:23:09] prtksxna: you can probably use the pastebin thing for now, the closest task is https://phabricator.wikimedia.org/T99831 [12:24:14] * prtksxna nods [12:24:19] although that is just about the bad naming, you also want to change the behavior [12:24:35] right, I'll take a look [12:25:34] But things would break if I change the API :( [12:26:01] yeah, it would be a breaking change, unless we add this as a new method [12:26:21] hmm, yeah, that would make sense [12:26:35] We could deprecate isValid at some point [12:26:48] yeah [12:26:57] Thanks MatmaRex :D [12:27:58] prtksxna: as for the layout thing. it shouldn't matter much if it's a new Layout or an option in one of the existing ones. i mostly worry if it should be a Layout or a Widget. if it was a layout, if couldn't be directly used inside a FieldLayout, for example (you'd need to create a custom widget to "wrap" it) [12:28:10] (which might be a good or bad thing, depending on how you look at it) [12:29:27] the name "FlowLayout" was inspired by an obscure GUI toolkit i'm fond of :P, which uses "stacks" and "flows" to lay out window content (http://shoesrb.com/manual/Slots.html). "HorizontalLayout" might be better, on second thought. [12:30:55] MatmaRex: I'll have to understand and then think about what you just said. I don't have an opinion on this yet. [12:31:20] I am going to go back to working on the upload dialog patch for now [12:32:19] prtksxna: i'm just going to try it out and we'll see how well it works [12:32:28] let me just file a task and find all the use cases for it i had [12:32:40] (y) [12:34:01] MatmaRex: Another stupid question, how can I setup an even handler for multiple widgets at once? Like $( el1, el2).on(…? [12:34:42] i don't tihnk you can, you have to just loop over them or somehting [12:35:26] prtksxna: if you have a GroupElement, there are some methods to do it (#aggregate, i think)? but they looked like a pain to use last time i checked [12:35:41] MatmaRex: ok [12:37:35] MatmaRex: The "values" variable in your pastie doesn't have the return values of the promises, like a boolean, but the promises objects themselves. [12:38:28] MatmaRex: Maybe I am doing something wrong, is this code being used somewhere already? [12:38:29] oh. hmm. [12:38:41] no, i just wrote that and didn't test it well [12:39:11] MatmaRex: I want to setAbilities on the actions of my ProcessDialog based on the validity of the TextInputWidgets in it. [12:39:48] Line 327 of https://gerrit.wikimedia.org/r/#/c/228795/13/resources/src/mediawiki.dialogs/mw.dialogs.Upload.js [12:40:26] http://api.jquery.com/jQuery.when/ seems to say that it should have the return values [12:41:31] MatmaRex: I was doing something stupid [12:41:36] MatmaRex: It works [12:41:57] hah, okay [12:42:25] MatmaRex: Why do we $.when.apply( $, promises).done and now $.when( promises ).done? [12:42:36] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 10UI-Standardization: No space between "Next" button and the "Skip this step in the future" checkbox label in Special:UploadWizard - https://phabricator.wikimedia.org/T107779#1506103 (10matmarex) [12:42:41] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard file upload status runs into action button - https://phabricator.wikimedia.org/T107508#1506105 (10matmarex) [12:43:55] prtksxna: does that latter work? i don't know if $.when can take an array, or only individual arguments [12:44:25] Oh ok, I always confuse how to use apply :| [12:53:24] 6Multimedia, 10MediaWiki-General-or-Unknown, 6WMF-Design: Release thumbnail changes - https://phabricator.wikimedia.org/T77894#1506120 (10Gilles) I think this was about changing the border style around thumbnails, but I can't remember the details. [12:53:28] prtksxna: do you have time for a quick merge? i'd like this to make the next branch cut. https://gerrit.wikimedia.org/r/229117 and https://gerrit.wikimedia.org/r/#/c/229112/1 , you can use https://gerrit.wikimedia.org/r/#/c/226647/10 to test it [12:53:41] (it's about the date input) [12:55:54] MatmaRex: What is wrong with setting it to today if we know nothing? If we don't set anything what will it open to? [12:55:59] MatmaRex: The first change looks good. [12:56:35] prtksxna: it will just be an empty field with the calendar. mark said that automatically setting it to today is inappropriate for uploadwizard [12:56:59] MatmaRex: Ah, but when you focus the field the calendar will open to today? [12:58:18] yes [12:58:37] but the user will still need to click to choose that date [12:59:01] Right, looks good then [12:59:06] I'll test and merge [13:03:43] MatmaRex: Can't test, UW keep giving me "You can only upload files with a size of up to -1 B. You tried to upload a file that is 389 KB." [13:03:49] Normal upload works fine [13:04:25] heh [13:04:54] prtksxna: you can use the testing change i have here: https://gerrit.wikimedia.org/r/#/c/226647/10 [13:05:01] just checkout and visit Special:Blankpage [13:17:29] MatmaRex: Done! [13:19:52] MatmaRex: See line 185 on https://gerrit.wikimedia.org/r/#/c/228795/15/resources/src/mediawiki.dialogs/mw.dialogs.Upload.js when you have time. [13:22:37] MatmaRex: Can we have a ProcessDialog render normally, without a dialog, like just on a page, like UW? [13:27:00] marktraceur: See my comment on PS15 https://gerrit.wikimedia.org/r/#/c/228795/. Thanks! [13:27:09] * prtksxna goes to get dinner [13:46:54] 6Multimedia, 6Commons, 6Performance-Team, 6operations, and 8 others: Convert eqiad imagescalers to HHVM, Trusty - https://phabricator.wikimedia.org/T84842#1506211 (10Joe) 5Open>3Resolved [13:51:21] prtksxna: replied [13:55:02] prtksxna: you could put the ProcessDialog in a WindowManager({modal: false}), but the styles for this are mostly unimplemented and it'll probably fall apart. we use this approach in VE for some dialogs connected to the toolbar, e.g. the find-and-replace one (http://i.imgur.com/cqbBZio.png) [13:59:03] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 10UI-Standardization: No space between "Next" button and the "Skip this step in the future" checkbox label in Special:UploadWizard - https://phabricator.wikimedia.org/T107779#1506266 (10matmarex) p:5Triage>3Normal [14:05:28] (03PS4) 10Bartosz Dziewoński: Use mw.widgets.DateInputWidget instead of jQuery UI datepicker [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/228296 (https://phabricator.wikimedia.org/T97426) [14:05:49] (03PS5) 10Bartosz Dziewoński: Use mw.widgets.DateInputWidget instead of jQuery UI datepicker [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/228296 (https://phabricator.wikimedia.org/T97426) [14:06:02] (03CR) 10Bartosz Dziewoński: "Rebased. Dependencies in core are merged now, try it?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/228296 (https://phabricator.wikimedia.org/T97426) (owner: 10Bartosz Dziewoński) [14:36:34] prtksxna: I replied also... [15:05:35] prtksxna: Did you have a chance to look at https://gerrit.wikimedia.org/r/#/c/224966/ ? [15:10:08] 6Multimedia, 10MediaWiki-File-management, 6Performance-Team: Investigate graphicsmagick performance - https://phabricator.wikimedia.org/T107885#1506413 (10Gilles) 3NEW a:3Gilles [16:04:19] James_F: Not yet, its only my list [16:04:51] MatmaRex marktraceur Thanks! [16:04:57] Yup yup [16:05:12] Seems like I just need to rename the thing and we're good? [16:06:29] I didn't look at the code [16:06:33] MatmaRex: > Probably, everything that you don't intend to be public API. <-- I'd expect people to use only the emitted event and the closing promise. Would that mean that I make everything protected? [16:06:39] marktraceur: ^ [16:06:41] marktraceur: lol [16:06:45] probably. why not? [16:06:58] I don't understand these things well, which is why I ask [16:07:03] Then why did I add getImageInfo even [16:07:24] Oh, wait. No. [16:07:25] Ignore me [16:07:27] marktraceur: We return the upload object when we close the dialog [16:07:39] * marktraceur guzzles Monster [16:34:35] prtksxna: marktraceur: more DateInputWidget followups. https://gerrit.wikimedia.org/r/229153 https://gerrit.wikimedia.org/r/229154 [16:34:55] i'm slowly starting to hate this stupid widget. [16:35:16] bloody thing should've worked correctly five commits ago. [16:36:16] 6Multimedia, 10MediaWiki-File-management, 6Performance-Team: Investigate graphicsmagick performance - https://phabricator.wikimedia.org/T107885#1506737 (10Gilles) Tests conducted using the GM that debian gives me on the VM, which is actually a year older than the IM version we use. On thumbnailing a large P... [16:36:44] marktraceur: i think we should merge https://gerrit.wikimedia.org/r/#/c/228296/ *after branch cut*, and put a brief note in Tech News that UploadWizard's UI will be getting a small revamp and that we're starting with the date selector. [16:37:26] 6Multimedia, 10MediaWiki-File-management, 6Performance-Team: Add support for using graphicsmagick instead of imagemagick for thumbnailing - https://phabricator.wikimedia.org/T21073#1506740 (10Gilles) [16:37:28] 6Multimedia, 10MediaWiki-File-management, 6Performance-Team: Investigate graphicsmagick performance - https://phabricator.wikimedia.org/T107885#1506738 (10Gilles) 5Open>3Resolved GraphicsMagick doesn't seem to be a silver bullet that will make all of our thumbnailing faster, but it could be very useful f... [16:38:06] MatmaRex: More like continuing with the date selector [16:38:13] We already did the buttons... [16:39:10] 6Multimedia, 10MediaWiki-File-management, 6Performance-Team: Add support for using graphicsmagick instead of imagemagick for thumbnailing - https://phabricator.wikimedia.org/T21073#1506745 (10Gilles) a:3Gilles As per some quick tests, it seems like GM is vastly superior than IM for our PNG thumbnailing com... [16:41:07] marktraceur: hah, true [16:43:17] MatmaRex: Anyway, happy to help write that up or whatever else, and yeah, we can wait on merge [16:45:04] marktraceur: at the rate i've been submitting follow-ups for date picker, we'll need another 10 this week. :P [17:02:14] Oh dear. [17:35:46] (03CR) 10MarkTraceur: [C: 04-1] "Small style nitpick and I'm testing it now" (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/228296 (https://phabricator.wikimedia.org/T97426) (owner: 10Bartosz Dziewoński) [17:39:22] (03CR) 10MarkTraceur: "Remaining issues:" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/228296 (https://phabricator.wikimedia.org/T97426) (owner: 10Bartosz Dziewoński) [17:39:49] (03CR) 10MarkTraceur: "Oh, maybe the core dependencies are not installed on my local, one sec" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/228296 (https://phabricator.wikimedia.org/T97426) (owner: 10Bartosz Dziewoński) [17:44:57] (03CR) 10MarkTraceur: "Yeah, seems fine apart from the one code style thing." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/228296 (https://phabricator.wikimedia.org/T97426) (owner: 10Bartosz Dziewoński) [17:47:15] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 5Patch-For-Review, 5WMF-deploy-2015-08-04_(1.26wmf17), 7user-notice: Support ogv.js in player - https://phabricator.wikimedia.org/T63823#1506969 (10brion) Adding user-notice tag, as this is something worth noting. :) I do recommend a 'soft launch' be... [17:52:09] (03CR) 10Bartosz Dziewoński: Use mw.widgets.DateInputWidget instead of jQuery UI datepicker (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/228296 (https://phabricator.wikimedia.org/T97426) (owner: 10Bartosz Dziewoński) [17:52:21] (03PS6) 10Bartosz Dziewoński: Use mw.widgets.DateInputWidget instead of jQuery UI datepicker [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/228296 (https://phabricator.wikimedia.org/T97426) [17:56:10] marktraceur: Does "fine apart from the one code style thing" mean I can merge it now that's fixed? ;-) [17:56:20] James_F: after branch cut [17:56:25] MatmaRex: Happened already. [17:56:29] okay. [17:56:39] MatmaRex: Given that we've merged the Sajax removal… [17:57:07] ugh. looks like i'm the only one who cares about broken scripts [17:57:13] oh well [17:57:18] Also, we clearly need to move UW to extension.json for my sanity. [17:57:43] MatmaRex: We care, we just don't want to keep lashing ourselves to the mast forever. [17:57:47] marktraceur: is there a reason why you use 'oo' instead of 'OO' for OOjs and OOjs UI stuff? [17:58:10] (and can i globally replace it in UW?) [18:05:18] MatmaRex: Go for it. [18:08:01] (03CR) 10Jforrester: [C: 032] "No-op (though this might be a bit fun for merge conflicts)." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/229167 (owner: 10Bartosz Dziewoński) [18:14:53] if i switch from native (which is non-working perian for me) to ogv.js, I don't get audio on mac os x. small issue. i'll file a ticket. [18:14:56] brion: ^ [18:15:22] thedj: ok, i'll take a look [18:15:47] and after playback of a clip i got: [18:15:48] TypeError: null is not an object (evaluating 'buffers.length') [18:15:49] popNextBuffer [18:15:49] audioProcess [18:15:57] is that in the worker of ogv.js ? [18:17:04] thedj: that looks like the audio output adapter class (AudioFeeder) [18:17:17] probably something failed to initialize the audio context properly and it got lost [18:17:18] (03Merged) 10jenkins-bot: SpecialUploadWizard: Reindent the massive HTML blob [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/229167 (owner: 10Bartosz Dziewoński) [18:17:46] brion: it was end-of-playback [18:18:08] same session actually, so perhaps it's the one that is missing from my earlier switch. [18:18:45] yeah could be related [18:18:57] i haven't tested with QT plugins present in safari so that'll be a fun thing to test :D [18:19:15] (old xiph qt components don't even seem to apply, probably cause they're ancient 32-bit) [18:19:18] brion: don't... lemme test if i can repreduce it in a different way [18:19:22] heh ok [18:19:44] it's hard to properly get rid of again [18:26:42] (03PS1) 10Bartosz Dziewoński: Don't put 'Thanks' step buttons in a ButtonGroupWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/229182 [18:26:44] (03PS1) 10Bartosz Dziewoński: Move file upload status labels from PHP to JS, and display them better [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/229183 (https://phabricator.wikimedia.org/T107508) [18:27:02] (03CR) 10Bartosz Dziewoński: [C: 04-2] "Depends on https://gerrit.wikimedia.org/r/229139" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/229182 (owner: 10Bartosz Dziewoński) [18:27:42] (03CR) 10jenkins-bot: [V: 04-1] Move file upload status labels from PHP to JS, and display them better [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/229183 (https://phabricator.wikimedia.org/T107508) (owner: 10Bartosz Dziewoński) [18:27:51] (03CR) 10jenkins-bot: [V: 04-1] Don't put 'Thanks' step buttons in a ButtonGroupWidget [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/229182 (owner: 10Bartosz Dziewoński) [18:33:13] MatmaRex: I usually shortcut OO to oo the same way we shortcut jQuery to $, it's passed into the wrapper function [18:34:17] yeah. why? [18:36:24] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler: ogv.js doesn't start audio when switching players - https://phabricator.wikimedia.org/T107920#1507223 (10TheDJ) 3NEW [18:36:34] brion: ^ reproduced with Chrome [18:37:00] MatmaRex: Just a matter of using local variables instead of globals, I guess? It seemed to make more sense according to the code conventions I'm used to. [18:37:45] OO -> OO would also do that [18:37:53] right ? [18:37:56] I mean, I guess [18:38:39] meh, whatever [18:39:12] thedj: curious! confirmed here in chrome, i'll see if i can track it down [18:39:34] (03PS25) 10TheDJ: Improve live loading and ResourceLoader behavior [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://phabricator.wikimedia.org/T74675) [18:40:16] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler: ogv.js doesn't start audio when switching players - https://phabricator.wikimedia.org/T107920#1507258 (10brion) a:3brion Can repro at https://ogvjs-testing.wmflabs.org/wiki/File:Folgers.ogv for now... [18:44:28] anyone would object if I deactivate cortado ? [18:44:52] It seems thoroughly useless (and has been for a while actually) [18:44:54] thedj: go for it! i was going to patch that up later but feel free :D [18:45:01] patch that up == patch to remove it :D [18:48:25] (03CR) 10MarkTraceur: [C: 031] "We're going to wait until the branch cut to merge this, because we don't want to push it out quiiiite yet." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/228296 (https://phabricator.wikimedia.org/T97426) (owner: 10Bartosz Dziewoński) [18:52:01] MatmaRex: I guess the branch was already cut... [18:53:08] yeah [18:53:12] ship it? [18:53:14] Yup! [18:53:18] (03CR) 10MarkTraceur: [C: 032] "Never mind, branch already cut, merging as this looks fine to me." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/228296 (https://phabricator.wikimedia.org/T97426) (owner: 10Bartosz Dziewoński) [18:53:35] Tech news is next on my list...then merging prtksxna's dialog patch maybe [18:54:28] (03Merged) 10jenkins-bot: Use mw.widgets.DateInputWidget instead of jQuery UI datepicker [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/228296 (https://phabricator.wikimedia.org/T97426) (owner: 10Bartosz Dziewoński) [18:55:00] brion: w00t [18:55:01] https://test.wikipedia.org/wiki/User:TheDJ/movietests [18:55:02] :) [18:55:07] it all works :) [18:55:23] oh, tech news. good point. [18:55:44] i'll also file myself a ticket for figuring out how to get subtitles working [18:56:17] probably just a layer issue or something [18:58:20] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 10Wikimedia-Video: TMH subtitles not yet available with ogv.js player - https://phabricator.wikimedia.org/T107924#1507369 (10brion) 3NEW a:3brion [18:59:41] thedj: thanks for helping review and test! always good to have more eyes on it to break stuff :D [19:02:17] (03PS1) 10TheDJ: Disable Cortado [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/229187 [19:03:35] (03PS1) 10Bartosz Dziewoński: Move "Skip tutorial" checkbox from PHP to JS, and display it better [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/229188 (https://phabricator.wikimedia.org/T107779) [19:03:54] "better" [19:04:34] I assume 107779 is the "no space between..." bug [19:04:41] yes [19:04:46] (03CR) 10jenkins-bot: [V: 04-1] Move "Skip tutorial" checkbox from PHP to JS, and display it better [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/229188 (https://phabricator.wikimedia.org/T107779) (owner: 10Bartosz Dziewoński) [19:04:48] feel free to reword :P [19:04:49] K, that can be next on my review list [19:04:53] Fix it quick! :) [19:04:59] tests are failing because of the OOUI dependnecy [19:05:08] (03CR) 10Brion VIBBER: [C: 032] "kill it with fire" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/229187 (owner: 10TheDJ) [19:05:36] (03Merged) 10jenkins-bot: Disable Cortado [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/229187 (owner: 10TheDJ) [19:05:49] brion: the fire part is still coming :) [19:25:43] (03PS1) 10TheDJ: Cortado: fully and wholly remove it [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/229191 [19:25:51] RIP [19:26:46] It occurs to me that our error/warning handling in mw.Upload leaves a lot to be desired [19:28:22] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 10VisualEditor, 7Epic: Preview video while editing with VE - https://phabricator.wikimedia.org/T103096#1507570 (10Jdforrester-WMF) p:5Triage>3Low [19:28:56] * thedj feels like Drogon [19:30:16] marktraceur: i think we should do a lot of logging on all those errors/warnings. it's a killer on user experience and we need to get it right and understand the workflow for pretty much each error situation. [19:32:14] True. [19:32:27] But we don't even have a solid upload workflow anymore [19:32:32] So...gotta get there first [19:41:21] prtksxna: I can't believe siebrand hasn't cracked the whip at you yet. :) [19:41:25] * thedj looking into RejectParserCacheValue [19:41:45] marktraceur: that's because he is on his bike right now :) [19:42:18] Oh! [19:42:21] That would explain it, yes. [19:43:18] (03PS1) 10Bartosz Dziewoński: .gitreview: Set defaultrebase=0, like in mediawiki/core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/229196 [19:46:09] prtksxna: So next up, is it relatively simple to use the UI you made to add this business to VisualEditor or do we need to move in a different direction for that? [19:46:25] Because I don't know anything about that world and it would be good to have a plan for when we need to do that [20:07:06] (03CR) 10MarkTraceur: [C: 032] "Nifty." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/229196 (owner: 10Bartosz Dziewoński) [20:08:16] (03Merged) 10jenkins-bot: .gitreview: Set defaultrebase=0, like in mediawiki/core [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/229196 (owner: 10Bartosz Dziewoński) [20:23:24] marktraceur: Want to cry? Switch 'grunt-jscs' from 1.8.0 to 2.0.0 in UW and run `npm install && grunt jscs`. [20:42:14] James_F: I'm afraid to. [20:42:33] marktraceur: Good news: jscs now only shows the first 50 issues before giving up. [20:42:35] So… :-) [20:42:40] Oh, perfect. [20:44:20] brion: https://phabricator.wikimedia.org/T74675#1507867 [20:44:51] fun... [20:44:57] ... what's the current hook use? /me checks [20:45:27] for that hook ? only syntaxhighlighter has used that hook so far [20:47:31] ugh it adds the modules straight onto outputPage instead of through the parser output [20:47:35] * brion headdesk [20:47:40] i hoped that hook would save my ass and make this simple, but it seems more difficult than i even figured. [20:47:56] "well"... [20:48:04] actually it adds loaderscripts to the startup module. [20:48:23] i guess you could just strstr() the parser output html for