[01:29:16] (03CR) 10BBlack: [C: 031] Remove CORS metrics [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/230982 (https://phabricator.wikimedia.org/T507) (owner: 10Gergő Tisza) [01:31:40] (03CR) 10Jforrester: [C: 031] Remove CORS metrics [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/230982 (https://phabricator.wikimedia.org/T507) (owner: 10Gergő Tisza) [02:13:10] 6Multimedia, 10MediaWiki-Parser: Internal audio links need a loudspeaker icon - https://phabricator.wikimedia.org/T5726#1533800 (10Whatamidoing-WMF) [02:29:37] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 10OTRS, 7HTTPS: Following links back on-wiki from OTRS is breaking JavaScript somehow - https://phabricator.wikimedia.org/T108834#1533826 (10Legoktm) [02:51:34] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 10OTRS, 7HTTPS: Following links back on-wiki from OTRS is breaking JavaScript somehow - https://phabricator.wikimedia.org/T108834#1533843 (10Jdforrester-WMF) p:5Triage>3High [09:41:40] My mediawiki installations is giving me issues (see -dev), switching to ooui tasks for the day [11:47:03] (03PS18) 10Paladox: Add extension.json, empty PHP entry point [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187471 (https://phabricator.wikimedia.org/T87988) (owner: 10Gilles) [11:47:17] (03CR) 10Paladox: [C: 031] Add extension.json, empty PHP entry point [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/187471 (https://phabricator.wikimedia.org/T87988) (owner: 10Gilles) [12:31:06] (03PS10) 10Paladox: Add extension.json, empty PHP entry point [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/187735 (https://phabricator.wikimedia.org/T87943) (owner: 10Gilles) [12:31:14] (03CR) 10jenkins-bot: [V: 04-1] Add extension.json, empty PHP entry point [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/187735 (https://phabricator.wikimedia.org/T87943) (owner: 10Gilles) [12:33:54] (03PS11) 10Paladox: Add extension.json, empty PHP entry point [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/187735 (https://phabricator.wikimedia.org/T87943) (owner: 10Gilles) [12:36:00] (03CR) 10Paladox: [C: 031] "Code looks good not tested." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/187735 (https://phabricator.wikimedia.org/T87943) (owner: 10Gilles) [12:48:13] 6Multimedia, 10MediaWiki-Vagrant, 10MediaWiki-extensions-TimedMediaHandler, 7Upstream: ogv transcodes have broken audio tracks with ffmpeg2theora 0.29 (Trusty upstream) - https://phabricator.wikimedia.org/T69953#1534672 (10fgiunchedi) >>! In T69953#1528506, @brion wrote: > Ok I've got a provisional patch f... [14:44:37] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 10OTRS, 7HTTPS: Following links back on-wiki from OTRS is breaking JavaScript somehow - https://phabricator.wikimedia.org/T108834#1535132 (10MarkTraceur) @Legoktm I don't suppose you could give me the raw request/response data for that, could you? [14:47:47] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 10OTRS, 7HTTPS: Following links back on-wiki from OTRS is breaking JavaScript somehow - https://phabricator.wikimedia.org/T108834#1535143 (10Aklapper) >>! In T108834#1532283, @Steinsplitter wrote: > I see the raw text when navigating to https://commons.wiki... [15:18:23] marktraceur: do you want me to copy the html of the page? [15:24:51] 6Multimedia, 10MediaWiki-Vagrant, 10MediaWiki-extensions-TimedMediaHandler, 7Upstream: ogv transcodes have broken audio tracks with ffmpeg2theora 0.29 (Trusty upstream) - https://phabricator.wikimedia.org/T69953#1535343 (10brion) Confirmed working with updated packge in MediaWiki-Vagrant. :D [15:29:36] legoktm: Sure [15:30:48] legoktm: Maybe it's somehow a cookie thing? But that wouldn't make sense unless the cookie got eaten after the request to Commons... [15:31:46] https://dpaste.de/Af79/raw [15:31:56] And I can't imagine why we'd be sending cookies to MW from OTRS [15:33:23] well, it breaks all JS on the page [15:33:33] not just UW [15:33:58] Hrm. [15:34:12] legoktm: Are there failed requests in the browser log? [15:34:21] Or JS errors in the console? [15:34:47] looking at my network console, it doesn't try loading any JS [15:34:52] all the requests are for only=styles [15:34:58] and those are all 304s [15:36:25] I'm now clicking through random pages on commons in the same tab, and JS isn't loading on any of them [15:36:40] as soon as I open a new tab everything is fine [15:37:37] I don't see how OTRS is able to tell my browser to stop serving JavaScript. [15:37:43] er, processing* JS [15:41:27] marktraceur: alright, progress! The same bug happens in Chromium, but UW doesn't look like shit and the fallback form displays properly [15:42:29] http://i.imgur.com/tJv6HzU.png [15:44:20] (03CR) 10Brion VIBBER: [C: 04-1] "Stray file MwEmbedModules/EmbedPlayer/resources/mw.processEmbedPlayers.js2 ?" (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/229191 (owner: 10TheDJ) [15:45:45] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 10OTRS, 7HTTPS: Following links back on-wiki from OTRS is breaking JavaScript somehow - https://phabricator.wikimedia.org/T108834#1535416 (10Legoktm) In Chromium 43ish, JavaScript is still disabled, but the fallback form displays fine: {F1470579} [15:56:17] 6Multimedia, 6Labs, 6operations, 10wikitech.wikimedia.org, and 2 others: Some wikitech.wikimedia.org thumbnails broken (404) - https://phabricator.wikimedia.org/T93041#1535441 (10Krenair) I checked several other images and most of them showed the same error. [15:59:49] legoktm: OK, so that's weird, but what on earth could be causing both of those situations [16:02:00] andre responded with useful answers... [16:02:13] Does OTRS set a weird encoding header somehow? [16:04:57] lemme see [16:06:11] legoktm: And did you paste the source from the broken page or the working page? [16:06:44] Because I don't see Andre's flawed characters anywhere [16:08:52] marktraceur: https://dpaste.de/0eK6/raw that's copied straight from the network console instead of view-source [16:09:05] Hmmm [16:09:28] Ah, there it is. [16:10:48] Can't repro the raw HTML with that [16:10:59] And JS seems to run just fine for me...trying Chrome [16:11:23] maybe Keegan can set you up with an OTRS account? [16:12:08] It's on my probably to-do list [16:12:10] He does not seem motivated [16:20:08] marktraceur: ygm [16:23:05] Oh thanks. [16:23:09] (03PS3) 10Florianschmidtwelzow: Re-add event listeners to images after a finished VE edit [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/231079 (https://phabricator.wikimedia.org/T97010) [16:25:41] (03PS7) 10Brion VIBBER: Optional MJPEG/mu-law MOV/WAV transcodes for iOS fallback [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/217295 [16:26:27] (03Abandoned) 10Brion VIBBER: Optional MJPEG/mu-law MOV/WAV transcodes for iOS fallback [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/217295 (owner: 10Brion VIBBER) [16:27:21] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 5Patch-For-Review: Support MJPEG & PCM audio as last-ditch fallback output for iOS - https://phabricator.wikimedia.org/T101716#1535646 (10brion) [16:27:23] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 7Mobile: TMH totally broken on mobile - https://phabricator.wikimedia.org/T62565#1535645 (10brion) [16:27:30] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 5Patch-For-Review: Support MJPEG & PCM audio as last-ditch fallback output for iOS - https://phabricator.wikimedia.org/T101716#1346126 (10brion) [16:27:32] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 7Accessibility, 7Mobile: TimedMediaHandler user experience is poor on mobile - https://phabricator.wikimedia.org/T98491#1535647 (10brion) [16:28:19] Keegan: This is *super fucking weird* [16:28:29] I am not at all closer to finding any solution though [16:28:37] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 5Patch-For-Review: Support MJPEG & PCM audio as last-ditch fallback output for iOS - https://phabricator.wikimedia.org/T101716#1535651 (10brion) 5Open>3declined ogv.js is deployed for desktop and getting closer for mobile, so there's less need to go... [16:29:08] marktraceur: as we like to say [16:29:12] WELCOME TO OTRS [16:29:36] Points if you put "this is super fucking weird" as the phab comment. [16:29:54] Oh no, friendly space [16:30:05] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 6operations, 7HHVM: Convert tmh100[12] to HHVM and trusty - https://phabricator.wikimedia.org/T104747#1535658 (10brion) [16:30:07] 6Multimedia, 10MediaWiki-Vagrant, 10MediaWiki-extensions-TimedMediaHandler, 7Upstream: ogv transcodes have broken audio tracks with ffmpeg2theora 0.29 (Trusty upstream) - https://phabricator.wikimedia.org/T69953#1535656 (10brion) 5Open>3Resolved a:3brion [16:31:39] 6Multimedia, 10Continuous-Integration-Infrastructure, 6operations, 5Patch-For-Review: Investigate impact of switching from ffmpeg to libav (ffmpeg is not in Jessie) - https://phabricator.wikimedia.org/T103335#1535660 (10brion) Ok closed out T69953 as the updated ffmpeg2theora gets things working. I think w... [16:39:24] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 10OTRS, 7HTTPS: Following links back on-wiki from OTRS is breaking JavaScript somehow - https://phabricator.wikimedia.org/T108834#1535706 (10MarkTraceur) Just tried with debug=true, diffed the responses, no differences anymore except for edit/watch/patrol t... [16:39:33] Keegan: I tried [16:39:39] (03PS4) 10Brion VIBBER: Add support for WebM VP9/Opus transcodes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/229397 (https://phabricator.wikimedia.org/T63805) [16:40:09] marktraceur: You did. I shall close the account shortly [16:40:31] Probably no issue with that, I now have a tab that is infected with the diseeeeease [16:41:52] * Keegan slinks away [16:46:18] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 10OTRS, 7HTTPS: Following links back on-wiki from OTRS is breaking JavaScript somehow - https://phabricator.wikimedia.org/T108834#1535771 (10MarkTraceur) I spoke too soon, I don't know how I mixed up my responses, but the same diffs are there... [16:55:14] (03PS3) 10Jforrester: Clean up transcode info table on File: page [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/230365 (owner: 10Brion VIBBER) [16:55:21] (03CR) 10Jforrester: [C: 031] Clean up transcode info table on File: page [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/230365 (owner: 10Brion VIBBER) [16:55:36] All because of a missing comma [16:55:39] (╯°□°）╯︵ ┻━┻ THIS IS RIDICULOUS [16:55:40] It must be these encoding errors [16:55:56] prtksxna: What were you fighting with? :) [16:56:15] Mediawiki on vagrant was giving me a 503 [16:56:18] Ah. [16:56:48] It was because the update script was failing silently when I ran git-update. It was failing because of a missing comma in one of my extensions. [16:58:01] http://╯‵д′╯彡┻━┻.wmflabs.org/wiki/Main_Page [17:01:28] :D [17:09:02] Keegan: Friendly space doesn't prevent marktraceur saying that. :-) [17:09:25] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 10OTRS, 7HTTPS: Following links back on-wiki from OTRS is breaking JavaScript somehow - https://phabricator.wikimedia.org/T108834#1535936 (10Tgr) `Blocked script execution in 'https://commons.wikimedia.org/wiki/Special:Preferences' because the document's fr... [17:09:36] James_F: Fair point [17:11:28] (03PS5) 10Brion VIBBER: Add support for WebM VP9/Opus playback and transcodes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/229397 (https://phabricator.wikimedia.org/T62272) [17:11:31] (03PS1) 10Brion VIBBER: Fix playback of WebM source files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/231309 (https://phabricator.wikimedia.org/T91431) [17:14:08] (03PS4) 10Brion VIBBER: Clean up transcode info table on File: page [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/230365 [17:14:30] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 10OTRS, 7HTTPS: Following links back on-wiki from OTRS is breaking JavaScript somehow - https://phabricator.wikimedia.org/T108834#1535984 (10Tgr) So it seems that OTRS displays the email contents in an iframe with `sandbox="allow-same-origin allow-popups"`... [17:17:13] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 10OTRS, 7HTTPS: Following links back on-wiki from OTRS is breaking JavaScript somehow - https://phabricator.wikimedia.org/T108834#1535993 (10MarkTraceur) Oh. Wow. Holy crap. So do we want to "fix" this somehow? [17:19:38] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 10OTRS, 7HTTPS: Following links back on-wiki from OTRS is breaking JavaScript somehow - https://phabricator.wikimedia.org/T108834#1536002 (10valhallasw) Simple example case: https://tools.wmflabs.org/gerrit-reviewer-bot/sandbox/frame.html [17:24:02] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 10OTRS, 7HTTPS, 7Security-Other: Following links back on-wiki from OTRS is breaking JavaScript somehow - https://phabricator.wikimedia.org/T108834#1536026 (10Tgr) [[ https://html.spec.whatwg.org/multipage/embedded-content.html#attr-iframe-sandbox | WHATWG... [17:29:49] (03PS1) 10Brion VIBBER: Use ResourceLoader for ogv.js core [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/231314 [17:30:48] (03CR) 10Brion VIBBER: "@thedj: here's that fix you asked for to load ogv.js via ResourceLoader." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/231314 (owner: 10Brion VIBBER) [17:48:28] (03PS11) 10Brion VIBBER: WIP: very basic TimedMediaHandler frontend for mobile [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/217485 [17:50:44] (03CR) 10Brion VIBBER: "Fixed for updates to TMH and MobileFrontend:" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/217485 (owner: 10Brion VIBBER) [18:30:31] 6Multimedia, 10MediaWiki-extensions-ImageMetrics, 7Performance, 3Reading-Web: ext.imageMetrics.head should only load on File pages - https://phabricator.wikimedia.org/T100378#1536309 (10Jhernandez) [18:32:13] 6Multimedia, 10MediaWiki-extensions-ImageMetrics, 7Performance, 3Reading-Web: ext.imageMetrics.head should only load on File pages - https://phabricator.wikimedia.org/T100378#1536317 (10Jhernandez) @tgr @gilles I've edited title based on your comment. Could it be reasonable? Do you want us to help with th... [18:37:32] 6Multimedia, 10MediaWiki-extensions-ImageMetrics, 7Performance, 3Reading-Web: ext.imageMetrics.head should only load on File pages - https://phabricator.wikimedia.org/T100378#1536342 (10Tgr) Fixed in https://gerrit.wikimedia.org/r/#/c/230982/. [18:55:47] 6Multimedia, 10MediaWiki-extensions-ImageMetrics, 7Performance, 3Reading-Web: ext.imageMetrics.head should only load on File pages - https://phabricator.wikimedia.org/T100378#1536490 (10Jhernandez) [19:12:37] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Gadgets: [Story] Use MediaViewer on commonsMedia properties on Wikibase repo - https://phabricator.wikimedia.org/T71456#1536576 (10Lydia_Pintscher) [19:18:42] 6Multimedia, 10MediaWiki-extensions-PagedTiffHandler, 7Wikimedia-log-errors: Division by 0 in PagedTiffHandler_body.php on line 807 (and 806) - https://phabricator.wikimedia.org/T108983#1536605 (10demon) 3NEW [19:19:50] 6Multimedia, 10MediaWiki-extensions-PagedTiffHandler, 7Wikimedia-log-errors: Division by 0 in PagedTiffHandler_body.php on line 807 (and 806) - https://phabricator.wikimedia.org/T108983#1536617 (10Reedy) https://github.com/wikimedia/mediawiki-extensions-PagedTiffHandler/blob/master/PagedTiffHandler_body.php#... [19:21:38] 6Multimedia, 10MediaWiki-extensions-PagedTiffHandler, 7Wikimedia-log-errors: Division by 0 in PagedTiffHandler_body.php on line 807 (and 806) - https://phabricator.wikimedia.org/T108983#1536630 (10demon) Probably happens when $srcWidth is 0. [19:29:28] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Gadgets: [Story] Use MediaViewer on commonsMedia properties on Wikibase repo - https://phabricator.wikimedia.org/T71456#1536679 (10Tgr) See second and third points in T108778#1530558. [19:42:20] (03CR) 10Jdlrobson: [C: 032] Remove CORS metrics [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/230982 (https://phabricator.wikimedia.org/T507) (owner: 10Gergő Tisza) [19:46:09] (03Merged) 10jenkins-bot: Remove CORS metrics [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/230982 (https://phabricator.wikimedia.org/T507) (owner: 10Gergő Tisza) [19:56:27] 6Multimedia, 10MediaWiki-extensions-ImageMetrics, 7Performance, 3Reading-Web: ext.imageMetrics.head should only load on File pages - https://phabricator.wikimedia.org/T100378#1536855 (10Jdlrobson) 5Open>3Resolved a:3Jdlrobson This is now fixed. [20:11:37] (03PS1) 10MarkTraceur: Add (unused) library for uploading to Commons [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/231408 [20:11:45] 'bout time. [20:12:24] (03CR) 10MarkTraceur: "Note that the bulk of this code has been tested with a userscript on en.wiki and en.wiki.beta." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/231408 (owner: 10MarkTraceur) [20:19:30] marktraceur: whee [20:19:47] marktraceur: in extensions/UploadWizard? do we not want to use that for VE? [20:23:06] I...ugh [20:23:12] MatmaRex: I cannot think of a good place for it [20:23:19] I don't like core, because it's Commons-specific [20:23:28] I don't like CommonsMetadata because it's only borderline related [20:23:36] I don't like VE itself because this is useful for other things [20:23:50] I'm thinking of just dumping upload tools and libraries into UploadWizard and renaming it much, much later on [20:24:01] Because ostriches will be sad about having to rename a repository [20:24:11] eh [20:24:17] how commons-specific is it, really? [20:24:29] I mean, "hard-coded" commons URLs for the API config [20:24:30] other than the hardcoded URL, it look like a generic cross-wiki upload thingie [20:24:35] looks* [20:24:36] But you can subclass [20:24:40] And use it for a different site [20:24:48] I guessssss we could put it somewhere else [20:25:22] marktraceur: i'd totally put this baby in core. rename it to ForeignRepoUpload, or CrossWikiUpload, or whatever. [20:25:38] marktraceur: and make the target host configurable via constructor parameters [20:26:12] hmm, although also knows about CentralAuth. [20:26:24] And {{information}} [20:27:47] hmph. [20:35:13] marktraceur: eh, i think we're setting ourselves up for a situation where we'll have to copy the code all over. [20:36:27] marktraceur: why do we need to specially handle centralauth there? [20:38:16] MatmaRex: I guess "we don't" but we'd need to eventually [20:38:35] yeah, ok, but why? what does it do? [20:39:22] last time i checked you could totally do cross-wiki requests between wikimedia wikis without bothering centralauth. [20:39:31] i just don't understand what is the purpose of that bit [20:39:46] MatmaRex: The upload would be anonymous without it [20:39:48] MatmaRex: Don't we need to trigger it to auto-create a Commons account if it doesn't already exist? [20:39:49] i think wikidata does it [20:40:30] As far as I recall from what I *tried* to do... [20:46:31] ugh, i hate wikidata's code [20:46:48] i know now that their class for this is wikibase.api.RepoApi [20:46:55] i just can't find where the damned thing is defined [20:50:02] Ew. [20:52:55] graaah, they have a separate extension called WikibaseJavaScriptApi. [20:53:18] var SELF = MODULE.RepoApi = function WbApiRepoApi( api ) { [20:53:28] marktraceur: dude, that's even less grappable what what you do. [20:53:34] than what. [20:53:34] :> [20:54:15] And that's saying something! [20:54:24] CentralAuth is terrible and so is CORS and there's no way around them [20:55:14] If one line has "api" on it four times, you might be doing something wrong [20:56:24] hmm, actually the method which i want might be wb.api.getLocationAgnosticMwApi. [20:56:59] and, well, this is not easy to tell, but Wikibase doesn't seem to do any special CentralAuth handling. [20:57:12] A getter wouldn't need it [20:57:15] so either their code is rubbish, or we don't need to either. [20:57:26] But when we're uploading we need to tell the remote wiki what account is being used [20:57:59] marktraceur: oooh, there's also a ForeignApi in MobileFrontend. [20:57:59] Er, or [20:58:05] Oh, christ [20:58:10] (i just grepped mw/extensions for 'centralauthtoken', and that came up.) [20:58:17] so, yeah [20:58:36] we're now creating a third cross-wiki API handling library [20:58:52] I didn't think any existed. My bad. [20:58:58] But honestly it's not that much code. [20:58:58] me neither [20:59:19] Which is why it's easier to write it into each use case than to make a general thing [20:59:56] yeah [21:00:16] mobile's code actually has some fairly fancy token handling. there's a postWithToken() method which handles both kinds of tokens. [21:00:36] Painful [21:01:06] 6Multimedia, 10MediaWiki-extensions-ImageMetrics, 5Patch-For-Review, 3Reading-Web: [ImageMetricsCorsSupport] Missing or empty schema - https://phabricator.wikimedia.org/T97475#1537270 (10Tgr) 5Open>3Resolved a:3Tgr [21:01:19] 6Multimedia, 10MediaWiki-extensions-ImageMetrics, 6Reading-Infrastructure-Team, 5Patch-For-Review, 5WMF-deploy-2015-08-18_(1.26wmf19): Use Cache-Control over cache-busting query args if possible, please - https://phabricator.wikimedia.org/T108707#1537273 (10Tgr) 5Open>3Resolved a:3Tgr [21:01:29] 6Multimedia, 10MediaWiki-extensions-ImageMetrics, 10MobileFrontend, 5Patch-For-Review, 3Reading-Web: cors-test.js 404s on mobile on beta labs - https://phabricator.wikimedia.org/T108206#1537275 (10Tgr) 5Open>3Resolved a:3Tgr [21:03:38] marktraceur: ugh, on second thought. that code seems to handle way too many things. [21:06:29] (although it does have some good ideas) [21:16:17] marktraceur: further thoughts. i think in the perfect world, mw.Upload shouldn't even know where it is uploading it. it should just take a mw.Api object (instead of 'apiconfig', like now). then, we'd create a mw.ForeignApi that extends mw.Api, and mw.ForeignApi would transparently handle CORS, tokens and all that. [21:16:38] I guess that would work. [21:17:41] then we have this CommonsUpload, which only cares about how to format the description page using {{information}} template. [21:17:57] (actually, maybe we should be handling this part in the dialog?) [21:18:14] (but anyway.) [21:19:12] marktraceur: and assuming that we'll need {{information}}-enabled upload in VE, i still think we should put the thing in core. [21:19:21] Yeah, sure [21:19:26] I'll probably rewrite it all in core [21:19:31] Well, move it all around anywho [21:19:36] or we can invent an extension for it, and it alone [21:19:46] but that doesn't seem like a good use of our efforts [21:39:09] marktraceur: okay, what i'm going to do is make my perfect world happen. there's already a bug for it (https://phabricator.wikimedia.org/T66636). [21:39:25] marktraceur: please let me know if you need me to work on anything more multimedia-related. [21:40:21] marktraceur: i'm not sure what our timelines are, and i've been mavericking around a bit lately. i need you to tell me if there are things that need to get done, and i'll get them done first thing. but do tell me. [21:40:39] i'm not sure if you're happy with what i've been working on, or are just putting up with it. [21:55:52] MatmaRex: I'll need you once all of these libraries and dialogs are done, to do the VE integration properly [21:55:58] 6Multimedia, 10MediaWiki-File-management: Site-wide styles for images - https://phabricator.wikimedia.org/T90914#1537596 (10Tgr) We could also just not invalidate: if you change the definition, images will change somewhere in the next 30 days. That does not sound too horrible to me. In any case, introducing t... [21:56:12] If you wanted to do a proof-of-concept with mw.Upload.Dialog as a start that would maybe be useful, but it's up to you [21:56:30] But that code is, I assume, necessary for our work anyway [21:56:38] So that's plenty Multimedia-y for me. [22:12:25] * bd808 whines at MatmaRex for an ooui date widget [22:13:18] what, it exists. [22:13:26] but in MW, not in OOUI itself. [22:13:42] well Brad needs it in MW I think, right? [22:13:49] * MatmaRex stabs bd808 with mw.widgets.DateInputWidget [22:14:08] bd808: we're using it in UploadWizard, if you want to see a demo. :) [22:17:52] cool. Did Brad need a time widget too? -- https://gerrit.wikimedia.org/r/#/c/216909/ [22:20:28] bd808: He's got it. [22:20:42] bd808: I don't know. [22:21:54] bd808: Possibly? We don't have a design for a time input widget yet. [22:22:21] yeah... and his design/implementation got panned in review [22:22:47] I'm pretty sure he needs datetime for https://en.wikipedia.org/wiki/Special:ApiSandbox [22:22:48] :-( [22:23:38] Which bit of it? [22:24:11] Is this for basetimestamp/startimestamp magic? That'd be neat. [22:25:03] now is the time when I get all managery and hand wavy and jsut say "Brad told me he needed it to finish" [22:25:08] :-) [22:25:42] Personally I didn't care either way about the design. My problem was adding i18n to OOUI rather than using MW's i18n.