[09:18:28] 6Multimedia, 10MediaWiki-File-management: Provide EPUB sanitizer - https://phabricator.wikimedia.org/T19858#1559993 (10Mrjohncummings) It would be really great if Commons could support EPUB, it is one of the main book formats on Project Guttenberg which has 100,000 public domain books available with it's partn... [12:58:05] (03PS1) 10Haritha28: Changed the message for "mwe-upwiz-license-show-recommended" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/232925 [13:57:33] 6Multimedia, 10OOjs-UI, 7Design: UI of SelectFileWidget may not be sufficiently obvious (unclear how to choose the file?) - https://phabricator.wikimedia.org/T109598#1560507 (10matmarex) [13:57:33] 6Multimedia, 10OOjs-UI, 7Design: UI of SelectFileWidget may not be sufficiently obvious (unclear how to choose the file?) - https://phabricator.wikimedia.org/T109598#1553772 (10matmarex) (I rephrased slightly what needs to be done, since I went ahead and merged the related patch https://gerrit.wikimedia.org/... [14:27:59] MatmaRex: Do you have a test script for your mw.api.upload changes? [14:28:09] I can probably use mine but I figured I'd ask [14:29:31] marktraceur: no, i tested it from the browser console on a local wiki [14:46:42] K. [14:47:07] MatmaRex: Is there a trick to get a fake file object, or did you create a file input and fill it [14:47:14] (security can be a pain in the ass) [14:50:52] I guess the file input creation wasn't so bad. [14:50:57] OK, cool, checked and stuff [15:11:17] marktraceur: i actually used a SelectFileWidget from OOUI, i think. appended it to body and chose a file in it. [15:11:21] thanks for the +2 [15:11:36] Yup yup [15:11:47] Working on the next one [15:11:54] Woo, progress. [15:12:36] Or something [15:13:03] And now...we wait [15:13:18] MatmaRex: ForeignApi is next, right? [15:16:14] yeah, i think [15:26:39] (03CR) 10Kai Nissen (WMDE): "I'll send you a campaign configuration file." (034 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/229456 (https://phabricator.wikimedia.org/T105283) (owner: 10Kai Nissen (WMDE)) [15:26:48] (03PS6) 10Kai Nissen (WMDE): [UploadWizard] Introducing the usage of an object reference [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/229456 (https://phabricator.wikimedia.org/T105283) [15:28:18] (03CR) 10MarkTraceur: "You could put it in a paste on Phabricator and link it here, then we have a record of it in public." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/229456 (https://phabricator.wikimedia.org/T105283) (owner: 10Kai Nissen (WMDE)) [15:28:38] Too much to hope for? [17:21:10] Moar progress!!!!! [17:21:14] I love merging core patches. [17:21:34] MatmaRex: So the way I read it is, you now need to add a CentralAuth subclass for ForeignApi... [17:21:43] Oh, reading text [17:21:45] On it. [17:22:56] marktraceur: i'm just responding to Jon's comments on https://gerrit.wikimedia.org/r/#/c/231711/ now [17:23:13] currently trying to figure out how to add the tests, since CentralAuth doesn't have them set up [18:04:45] marktraceur: hmm, you removed your +2 on https://gerrit.wikimedia.org/r/#/c/231710/ ? [18:22:37] (03CR) 10Brion VIBBER: [C: 032] "LGTM; ogv.js seems pretty settled out for now." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/229191 (owner: 10TheDJ) [18:23:09] (03Merged) 10jenkins-bot: Cortado: fully and wholly remove it [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/229191 (owner: 10TheDJ) [18:27:00] (03CR) 10Brion VIBBER: [C: 032] Fix jshint errors [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/231578 (owner: 10Paladox) [18:27:22] (03Merged) 10jenkins-bot: Fix jshint errors [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/231578 (owner: 10Paladox) [18:32:15] (03CR) 10Brion VIBBER: "Can probably also remove the getCaptiosnFromMediaWikiSrt [sic] function from MwEmbedModules/TimedText/resources/mw.TextSource.js" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/231771 (https://phabricator.wikimedia.org/T78511) (owner: 10TheDJ) [18:33:05] Did I? [18:33:40] marktraceur: Well, someone did? [18:33:45] marktraceur: Or gerrit swallowed it? [18:36:28] Might have been [18:36:49] I definitely +2'd it, and didn't remove it [18:37:12] Weeeird. [18:37:28] marktraceur: I can re-+2 it for you? [18:37:37] "And stay down" [18:37:41] * James_F grins. [18:40:39] I just did [18:43:10] (03CR) 10Brion VIBBER: [C: 032] "lgtm :D" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/231857 (owner: 10TheDJ) [18:43:33] marktraceur: are you doing the one in CentralAuth too? would be nice to put this behind us [18:47:24] (03Merged) 10jenkins-bot: Allow for potentially multiple types of subtitles [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/231857 (owner: 10TheDJ) [18:50:06] (03CR) 10Brion VIBBER: [C: 04-1] "(couple more inline notes; it's a good start!)" (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (owner: 10TheDJ) [19:04:30] (03PS2) 10Bartosz Dziewoński: Add (unused) library for uploading to Commons [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/231408 (owner: 10MarkTraceur) [19:05:08] (03CR) 10Bartosz Dziewoński: "Redone on top of ForeignApi." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/231408 (owner: 10MarkTraceur) [19:06:04] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I am still not sure what the use case for this is. As long as it's in the mediawiki/extensions/UploadWizard repository, we won't be able t" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/231408 (owner: 10MarkTraceur) [19:09:59] 6Multimedia, 6Commons, 10MediaWiki-File-management: header for Special:GlobalUsage - https://phabricator.wikimedia.org/T109882#1561524 (10Steinsplitter) 3NEW [19:13:30] 6Multimedia, 6Commons, 10MediaWiki-File-management: header for Special:GlobalUsage - https://phabricator.wikimedia.org/T109882#1561566 (10Steinsplitter) [19:14:19] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-extensions-GlobalUsage: header for Special:GlobalUsage - https://phabricator.wikimedia.org/T109882#1561570 (10Krenair) [19:14:23] 6Multimedia, 6Commons, 10MediaWiki-extensions-GlobalUsage: header for Special:GlobalUsage - https://phabricator.wikimedia.org/T109882#1561524 (10Krenair) [19:18:19] (03CR) 10Brion VIBBER: [C: 04-1] "Couple quick notes:" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [19:21:42] (03CR) 10Brion VIBBER: "Ah, we also probably have to add an 'info' button that takes you to the file page, at a minimum." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [19:26:49] (03CR) 10Brion VIBBER: [C: 032] TimedText: Fix the create/edit selector script [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/231861 (owner: 10TheDJ) [19:28:20] (03CR) 10jenkins-bot: [V: 04-1] TimedText: Fix the create/edit selector script [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/231861 (owner: 10TheDJ) [19:46:27] (03CR) 10Brion VIBBER: "A few more notes:" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [19:51:03] (03PS2) 10Brion VIBBER: TimedText: Fix the create/edit selector script [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/231861 (owner: 10TheDJ) [19:51:27] (03CR) 10Brion VIBBER: [C: 032] TimedText: Fix the create/edit selector script [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/231861 (owner: 10TheDJ) [19:53:56] (03Merged) 10jenkins-bot: TimedText: Fix the create/edit selector script [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/231861 (owner: 10TheDJ) [20:34:18] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler: TimedMediaHandler videos will not work on MediaWiki 1.25 - https://phabricator.wikimedia.org/T109150#1561836 (10ComputeVictory) The following comes from a Firebug debug console: ``` jQuery.fn.embedPlayer :: 1 processEmbedPlayers:: playerSet: Object[video... [20:44:10] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler: TimedMediaHandler videos will not work on MediaWiki 1.25 - https://phabricator.wikimedia.org/T109150#1561872 (10brion) A few questions: * Is this a locally uploaded video or a video from Commons loaded via InstantCommons? * What type is the video? Is it we... [21:15:38] 6Multimedia, 6Commons, 10MediaWiki-extensions-GlobalUsage: Add a header for Special:GlobalUsage - https://phabricator.wikimedia.org/T109882#1561938 (10Aklapper) [21:58:46] brion: on videoJS.. i recently replaced with v5.0-rcsomething but i'm considering switching back. it's still shaky, and all modules for VideoJS will need to be adapted to be compatible (they went ES6 style). [21:59:41] whee [22:00:00] using a transpiler i assume [22:02:33] yup [22:22:40] 'Cos every client has ES6 support. [22:22:44] Especially IE8. :-) [23:16:21] brion: Hmm, any idea why https://commons.wikimedia.org/wiki/File:LaulasiIslandSolomonISlandsPart1video.webm transcode jobs failed? "No video or audio stream found." Is the file lying about its contents? If so, how did it get through the upload step? [23:25:38] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler: TimedMediaHandler videos will not work on MediaWiki 1.25 - https://phabricator.wikimedia.org/T109150#1562791 (10ComputeVictory) The video is a locally uploaded video, and is a WebM video. Transcodes are disabled. I recently tested using an ogg video and di...