[00:15:41] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 7Browser-Support-Internet-Explorer, 5Patch-For-Review: Uploading two or more images in IE11 shows same name in UI for first and last image - https://phabricator.wikimedia.org/T88223#1595522 (10brion) Confirmed still present in MS Edge in current Windows bui... [04:47:29] (03CR) 10Mattflaschen: "Yeah, it's not ready yet, but there is a lot of potential." [extensions/PronunciationRecording] - 10https://gerrit.wikimedia.org/r/233183 (owner: 10Jforrester) [05:03:03] 6Multimedia: Hackathon: Generic viewport metrics tracking for other projects/teams - https://phabricator.wikimedia.org/T76039#1595803 (10Mattflaschen) [05:03:08] 6Multimedia, 10FINCH: Capture browser size and screen size for web users - https://phabricator.wikimedia.org/T75693#1595807 (10Mattflaschen) [08:08:37] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Some styles for MV are missing, link to description page invisible, button to open image in MV broken - https://phabricator.wikimedia.org/T111156#1596067 (10Schnark) 3NEW [08:09:01] (03CR) 10Zhuyifei1999: "> Why? We already know that this file can't be uploaded." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/222085 (https://phabricator.wikimedia.org/T103224) (owner: 10Zhuyifei1999) [08:19:31] (03CR) 10Zhuyifei1999: "Nevermind" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/222085 (https://phabricator.wikimedia.org/T103224) (owner: 10Zhuyifei1999) [08:40:11] join [08:40:15] join wikidata [08:43:24] 6Multimedia, 6Commons, 10MediaWiki-extensions-TimedMediaHandler: Visualize audio files on file description pages - https://phabricator.wikimedia.org/T103527#1596142 (10El_Grafo) [09:00:56] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Some styles for MV are missing, link to description page invisible, button to open image in MV broken - https://phabricator.wikimedia.org/T111156#1596178 (10matmarex) a:3matmarex Regression from de862298032c6567785842e031239424fadaf1ad. Patch coming; @ori... [09:01:03] (03PS1) 10Bartosz Dziewoński: Add missing dependency on 'mediawiki.ui.button' [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/235421 (https://phabricator.wikimedia.org/T111156) [09:01:16] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Convert MultimediaViewer to use OOjs UI instead of MW UI buttons and icons - https://phabricator.wikimedia.org/T111159#1596186 (10matmarex) 3NEW [09:02:11] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 5Patch-For-Review: Some styles for MV are missing, link to description page invisible, button to open image in MV broken - https://phabricator.wikimedia.org/T111156#1596198 (10matmarex) I didn't even realize that MMV uses MediaWiki UI buttons, I filed T11... [09:03:04] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: MediaViewer should use mediawiki-ui styling - https://phabricator.wikimedia.org/T72990#1596202 (10matmarex) 5Open>3Resolved [09:03:36] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 5Patch-For-Review: Some styles for MV are missing, link to description page invisible, button to open image in MV broken - https://phabricator.wikimedia.org/T111156#1596209 (10Thgoiter) > The button in MV to open the description page on Commons is invisib... [09:04:32] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 5Patch-For-Review: Some styles for MV are missing, link to description page invisible, button to open image in MV broken - https://phabricator.wikimedia.org/T111156#1596212 (10matmarex) p:5Triage>3High [10:59:36] marktraceur MatmaRex: I have to this.upload.setText( this.upload.getText() ), before uploading, right? Looks a bit construed, so I ask. [11:01:15] hmm, why? [11:01:15] I am getting an error when I try to upload with https://gerrit.wikimedia.org/r/#/c/235431/ [11:01:43] MatmaRex: The text property of the object remains empty until you setText [11:02:00] MatmaRex: And mw.Upload doesn't ever call setText [11:03:32] hmm. we're talking about ForeignStructuredUpload, right? [11:04:11] MatmaRex: Yes [11:04:28] prtksxna: yes, you do. that's a bug in mw.Upload, actually (it accesses this.text directly instead of this.getText()). i'll fix it there in a few minutes [11:04:54] `this.upload.setText( this.upload.getText() )` is a sane workaround for this issue for now [11:05:09] Right [11:05:16] I'll change it, no worries [11:05:39] MatmaRex: What about the patch I pasted? [11:08:16] prtksxna: i don't understand, what about it? [11:08:29] MatmaRex: All uploads using that dialog are failing [11:08:44] I get the errors in upload.getState() [11:08:59] I get the error state, not errors :\ [11:09:31] hmm. i'll look into it [11:11:09] MatmaRex: I think I know why [11:12:57] I was defining mw.Upload.Dialog.getText() instead of mw.ForeignStructuredUpload.Dialog.getText() [11:13:09] But I don't think that fixed it yet [11:14:42] 6Multimedia, 6Commons, 6Community-Tech, 10Tool-Labs-tools-Other: [AOI] Ceate a new DerivativeFX after the Toolserver shutdown - https://phabricator.wikimedia.org/T110409#1596423 (10Steinsplitter) >>! In T110409#1586685, @Snaevar wrote: > I have seen DerivativeFX at http://tools.wmflabs.org/derivative/deri1... [11:15:25] Hm mw.Upload.Dialog isn't working either. Special:Upload is though [11:16:30] prtksxna: https://gerrit.wikimedia.org/r/235434 check if it works for you, and merge if it does? [11:16:42] MatmaRex: mw.Upload.js does call getText from finishStashUpload [11:17:55] but not from upload() [11:18:10] MatmaRex: Yeah, but the text hasn't usually been set there anyway [11:18:21] hmm [11:18:32] MatmaRex: Testing your patch [11:20:56] 6Multimedia, 6Commons, 6Community-Tech, 10Tool-Labs-tools-Other: [AOI] Create a new DerivativeFX after the Toolserver shutdown - https://phabricator.wikimedia.org/T110409#1596439 (10Aklapper) [11:21:09] MatmaRex: Still getting an error, but I don't think it has anything to do with the JS [11:21:28] MatmaRex: Does https://gerrit.wikimedia.org/r/#/c/235431/ work for you? [11:22:36] i'm testing it [11:23:07] Thanks [11:34:33] prtksxna: it works for me, i managed to upload a file to my wiki with your mw.ForeignStructuredUpload.Dialog. [11:34:47] MatmaRex: I was getting badfilename errors [11:34:52] MatmaRex: Got it working here too [11:35:10] MatmaRex: Should we make these details accessible from the upload object? [11:35:37] which details? [11:36:12] MatmaRex: Object {badfilename: "Sdf.png"} [11:36:28] MatmaRex: It only returns a state right now, with no way to get this information [11:36:36] MatmaRex: Or maybe there is, and I just don't know of one [11:36:48] hmm. yeah, it should probably be accessible [11:37:11] MatmaRex: https://phabricator.wikimedia.org/P1965 [11:37:36] MatmaRex: Are the possible error states documented somewhere? [11:37:54] and yeah, it looks like it gets swallowed and isn't accessible :/ [11:38:07] Could make a new enum type [11:39:32] prtksxna: doesn't seem to be documented anywhere, eh [11:41:20] MatmaRex: And it comes from includes/specials/SpecialUpload.php, right? [11:42:00] Uh sorry, includes/upload/UploadBase.php [11:43:19] prtksxna: seems so. but it looks like upload errors can come from a bunch of places [11:43:26] /o\ [11:43:34] includes/api/ApiUpload.php has some custom ones [11:43:56] and you can probably run into generic errors from extensions like TItleBlacklist [11:44:50] UploadWizard probably has code to handle the important ones… [11:45:21] MatmaRex: includes/api/ApiUpload.php doesn't seem to be adding any new ones [11:46:09] maybe i'm misreading. checkVerification() seems to return all kinds of errors [11:46:40] hmm, although i guess these are defined in UploadBase too [11:47:12] https://github.com/wikimedia/mediawiki-extensions-UploadWizard/blob/master/resources/mw.UploadWizardUpload.js#L226 [11:47:43] Should we cover just these? [11:49:11] I have MOAR questions [11:50:18] Can we use https://doc.wikimedia.org/oojs-ui/master/js/#!/api/OO.ui.CapsuleMultiSelectWidget for the categories? [11:51:25] prtksxna: that UW code you linked doesn't look like all error handling code. UW is a mess [11:52:13] prtksxna: we should be able to use that, and category selector was one of the use cases. i'm not sure if it's being actually used anywhere now, so you might run into snags [11:52:27] https://github.com/wikimedia/mediawiki-extensions-UploadWizard/blob/master/resources/mw.UploadWizardDetails.js#L1650 then [11:54:07] MatmaRex: Alright [11:55:39] We'll have to add/removeItems on the fly or is there a way to hook it up with a method that'll promise to give an array? [11:57:10] Now that I know that my filenames were bad, I'll test and merge https://gerrit.wikimedia.org/r/#/c/235434 [11:57:42] dunno [12:08:29] Thanks MatmaRex [12:08:33] :D [12:27:11] (03PS5) 10Bartosz Dziewoński: Added support to ignore file extension [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/222085 (https://phabricator.wikimedia.org/T103224) (owner: 10Zhuyifei1999) [12:28:36] (03CR) 10Bartosz Dziewoński: [C: 031] "I updated the patch to remove that part." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/222085 (https://phabricator.wikimedia.org/T103224) (owner: 10Zhuyifei1999) [12:28:42] (03PS6) 10Bartosz Dziewoński: Added support to ignore file extension [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/222085 (https://phabricator.wikimedia.org/T103224) (owner: 10Zhuyifei1999) [12:40:34] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Special:UploadWizard needs to notify globally blocked users at the beginning of the process, and provide a standard block message - https://phabricator.wikimedia.org/T111174#1596668 (10Billinghurst) 3NEW [12:42:26] (03CR) 10Steinsplitter: [C: 031] Added support to ignore file extension [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/222085 (https://phabricator.wikimedia.org/T103224) (owner: 10Zhuyifei1999) [12:56:28] (03CR) 10Zhuyifei1999: [C: 031] "Should work. I don't think files without extension will be a serious issue." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/222085 (https://phabricator.wikimedia.org/T103224) (owner: 10Zhuyifei1999) [13:03:15] (03CR) 10Bartosz Dziewoński: "Yeah, I skipped checking them because UW makes the assumption that a file always has an extension elsewhere, and this would be difficult t" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/222085 (https://phabricator.wikimedia.org/T103224) (owner: 10Zhuyifei1999) [13:55:19] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Notify user of blocked IP before the upload process starts, not when it completes - https://phabricator.wikimedia.org/T105863#1596799 (10matmarex) I am unable to reproduce this issue locally. Blocked users (and users using blocked IP addresses) corr... [14:09:43] MatmaRex, prtksxna, good morning, were things cleared up? [14:10:06] hello marktraceur [14:10:43] marktraceur: you have those patches to review, as promised ;) [14:11:12] Eeexcellent. [14:11:46] I just got re-pinged about a bug I thought was a hoax...UW renaming the first image to the name of the last image. I don't know how on earth that could happen, but it's an IE bug. [14:11:55] So you gotta expect some psychedelic shit [14:16:13] James_F|Away: IE11 UploadWizard displays the wrong filename for the first upload in the list, I told Kasia pretty much that issues affecting IE users that didn't actually cause data loss or corruption weren't a huge priority right now, but I can correct myself if you disagree [14:26:39] 6Multimedia, 6Commons, 10MediaWiki-Uploading: Failed 97MB PDF chunked upload to Commons: "No specifications provided to ArchivedFile constructor." - https://phabricator.wikimedia.org/T107704#1596889 (10Anomie) [14:26:43] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: UploadWizard fails uploading pdf with error message - https://phabricator.wikimedia.org/T94562#1596890 (10Anomie) [14:27:45] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Chunked/stashed uploads fail for some pdf and djvu files: "No specifications provided to ArchivedFile constructor." - https://phabricator.wikimedia.org/T94562#1596895 (10Anomie) [14:32:23] i access the wiki, in website dota2.gamepedia.com...I have this model of skyn for me.where i get this model? [14:33:08] This model not available in wiki [14:35:22] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Notify user of blocked IP before the upload process starts, not when it completes - https://phabricator.wikimedia.org/T105863#1596938 (10matmarex) I'm just going to assume this was a global block, since a proxy is likely to have been blocked globall... [14:35:41] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Notify user of blocked IP before the upload process starts, not when it completes - https://phabricator.wikimedia.org/T105863#1596939 (10matmarex) [14:35:45] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Special:UploadWizard needs to notify globally blocked users at the beginning of the process, and provide a standard block message - https://phabricator.wikimedia.org/T111174#1596940 (10matmarex) [14:48:01] (03PS9) 10Paladox: Support low quility videos in webm and mp4 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/234912 [14:48:06] (03PS3) 10Paladox: Support 4k in ogv videos [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/234913 [15:07:04] rodrigorootrj: You want the code for the skin? [15:07:21] yes [15:07:31] css, jquery...all changes [15:08:02] this skyn is copy the skyn vector [15:08:07] Skin. [15:08:28] but i need css code thread [15:08:38] to customize my local wiki [15:10:35] I'm working on it [15:11:01] Firefox appears to be taking an extended lunch break... [15:11:46] Yeah, Firefox got destroyed by something, let me bring up Chrome quick [15:12:32] yes, skin! [15:13:54] Where did my gamepedia person go...hm [15:16:00] I think there might not be code for it [15:26:18] rodrigorootrj: I'd suggest contacting the Gamepedia devs, if you can find a good place for that, or just finding a different skin [15:28:48] (03CR) 10MarkTraceur: [C: 032] Add missing dependency on 'mediawiki.ui.button' [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/235421 (https://phabricator.wikimedia.org/T111156) (owner: 10Bartosz Dziewoński) [15:29:07] MatmaRex: Here I was hoping that Reading would actually take MMV from us... [15:29:26] marktraceur: https://gerrit.wikimedia.org/r/#/c/235431/ [15:31:27] (03CR) 10MarkTraceur: [C: 032] "Oh! OK. Thanks, MatmaRex." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/235377 (https://phabricator.wikimedia.org/T88223) (owner: 10Bartosz Dziewoński) [15:32:16] marktraceur: i'll submit a patch for the globalblocking issue i touched above. i'm trying out some vaguely related things now [15:32:23] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 7Browser-Support-Internet-Explorer, 5Patch-For-Review: Uploading two or more images in IE11 shows same name in UI for first and last image - https://phabricator.wikimedia.org/T88223#1597306 (10MarkTraceur) 5Open>3Resolved Merged, should be fixed in prod... [15:32:25] (03Merged) 10jenkins-bot: Add missing dependency on 'mediawiki.ui.button' [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/235421 (https://phabricator.wikimedia.org/T111156) (owner: 10Bartosz Dziewoński) [15:33:03] marktraceur: also, i need ori to appear and deploy the MMV patch, since it's a regression caused by his stuff [15:33:14] Why not just SWAT it? [15:33:19] (03Merged) 10jenkins-bot: Work around having wrong .value on IE 11 [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/235377 (https://phabricator.wikimedia.org/T88223) (owner: 10Bartosz Dziewoński) [15:33:36] James_F: Could do, but I can't do today's evening SWAT [15:33:39] The patch is innocuous. [15:33:42] marktraceur: No, I mean now. [15:33:49] I guess there's still time? [15:34:11] (03PS1) 10Jforrester: Add missing dependency on 'mediawiki.ui.button' [extensions/MultimediaViewer] (wmf/1.26wmf20) - 10https://gerrit.wikimedia.org/r/235483 (https://phabricator.wikimedia.org/T111156) [15:34:19] (03PS1) 10Jforrester: Add missing dependency on 'mediawiki.ui.button' [extensions/MultimediaViewer] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/235484 (https://phabricator.wikimedia.org/T111156) [15:35:03] (03PS1) 10MarkTraceur: Work around having wrong .value on IE 11 [extensions/UploadWizard] (wmf/1.26wmf20) - 10https://gerrit.wikimedia.org/r/235485 (https://phabricator.wikimedia.org/T88223) [15:35:22] Oh, James_F [15:35:31] Oh, different patch [15:36:01] (03PS1) 10MarkTraceur: Work around having wrong .value on IE 11 [extensions/UploadWizard] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/235486 (https://phabricator.wikimedia.org/T88223) [15:36:11] Oh, I don't care about IE11 users. [15:36:15] Heh [15:36:19] (Well, I do, but not as much as all users.) [15:36:20] WMDE appears to [15:36:34] James_F: I definitely assumed that, correctly, in my triaging of the bug, then [15:36:37] They should use SuSE. [15:37:17] It would be less bad. [15:39:39] meh, IE11 is a passable browser. [15:39:47] i run into more bugs in Chromium. [15:41:21] (03CR) 10MarkTraceur: [C: 032] Correctly report an error for file names without extension [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/235363 (https://phabricator.wikimedia.org/T89792) (owner: 10Bartosz Dziewoński) [15:41:25] marktraceur: It would be more German. [15:41:46] James_F: Indeed [15:42:07] Maybe I should just merge all of MatmaRex's patches [15:42:17] (03Merged) 10jenkins-bot: Correctly report an error for file names without extension [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/235363 (https://phabricator.wikimedia.org/T89792) (owner: 10Bartosz Dziewoński) [15:42:27] (03PS7) 10Bartosz Dziewoński: Added support to ignore file extension [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/222085 (https://phabricator.wikimedia.org/T103224) (owner: 10Zhuyifei1999) [15:42:32] marktraceur: https://gerrit.wikimedia.org/r/#/c/222085/ is also mergeable, i think. [15:42:49] (03CR) 10MarkTraceur: [C: 032] Improve OpenStreetMap link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/235058 (https://phabricator.wikimedia.org/T1099) (owner: 10Bartosz Dziewoński) [15:42:56] (03CR) 10Alex Monk: [C: 032] Work around having wrong .value on IE 11 [extensions/UploadWizard] (wmf/1.26wmf20) - 10https://gerrit.wikimedia.org/r/235485 (https://phabricator.wikimedia.org/T88223) (owner: 10MarkTraceur) [15:43:13] (03CR) 10Alex Monk: [C: 032] Work around having wrong .value on IE 11 [extensions/UploadWizard] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/235486 (https://phabricator.wikimedia.org/T88223) (owner: 10MarkTraceur) [15:43:23] MatmaRex: AWESOME [15:43:40] I hate getting that error message on my local wiki [15:43:44] (03Merged) 10jenkins-bot: Improve OpenStreetMap link [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/235058 (https://phabricator.wikimedia.org/T1099) (owner: 10Bartosz Dziewoński) [15:43:56] (03Merged) 10jenkins-bot: Work around having wrong .value on IE 11 [extensions/UploadWizard] (wmf/1.26wmf20) - 10https://gerrit.wikimedia.org/r/235485 (https://phabricator.wikimedia.org/T88223) (owner: 10MarkTraceur) [15:43:58] (03CR) 10Alex Monk: [C: 032] Add missing dependency on 'mediawiki.ui.button' [extensions/MultimediaViewer] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/235484 (https://phabricator.wikimedia.org/T111156) (owner: 10Jforrester) [15:44:03] (03CR) 10MarkTraceur: [C: 032] Added support to ignore file extension [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/222085 (https://phabricator.wikimedia.org/T103224) (owner: 10Zhuyifei1999) [15:44:05] (03CR) 10Alex Monk: [C: 032] Add missing dependency on 'mediawiki.ui.button' [extensions/MultimediaViewer] (wmf/1.26wmf20) - 10https://gerrit.wikimedia.org/r/235483 (https://phabricator.wikimedia.org/T111156) (owner: 10Jforrester) [15:46:20] (03Merged) 10jenkins-bot: Work around having wrong .value on IE 11 [extensions/UploadWizard] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/235486 (https://phabricator.wikimedia.org/T88223) (owner: 10MarkTraceur) [15:46:22] (03Merged) 10jenkins-bot: Add missing dependency on 'mediawiki.ui.button' [extensions/MultimediaViewer] (wmf/1.26wmf21) - 10https://gerrit.wikimedia.org/r/235484 (https://phabricator.wikimedia.org/T111156) (owner: 10Jforrester) [15:46:25] (03Merged) 10jenkins-bot: Added support to ignore file extension [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/222085 (https://phabricator.wikimedia.org/T103224) (owner: 10Zhuyifei1999) [15:46:28] (03Merged) 10jenkins-bot: Add missing dependency on 'mediawiki.ui.button' [extensions/MultimediaViewer] (wmf/1.26wmf20) - 10https://gerrit.wikimedia.org/r/235483 (https://phabricator.wikimedia.org/T111156) (owner: 10Jforrester) [15:47:28] That's what we like to see [15:47:41] MatmaRex: These seem great but not terribly themed [15:47:46] Am I missing something? [15:49:00] I mean, I'm happy with the stuff that I just merged, just wondering if there's something else I need to look at [15:49:03] marktraceur: no. i just opened the list of all UploadWizard bugs and clicked on a few that i could understand. [15:49:09] Oh, K :) [15:49:14] Well, great stuff [15:49:34] * marktraceur looks at prtksxna's patch [15:49:39] marktraceur: i'm now looking into a few problems where you only learn that you can't upload a file after you went through the whole wizard, so that'll be the next batch [15:49:47] OK, fun [15:49:52] Those are tricky [15:57:14] MatmaRex: I'm going to test that UW is still "working" but it'd be cool if you could test IE11 [15:58:37] marktraceur: okay, doing [16:12:07] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 5WMF-deploy-2015-08-25_(1.26wmf20), 5WMF-deploy-2015-09-01_(1.26wmf21), 5WMF-deploy-2015-09-08_(1.26wmf22): Some styles for MV are missing, link to description page invisible, button to open image in M... - https://phabricator.wikimedia.org/T111156#1597727 [16:28:58] 6Multimedia, 6Commons, 10MediaWiki-extensions-MultimediaViewer, 5WMF-deploy-2015-09-01_(1.26wmf21): "Open in Media Viewer" box appears twice after editing file page - https://phabricator.wikimedia.org/T110493#1597853 (10Yann) This still happens to me on Commons today (Chrome, Win7). [16:30:32] marktraceur: We want to be able to add categories using OO.ui.CapsuleMultiSelectWidget, right? [16:31:08] I believe so, yes. [16:35:14] marktraceur: We'll need to have something like jquery.mwCoolCats.js in core, then? [16:35:39] ignore me [16:35:48] 6Multimedia, 6Commons, 10MediaWiki-extensions-MultimediaViewer, 5WMF-deploy-2015-09-01_(1.26wmf21): "Open in Media Viewer" box appears twice after editing file page - https://phabricator.wikimedia.org/T110493#1597900 (10matmarex) Yes; sorry, the patch was not deployed separately. It will go out to Commons... [16:37:53] prtksxna: Done. :) [16:38:03] Don't use coolcats, I'd love to kill that [16:38:05] It's awful [16:39:31] marktraceur: I didn't realize that coolcats did the UI part too, I thought it was just used for prefix search [16:39:53] marktraceur: And that is as simple as using the API, right? https://en.wikipedia.org/w/api.php?action=opensearch&namespace=14&limit=10&search=lol [16:40:25] marktraceur: OO.ui.CapsuleMultiSelectWidget doesn't support remote autocomplete out of the box, or at least it not clear if it does [16:40:39] marktraceur: I'll see if we can use that [16:40:58] and make a mw.widget.CategorySelector or something… [16:42:17] got disconnected :| [16:43:43] marktraceur: I'm excited to see more <-- categories, right [16:43:49] Is there a phab task for this? [16:44:48] prtksxna: Probably not, I think MatmaRex said that there was something we could use baaaasically out of the box though [16:45:20] [17:22:13] MatmaRex: prtksxna: we should be able to use that, and category selector was one of the use cases. i'm not sure if it's being actually used anywhere now, so you might run into snags [16:45:20] what, capsules? i'm pretty sure no one really tried using it yet [16:45:29] so if prtksxna says it doesn't work, then it doesn't work [16:45:33] * prtksxna killed a spider [16:45:47] Limbo is giving me nightmares :| [16:46:03] Fair enough [16:46:30] MatmaRex: Give me until tomorrow to say that :P I am sure we can use it, just that I couldn't find a method to automagically attach it to an API endpoint for autocomplete. [16:47:22] everything can be solved with enough subclassing! [16:47:24] :> [16:51:23] mw.widgets.CoolCats it is then :P [16:52:01] * marktraceur weeps [16:52:11] prtksxna: mw.widgets.StrayCatStrut [16:53:21] :D :P [16:54:56] Does anyone remember Alley Cat? [16:55:13] Sounds familiar [16:55:24] https://www.youtube.com/watch?v=uZDG4dlU5uY [16:55:40] Wow! That soundtrack. [16:57:47] I'll go to bed now [16:57:51] Category selector tomorrow… [17:03:57] prtksxna: Oh, wow, no, I don't remember this, it looks cool [17:34:40] James_F: Is there a document listing the goals for the entire Editing department somewhere? [17:34:55] I guess roadmap might help me... [17:35:03] Nope [17:37:16] marktraceur: "Goals"? [17:37:31] marktraceur: Which of the ten or so definitions of the word do you mean? [17:38:12] What do we want to accomplish? [17:38:35] I'm looking for something like "We want more editors" balanced with "We want higher-quality content" in some way that makes sense [17:39:26] I guess I'm having trouble articulating what I want to find because I'm not sure I've ever seen it in a way that actually helped me [17:42:14] Oh, right. [17:42:22] Yeah, that's what we're working on now. [17:42:29] Bottom-up? [17:42:33] Indeed. [17:42:38] Rather than top-down which is icky. [17:42:38] Seems backwards to me [17:43:05] Like...I want there to be an overall goal so I can know what I'm supposed to work towards, I think [17:43:30] Oh. [17:43:31] Well. [17:43:47] There's "We build collaborative, inclusive tools for creating and editing free knowledge." [17:43:59] But that's probably too high-level for your needs? [17:44:37] marktraceur: Talking to Trevor now. [17:44:39] It's fine, but I think it's still backwards [17:44:54] Like, that's what we do, not what we want to accomplish? I dunno, maybe I'm being too demanding :P [17:44:58] Apparently there's a WMF-level piece of work to do this. [17:45:10] I would imagine so [17:45:13] But nothing at Editing level yet. [17:46:53] Hm. [17:46:58] That makes it difficult [17:47:19] James_F: I was going down this particular rabbit hole because I wanted to start thinking about what metrics to track, what success looked like, etc. [17:47:22] Something like https://meta.wikimedia.org/wiki/Wikimedia_Foundation_Guiding_Principles ? [17:47:32] And I realized I was being rather small-minded about it, just looking for success locally [17:47:48] But if we aren't supporting a grander vision or goal, it's kind of meaningless for us to succeed [17:48:08] https://www.mediawiki.org/wiki/Editing/Guiding_principles [17:48:10] Starting now. [17:48:16] <3 [17:59:15] OK, going to gorge on some Indian food because I have an unprecedented hunger for curry chicken [18:02:35] (03PS1) 10Bartosz Dziewoński: Check for global blocks in addition to regular ones before showing the wizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/235517 (https://phabricator.wikimedia.org/T111174) [18:02:36] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard has really poor error handling if the user is blocked while working through the form - https://phabricator.wikimedia.org/T111227#1598467 (10matmarex) 3NEW [18:04:23] 6Multimedia, 10MediaWiki-Uploading, 10MediaWiki-User-blocking: Blocked users can upload files to stash - https://phabricator.wikimedia.org/T111228#1598481 (10matmarex) 3NEW [18:06:40] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Special:UploadWizard needs to notify globally blocked users at the beginning of the process, and provide a standard block message - https://phabricator.wikimedia.org/T111174#1598492 (10matmarex) I discovered a couple of things while working... [18:07:13] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Special:UploadWizard needs to notify globally blocked users at the beginning of the process, and provide a standard block message - https://phabricator.wikimedia.org/T111174#1598500 (10matmarex) [18:08:43] 6Multimedia, 10MediaWiki-Special-pages, 10MediaWiki-Uploading, 10MediaWiki-extensions-GlobalBlocking: Special:Upload does not check for global blocks until the form is submitted - https://phabricator.wikimedia.org/T111229#1598506 (10matmarex) 3NEW [18:10:57] (03CR) 10Bartosz Dziewoński: "I didn't test this code, since I don't have GlobalBlocking set up. I manually tested that the error page is shown correctly, and the rest " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/235517 (https://phabricator.wikimedia.org/T111174) (owner: 10Bartosz Dziewoński) [18:12:21] marktraceur: there, i fixed a bug and filed four new ones. :P [18:16:21] MatmaRex: Tsk. ;-) [18:35:15] marktraceur: Thoughts on https://www.mediawiki.org/wiki/Editing/Guiding_principles as a start? [19:06:27] MatmaRex: You're killin' me here [19:07:09] James_F: Good start from what I've read so far [19:07:24] I'm going to have some fun adapting these to Multimedia I think [19:07:44] marktraceur: I think the MM ones in particular would be; [19:08:03] Quality of coverage — We want the topics covered on our content sites to be of high quality – referenced, correct, informative, illustrated, organised, up-to-date, explained, consistent, meaningful, coherent, re-usable, … [19:08:18] And: [19:08:18] Accessibility — We want the topics covered on our content sites to be as accessible to as many people as possible – technologically, cognitively, culturally, lingually, … [19:08:27] Well, I think on some level we can make all of these fit into the Multimedia sphere [19:08:39] Oh, of course, all MM work will touch on these points. [19:08:46] New users coming in, users feeling validated, etc. [19:08:50] It's more like a lens through which I can say "okay, we want these things as part of Editing, so how do we measure them for Multimedia" [19:09:00] * James_F nods. [19:13:39] James_F: +1 on including Happiness [19:13:56] "not making people hate each other, themselves, and their work" is a good thing :D [19:15:02] brion: Yeah. Originally I had that as "fulfillment", but I worried that it would sound like an Amazon warehouse thing. :-) [19:15:28] "congratulations! your edit has shipped. it will arrive in two business days" [19:15:58] * James_F grins. [19:16:08] one-click editing ftw [19:16:18] and you thought visual editor was easy? [19:16:28] Would you like free two-day draft approval with a free trial of Wikibooks Prime? [19:16:35] lol [19:17:15] No no. [19:17:27] We need to sell a speaker that listens to you and transcribes your thoughts into edits. [19:17:29] Duh. [19:18:01] James_F: we don't have the computing power for that; we'll have to crowdsource it [19:18:04] i call it a "telephone" [19:18:09] brion: :-) [19:21:33] brion: I think I've heard of those things [19:47:54] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Problems with UploadWizard stash moving to the target - https://phabricator.wikimedia.org/T37354#1599009 (10brion) a:5brion>3None [20:04:46] 6Multimedia, 10MediaWiki-extensions-Score, 5Patch-For-Review: Score should output SVG - https://phabricator.wikimedia.org/T49578#1599105 (10brion) a:5brion>3None Removing assignment from some tasks I'm not actively working on. Volunteers welcome, I'm happy to help if pinged! [20:28:44] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard enforces exact date, doesn't accept other forms - https://phabricator.wikimedia.org/T111248#1599200 (10SJu) 3NEW [20:33:54] https://phabricator.wikimedia.org/T111248 [20:33:57] * MatmaRex dies a little inside [20:34:11] gods, our design is so awful if people can't tell that buttons are button [20:36:49] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard enforces exact date, doesn't accept other forms - https://phabricator.wikimedia.org/T111248#1599229 (10matmarex) There should be a switcher next to the date field, allowing you to input any text in it. Furthermore, if you start typing '{{' into the... [21:06:54] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): Change link syntax of openstreetmap link - https://phabricator.wikimedia.org/T1099#1599321 (10matmarex) 5Open>3Resolved [21:08:00] 6Multimedia, 6Commons, 10MediaWiki-extensions-MultimediaViewer, 5WMF-deploy-2015-09-01_(1.26wmf21): "Open in Media Viewer" box appears twice after editing file page - https://phabricator.wikimedia.org/T110493#1599322 (10matmarex) @Yann, it should be resolved on Commons now. Can you confirm? Thanks. [21:12:49] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Clean up possible refactor-related regressions - https://phabricator.wikimedia.org/T96907#1599347 (10matmarex) [21:12:52] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): UploadWizard does not handle invalid names - https://phabricator.wikimedia.org/T89792#1599346 (10matmarex) 5Open>3Resolved [21:22:46] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard enforces exact date, doesn't accept other forms - https://phabricator.wikimedia.org/T111248#1599406 (10SJu) I'm a bit confused. Now the form works as you say. However, before ca. half an hour, I didn's see the switch and when I tried to copy the... [21:25:22] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Chunked/stashed uploads fail for some pdf and djvu files: "No specifications provided to ArchivedFile constructor." - https://phabricator.wikimedia.org/T94562#1599417 (10matmarex) We previously solved* problems like this by gzipping the dat... [21:30:04] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard enforces exact date, doesn't accept other forms - https://phabricator.wikimedia.org/T111248#1599455 (10Tgr) Or you have the UW page open in a tab all the time and don't refresh it for days? Some people seem to do that. I wonder if some kind of auto... [21:40:17] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard enforces exact date, doesn't accept other forms - https://phabricator.wikimedia.org/T111248#1599543 (10matmarex) This was changed very recently, see T110026, because although the switcher was always there, it was hard to notice. {F2320849} In fac... [21:41:33] *faith in humanity restored* [21:48:24] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 7I18n: MediaWiki:mwe-upwiz-source-ownwork-assert-any-license needs working GENDER suport - https://phabricator.wikimedia.org/T30525#1599598 (10Aklapper) @Amire80: This issue has been assigned to you a while ago. Could you please provide a status update and i... [21:51:56] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard enforces exact date, doesn't accept other forms - https://phabricator.wikimedia.org/T111248#1599607 (10SJu) I have surely not the UW page open for a time, I use it very rarely (I prefer Special:Upload for my own photos). Let's suppose that I had... [22:01:45] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard enforces exact date, doesn't accept other forms - https://phabricator.wikimedia.org/T111248#1599681 (10SJu) I think, the task can be closed as mistaken or solved. For possible investigation: the file i had problem with was https://commons.wikimed... [22:15:48] 6Multimedia, 10MediaWiki-extensions-UploadWizard: When image uploads fail, the entire process shouldn't have to be started anew, just fixed - https://phabricator.wikimedia.org/T105545#1599780 (10matmarex) a:3matmarex [22:15:52] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UW doesn't allow to fix a name clashing issue - https://phabricator.wikimedia.org/T100975#1599781 (10matmarex) a:3matmarex [22:34:58] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard enforces exact date, doesn't accept other forms - https://phabricator.wikimedia.org/T111248#1599854 (10matmarex) 5Open>3Resolved Thanks. [23:18:44] Does anyone remember the limits for thumbnail generation? https://commons.wikimedia.org/wiki/File:Mailhoc-Panorama.jpg apparently isn't getting thumbnails and a user is asking me. [23:19:36] * guillom wonders if marktraceur knows. [23:21:17] that is a very large image... [23:21:40] Hence my question. [23:26:12] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10UI-Standardization: Fix style of tipsy tooltips in MediaViewer - https://phabricator.wikimedia.org/T77402#1600230 (10Volker_E) @violetto @MingleTerminator Well, we're leaving most of the interface somehow customizable, right? Therefore my question on wh... [23:39:29] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10UI-Standardization: Fix style of tipsy tooltips in MediaViewer - https://phabricator.wikimedia.org/T77402#1600274 (10Tgr) I'm not sure what the context is (are you working on UI standardization?) but adding styles to tipsy might not be worth the effort.... [23:47:56] guillom: that failure looks like time, not size. I'm not finding the config about how much time it can take to make a thumb but there is a limit. Not sure if that takes time to load the original from swift into account or not.