[00:19:26] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard, 7Easy: Use {{PD-USGov-USGS}} if from USGS Bee Inventory and Monitoring Lab on Flickr - https://phabricator.wikimedia.org/T106269#1618833 (10Josve05a) [07:14:39] 6Multimedia, 10MediaWiki-File-management, 6Performance-Team, 7Swift: Purging in Thumbor - https://phabricator.wikimedia.org/T111005#1619539 (10Gilles) [07:43:27] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler: Make a conversion script to convert vp8 videos to vp9 - https://phabricator.wikimedia.org/T111907#1619672 (10Paladox) [07:43:57] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Upload failing (6 MB file) - https://phabricator.wikimedia.org/T111908#1619676 (10Sebaso) 3NEW [07:44:34] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler: Enable vp9 by default, disable on wikimedia. - https://phabricator.wikimedia.org/T111909#1619684 (10Paladox) 3NEW [07:48:27] 6Multimedia: Figure out legal text to be put in the mw.ForeignStructuredUpload.Dialog.js - https://phabricator.wikimedia.org/T111910#1619693 (10Prtksxna) 3NEW a:3Slaporte [07:48:56] 6Multimedia: Figure out legal text to be put in the mw.ForeignStructuredUpload.Dialog.js - https://phabricator.wikimedia.org/T111910#1619701 (10Prtksxna) [07:52:25] 6Multimedia: Figure out legal text to be put in the mw.ForeignStructuredUpload.Dialog.js - https://phabricator.wikimedia.org/T111910#1619705 (10Prtksxna) [07:52:27] 6Multimedia, 7Epic, 5Patch-For-Review: Be able to embed an upload dialog so that other extensions (e.g. WikiEditor, VisualEditor) can provide it to users - https://phabricator.wikimedia.org/T91717#1619704 (10Prtksxna) [07:53:48] marktraceur: Made https://phabricator.wikimedia.org/T111910 to continue the discussion with Stephen [07:54:42] marktraceur: The OO.ui.CapsuleMultiSelectWidget breaks when you add the first token in a new line. I'll try and see if I can fix that [08:11:21] A lot is going one here…filed https://phabricator.wikimedia.org/T111911 [08:23:43] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed. You may want to add reviewers for the functional part." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/226038 (owner: 10Prtksxna) [12:16:26] prtksxna: I don't know if Phabricator is the best venue for legal advice, but as long as slaporte is cool with it [14:51:14] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Upload failing (6 MB file) - https://phabricator.wikimedia.org/T111908#1620791 (10matmarex) Can you provide a copy of the file? You can upload it here to Phabricator by dragging-and-dropping it to the comment field, or at https://phabricator.wikimedia.org/file/... [14:54:55] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Upload failing (6 MB file) - https://phabricator.wikimedia.org/T111908#1620798 (10Sebaso) @matmarex https://phabricator.wikimedia.org/F2561533 [15:13:42] 6Multimedia, 10MediaWiki-extensions-GWToolset, 7Easy, 7I18n, 5Patch-For-Review: GWToolset message "gwtoolset-mapping-no-gwtoolset-title" is missing documentation - https://phabricator.wikimedia.org/T102748#1620841 (10Prtksxna) 5Open>3Resolved a:3Prtksxna [15:18:44] marktraceur: Hm, right. Let's see… [15:22:03] marktraceur: I'm going to have to skip today's stand-up, sorry. Conflicting meeting. :-( [15:28:08] OK! [15:28:27] Will we have MatmaRex or brion? [15:28:45] yo yo yo [15:28:57] Aww, and I'll miss it. :-( [15:29:07] hi [15:29:44] I may have failed to give brion the event. One sec. [15:30:24] brion: Should be on your calendar now [15:35:24] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 10Wikimedia-Video, 5Patch-For-Review: Embedded video player broken - https://phabricator.wikimedia.org/T108359#1620962 (10brion) Ok this is merged since yesterday; should go out with next weeks updates as usual or we can SWAT it if we're in a hurry. [16:12:44] MatmaRex: Is it ok to add methods like setValidityFlag to mw.widgets.DateInputWidget? [16:13:34] probably? [16:15:34] MatmaRex: mm, and should we allow to add validations like between date ranges, before date x, after date y etc. Or should we just do those checks in FSUD? [16:17:11] do we need any such checks? [16:17:45] MatmaRex: Can't upload images in a future date, no matter how much marktraceur wants time travel to happen [16:17:56] DateInputWidget could be extended to make it possible to not allow setting dates before given / after given [16:18:14] …and within a range? [16:18:34] prtksxna: Yes, but make sure it's easy to disable the validation, just in case ;) [16:18:36] yeah. [16:18:51] i'd do this as minDate and maxDate, both optional [16:18:56] * prtksxna nods [16:19:05] MatmaRex: So as part of mw.widgets.DateInputWidget or should I subclass it? [16:19:19] in DateInputWidget, i think [16:19:55] Cool, I'll try and implement this. Thanks MatmaRex [16:44:25] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Upload failing (6 MB file) - https://phabricator.wikimedia.org/T111908#1621269 (10Steinsplitter) [16:45:34] 6Multimedia, 6Commons: Some files had disappeared from Commons after renaming - https://phabricator.wikimedia.org/T111838#1617529 (10Steinsplitter) This is a well known long term problem. Wondering why this isn't fixed yet (after years and multiple reports) [16:46:26] (03Abandoned) 10Bartosz Dziewoński: Add override button back in [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/159625 (https://bugzilla.wikimedia.org/46741) (owner: 10MarkTraceur) [16:46:43] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard unable to override "similar name"/"same name" detection warning - https://phabricator.wikimedia.org/T48741#1621282 (10matmarex) [16:58:36] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard unable to override "similar name"/"same name" detection warning - https://phabricator.wikimedia.org/T48741#1621317 (10matmarex) T106968 has been merged into this bug incorrectly, this is a different issue that had incorrect title. [16:58:56] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard form gets to deadlock when the file title is not accepted - https://phabricator.wikimedia.org/T106968#1621328 (10matmarex) 5duplicate>3Open This is not the same bug as T48741, that one just had a confusing title. [17:05:31] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 7Tracking: Improve UploadWizard UX (tracking) - https://phabricator.wikimedia.org/T96911#1621363 (10matmarex) [17:05:33] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard unable to override "similar name"/"same name" detection warning - https://phabricator.wikimedia.org/T48741#1621361 (10matmarex) 5Open>3stalled I was unable to reproduce this issue locally. I uploaded a file called "add.png" to my wiki: {F25618... [17:08:22] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard cannot replace existing files - https://phabricator.wikimedia.org/T42893#1621367 (10matmarex) [17:08:43] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard unable to override "similar name"/"same name" detection warning - https://phabricator.wikimedia.org/T48741#1621369 (10matmarex) [17:08:45] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UW: re-upload of deleted file impossible (duplicate-archive case); should have override - https://phabricator.wikimedia.org/T42921#1621370 (10matmarex) [17:09:46] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UW: re-upload of deleted file impossible (duplicate-archive case); should have override - https://phabricator.wikimedia.org/T42921#1621374 (10matmarex) 5duplicate>3Open This is not a duplicate of T42893. That one is for existing files. [17:10:48] James_F: For "illustrated" pages...imagelinks sufficient? We'll pick up stuff with maintenance icons, especially considering if there's an icon on the "needs image" template... [17:13:34] 6Multimedia, 6Commons: Some files had disappeared from Commons after renaming - https://phabricator.wikimedia.org/T111838#1621398 (10Wieralee) It is difficult to explain. During renaming I don't see any problems. Everything is O.K. But after some time, when I woulded like to see one of that files, I had notic... [17:17:07] I guess I'm asking how precise we want to be with our adherence to the definition of "illustrated", and what that definition is [17:17:39] marktraceur: Meh. [17:18:05] marktraceur: Does imagelinks get touched when an image is in a transclusion? In a gallery? [17:19:40] I think all of the above, but I could be wrong [17:20:10] should be yes :) [17:23:04] marktraceur: James_F: there are icons in all stub templates. [17:23:16] marktraceur: PageImages has some smarter logic to ignore tiny icons? [17:23:22] (i have no idea what we're discussing) [17:23:27] Can we piggy-back off PageImages? [17:23:45] MatmaRex: Possible KPI for Multimedia of what %age of our content is illustrated. [17:26:13] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UW: re-upload of deleted file impossible (duplicate-archive case); should have override - https://phabricator.wikimedia.org/T42921#1621445 (10matmarex) a:3matmarex [17:28:32] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Unable to reupload identical files to Upload Wizard - https://phabricator.wikimedia.org/T50543#1621468 (10matmarex) [17:28:47] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Unable to reupload revised files to Upload Wizard - https://phabricator.wikimedia.org/T50543#533268 (10matmarex) [17:28:54] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Unable to reupload revised files to Upload Wizard - https://phabricator.wikimedia.org/T50543#533268 (10matmarex) [17:30:45] man, the quality of bug reports in #UploadWizard is awful [17:33:49] (03CR) 10Brion VIBBER: [C: 04-1] "couple inline notes" (033 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://phabricator.wikimedia.org/T74675) (owner: 10TheDJ) [17:39:59] (03CR) 10Brion VIBBER: Improve live loading and ResourceLoader behavior (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/172421 (https://phabricator.wikimedia.org/T74675) (owner: 10TheDJ) [17:50:11] MatmaRex: The input field is hidden onblur and along with it the red border *facepalm* [17:51:38] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard should handle duplicate-archive with an empty title - https://phabricator.wikimedia.org/T61646#1621583 (10matmarex) a:3matmarex [17:54:45] MatmaRex: https://gerrit.wikimedia.org/r/#/c/237154/ [17:57:17] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler: Make a conversion script to convert vp8 videos to vp9 - https://phabricator.wikimedia.org/T111907#1621607 (10brion) 5Open>3Invalid a:3brion That's what transcoding does. [17:58:12] prtksxna: need it now? i'm disemboweling UploadWizard [17:58:30] MatmaRex: Nope, I think I know the next step [17:58:43] MatmaRex: Will tell you once I really need review [17:58:54] right. i'll look later, anyway [18:00:48] (03PS1) 10Bartosz Dziewoński: Better handle revdeleted file duplicates when displaying warning popup [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237157 (https://phabricator.wikimedia.org/T61646) [18:05:28] (03PS1) 10Bartosz Dziewoński: Allow reupload of deleted files ('duplicate-archive' warning) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237158 (https://phabricator.wikimedia.org/T42921) [18:05:53] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: UW: re-upload of deleted file impossible (duplicate-archive case); should have override - https://phabricator.wikimedia.org/T42921#1621636 (10matmarex) Bug 39852 (T41852) does not seem to come back with the above patch, possibly due to my f... [18:06:27] (03CR) 10jenkins-bot: [V: 04-1] Allow reupload of deleted files ('duplicate-archive' warning) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237158 (https://phabricator.wikimedia.org/T42921) (owner: 10Bartosz Dziewoński) [18:07:27] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard, 7Tracking: UploadWizard Flickr (tracking) - https://phabricator.wikimedia.org/T45450#1621644 (10matmarex) [18:08:24] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 7Easy, 5Patch-For-Review, 5WMF-deploy-2015-09-08_(1.26wmf22): Add an option to ignore file extension - https://phabricator.wikimedia.org/T103224#1621654 (10matmarex) 5Open>3Resolved [18:10:08] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Unable to change file extension while uploading file - https://phabricator.wikimedia.org/T36703#1621659 (10matmarex) So what you're saying is that we should just normalize the extension to ".jpg", and generally to lowercase? [18:14:07] MatmaRex: I think pageimages doesn't use a database, though, just parses the page or something [18:14:24] it uses page_props [18:14:50] Ah. [18:15:39] (03CR) 10Bartosz Dziewoński: "Superseded by https://gerrit.wikimedia.org/r/237158" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/159625 (https://bugzilla.wikimedia.org/46741) (owner: 10MarkTraceur) [18:15:47] well it saves into pgae_props doesn't it? it pulls from the page data... [18:16:21] I guess so. [18:16:27] And it must be automatic on save? [18:16:37] Like, hooks into an on-save event and dumps something in page_props [18:16:46] yeah i think so [18:17:03] I'm seeing 2 million results with page_image in page_props on enwiki [18:17:09] Which seems sane-ish [18:17:20] But no historical data, because the page_image apparently doesn't have any timestamp [18:17:23] (03CR) 10Bartosz Dziewoński: "Superseded by https://gerrit.wikimedia.org/r/237158" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/65318 (https://bugzilla.wikimedia.org/40921) (owner: 10TheDJ) [18:17:54] So I can't get data for last year or the year before or anything [18:17:55] page_props always refers to the current revision only [18:17:59] it's only suitable for derived data [18:18:21] Right, but with page_image, that's not the case [18:18:52] how so? [18:18:55] I would much rather have had it in a revision_prop table or something [18:19:04] it's derived from what's in the page [18:19:06] Because now I don't know what page_image was for revision N, I only know the current one [18:19:11] which may depend on templates etc [18:19:18] so can't be preserved on a per-revision basis, really [18:19:31] Bloody templates [18:19:34] hehehe [18:20:08] imo lead image selection should be able to be manually overridden during edit, saved as revision-specific metadata, and recorded [18:20:17] but i don't think anybody's worked on that yet [18:20:41] Oh, shoot, imagelinks has the same problem. v.v [18:20:51] I don't know why I thought anything different [18:21:02] So I'm back to needing bloody mwgrep or something [18:21:11] Worse, sifting through old revisions [18:23:10] What is better? Having a minDate(>=), or an isAfterDate(>)? [18:23:33] s/isAfterDate/shouldBeAfterDate [18:31:44] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Unable to change file extension while uploading file - https://phabricator.wikimedia.org/T36703#1621723 (10Steinsplitter) >>! In T36703#1621659, @matmarex wrote: > So what you're saying is that we should just normalize the extension to ".jpg", and generally to... [18:53:52] (03CR) 10Brion VIBBER: [C: 04-1] [WIP] TimedText should use ContentHandler (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/236486 (https://phabricator.wikimedia.org/T111651) (owner: 10TheDJ) [19:03:19] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Upload failing (6 MB file) - https://phabricator.wikimedia.org/T111908#1621809 (10Herzi.Pinki) p:5Triage>3High Sorry for interfering, but I can reproduce the behavior (different file, different ISP, different country), for small files it works l... [19:18:12] OK, James_F, thanks to halfak, we're getting historical data for illustrations with a few caveats [19:18:22] 1. Possible false positives [19:18:25] Others possibly [19:18:32] Busy dealing with the script first [19:19:06] MatmaRex: Neat. [19:19:09] Bah. [19:19:11] marktraceur: Neat. [19:19:13] :> [19:19:20] Clearly we should organise teams for non-tab clashes. [19:19:32] I'm sure MatmaRex has done something today worthy of 'neat' though. :-) [19:19:55] He tends to! [19:19:59] :-) [19:20:18] https://www.mediawiki.org/wiki/Wikimedia_Engineering/2015-16_Q1_Goals#Multimedia_Team [19:20:23] "UploadWizard is completely converted to OOUI with no loading of jQuery UI code, technical debt " [19:20:33] Likely for us to be done in three weeks' time? [19:20:43] "Users can upload files from within VisualEditor without abandoning their edit " similarly? [19:20:58] "likely" is a strong term for the first one [19:21:05] The second one, I have almost no worries about. [19:21:11] * James_F looks at MatmaRex expectantly. [19:21:14] Especially since it doesn't say something like "on english wikipedia" [19:21:32] Hooray loopholes. [19:21:49] James_F: But in all seriousness, that should be done by, at the latest that I can foresee, two weeks into q2. [19:22:02] Hmmph. [19:22:08] (Yay.) [19:23:10] please plan changes in the UploadWizard not in September due Wiki Loves Monuments [19:23:18] James_F: impossible within three weeks unless i abandon everything else [19:23:51] James_F: uploading from within VE is likelier, we have the dialogs almost done and APIs all done, we "just" need to integrate it into VE [19:24:00] MatmaRex: What's left? Error dialogs, CatSel... [19:24:12] marktraceur: everything except for date selector [19:24:27] Well, and I've already done the buttons and checkboxes [19:24:29] (and some buttons) [19:24:32] yes [19:24:35] MatmaRex: Focus on the "no jquery UI" bit. [19:24:58] I think that's the real goal, here, the rest can follow [19:25:40] it's hard to even tell where it is used. i guess i could kill some dialogs in a timely manner [19:26:06] i'm not sure how much the form validation is connected with jquery.ui, that's a big one [19:26:10] That's the most egregious one anyway [19:26:20] Ugh, yeah, form validation is...blergh. [19:26:36] I don't know if that's jquery.ui particularly, or if it's a separate plugin [19:29:47] We have date validation! [19:29:51] I think… [19:33:15] marktraceur: MatmaRex https://gerrit.wikimedia.org/r/#/c/237186/ and https://gerrit.wikimedia.org/r/#/c/237154/ whenever you have time [19:33:59] MatmaRex: Remove jquery.ui from the dependencies list and keep hacking until it works. [19:34:00] ;-) [19:34:43] James_F: Eep. [19:34:57] Take an axe to the issue. [19:35:23] I think in the relatively near future we could tell edsanders to add the dialog to VE and send prtksxna to help with OOUI-ifying UW... [19:35:25] James_F: give me a QA team big enough to test that :P [19:35:34] * James_F nods. [19:35:51] marktraceur: Yep, I was thinking the same thing [19:36:08] marktraceur: I did also want to work on the hotcat extension, but that can wait [19:37:07] prtksxna: Eww, HotCat. [19:37:17] I mean, make James_F happy and work on our goals, etc. :) [19:37:23] * James_F coughs. [19:37:39] I would say that I could stop screwing around with metrics and do the same thing, but I feel like both are pretty important? [19:38:15] Maybe? [19:40:28] James_F: I'm willing to bow to your opinion on that, but if we're going to try to prototype cool things, we need to know if they're working... [19:40:58] eh [19:41:08] we're doing too many prototype things [19:41:29] marktraceur: Maybe we could punt it and say doing the 'metrics and prototyping' next quarter? [19:41:53] OK, fair enough [19:42:09] I'll finish up the illustration numbers, since it's about one command away from running [19:43:14] Nice. [19:44:16] Last time I checked UploadWizard was giving me weird errors :( [19:44:25] But that must be a local issue [19:44:38] I'll sleep once jenkins +2's my patches [19:45:44] :-) [19:46:53] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Upload failing (6 MB file) - https://phabricator.wikimedia.org/T111908#1622156 (10matmarex) Thanks @Sebaso. The upload went through for me (I stopped before going further in the wizard), so this isn't ubiquitous, at least. But then I don't know how... [19:49:58] …and done [19:52:28] 6Multimedia: Validate according to range in mw.widget.DateInputWidget - https://phabricator.wikimedia.org/T111993#1622179 (10Prtksxna) 3NEW a:3Prtksxna [19:53:04] 6Multimedia: Validate according to range in mw.widget.DateInputWidget - https://phabricator.wikimedia.org/T111993#1622179 (10Prtksxna) [19:54:24] Calling a moment instance "mom", bold move [19:54:59] I really want to make config variable valiDateIsAfter :P [19:55:28] s/make/make the [19:57:08] There's a joke here about dating your mom [19:57:13] I swear there is [19:58:02] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10Wikipedia-iOS-App-Product-Backlog, 3Reading-Web, 3Wikipedia-Android-App: In the news image doesn't invoke media viewer - https://phabricator.wikimedia.org/T100336#1622200 (10Josve05a) [19:58:27] :P [20:00:31] prtksxna: Putting in "2015-09-10" with a maxDate of 2015-09-09 displays "Tue, 1 Sep 2015" in the text box when I defocus [20:00:48] I guess because it stopped updating instead of blanking it or sticking in "Invalid date" or whatever [20:01:12] But go to bed, I'll comment on the patch [20:02:24] 6Multimedia, 10Wikimedia-Video, 7Design, 7Mobile: Devise a basic interaction design for TV app platforms ("living room", "10-foot experience") - https://phabricator.wikimedia.org/T111994#1622213 (10brion) 3NEW [20:02:33] marktraceur: minDate and maxDate are misleading, they imply >= but are actually > [20:02:37] I am updating the patch now [20:02:45] 6Multimedia, 10Wikimedia-Video, 7Design, 7Mobile: Devise a basic interaction design for TV app platforms ("living room", "10-foot experience") - https://phabricator.wikimedia.org/T111994#1622231 (10brion) [20:03:37] prtksxna: Yes, 2015-09-10 is invalid either way [20:04:13] wtf! why is it showing 1sep :\ [20:04:25] Because when I had put in 2015-09-1 it was perfectly happy [20:04:29] 6Multimedia, 10Wikimedia-Video, 7Design, 7Mobile: Devise a basic interaction design for TV app platforms ("living room", "10-foot experience") - https://phabricator.wikimedia.org/T111994#1622213 (10brion) [20:04:30] marktraceur: You entered the text, didn't use the calendar? [20:04:32] But when I put in the last 0, not so much [20:04:32] Yeah [20:04:49] The calendar works pretty well [20:05:21] marktraceur: I am not able to replicate the problem here [20:05:39] marktraceur: Can you fetch the new patchset and confirm? [20:06:26] Sure, one sec [20:06:35] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Upload failing (6 MB file) - https://phabricator.wikimedia.org/T111908#1622261 (10Tsungam) Could this be a problem with chunked uploads? With chunked uploads enabled, only 3 of 13 files succeeded to upload, these three were below 5 MB. After disabel... [20:06:58] 6Multimedia, 10Wikimedia-Video, 7Mobile: Create Xbox One app for Wikipedia - https://phabricator.wikimedia.org/T111997#1622264 (10brion) 3NEW [20:07:05] 6Multimedia, 10Wikimedia-Video, 7Mobile: Create Xbox One app for Wikipedia - https://phabricator.wikimedia.org/T111997#1622271 (10brion) [20:07:07] 6Multimedia, 10Wikimedia-Video, 7Design, 7Mobile: Devise a basic interaction design for TV app platforms ("living room", "10-foot experience") - https://phabricator.wikimedia.org/T111994#1622272 (10brion) [20:07:16] Also, did you test https://gerrit.wikimedia.org/r/#/c/237186/? [20:07:17] prtksxna: Now I get no validation at all, I think... [20:07:28] :S [20:08:18] prtksxna: Not as such, is that what caused the above? [20:08:40] I doubt it, we are overriding that function [20:09:24] Very odd stuff. [20:09:44] marktraceur: It seems to be working for me, and I don't have any un-pushed changes [20:09:50] Oh, because you changed the name of the config variable [20:09:59] marktraceur: Are you sure you have the latest https://gerrit.wikimedia.org/r/#/c/235431/ too? [20:10:05] marktraceur: Yes! [20:10:34] OK, same result with 2015-09-10 now. [20:11:12] Maybe core is out of date somehow, one sec [20:11:18] Oh, no, this is core [20:11:22] * marktraceur chugs some more caffeine [20:13:41] prtksxna: I'm using firefox, maybe it's a weird (very weird) browser thing? [20:14:07] I am on Chrome, I'll try with FF too [20:14:57] marktraceur: Works on FF too [20:15:19] Huh. [20:15:20] Weeeird. [20:15:29] prtksxna: Can you give me the snippet you're using? [20:15:34] Maybe there's a difference [20:17:22] marktraceur: Yes, just a second [20:17:34] marktraceur: I also want to make sure that we're trying to recreate the same issue [20:17:35] https://phabricator.wikimedia.org/F2562418 [20:17:37] marktraceur: ^ [20:18:56] prtksxna: Is it already 2015-09-10 there? [20:19:03] Yes [20:19:05] Because then UW would allow you to enter that date. [20:19:16] * prtksxna facepalm [20:19:19] Try putting in 2015-09-20 [20:19:35] I am getting the issue too! [20:19:53] marktraceur: code snippet https://github.com/prtksxna/UploadUI [20:19:54] OK, fair enough [20:19:59] Clearly some sleep is necessary, though ;) [20:20:04] not that you need it any more [20:20:10] Yeah [20:20:19] Heyyyyy! The date changed when I wasn't looking :P [20:22:07] This is DateInputWidget doing something funny, maybe MatmaRex knows what [20:32:35] haha [20:32:50] I get it [20:33:04] Its happening because valid is false even if the date is well formed :( [20:33:28] prtksxna: marktraceur: hmm, interesting. i wrote DateInputWidget to reject inputs which are not valid dates (you can't choose them), a bit like you can't choose an option in a dropdown that it doesn't have [20:33:34] And onTextInputChange tries to make a valid date more valid [20:41:25] MatmaRex: I should separate out the isValidDate and isInDateRange methods and make validateDate call those and use just isValid date in onTextInputChange. That should fix it. Does that sound alright? [20:42:37] prtksxna: uh, let me look [20:45:37] prtksxna: sorry, i'm having a hard time imagining this. hmm [20:46:14] prtksxna: so the issue is, corrent me if i'm wrong: currently the widget rejects "invalid" dates, that is, it does not allow you to set a value that wouldn't be valid… [20:47:02] …you want it to also check against min and max date when checking validity; however, you want to *allow* the user to set these "invalid" dates, rather than reject them; and give the widget red styling or something to indicate this [20:47:26] if so, i think what you're saying makes sense. :D [20:51:50] The only thing we need to be able to do to update the display, is have a valid date. [20:52:02] Having a valid field isn't necessary. [20:52:08] So yes, I agree with both of you. [20:52:24] Or neither of you, I think all of us are somehow tired despite being in totally different times of the day [20:53:19] * prtksxna assumes we all agree and goes on to update the patch [20:53:24] Good policy [20:53:24] :-) [20:54:18] IRC consensus! [20:54:29] {{cabal approved}} [20:54:39] or rather {{cabal-approved}} [20:55:20] mom.isValid() :P [20:57:19] "isValidDate", "validateDate", hard to type [20:59:22] Next I'll have you write a special upload tool for picture of fruits [20:59:40] valiDateDate [20:59:40] validateDateDate() [20:59:54] validateDateDateData [20:59:58] mw.ForeignStructuredFruitUpload.Dialog.js [21:00:33] StructuredFruitUpload, for SVGs of buildings made of fruit [21:00:45] Or would that be StructuredFruitStructureUpload [21:00:45] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Clean up possible refactor-related regressions - https://phabricator.wikimedia.org/T96907#1622507 (10matmarex) [21:00:48] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard js error on publishing file on beta labs - https://phabricator.wikimedia.org/T89138#1622504 (10matmarex) 5Open>3Invalid a:3matmarex I'm guessing this must have been transient? [21:01:08] * guillom 's approach to dates in JavaScript is basically "Just use moment.js for everything". [21:01:16] guillom: A great approach. [21:01:59] 6Multimedia, 10MediaWiki-File-management, 10MediaWiki-RfCs: Provide semantic wiki-configurable styles for media display - https://phabricator.wikimedia.org/T90914#1622521 (10daniel) @cscott we'd like to schedule this for an RFC doscussion on IRC next week, on September 16 (2pm SF time on #wikimedia-office).... [21:02:40] marktraceur: The issue you pointed out seems fixed, not sure if I broke EVERYTHING else in the process [21:02:49] OK, fun [21:02:57] prtksxna: Minor code comments fixed too? :D [21:03:27] marktraceur: Oops, didn't see those [21:03:36] Sweet, looks good on the big stuff [21:03:58] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Unspecified date entries from UploadWizard - https://phabricator.wikimedia.org/T85095#1622524 (10matmarex) [21:08:10] Jenkins seems upset now too. [21:08:21] I'll merge it when I get home, I have to run for a bit [21:09:14] marktraceur: Missed a semicolon [21:09:29] marktraceur: Updated, fixed the small stuff too [21:11:16] [01:14:38] prtksxna: I'll sleep once jenkins +2's my patches [21:13:45] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Upload failing (6 MB file) - https://phabricator.wikimedia.org/T111908#1622593 (10Herzi.Pinki) >>! In T111908#1622261, @Tsungam wrote: > Could this be a problem with chunked uploads? With chunked uploads enabled, only 3 of 13 files succeeded to uplo... [21:14:15] * prtksxna amended changes to the wrong commit [21:14:18] * prtksxna facepalms [21:16:59] (03PS2) 10Bartosz Dziewoński: Allow reupload of deleted files ('duplicate-archive' warning) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237158 (https://phabricator.wikimedia.org/T42921) [21:44:23] Finally got the +2 and the changes are in the right commits [21:44:29] This was fun! [21:45:17] * prtksxna wishes James_F, marktraceur, MatmaRex, and prtksxna were all in one timezone [21:46:31] prtksxna: It's called "all staff". :-) [21:47:05] James_F: :) [21:47:08] ┌[；`||～,]┐ z z Z [21:47:37] Bye. [21:51:25] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Upload failing (6 MB file) - https://phabricator.wikimedia.org/T111908#1622671 (10matmarex) I can reproduce after enabling chunked uploads. [21:51:51] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Chunked upload fails (for files >5 MB) - https://phabricator.wikimedia.org/T111908#1622672 (10matmarex) [21:54:14] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Chunked upload fails (for files >5 MB) - https://phabricator.wikimedia.org/T111908#1622677 (10matmarex) `{"servedby":"mw1135","error":{"code":"badparams","info":"Must supply a filekey when offset is non-zero","*":"See https://commons.wikimedia.org/w... [22:30:45] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Chunked upload fails (for files >5 MB) - https://phabricator.wikimedia.org/T111908#1622822 (10matmarex) a:3matmarex [22:41:59] (03PS1) 10Bartosz Dziewoński: Always set 'offset' with chunked uploads, even for first chunk (offset == 0) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237285 (https://phabricator.wikimedia.org/T111908) [22:50:29] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Chunked upload fails (for files >5 MB) - https://phabricator.wikimedia.org/T111908#1622918 (10matmarex) Investigation notes: * I can't reproduce this error locally, even after enabling chunked uploads. The two chunks of this fil... [22:51:17] marktraceur: i need https://gerrit.wikimedia.org/r/237285 merged by tomorrow, so that we can have it swatted. chunked uploads via UW are broken on commons [22:51:36] the change should be a no-op, but instead it fixes it, magically [22:52:11] (03PS2) 10Bartosz Dziewoński: Always set 'offset' with chunked uploads, even for first chunk (offset == 0) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237285 (https://phabricator.wikimedia.org/T111908) [22:53:37] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Chunked uploads: fails immediately when trying to upload large JPEG due to binReader.result being undefined - https://phabricator.wikimedia.org/T42586#1622949 (10matmarex) [22:54:38] James_F: fyi ^^^ [22:58:08] MatmaRex: What about it? [22:58:42] James_F: chunked uploads are broken on commons. thought you might want to know :) [22:58:52] Oh, that. [22:58:54] Yeah. [22:59:07] I was looking at https://phabricator.wikimedia.org/T42586 and trying to work out why I'd care. ;-) [23:00:41] marktraceur: Want to review with eye to a cherry-pick? [23:01:16] marktraceur: (Given that SWAT is right now.) [23:08:38] (03CR) 10Jforrester: [C: 031] "Seems sane…" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237285 (https://phabricator.wikimedia.org/T111908) (owner: 10Bartosz Dziewoński) [23:12:27] marktraceur: Are we doing it? [23:21:55] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Chunked upload fails (for files >5 MB) - https://phabricator.wikimedia.org/T111908#1623083 (10Tgr) Apparently the chunked upload browser tests [[ https://integration.wikimedia.org/ci/view/BrowserTests/view/UploadWizard/job/brows... [23:26:31] heh. [23:27:01] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Chunked upload fails (for files >5 MB) - https://phabricator.wikimedia.org/T111908#1623094 (10BBlack) Well, I see a success in May, and then failures starting in August. No runs between? Also, any chance this is related? T8643... [23:36:24] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Chunked upload fails (for files >5 MB) - https://phabricator.wikimedia.org/T111908#1623144 (10Tgr) I'm not familiar with Jenkins; I just assumed Jenkins discarded old build logs apart from the last successful one. Maybe there wa... [23:46:08] (03CR) 10Legoktm: [C: 032] Check for global blocks in addition to regular ones before showing the wizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/235517 (https://phabricator.wikimedia.org/T111174) (owner: 10Bartosz Dziewoński) [23:46:42] Thanks legoktm. [23:48:22] Np [23:57:01] 6Multimedia, 6Editing-Department, 10Gallery, 10VisualEditor: Make enwiki's Template:Gallery redundant by implementing all its features in wikitext - https://phabricator.wikimedia.org/T95531#1623214 (10Jdforrester-WMF) [23:57:04] 6Multimedia, 10Gallery, 10MediaWiki-Interface, 7JavaScript: Gallery doesn't resize caption on window resize - https://phabricator.wikimedia.org/T91075#1623215 (10Jdforrester-WMF) [23:57:07] 6Multimedia, 10Gallery, 10MediaWiki-General-or-Unknown, 7JavaScript, and 2 others: UX and performance issues with mediawiki.page.gallery module - https://phabricator.wikimedia.org/T88654#1623216 (10Jdforrester-WMF) [23:57:10] 6Multimedia, 10Gallery, 10MediaWiki-extensions-TimedMediaHandler: No way to get to file page of audio file from a gallery - https://phabricator.wikimedia.org/T87056#1623217 (10Jdforrester-WMF) [23:59:57] (03Merged) 10jenkins-bot: Check for global blocks in addition to regular ones before showing the wizard [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/235517 (https://phabricator.wikimedia.org/T111174) (owner: 10Bartosz Dziewoński)