[00:04:06] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Special:UploadWizard needs to notify globally blocked users at the beginning of the process, and provide a standard block message - https://phabricator.wikimedia.org/T111174#1623252 (10Jdforrester-WMF) 5Open>3Resolved [00:41:27] (03PS1) 10Bartosz Dziewoński: Actually display a button to try after errors in the 'Details' step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237306 (https://phabricator.wikimedia.org/T106968) [00:41:29] (03PS1) 10Bartosz Dziewoński: Unbreak final "Continue anyway" button on 'Details' step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237307 [00:41:32] whew. [00:41:39] * MatmaRex wipes sweat from brow [00:41:50] * GEOFBOT throws MatmaRex a towel [00:54:20] 6Multimedia, 10MediaWiki-extensions-UploadWizard: When image uploads fail, the entire process shouldn't have to be started anew, just fixed - https://phabricator.wikimedia.org/T105545#1623338 (10matmarex) >>! In T105545#1452043, @Bush6984 wrote: > This is why I'm proposing that the setup be modified to fully u... [00:56:41] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: UploadWizard form gets to deadlock when the file title is not accepted - https://phabricator.wikimedia.org/T106968#1623343 (10matmarex) (It is the same as T105545 and T100975, though.) All this because of a typo in a cleanup commit made in... [01:14:46] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler: Enable vp9 by default, disable on wikimedia. - https://phabricator.wikimedia.org/T111909#1623371 (10Jdforrester-WMF) p:5Triage>3Low [01:15:27] 6Multimedia, 6Commons, 10Wikimedia-SVG-rendering: SVG file is generating 429 and 500 errors because it is too large - https://phabricator.wikimedia.org/T111815#1623378 (10Jdforrester-WMF) [01:16:29] 6Multimedia, 6Commons, 10MediaWiki-Uploading: Commons private-to-public setting - https://phabricator.wikimedia.org/T111792#1623381 (10Jdforrester-WMF) This will need Legal sign-off and a huge amount of care. In general, the answer to "somewhere users can access that isn't public" is "no". [01:17:45] 6Multimedia, 6Commons, 7Swift: Some files had disappeared from Commons after renaming - https://phabricator.wikimedia.org/T111838#1617529 (10Jdforrester-WMF) [03:48:06] 6Multimedia, 6Commons, 10Wikimedia-SVG-rendering: SVG file is generating 429 and 500 errors because it is too large - https://phabricator.wikimedia.org/T111815#1623479 (10Bawolff) Locally I can render the file (rsvg 2.26.3), but it probably depends on what version of libxml its linked against (google suggest... [04:08:36] 6Multimedia, 6Commons, 10Wikimedia-SVG-rendering: SVG file is generating 429 and 500 errors because it is too large - https://phabricator.wikimedia.org/T111815#1623482 (10Bawolff) Note, its probably not because the image itself is too big, but because the embedded png images are too big (As an aside, the emb... [04:20:57] James_F, legoktm, sorry I missed the SWAT window [04:23:14] 6Multimedia, 10MediaWiki-File-management, 10MediaWiki-Tarball-Backports, 5Patch-For-Review: Uppercase picture extensions like .PNG are not allowed - https://phabricator.wikimedia.org/T68667#1623502 (10Tgr) 5Open>3Resolved Backported to 1.23, verified. Will be part of the next release. [04:25:33] I should really take that event off my calendar, it's 18:00 my time and I've been working 9-5 pretty much [04:31:25] * marktraceur merges date selector silliness [04:45:13] (9-5 and apparently 23:20-23:40) [04:45:21] Because that makes sense [04:45:38] Anyway, I have come home drenched and sore, and now it is time for shower and bed. [04:45:41] 'night y'all [05:14:54] marktraceur: No word from slaporte yet [06:28:01] 6Multimedia, 6Performance-Team, 10Wikimedia-Apache-configuration, 10Wikimedia-Video, 7Regression: Files served from /static directory for text domains are not gzipped - https://phabricator.wikimedia.org/T109040#1623650 (10BBlack) >>! In T109040#1615502, @Krinkle wrote: > This also applies to e.g. https:/... [07:21:33] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Chunked upload fails (for files >5 MB) - https://phabricator.wikimedia.org/T111908#1623711 (10Sebaso) >>! In T111908#1622671, @matmarex wrote: > I can reproduce after enabling chunked uploads. thx for your work. just to confirm... [07:52:00] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237157 (https://phabricator.wikimedia.org/T61646) (owner: 10Bartosz Dziewoński) [11:07:54] 6Multimedia, 10MediaWiki-File-management: Allow adjusting of default gallery display options - https://phabricator.wikimedia.org/T14797#1624627 (10Krenair) [13:21:14] marktraceur: I get "You can only upload files with a size of up to -1 bytes. You tried to upload a file that is 322 KB." whenever I try to upload anything using UW. [13:38:13] marktraceur: No errors in the console [13:38:16] This used to work! [14:07:21] (03CR) 10Anomie: [C: 031] Always set 'offset' with chunked uploads, even for first chunk (offset == 0) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237285 (https://phabricator.wikimedia.org/T111908) (owner: 10Bartosz Dziewoński) [14:07:26] Oh dear. [14:07:44] Maybe involving ^^ [14:08:23] prtksxna: Have you emailed slaporte or only philed a phlask? [14:09:09] marktraceur: You said he'd email me, so I just philed a task. [14:11:52] marktraceur: Uh, I have bots on ignore, what are you ^^ing [14:14:27] Ah. [14:14:36] prtksxna: https://gerrit.wikimedia.org/r/237285 [14:15:40] (03CR) 10MarkTraceur: [C: 032] Always set 'offset' with chunked uploads, even for first chunk (offset == 0) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237285 (https://phabricator.wikimedia.org/T111908) (owner: 10Bartosz Dziewoński) [14:16:12] So we should really SWAT that. [14:17:37] (03Merged) 10jenkins-bot: Always set 'offset' with chunked uploads, even for first chunk (offset == 0) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237285 (https://phabricator.wikimedia.org/T111908) (owner: 10Bartosz Dziewoński) [14:23:43] (03PS1) 10MarkTraceur: Always set 'offset' with chunked uploads, even for first chunk (offset == 0) [extensions/UploadWizard] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/237383 (https://phabricator.wikimedia.org/T111908) [14:25:15] marktraceur: Same error [14:25:46] prtksxna: Really? [14:25:48] That's odd. [14:26:06] Special:Upload and FSUD work fine [14:26:15] I'll reload vagrant just to be sure… [14:28:19] marktraceur: Same, "You can only upload files with a size of up to -1 bytes. You tried to upload a file that is 2.97 MB.". -1 bytes?? [14:29:49] Even for tiny 10kb images [14:30:56] Should I try disabling and renabling the uw role and provisioning? [14:31:55] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Chunked upload fails (for files >5 MB) - https://phabricator.wikimedia.org/T111908#1625389 (10Jarekt) I had the same problem with a set of large photographs (5-30 Mb). I tried many times to upload them since this weekend but eve... [14:33:35] * prtksxna does that [14:39:01] Still the same… [14:44:34] ╯°□°）╯┻━┻ [14:45:13] hi. [14:45:28] I need to have dinner, and I need a table for that, so, ┬─┬ノ( º _ ºノ) [14:45:29] brb [14:49:26] prtksxna: Good save. [14:49:39] MatmaRex: prtksxna was getting "You can only upload files with a size of up to -1 bytes. You tried to upload a file that is 2.97 MB." [14:49:55] I'm just sitting down at the computer so I'm not sure what's wrong [14:50:59] I have to deal with SWAT in ten minutes... [14:51:36] prtksxna: check if your PHP settings upload_max_filesize and post_max_size and not set to -1. (it might be a magic value to disable the limits, i don't quite remember) [14:52:39] marktraceur: i can check the swat if you';re busy [14:54:48] Naw, I can do it, just need to make coffee quick [14:56:11] marktraceur: :-) [14:57:23] Morning, James_F [15:05:24] MatmaRex: Is the bug only for files >5MB? [15:05:57] yes [15:06:11] (we never use chunked upload for smaller ones) [15:06:39] OK, good. [15:10:57] #swatfromhell [15:34:14] MatmaRex: Neither of those are set [15:37:00] (03CR) 10MarkTraceur: [C: 032] Always set 'offset' with chunked uploads, even for first chunk (offset == 0) [extensions/UploadWizard] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/237383 (https://phabricator.wikimedia.org/T111908) (owner: 10MarkTraceur) [15:37:16] marktraceur: oops, closed the wrong window [15:37:22] …and everyone is gone [15:37:26] Yes, we left [15:37:40] prtksxna: Any burning questions, comments, wishes, or desires? [15:38:03] Are we moving both https://phabricator.wikimedia.org/T40030 and https://phabricator.wikimedia.org/T40031 to doing? [15:38:06] marktraceur: ^ [15:38:14] That seems to be the idea, or at least "next up" [15:38:25] * prtksxna nods [15:38:27] (03Merged) 10jenkins-bot: Always set 'offset' with chunked uploads, even for first chunk (offset == 0) [extensions/UploadWizard] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/237383 (https://phabricator.wikimedia.org/T111908) (owner: 10MarkTraceur) [15:38:41] marktraceur: No other questions then :) [15:38:52] Woot woot [15:40:19] MatmaRex: My settings - https://phabricator.wikimedia.org/P2004 https://phabricator.wikimedia.org/P2005 [15:43:31] prtksxna: hold on [15:47:27] Life is so exciting in -operations, prtksxna :) [15:48:45] prtksxna: hmm. there's probably nothing special in those, but [15:48:55] looking at the code which finds out these limits: [15:48:57] 'maxPhpUploadSize' => min( [15:48:58] wfShorthandToInteger( ini_get( 'upload_max_filesize' ) ), [15:48:58] wfShorthandToInteger( ini_get( 'post_max_size' ) ) [15:48:58] ), [15:49:16] you're saying that neither of these is set - like not existing at all, or set to an empty value? [15:49:27] if it's set to an empty value, then wfShorthandToInteger() will return -1, apparnetly. [15:58:43] MatmaRex: Are these variables specific to UW? [15:59:14] no [15:59:30] but perhaps PHP interprets them differently than MW/UploadWizard [15:59:36] MatmaRex: FSUD, and Special:Upload are working fine [15:59:37] Ah [15:59:47] MatmaRex: What do you have them set to? [16:00:15] some ludicrously large values, let me see [16:00:42] upload_max_filesize = 1G [16:00:52] post_max_size = 200M [16:06:11] MatmaRex: erm in php.ini? [16:06:35] You can set them in LS.php too I think [16:08:28] prtksxna: php.ini, yes [16:13:03] MatmaRex: You expressed concern about jquery.ui being used in validation, right? I might glance at that before I replace error dialogs. [16:14:55] 'cause I think http://plugins.jquery.com/validate/ is fine as it is, apart from not being the OOUI validation [16:14:59] We can replace it slowly [16:15:44] 6Multimedia: Replace jquery dialogs in UploadWizard with OOUI dialogs - https://phabricator.wikimedia.org/T112117#1626113 (10MarkTraceur) 3NEW a:3MarkTraceur [16:16:10] 6Multimedia: Replace jquery dialogs in UploadWizard with OOUI dialogs - https://phabricator.wikimedia.org/T112117#1626128 (10MarkTraceur) [16:16:12] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 7Epic: Migrate UploadWizard UI elements to OOjs UI - https://phabricator.wikimedia.org/T96914#1626127 (10MarkTraceur) [16:18:32] marktraceur: hm [16:20:23] MatmaRex: They were already set in php.ini, I was looking only at LS.php initially [16:24:23] 6Multimedia, 6Performance-Team, 10Wikimedia-Apache-configuration, 10Wikimedia-Video, and 2 others: Files served from /static directory for text domains are not gzipped - https://phabricator.wikimedia.org/T109040#1626186 (10Krinkle) >>! In T109040#1623650, @BBlack wrote: >>>! In T109040#1615502, @Krinkle wr... [16:26:08] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Chunked upload fails (for files >5 MB) - https://phabricator.wikimedia.org/T111908#1626200 (10matmarex) 5Open>3Resolved This is fixed now, and the fix is deployed on Commons. I've learned that the root cause was a security p... [16:32:35] I have explicitly set wgMaxUploadSize and wgUploadSizeWarning now too [16:33:07] (03CR) 10Bartosz Dziewoński: Better handle revdeleted file duplicates when displaying warning popup (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237157 (https://phabricator.wikimedia.org/T61646) (owner: 10Bartosz Dziewoński) [16:37:15] Still the same [16:37:29] I don't think I want to stay up till late tonight [16:37:42] I'll try and fix this tomorrow night when you guys are online [16:38:01] I'll work on the CategorySelector tomorrow then. HA! [16:38:06] marktraceur: ^ [16:39:24] hmph. that's one weird issue. :/ [16:39:47] prtksxna: hmm. maybe you need to restart apache for php.ini changes to take? [16:40:01] sudo service apache2 restart [16:40:54] (be right back. grabbing some food.) [16:41:15] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237157 (https://phabricator.wikimedia.org/T61646) (owner: 10Bartosz Dziewoński) [16:41:48] MatmaRex: They were already there, also I am vagrant reload must be doing that already [16:42:01] MatmaRex: there's a bug with maxPhpUploadSize in HHVM that we're hacking around in mw-config [16:42:15] // FIXME: Temp fix for T98933 - legoktm 2015-05-12 [16:42:15] 'maxPhpUploadSize' => 104857600, [18:35:05] (03PS1) 10Bartosz Dziewoński: Move details step status labels from PHP to JS [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237455 [18:37:02] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Move UI creation into JavaScript - https://phabricator.wikimedia.org/T96918#1626903 (10matmarex) I made some small steps towards this while working on other issues: * cae915a6dfb422d6dc8c7b87dd83d3438b7077ef * d811c8ee289c6eb990322ef80e5c9d99595eaffa * ec5b7c90... [18:40:04] 6Multimedia, 6Commons, 7Swift: Some files had disappeared from Commons after renaming - https://phabricator.wikimedia.org/T111838#1626920 (10Wieralee) An uploader of this files is claiming to "give him his files back". I have found small versions of these photos in google. I don't know if I should upload the... [18:42:47] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/213763 (https://phabricator.wikimedia.org/T109079) (owner: 10Paladox) [18:51:06] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Replace jquery dialogs in UploadWizard with OOUI dialogs - https://phabricator.wikimedia.org/T112117#1627043 (10matmarex) [18:55:31] 6Multimedia, 10MediaWiki-extensions-UploadWizard: duplicate link: is not HTML-linked to file page, not red and points to the wrong URL - https://phabricator.wikimedia.org/T34606#1627096 (10matmarex) a:3matmarex >>! In T34606#381701, @MarkTraceur wrote: > OK, so to be clear, the reason this is a problem is be... [18:55:46] 6Multimedia, 10MediaWiki-extensions-UploadWizard: duplicate link: is not HTML-linked to file page, not red and points to the wrong URL - https://phabricator.wikimedia.org/T34606#1627099 (10matmarex) [18:55:48] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Replace jquery dialogs in UploadWizard with OOUI dialogs - https://phabricator.wikimedia.org/T112117#1627098 (10matmarex) [18:58:28] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 7Easy: Add parameter(s) for UploadWizard to redirect to target page after upload - https://phabricator.wikimedia.org/T48242#1627199 (10matmarex) WMDE folks implemented a variant of this for Wiki Loves Monuments campaigns, see T105281. [19:03:11] 6Multimedia, 10MediaWiki-extensions-UploadWizard: File selection control not centered after some failure cycles - https://phabricator.wikimedia.org/T53960#1627241 (10matmarex) I can no longer reproduce using the provided steps. It appears this has been fixed. [19:03:19] 6Multimedia, 10MediaWiki-extensions-UploadWizard: File selection control not centered after some failure cycles - https://phabricator.wikimedia.org/T53960#1627244 (10matmarex) 5Open>3Resolved [19:04:43] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: UW: re-upload of deleted file impossible (duplicate-archive case); should have override - https://phabricator.wikimedia.org/T42921#1627262 (10matmarex) [19:04:46] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: UploadWizard form gets to deadlock when the file title is not accepted - https://phabricator.wikimedia.org/T106968#1627261 (10matmarex) [19:04:51] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard, 6Reading-Infrastructure-Team, and 2 others: Address technical issues responsible for funnel drop-offs in UploadWizard - https://phabricator.wikimedia.org/T91652#1627260 (10matmarex) [19:08:21] 6Multimedia, 10Wikimedia-Media-storage, 6Wikisource: Swift outage caused a bunch of moved files to be "inconsistent" and "missing" - https://phabricator.wikimedia.org/T71311#1627303 (10Ankry) Probably the files can be restored while renaming back under their previous names. Like I did it a while ago in the c... [19:08:32] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Make stashed / async uploads rely on the database instead of the session - https://phabricator.wikimedia.org/T77828#1627307 (10matmarex) Upload stash data is most definitely stored in the database. [19:08:41] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Make stashed / async uploads rely on the database instead of the session - https://phabricator.wikimedia.org/T77828#1627310 (10matmarex) 5Open>3Resolved [19:08:43] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 7Epic: Improve upload funnel survival rate - https://phabricator.wikimedia.org/T85555#1627313 (10matmarex) [20:05:25] brion: hi, i see my ffmpeg 2.8 switched my defualt ancoding to vp9 and opus, that does not work for commons as of now, right ? [20:05:32] *encoding [20:10:11] 6Multimedia, 6Performance-Team, 10Wikimedia-Apache-configuration, 10Wikimedia-Video, and 2 others: Files served from /static directory for text domains are not gzipped - https://phabricator.wikimedia.org/T109040#1627713 (10BBlack) I've merged a change that should fix this and some other related cases. It'... [20:19:52] OK...I have to run and sign a lease, bloody scheduling is difficult, I'll be back later to do some code review and maybe finish my dialogs patch for UW. [20:26:55] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 6TCB-Team, 5Patch-For-Review: [WLM] Make UW button targets dynamically set - https://phabricator.wikimedia.org/T105281#1627832 (10Nemo_bis) I'm not sure what the home button is being talked about here (do we really expect users to press the home button on t... [20:28:30] matanya: it works just fine if it's installed :D [20:28:40] which it isn't yet [20:28:44] heh [20:29:13] there was a slight snag in testing on beta cluster [20:29:19] need to coordinate to get that fixed up... [20:29:57] ok, so i'll change the default to vp8 with vorbis, thanks [20:30:23] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 6TCB-Team, 5Patch-For-Review: [WLM] Possibility to choose which of the uploaded images should be shown by default on the list - https://phabricator.wikimedia.org/T105283#1627870 (10Nemo_bis) [20:30:40] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 6TCB-Team, 5Patch-For-Review: [WLM] Change the target and the name of the "Back to Wiki" link shown after successful upload - https://phabricator.wikimedia.org/T105285#1627875 (10Nemo_bis) [20:31:04] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 6TCB-Team, 5Patch-For-Review: [WLM] fix button configuration for Commons campaigns to check for a given object reference - https://phabricator.wikimedia.org/T110697#1627879 (10Nemo_bis) [20:43:54] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: UW: re-upload of deleted file impossible (duplicate-archive case); should have override - https://phabricator.wikimedia.org/T42921#1627969 (10Tgr) The more generic issue is T77550 (which I merged in a somewhat stupid way as the open bug is... [20:47:30] 6Multimedia, 6Commons, 7Swift: Some files had disappeared from Commons after renaming - https://phabricator.wikimedia.org/T111838#1627993 (10Tgr) Often the files still exist on disk, they just have a different name than in the DB so the system cannot find them. Do you know which files the uploader is talking... [22:12:20] 6Multimedia, 6Commons, 7Swift: Some files had disappeared from Commons after renaming - https://phabricator.wikimedia.org/T111838#1628554 (10Wieralee) I wrote it at the beginning... "Some files had disappeared from Commons after renaming. Purging does not work. File:Днестровский горсовет.jpg File:Улица 25...