[00:39:35] (03CR) 10Jforrester: [C: 031] "Remove 'oo' from .jshintrc so it doesn't allow use of it as a global in future." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237922 (owner: 10Bartosz Dziewoński) [01:07:21] 6Multimedia, 10MassAction, 10MediaWiki-Internationalization, 10MediaWiki-extensions-GWToolset, and 6 others: Special pages, actions and views whose messages don't escape text - https://phabricator.wikimedia.org/T85864#1636025 (10Yaron_Koren) [03:28:04] 6Multimedia, 6Commons, 10MediaWiki-API, 10MediaWiki-Uploading, 5Patch-For-Review: Provide a well-performing API to rotate an image - https://phabricator.wikimedia.org/T35186#1636134 (10AdamCuerden) Can I make a request that this ONLY be done for 90, 180, or 270° rotations? Anything that needs a crop or t... [07:10:42] 6Multimedia, 6Commons, 10MediaWiki-API, 10MediaWiki-Uploading, 5Patch-For-Review: Provide a well-performing API to rotate an image - https://phabricator.wikimedia.org/T35186#1636312 (10Rillke) >>! In T35186#1636134, @AdamCuerden wrote: > Can I make a request that this ONLY be done for 90, 180, or 270° ro... [10:11:41] 6Multimedia, 10MediaWiki-File-management, 7Easy: PNG metadata extractor doesn't properly convert dates - https://phabricator.wikimedia.org/T58064#1636595 (10Bawolff) >So do you want only timezones implemented? And if so, which timezone? We want timezone specifiers handled. So ideally 1997-07-16T19:20:30+01... [11:38:00] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Interner Fehler: Der Token ist fehlerhaft. - https://phabricator.wikimedia.org/T112514#1636837 (10Steinsplitter) 3NEW [11:41:26] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Fehlschlagung durch einen redundanten Titel - https://phabricator.wikimedia.org/T112515#1636861 (10Steinsplitter) 3NEW [12:29:02] 6Multimedia, 6Commons, 10Wikimedia-Site-Requests: Please upload large files to Wikimedia Commons - https://phabricator.wikimedia.org/T111941#1637003 (10Krenair) (files were moved around a bit) ```krenair@tin:~$ time tiffinfo upload-T111941/broken/UBBasel_Map_1700-1799_VB_A2-2-120a.tif >/dev/null TIFFReadDire... [12:30:19] 6Multimedia, 6Commons, 10Wikimedia-Site-Requests: Please upload large files to Wikimedia Commons - https://phabricator.wikimedia.org/T111941#1637027 (10Krenair) a:5Krenair>3None [12:49:36] Morning team [13:12:33] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Fehlschlagung durch einen redundanten Titel - https://phabricator.wikimedia.org/T112515#1637158 (10Aklapper) Thanks for taking the time to report this! To resolve issues, it helps to have exact steps to reproduce. Could you [[ https://www.mediawiki.org/wiki/Ho... [13:13:50] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Interner Fehler: Der Token ist fehlerhaft. - https://phabricator.wikimedia.org/T112514#1637172 (10Aklapper) Thanks for taking the time to report this! Is this the same as T112446? (For future reference, could you please file reports in English so the developer... [13:23:01] 6Multimedia, 6Commons, 10Wikimedia-Site-Requests: Please upload large files to Wikimedia Commons - https://phabricator.wikimedia.org/T111941#1637190 (10Bawolff) >>! In T111941#1633125, @Krenair wrote: > Oh, sorry, I misremembered the limit - it's 4GB rather than 5GB. That also rules out this one: > ```-rw-r-... [13:37:08] 6Multimedia, 6Commons, 10Wikimedia-Site-Requests: Please upload large files to Wikimedia Commons - https://phabricator.wikimedia.org/T111941#1637228 (10Krenair) >>! In T111941#1637190, @Bawolff wrote: > ``` > vips tiffsave UBBasel_Map_Kanton_Bern_1672_Kartenslg_Schw_Cb_2.tif out.tif --compression deflate > `... [13:52:44] weird, special:upload says max file size is 1000MB https://commons.wikimedia.org/wiki/Special:Upload [13:52:47] which is untrue [13:52:54] i thought [13:53:03] due to post_max_size [13:56:00] does Special:Upload check that? [13:56:10] i know UW does, not sure about the special [14:02:02] 6Multimedia, 6Commons, 10Wikimedia-Site-Requests: Please upload large files to Wikimedia Commons - https://phabricator.wikimedia.org/T111941#1637280 (10Krenair) And: ```-rw-r--r-- 1 mwdeploy mwdeploy 16G Sep 14 13:52 UBBasel_Map_1568_Kartenslg_AA_26-48.tif -rw-rw-r-- 1 mwdeploy mwdeploy 239M Sep 14 13:56... [14:11:34] 6Multimedia, 6Commons, 10Wikimedia-Site-Requests: Please upload large files to Wikimedia Commons - https://phabricator.wikimedia.org/T111941#1637320 (10Basel_University_Library) Sorry for all the inconvenience caused ... UBBasel_Map_Kanton_Bern_1672_Kartenslg_Schw_Cb_2.tif ist a multitiff. vips seems to kee... [14:14:14] 6Multimedia, 6Commons, 10Wikimedia-Site-Requests: Please upload large files to Wikimedia Commons - https://phabricator.wikimedia.org/T111941#1637324 (10Krenair) >>! In T111941#1637320, @Basel_University_Library wrote: > UBBasel_Map_Kanton_Bern_1672_Kartenslg_Schw_Cb_2.tif ist a multitiff. vips seems to keep... [14:14:41] 6Multimedia, 6Commons, 10Wikimedia-Site-Requests: Please upload large files to Wikimedia Commons - https://phabricator.wikimedia.org/T111941#1637326 (10Krenair) a:3Basel_University_Library [14:15:00] 6Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading, 10pywikibot-core: uploading a .webm with a file name identical to a jpg name fails with a cryptic error: ERROR: Upload error: 'exists-normalized' - https://phabricator.wikimedia.org/T101647#1637328 (10Anomie) 5Open>3declined a:3Anomie > and if the... [14:16:28] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Fehlschlagung durch einen redundanten Titel - https://phabricator.wikimedia.org/T112515#1637336 (10Bawolff) > Could you provide a list of steps to reproduce the problem I don't think steinsplitter is reporting a problem he has experienced, but one that was rep... [14:19:52] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Upload wizard fails with api-error-badtoken, cannot resubmit - https://phabricator.wikimedia.org/T112446#1637351 (10MartinK) [14:21:58] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Upload wizard fails with api-error-badtoken, cannot resubmit - https://phabricator.wikimedia.org/T112446#1637357 (10MartinK) 5duplicate>3Open p:5Triage>3Unbreak! [14:22:56] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Interner Fehler: Der Token ist fehlerhaft. - https://phabricator.wikimedia.org/T112514#1637359 (10MartinK) [14:22:58] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Upload wizard fails with api-error-badtoken, cannot resubmit - https://phabricator.wikimedia.org/T112446#1634977 (10MartinK) [14:31:00] 6Multimedia, 10MediaWiki-extensions-EducationProgram, 10MediaWiki-extensions-SiteMatrix, 10MediaWiki-extensions-UploadWizard, and 3 others: LanguageNames not falling back properly - https://phabricator.wikimedia.org/T111643#1637381 (10Krenair) 5Open>3Resolved [14:31:14] 6Multimedia, 10MediaWiki-extensions-EducationProgram, 10MediaWiki-extensions-SiteMatrix, 10MediaWiki-extensions-UploadWizard, and 2 others: LanguageNames not falling back properly - https://phabricator.wikimedia.org/T111643#1612596 (10Krenair) [14:32:54] Urgh dialogs [14:32:59] If I have to write another dialog [14:35:15] marktraceur: o/ [14:43:36] 6Multimedia, 10MediaWiki-File-management, 7Easy: PNG metadata extractor doesn't properly convert dates - https://phabricator.wikimedia.org/T58064#1637417 (10Galorefitz) Alright, thanks! :) [14:51:54] 6Multimedia, 6Commons, 10Wikimedia-Site-Requests: Please upload large files to Wikimedia Commons - https://phabricator.wikimedia.org/T111941#1637434 (10Basel_University_Library) I recreated the UBBasel_Map_1700-1799_VB_A2-2-120a.tif New URL: http://www.ub.unibas.ch/digi/a100/diverse_projekte/UBBasel_Map_170... [14:53:25] 6Multimedia, 6Commons, 10Wikimedia-Site-Requests: Please upload large files to Wikimedia Commons - https://phabricator.wikimedia.org/T111941#1637436 (10Bawolff) I found a different command that should work on multipage tiffs ``` tiffcp -c zip:p9 infile.tif outfile.tif ``` I believe tiffcp is part of libtiff. [14:55:10] Hey prtksxna! [14:55:14] What can I do you fer? [14:56:02] marktraceur: Get an answer from slaporte :) [14:56:25] Haven't made much progress on the category selector today, I'll have something for you to review by tomorrow [14:59:37] Ugh. [14:59:40] OK [15:00:05] hi [15:01:06] 6Multimedia, 6Commons, 10Wikimedia-Site-Requests: Please upload large files to Wikimedia Commons - https://phabricator.wikimedia.org/T111941#1637463 (10Basel_University_Library) @Bawolff - yes we used tiffcp to create the multitiffs in the first place. I will try, what it can do for UBBasel_Map_1568_Kartensl... [15:15:46] 6Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading: First chunk can be smaller than 1024 bytes - https://phabricator.wikimedia.org/T112405#1637544 (10Anomie) 5Open>3Invalid a:3Anomie >>! In T112405#1635010, @XZise wrote: > ``` > $ curl -b cookie.lwp -F format=json -F action=upload -F stash=1 -F filesi... [15:18:32] 6Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading, 10pywikibot-core: Unable to continue/finish uploading chunked file - https://phabricator.wikimedia.org/T112416#1637551 (10Anomie) 5Open>3Invalid a:3Anomie See explanation of what's going on here in T112405#1637544. The short version is that your fi... [15:21:44] 6Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading: First chunk can be smaller than 1024 bytes - https://phabricator.wikimedia.org/T112405#1637556 (10XZise) So what is the result from stashimageinfo good for? Afaik it should return that the chunk is invalid as well. [15:24:58] 6Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading: First chunk can be smaller than 1024 bytes - https://phabricator.wikimedia.org/T112405#1637574 (10XZise) Additionally is there a security concern why it isn't further processed? Or should we just upload a 1 KiB chunk to check if any warnings happen so that... [15:42:00] 6Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading: First chunk can be smaller than 1024 bytes - https://phabricator.wikimedia.org/T112405#1637646 (10Anomie) >>! In T112405#1637556, @XZise wrote: > So what is the result from stashimageinfo good for? It shows you that the single "file" was stashed and gives... [15:51:19] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Fehlschlagung durch einen redundanten Titel - https://phabricator.wikimedia.org/T112515#1637693 (10matmarex) From Google Translate: > In case of failure suppression by a redundant title can no longer press on Upload again, so you have to repeat the work for no... [15:56:39] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Upload wizard fails with api-error-badtoken, cannot resubmit - https://phabricator.wikimedia.org/T112446#1637722 (10matmarex) p:5Unbreak!>3High I don't think this warrants "Unbreak Now!" priority. I believe this only affects users who open UploadWizard, lea... [16:08:02] 6Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading: Allow continuing the upload in stashed mode after warning - https://phabricator.wikimedia.org/T112543#1637770 (10XZise) 3NEW [16:12:22] 6Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading: Allow continuing the upload in stashed mode after warning - https://phabricator.wikimedia.org/T112543#1637808 (10Anomie) [16:22:50] 6Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading: Allow continuing the upload in stashed mode after warning - https://phabricator.wikimedia.org/T112543#1637846 (10Anomie) I rewrote the description since it seemed to be describing the opposite of reality, possibly due to terminology confusion between the s... [16:31:08] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard throws “Error: Unable to parse title“ when a URL parameter (categories) contains characters not allowed in page titles - https://phabricator.wikimedia.org/T112417#1637888 (10matmarex) [16:39:48] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Fehlschlagung durch einen redundanten Titel - https://phabricator.wikimedia.org/T112515#1637927 (10Jdforrester-WMF) [16:39:51] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5WMF-deploy-2015-09-15_(1.26wmf23), 7user-notice: UploadWizard form gets to deadlock when the file title is not accepted - https://phabricator.wikimedia.org/T106968#1637928 (10Jdforrester-WMF) [16:40:20] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard throws “Error: Unable to parse title“ when a URL parameter (categories) contains characters not allowed in page titles - https://phabricator.wikimedia.org/T112417#1637932 (10Jdforrester-WMF) p:5Triage>3High [16:51:46] 6Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading: Allow continuing the upload in stashed mode after warning - https://phabricator.wikimedia.org/T112543#1638007 (10Jdforrester-WMF) Is this a dupe of {T85561}? [16:56:32] i'm going to get some food and then do the categories thing and the token thing. [16:59:14] MatmaRex: Category selector in UW? Or something else? [17:02:11] In similar news, I'm going to go get some food and then double-check my dialog patch. [17:02:27] (03PS2) 10MarkTraceur: Use OOUI dialogs instead of jquery.ui [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237689 (https://phabricator.wikimedia.org/T112117) [17:02:31] But there it is if you want to look at it [17:03:44] (03CR) 10jenkins-bot: [V: 04-1] Use OOUI dialogs instead of jquery.ui [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237689 (https://phabricator.wikimedia.org/T112117) (owner: 10MarkTraceur) [17:04:25] 6Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading: Allow continuing the upload in stashed mode after warning - https://phabricator.wikimedia.org/T112543#1638054 (10Anomie) >>! In T112543#1638007, @Jdforrester-WMF wrote: > Is this a dupe of {T85561}? No. That's about looking in the stash for UI purposes, w... [17:07:12] marktraceur: no, https://phabricator.wikimedia.org/T112417 [17:24:33] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 6Performance-Team, 10Wikimedia-Video, 5Patch-For-Review: Experiment with Video.js - https://phabricator.wikimedia.org/T100106#1638193 (10Paladox) Switch video.js resolutions plugin to https://github.com/kmoskwiak/videojs-resolution-switcher which is... [17:41:22] 6Multimedia, 6Commons, 10Wikimedia-Site-Requests: Please upload large files to Wikimedia Commons - https://phabricator.wikimedia.org/T111941#1638246 (10Krenair) >>! In T111941#1637434, @Basel_University_Library wrote: > I recreated the UBBasel_Map_1700-1799_VB_A2-2-120a.tif > > New URL: http://www.ub.unibas... [18:02:45] 6Multimedia, 6Commons, 10Wikimedia-Site-Requests: Please upload large files to Wikimedia Commons - https://phabricator.wikimedia.org/T111941#1638347 (10Krenair) >>! In T111941#1637463, @Basel_University_Library wrote: > For UBBasel_Map_Kanton_Bern_1672_Kartenslg_Schw_Cb_2.tif, I have also prepared a smaller... [18:44:13] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 6Performance-Team, 10Wikimedia-Video, 5Patch-For-Review: Experiment with Video.js - https://phabricator.wikimedia.org/T100106#1638557 (10Paladox) [18:45:05] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 6Performance-Team, 10Wikimedia-Video, 5Patch-For-Review: Experiment with Video.js - https://phabricator.wikimedia.org/T100106#1305581 (10Paladox) [18:46:49] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 6Performance-Team, 10Wikimedia-Video, 5Patch-For-Review: Experiment with Video.js - https://phabricator.wikimedia.org/T100106#1638589 (10Paladox) [18:49:27] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 6Performance-Team, 10Wikimedia-Video, 5Patch-For-Review: Experiment with Video.js - https://phabricator.wikimedia.org/T100106#1638612 (10Paladox) [18:58:20] (03PS28) 10Paladox: [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [18:58:30] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [19:03:03] (03CR) 10Paladox: "Known issue is with volume control where by it would show two scroll bars in prevous patch this did not happen." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [19:05:08] (03PS29) 10Paladox: [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [19:10:39] (03PS1) 10Bartosz Dziewoński: Don't fail horribly when invalid categories are passed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238219 (https://phabricator.wikimedia.org/T112417) [19:18:03] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10UI-Standardization: Fix style of tipsy tooltips in MediaViewer - https://phabricator.wikimedia.org/T77402#1638681 (10Volker_E) p:5Normal>3Lowest [19:26:36] (03PS1) 10Bartosz Dziewoński: Disable jQuery.validator debug mode [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238222 [19:27:27] Wait, really? [19:27:54] (03CR) 10MarkTraceur: [C: 032] "Gods." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238222 (owner: 10Bartosz Dziewoński) [19:27:57] That's embarassing. [19:28:39] heh [19:28:48] well, it did not output anything for a long time. [19:29:19] (03Merged) 10jenkins-bot: Disable jQuery.validator debug mode [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238222 (owner: 10Bartosz Dziewoński) [19:35:29] (03CR) 10MarkTraceur: "Shouldn't it be an invalid entry if you stick in invalid characters?" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238219 (https://phabricator.wikimedia.org/T112417) (owner: 10Bartosz Dziewoński) [19:37:09] (03CR) 10Bartosz Dziewoński: "I don't understand? It is not the user's fault for clicking on a botched link, we shouldn't punish them for it." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238219 (https://phabricator.wikimedia.org/T112417) (owner: 10Bartosz Dziewoński) [19:37:59] Ohhhh [19:38:02] I misunderstood. [19:39:33] (03CR) 10MarkTraceur: [C: 032] "I misunderstood, I tested by putting <<< into the categories field in the wizard, this makes much more sense" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238219 (https://phabricator.wikimedia.org/T112417) (owner: 10Bartosz Dziewoński) [19:39:55] hmm, yeah, we don't seem to handle that well… [19:40:01] it actually also causes exceptions. [19:40:05] although fairly harmless ones. [19:41:03] (how i feel every time i'm fixing an uploadwizard bug: http://i.imgur.com/t0XHtgJ.gif) [19:41:12] (03Merged) 10jenkins-bot: Don't fail horribly when invalid categories are passed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238219 (https://phabricator.wikimedia.org/T112417) (owner: 10Bartosz Dziewoński) [19:46:27] MatmaRex: True dat [19:46:45] * MatmaRex fixing [19:49:25] Thanks :) [19:54:22] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Upload wizard fails with api-error-badtoken, cannot resubmit - https://phabricator.wikimedia.org/T112446#1638861 (10MartinK) @matmarex We are in the middle of Wiki Loves Monuments right now. For multi uploads this probably is the most busy time of the year. The... [20:25:03] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 6Performance-Team, 10Wikimedia-Video, 5Patch-For-Review: Experiment with Video.js - https://phabricator.wikimedia.org/T100106#1639007 (10TheDJ) Eh, nothing is 'meant' for videoJS 5, some things are just already ported and other (mostly of it) not. [20:28:04] 6Multimedia, 10MediaWiki-extensions-TimedMediaHandler, 6Performance-Team, 10Wikimedia-Video, 5Patch-For-Review: Experiment with Video.js - https://phabricator.wikimedia.org/T100106#1639018 (10Paladox) Ok but that new resolution plugs is. [20:39:10] (03PS1) 10Catrope: Update for I51f7966add: load oojs-ui.styles.icons [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238309 [20:47:37] (03PS1) 10Bartosz Dziewoński: Handle invalid titles better in mwCoolCats [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238313 [20:48:09] marktraceur: ^ [20:49:04] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, 3Reading-Web: Mediaviewer failing in mobile when file names include special characters - https://phabricator.wikimedia.org/T111609#1639130 (10Jdlrobson) p:5Triage>3Normal [20:51:29] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, 3Reading-Web: Safari 8: Mediaviewer failing in mobile when file names include special characters - https://phabricator.wikimedia.org/T111609#1639137 (10Jdlrobson) [20:51:53] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, 3Reading-Web: Safari 8: Mediaviewer failing in mobile when file names include special characters - https://phabricator.wikimedia.org/T111609#1611774 (10Jdlrobson) [20:52:01] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, 3Reading-Web: Safari 8: Mediaviewer failing in mobile when file names include special characters - https://phabricator.wikimedia.org/T111609#1611774 (10Jdlrobson) (Confirmed in Safari 8) [20:52:15] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, 3Reading-Web-Sprint-56-Four Lions: Safari 8: Mediaviewer failing in mobile when file names include special characters - https://phabricator.wikimedia.org/T111609#1639145 (10Jdlrobson) [20:53:21] (03CR) 10MarkTraceur: [C: 032] Handle invalid titles better in mwCoolCats [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238313 (owner: 10Bartosz Dziewoński) [20:54:42] (03Merged) 10jenkins-bot: Handle invalid titles better in mwCoolCats [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238313 (owner: 10Bartosz Dziewoński) [20:54:48] Thanks Jenkins. [21:03:38] oh my, irccloud changed its font. my eyes [21:04:43] nevermind, there's a dark monospace theme :) [21:16:58] (03PS1) 10Bartosz Dziewoński: Really recover from 'badtoken' error when uploading [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238325 (https://phabricator.wikimedia.org/T71691) [21:17:09] GEOFBOT: YuviPanda has opinions on this too. [21:17:49] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Upload wizard fails with api-error-badtoken, cannot resubmit - https://phabricator.wikimedia.org/T112446#1639240 (10matmarex) Thank you for filing this bug, I missed a spot when I was fixing this the last time (T71691). I hope I did not mis... [21:18:04] this would be SO MUCH EASIER if we did not have so much ENTIRELY CUSTOM CODE [21:18:04] :P [21:18:11] * MatmaRex stabs UploadWizard [21:18:19] MatmaRex: Right? [21:18:30] marktraceur: review, test and SWAT https://gerrit.wikimedia.org/r/238325 ? :P [21:18:30] * marktraceur reviews [21:18:35] Probably not SWAT [21:18:38] I have a thing at 6 [21:19:28] MatmaRex: I guess this will get better as we move towards mw.Upload. [21:19:52] hmph, i can't really either today. i guess i'll try to do it tomorrow [21:20:20] AOK. [21:20:30] James_F: Think you can SWAT it? :D [21:20:53] I can. [21:21:16] I swatted a mosquito yesterday. [21:21:27] it was a very convenient bugfix [21:23:33] OK, I'll just merge this then. [21:24:12] Hrm. [21:24:15] Maybe we shouldn't [21:24:37] MatmaRex: I don't know if it was your patch, but I just had UploadWizard submit a form from the details page that...I don't even know what [21:24:56] um [21:25:00] screenshot? [21:25:27] It asks me if I want to leave the page [21:25:46] Then it sends me to, like, Special:UploadWizard?description1=aoeua&date1=2015-09-01 etc. [21:26:02] Must be missing a return 0 somewhere [21:26:28] Shit, it's in master. [21:26:35] * marktraceur scrambles [21:28:43] Bisecting... [21:30:40] MatmaRex: Somehow, jquery.validator's debug mode caused a bug. [21:31:13] ugh [21:31:15] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Upload wizard fails with api-error-badtoken, cannot resubmit - https://phabricator.wikimedia.org/T112446#1639286 (10intracer) And where are the tests? [21:31:16] well [21:31:28] revert then? i admit i didn't test that patch [21:31:33] it seemed trivial… [21:32:30] marktraceur: ^ [21:33:33] I thought the same. [21:33:36] Revertiiiing [21:33:59] (03PS1) 10MarkTraceur: Revert "Disable jQuery.validator debug mode" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238332 [21:34:08] It must be stopping the form from submitting normally in debug mode [21:35:33] http://jqueryvalidation.org/validate yup [21:35:39] Enables debug mode. If true, the form is not submitted and certain errors are displayed on the console (will check if a window.console property exists). Try to enable when a form is just submitted instead of validation stopping the submit. [21:35:46] What a stupid way to make that work [21:39:53] MatmaRex: Be a dear and review that, please [21:40:09] Then I'll rebase yours, test again, and merge [21:40:25] And then James_F can SWAT it without, you know, breaking Commons. [21:41:00] * James_F crosses fingers. [21:41:08] seriously? that's fucked up [21:41:11] (03CR) 10Bartosz Dziewoński: [C: 032] Revert "Disable jQuery.validator debug mode" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238332 (owner: 10MarkTraceur) [21:42:39] (03Merged) 10jenkins-bot: Revert "Disable jQuery.validator debug mode" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238332 (owner: 10MarkTraceur) [21:43:51] (03PS2) 10MarkTraceur: Really recover from 'badtoken' error when uploading [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238325 (https://phabricator.wikimedia.org/T71691) (owner: 10Bartosz Dziewoński) [21:44:38] (03CR) 10MarkTraceur: [C: 032] Really recover from 'badtoken' error when uploading [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238325 (https://phabricator.wikimedia.org/T71691) (owner: 10Bartosz Dziewoński) [21:44:47] Perfect. [21:45:14] (03PS1) 10MarkTraceur: Really recover from 'badtoken' error when uploading [extensions/UploadWizard] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/238334 (https://phabricator.wikimedia.org/T71691) [21:46:05] (03Merged) 10jenkins-bot: Really recover from 'badtoken' error when uploading [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238325 (https://phabricator.wikimedia.org/T71691) (owner: 10Bartosz Dziewoński) [21:46:51] James_F: You've been added to SWAT. [21:47:10] Right-o. Is the cherry-pick ready to go? Also, ideally, tested? :-) [21:47:38] i verified that it solves the particular case that was reported [21:47:44] OK, that WFM. [21:47:56] i hope there aren't any more places where we can get badtoken errors hidden away [21:47:59] (03PS2) 10Jforrester: Really recover from 'badtoken' error when uploading [extensions/UploadWizard] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/238334 (https://phabricator.wikimedia.org/T71691) (owner: 10MarkTraceur) [21:48:03] * James_F nods. [21:53:00] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Upload wizard fails with api-error-badtoken, cannot resubmit - https://phabricator.wikimedia.org/T112446#1639377 (10matmarex) I don't believe we have any tests that would cover this. Unit tests for this would be unpleasant to write (you'd... [21:53:57] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Upload wizard fails with api-error-badtoken, cannot resubmit - https://phabricator.wikimedia.org/T112446#1639383 (10matmarex) Also, asking again, since it's not clear from the reports: Do you experience this error immediately, and not afte... [22:00:38] marktraceur: James_F: i'm going to leave for tonight soon, i have to wake up early tomorrow. see you [22:03:01] OK, g'night [23:05:08] (03CR) 10Alex Monk: [C: 032] Really recover from 'badtoken' error when uploading [extensions/UploadWizard] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/238334 (https://phabricator.wikimedia.org/T71691) (owner: 10MarkTraceur) [23:06:26] (03Merged) 10jenkins-bot: Really recover from 'badtoken' error when uploading [extensions/UploadWizard] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/238334 (https://phabricator.wikimedia.org/T71691) (owner: 10MarkTraceur) [23:11:57] 6Multimedia, 10Gallery, 7Design: No way to access image in packed gallery with long descriptions - https://phabricator.wikimedia.org/T93393#1639705 (10Jdforrester-WMF) [23:12:46] 6Multimedia, 10Gallery, 10MediaWiki-extensions-TimedMediaHandler: No way to get to file page of audio file from a gallery - https://phabricator.wikimedia.org/T87056#1639766 (10Jdforrester-WMF) [23:25:49] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23): Upload wizard fails with api-error-badtoken, cannot resubmit - https://phabricator.wikimedia.org/T112446#1639844 (10Jdforrester-WMF) 5Open>3Resolved This //looks// like it's now working, so marking... [23:39:12] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Find my recent uploads easily - https://phabricator.wikimedia.org/T77565#1639897 (10Pcoombe) 5Open>3Resolved a:3Pcoombe The "MyUploads" gadget is enabled by default on Commons, and provides a quick link to recent uploads next to the "My contributions" lin... [23:44:42] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 7Tracking: Improve UploadWizard UX (tracking) - https://phabricator.wikimedia.org/T96911#1639912 (10Pcoombe) [23:47:29] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Upload wizard drag and drop functionality is not obvious to users - https://phabricator.wikimedia.org/T47656#1639938 (10Pcoombe) [23:49:26] 6Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading: Allow continuing the upload in stashed mode after warning - https://phabricator.wikimedia.org/T112543#1639949 (10Jdforrester-WMF) Aha, I see. [23:49:41] 6Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading: Allow continuing the partially-complete upload in stashed mode after warning - https://phabricator.wikimedia.org/T112543#1639950 (10Jdforrester-WMF) [23:50:19] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Allow continuing one or more fully-complete uploads that are in stashed mode - https://phabricator.wikimedia.org/T85561#1639951 (10Jdforrester-WMF) [23:50:26] 6Multimedia, 10MediaWiki-API, 10MediaWiki-Uploading: Allow continuing the partially-complete upload in stashed mode after warning - https://phabricator.wikimedia.org/T112543#1637770 (10Jdforrester-WMF) p:5Triage>3Low