[00:08:44] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Files that contain a pound sign in their name can't be uploaded - https://phabricator.wikimedia.org/T74752#1640001 (10Pcoombe) 5Open>3Resolved a:3Pcoombe This seems to be fixed. [06:55:56] 6Multimedia, 6Commons, 10Wikimedia-Site-Requests: Please upload large files to Wikimedia Commons - https://phabricator.wikimedia.org/T111941#1640491 (10Basel_University_Library) Nope for UBBasel_Map_1568_Kartenslg_AA_26-48.tif - it's definitely too big, sorry. So it's done. Great job! Thanks to all! [06:56:31] 6Multimedia, 6Commons, 10Wikimedia-Site-Requests: Please upload large files to Wikimedia Commons - https://phabricator.wikimedia.org/T111941#1640492 (10Basel_University_Library) 5Open>3Resolved [11:43:26] 6Multimedia, 10Wikimedia-Media-storage: Files disappear and give 404's for the full resolution - https://phabricator.wikimedia.org/T71362#1641066 (10Aklapper) >>! In T71362#731740, @Gilles wrote: > they're part of the cleanup list established for bug 69311 It's unlikely that there is a single bug responsible f... [11:56:17] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23): UploadWizard throws “Error: Unable to parse title“ when a URL parameter (categories) contains characters not allowed in page titles - https://phabricator.wikimedia.org/T112417#1641097 (10matmarex) 5Ope... [12:13:12] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard throws “Uncaught Error: Unable to parse title ” when a URL parameter (categories) contains characters not allowed in page titles - https://phabricator.wikimedia.org/T112642#1641111 (10JeanFred) 3NEW [12:14:24] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard throws “Uncaught Error: Unable to parse title ” when a URL parameter (categories) contains characters not allowed in page titles - https://phabricator.wikimedia.org/T112642#1641122 (10JeanFred) Funnily, this leaves UploadWizard in a state where cli... [12:32:05] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard throws “Uncaught Error: Unable to parse title ” when a URL parameter (categories) contains characters not allowed in page titles - https://phabricator.wikimedia.org/T112642#1641148 (10matmarex) I forgot to mention on T112417 that the fix is not yet... [12:32:46] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard throws “Uncaught Error: Unable to parse title ” when a URL parameter (categories) contains characters not allowed in page titles - https://phabricator.wikimedia.org/T112642#1641150 (10matmarex) [12:32:48] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23): UploadWizard throws “Error: Unable to parse title“ when a URL parameter (categories) contains characters not allowed in page titles - https://phabricator.wikimedia.org/T112417#1641152 (10matmarex) [12:33:03] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review, 5WMF-deploy-2015-09-15_(1.26wmf23): UploadWizard throws “Error: Unable to parse title“ when a URL parameter (categories) contains characters not allowed in page titles - https://phabricator.wikimedia.org/T112417#1641153 (10matmarex) 5Res... [12:33:50] (03PS1) 10Bartosz Dziewoński: Don't fail horribly when invalid categories are passed [extensions/UploadWizard] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/238421 (https://phabricator.wikimedia.org/T112417) [12:42:48] (03CR) 10Bartosz Dziewoński: "There's no 'oo' there, only (correctly) 'OO'." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237922 (owner: 10Bartosz Dziewoński) [12:44:06] (03PS1) 10Bartosz Dziewoński: Remove non-existent files/directories from .jshintignore [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238422 [12:44:49] (03PS1) 10Bartosz Dziewoński: Remove 'mw' as allowed global variable from .jshintrc [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238423 [12:45:56] (03PS2) 10Bartosz Dziewoński: Always use 'OO' rather than 'oo' for OOjs and OOjs UI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237922 [12:46:06] (03CR) 10jenkins-bot: [V: 04-1] Remove 'mw' as allowed global variable from .jshintrc [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238423 (owner: 10Bartosz Dziewoński) [12:46:08] (03PS3) 10Bartosz Dziewoński: Do not obfuscate class names when adding prototype methods [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237923 [12:46:09] 6Multimedia, 10MediaWiki-extensions-UploadWizard: UploadWizard throws “Uncaught Error: Unable to parse title ” when a URL parameter (categories) contains characters not allowed in page titles - https://phabricator.wikimedia.org/T112642#1641172 (10JeanFred) >>! In T112642#1641148, @matmarex wrote: > I forgot to... [12:50:13] (03PS2) 10Bartosz Dziewoński: Remove 'mw' as allowed global variable from .jshintrc [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238423 [12:51:40] (03CR) 10jenkins-bot: [V: 04-1] Remove 'mw' as allowed global variable from .jshintrc [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238423 (owner: 10Bartosz Dziewoński) [12:54:35] 6Multimedia, 10MediaWiki-File-management, 6Performance-Team: Optimize thumbs right after creation - https://phabricator.wikimedia.org/T111633#1641193 (10Gilles) a:3Gilles I'm assigning this to myself to investigate where the gains are being had. I.e. to verify that it's not just metadata we want to keep be... [12:54:51] (03PS3) 10Bartosz Dziewoński: Remove 'mw' as allowed global variable from .jshintrc [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238423 [13:06:45] (03PS3) 10Bartosz Dziewoński: Allow uploading files with the same name but different extension at once [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237741 (https://phabricator.wikimedia.org/T48741) [13:17:52] 6Multimedia, 10MediaWiki-File-management, 10MediaWiki-Tarball-Backports, 5MW-1.23-release, 5Patch-For-Review: Uppercase picture extensions like .PNG are not allowed - https://phabricator.wikimedia.org/T68667#1641300 (10Kghbln) @Tgr Thanks a ton for tackling this pretty nasty issue! @Aklapper Just to cla... [13:25:55] https://jwatt.org/blog/2015/09/14/directory-picking-and-drag-and-drop [13:26:20] (03PS4) 10Bartosz Dziewoński: Allow uploading files with the same name but different extension at once [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237741 (https://phabricator.wikimedia.org/T48741) [13:26:35] (03CR) 10Bartosz Dziewoński: "Should be better now." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237741 (https://phabricator.wikimedia.org/T48741) (owner: 10Bartosz Dziewoński) [14:08:13] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: Allow continuing one or more fully-complete uploads that are in stashed mode - https://phabricator.wikimedia.org/T85561#1641452 (10matmarex) I like this idea, but I see at least two blockers: * We don't purge the upload stash of files for which the... [14:09:56] O.O [14:10:02] You've been busy MatmaRex [14:10:51] plenty of bugs to resolve [14:12:30] (03CR) 10MarkTraceur: [C: 032] Remove non-existent files/directories from .jshintignore [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238422 (owner: 10Bartosz Dziewoński) [14:13:51] (03Merged) 10jenkins-bot: Remove non-existent files/directories from .jshintignore [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238422 (owner: 10Bartosz Dziewoński) [14:37:17] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Step 2: Longer filenames truncated - https://phabricator.wikimedia.org/T58331#1641507 (10matmarex) a:3matmarex [14:37:31] (03PS1) 10Bartosz Dziewoński: Prevent 'filename-toolong' errors during 'Upload' step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238451 [14:37:33] (03PS1) 10Bartosz Dziewoński: Allow long file names on 'Upload' step to be wrapped [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238452 (https://phabricator.wikimedia.org/T58331) [14:37:56] marktraceur: https://gerrit.wikimedia.org/r/238451 is another thing which could prevent one from uploading a file [14:42:38] (03CR) 10MarkTraceur: [C: 032] Always use 'OO' rather than 'oo' for OOjs and OOjs UI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237922 (owner: 10Bartosz Dziewoński) [14:43:00] Today is the day of "MatmaRex has been dealing with marktraceur's code style for FAR TOO LONG" [14:43:30] heh [14:43:44] (03Merged) 10jenkins-bot: Always use 'OO' rather than 'oo' for OOjs and OOjs UI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237922 (owner: 10Bartosz Dziewoński) [14:44:27] MatmaRex: What's the benefit of using "function UWControllerDetails()" instead of just "function ()"? [14:46:01] marktraceur: when you print a uw.controller.Details to the browser console, it displays "UWControllerDetails" rather than "Object" [14:46:20] Ooh, neat. [14:48:09] it doesn't matter usually, but it's an added little convenience sometimes. i didn't bother doing it everywhere, only in the files i touched anyway. VE and OOUI use this convention and i found it pretty helpful there (where you're debugging a widget and want to find out what it is) [14:50:57] Sure [14:53:52] marktraceur: i think i'll do https://phabricator.wikimedia.org/T34606#1627096 now, since that part of the UI has been bugging me for a while. not sure how it affects your dialogs work, it probably means you have one dialog less to take care of [14:54:01] speaking of which, how's that going? [14:54:13] The patch exists, I haven't tested most of theme [14:54:16] them* [14:54:23] Lots of error dialogs I'm not sure I can trigger easily [14:54:28] But they look OK. [14:54:33] (03CR) 10MarkTraceur: [C: 032] Do not obfuscate class names when adding prototype methods [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237923 (owner: 10Bartosz Dziewoński) [14:55:45] (03Merged) 10jenkins-bot: Do not obfuscate class names when adding prototype methods [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237923 (owner: 10Bartosz Dziewoński) [14:57:05] * James_F waves. [14:57:16] What's the next emergency-deploy-for-Commons patch? :-) [14:57:46] marktraceur: Also, re-ping on what you think needs doing before we can close https://phabricator.wikimedia.org/T111791 [14:58:55] James_F: prtksxna is just polishing it up for use in other places [14:58:59] James_F: hey, i put one in swat where UW would go belly-up when you provided weird URL parameters. [14:59:36] i'm convinced it is very important, but people wanted it, so there. especially since the swat looked empty. [14:59:44] i'm *not* convinced. [15:08:34] (03CR) 10MarkTraceur: [C: 032] Remove 'mw' as allowed global variable from .jshintrc [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238423 (owner: 10Bartosz Dziewoński) [15:09:47] (03Merged) 10jenkins-bot: Remove 'mw' as allowed global variable from .jshintrc [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238423 (owner: 10Bartosz Dziewoński) [15:10:50] MatmaRex: Part of me wants to tear out all the code we've ever written to try and avoid title errors in the stash step and just hash the file contents plus a timestamp and use that [15:11:33] But another part of me knows there will be problems with that, too, somehow [15:11:45] (03CR) 10MarkTraceur: [C: 032] Prevent 'filename-toolong' errors during 'Upload' step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238451 (owner: 10Bartosz Dziewoński) [15:11:47] (03CR) 10jenkins-bot: [V: 04-1] Prevent 'filename-toolong' errors during 'Upload' step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238451 (owner: 10Bartosz Dziewoński) [15:12:01] eh, i think that's fairly reliable, it was just missing this check [15:12:07] (03CR) 10MarkTraceur: [C: 032] Allow long file names on 'Upload' step to be wrapped [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238452 (https://phabricator.wikimedia.org/T58331) (owner: 10Bartosz Dziewoński) [15:12:09] (03CR) 10jenkins-bot: [V: 04-1] Prevent 'filename-toolong' errors during 'Upload' step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238451 (owner: 10Bartosz Dziewoński) [15:12:11] (03CR) 10jenkins-bot: [V: 04-1] Allow long file names on 'Upload' step to be wrapped [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238452 (https://phabricator.wikimedia.org/T58331) (owner: 10Bartosz Dziewoński) [15:12:18] ugh, rebasing [15:12:27] marktraceur: OK… [15:12:31] MatmaRex: Understood. [15:12:55] 6Multimedia, 6Commons, 10Wikimedia-Site-Requests: Please upload large files to Wikimedia Commons - https://phabricator.wikimedia.org/T111941#1641642 (10Krenair) a:5Basel_University_Library>3Krenair [15:13:26] (03PS2) 10Bartosz Dziewoński: Prevent 'filename-toolong' errors during 'Upload' step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238451 [15:13:28] (03PS2) 10Bartosz Dziewoński: Allow long file names on 'Upload' step to be wrapped [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238452 (https://phabricator.wikimedia.org/T58331) [15:14:07] marktraceur: try again? [15:15:45] Oh, my. [15:16:17] MatmaRex: Manual rebase? [15:16:19] (03CR) 10MarkTraceur: [C: 032] Prevent 'filename-toolong' errors during 'Upload' step [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238451 (owner: 10Bartosz Dziewoński) [15:16:35] yeah. [15:16:40] Righto. [15:17:41] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/UploadWizard] (wmf/1.26wmf22) - 10https://gerrit.wikimedia.org/r/238421 (https://phabricator.wikimedia.org/T112417) (owner: 10Bartosz Dziewoński) [15:20:13] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Excess whitespace around UploadWizard checkboxes - https://phabricator.wikimedia.org/T110787#1641676 (10Jdforrester-WMF) p:5Triage>3Normal [15:20:54] 6Multimedia, 10MediaWiki-Unit-tests, 10MediaWiki-Uploading, 5MW-1.26-release, and 2 others: mediawiki.api.upload.test doesn't tear down spurious