[01:18:55] 6Multimedia, 6Commons, 10MediaWiki-File-management: Failed to load resource: the server responded with a status of 400 (Bad Request) - https://phabricator.wikimedia.org/T113198#1657309 (10Tgr) That's weird. I tried to reproduce manually but couldn't: ``` tgr@terbium:~$ mwscript eval.php --wiki=commonswiki >... [01:20:20] 6Multimedia, 6Commons, 10MediaWiki-File-management: Failed to load resource: the server responded with a status of 400 (Bad Request) - https://phabricator.wikimedia.org/T113198#1657310 (10Tgr) Both images were reuploaded a few hours age and the previous version was smaller than 800px, so this is some sort of... [01:24:16] 6Multimedia, 6Commons, 10MediaWiki-File-management: Failed to load resource: the server responded with a status of 400 (Bad Request) - https://phabricator.wikimedia.org/T113198#1657311 (10Ajfweb) That's what I assumed (as the uploader). But it's strange, surely uploading larger versions is very much routine?... [01:30:17] (03CR) 10TTO: [C: 04-1] Add scrollbar to list of available transcodes (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/219886 (https://phabricator.wikimedia.org/T87129) (owner: 10Paladox) [05:48:33] 6Multimedia, 6Commons, 10MediaWiki-File-management, 7Availability, 7Performance: Failed to load resource: the server responded with a status of 400 (Bad Request) - https://phabricator.wikimedia.org/T113198#1657388 (10Nemo_bis) [06:11:38] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 3Reading-Web: Evaluate position of "Open inMedia Viewer" button on file description page - https://phabricator.wikimedia.org/T113177#1657407 (10Tgr) I don't believe it was agreed; various alternatives were discussed, and we ended up with the current desig... [09:13:39] 6Multimedia, 6Commons, 10Wikimedia-Site-Requests: Please upload large files to Wikimedia Commons - https://phabricator.wikimedia.org/T111941#1657546 (10Basel_University_Library) > btw, be advised that due to quirks in how we render tiff thumbnails, the limit on large files where we don't display thumbnails i... [11:30:01] (03PS3) 10Bartosz Dziewoński: Display duplicates inline rather than in a popup [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238642 (https://phabricator.wikimedia.org/T34606) [11:30:16] (03CR) 10Bartosz Dziewoński: "(I responded to Siebrand's comments on I9661f24323371f186976df1f5569aba002d4f34e.)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238642 (https://phabricator.wikimedia.org/T34606) (owner: 10Bartosz Dziewoński) [11:41:11] Hey! Who's the Multimedia main contact for the Gerrit Cleanup Day this Wednesday? [11:41:11] ^ gilles or marktraceur, do you know? [11:41:11] Also interested whether the Gerrit queries in https://phabricator.wikimedia.org/T88531 are helpful or not, or how to make them more useful for you. I'm happy to help. [11:45:03] 6Multimedia, 6Commons, 10MediaWiki-extensions-TimedMediaHandler: Visualize audio files on file description pages - https://phabricator.wikimedia.org/T103527#1657806 (10Qgil) Is this task a good candidate for #Possible-Tech-Projects? [11:45:32] andre__: you are aware that we are literally three people, and that gilles is technically on a different team now? :) [11:46:03] andre__: i'll be available should anyone need anything. [11:46:23] I guess the voiced people in this channel should match the current team [11:46:28] MatmaRex: Argh, true, now that I re-read https://wikimediafoundation.org/w/index.php?title=Staff_and_contractors again I realize. Sorry, should have pinged Mark instead [11:46:50] gilles: Sorry for pinging you here. Though I'm afraid I have the same question for Performance :) [11:47:18] for gerrit cleanup day, we'll be making marktraceur go through his million open changesets and abandon them all! :> [11:47:23] MatmaRex: I'm not sure how the fact that it's three people is relevant, could you elaborate? :) [11:47:24] hehe [11:47:31] andre__: we have a team meeting tonight, I'll bring it up [11:47:52] andre__: it sounds a bit funny to have a "contact person" for a three-person team. nevermind. [11:48:17] andre__: if I don't get back to you, consider me to be the contact person [11:48:21] (for performance) [11:48:51] MatmaRex, ah. Gotcha. Yeah, point taken. [11:50:31] gilles: Thank you a lot! I sent an email to performance@ and Ori on Thursday about this, but now I see that https://lists.wikimedia.org/pipermail/performance/ is empty. Is that mailing list actively used, or is there another one? [11:52:43] andre__: I've had a new private one created for the team but I think ori has yet to set it up. we don't email each other much. emailing ori was the right choice, but I'm not surprised he hasn't gotten back to you yet :) [11:53:49] gilles, I see, I see. That's helpful to know, thanks (also in the context of anyone else trying to reach out to Perf) [12:21:14] (03Abandoned) 10Bartosz Dziewoński: Add (unused) library for uploading to Commons [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/231408 (owner: 10MarkTraceur) [12:32:27] (03CR) 10Bartosz Dziewoński: [C: 04-1] "There's so much crazy event handling code there that this doesn't actually work. Try it." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/234245 (https://phabricator.wikimedia.org/T110579) (owner: 10Thiemo Mättig (WMDE)) [13:00:32] (03CR) 10Bartosz Dziewoński: "Really man, UW no longer loads with this patch. Uncaught TypeError: $(...).button is not a function. Clearly the dependency is still neces" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237689 (https://phabricator.wikimedia.org/T112117) (owner: 10MarkTraceur) [13:00:37] (03CR) 10Bartosz Dziewoński: [C: 04-1] Use OOUI dialogs instead of jquery.ui [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237689 (https://phabricator.wikimedia.org/T112117) (owner: 10MarkTraceur) [13:04:06] (03PS9) 10Bartosz Dziewoński: Use OOUI dialogs instead of jquery.ui [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237689 (https://phabricator.wikimedia.org/T112117) (owner: 10MarkTraceur) [13:04:28] (03CR) 10Bartosz Dziewoński: "PS9: Restore dependency, rebase on https://gerrit.wikimedia.org/r/#/c/238642/ ." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237689 (https://phabricator.wikimedia.org/T112117) (owner: 10MarkTraceur) [13:14:12] (03CR) 10Bartosz Dziewoński: "This seems to do way too many things at once, I'm not comfortable merging this as-is. I'll try to split it up and try to understand what's" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237689 (https://phabricator.wikimedia.org/T112117) (owner: 10MarkTraceur) [13:53:20] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Replace jquery dialogs in UploadWizard with OOUI dialogs - https://phabricator.wikimedia.org/T112117#1658009 (10matmarex) [13:53:23] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review, 7user-notice: Remove image preview dialog from UploadWizard - https://phabricator.wikimedia.org/T112907#1658010 (10matmarex) [14:09:20] (03PS4) 10Bartosz Dziewoński: Display duplicates inline rather than in a popup [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238642 (https://phabricator.wikimedia.org/T34606) [14:09:22] (03PS10) 10Bartosz Dziewoński: Use OOUI dialogs instead of jquery.ui [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237689 (https://phabricator.wikimedia.org/T112117) (owner: 10MarkTraceur) [14:09:24] (03PS3) 10Bartosz Dziewoński: Unbreak confirmation of no categories being set [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239418 (https://phabricator.wikimedia.org/T51710) [14:09:26] (03PS1) 10Bartosz Dziewoński: Remove unused mw.UploadWizardDeleteDialog class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239836 [14:09:28] (03PS1) 10Bartosz Dziewoński: Remove unused mw.UploadWizardDeedPreview class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239837 [14:09:30] (03PS1) 10Bartosz Dziewoński: Remove lightbox image preview dialogs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239838 (https://phabricator.wikimedia.org/T112907) [14:11:25] (03CR) 10jenkins-bot: [V: 04-1] Unbreak confirmation of no categories being set [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239418 (https://phabricator.wikimedia.org/T51710) (owner: 10Bartosz Dziewoński) [14:11:38] (03CR) 10jenkins-bot: [V: 04-1] Use OOUI dialogs instead of jquery.ui [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237689 (https://phabricator.wikimedia.org/T112117) (owner: 10MarkTraceur) [14:12:03] (03CR) 10jenkins-bot: [V: 04-1] Remove unused mw.UploadWizardDeleteDialog class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239836 (owner: 10Bartosz Dziewoński) [14:12:05] (03CR) 10jenkins-bot: [V: 04-1] Remove unused mw.UploadWizardDeedPreview class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239837 (owner: 10Bartosz Dziewoński) [14:12:29] fucking banana… [14:13:59] (03CR) 10jenkins-bot: [V: 04-1] Remove lightbox image preview dialogs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239838 (https://phabricator.wikimedia.org/T112907) (owner: 10Bartosz Dziewoński) [14:15:52] (03PS11) 10Bartosz Dziewoński: Use OOUI dialogs instead of jquery.ui [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237689 (https://phabricator.wikimedia.org/T112117) (owner: 10MarkTraceur) [14:15:54] (03PS2) 10Bartosz Dziewoński: Remove unused mw.UploadWizardDeedPreview class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239837 [14:15:56] (03PS2) 10Bartosz Dziewoński: Remove unused mw.UploadWizardDeleteDialog class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239836 [14:15:58] (03PS2) 10Bartosz Dziewoński: Remove lightbox image preview dialogs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239838 (https://phabricator.wikimedia.org/T112907) [14:16:00] (03PS4) 10Bartosz Dziewoński: Unbreak confirmation of no categories being set [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239418 (https://phabricator.wikimedia.org/T51710) [14:18:01] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I moved out most stuff, see dependencies." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237689 (https://phabricator.wikimedia.org/T112117) (owner: 10MarkTraceur) [14:19:59] Urgh [14:20:15] Not sure what e is [14:20:32] Not sure what I'm trying to do, ChanServ is the one running the show [14:21:27] Ooookay. [14:22:00] marktraceur: You want to add +V surely? [14:22:06] I did, in chanserv [14:22:08] marktraceur: Oh, you did, never mind. [14:22:13] * James_F nods. [14:22:18] +V in channel is not a thing, and caused poor tgr|away to get -e [14:22:21] But not me? :-P [14:22:37] I'm just not sure I trust you, James_F [14:22:44] With that immense power [14:22:50] * James_F grins. [14:23:18] andre__: I don't know about *all* of my old changesets, but I could certainly help with the cleanup day if necessary. MatmaRex looks like he's already all up in my bidness. [14:25:13] andre__: oh, while we have you here… [14:25:35] andre__: MultimediaViewer is apparently not our responsibility anymore. can you remove it from the Herald rule that adds #Multimedia? [14:25:46] James_F: right? ^ [14:26:33] MatmaRex: There's already a Phab task asking andre__ to tweak our Herald rule, yes. [14:26:57] Hélas, no progress yet. [14:27:03] Indeed. [14:28:04] * MatmaRex glares at andre__ [14:28:35] marktraceur: i rejiggered your dialogs patch. can you review and merge the parts i split out? [14:29:21] (and https://gerrit.wikimedia.org/r/#/c/238642/ too, was already +2'd but CI failed) [14:30:32] Byokay [14:31:11] (03CR) 10MarkTraceur: [C: 032] Display duplicates inline rather than in a popup [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238642 (https://phabricator.wikimedia.org/T34606) (owner: 10Bartosz Dziewoński) [14:31:30] I <3 the merge button [14:32:07] MatmaRex: Ah, clever, make my patch depend on all of yours [14:32:09] ;) [14:32:29] heh [14:32:43] (03CR) 10MarkTraceur: "JENKINS." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238642 (https://phabricator.wikimedia.org/T34606) (owner: 10Bartosz Dziewoński) [14:32:55] (03CR) 10MarkTraceur: Display duplicates inline rather than in a popup [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238642 (https://phabricator.wikimedia.org/T34606) (owner: 10Bartosz Dziewoński) [14:33:00] (03CR) 10MarkTraceur: [C: 032] Display duplicates inline rather than in a popup [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238642 (https://phabricator.wikimedia.org/T34606) (owner: 10Bartosz Dziewoński) [14:33:15] (03Merged) 10jenkins-bot: Display duplicates inline rather than in a popup [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/238642 (https://phabricator.wikimedia.org/T34606) (owner: 10Bartosz Dziewoński) [14:33:20] Oh, herp [14:33:24] * marktraceur finds moar caffeine [14:34:01] (03CR) 10MarkTraceur: [C: 032] "Wow, this is a great idea" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239837 (owner: 10Bartosz Dziewoński) [14:36:57] (03CR) 10MarkTraceur: [C: 032] Remove lightbox image preview dialogs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239838 (https://phabricator.wikimedia.org/T112907) (owner: 10Bartosz Dziewoński) [14:38:30] MatmaRex: yw [14:39:10] marktraceur: missed one. [14:39:12] https://gerrit.wikimedia.org/r/239836 [14:39:34] Weird [14:40:05] Wait, we had a class that RETURNED SOMETHING? [14:40:14] I hate this project so goddamn much [14:40:47] (03CR) 10MarkTraceur: [C: 032] Remove unused mw.UploadWizardDeleteDialog class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239836 (owner: 10Bartosz Dziewoński) [14:42:03] MatmaRex: So here's the really fun question: Why were there several different messages in UploadWizard that said simply "OK" and whose qqq was basically always "{{Identical|OK}}" [14:42:49] marktraceur: perhaps somebody really took https://www.mediawiki.org/wiki/Localisation#Avoid_message_reuse to heart [14:42:59] (03Merged) 10jenkins-bot: Remove unused mw.UploadWizardDeleteDialog class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239836 (owner: 10Bartosz Dziewoński) [14:43:02] (03Merged) 10jenkins-bot: Remove unused mw.UploadWizardDeedPreview class [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239837 (owner: 10Bartosz Dziewoński) [14:43:04] (03Merged) 10jenkins-bot: Remove lightbox image preview dialogs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239838 (https://phabricator.wikimedia.org/T112907) (owner: 10Bartosz Dziewoński) [14:43:18] I guess so, geez [14:43:48] Oh, sigh. [14:43:50] prtksxna, marktraceur: Ed and I were chatting about making some changes to the upload dialog in core to make it easier to integrate into VE. [14:44:07] I wonder if we broke that concept in UW, are those messages different in different languages? [14:44:19] Quoting Ed, "breaking up the dialog into panels that can be pulled in". Sound OK? [14:44:27] James_F: Hm, sure I guess [14:45:01] Here's where I say "like UploadWizard's steps!!!" but never mind [14:45:08] * James_F grins. [14:45:10] That dream is on hold [14:45:11] A bit. [14:46:21] marktraceur: meh, for a generic "OK" in a dialog, reusing is probably okay. [14:46:45] MatmaRex: Funny, that's exactly the case your link uses as a bad thing [14:47:33] mmmmmeh. [14:47:47] this is more like "Dismiss". mixing up "OK" and "Yes" is probably not okay. [14:48:17] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Replace jquery dialogs in UploadWizard with OOUI dialogs - https://phabricator.wikimedia.org/T112117#1658149 (10Jdforrester-WMF) [14:48:19] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 7user-notice: Remove image preview dialog from UploadWizard - https://phabricator.wikimedia.org/T112907#1658146 (10Jdforrester-WMF) 5Open>3Resolved a:3matmarex [14:49:01] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 7user-notice: Remove image preview dialog from UploadWizard - https://phabricator.wikimedia.org/T112907#1658150 (10matmarex) a:5matmarex>3MarkTraceur [14:49:22] i18n/et.json: "mwe-upwiz-too-many-files-ok": "Sobib", [14:49:22] i18n/et.json: "mwe-upwiz-file-too-large-ok": "Selge", [14:49:27] First one I found [14:50:09] Honestly might just be an instance of two different translators having different styles, seems to be the case elsewhere [14:50:47] Anyway, most of the messages don't seem to have different documentation, so [14:51:36] BRB, need to fetch a package from the office. [14:53:05] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Replace jquery dialogs in UploadWizard with OOUI dialogs - https://phabricator.wikimedia.org/T112117#1658166 (10matmarex) [14:53:08] 6Multimedia, 10MediaWiki-extensions-UploadWizard: duplicate link: is not HTML-linked to file page, not red and points to the wrong URL - https://phabricator.wikimedia.org/T34606#1658162 (10matmarex) 5Open>3Resolved [15:07:31] 6Multimedia, 10MediaWiki-extensions-UploadWizard: Problem with upload wizard on Commons - https://phabricator.wikimedia.org/T113233#1658185 (10Atsirlin) 3NEW [15:11:30] (03PS12) 10Bartosz Dziewoński: Use OOUI dialogs instead of jquery.ui [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237689 (https://phabricator.wikimedia.org/T112117) (owner: 10MarkTraceur) [15:11:32] (03PS1) 10Bartosz Dziewoński: Remove some dead code related to jQuery UI buttons [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239852 [15:12:07] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Actually, we can remove the jquery.ui.dialog dependency after doing https://gerrit.wikimedia.org/r/#/c/239852/1 first. Previous comments s" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237689 (https://phabricator.wikimedia.org/T112117) (owner: 10MarkTraceur) [15:15:39] MatmaRex: https://github.com/search?q=mwe-upwiz-buttons+%40wikimedia&type=Code&utf8=%E2%9C%93 suggests other things to fix. [15:17:25] James_F: no, the wrapper div still exists. [15:17:44] and yeah, it's horrible, but that part's not broken. [15:19:48] James_F: Yep, that makes sense, I wanted all the render functions to return panels instead of forms at some point anyway. [15:20:15] marktraceur MatmaRex: How are we supposed to handle link in i18n messages? [15:20:37] prtksxna: Cool. Ed says his code will be here in a few hours/tomorrow. :-) [15:20:47] MatmaRex: Eww. [15:20:54] \o/ [15:21:18] James_F: I'll change mw.Upload.Dialog first, and then mw.ForeignStructuredUpload.Dialog [15:21:23] prtksxna: mw.message() can handle some basic wikitext, like [[foo|bar]], [[http://foo bar]] [15:21:29] prtksxna: Or Ed can do it and you can merge? [15:21:36] [[foo|bar]], [http://foo bar]* [15:21:41] James_F: Oh, sure! [15:21:53] James_F: But FSUD is still pending review and some work too [15:21:58] so just use that? or i'm misunderstanding you. [15:22:06] MatmaRex: Cool, that's what I needed. Thanks! [15:22:50] prtksxna: you'll need to add a dependency on mediawiki.jqueryMsg, and then use mw.message(…).parse() (which returns a jQuery object). it should just work, apart from that. [15:23:16] MatmaRex: Thanks [15:23:46] James_F marktraceur: Want to take a look at https://gerrit.wikimedia.org/r/#/c/235431/ and confirm that this what we had discussed/wanted to implement? [15:28:53] prtksxna: Yeah. [15:29:09] prtksxna: Will look later tonight, hopefully. [15:29:16] James_F: (y) [15:31:51] James_F: No meeting today? [15:31:57] Oh, sorry. [15:32:16] Calendar didn't remind me. [15:32:26] * marktraceur fails too [15:32:56] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: VisualEditor: Button to initiate UploadWizard and insert image on completion - https://phabricator.wikimedia.org/T40030#1658236 (10Jdforrester-WMF) a:3Esanders [15:33:15] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: Button in VisualEditor to initiate Commons file uploading, and insert image on completion - https://phabricator.wikimedia.org/T40030#1658238 (10Jdforrester-WMF) [15:34:53] o/ [15:35:01] * James_F waves at Krinkle IRL. [15:39:09] Gosh that was the worst standup I've ever heard [15:39:18] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, 3Reading-Web-Sprint-56-Four Lions: Safari 8: Mediaviewer failing in mobile when file names include special characters - https://phabricator.wikimedia.org/T111609#1658259 (10Jdforrester-WMF) Mass-removing the Multimedia tag from MediaVi... [15:39:20] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 3Reading-Web: Evaluate position of "Open inMedia Viewer" button on file description page - https://phabricator.wikimedia.org/T113177#1658257 (10Jdforrester-WMF) Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the... [15:39:23] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Convert MultimediaViewer to use OOjs UI instead of MW UI buttons and icons - https://phabricator.wikimedia.org/T111159#1658261 (10Jdforrester-WMF) Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading departm... [15:39:26] OH GOD [15:39:31] WHAT? [15:39:32] Whew. [15:39:38] wikibugs was being loud [15:39:48] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: MediaViewer crops bottom of images - https://phabricator.wikimedia.org/T89631#1658292 (10Jdforrester-WMF) Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department, not Editing's Multimedia team. [15:39:51] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 6Mobile-Apps, 7Parsoid-DOM: Add a data- attribute with the file's title to [[File: elements - https://phabricator.wikimedia.org/T88825#1658296 (10Jdforrester-WMF) Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by... [15:39:54] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Inform MediaViewer user where to find the image if it is not on the page - https://phabricator.wikimedia.org/T87813#1658300 (10Jdforrester-WMF) Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department... [15:39:57] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 5Patch-For-Review: Convert MultimediaViewer to use extension registration - https://phabricator.wikimedia.org/T87943#1658298 (10Jdforrester-WMF) Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading departm... [15:40:00] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Test if opening animation of MMV panel increases panel opens significantly; if not, remove it - https://phabricator.wikimedia.org/T87639#1658302 (10Jdforrester-WMF) Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by t... [15:40:09] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Show progress bar when loading the lightbox image - https://phabricator.wikimedia.org/T86288#1658312 (10Jdforrester-WMF) Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department, not Editing's Multime... [15:40:11] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Parallel loading of image and scripts in MediaViewer - https://phabricator.wikimedia.org/T86109#1658317 (10Jdforrester-WMF) Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department, not Editing's Mult... [15:40:14] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Clicking Back in browser shows incorrect page rendering - https://phabricator.wikimedia.org/T86207#1658314 (10Jdforrester-WMF) Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department, not Editing's M... [15:40:25] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 5MW-1.23-release: Backport MediaViewer to MediaWiki 1.23 LTS - https://phabricator.wikimedia.org/T85193#1658333 (10Jdforrester-WMF) Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department, not Edit... [15:41:21] hi wikibugs. [15:41:22] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Attribution prompt improvement - https://phabricator.wikimedia.org/T77720#1658416 (10Jdforrester-WMF) Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department, not Editing's Multimedia team. [15:41:23] bye wikibugs. [15:45:02] 6Multimedia, 10MediaWiki-extensions-GWToolset, 10MediaWiki-extensions-MultimediaViewer, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Include templates into multimedia role - https://phabricator.wikimedia.org/T596#1658850 (10Jdforrester-WMF) Mass-removing the Multimedia tag from MediaViewer tas... [15:45:04] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Inline slideshows - https://phabricator.wikimedia.org/T7383#1658849 (10Jdforrester-WMF) Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading department, not Editing's Multimedia team. [15:45:07] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 7Easy, 7Technical-Debt: Use DOM append instead of z-index to position lightbox - https://phabricator.wikimedia.org/T58403#1658846 (10Jdforrester-WMF) Mass-removing the Multimedia tag from MediaViewer tasks, as this is now being worked on by the Reading... [15:54:46] 6Multimedia, 10MediaWiki-extensions-GWToolset, 10MediaWiki-extensions-MultimediaViewer, 10MediaWiki-extensions-UploadWizard, 5Patch-For-Review: Include templates into multimedia role - https://phabricator.wikimedia.org/T596#1659185 (10Jdforrester-WMF) [15:55:51] Holy gods the cleanup [15:58:51] 6Multimedia: Figure out legal text to be put in the mw.ForeignStructuredUpload.Dialog.js - https://phabricator.wikimedia.org/T111910#1659196 (10Prtksxna) After speaking with @slaporte, I have changed the first step to be: {F2623979} {F2623981} I still need to know what the exact language is going to be. [16:11:53] (03CR) 10MarkTraceur: [C: 032] Remove some dead code related to jQuery UI buttons [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239852 (owner: 10Bartosz Dziewoński) [16:13:14] MatmaRex: "Previous comments" I don't see any previous comments on the dialog patch that aren't addressed [16:14:38] marktraceur: my own ones on PS11 [16:15:43] (03Merged) 10jenkins-bot: Remove some dead code related to jQuery UI buttons [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239852 (owner: 10Bartosz Dziewoński) [16:17:21] Oh. [16:17:28] (brb, dinner) [16:20:34] MatmaRex: When you get back...I didn't see an obvious way to add a "close" button to a dialog, but maybe I'm blind, your input would be appreciated [16:21:57] The hanging on validation seems to be a $.validate error because the inputs don't have names...interesting [16:31:37] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 10MediaWiki-extensions-UploadWizard: UploadWizard Title blacklist error reports reported on wrong page - https://phabricator.wikimedia.org/T113040#1659749 (10Jdforrester-WMF) Yeah, very odd, https://github.com/wikimedia/operations-mediawiki-config/blob/f4f8cbcd... [16:33:06] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: One/some(?) users reporting a problem initialising UploadWizard on Commons - https://phabricator.wikimedia.org/T113233#1659754 (10Jdforrester-WMF) [16:33:11] 6Multimedia, 6Commons, 10MediaWiki-extensions-UploadWizard: One/some(?) users reporting a problem initialising UploadWizard on Commons - https://phabricator.wikimedia.org/T113233#1659759 (10Jdforrester-WMF) Still happening? [16:35:08] Most of the wikibugs-badgering is now done. [16:35:37] marktraceur: Is it a process dialog? If so, just have a 'cancel' action? [16:37:23] James_F: It's just a normal dialog subclass [16:37:31] Hmm. [16:37:36] * James_F summons Ed. [16:37:43] 6Multimedia, 10Beta-Cluster, 10MediaWiki-File-management: Low-quality images are not rendered in beta - https://phabricator.wikimedia.org/T71757#1659794 (10Yurik) @hashar, tell you the truth, I don't know myself how new code is deployed to betacluster, especially entry points - its all pretty scary to me too ) [16:38:19] James_F: ProcessDialog looked like it would be overkill for a preview of a wikitext rendering [16:38:30] Why not just make it a mini-VE surface? [16:38:31] Oh, sure. [16:38:46] A mini-VE might be nice. [16:38:53] Sure, but not right now [16:38:58] You'd probably want to wait for Roan's switcher code to land in MW. [16:39:01] Surely it's more complicated than that [16:39:02] Yeah. [16:39:14] Right now it's embedded in Flow. [16:41:40] 6Multimedia, 10Beta-Cluster, 10MediaWiki-File-management: Low-quality images are not rendered in beta - https://phabricator.wikimedia.org/T71757#1659818 (10greg) >>! In T71757#1659794, @Yurik wrote: > @hashar, tell you the truth, I don't know myself how new code is deployed to betacluster, especially entry p... [16:41:45] marktraceur: [16:41:47] closeButton = new OO.ui.ButtonWidget( { [16:41:47] label: OO.ui.msg( 'ooui-dialog-process-dismiss' ) [16:41:47] } ); [16:41:47] closeButton.on( 'click', function () { [16:41:48] dialog.close(); [16:41:49] } ); [16:42:01] this snippet is from the OOUI demo. just like this should work. [16:42:30] marktraceur: the $.validate warnings have been there before, i tried to kill them by disabling debug mode, which, as you remember, broke form submission [16:43:40] -.- [16:43:55] 6Multimedia, 10Beta-Cluster, 10MediaWiki-File-management: Low-quality images are not rendered in beta - https://phabricator.wikimedia.org/T71757#1659827 (10greg) >>! In T71757#1659794, @Yurik wrote: > @hashar, tell you the truth, I don't know myself how new code is deployed to betacluster, especially entry p... [16:45:37] they're just noise, not an actual problem [16:46:59] 6Multimedia, 10Beta-Cluster, 10MediaWiki-File-management: Low-quality images are not rendered in beta - https://phabricator.wikimedia.org/T71757#1659844 (10Yurik) @greg, this is awesome list of links! (is it posted on wikitech somewhere?). When scap and config updates run, do they include the entry points... [16:47:40] MatmaRex: OK, so something else is wrong, which is always good. [16:47:52] I did return a different promise in one of the validate methods, maybe that's the issue [16:50:02] 6Multimedia, 10Beta-Cluster, 10MediaWiki-File-management: Low-quality images are not rendered in beta - https://phabricator.wikimedia.org/T71757#1659875 (10greg) >>! In T71757#1659844, @Yurik wrote: > @greg, this is awesome list of links! (is it posted on wikitech somewhere?). When scap and config updates... [17:57:31] (03PS1) 10Bartosz Dziewoński: Consistently use NS_CATEGORY / NS_FILE for namespace numbers [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239893 [18:08:11] MatmaRex: fixed that Herald rule already a few days ago and now James batch-edited related tasks [18:08:31] i've seen, thanks [18:11:50] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 10MediaWiki-extensions-UploadWizard: UploadWizard Title blacklist error reports reported on wrong page - https://phabricator.wikimedia.org/T113040#1660242 (10matmarex) a:3matmarex We're passing the title wrong… [18:14:57] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 10MediaWiki-extensions-UploadWizard: UploadWizard Title blacklist error reports reported on wrong page - https://phabricator.wikimedia.org/T113040#1660253 (10matmarex) (And so it's using the default title of "Feedback", which on Commons redirects to "Commons ta... [18:20:46] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 10MediaWiki-extensions-UploadWizard: UploadWizard Title blacklist error reports reported on wrong page - https://phabricator.wikimedia.org/T113040#1660281 (10matmarex) This was broken back in 2011 by r106003 (rSVN106003), which changed the parameters of mw.Feed... [18:28:45] (03PS1) 10Bartosz Dziewoński: Actually pass the blacklist page title and header text to mw.Feedback [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239896 (https://phabricator.wikimedia.org/T113040) [18:32:55] 6Multimedia, 10Beta-Cluster, 10MediaWiki-File-management: Low-quality images are not rendered in beta - https://phabricator.wikimedia.org/T71757#1660335 (10Tgr) Thumbnail entry points are not deployed, they are just there. See the blocked task. [18:33:26] marktraceur: how are the dialogs brewing? [18:35:13] MatmaRex: Pretty well, should have something for review in a bit [18:44:42] MatmaRex: I guess your snippet isn't working so far [18:45:44] hmm. [18:46:27] I think because I put it in a weird place. [18:46:43] Yeah, there we go [18:50:14] MatmaRex: I did something maybe overly clever by returning windowManager.openWindow( confirmationDialog, { ... } ).then( ... ) [18:50:25] I think that must be why the validation is borked [18:58:29] Never mind, it was not sufficiently clever [19:00:22] (03PS13) 10MarkTraceur: Use OOUI dialogs instead of jquery.ui [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237689 (https://phabricator.wikimedia.org/T112117) [19:05:28] (03CR) 10Alex Monk: [C: 032] Actually pass the blacklist page title and header text to mw.Feedback [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239896 (https://phabricator.wikimedia.org/T113040) (owner: 10Bartosz Dziewoński) [19:05:31] MatmaRex: There you go [19:06:18] Should fix all but the sole windowManager issue which I'm not sure about...would have to either finish my big refactor efforts or undo them all to fix that, I think [19:08:35] marktraceur: looking [19:09:06] marktraceur: the WindowManager thing is more of a good-to-have… i think you're supposed to use only one WindowManager to open/close all of your Windows (Dialogs) [19:09:22] but, this works too. [19:09:25] Right [19:09:36] Most of them will only ever happen once per step anyway, there are other things managing that [19:10:00] yeah, let's just not accidentally allow the user to do something while dialogs are open [19:10:05] we have this problem with tipsies in UW [19:10:26] i keep finding new way for a tipsy to stay open when the content it's for has disappeared [19:12:03] Ugh. [19:15:08] LicensePreview, at least, gets closed when you click outside of it, so that won't be an issue [19:15:41] ErrorDialog is modal, you have to close it before moving on [19:16:27] marktraceur: thanks, that looks pretty, i'll give it some whacks and merge today. brb [19:16:28] (03Merged) 10jenkins-bot: Actually pass the blacklist page title and header text to mw.Feedback [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239896 (https://phabricator.wikimedia.org/T113040) (owner: 10Bartosz Dziewoński) [19:16:39] Hooray [23:14:38] (03PS5) 10Bartosz Dziewoński: Unbreak confirmation of no categories being set [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239418 (https://phabricator.wikimedia.org/T51710) [23:17:28] (03CR) 10Bartosz Dziewoński: [C: 032] Use OOUI dialogs instead of jquery.ui [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237689 (https://phabricator.wikimedia.org/T112117) (owner: 10MarkTraceur) [23:18:00] (03CR) 10Bartosz Dziewoński: [C: 04-2] "Not to be merged until next wmf branch." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239418 (https://phabricator.wikimedia.org/T51710) (owner: 10Bartosz Dziewoński) [23:18:40] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 7Epic: Migrate UploadWizard UI elements to OOjs UI - https://phabricator.wikimedia.org/T96914#1661535 (10matmarex) [23:18:42] 6Multimedia, 10MediaWiki-extensions-UploadWizard, 7user-notice: Replace jquery dialogs in UploadWizard with OOUI dialogs - https://phabricator.wikimedia.org/T112117#1661532 (10matmarex) 5Open>3Resolved [23:26:12] (03Merged) 10jenkins-bot: Use OOUI dialogs instead of jquery.ui [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/237689 (https://phabricator.wikimedia.org/T112117) (owner: 10MarkTraceur) [23:31:12] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 10MediaWiki-extensions-UploadWizard, and 2 others: UploadWizard Title blacklist error reports reported on wrong page - https://phabricator.wikimedia.org/T113040#1661579 (10matmarex) 5Open>3Resolved The change will be deployed to Commons this Wednesday, acco...