[03:27:34] 6Multimedia, 6Commons, 6Editing-Department, 10Possible-Tech-Projects, and 2 others: Allow uploading of 3D files to Wikimedia Commons - https://phabricator.wikimedia.org/T3790#1679862 (10TasneemLo) @MarkTraceur , @JeanFred are either of you still open to being a mentor for this for Outreachy-Round-11 ? [06:04:15] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10Reading-Web, 7Performance: Reduce amount of metadata embedded in thumbnails across site - https://phabricator.wikimedia.org/T100546#1679927 (10Nemo_bis) [07:25:45] (03CR) 10Siebrand: [C: 032] "i18n/L10n reviewed." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/241524 (https://phabricator.wikimedia.org/T113631) (owner: 10Paladox) [07:26:20] (03Merged) 10jenkins-bot: Change message timedmedia-desc to timedmediahandler-desc [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/241524 (https://phabricator.wikimedia.org/T113631) (owner: 10Paladox) [09:13:43] 6Multimedia, 6Commons, 6Editing-Department, 10Possible-Tech-Projects, and 2 others: Allow uploading of 3D files to Wikimedia Commons - https://phabricator.wikimedia.org/T3790#1680107 (10Aklapper) Reaching out via [[ https://www.mediawiki.org/wiki/Communication | IRC ]] or private email recommended in case... [10:12:41] 6Multimedia, 6Commons, 10UploadWizard: 587 MB file to upload, chunked upload failed at assembling state - https://phabricator.wikimedia.org/T112698#1680262 (10Aklapper) >>! In T112698#1649875, @Inaki-LL wrote: > Filename is AsironLaburpena.ogv if that helps. @Matmarex: Did that help somehow to look up logs? [10:18:00] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Per Nemo bis." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/232925 (owner: 10Haritha28) [12:12:11] (03PS9) 10Bartosz Dziewoński: Unbreak confirmation of no categories being set [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239418 (https://phabricator.wikimedia.org/T51710) [12:23:19] (03PS2) 10Bartosz Dziewoński: Remove TODO comment that offers bad advice [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240891 [12:23:25] (03PS2) 10Bartosz Dziewoński: Correct config documentation mentioning non-existent option [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240890 [13:41:55] Morning [13:43:31] morning marktraceur [13:47:37] prtksxna, edsanders|away how are we lookin' [13:50:50] marktraceur: prtksxna emailed that he's not around today [13:51:12] Oh. [13:52:37] I assume he's waiting for answers from edsanders? [13:52:58] yeah, on https://gerrit.wikimedia.org/r/#/c/235431/36 [13:53:23] OK. [13:53:26] marktraceur: we should merge https://gerrit.wikimedia.org/r/#/c/239418/ today, probably [13:56:43] "probably" I like the enthusiasm :P [13:57:37] heh [13:57:46] Oh, necessaryFilled is only for categories [13:57:48] TIL [13:58:09] marktraceur: in fact, i think all of my pending changes to UW are ready to be merged, except for the CategorySelector one (which waits until after branch cut) [13:58:13] (03CR) 10MarkTraceur: [C: 032] "Thanks for fixing." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239418 (https://phabricator.wikimedia.org/T51710) (owner: 10Bartosz Dziewoński) [13:59:21] Fun. [13:59:32] (03Merged) 10jenkins-bot: Unbreak confirmation of no categories being set [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/239418 (https://phabricator.wikimedia.org/T51710) (owner: 10Bartosz Dziewoński) [13:59:45] marktraceur: i have some core MW work to do, a bunch of things have accumulated, so i'll probably spend today on that [13:59:50] MatmaRex: I have your "status:open" query in my frequently visited browser history for just such an occasion [13:59:56] :> [14:00:19] I'll merge all your stuff then troll for something that needs doing [14:00:32] I guess the feedback link thing didn't get merged yet [14:01:55] oh, hmm. yeah, i could probably do that today if you want? [14:02:19] marktraceur: also, people are pinging you in #-dev :) [14:19:11] MatmaRex: That'd be great [14:23:39] what's the question? [14:24:00] (03CR) 10MarkTraceur: [C: 032] "WOW." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240891 (owner: 10Bartosz Dziewoński) [14:24:47] (03CR) 10MarkTraceur: [C: 032] Correct config documentation mentioning non-existent option [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240890 (owner: 10Bartosz Dziewoński) [14:24:53] edsanders: about your comments on https://gerrit.wikimedia.org/r/#/c/235431/36 [14:25:09] (03Merged) 10jenkins-bot: Remove TODO comment that offers bad advice [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240891 (owner: 10Bartosz Dziewoński) [14:25:23] (03PS3) 10MarkTraceur: Replace jquery.mwCoolCats with mediawiki.widgets.CategorySelector [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240586 (https://phabricator.wikimedia.org/T112764) (owner: 10Bartosz Dziewoński) [14:25:43] edsanders: I think prtksxna said he was waiting on something for that patch [14:26:03] (03Merged) 10jenkins-bot: Correct config documentation mentioning non-existent option [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240890 (owner: 10Bartosz Dziewoński) [14:28:59] there's one unaddressed and one which is blocked on some product discussion, about what we tell the user to do when they have something which isn't for commons [14:30:07] So it's James_F|Away's fault [14:30:36] yeah - I guess it's ok for now though [14:34:27] 6Multimedia, 6Commons, 6Editing-Department, 10Possible-Tech-Projects, and 2 others: Allow uploading of 3D files to Wikimedia Commons - https://phabricator.wikimedia.org/T3790#1680964 (10MarkTraceur) I'm tentatively telling @TasneemLo that our priorities are in the following order: * Panoramic images (almo... [14:34:43] James_F|Away: https://phabricator.wikimedia.org/T3790 also could use your comment, I'm prioritizing priorities without you [14:39:07] 6Multimedia, 6Commons, 10UploadWizard, 7user-notice: Make categories more required-looking - https://phabricator.wikimedia.org/T51710#1680975 (10matmarex) 5Open>3Resolved [14:39:35] 6Multimedia, 6Commons, 10UploadWizard, 7user-notice: Make categories more required-looking - https://phabricator.wikimedia.org/T51710#567616 (10matmarex) This change will be deployed to Commons this Wednesday. [14:45:36] (03CR) 10Siebrand: "i18n/L10n reviewed." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240586 (https://phabricator.wikimedia.org/T112764) (owner: 10Bartosz Dziewoński) [14:49:09] 6Multimedia, 6Commons, 6Editing-Department, 10Possible-Tech-Projects, and 2 others: Allow uploading of 3D files to Wikimedia Commons - https://phabricator.wikimedia.org/T3790#1681015 (10Moushira) @MarkTraceur: By 3D printing schematics, we mean STLs? [15:02:10] (03CR) 10MarkTraceur: [C: 031] "Will merge after branch cut." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240586 (https://phabricator.wikimedia.org/T112764) (owner: 10Bartosz Dziewoński) [15:17:32] 6Multimedia, 10UploadWizard: Unescaped messages on Special:UploadWizard - https://phabricator.wikimedia.org/T113669#1681074 (10matmarex) > ``` > Unescaped message mwe-upwiz-file-all-failed > Unescaped message mwe-upwiz-file-some-failed > ``` These are no longer used there since 8410bced3451905fad051602e69f230... [15:17:48] (03PS1) 10Bartosz Dziewoński: SpecialUploadWizard: Escape messages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/241664 (https://phabricator.wikimedia.org/T113669) [15:19:46] Good morning, James_F [15:21:59] * James_F waves. [15:31:33] edsanders: could you review https://gerrit.wikimedia.org/r/238998 , too? i think it's also a prereq to the upload dialog [15:31:57] (i'll be reviewing your design changes later today) [15:35:28] (03CR) 10Bartosz Dziewoński: [C: 04-1] Add feedbackLink config param for bugs (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240105 (https://phabricator.wikimedia.org/T112666) (owner: 10MarkTraceur) [15:35:35] ... [15:35:46] I see how it is [15:36:30] marktraceur: looks good apart from that [15:36:33] (03CR) 10MarkTraceur: [C: 031] "I'm happy with this (though I don't know why it depends on anything)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240892 (owner: 10Bartosz Dziewoński) [15:36:39] (03PS2) 10MarkTraceur: Set a name attribute for the date input field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240892 (owner: 10Bartosz Dziewoński) [15:37:27] (03CR) 10Bartosz Dziewoński: "The dependency should probably be the other way, but whatever." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240892 (owner: 10Bartosz Dziewoński) [15:37:33] (03PS3) 10Bartosz Dziewoński: Set a name attribute for the date input field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240892 [15:37:56] marktraceur: if you're merging https://gerrit.wikimedia.org/r/#/c/240892/ , do test it a bit, i don't think i tried it without the CategorySelector patch [15:38:13] marktraceur: i left one comment on https://gerrit.wikimedia.org/r/#/c/240105/ , looks good ot me apart from that [15:38:30] (03CR) 10MarkTraceur: Add feedbackLink config param for bugs (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240105 (https://phabricator.wikimedia.org/T112666) (owner: 10MarkTraceur) [15:38:38] (03PS2) 10MarkTraceur: Add feedbackLink config param for bugs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240105 (https://phabricator.wikimedia.org/T112666) [15:39:19] MatmaRex: Checking, fixed your comment [15:40:16] (03CR) 10Bartosz Dziewoński: [C: 032] Add feedbackLink config param for bugs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240105 (https://phabricator.wikimedia.org/T112666) (owner: 10MarkTraceur) [15:41:22] 6Multimedia, 6Commons, 10UploadWizard, 7Easy: Disable the feedback tool from UploadWizard, replace it with a Phabricator link - https://phabricator.wikimedia.org/T112666#1681185 (10matmarex) 5Open>3Resolved [15:41:33] 6Multimedia, 6Commons, 10UploadWizard, 7Easy: Disable the feedback tool from UploadWizard, replace it with a Phabricator link - https://phabricator.wikimedia.org/T112666#1641857 (10matmarex) This change will be deployed to Commons this Wednesday. [15:49:35] MatmaRex: I still see a bunch of $.validate "no name" errors in the console [15:49:49] marktraceur: yeah, ignore them [15:50:00] MatmaRex: I mean, I thought that was the purpose of the patch, to fix those [15:50:02] you're probably getting one for each OOUI checkbox [15:50:08] Yup [15:50:16] But also for the date input. [15:51:32] marktraceur: date input has two elements: one is which contains the actual value, which will have the 'name', and which is used for validation; and one inside internal TextInputWidgets which has no 'name' and is the text input you actually see [15:51:56] Yes, and the latter is causing validate warnings, but we don't care about those? [15:52:02] it's weird but it wouldn't be a problem if jquery.validate didn't have strong opinions [15:52:05] Because we're going to turn off debug anyway [15:52:10] yep, afaics, it is not causing any real issues [15:52:11] * marktraceur puts that in "next" [15:52:33] 6Multimedia: Stop form from submitting and turn validate debug mode off - https://phabricator.wikimedia.org/T113968#1681300 (10MarkTraceur) 3NEW [16:01:10] (03Merged) 10jenkins-bot: Add feedbackLink config param for bugs [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240105 (https://phabricator.wikimedia.org/T112666) (owner: 10MarkTraceur) [16:02:01] \o/ [16:02:43] (03CR) 10MarkTraceur: [C: 032] Set a name attribute for the date input field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240892 (owner: 10Bartosz Dziewoński) [16:04:00] (03PS5) 10MarkTraceur: [WIP] change text fields to be OOUI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/212842 (https://phabricator.wikimedia.org/T113371) [16:04:02] (03CR) 10jenkins-bot: [V: 04-1] [WIP] change text fields to be OOUI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/212842 (https://phabricator.wikimedia.org/T113371) (owner: 10MarkTraceur) [16:04:21] This will be fun. [16:04:24] (03Merged) 10jenkins-bot: Set a name attribute for the date input field [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240892 (owner: 10Bartosz Dziewoński) [16:10:14] (off to dinner) [16:11:08] Cheers [16:12:03] (03PS6) 10MarkTraceur: [WIP] change text fields to be OOUI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/212842 (https://phabricator.wikimedia.org/T113371) [16:12:14] Seems to "work" now, got a few tweaks to make [16:12:21] Inline text fields and all that. [16:13:30] (03CR) 10jenkins-bot: [V: 04-1] [WIP] change text fields to be OOUI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/212842 (https://phabricator.wikimedia.org/T113371) (owner: 10MarkTraceur) [16:17:49] 6Multimedia, 6Commons, 6Editing-Department, 10Possible-Tech-Projects, and 2 others: Allow uploading of 3D files to Wikimedia Commons - https://phabricator.wikimedia.org/T3790#1681411 (10Aklapper) What is an "STL"? Links are generally welcome. [16:21:49] 6Multimedia, 6Commons, 6Editing-Department, 10Possible-Tech-Projects, and 2 others: Allow uploading of 3D files to Wikimedia Commons - https://phabricator.wikimedia.org/T3790#1681428 (10Qgil) https://en.wikipedia.org/wiki/STL_(file_format) [16:45:38] Ugh, the title destination check is broken...of course... [16:58:35] OK, that part works again...sorta [16:59:11] (03PS7) 10MarkTraceur: [WIP] change text fields to be OOUI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/212842 (https://phabricator.wikimedia.org/T113371) [16:59:26] MatmaRex: How would you make an OO.ui.TextInputWidget inline so it could be included in a sentence? [16:59:37] Or is that way too stupid to even imagine [17:00:06] marktraceur: give its .$element 'display: inline-block' in CSS [17:00:17] (03CR) 10jenkins-bot: [V: 04-1] [WIP] change text fields to be OOUI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/212842 (https://phabricator.wikimedia.org/T113371) (owner: 10MarkTraceur) [17:00:19] or better don't, that usually makes for shitty localisation experience [17:00:33] Yeah. [17:00:43] I think it's time to Just Bloody Fix It for UploadWizard [17:00:47] Because that is a nasty field. [17:00:50] I'll do that in a follow-up [17:01:16] (03PS8) 10MarkTraceur: Change text fields to be OOUI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/212842 (https://phabricator.wikimedia.org/T113371) [17:02:15] 6Multimedia, 10UploadWizard: Take out inline author field from license release message(s) - https://phabricator.wikimedia.org/T113977#1681649 (10MarkTraceur) 3NEW a:3MarkTraceur [17:02:41] (03CR) 10jenkins-bot: [V: 04-1] Change text fields to be OOUI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/212842 (https://phabricator.wikimedia.org/T113371) (owner: 10MarkTraceur) [17:05:24] What the fuck [17:05:49] I'll just...I'll deal with that in a sec. [17:24:17] (03PS1) 10Paladox: Add composer.json [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/241695 [19:08:39] (03CR) 10Jdlrobson: "Also what is the best way to test this - can you provide local testing instructions?" (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178059 (https://phabricator.wikimedia.org/T76030) (owner: 10Gergő Tisza) [19:17:34] hi folks [19:32:47] hi thedj [19:39:21] MatmaRex: you found the IE9 issue I see ? [19:39:55] so it would seem [20:34:23] marktraceur: still there? [20:35:11] marktraceur: i'm going to rejigger the legalese thingies in prtksxna's upload dialog, and i'm going to want you to recheck them [20:35:15] i think they look bad [20:35:27] (no text changes, just shifting stuff around) [21:32:16] MatmaRex: OK, no problem [21:33:35] marktraceur: i'm currently trying to figure out why jquerymsg can't parse the messages we're using there… [21:33:50] or rather, i already know why it can't, it's because it's fucked up [21:33:54] i'm trying to make it can [21:37:18] (03CR) 10Hashar: "check experimental" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/241695 (owner: 10Paladox) [21:43:29] (03CR) 10Hashar: [C: 032] Add composer.json [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/241695 (owner: 10Paladox) [21:44:30] (03CR) 10Paladox: "Thanks." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/241695 (owner: 10Paladox) [21:45:05] (03Merged) 10jenkins-bot: Add composer.json [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/241695 (owner: 10Paladox) [22:10:54] marktraceur [22:10:55] mark [22:10:57] maaaaark [22:11:00] foreign-structured-upload-form-label-infoform-legal [22:11:11] what is this supposed to be? it's a message we're using but not defining [22:11:19] Bloody hell. [22:11:23] MatmaRex: Uhhh [22:11:34] we have like four other legalese messages [22:11:39] I think prtksxna said to take it out, and I maybe took it out of i18n but not in the JS? [22:11:42] so maybe this is somehting old that should've been removed? [22:11:55] it's in the details step, not upload [22:12:01] Oh. [22:12:01] okay, remove. got it [22:12:06] You sure we should remove? [22:12:08] Yeah, I think so [22:12:17] i'm also pretty sure it's a remnant of something [22:12:17] I don't want no lawyers shouting at me. [22:12:20] OK. [22:12:33] prtksxna removed it from module definition when ed pointed it out [22:12:36] but not from actual code [22:12:36] James_F: Better to ask forgiveness, or something [22:13:01] Yeah yeah. [22:13:06] Also I think slaporte signed off on the current state of things [22:17:29] (03CR) 10Gergő Tisza: "The easiest way is probably just to test together with the followup patch, but you can just also open MMV, open the download dialog (down " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178059 (https://phabricator.wikimedia.org/T76030) (owner: 10Gergő Tisza) [22:28:30] MatmaRex, marktraceur: Good to merge, then? [22:28:57] I have no objections? [22:29:12] no [22:29:16] it's broken in ways [22:29:19] i'm fixing still [22:29:38] i just discovered that it doesn't actually require the date to be given [22:32:48] Argh. [22:33:01] MatmaRex: I also need you to merge https://gerrit.wikimedia.org/r/#/c/241699/ in your copious free time. :-( [22:33:16] Err, https://gerrit.wikimedia.org/r/#/c/241668/ instead. But that one needs review. [22:33:18] (Sorry.) [22:33:40] yeah, can do both before tomorrow [22:33:49] OK. [22:33:53] James_F: i need https://gerrit.wikimedia.org/r/240690 . [22:33:55] 'Cos VE now looks a bit woeful. [22:34:11] MatmaRex: You won't get that before the cut tomorrow… [22:34:29] MatmaRex: Unless we do an insane OOUI release and possibly break lots. [22:34:37] yeah, but make it before the OOUI cut at least… :) [22:34:43] MatmaRex: But then a lot of people will not be my friend. [22:34:52] why D: [22:35:22] Because breaking the interface a few hours before the cut for lots of different bits of our code is a good way to be unpopular. :-) [22:49:00] (03CR) 10Jdlrobson: [C: 04-1] "Unless there is a strong reason for this I suggest simplifying this line (especially since it can give strange side effects when multiple " (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178059 (https://phabricator.wikimedia.org/T76030) (owner: 10Gergő Tisza) [23:06:24] (03PS7) 10Gergő Tisza: Add functions to display/remove a warning in the dialogs [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178059 (https://phabricator.wikimedia.org/T76030) [23:07:43] (03CR) 10Gergő Tisza: [C: 04-1] "Huh. I thought I already updated this with Pau's design proposal from https://gerrit.wikimedia.org/r/#/c/178141/ but apparently I didn't. " [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178059 (https://phabricator.wikimedia.org/T76030) (owner: 10Gergő Tisza) [23:09:04] (03CR) 10Gergő Tisza: "Forgot to post this (gerrit drafts are annoying)." (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178059 (https://phabricator.wikimedia.org/T76030) (owner: 10Gergő Tisza) [23:10:59] (03CR) 10Gergő Tisza: "> Needs some more work." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/178059 (https://phabricator.wikimedia.org/T76030) (owner: 10Gergő Tisza) [23:25:28] (03CR) 10Jdlrobson: [C: 031] "Do you want to change it now?" (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/173916 (https://phabricator.wikimedia.org/T77253) (owner: 10Gilles) [23:39:27] (03PS1) 10Siebrand: Standardize version of php-parallel-lint [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/242002