[01:26:14] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer: Zoom Link for Media Viewer - https://phabricator.wikimedia.org/T77502#1718669 (10Tgr) ZoomViewer has been updated since, I believe. Anyway, it is not hosted on the production cluster so linking to it is a no-go. [04:41:37] 6Multimedia: Specific video file on Commons doesn't transcode - https://phabricator.wikimedia.org/T99522#1718834 (10brion) 5Open>3Resolved a:3brion This file seems to work now. Resolving. [06:39:19] (03CR) 10Nikerabbit: [C: 032] Remove hacks from 063cc6bc, no longer needed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/242496 (owner: 10Bartosz Dziewoński) [06:39:29] (03CR) 10Nikerabbit: Remove hacks from 063cc6bc, no longer needed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/242496 (owner: 10Bartosz Dziewoński) [06:39:50] (03PS2) 10Nikerabbit: Remove hacks from 063cc6bc, no longer needed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/242496 (owner: 10Bartosz Dziewoński) [06:58:31] (03CR) 10Nikerabbit: [C: 032] Remove hacks from 063cc6bc, no longer needed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/242496 (owner: 10Bartosz Dziewoński) [07:00:11] (03Merged) 10jenkins-bot: Remove hacks from 063cc6bc, no longer needed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/242496 (owner: 10Bartosz Dziewoński) [08:12:19] (03PS1) 10Siebrand: Update indentation to use tabs [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/245378 [08:34:05] (03PS2) 10Hashar: Updated watir-webdriver Ruby gem to the latest version [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240670 (https://phabricator.wikimedia.org/T112748) (owner: 10Zfilipin) [08:34:07] (03CR) 10jenkins-bot: [V: 04-1] Updated watir-webdriver Ruby gem to the latest version [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240670 (https://phabricator.wikimedia.org/T112748) (owner: 10Zfilipin) [08:41:11] (03CR) 10Siebrand: [C: 032] Update indentation to use tabs [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/245378 (owner: 10Siebrand) [08:41:13] (03CR) 10jenkins-bot: [V: 04-1] Update indentation to use tabs [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/245378 (owner: 10Siebrand) [08:58:58] (03CR) 10Hashar: "recheck" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240670 (https://phabricator.wikimedia.org/T112748) (owner: 10Zfilipin) [09:00:30] (03CR) 10Hashar: [C: 032] Updated watir-webdriver Ruby gem to the latest version [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240670 (https://phabricator.wikimedia.org/T112748) (owner: 10Zfilipin) [09:02:10] (03Merged) 10jenkins-bot: Updated watir-webdriver Ruby gem to the latest version [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/240670 (https://phabricator.wikimedia.org/T112748) (owner: 10Zfilipin) [09:03:42] (03CR) 10Siebrand: [C: 032] Update indentation to use tabs [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/245378 (owner: 10Siebrand) [09:06:08] (03Merged) 10jenkins-bot: Update indentation to use tabs [extensions/ImageMetrics] - 10https://gerrit.wikimedia.org/r/245378 (owner: 10Siebrand) [09:31:26] (03PS1) 10Siebrand: Update indentation to use tabs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/245453 [09:36:19] (03CR) 10Siebrand: [C: 032] Update indentation to use tabs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/245453 (owner: 10Siebrand) [09:39:29] (03Merged) 10jenkins-bot: Update indentation to use tabs [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/245453 (owner: 10Siebrand) [10:41:04] MatmaRex: Did you test https://gerrit.wikimedia.org/r/#/c/244680/? Do you see the texture when you start typing? [10:42:29] prtksxna: yes, but only with the OOUI dependency [10:42:53] MatmaRex: Ah yes, and that'll come in core on Tuesday? [10:43:24] prtksxna: it probably won't, depends on when James_F plans to do the next release. if not, i'll backport it. [10:43:50] MatmaRex: Cool. I'll get that dependency and test. [10:50:42] MatmaRex: https://gerrit.wikimedia.org/r/#/c/244680/ looks good, should I wait to merge it? [10:52:16] prtksxna: i think we should be merging the things asap [10:56:36] MatmaRex: Anything left to mark T115010 as resolved? [10:58:02] prtksxna: looks like that's all [11:01:08] So, from your email, only T114940 is left now. [11:20:23] MatmaRex: Does the API only return one error at a time? I remember getting a json like { exists:…, duplicate:…} earlier. [11:54:18] prtksxna: only one error, but possibly many warnings [11:55:11] prtksxna: the action=upload api is pretty nasty here, you either get the error as { error: foo }, or warnings as { upload: { warnings: foo } } [11:56:12] the api also returns warnings as { warnings: foo }, but these are generally caused by incorrectly using it [12:12:03] MatmaRex: It seems that some behavior changed recently. When I upload a file that I've already uploaded previously, it used to give me both exists (as in description page) and duplicate (as in file exists) at the same time. Now I only get one. [12:13:22] Which means that even if we move the duplicate check before the exists check (https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki/mediawiki.Upload.BookletLayout.js#L260) , we'll still only get the exists error message, as in T115056. [12:15:26] hmm. [12:17:03] And I am pretty sure it wasn't this way a few days ago. I'd get both keys, and thus changing the order of the conditions would solve the problem. [12:17:21] I am checking though :) [12:18:33] prtksxna: i think the warnings have a slightly different meanings - 'exists' means that a *file* with the same name exists, 'page-exists' means that a *page* exists (but not the file), and 'duplicate' means that a file with different name but same contents exists. [12:19:07] /o\ [12:19:11] MatmaRex: That makes sense [12:19:53] Weird that I've never actually seen the page-exists warning. [12:20:38] I'll try and get it [12:20:40] yeah, i think it's kind of difficult to run into. you'd have to deliberately create the File: namespace page for a file that wasn't uploaded [12:20:50] or delete only the file, but not the page? i'm not sure if that's even possible [12:21:19] Or just upload 2 different files and give the same file name in the dialog? [12:23:49] Err, that doesn't work. I still get exists. [12:24:42] Weird, I should gotten page-exists, right? I am sure that a *file* with the same name doesn't exist, so getting 'exists' is wrong. [12:25:03] hmm. [12:26:00] weird. dunno, maybe it's buggy? :P [12:26:25] :P [12:27:02] MatmaRex: Do you mind trying what I did? Just to be sure that *it* is buggy and not me :) [12:27:21] yeah, i'm trying [12:31:11] I don't understand core too well, but its weird that getExistsWarning returns a specific warning (https://github.com/wikimedia/mediawiki/blob/master/includes/upload/UploadBase.php#L1739), but then checkWarnings (https://github.com/wikimedia/mediawiki/blob/master/includes/upload/UploadBase.php#L641) just checks if it isn't false and returns 'exists' (not using the name getExistsWarning uses). [12:34:06] s/too well/at all [12:34:48] prtksxna: i don't understand that code either, it's terrible [12:35:13] prtksxna: i did manage to get a 'page-exists' warning, though. [12:35:31] Which means that code isn't buggy \o/ [12:35:32] i created a page called "File:Asasdasd.png", then i tried to upload a file under that same name using the media dialog in VE. [12:36:56] * prtksxna tries that [12:41:46] Unknown warning: "{"page-exists":"Asad.png"}". \o/ [12:44:33] Thank you for walking me through this MatmaRex [12:45:02] :D [13:00:16] (03PS1) 10Hashar: Add composer test entry point [extensions/TimedMediaHandler] (REL1_25) - 10https://gerrit.wikimedia.org/r/245476 (https://phabricator.wikimedia.org/T115211) [13:00:47] (03CR) 10jenkins-bot: [V: 04-1] Add composer test entry point [extensions/TimedMediaHandler] (REL1_25) - 10https://gerrit.wikimedia.org/r/245476 (https://phabricator.wikimedia.org/T115211) (owner: 10Hashar) [13:11:29] (03PS2) 10Hashar: Add composer test entry point [extensions/TimedMediaHandler] (REL1_25) - 10https://gerrit.wikimedia.org/r/245476 (https://phabricator.wikimedia.org/T115211) [13:12:42] (03CR) 10Hashar: "We probably want to massively update all repositories branches to introduce those dummy scripts. This way all the CI Configuration can be" [extensions/TimedMediaHandler] (REL1_25) - 10https://gerrit.wikimedia.org/r/245476 (https://phabricator.wikimedia.org/T115211) (owner: 10Hashar) [13:25:49] prtksxna: fyi, anomie just merged https://gerrit.wikimedia.org/r/#/c/237725/ which affects some of the warnings output from action=upload api, but it shouldn't affect any of the upload dialog code [13:31:34] * prtksxna looks [13:32:43] MatmaRex: Mind taking a look at https://gerrit.wikimedia.org/r/#/c/242592/? I'll rebase if you think its merge-able. [13:34:26] prtksxna: looks good, let's merge. /me rebases [13:34:34] MatmaRex: Thanks [13:36:00] MatmaRex: I think I am using messages all wrong. I'll make a patch dependent on yours, so that I can fix getErrorMessageForStateDetails instead of some rebase. [13:36:20] MatmaRex: Also, I'd left comments on your patches, want to resolve/discuss those? [13:37:16] prtksxna: yeah, which patches? [13:37:35] https://gerrit.wikimedia.org/r/#/c/244676 and https://gerrit.wikimedia.org/r/#/c/244512 [13:37:37] MatmaRex: ^ [13:39:51] looking [14:07:16] prtksxna: replied to both [14:14:19] 6Multimedia, 6Commons, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Commons' TitleBlacklist messages are messy and not parseable by jqueryMsg - https://phabricator.wikimedia.org/T115259#1719278 (10matmarex) 3NEW [14:14:24] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Provide precise information for errors caused by title blacklist in upload image dialog - https://phabricator.wikimedia.org/T115260#1719286 (10matmarex) 3NEW [14:14:47] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review: Trying to upload image under blacklisted title in the upload image dialog throws error "" - https://phabricator.wikimedia.org/T114940#1719293 (10matmarex) [14:14:57] 6Multimedia, 6Commons, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Commons' TitleBlacklist messages are messy and not parseable by jqueryMsg - https://phabricator.wikimedia.org/T115259#1719296 (10matmarex) [14:15:00] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review: Trying to upload image under blacklisted title in the upload image dialog throws error "" - https://phabricator.wikimedia.org/T114940#1710047 (10matmarex) [14:15:03] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Provide precise information for errors caused by title blacklist in upload image dialog - https://phabricator.wikimedia.org/T115260#1719295 (10matmarex) [14:15:54] Hi guys, it's a US holiday today, and I'm taking it so I can make more progress on moving [14:16:12] I have appropriately declined some meetings. [14:16:20] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review: Trying to upload image under blacklisted title in the upload image dialog throws error "" - https://phabricator.wikimedia.org/T114940#1710047 (10matmarex) I filed T115260 to track furt... [14:17:25] http://www.nooooooooooooooo.com/ [14:18:15] maaark [14:18:46] D: [14:19:42] i'm away to get some food, and then back to finish making the upload dialog usable today [14:34:33] prtksxna: you're working on https://phabricator.wikimedia.org/T115056 , right? [15:12:46] I'm in IAD and WiFi is poor. Won't try to do the hangout. [15:20:58] 6Multimedia, 6Commons, 10UploadWizard: UploadWizard Flickr does not display preview images during Step 4 - https://phabricator.wikimedia.org/T113850#1719406 (10Aklapper) Still an issue? [15:24:48] prtksxna: bleh, looks like i won't make the meeting either, my internet connection just died (perhaps something to do with all the sudden snow) and i'm tethering right now [15:26:27] MatmaRex: I suspected the snow might do this :| [15:26:54] MatmaRex: Cool, no meeting! [15:29:00] it's not like this is a hundred-year snowstorm, dammit [15:29:05] it's just snow. winter. happens every year. [15:29:17] * MatmaRex grumbles [15:29:46] prtksxna: so uh, you're doing https://phabricator.wikimedia.org/T115056 , right? [15:29:53] (or should i?) [15:30:29] MatmaRex: I am, you left IRC before I could answer (was eating dinner). [15:31:02] right. thanks [15:33:57] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Media upload dialog reports that file page exists, but not the file, even if the file does exist - https://phabricator.wikimedia.org/T115056#1719439 (10matmarex) a:3Prtksxna [15:42:44] MatmaRex: ugh, every time I submit a patch dependent on your patch, I'll be submitted a new PS to those too? [15:42:59] Maybe it wont, and I just have an older copy right now. [15:46:39] prtksxna: no, it shouldn't create a new patchset in the dependencies [15:49:52] MatmaRex: Should i be worried? https://phabricator.wikimedia.org/P2185 [15:51:35] prtksxna: that looks like the usual thing you get when your 'origin' and 'gerrit' remotes are not in sync (or just not updated recently) [15:51:37] https://phabricator.wikimedia.org/P2184 [15:51:47] prtksxna: try cancelling, then `git fetch gerrit` [15:51:55] then try again. the message should be gone [15:52:18] MatmaRex: Shouldn't I be seeing origin/master in the log if you recently rebased the patches? [15:52:41] (or `git fetch gerrit master`? not sure) [15:53:22] prtksxna: hmm, i think only with `git log --decorate`? but i didn't rebase them , i think [15:53:30] https://phabricator.wikimedia.org/P2186 [15:53:46] Bartosz Dziewoński [15:53:47] 7:29 PM [15:53:47] Patch Set 2: Patch Set 1 was rebased [15:53:49] oops [15:53:58] oh. hmm [15:54:07] i rebased on top of the updated dependency [15:54:16] MatmaRex: Do you want to submit the change, or I'll submit it once your changes are merged? [15:54:37] i'm not sure what would happen. worst case is that it'll revert my recent patchsets on the changeset [15:54:52] In my experience, even after typing 'yes' it won't update your patch if nothing has changed. [15:55:19] prtksxna: you can do: git review -d 244676 && git cherry-pick 0e29ebd [15:55:37] that should give you a clean state with your patch preserved [15:55:48] (0e29ebd is your commit from https://phabricator.wikimedia.org/P2186) [15:56:04] That is exactly what I did :) [16:02:17] I'll just link that pastie to the task and put it on gerrit once your patches are merged. [16:02:17] MatmaRex: ^ [16:03:20] eh [16:03:24] nooo [16:03:28] just push them for review [16:03:49] prtksxna: ^ [16:04:25] it looks like it'll be fine, and even if not, you can't break anything permanently. we can always revert to earlier patchset [16:04:57] I guess it didn't hurt anything \o/ [16:05:22] yeah, all looks well [16:06:15] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review: Provide precise information for errors caused by title blacklist in upload image dialog - https://phabricator.wikimedia.org/T115260#1719486 (10Prtksxna) We still need to change the messages and the links, but this makes things... [16:10:38] (03CR) 10Paladox: [C: 031] Add composer test entry point [extensions/TimedMediaHandler] (REL1_25) - 10https://gerrit.wikimedia.org/r/245476 (https://phabricator.wikimedia.org/T115211) (owner: 10Hashar) [20:05:44] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media, 5Patch-For-Review: Provide precise information for errors caused by title blacklist in upload image dialog - https://phabricator.wikimedia.org/T115260#1719925 (10Jdforrester-WMF) [20:05:46] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media, 5MW-1.27-release-notes, and 2 others: Trying to upload image under blacklisted title in the upload image dialog throws error "" - https://phabricator.wikimedia.org/T114940#1719923 (10Jdforrester-WMF) 5O... [20:06:52] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media, 5MW-1.27-release-notes, and 2 others: Media upload dialog reports that file page exists, but not the file, even if the file does exist - https://phabricator.wikimedia.org/T115056#1719926 (10Jdforrester-WMF) 5Open>3Resolved [20:08:15] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Provide precise information for errors caused by title blacklist in upload image dialog - https://phabricator.wikimedia.org/T115260#1719929 (10Jdforrester-WMF) p:5Triage>3Normal [20:08:37] (03PS13) 10Jdlrobson: Add extension.json, empty PHP entry point [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/187735 (https://phabricator.wikimedia.org/T87943) (owner: 10Gilles) [20:08:44] (03CR) 10Jdlrobson: [C: 032] Add extension.json, empty PHP entry point [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/187735 (https://phabricator.wikimedia.org/T87943) (owner: 10Gilles) [20:10:14] (03Merged) 10jenkins-bot: Add extension.json, empty PHP entry point [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/187735 (https://phabricator.wikimedia.org/T87943) (owner: 10Gilles) [20:11:44] (03CR) 10Jdlrobson: "setup https://phabricator.wikimedia.org/T115279?workflow=create" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/187735 (https://phabricator.wikimedia.org/T87943) (owner: 10Gilles) [20:52:47] 6Multimedia, 10Wikimedia-Developer-Summit-2016: WikiDev16: Next generation video for Wikipedia and friends - https://phabricator.wikimedia.org/T112695#1720009 (10Qgil) > This session can be considered as 'backlog grooming'. The intent will be to report on current status, gather feature requests, identify block... [21:31:26] 6Multimedia, 10Wikimedia-Developer-Summit-2016, 10Wikimedia-Video: WikiDev16: Next generation video for Wikipedia and friends - https://phabricator.wikimedia.org/T112695#1720123 (10Qgil)