[00:35:43] 6Multimedia, 6Commons, 10MediaWiki-File-management, 7Wikimedia-log-errors: XMPReader::parse exceptions - https://phabricator.wikimedia.org/T118799#1809668 (10Krinkle) 3NEW [00:42:03] 6Multimedia, 6Commons, 10MediaWiki-File-management, 7Wikimedia-log-errors: XMPReader::parse exceptions - https://phabricator.wikimedia.org/T118799#1809701 (10Bawolff) I think XMP errors would be more appropriate as the info level severity (Or maybe even lower). Also the filename should definitely be includ... [06:31:45] Should we add mw.loader.using( …module name… ) in the intro example in https://doc.wikimedia.org/mediawiki-core/master/js/#!/api/mw.Upload.Dialog. Will make it easier for people trying to use it on-wiki. [06:32:23] Is there a documentation tag that we use to show which modules need to be loaded to use something? Or does everyone have to look inside Resources.php? [07:37:52] prtksxna: [[mw:RL/DM]] ? [08:23:24] 6Multimedia, 6Commons, 10MediaWiki-File-management: Mirrored EXIF rotations are not applied to thumbnails - https://phabricator.wikimedia.org/T75602#1810227 (10Thgoiter) Same for https://de.wikipedia.org/wiki/Datei:Schauspielhaus_Duesseldorf_Grundriss.jpg (Orientation: Mirror horizontal) [09:20:00] prtksxna: ppl just look in Resources.php honestly :) [09:20:07] which is probably bad. [10:08:21] thedj: That's what I have been doing :S [10:38:05] 6Multimedia, 10MediaWiki-General-or-Unknown, 7Design, 5Patch-For-Review: mw.ForeignStructuredUpload.BookletLayout's DateInputWidget should have better default value - https://phabricator.wikimedia.org/T115863#1810486 (10Prtksxna) >>! In T115863#1781838, @Esanders wrote: > lastModified is an improvment but... [12:09:33] 6Multimedia, 10MediaWiki-General-or-Unknown, 5Patch-For-Review: mw.ForeignStructuredUpload should have a configurable information template - https://phabricator.wikimedia.org/T118097#1810604 (10Prtksxna) [15:14:03] marktraceur: When using the examples in ApiImageTweaks, I get an internal_api_error_BadMethodCallException [15:14:34] Uhhh [15:14:35] marktraceur: https://phabricator.wikimedia.org/P2319 [15:14:44] prtksxna: Did you install MediaDevilry also? [15:15:10] Oh, hm, you might not have included itdestfile [15:15:22] or https://github.com/MarkTraceur/MediaDevilry [15:15:31] I meant I haven't included either [15:15:40] Hm. [15:16:01] The error you got, though, is probably itdestfile missing [15:16:06] The examples are probably not polished. [15:16:26] marktraceur: Do you mind getting on Hangout before our Hangout? [15:17:01] Yo dawg. [15:17:09] No I don't mind, let me get coffee first though if you don't mind [15:17:13] 10, 15 minutes tops [15:17:16] * prtksxna combs hair [15:27:02] OK ten minutes was accurate [15:30:43] prtksxna: I'm ready! [15:31:19] marktraceur: Sorry! I was tethering and my mobile data died [15:31:23] Trying to connect to the hangout now [15:43:16] prtksxna: Hallo [15:43:40] MatmaRex: Can you confirm that you saw my message to prtksxna? [15:44:38] marktraceur: hi. which message? [15:48:39] Never mind, we confirmed that he was magically disconnected from the Internet [15:48:52] Aaaand once again. [15:48:56] prtksxna: Still there? [15:49:18] prtksxna: Trying to reconnect :\ [15:49:23] marktraceur: ^ [15:49:30] OK! [15:49:31] ooops :S [15:54:19] i've gotta run for awhile, might miss the hangout, sorry [15:54:20] That's OK! [16:08:13] marktraceur: https://python-pillow.github.io/ [16:08:29] marktraceur: That was nice whilst it lasted. [16:09:06] marktraceur: Which does have rotation! http://pillow.readthedocs.org/en/3.0.x/reference/Image.html?highlight=rotate#PIL.Image.Image.rotate [16:09:40] (i'm here now) [16:11:26] MatmaRex: You missed us praising your work [16:11:55] prtksxna: But not a service, just a library [16:12:03] :o [16:28:40] marktraceur: This is what thumbor uses [16:29:25] marktraceur: I meant to point out thus that adding rotation to thumbor won't be that hard because the library it uses for image manipulation already uses it [16:29:31] s/uses/has [16:30:14] (-, – )…zzZZ Anyway, I should go to bed [16:30:30] Oh, cool. [16:31:48] (03PS6) 10Bartosz Dziewoński: Split off uw.OtherDetailsWidget from UploadWizardDetails (and OOUI-ize) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251488 (https://phabricator.wikimedia.org/T96917) [16:31:50] (03PS1) 10Bartosz Dziewoński: Split off uw.CampaignDetailsWidget from UploadWizardDetails (and OOUI-ize) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253627 (https://phabricator.wikimedia.org/T96917) [16:31:52] (03PS1) 10Bartosz Dziewoński: Use OOUI 'required' indicator for required fields where possible [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253628 (https://phabricator.wikimedia.org/T117833) [16:31:56] (03PS1) 10Bartosz Dziewoński: Use FieldLayout's 'help' popups rather than jquery.tipsy hints where possible [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253629 (https://phabricator.wikimedia.org/T115637) [16:32:26] marktraceur: alright, i think i'm fairly happy with that stack now ^ [16:33:13] MatmaRex: Neat! I think I can wait to work on the next ImageTweaks thing anyway. [16:33:33] marktraceur: i'm working on doing the same thing to deeds now. i know it's not exactly in our quarterly goals, but one thing that UW definitely does not need is yet another half-complete refactoring [16:36:29] :-) [16:40:19] MatmaRex: True dat. [16:40:55] MatmaRex: I think ultimately this solves the show-stopping issue of "gee, there's this massive bug, but nobody understands this codebase enough to fix it" [16:41:36] (03PS9) 10Bartosz Dziewoński: mw.UploadWizardDeed: Change text fields to be OOUI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/212842 (https://phabricator.wikimedia.org/T113371) (owner: 10MarkTraceur) [16:41:38] (03PS1) 10Bartosz Dziewoński: Remove some dead code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253631 [16:41:40] (03PS1) 10Bartosz Dziewoński: Separate other classes from resources/mw.UploadWizardDeed.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253632 [16:41:42] (03PS1) 10Bartosz Dziewoński: mw.UploadWizardDeedOwnWork: Only use one authorInput and move it when needed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253633 [16:41:43] marktraceur: also true [16:42:02] (03CR) 10Bartosz Dziewoński: mw.UploadWizardDeed: Change text fields to be OOUI (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/212842 (https://phabricator.wikimedia.org/T113371) (owner: 10MarkTraceur) [16:42:19] marktraceur: Do you mean, we've now converted it to gee, there's this massive bug, and only MatmaRex understands this codebase enough to fix it"? ;-) [16:42:28] James_F: Probably [16:42:36] * James_F hugs MatmaRex. [16:42:41] James_F: But that's an improvement from only me understanding it, IMO [16:42:49] :-) [16:42:50] (03CR) 10Bartosz Dziewoński: [C: 031] "I salvaged the part of this that was not invalidated by my massive refactor (T96917), in mw.UploadWizardDeed.js, and added some more." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/212842 (https://phabricator.wikimedia.org/T113371) (owner: 10MarkTraceur) [16:43:26] MatmaRex: Do the step controller/ui classes still make sense with your Grand Vision for UploadWizard™? [16:43:28] James_F: marktraceur: i think we have infinitely more people understanding OOUI than jquery.validate ;) [16:43:30] (03CR) 10jenkins-bot: [V: 04-1] mw.UploadWizardDeed: Change text fields to be OOUI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/212842 (https://phabricator.wikimedia.org/T113371) (owner: 10MarkTraceur) [16:43:43] Since my half-complete refactor was partly making those classes [16:43:43] MatmaRex: :-) [16:43:57] (03CR) 10jenkins-bot: [V: 04-1] Separate other classes from resources/mw.UploadWizardDeed.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253632 (owner: 10Bartosz Dziewoński) [16:44:16] MatmaRex: Krinkle might understand $.validate, but I wouldn't count on that [16:44:31] (03CR) 10jenkins-bot: [V: 04-1] mw.UploadWizardDeedOwnWork: Only use one authorInput and move it when needed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253633 (owner: 10Bartosz Dziewoński) [16:44:39] marktraceur: i'm not convinced about the controller/ui split, but i don't mind it, and having classes for each step is definitely good [16:44:47] MatmaRex: K, awesome [16:47:44] (03PS10) 10Bartosz Dziewoński: mw.UploadWizardDeed: Change text fields to be OOUI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/212842 (https://phabricator.wikimedia.org/T113371) (owner: 10MarkTraceur) [16:47:57] (03PS2) 10Bartosz Dziewoński: Separate other classes from resources/mw.UploadWizardDeed.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253632 [16:49:08] (03PS2) 10Bartosz Dziewoński: mw.UploadWizardDeedOwnWork: Only use one authorInput and move it when needed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253633 [16:51:02] (03CR) 10jenkins-bot: [V: 04-1] mw.UploadWizardDeedOwnWork: Only use one authorInput and move it when needed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253633 (owner: 10Bartosz Dziewoński) [16:51:51] (03PS3) 10Bartosz Dziewoński: uw.TitleDetailsWidget: Restore blacklist error message details [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/252663 [18:51:36] 6Multimedia, 6Commons, 10Internet-Archive, 10MediaWiki-Uploading: Upload by URL doesn't work well for large files: HTTP request timed out. - https://phabricator.wikimedia.org/T118887#1811750 (10Dereckson) 3NEW [18:52:23] 6Multimedia, 6Commons, 10Internet-Archive, 10MediaWiki-Uploading: Upload by URL doesn't work well for large files: HTTP request timed out. - https://phabricator.wikimedia.org/T118887#1811760 (10Dereckson) @csteipp Would you know if there is some security configuration in place to timeout fairly quickly an... [18:54:20] 6Multimedia, 6Commons, 10Internet-Archive, 10MediaWiki-Uploading: Upload by URL doesn't work well for large files: HTTP request timed out. - https://phabricator.wikimedia.org/T118887#1811774 (10Dereckson) [18:57:24] 6Multimedia, 6Commons, 10Internet-Archive, 10MediaWiki-Uploading: Upload by URL doesn't work well for large files: HTTP request timed out. - https://phabricator.wikimedia.org/T118887#1811790 (10csteipp) >>! In T118887#1811760, @Dereckson wrote: > @csteipp Would you know if there is some security configurat... [19:01:27] 6Multimedia, 10MediaWiki-Authentication-and-authorization, 7Blocked-on-Multimedia: History - https://phabricator.wikimedia.org/T118891#1811815 (10Dgarlin21) 3NEW a:3Dgarlin21 [20:31:03] 6Multimedia, 10MediaWiki-Authentication-and-authorization, 7Blocked-on-Multimedia: History - https://phabricator.wikimedia.org/T118891#1812184 (10Bawolff) ? Is this a test bug? [20:58:47] 6Multimedia, 6Commons, 10Internet-Archive, 10MediaWiki-Uploading: Upload by URL doesn't work well for large files: HTTP request timed out. - https://phabricator.wikimedia.org/T118887#1812233 (10Bawolff) Actually, yes we do: *we have a connect timeout of 5 seconds (must connect to server in under 5 seconds... [21:02:52] 6Multimedia, 6Commons, 10Internet-Archive, 10MediaWiki-Uploading: Upload by URL doesn't work well for large files: HTTP request timed out. - https://phabricator.wikimedia.org/T118887#1812239 (10Bawolff) If we want to change this, the config is $wgCopyUploadTimeout. But if we increase it too much we'll prob... [21:07:42] 6Multimedia, 10UploadWizard, 7I18n: Messages mwe-upwiz-error-too-short and mwe-upwiz-error-too-long are reused, sometimes passed wrong parameters - https://phabricator.wikimedia.org/T118902#1812246 (10matmarex) 3NEW [22:01:05] 6Multimedia, 6Commons, 10Internet-Archive, 10MediaWiki-Uploading: Upload by URL doesn't work well for large files: HTTP request timed out. - https://phabricator.wikimedia.org/T118887#1812341 (10Yann) FYI I tested https://archive.org/download/AlfredHitchcockExtendedInterview/AlfredHitchcockExtendedInterview... [22:07:52] 6Multimedia, 10UploadWizard: Migrate deed chooser forms to OOjs UI - https://phabricator.wikimedia.org/T118906#1812355 (10matmarex) 3NEW a:3matmarex [22:08:57] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Migrate text fields in UploadWizard deed step to OO.ui.TextInputWidget - https://phabricator.wikimedia.org/T113371#1812365 (10matmarex) [22:09:04] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Migrate text fields in UploadWizard deed step to OO.ui.TextInputWidget - https://phabricator.wikimedia.org/T113371#1663232 (10matmarex) [22:10:52] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Split up the details class into multiple OOjs UI widgets in separate files - https://phabricator.wikimedia.org/T96917#1812372 (10matmarex) [22:12:10] (03CR) 10Bartosz Dziewoński: Split off uw.DateDetailsWidget from UploadWizardDetails (introduce uw.DetailsWidget) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251179 (https://phabricator.wikimedia.org/T96917) (owner: 10Bartosz Dziewoński) [22:12:22] MatmaRex: Neat, thanks [22:12:42] (03PS11) 10Bartosz Dziewoński: mw.UploadWizardDeed: Change text fields to be OOUI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/212842 (https://phabricator.wikimedia.org/T113371) (owner: 10MarkTraceur) [22:12:44] (03PS2) 10Bartosz Dziewoński: Remove some dead code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253631 [22:12:46] (03PS3) 10Bartosz Dziewoński: mw.UploadWizardDeedOwnWork: Only use one authorInput and move it when needed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253633 [22:12:48] (03PS3) 10Bartosz Dziewoński: Separate other classes from resources/mw.UploadWizardDeed.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253632 [22:12:50] (03PS1) 10Bartosz Dziewoński: [WIP] Use OOUI FieldLayouts and validation for deeds [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253765 (https://phabricator.wikimedia.org/T113371) [22:14:55] (03PS2) 10Bartosz Dziewoński: [WIP] Use OOUI FieldLayouts and validation for deeds [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253765 (https://phabricator.wikimedia.org/T118906) [22:16:55] (03CR) 10jenkins-bot: [V: 04-1] mw.UploadWizardDeed: Change text fields to be OOUI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/212842 (https://phabricator.wikimedia.org/T113371) (owner: 10MarkTraceur) [22:17:19] (03CR) 10jenkins-bot: [V: 04-1] mw.UploadWizardDeedOwnWork: Only use one authorInput and move it when needed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253633 (owner: 10Bartosz Dziewoński) [22:17:39] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use OOUI FieldLayouts and validation for deeds [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253765 (https://phabricator.wikimedia.org/T118906) (owner: 10Bartosz Dziewoński) [22:17:43] (03CR) 10jenkins-bot: [V: 04-1] Separate other classes from resources/mw.UploadWizardDeed.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253632 (owner: 10Bartosz Dziewoński) [22:18:09] grrrawr [22:20:27] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Use OOUI FieldLayouts and validation for deeds [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253765 (https://phabricator.wikimedia.org/T118906) (owner: 10Bartosz Dziewoński) [22:25:26] MatmaRex: Womp womp [22:30:54] (03PS3) 10Bartosz Dziewoński: [WIP] Use OOUI FieldLayouts and validation for deeds [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253765 (https://phabricator.wikimedia.org/T118906) [22:30:56] (03PS12) 10Bartosz Dziewoński: mw.UploadWizardDeed: Change text fields to be OOUI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/212842 (https://phabricator.wikimedia.org/T113371) (owner: 10MarkTraceur) [22:30:58] (03PS4) 10Bartosz Dziewoński: mw.UploadWizardDeedOwnWork: Only use one authorInput and move it when needed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253633 [22:31:00] (03PS4) 10Bartosz Dziewoński: Separate other classes from resources/mw.UploadWizardDeed.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253632 [23:23:31] 6Multimedia, 10UploadWizard: Copy metadata copies even if nothing was selected to copy - https://phabricator.wikimedia.org/T43999#1812483 (10matmarex) The button should probably be disabled when all of the checkboxes are unchecked. This would be easier to do after T117784.