[08:48:10] (03PS8) 10Ori.livneh: Variant logging [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/186158 (https://phabricator.wikimedia.org/T87184) (owner: 10Gilles) [08:48:27] (03CR) 10jenkins-bot: [V: 04-1] Variant logging [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/186158 (https://phabricator.wikimedia.org/T87184) (owner: 10Gilles) [10:13:25] 6Multimedia, 6Commons, 10Internet-Archive, 10MediaWiki-Uploading: Upload by URL doesn't work well for large files: HTTP request timed out. - https://phabricator.wikimedia.org/T118887#1813288 (10MoritzMuehlenhoff) >>! In T118887#1811790, @csteipp wrote: > In mediawiki, no. Moritz may know if our outbound pr... [10:23:26] 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset, 7Tracking: GWToolset metadata input tracker - https://phabricator.wikimedia.org/T60509#1813301 (10Liuxinyu970226) [12:45:10] 6Multimedia, 10Wikimedia-Developer-Summit-2016, 10Wikimedia-Video: WikiDev16: Next generation video for Wikipedia and friends - https://phabricator.wikimedia.org/T112695#1813488 (10Qgil) [12:46:29] 6Multimedia, 10Wikimedia-Developer-Summit-2016, 10Wikimedia-Video: WikiDev16: Next generation video for Wikipedia and friends [backend] - https://phabricator.wikimedia.org/T118911#1813496 (10Qgil) [13:00:18] marktraceur: https://www.mediawiki.org/wiki/Extension:ImageTweaks/UI [13:37:08] MatmaRex: https://gerrit.wikimedia.org/r/#/c/246241 works for me now [13:37:25] yay [13:37:26] MatmaRex: Should I +2 or is there still something pending there? [13:37:36] prtksxna: i think it's fine to +2 [15:15:18] prtksxna: I'm not sure the survey thing will work perfectly, but it looks pretty nice! [15:16:28] prtksxna, James_F|Away, would you guys mind if I charged boldly into Commons and asked what they would like in an image editor? [15:19:54] marktraceur: Yeah, we'll have to figure out the survey part [15:20:38] marktraceur: Should we ask if they want an image editor in the first place? [15:22:55] prtksxna: Part of me thinks that's an idea that's defensible on principle. [15:24:38] * prtksxna nods [15:24:59] marktraceur: Either way, I do feel that we should release a very bare minimum extension to begin with [15:25:09] True [15:25:14] marktraceur: And change stuff only when the people actually using it want it changed [15:25:16] Then again, that's a long way away [15:25:23] We're "just experimenting". [15:25:27] Right [15:26:19] Though I admit I'm still not quite sure what that means. :P [15:26:32] I am just not sure that asking gives us answers from the right people. We received very different qualitative feedback from logged in users about Hovercards when we asked generally and when there was a feedback button in the feature itself. [15:26:51] Both had negative reviews, but one of them has useful criticism. [15:26:56] BETAFEATURE! :P [15:28:27] Hm. [15:28:40] I think this could be harder because the feature is not as easy to discover [15:28:57] I mean, BF, sure, but...well, like I said, we're a long way away from this, we can deal with it later [15:29:06] * prtksxna nods [15:29:08] I don't see any harm in asking [15:29:12] OK [15:29:32] As long as people don't expect that we're building it :P [15:29:52] Because we're "just experimenting". [15:30:07] Right. I'll keep expectations low. [15:30:23] Besides, loads of people know me at Commons [15:30:27] They know I'm useless [15:30:49] marktraceur: No meetings ever on Wednesdays? [15:31:41] :P [15:32:01] Oh, right [15:32:06] I forgot about that [15:32:15] I was expecting a surefire way to ambush James. [15:33:00] I guess I might as well make breakfast, then [15:40:26] marktraceur: I'll stop thinking about ImageTweaks then. Link me to your post on commons when you make it :) [15:48:04] KK [15:48:20] prtksxna: I'd say you could keep thinking about it, even go ahead and make a UI if you want to [15:48:38] Roughly my suggestion would be to use the special page as a base, just replace the entire UI [15:56:02] Ooh, we have a Gerrit repo. [16:12:57] marktraceur: Hm. cool [16:13:10] marktraceur: I didn't find any nice cropping/rotating libraries [16:13:15] Merged your fix for the package.json at least... [16:13:27] prtksxna: Hm, odd [16:13:37] There were a few that were ok, but dependent on jQuer [16:14:11] prtksxna: I'd suggest using instead, and just not loading the script if there's not support for canvas in the browser [16:14:29] marktraceur: the script? [16:14:48] The script that lets the user edit the image in the canvas :) [16:15:05] Or, whatever, load the bootstrap script but then don't load the rest [16:15:12] Ah ok [16:15:17] See e.g. MMV's bootstrap [16:15:28] We probably don't need canvas. [16:15:41] Err. Yes, we do. [16:16:05] marktraceur: I'll make a list and put in /UI. Let's evaluate tomorrow? [16:16:22] KK [16:21:34] 6Multimedia, 10MediaWiki-General-or-Unknown, 10WikiEditor: WikiEditor causing errors - https://phabricator.wikimedia.org/T118942#1813856 (10Prtksxna) [16:58:10] James_F: COM:VP post about ImageTweaks sound okay to you? I'd like to know if "crop and rotate" is a good starting point or if I should be thinking about something else. [16:58:26] And, you know, figuring out what Commons wants out of an image editor is a good idea [17:16:28] marktraceur: Sure, though I think they might be more interested in the non-destructive stuff first. [17:16:51] I mean, yeah [17:17:22] I'm talking about both of the via-upload use cases (but not the inline use case yet) [17:18:11] * James_F nods. [17:18:19] I'd talk about it, and say it's coming later. [17:18:30] This avoids them demanding you work on that instead. ;-) [17:24:21] Indeed. [17:24:55] James_F: Actually, Commons isn't really the place to talk about the inline use case now that I think about it [17:32:19] https://commons.wikimedia.org/wiki/Commons:Village_pump#Image_editing_tool_on-wiki [17:34:25] marktraceur: Sure. [19:58:00] 6Multimedia, 10MediaWiki-General-or-Unknown, 10WikiEditor: WikiEditor causing errors - https://phabricator.wikimedia.org/T118942#1814612 (10TheDJ) >>! In T118942#1813848, @Catrope wrote: > No, that should work. Actually, even when it does work, you should still declare the dependency, since you are a direct... [20:09:17] 6Multimedia, 10MediaWiki-General-or-Unknown, 10WikiEditor: WikiEditor causing errors - https://phabricator.wikimedia.org/T118942#1814692 (10Paladox) Updating moment seems to fix the whole problem not sure why since I updated mediawiki first and js worked fine until I updated wikieditor. [21:00:31] 6Multimedia, 10MediaWiki-General-or-Unknown, 10WikiEditor, 5Patch-For-Review: WikiEditor causing errors - https://phabricator.wikimedia.org/T118942#1814966 (10Paladox) I get this error SyntaxError: Unexpected identifier 'number'. Expected ')' to end a argument list. So updating moment fixes this problem. [21:41:22] 6Multimedia, 10MediaWiki-General-or-Unknown, 10WikiEditor, 5Patch-For-Review: WikiEditor causing errors - https://phabricator.wikimedia.org/T118942#1815159 (10Paladox) This is my website with all modules loaded. One of them are causing the error. http://en.random-wikisaur.tk/load.php?debug=false&lang=en&m... [22:41:18] (03PS4) 10Bartosz Dziewoński: Use OOjs UI FieldLayouts and validation for deeds [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253765 (https://phabricator.wikimedia.org/T118906) [22:41:20] (03PS13) 10Bartosz Dziewoński: mw.UploadWizardDeed: Change text fields to be OOUI [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/212842 (https://phabricator.wikimedia.org/T113371) (owner: 10MarkTraceur) [22:41:22] (03PS3) 10Bartosz Dziewoński: Remove some dead code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253631 [22:41:24] (03PS5) 10Bartosz Dziewoński: mw.UploadWizardDeedOwnWork: Only use one authorInput and move it when needed [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253633 [22:41:26] (03PS5) 10Bartosz Dziewoński: Separate other classes from resources/mw.UploadWizardDeed.js [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/253632 [22:41:28] (03PS1) 10Bartosz Dziewoński: Move #mwe-upwiz-details-error-count element generation to JavaScript [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/254046 [22:41:30] (03PS1) 10Bartosz Dziewoński: Remove now-unused $.fn.requiredFieldLabel and $.fn.addHint [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/254047 [22:41:32] (03PS1) 10Bartosz Dziewoński: Remove all jquery.validate code [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/254048 [22:41:37] POW! [22:41:41] but there's more! [22:41:52] (03PS1) 10Bartosz Dziewoński: Remove unused file 24px-spinner-black.gif [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/254051 [22:41:54] (03PS1) 10Bartosz Dziewoński: Fix upload spinner background color when hovering odd rows [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/254052 [22:41:56] (03PS1) 10Bartosz Dziewoński: Remove unused dependency on jquery.suggestions [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/254053 [22:45:34] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Enable various core modules for mobile to make UploadWizard work - https://phabricator.wikimedia.org/T97202#1815313 (10matmarex) UW no longer uses jquery.ui (except for jquery.ui.selectable for Flickr uploads), will stop using jquery.validate after T96917 and T... [22:50:59] MatmaRex: I'm falling behind... [22:54:46] o/