[01:43:40] marktraceur: around? [01:44:22] prtksxna: Ish [01:44:27] prtksxna: What up [01:45:06] marktraceur: Trying to find the image manipulation libraries we talked about. Found a few, not very satisfied. Do know any? [01:45:54] prtksxna: For the frontend? Hrm. [01:46:04] I feel like doqpad/gfx might have something [01:46:08] Not something great [01:46:27] marktraceur: Yep. Most come with a UI. We just want something that affects the canvas, and maybe some UI for cropping [01:47:17] Right [01:47:19] Welllll [01:47:29] I am thinking something like Camanjs or Fabricjs. [01:47:51] And writing plugins for whatever we need [01:49:05] Camanjs was the first one I saw, yeah [01:49:34] The core mostly has filters. Needs plugins for rotation, cropping and flipping [01:49:52] But its much smaller than Fabricjs. 232kb vs 50kb. [01:50:06] Yeah [01:50:18] marktraceur: Cool. I'll look into Caman then. [01:53:44] prtksxna: So, if it would take significantly more effort to write in the rotation/cropping/flipping stuff for Caman, I'd say we can take the 182kb hit [01:54:08] And also plus too, I haven't fully finished my question of what transforms are actually useful [01:54:11] marktraceur: There are existing plugins [01:54:18] marktraceur: Yeah [01:54:34] I think my investigation so far has concluded "crop? pffft." [01:54:55] But rotation and mirror would be helpful at least, based on my very limited COM:VP discussion [01:55:18] marktraceur: Right, I saw [01:55:32] Makes things easier for us [01:58:11] Lil bit [01:58:48] Though I think really, if we're going to be experimenting anyway, and we have a month and a half left (minus holidays) to do so...might as well write a bloody crop tool too [01:59:01] If Commons looks at it and is like "whoa, bro, that's great" then we can release it [01:59:11] Yeah [01:59:55] We should also find out what kind of rotating they use mostly. 90 degress? rotate and crop in one tool (like in most mobile based image editors)? rotate with background image? [02:00:36] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Confusing annotation about mandatory fields in Special:UploadWizard - https://phabricator.wikimedia.org/T44775#1816067 (10matmarex) a:3matmarex I think this gets definitely solved with T96917 and T118906. [02:02:11] * prtksxna goes to make breakfast [02:16:02] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10Parsoid, and 4 others: Use content hash based image / thumb URLs - https://phabricator.wikimedia.org/T66214#1816102 (10bearND) Another example is T118978. [02:19:21] Can we use Caman? https://github.com/meltingice/CamanJS/blob/master/LICENSE [02:29:10] prtksxna: looks like https://en.wikipedia.org/wiki/BSD_licenses#3-clause_license_.28.22Revised_BSD_License.22.2C_.22New_BSD_License.22.2C_or_.22Modified_BSD_License.22.29 [02:29:29] so we probably can [07:25:38] prtksxna: My limited understanding of BSD and other permissive licenses is that they don't mind being bundled with other licenses. [07:26:20] And I did totally steal the structure for some of the includes/*.php files from mediawiki core so we're stuck with GPLv2 I think, unless we want to Be Bold with GPLv3. [07:28:48] marktraceur: You're still up :O [07:29:53] prtksxna: Not for looong [07:30:23] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Logging, and 3 others: Missing page id in the recentchanges list of https://commons.wikimedia.org/ for some upload logevents. - https://phabricator.wikimedia.org/T118433#1816442 (10LinJin) What's the state of this issue? [08:04:39] brion thedj: The interface of the video player uses https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FTimedMediaHandler/master/MwEmbedModules%2FEmbedPlayer%2Fresources%2Fskins%2Fkskin%2Fimages%2Fksprite.png, right? Would it make sense to skin it according to MediaWiki UI colors and icons? [08:58:59] prtksxna: did you find darkroomjs as well ? [08:59:15] thedj: https://www.mediawiki.org/wiki/Extension:ImageTweaks/UI [09:01:58] i like the structured modules approach of canvas transformations that darkroom takes. [09:02:47] just too bad they mix UI and logic though. [09:03:48] thedj: Yeah [09:04:12] thedj: The UI isn't bad either. But I don't want to add it to mediawiki's already confused personality [09:04:28] indeed. camanjs is probably better in this respect [09:07:46] thedj: Did you see my message about TMH? [09:08:57] ah, now i do. [09:11:18] prtksxna: honestly, i just want to dump that player. [09:11:43] thedj: Oh. By when do you want to replace it, and with what? [09:11:51] VideoJS [09:11:56] thedj: Weren't you working on dumping it during the Lyon hackathon? [09:12:03] and hopefully sometime next year. [09:12:15] yes, but there are a lot of pre requisites to actually doing it. [09:12:26] * prtksxna nods [09:12:41] for instance, just to able to migrate, we had to fix up the old player to not add itself to every single page. [09:13:15] Hmm [09:13:21] we have to improve our subs core, so we can switch to VTT subs [09:13:30] i want to switch it to contentmodel [09:13:53] and then we need to find a way to not break content caching all over the place when we do the actual switch. [09:15:06] Sounds like a lot [09:15:22] and i was sort of waiting for the new version of VideoJS to land properly, which took months longer than expected. [09:15:49] prtksxna: yup, but then at least we have a sane player, that could bring us into the future. [09:16:01] https://phabricator.wikimedia.org/T100106 [09:16:17] I'll check how the videojs player is skinned. If both need assets of some sort, I don't mind trying it out with Kaltura(?) and then skinning video js when we're ready [09:19:36] prtksxna: we need a design no matter what, so why not :) [09:20:15] thedj: :D [09:20:53] thedj: So the file that I pointed to would be correct. There are more in /resources, but no sprites, just the play and pause buttons [09:21:14] yes, the kskin is what we use right now. [09:23:11] Cool. Thanks thedj! [10:05:24] 6Multimedia, 6Commons, 10MediaWiki-File-management, 6operations: Image cache issue when 'over-writing' an image on commons - https://phabricator.wikimedia.org/T119038#1816638 (10Aklapper) [10:33:24] 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset: GWT - https://phabricator.wikimedia.org/T119053#1816669 (10Swiss-National-Library) 3NEW [10:41:52] 6Multimedia, 6Commons, 10MediaWiki-extensions-GWToolset: GWT - https://phabricator.wikimedia.org/T119053#1816680 (10Swiss-National-Library) [11:39:48] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Logging, and 3 others: Missing page id in the recentchanges list of https://commons.wikimedia.org/ for some upload logevents. - https://phabricator.wikimedia.org/T118433#1816758 (10Krenair) Fix should be deployed now... Please check that recen... [12:04:14] (03Abandoned) 10TheDJ: Automatically re-add transcode jobs if transcode pending for 72h [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/133994 (https://phabricator.wikimedia.org/T63401) (owner: 10Brian Wolff) [12:27:40] (03CR) 10TheDJ: "Of note is that the 'full click' of the image thumbnail was actually intentionally removed. I noticed that recently when I waded through s" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/250300 (https://phabricator.wikimedia.org/T117344) (owner: 10Gergő Tisza) [15:27:27] Good morning folks [15:27:33] prtksxna: Any more thoughts on libraries? [15:29:43] Hello marktraceur [15:30:07] Caman seems to be the way to go. [15:30:15] And making our own cropping UI shouldn't be too hard [15:31:46] Cool beans [15:32:19] Nothing new on COM:VP? [15:32:30] prtksxna: So you're looking into building that UI that you mocked up, then? [15:32:34] (checking now) [15:32:44] No, nothing on VP [15:32:49] Yep [15:33:25] marktraceur: I'll start next week. Have some Blueprint and Popups work for tomorrow [15:33:38] Plus, it'll give more time to the thread on vp [15:33:41] OK coolio [15:34:02] I guess I have some time on MatmaRex's patches. I almost forgot about that... [15:35:24] COM:VP is too busy hating on a tiny watchlist change that i merged last week [15:35:30] also, hi. [15:35:53] Whoa! I never knew https://www.mediawiki.org/wiki/VisualEditor/Backlog_design#Story_points [15:36:08] MatmaRex: o/ [15:36:13] MatmaRex: Are there any dialogs in VE that have a toolbar? [15:37:05] MatmaRex: Also, why does the movepage form have a border around it? [15:37:10] prtksxna: as in, the dialogs itself? a few dialogs display a small editing surface inside [15:37:20] prtksxna: for image caption, or basic reference contents [15:37:42] MatmaRex: Yep, I've seen those. I meant on the entire dialog [15:37:52] then afaik no [15:38:06] (i'm not sure how that would even look) [15:39:10] prtksxna: movepage… i guess it just does? it helps separate the form from all the useless text [15:39:29] MatmaRex: How *dare* you. [15:39:47] marktraceur: i'm the worst [15:48:19] MatmaRex: Makes sense, did you see https://phabricator.wikimedia.org/T113953#1807064 [15:48:49] We could get rid of the borders in that case [15:51:40] prtksxna: i've seen it, but i don't really have a strong opinion. [16:00:33] MatmaRex, joining us? [16:00:41] yep [17:58:17] (03CR) 10MarkTraceur: [C: 04-1] "Little things mostly" (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251179 (https://phabricator.wikimedia.org/T96917) (owner: 10Bartosz Dziewoński) [17:59:27] (03CR) 10MarkTraceur: "Notably, TextInputWidget has a 'required' option, but nothing else seems to. It might be a good idea to extend that to other field types, " [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251179 (https://phabricator.wikimedia.org/T96917) (owner: 10Bartosz Dziewoński) [18:14:12] (03CR) 10MarkTraceur: "Seems to work fine" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251179 (https://phabricator.wikimedia.org/T96917) (owner: 10Bartosz Dziewoński) [19:18:31] (03CR) 10MarkTraceur: Split off uw.DateDetailsWidget from UploadWizardDetails (introduce uw.DetailsWidget) (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251179 (https://phabricator.wikimedia.org/T96917) (owner: 10Bartosz Dziewoński) [19:51:05] (03CR) 10Bartosz Dziewoński: Split off uw.DateDetailsWidget from UploadWizardDetails (introduce uw.DetailsWidget) (033 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251179 (https://phabricator.wikimedia.org/T96917) (owner: 10Bartosz Dziewoński) [20:10:53] (03CR) 10MarkTraceur: [C: 032] "OK!" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251179 (https://phabricator.wikimedia.org/T96917) (owner: 10Bartosz Dziewoński) [20:14:34] (03Merged) 10jenkins-bot: Split off uw.DateDetailsWidget from UploadWizardDetails (introduce uw.DetailsWidget) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251179 (https://phabricator.wikimedia.org/T96917) (owner: 10Bartosz Dziewoński) [20:55:22] 6Multimedia, 10MediaWiki-General-or-Unknown, 10WikiEditor, 5Patch-For-Review: WikiEditor causing errors - https://phabricator.wikimedia.org/T118942#1818551 (10matmarex) Is the problem still occurring? I can't reproduce it. [21:17:03] 6Multimedia, 10MediaWiki-General-or-Unknown, 10WikiEditor, 5Patch-For-Review: WikiEditor causing errors - https://phabricator.wikimedia.org/T118942#1818618 (10Paladox) Yes for me. Workaround is to update moment. [21:17:44] 6Multimedia, 10MediaWiki-General-or-Unknown, 10WikiEditor, 5Patch-For-Review: WikiEditor causing errors - https://phabricator.wikimedia.org/T118942#1818619 (10Paladox) You must be on edit page for error to show js is unaffected if your not on edit page. [21:18:46] 6Multimedia, 10MediaWiki-General-or-Unknown, 10WikiEditor, 5Patch-For-Review: WikiEditor causing errors - https://phabricator.wikimedia.org/T118942#1818620 (10TheDJ) @Paladox, you really are the only one who is experiencing this as far as I can determine. [21:21:10] 6Multimedia, 10MediaWiki-General-or-Unknown, 10WikiEditor, 5Patch-For-Review: WikiEditor causing errors - https://phabricator.wikimedia.org/T118942#1818626 (10Paladox) @TheDJ oh I am not sure why I am experiencing this problem. I have websites across different servers and when I updated wikieditor the pro... [21:25:48] 6Multimedia, 10MediaWiki-General-or-Unknown, 10WikiEditor, 5Patch-For-Review: WikiEditor causing errors - https://phabricator.wikimedia.org/T118942#1818636 (10Paladox) Could I have help to trace it through my site. So I can find the module causing the problem because it says it is moment but may be becaus... [21:30:22] (03PS6) 10MarkTraceur: Split off uw.CategoriesDetailsWidget from UploadWizardDetails (improve warnings) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251180 (https://phabricator.wikimedia.org/T96917) (owner: 10Bartosz Dziewoński) [21:30:27] (03CR) 10MarkTraceur: [C: 032] Split off uw.CategoriesDetailsWidget from UploadWizardDetails (improve warnings) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251180 (https://phabricator.wikimedia.org/T96917) (owner: 10Bartosz Dziewoński) [21:32:13] 6Multimedia, 10MediaWiki-General-or-Unknown, 10WikiEditor, 5Patch-For-Review: WikiEditor causing errors - https://phabricator.wikimedia.org/T118942#1818646 (10Paladox) If I have these enabled # Enables use of WikiEditor by default but still allow users to disable it in preferences $wgDefaultUserOptions['u... [21:33:20] (03PS7) 10MarkTraceur: Split off uw.DescriptionsDetailsWidget from UploadWizardDetails (and OOUI-ize) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251181 (https://phabricator.wikimedia.org/T96917) (owner: 10Bartosz Dziewoński) [21:33:52] (03Merged) 10jenkins-bot: Split off uw.CategoriesDetailsWidget from UploadWizardDetails (improve warnings) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251180 (https://phabricator.wikimedia.org/T96917) (owner: 10Bartosz Dziewoński) [21:52:54] 6Multimedia, 10MediaWiki-General-or-Unknown, 10WikiEditor, 5Patch-For-Review: WikiEditor causing errors - https://phabricator.wikimedia.org/T118942#1818711 (10matmarex) 5Open>3Invalid a:3matmarex I looked into this and I am convinced that this problem is specific to your wiki. The load.php URL you li... [21:53:05] 6Multimedia, 10MediaWiki-General-or-Unknown, 10WikiEditor, 5Patch-For-Review: WikiEditor causing errors - https://phabricator.wikimedia.org/T118942#1818716 (10matmarex) [21:54:03] O.O UploadWizardDescription is all gone [22:07:39] (03CR) 10Bartosz Dziewoński: [C: 032] Split off uw.LocationDetailsWidget from UploadWizardDetails (and OOUI-ize) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251291 (https://phabricator.wikimedia.org/T96917) (owner: 10MarkTraceur) [22:09:32] I'm going to finish testing 251181, merge if applicable, then I have to fuck off [22:09:38] Maintaining the suspense, hooray [22:11:39] Hm, I tricked a tipsy bubble into staying around [22:11:42] But not on purpose [22:11:47] So I'm not sure how I can reproduce. [22:11:57] 6Multimedia, 10MediaWiki-General-or-Unknown, 10WikiEditor, 5Patch-For-Review: WikiEditor causing errors - https://phabricator.wikimedia.org/T118942#1818801 (10TheDJ) OK, I see it now on [[ http://en.random-wikisaur.tk/index.php?title=Information&action=edit | your site ]]. moment is being pulled in by med... [22:11:58] I doubt it has anything to do with this patch [22:12:46] (03CR) 10MarkTraceur: [C: 032] "Note about the language silliness but otherwise great" (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251181 (https://phabricator.wikimedia.org/T96917) (owner: 10Bartosz Dziewoński) [22:14:50] (03Merged) 10jenkins-bot: Split off uw.DescriptionsDetailsWidget from UploadWizardDetails (and OOUI-ize) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/251181 (https://phabricator.wikimedia.org/T96917) (owner: 10Bartosz Dziewoński) [22:15:28] marktraceur: it happens sometimes with the ones from category selector. it's on my todo list, there's a bug somewhere [22:18:04] It was after I submitted the form, if that helps [22:22:06] 6Multimedia, 10MediaWiki-General-or-Unknown, 10WikiEditor, 5Patch-For-Review: WikiEditor causing errors - https://phabricator.wikimedia.org/T118942#1818858 (10Paladox) CloudFlare is broken. Found the Auto Minify option and javascript enabled by default. Seems cloudflares minify is broken. [22:29:22] 6Multimedia, 10MediaWiki-General-or-Unknown, 10WikiEditor, 5Patch-For-Review: WikiEditor causing errors - https://phabricator.wikimedia.org/T118942#1818900 (10TheDJ) 5Invalid>3declined {F2977103} {F2977094} It breaks after the "https" link to github. [22:29:48] 6Multimedia, 10MediaWiki-General-or-Unknown, 10WikiEditor, 5Patch-For-Review: WikiEditor causing errors - https://phabricator.wikimedia.org/T118942#1818906 (10TheDJ) 5declined>3Invalid [22:31:31] 6Multimedia, 10MediaWiki-General-or-Unknown, 10WikiEditor, 5Patch-For-Review: WikiEditor causing errors - https://phabricator.wikimedia.org/T118942#1818939 (10Paladox) Thanks. Ive turned of minify for javascript since mediawiki has one and it was causing problems anyways. [22:39:00] 6Multimedia, 10UploadWizard, 5MW-1.27-release-notes, 5Patch-For-Review: Chunked/stashed uploads fail for some pdf and djvu files: "No specifications provided to ArchivedFile constructor." - https://phabricator.wikimedia.org/T94562#1818983 (10greg) >>! In T94562#1756807, @waldyrious wrote: > @matmarex does... [22:52:10] 6Multimedia, 10UploadWizard, 5Patch-For-Review, 5WMF-deploy-2015-12-01_(1.27.0-wmf.8): Split up the details class into multiple OOjs UI widgets in separate files - https://phabricator.wikimedia.org/T96917#1819079 (10Jdforrester-WMF) [22:52:22] Was my edit to the description of https://phabricator.wikimedia.org/T96917 helpful? [23:11:04] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Migrate deed chooser forms to OOjs UI - https://phabricator.wikimedia.org/T118906#1819182 (10matmarex) | Old: {F2977252} {F2977258} | New: {F2977243} {F2977249} | [23:11:50] it was, thanks