[00:03:51] prtksxna: good nite :) [00:16:46] (03PS4) 10Bartosz Dziewoński: Create arrow steps in JavaScript [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/255418 (https://phabricator.wikimedia.org/T96918) (owner: 10MarkTraceur) [00:16:48] (03PS3) 10Bartosz Dziewoński: Move remainder of UI creation into JS [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/255424 (https://phabricator.wikimedia.org/T96918) (owner: 10MarkTraceur) [00:17:18] thedj: :) [00:17:32] (03CR) 10Bartosz Dziewoński: [C: 032] Create arrow steps in JavaScript [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/255418 (https://phabricator.wikimedia.org/T96918) (owner: 10MarkTraceur) [00:18:58] (03CR) 10jenkins-bot: [V: 04-1] Move remainder of UI creation into JS [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/255424 (https://phabricator.wikimedia.org/T96918) (owner: 10MarkTraceur) [00:19:28] (03Merged) 10jenkins-bot: Create arrow steps in JavaScript [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/255418 (https://phabricator.wikimedia.org/T96918) (owner: 10MarkTraceur) [00:49:02] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Flickr uploads no longer work with this patch, and there are exceptions in the test suite." [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/255424 (https://phabricator.wikimedia.org/T96918) (owner: 10MarkTraceur) [00:49:45] Hmm. [00:50:17] (testing with https://www.flickr.com/photos/swallowtailgardenseeds/18375517709/) [00:52:29] I believe you [00:52:39] I maybe have spent too much time ignoring Flickr [00:52:44] Maybe it's time to bring it into the refactor fold [00:52:55] And/or make it make any kind of sense [00:52:56] At all [00:54:59] :O [00:55:15] i iz uzelss withouz the flickz uploadz [00:55:36] (03CR) 10Bartosz Dziewoński: "Also, there are no buttons to move to "thanks" step after finishing the upload. (At least if one of the files fails to publish.)" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/255424 (https://phabricator.wikimedia.org/T96918) (owner: 10MarkTraceur) [00:56:53] comets: Don't worry, we make sure they work [00:57:08] comets: Mostly they've just been neglected because they way they're written doesn't line up with the rest of the system [00:57:21] Because the system was designed poorly, in memory of another system we all know and love [00:57:52] whose? O_O boomis? :P [01:00:19] I was thinking MediaWiki [01:05:39] booims i knew and loved.....but ok [02:14:31] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Rewrite UploadWizard with mustache templates - https://phabricator.wikimedia.org/T96520#1843677 (10kaldari) [03:26:28] James_F|Away: marktraceur: prtksxna: i sent you all an unreasonably long email. please read it :) good night [03:26:43] I see, that's a good thing [03:27:44] I'm not going to talk you down, FWIW - I think you make good points [03:49:07] Well, I talked you a little down. [08:45:57] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Add support for installation with Composer - https://phabricator.wikimedia.org/T119248#1844081 (10Samwilson) Ah well. Do you have a link to the discussion about why Composer's not a good idea for this extension? Thanks for looking at this anyway! :) [10:08:12] 6Multimedia, 10MediaWiki-General-or-Unknown, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Show determinate progress bar for the image upload in mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T115861#1844174 (10Pginer-WMF) >>! In T115861#1842879, @Volker_E wrote: > What do y... [12:40:42] 6Multimedia, 6Commons, 10MediaWiki-File-management, 7Upstream: ImageMagick: Properly set alpha channel values for XCF Thumbnail - https://phabricator.wikimedia.org/T37622#1844485 (10jayvdb) [13:20:24] (03PS60) 10TheDJ: [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) [13:21:34] 6Multimedia, 10MediaWiki-extensions-MwEmbedSupport, 7JavaScript, 5Patch-For-Review, and 3 others: "Uncaught TypeError: Cannot read property 'insertRule' of undefined" from MwEmbedSupport/Spinner.js - https://phabricator.wikimedia.org/T118792#1844577 (10Krinkle) 5Open>3Resolved [13:24:24] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) (owner: 10TheDJ) [14:11:56] 6Multimedia, 6Commons, 10MediaWiki-File-management: isValidContainerName in /includes/filebackend/FileBackendStore.php not accepting databases starting with "_". - https://phabricator.wikimedia.org/T120071#1844616 (10Anomie) [14:58:06] I am taking advantage of no-meeting day to do my laundry! Thanks, no-meeting day. [15:03:46] 6Multimedia, 6Commons, 10MediaWiki-File-management: Renaming in Commons creates "No file by this name exists" message; works after reload - https://phabricator.wikimedia.org/T120054#1844745 (10Aklapper) [15:24:52] MatmaRex: Any thoughts on the goals? [15:30:21] (03PS61) 10TheDJ: [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) [15:31:57] marktraceur: i'm still thinking, but will reply. [15:32:02] KK [15:32:31] I think we have a pretty short amount of time to sort them out, sadly [16:39:10] (03PS1) 10MarkTraceur: Use promises instead of triggers for Flickr [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/256434 [17:10:25] Ugh, just got to FlickrChecker#getPhotos [17:10:28] Send rope [17:10:50] 6Multimedia, 10MediaWiki-extensions-MwEmbedSupport, 7JavaScript, 5Patch-For-Review, and 3 others: "Uncaught TypeError: Cannot read property 'insertRule' of undefined" from MwEmbedSupport/Spinner.js - https://phabricator.wikimedia.org/T118792#1845160 (10Krinkle) [17:11:36] hahaha [17:13:22] I'm running through and making these methods all return promises as a start [17:13:28] Sort of surveying it [17:15:12] (03PS1) 10MarkTraceur: Improve FlickrChecker docs, use promises [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/256447 [17:17:06] (03CR) 10jenkins-bot: [V: 04-1] Improve FlickrChecker docs, use promises [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/256447 (owner: 10MarkTraceur) [17:18:36] * marktraceur pokes grrrit-wm [18:02:41] I'm starting to think Flickr is more broken than I realized [18:04:03] (03PS2) 10MarkTraceur: Improve FlickrChecker docs, use promises [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/256447 [18:09:05] OK, whew, it's not broken in master [18:12:52] marktraceur: Ha. [18:14:11] (03PS3) 10MarkTraceur: Improve FlickrChecker docs, use promises [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/256447 [18:14:15] Better. [18:18:34] (03PS1) 10MarkTraceur: Consolidate some of the photo handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/256464 [18:20:29] (03CR) 10jenkins-bot: [V: 04-1] Consolidate some of the photo handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/256464 (owner: 10MarkTraceur) [18:20:37] I hate Jenkins [18:21:14] But it wuvs you! [18:24:48] James_F: marktraceur: replied. [18:24:49] :( [18:24:56] * James_F hugs. [18:26:02] TrevorParscal is going to send an e-mail soon saying we should just do one goal per team (the green, 'focus' one) in the published list, and have the others as things we work on as our "day job". [18:29:11] MatmaRex: https://gerrit.wikimedia.org/r/#/c/256127/ doesn't seem to fix the bug it's tagged with for me, unless I'm missing something? [18:29:30] (I.e., right click doesn't offer "paste".) [18:30:39] James_F: it mostly does for me. the still doesn't cover the *whole* field, but at least it covers most of it now. you might not get "Paste" if you click near the border. [18:31:18] I get it a few fixes away from an existing entry, but nowhere else. [18:31:39] James_F: i'm idly considering using contenteditable for that widget. managing the input is too much fuss. [18:31:50] That sounds… hard? [18:32:02] Oh, wait. [18:32:07] I had cached code. [18:32:09] James_F: i also considered making the be a "background" to the capsules, and positioning the text with padding [18:32:11] Yeah, it works beautifully. [18:32:24] oh, yeah, PS2 fixed some bugs. [18:48:57] (03PS1) 10Paladox: Update grunt-jscs to 2.4.0 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/256471 [18:50:36] (03PS2) 10Paladox: Update grunt-jscs to 2.4.0 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/256471 [19:15:12] 6Multimedia, 6Commons, 10MediaWiki-File-management: isValidContainerName in /includes/filebackend/FileBackendStore.php not accepting databases starting with "_". - https://phabricator.wikimedia.org/T120071#1845575 (10Tgr) [19:15:16] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Uploading, 5Patch-For-Review: Non-alphanumeric characters in wgDBname break file uploads - https://phabricator.wikimedia.org/T46066#495516 (10Tgr) [19:15:55] 6Multimedia, 6Commons, 10MediaWiki-File-management: Make image thumbnails interlaced whenever possible - https://phabricator.wikimedia.org/T120032#1845580 (10Tgr) [20:04:39] (03PS2) 10MarkTraceur: Consolidate some of the photo handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/256464 [20:06:14] (03CR) 10jenkins-bot: [V: 04-1] Consolidate some of the photo handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/256464 (owner: 10MarkTraceur) [20:06:19] Ugh [20:06:44] (03PS3) 10MarkTraceur: Consolidate some of the photo handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/256464 [20:08:26] (03CR) 10jenkins-bot: [V: 04-1] Consolidate some of the photo handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/256464 (owner: 10MarkTraceur) [20:09:19] (03PS4) 10MarkTraceur: Consolidate some of the photo handling [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/256464 [20:28:56] 6Multimedia, 10OOjs-UI, 10UploadWizard, 5OOjs-UI-next-release: CapsuleMultiSelectWidget's is tiny, making it difficult to right-click and paste - https://phabricator.wikimedia.org/T119781#1845739 (10Jdforrester-WMF) 5Open>3Resolved [20:29:54] brion: I made quite a few smaller improvements to the video.js player lib. esp. for audio. [20:30:39] Neat! [20:30:53] s/lib/patch [20:33:56] thedj, brion: How's that going, BTW? [20:34:02] Need help/support/cheerleading? [20:34:46] the biggest work there is going to be writing some extra plugins specific to us, and the html structure.... [20:35:35] thedj: James_F : I've got good contacts with the videojs folks and a pretty good idea how to start working on the plugins [20:35:51] Mainly its just pushing forward :) [20:35:59] and i'm wondering if we should merge what i have in the patch now... [20:36:41] James_F: wouldn't hurt to have an FTE or two dedicated to media playback and infrastructure :) [20:36:58] brion: I don't control Reading much. :-( [20:37:10] thedj: I'll look it over this afternoon [20:37:40] James_F: reading/editing split is very confusing to me, as all this infrastructure is needed for both [20:38:03] I don't grok our verticals still [20:38:07] brion: btw. i've been noticing that issue where sometimes the video requests seem to stall... [20:38:22] brion: Upload, edit, describe, meta-data == Editing. [20:38:39] brion: View/render == Reading. [20:38:47] * thedj suspects a problem with partial content requests... [20:38:58] brion: But, umm, galleries? Us. Paginated content? Us, maybe? Eh. [20:39:03] It's a bit messy. [20:39:08] So, every content related project requires both departments? [20:39:35] thedj: possible... They're notoriously janky [20:39:52] We may need to bring ops in to debug that issue [20:40:08] brion: Let's not even get to the point of asking who is responsible for Wikiversity vs. Wikinews vs. … [20:40:14] Hehe [20:43:56] brion: Everything is terrible, send help [20:44:12] :) [20:44:14] I still don't feel like Reading has properly committed to MMV. [20:44:21] Maybe I'm wrong, but seriously [20:45:01] Well. [20:45:09] They have three "MediaViewer"s. [20:45:11] marktraceur: I thought MMV was abandonware, now that its done :P [20:45:20] The desktop one, the mobile web one, and the one in Android. [20:45:21] Isn't that the life cycle of features? [20:45:26] And I think there's one in iOS too. [20:45:37] So hardly abandoned. Quadrupled-down. [20:46:05] bawolff: That would certainly make software engineering a nice job to have [20:46:38] Well, nicer. [20:48:00] anyone know of a way to override overflow:hidden set on a parent element ???? [20:48:42] well last non-trivial change was a month and a half ago, certainly not actively developed [20:49:21] thedj: Like, you want the child element to have a different overflow, or you want the parent element to have a different overflow if a particular child element is present? [20:49:52] i want the child to be able to ignore that the parent wants to clip it's contents :) [20:50:04] I don't think you can [20:50:04] Doesn't really answer my question [20:50:18] marktraceur: last one [20:50:22] OK [20:50:23] bawolff: EditPage.php isn't actively developed. Doesn't mean it's abandonned. [20:50:26] thedj: Yeah that's not a thing [20:50:43] thedj: You're going to need to use JS or set the parent's classes conditionally or something [20:51:13] James_F: EditPage.php isn't the best example, as its been not using current conventions for something like 7 years now [20:51:32] bawolff: It was intentionally picked. :-) [20:51:36] James_F: I thought that was deprecated anyway? :) [20:51:38] i guess i'll have to set an extra class with JS on the parent then [20:51:58] marktraceur: 90% of the "edit API" is just RPC on EditPage.php via a stateless HTTP API. Yuck. [20:52:16] Sounds about right [20:52:56] marktraceur: My favourite "API" is getCheckboxes [20:53:25] It returns HTML. Good luck if you're not HTML-based, like the iOS app. [20:53:36] From HTMLForm? [20:53:45] categorieshtml :D [20:53:51] marktraceur: EditPage::getCheckboxes [20:53:55] Eugh [20:54:06] Yeah. [20:54:17] VE has to decode it (thanks to MatmaRex being awesoem it looks nice). [20:55:42] Sigh. [20:55:53] marktraceur: Don't worry, not your problem. [20:55:59] Well. Not yet. :-) [20:56:03] When are we releasing MediaWiki 2.0 written in Rust, again? [20:56:24] I need to find a way to claim that re-writing all of MediaWiki is a "Multimedia Editing" task. :-) [20:58:02] Multimedia = multiple media. Text = a single type of media. Can't have multiple media without at least one media. Hence Multimedia editing is related to all things mediawiki does ;) [20:58:16] Bam. [20:58:24] bawolff: Are you angling for a deathmarch job? ;-) [20:58:27] James_F: This is how we can finally get a backend coder! :) [20:58:32] * James_F grins. [20:58:33] bawolff: You're not busy right? :) [20:59:23] I'm happily finding ways to break MediaWiki currently :) [20:59:31] * James_F grins. [21:00:32] Hmm. I'll give +2 rights to OOUI to someone who is happy to merge a patch of mine. Sound fair? ;-) [21:00:54] silence..... [21:00:59] * James_F grins. [21:01:12] I know Doxygen is terrible but… gnargh.https://gerrit.wikimedia.org/r/#/c/254492/ [21:01:59] Don't look at me [21:02:35] Oh well. [21:10:38] (03PS4) 10MarkTraceur: Move remainder of UI creation into JS [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/255424 (https://phabricator.wikimedia.org/T96918) [21:10:58] MatmaRex: That fixes the Flickr uploads, but I'm not sure I can reproduce your upload failure issue [21:11:57] I always forget how to screw it up on the last step, most of the non-catastrophic errors trigger way earlier in the process now [21:12:12] So beyond, like, turning off apache [21:12:16] Ooh, I'll just do that [21:12:57] (03CR) 10jenkins-bot: [V: 04-1] Move remainder of UI creation into JS [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/255424 (https://phabricator.wikimedia.org/T96918) (owner: 10MarkTraceur) [21:13:31] Huh, thought I fixed everything [21:14:10] Hm, turning off apache ends the process on master too [21:15:23] (03PS5) 10MarkTraceur: Move remainder of UI creation into JS [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/255424 (https://phabricator.wikimedia.org/T96918) [21:16:32] I guess we could fix that, put in a button that's like "pfft I don' care, try again dummy" [21:16:51] We could call it #mwe-upwiz-marktraceur-turned-off-apache-continue-anyway [21:20:41] James_F: Have we made any changes to the goals? Are we going to? [21:20:54] marktraceur: "Made". [21:21:44] Err [21:22:28] James_F: I missed a nuance or two there [21:23:28] marktraceur: I don't know what your question is. [21:23:52] James_F: Maybe I can answer it myself, one tick. [21:24:27] OK, I think I'm mostly OK with how they look on the document, so that does indeed answer my question [21:27:31] But we clearly don't have agreement on them being what we all want to do, even with the changes that people have made. :-( [21:28:47] Yeah, I dunno [21:28:59] James_F: More proactive goals discussions next quarter for sure. [21:29:08] Ideally. :-) [21:30:16] (03PS63) 10TheDJ: [WIP] Using VideoJS instead of Kaltura player [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/212981 (https://phabricator.wikimedia.org/T100106) [21:41:29] 6Multimedia, 6Commons, 10MediaWiki-File-management: Make image thumbnails interlaced whenever possible - https://phabricator.wikimedia.org/T120032#1846006 (10Bawolff) >time/memory overhead on the rendering server. For large files this could be significant. (E.g. for PNG interlacing (Adam7) seven consecutive... [21:56:04] 6Multimedia, 6Commons, 10MediaWiki-File-management: Make image thumbnails interlaced whenever possible - https://phabricator.wikimedia.org/T120032#1846065 (10Tgr) >>! In T120032#1846006, @Bawolff wrote: > Also, if we ever have to resize the file, interlaced jpegs take much more memory to resize then non-inte... [21:57:22] 6Multimedia, 10UploadWizard, 5Patch-For-Review: Add support for installation with Composer - https://phabricator.wikimedia.org/T119248#1846068 (10Samwilson) Thanks. Lots to read! Very interesting... [21:58:33] 6Multimedia, 6Commons, 10MediaWiki-File-management: Make image thumbnails interlaced whenever possible - https://phabricator.wikimedia.org/T120032#1846070 (10Bawolff) >>! In T120032#1846065, @Tgr wrote: >>>! In T120032#1846006, @Bawolff wrote: >> Also, if we ever have to resize the file, interlaced jpegs tak... [22:04:51] tgr: http://upload.beta.wmflabs.org/wikipedia/commons/thumb/2/29/Red_pog_03.svg/446px-Red_pog_03.svg.png is odd. Both 445 and 447 are ok. It wouldn't surprise me if that's something messed up with beta wiki [22:08:18] 6Multimedia, 6Commons, 10MediaWiki-File-management: Make image thumbnails interlaced whenever possible - https://phabricator.wikimedia.org/T120032#1846087 (10Tgr) >>! In T120032#1846070, @Bawolff wrote: > I meant server. e.g. If we ever do resize chaining. We would just have to make sure that it's only done... [22:17:04] 6Multimedia, 10Beta-Cluster-Infrastructure, 6Commons, 10MediaWiki-File-management, 5Patch-For-Review: Images with extra parameters (e.g. low-quality JPEG) are not rendered in beta - https://phabricator.wikimedia.org/T71757#1846118 (10Tgr) [22:24:24] 6Multimedia, 10Beta-Cluster-Infrastructure, 6Commons, 10MediaWiki-File-management: Thumbnail generation should happen via the same setup in the beta cluster and in production (tracking) - https://phabricator.wikimedia.org/T84950#1846144 (10Ricordisamoa) [22:25:37] marktraceur, MatmaRex: -office RfC discussion on replacing
with
for images in read HTML may be interesting. [23:30:16] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-extensions-MultimediaViewer: MediaViewer intermittent image loading errors (2015 Oct-Dec) - https://phabricator.wikimedia.org/T115563#1846391 (10Jdlrobson) What are the next steps with this card? Could you add a checklist to the description of...