[00:15:15] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 5MW-1.27-release-notes, and 3 others: Properly use language templates in cross-wiki upload - https://phabricator.wikimedia.org/T119691#1860903 (10zhuyifei1999) >>! In T119691#1858906, @Jdforrester-WMF wrote: >> Please elaborate why it is "broken" wkitext. > >... [01:01:13] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 5MW-1.27-release-notes, and 3 others: Properly use language templates in cross-wiki upload - https://phabricator.wikimedia.org/T119691#1861131 (10Tgr) @Jdforrester-WMF I guess the question is whether we would rather confuse users by adding a strange `1=` to the... [01:09:49] (03CR) 10Legoktm: [C: 032] Remove begin/commit from onTitleMoveComplete() hook [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257501 (owner: 10Aaron Schulz) [01:11:20] (03Merged) 10jenkins-bot: Remove begin/commit from onTitleMoveComplete() hook [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257501 (owner: 10Aaron Schulz) [01:14:15] 6Multimedia: create tool to crunch metrics for views (play started) of video and audio files - https://phabricator.wikimedia.org/T116363#1861147 (10matmarex) I'm surprised that this got assigned to me suddenly? I guess you want me to work on this? Why was I chosen? :P Based on some very crude estimates, it look... [01:16:14] marktraceur: https://gerrit.wikimedia.org/r/257366 merrrrge [01:33:18] (03CR) 10MarkTraceur: [C: 032] mw.UploadWizardDetails: Do not double-escape campaign fields' labels [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257366 (owner: 10Bartosz Dziewoński) [01:33:23] Aye aye sir [01:35:07] (03Merged) 10jenkins-bot: mw.UploadWizardDetails: Do not double-escape campaign fields' labels [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257366 (owner: 10Bartosz Dziewoński) [03:43:19] (03PS1) 10Yuvipanda: Fix minor typo in comment [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257545 [03:44:01] I didn't know yuvipanda was doing GCI [04:40:35] marktraceur: dang, that was cold [04:42:50] 6Multimedia, 10Wikimedia-Developer-Summit-2016, 10Wikimedia-Video: WikiDev16: Next generation video for Wikipedia and friends [backend] - https://phabricator.wikimedia.org/T118911#1861335 (10RobLa-WMF) [04:55:56] 6Multimedia, 10Wikimedia-Developer-Summit-2016, 10Wikimedia-Video: WikiDev16: Next generation video for Wikipedia and friends [backend] - https://phabricator.wikimedia.org/T118911#1861348 (10RobLa-WMF) a:3TheDJ [05:42:33] Hydronium: love them sick burns yo [05:59:46] * Hydronium adds to https://meta.wikimedia.org/wiki/IRC/Quotes [06:33:47] (03CR) 10Legoktm: [C: 032] Fix minor typo in comment [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257545 (owner: 10Yuvipanda) [06:36:29] (03Merged) 10jenkins-bot: Fix minor typo in comment [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257545 (owner: 10Yuvipanda) [07:25:11] 6Multimedia, 10MediaWiki-extensions-MwEmbedSupport, 7JavaScript, 5Patch-For-Review, and 4 others: "Uncaught TypeError: Cannot read property 'insertRule' of undefined" from MwEmbedSupport/Spinner.js - https://phabricator.wikimedia.org/T118792#1861458 (10TheDJ) I wonder if this issue was the result of async... [08:51:31] 6Multimedia, 10MediaWiki-Uploading, 7Community-Wishlist-Survey: Enhance image uploading process - https://phabricator.wikimedia.org/T120745#1861559 (10Reedy) [15:36:19] 6Multimedia, 10UploadWizard, 3Google-Code-In-2015, 7I18n: Messages mwe-upwiz-error-too-short and mwe-upwiz-error-too-long are reused, sometimes passed wrong parameters - https://phabricator.wikimedia.org/T118902#1862307 (10matmarex) [15:40:30] 6Multimedia, 10MediaWiki-Uploading, 7Community-Wishlist-Survey: Enhance image uploading process - https://phabricator.wikimedia.org/T120745#1862325 (10matmarex) So… the proposal is basically asking to have UploadWizard enabled on more wikis? I'd update the task title, but I don't want to interfere with the s... [15:41:33] 6Multimedia, 10MediaWiki-General-or-Unknown, 10VisualEditor: Show not logged in error before uploading to stash in mw.Upload.BookletLayout - https://phabricator.wikimedia.org/T115866#1862327 (10matmarex) [15:41:36] 6Multimedia, 10VisualEditor, 10VisualEditor-Media: MWMediaDialog: exception "Local uploads are disabled" - https://phabricator.wikimedia.org/T119314#1862326 (10matmarex) [16:02:08] MatmaRex: Joining us? [16:02:26] agh, yes. [16:02:29] :) [16:06:54] MatmaRex: https://phabricator.wikimedia.org/T77826 [16:07:49] I looked at it and thought to myself "geez, not sure how I want that to interact with OOUI" [16:07:55] So hopefully you'll have thoughts [16:08:05] Part of me wanted a form saver thing *in* OOUI [16:09:54] prtksxna: I'll look at the prototype now, hopefully post to wikitech soon after [16:10:26] marktraceur: hmm. you should be able to easily get the contents of everything with the getSerialized() methods [16:10:35] the same thing we use for metadata copier [16:10:59] marktraceur: Cool. I'll eat dinner and try to solve the crop-undo issue (not the same issue as before). [16:11:09] marktraceur: So you could wait till I fix it…maybe? [16:11:15] Oh, sure [16:12:07] marktraceur: basically, allTheData = details.getAllFields().map(function(field){ return field.getSerialized() }) [16:12:22] I guess that's true now [16:12:25] Hot damn [16:12:27] marktraceur: and to set them back, details.getAllFields().map(function(field, i){ return field.setSerialized( allTheData[i] ) }) [16:13:00] marktraceur: although, that might not play very well with campaigns, or custom deeds. [16:13:17] basically, if the fields in the UpWizDetails object are different. [16:13:18] MatmaRex: Or setting back data when the files are in a different order, or some are missing, or whatever [16:13:42] Have to save it with the filekey, too, because refreshing would destroy the filename [16:13:53] yeah. you might need to make this a little bit smarter [16:14:00] but it looks entirely possible to implement [16:16:42] K! [16:17:39] prtksxna: speaking of testing cross-wiki things, i'm actually trying right now to set up two vanilla Ubuntu VMs (non-Vagrant) to talk to each other, i've finally gotten fed up with how broken beta labs debug mode is. will report back with findings. :P [16:18:07] Thanks MatmaRex! [16:51:23] Hmm, did my mail to wikitech make it through? [16:52:00] It's not in the archive [16:52:02] Weird [16:53:43] is there a way to quickly create a oo.ui dialog from the browser console ? [16:56:20] hmm, doesn't seem so.. i'll just have to code up something when i get home, instead of 'toying' about.. [16:57:37] thedj: You'll need at least a couple of lines [16:58:58] yeah, i'll look later. I'm still at work, can't edit entire wiki installs from here :) [17:00:04] thedj: :) [17:08:11] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10Parsoid, and 5 others: Use content hash based image / thumb URLs & define an official thumb API - https://phabricator.wikimedia.org/T66214#1862573 (10Anomie) >>! In T66214#1854415, @GWicke wrote: > Based on the earlier discussion with @brion (especially... [17:14:26] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10Traffic, and 2 others: Image cache issue when 'over-writing' an image on commons - https://phabricator.wikimedia.org/T119038#1862587 (10BBlack) This was merged in the SWAT that happened around 00:00-01:00 UTC Dec 8 (so about 17 hours before this post).... [17:22:30] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10Parsoid, and 5 others: Use content hash based image / thumb URLs & define an official thumb API - https://phabricator.wikimedia.org/T66214#1862594 (10Anomie) [18:07:21] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10Parsoid, and 5 others: Use content hash based image / thumb URLs & define an official thumb API - https://phabricator.wikimedia.org/T66214#1862757 (10Ciencia_Al_Poder) >>! In T66214#1862573, @Anomie wrote: > Why do you only want to support //square// bo... [18:35:15] \o/ [18:35:48] I was replacing the canvas manually and not calling Caman's replaceCanvas(), so it would pass the incorrect ImageData during undo/redos [19:10:00] (03CR) 10Jdlrobson: [C: 032] Do not set up the overlay on irrelevant hash changes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/256841 (https://phabricator.wikimedia.org/T119854) (owner: 10Gergő Tisza) [19:12:03] (03Merged) 10jenkins-bot: Do not set up the overlay on irrelevant hash changes [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/256841 (https://phabricator.wikimedia.org/T119854) (owner: 10Gergő Tisza) [19:15:11] 6Multimedia, 10MediaWiki-General-or-Unknown, 10VisualEditor, 5Patch-For-Review: Show not logged in error before uploading to stash in mw.Upload.BookletLayout - https://phabricator.wikimedia.org/T115866#1863056 (10matmarex) a:3matmarex [19:15:24] 6Multimedia, 10VisualEditor, 10VisualEditor-Media, 5Patch-For-Review: MWMediaDialog: exception "Local uploads are disabled" - https://phabricator.wikimedia.org/T119314#1863058 (10matmarex) a:3matmarex [19:23:02] vagrant up-ing the new instance now and going to bed. [19:23:15] marktraceur: Does anything in ImageEditor need fixing? [19:31:50] prtksxna: Well, how detailed a review do you want...it's a prototype, I assume code issues can get fixed later, little bugs are fine [19:32:24] marktraceur: As detailed as you'd think it should be before posting? [19:32:42] Honestly I pushed most of the buttons and my browser didn't crash, I'm good with that [19:32:58] marktraceur: Cool [19:37:04] prtksxna: Did you want me to send the wikitech mail, or will you? [19:37:19] (☞ﾟヮﾟ)☞ D O I T ! [19:38:03] marktraceur: *YOU [19:38:20] Neat [19:40:23] prtksxna: Actually, can you verify that you got my wikitech mail on the appreciation thread? I never saw it on the archives and I didn't get a bounce mail, I think [19:41:13] marktraceur: The last one I see is by kart_, 15 hours ago [19:41:18] Balls. [19:49:16] marktraceur: Step one, fix your e-mail. [19:51:20] James_F: If I write it and send it and it doesn't get through, that's fine, I can diagnose and resend once I fix it [19:51:27] * James_F grins. [19:55:42] OK sent, if anyone sees it, do please confirm [19:57:17] 6Multimedia, 10UploadWizard, 7Easy, 7I18n: Clarify wording in dialog about unsupported file types which mentions Firefox and Firefogg - https://phabricator.wikimedia.org/T116003#1863341 (10Nemo_bis) [19:58:06] 6Multimedia, 10UploadWizard, 7Design, 7I18n: UploadWizard strings are skewed towards images (though e.g. also PDFs can be uploaded) - https://phabricator.wikimedia.org/T117795#1863346 (10Nemo_bis) [20:00:04] Feeeck. [20:03:17] God damn it Thunderbird [20:29:55] 6Multimedia, 10MediaWiki-Uploading, 7JavaScript: Make it harder for users to misunderstand or ignore the licensing agreement in the upload dialog - https://phabricator.wikimedia.org/T120867#1863551 (10MarkTraceur) 3NEW [20:32:06] marktraceur: your mail is stuck in moderation [20:32:20] still having trouble accessing the admin interface? [20:36:07] tgr: Yeah I see that, I'm trying to get a local smtp server working because gmail is a lying whore [21:01:34] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 7JavaScript: Make it harder for users to misunderstand or ignore the licensing agreement in the upload dialog - https://phabricator.wikimedia.org/T120867#1863737 (10Josve05a) [21:08:09] FUCKING EMAIL IS THE WORST [21:08:31] I now have Thunderbird fetching IMAP messages from gmail and sending mail through Riseup because gmail is a little bitch [21:09:02] But at least the email went through this time. [21:16:17] I'm going to go take my anger out on some pizza rolls [21:20:27] * James_F grins. [21:59:19] 6Multimedia, 10OOjs-UI, 10UploadWizard, 5OOjs-UI-0.14.1, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): CapsuleMultiSelectWidget's is tiny, making it difficult to right-click and paste - https://phabricator.wikimedia.org/T119781#1863905 (10Jdforrester-WMF) [22:00:25] hello everyone [22:00:36] Is "It is recommended that you properly fill in all of the fields. Do you want to continue without filling all the fields?" redundant? [22:02:34] Hydronium: Maybe "It is recommended that you properly fill in all of the fields. Do you want to continue without doing so?" [22:03:12] OK [22:03:34] * James_F doesn't have a strong opinion. [22:04:58] Yeah, it could be shorter I guess [22:05:34] How about "The date that you selected is in the future." for post-dating a file? [22:09:28] (03PS1) 10Aaron Schulz: Remove begin/commit from onArticleDeleteComplete() [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257759 [22:11:32] (03CR) 10jenkins-bot: [V: 04-1] Warning when file date is in the future [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257760 (https://phabricator.wikimedia.org/T117117) (owner: 10Sn1per) [22:12:22] (03PS2) 10Sn1per: Warning when file date is in the future [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257760 (https://phabricator.wikimedia.org/T117117) [22:15:01] (03CR) 10jenkins-bot: [V: 04-1] Warning when file date is in the future [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257760 (https://phabricator.wikimedia.org/T117117) (owner: 10Sn1per) [22:15:19] ugh [22:18:57] (03PS1) 10Legoktm: Campaigns: Add templatelinks through ParserOutput [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257763 [22:21:52] (03PS1) 10Legoktm: Don't use a hook to add CSS to Campaign pages [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257765 [22:22:40] (03PS3) 10Sn1per: Warning when file date is in the future [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257760 (https://phabricator.wikimedia.org/T117117) [22:27:03] All hail Lord Jenkins [22:27:07] jenkins has been satisfied [22:27:55] * Hydronium kowtows [22:46:12] (03CR) 10Aaron Schulz: [C: 04-1] Campaigns: Add templatelinks through ParserOutput (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257763 (owner: 10Legoktm) [22:46:31] (03CR) 10Aaron Schulz: "Ah, wait the change here too" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257763 (owner: 10Legoktm) [22:51:13] (03CR) 10Aaron Schulz: Campaigns: Add templatelinks through ParserOutput (032 comments) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257763 (owner: 10Legoktm) [22:52:41] (03PS2) 10Legoktm: Campaigns: Add templatelinks through ParserOutput [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257763 [22:52:46] (03CR) 10Legoktm: Campaigns: Add templatelinks through ParserOutput (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257763 (owner: 10Legoktm) [22:53:37] (03PS3) 10Legoktm: Campaigns: Add templatelinks through ParserOutput [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257763 [22:55:46] (03CR) 10Aaron Schulz: [C: 032] Campaigns: Add templatelinks through ParserOutput [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257763 (owner: 10Legoktm) [22:57:33] (03Merged) 10jenkins-bot: Campaigns: Add templatelinks through ParserOutput [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257763 (owner: 10Legoktm) [23:02:04] (03PS1) 10Aaron Schulz: Remove unnecessary begin()/commit() pair in onPageContentSaveComplete [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257770 [23:29:38] (03CR) 10Krinkle: [C: 032] Remove begin/commit from onArticleDeleteComplete() [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257759 (owner: 10Aaron Schulz) [23:32:08] (03Merged) 10jenkins-bot: Remove begin/commit from onArticleDeleteComplete() [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257759 (owner: 10Aaron Schulz) [23:32:22] (03CR) 10Jforrester: [C: 031] Warning when file date is in the future (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257760 (https://phabricator.wikimedia.org/T117117) (owner: 10Sn1per) [23:39:46] (03CR) 10Krinkle: Remove unnecessary begin()/commit() pair in onPageContentSaveComplete (031 comment) [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257770 (owner: 10Aaron Schulz)