[00:09:38] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 7JavaScript, 5Patch-For-Review: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool - https://phabricator.wikimedia.org/T120867#1876812 (10Josve05a) >>! In T120867#1876793, @matmarex wrote: > Experienced users (>= 10 edits in... [00:11:47] 6Multimedia, 10Ops-Access-Requests, 6operations: Give Bartosz access to stat1003 ("researchers" and "statistics-users") - https://phabricator.wikimedia.org/T119404#1876813 (10matmarex) Thank you, it all works fine. >>! In T119404#1829716, @matmarex wrote: > Full name: Bartosz Dziewoński > Wikitech page: ht... [00:13:07] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 7JavaScript, 5Patch-For-Review: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool - https://phabricator.wikimedia.org/T120867#1876814 (10matmarex) Counting edits on Commons only. [03:05:38] MatmaRex: The higher deletion rate for experienced users is more baffling :O [03:12:54] prtksxna: yeah, i really don't know what to make of that. [06:32:34] 6Multimedia, 6Commons, 10MediaWiki-File-management, 7Easy: Download this file link on description page (particularly relevant to svg) - https://phabricator.wikimedia.org/T27148#1877024 (10Tgr) By "download URL" I meant an URL that downloads the image on left-click, instead of opening it. I thought that was... [11:31:24] 6Multimedia, 10MediaWiki-Gallery, 7Design: No way to access image in packed gallery with long descriptions - https://phabricator.wikimedia.org/T93393#1877320 (10Perhelion) Another example with (`mode="packed-hover"`) small images https://de.wikipedia.org/wiki/Benutzer:Ollemarkeagle#Brandenburg I guess this... [15:08:06] OK, I was very busy over the weekend, what did I miss [15:17:50] morning marktraceur. not very much, i guess. [15:18:15] I saw the description campaign bug pop up on IRC while I was at Ikea [15:18:31] marktraceur: you missed me discovering that the deletion ratio for cross-wiki uploads by experienced users is much higher than that of new users, for as yet inexplicable reasons. [15:18:49] Weird [15:18:57] Based on edit count? [15:19:25] yeah, less than / equal to or greater than 10 edits [15:20:57] but also when looking at first-time or not uploads [15:41:06] Looks like my anomie review was pretty much OK [15:41:12] That's a good way to start the day [16:00:55] marktraceur: merge https://gerrit.wikimedia.org/r/#/c/258767/ ? [16:02:10] (03CR) 10MarkTraceur: [C: 032] mw.UploadWizardDetails: Don't fail when 'description' is given, but 'descriptionlang' isn't [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/258767 (https://phabricator.wikimedia.org/T121340) (owner: 10Bartosz Dziewoński) [16:04:42] (03Merged) 10jenkins-bot: mw.UploadWizardDetails: Don't fail when 'description' is given, but 'descriptionlang' isn't [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/258767 (https://phabricator.wikimedia.org/T121340) (owner: 10Bartosz Dziewoński) [16:13:29] MatmaRex: So what do you need from me on that patch aside from review? [16:15:15] marktraceur: i think i've got it under control code-wise, i'm mostly hoping someone will improve/make the content for options 3 and 4 [16:15:33] OK, and James is on it [16:15:42] I'm going to start looking at code and the discussion then [16:15:47] James_F: marktraceur: also, it would be nice to have it translated, and run the test in some more languages. any of you speak spanish? :P [16:18:05] Nein. [16:18:19] What, that's Japanese. Apparently it's worse than I thought. [16:18:53] Besides, we need a native speaker to translate. [16:19:04] Where's pginer when we need him!? [16:19:20] Oh. In the channel. [16:29:28] MatmaRex: For re-wording, how about: [16:29:30] [N] Did you download this image from a website, or get it from an image search? [16:29:30] [Y] Did you create this image (take the photo, sketch the drawing, …) yourself? [16:29:30] [N] Does it contain, or is it inspired by, work owned by anyone else, like a logo? [16:29:32] [Y] Will this image help educate, instruct or inform people about something? [16:33:34] James_F: hmm, so content-wise, basically the same as 2? [16:33:57] MatmaRex: Yeah. You think that's a mistake? [16:34:23] i think it's fine [16:35:42] i'm not sure if we really need to make "own work" and "no derivatiees" two separate questions [16:36:12] If you drew it but it's "inspired by" a cartoon it's also no good. [16:36:41] (actually, it's fairly different from 2, on a closer look.) [16:36:54] Yeah, they're mutually inspired but a bit different. [16:38:40] James_F: we can't really explain the nuances of drawing characters from cartoons in two lines of text, though. the logo is a better example, but then, neither can we explain the nuances of logos. [16:38:49] Sure. [16:38:59] But better to be a low pass filter than a high pass filter. [16:39:35] i liked the wording of "no work by anyone else" from option 2, which should unambiguously reject album covers, film posters and the like [16:39:52] "By". [16:39:58] "I took this photo, it's by me!" [16:40:00] anyway, i think they're great. let's do it and see how it turns out [16:40:04] OK. [16:40:11] We can always tweak later. [16:40:18] James_F: yeah, but people don't take photos of those, they download them from google image search. :P [16:40:32] Sometimes they do. :-) [16:48:32] (03PS1) 10Thcipriani: mw.UploadWizardDetails: Don't fail when 'description' is given, but 'descriptionlang' isn't [extensions/UploadWizard] (wmf/1.27.0-wmf.8) - 10https://gerrit.wikimedia.org/r/259006 (https://phabricator.wikimedia.org/T121340) [16:51:43] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/UploadWizard] (wmf/1.27.0-wmf.8) - 10https://gerrit.wikimedia.org/r/259006 (https://phabricator.wikimedia.org/T121340) (owner: 10Thcipriani) [16:53:41] (03Merged) 10jenkins-bot: mw.UploadWizardDetails: Don't fail when 'description' is given, but 'descriptionlang' isn't [extensions/UploadWizard] (wmf/1.27.0-wmf.8) - 10https://gerrit.wikimedia.org/r/259006 (https://phabricator.wikimedia.org/T121340) (owner: 10Thcipriani) [16:59:56] (03PS1) 10Thcipriani: Revert "mw.UploadWizardDetails: Don't fail when 'description' is given, but 'descriptionlang' isn't" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/259014 [17:21:56] 6Multimedia, 10UploadWizard, 5Patch-For-Review, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8), 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Upload wizard on Commons fails to process uploads with the "description" field - https://phabricator.wikimedia.org/T121340#1878081 (10matmarex) 5Open>3Resolved The fix has bee... [17:39:27] (03Abandoned) 10Thcipriani: Revert "mw.UploadWizardDetails: Don't fail when 'description' is given, but 'descriptionlang' isn't" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/259014 (owner: 10Thcipriani) [18:00:26] MatmaRex: I don't understand, how is the bucket stored? In the request logs? [18:02:34] James_F: one more time about the option 3 questions. i'm not convinced that the last one is good, at least not without some other wording changes. it doesn't seem to match the wordingof the message displayed when "wrong" answer is selected. https://i.imgur.com/cw07iFd.png (it's also long enough to cause scrollbars) [18:03:00] marktraceur: it's generated based on user id, so we don't need to store it client-side. server-side, it's saved in a change tag on the upload (see the WIkimediaEvents patch). [18:03:19] (it's not really necessary, since we could reconstruct it from the user id, but that'd be a pain) [18:03:20] Oh, brilliant. [18:03:48] clever, yes, ori suggested this [18:03:55] MatmaRex: What about people using the debug query string? Won't the backend still save the bucket? [18:04:06] I guess the referer header should show the query string [18:04:14] marktraceur: no, it's iffed-out, unless i coded it wrong [18:04:25] I believe in you [18:04:28] marktraceur: search for 'shouldRecordBucket' [18:05:02] (i'm amending the patch now, btw) [18:05:15] KK [18:14:14] 6Multimedia, 10Internet-Archive, 10MediaWiki-DjVu, 10MediaWiki-extensions-MultimediaViewer: Add support for Internet Archive BookReader - https://phabricator.wikimedia.org/T121108#1878347 (10Jdlrobson) p:5Triage>3Low [18:17:01] MatmaRex: Hmm. Maybe drop it? [18:18:21] James_F: i dunno myself. it's a good thing to ask, but it doesn't fit in with the rest right now [18:18:34] * James_F nods. [18:18:44] We could make it about PII instead? [18:19:07] i'm fine with dropping it if you don't want to rework the thing [18:19:08] hmm [18:19:26] [Y] Does this image have no private and personal information and is OK to publish? [18:19:29] Or something. [18:50:29] prtksxna: you there? do you have non-JPG versions of images from https://phabricator.wikimedia.org/T121021#1873203 ? [18:52:05] everyone, does this look sensible? https://i.imgur.com/3TwzDvE.png [18:52:56] It's neat. [18:53:28] (What does it look like in RTL?) [18:53:51] it doesn't yet. presumably it'd be flipped. [18:54:10] Images should be @noflip'ed. [18:54:46] Well, maybe the "a website" one as it's looking a bit like us shouldn't, but… [18:55:33] i mean, the layout would be flipped. the images would look the same, unless someone draws RTL ones. [18:58:18] * James_F nods. [19:21:14] Looks good to me MatmaRex [19:33:52] OK, API patch is looking OK now, I'm going to try to work on the UploadWizard part... [19:34:12] Hopefully it takes me longer than five minutes to get stuck this time [19:42:32] marktraceur: you'll need an API patch to remove images from stash, too :D (images removed by the used at the upload step shouldn't show up again) [19:43:05] James_F: rtl-ish: https://i.imgur.com/XssC7au.png [19:43:21] MatmaRex: Looks fine. Go for it. [19:49:18] James_F: i really don't like how the checkbox is partially offscreen. i'll make a quick VE patch to make this dialog 50px higher, ok? [19:49:37] MatmaRex: Or drop the text height? [19:49:58] (Sure.) [19:50:47] James_F: i don't think it can be squished any more. [19:50:53] * James_F nods. [19:53:44] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 7JavaScript, 5Patch-For-Review: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool - https://phabricator.wikimedia.org/T120867#1878867 (10Isarra) So why have an extra tool for this at all? [20:03:08] James_F: https://gerrit.wikimedia.org/r/259068 https://gerrit.wikimedia.org/r/259069 [20:03:14] I saw. [20:32:54] MatmaRex: Shoot, I hate it when you're right [20:36:57] MatmaRex: Actually! I could just link to the stash and let them deal with their stash on their own at first [20:37:22] And add Ajaxy deletions in the wizard afterwards [20:47:00] 6Multimedia, 6Commons, 10MediaWiki-Uploading: Provide a copyright click-through guide in the cross-wiki upload tool - https://phabricator.wikimedia.org/T121021#1879075 (10matmarex) The complete designs for ideas A, D, E can be seen at T120867#1874985 now. [20:57:33] marktraceur: Do you feel there's enough stuff lying around to do for Multimedia that I don't need to run around making/arranging more tickets before I go on leave? [20:58:07] James_F: Should be! [20:58:15] Good. :-) [21:01:07] i posted at https://commons.wikimedia.org/wiki/Commons:Administrators%27_noticeboard#Interface_options_for_A.2FB_test [21:02:47] James_F: marktraceur: i think https://gerrit.wikimedia.org/r/#/c/258416/ is as good as it's going to get, and that we should merge it and give it a few more whacks on beta labs. [21:02:59] I'll do that then [21:03:33] James_F: marktraceur: that doesn't enable the test yet, i'll write a separate patch for that and have it swatted tomorrow [21:04:04] perhaps we'll convince someone to translate this before then, and we'll be able to run on more than just en.wp [21:04:44] MatmaRex: Do you know if ori is good with it? [21:05:39] marktraceur: i think so, but let me poke him. in any case, we're not running the test yet and we can tweak it. [21:07:50] MatmaRex: You don't want to write the config variable in yet? We can just set it to false by default and submit a config change later. [21:08:44] * James_F nods. [21:09:35] marktraceur: do you think putting it in config will make this any easier? i could do it, i guess [21:09:44] marktraceur: right now it's hardcoded on line 78 of https://gerrit.wikimedia.org/r/#/c/258416/9/resources/src/mediawiki/mediawiki.ForeignStructuredUpload.BookletLayout.js,cm [21:10:08] MatmaRex: I think we'd have an easier time getting a config change through the fundraising blockade than a software change [21:10:23] And yeah, I was just reviewing that line, which is why I asked [21:10:46] this week doesn't have any blockades though (only next) [21:11:02] Oh, right, but this is the last train [21:11:09] So we'd need to specially deploy the test [21:11:16] Which also sounds less than fun to me, shrug [21:11:28] wait, i'm lost [21:11:51] i want to merge this today so that a) people can translate it b) we don't need to scap when deploying the test, only sync-file [21:12:07] MatmaRex: At least from what I remember James_F saying, tomorrow's the last branch cut before the blockades go up [21:12:18] although, hmm. /me grumbles [21:12:20] MatmaRex: Then we'd need to backport in mediawiki/core if we wanted to un-hardcode it [21:12:38] MatmaRex: But if we didn't hardcode, we could *just* submit the config change, instead of the config change and a backport [21:13:17] And adding the config variable is like a five minute change so we've probably been talking about it longer than it would take to add :) [21:13:31] i guess. okay [21:13:38] Thanks! [21:14:05] Also on principle I'm not sure I like adding code to core without adding any functionality (without debug options, anyway) [21:14:36] i also just noticed, we'd need to backport this to wmf.8 (or our test will "ramp up" until thursday) [21:28:09] MatmaRex: I guess I'd be okay with that, if we're going to let it run over the holiday (or until a clear winner emerges) [21:28:21] Anyway it looks great [21:28:26] I just tested it locally [22:15:00] Yay. [22:28:17] 6Multimedia, 6Commons, 10MediaWiki-Internationalization, 10MediaWiki-extensions-GWToolset, and 5 others: Special pages, actions and views whose messages don't escape text - https://phabricator.wikimedia.org/T85864#1879344 (10Aklapper) >>! In T85864#1875643, @Nemo_bis wrote: > Can we add this to GCI? I'd...