[00:03:07] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 7JavaScript, 5Patch-For-Review: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool - https://phabricator.wikimedia.org/T120867#1879602 (10Stefan2) >>! In T120867#1876447, @matmarex wrote: > There were 178 cases where someone... [00:23:28] marktraceur: updated https://gerrit.wikimedia.org/r/#/c/258416/ with configurability. [00:27:08] MatmaRex: Cool, thanks, will merge it tomorrow morning [00:27:53] why tomorrow? :o [00:28:17] MatmaRex: Because I'm about to have guests for dinner! [00:28:27] I'll have time to get it done [00:29:04] ha. enjoy the dinner then [08:34:31] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 7JavaScript, 5Patch-For-Review: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool - https://phabricator.wikimedia.org/T120867#1880145 (10Josve05a) >>! In T120867#1879602, @Stefan2 wrote: >>>! In T120867#1876447, @matmarex w... [10:23:11] 6Multimedia, 6Collaboration-Team-Backlog, 6Commons, 10Echo, 10MediaWiki-Uploading: Fix async upload by url - https://phabricator.wikimedia.org/T119336#1880322 (10zhuyifei1999) [14:39:19] helllo [14:48:48] MatmaRex: o/ [14:52:09] (03PS1) 10Zfilipin: Upgrade to the latest version of mediawiki_selenium Ruby gem [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/259255 (https://phabricator.wikimedia.org/T114362) [14:53:50] MatmaRex: Do you want me to squash the image change patches? [14:54:58] prtksxna: i was just looking at them. either way works [14:57:23] (03CR) 10Zfilipin: [C: 032] Upgrade to the latest version of mediawiki_selenium Ruby gem [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/259255 (https://phabricator.wikimedia.org/T114362) (owner: 10Zfilipin) [14:58:25] prtksxna: what do you think about option 4? i didn't really know what you had in mind, so i put that together quickly yesterday [14:59:52] (03Merged) 10jenkins-bot: Upgrade to the latest version of mediawiki_selenium Ruby gem [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/259255 (https://phabricator.wikimedia.org/T114362) (owner: 10Zfilipin) [15:01:15] OK good morning, let's get something merged [15:04:02] MatmaRex: The template thing is nifty, by the way. I've never seen that before in RL. [15:05:21] marktraceur: Jon's work from last year, i think they use that pretty widely in mobile [15:05:29] Right. [15:06:01] I guess I'll merge the WikimediaEvents one first? I guess it doesn't really matter? [15:06:42] shouldn't matter. we'll merge prtksxna's image/design tweaks as follow-ups [15:07:04] OK. [15:07:42] Leeroy. [15:07:51] I told you I'd have plenty of time this morning! [15:07:58] ;) [15:11:53] prtksxna: https://gerrit.wikimedia.org/r/#/c/259228/ looks good to me, is it okay to merge or are you doing something with it? [15:12:27] prtksxna: i tried optimizing the SVGs, but it seems that svgo is confused by non-inline styles in them and it butchers them horribly [15:12:31] so, i say not worth it [15:29:08] 6Multimedia, 6Commons, 10MediaWiki-Uploading: Provide a copyright click-through guide in the cross-wiki upload tool (interface design ideas for T120867) - https://phabricator.wikimedia.org/T121021#1880822 (10matmarex) [15:30:01] 6Multimedia, 6Commons, 10MediaWiki-Uploading: Adding a template in cross-wiki upload if no category is provided - https://phabricator.wikimedia.org/T121268#1880824 (10matmarex) [15:30:05] 6Multimedia, 6Commons, 10MediaWiki-Uploading: Provide a copyright click-through guide in the cross-wiki upload tool (interface design ideas for T120867) - https://phabricator.wikimedia.org/T121021#1867135 (10matmarex) [15:30:09] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 7Crosswiki, and 2 others: Cross-wiki-upload: Allow users to specify source and specific license - https://phabricator.wikimedia.org/T121012#1880826 (10matmarex) [15:30:13] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 7JavaScript, 5Patch-For-Review: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool - https://phabricator.wikimedia.org/T120867#1880823 (10matmarex) [15:30:17] 6Multimedia, 6Commons, 10MediaWiki-Uploading: Provide a copyright click-through guide in the cross-wiki upload tool (interface design ideas for T120867) - https://phabricator.wikimedia.org/T121021#1867135 (10matmarex) I'm going to mark this subtask as resolved, let's centralize discussion on T120867 now. [15:30:27] 6Multimedia, 6Commons, 10MediaWiki-Uploading: Provide a copyright click-through guide in the cross-wiki upload tool (interface design ideas for T120867) - https://phabricator.wikimedia.org/T121021#1880828 (10matmarex) 5Open>3Resolved [15:30:31] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 7JavaScript, 5Patch-For-Review: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool - https://phabricator.wikimedia.org/T120867#1863551 (10matmarex) [15:31:27] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 7JavaScript: Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool (A/B test of different upload interfaces) - https://phabricator.wikimedia.org/T120867#1880833 (10matmarex) [15:31:37] MatmaRex: Did you test it for RTL? [15:31:44] 6Multimedia, 6Commons, 10MediaWiki-Uploading: Provide a copyright click-through guide in the cross-wiki upload tool (interface design ideas for T120867) - https://phabricator.wikimedia.org/T121021#1867135 (10matmarex) a:3Prtksxna [15:31:55] MatmaRex: I had a 2x2 grid in mind, but this is better. Hides the "camera" image well too :P [15:32:00] prtksxna: yeah, it seemed to work just fine. [15:32:08] MatmaRex: Cool then :) [15:32:29] prtksxna: the images are not flipped, but i think that's okay. only the 'website' one could make sense to flip [15:32:47] MatmaRex: Right, adding -rtl images is trivial [15:33:06] I'll do it in a follow up patch. I wonder it Adobe products look different in rtl. [15:33:37] prtksxna: hah, yeah, the hidden image was a nice side-effect ;) i tried to arrange them in a grid, but there was little horizontal space and i didn't want to shrink them too much [15:33:50] * prtksxna nods [15:34:01] And then text would've take more horizontal space too. [15:34:27] 6Multimedia, 6Commons, 10MediaWiki-Uploading: Adding a template in cross-wiki upload if no category is provided - https://phabricator.wikimedia.org/T121268#1880839 (10matmarex) a:3matmarex [15:35:32] James_F: prtksxna: marktraceur: i started https://www.mediawiki.org/wiki/Multimedia/December_2015_cross-wiki_upload_A/B_test , i'll document the test there later today [15:35:44] Cool, thanks [15:35:45] (it should be a nice place to post the results too) [15:35:46] I don't want to change my computer's language. I don't know anyone around who know an RTL language and I am scared I won't be able to go back :P [15:36:03] MatmaRex: (y) [15:36:29] (hmm, gotta update the screenshots) [15:40:29] MatmaRex: Thank you. [15:49:22] prtksxna: Ask mooeypoo to test it? [15:49:59] Or try to find the RTL English hack that sometimes works [15:50:19] marktraceur: Will do. Google results show that the interface doesn't change. [15:51:25] KK. [15:53:33] James_F: So we're good to go for making the branch now, right? [15:53:40] MatmaRex: I think so, yes. [15:53:43] And a config change won't be a huge problem for another week or so [15:53:47] OK good. [15:54:03] marktraceur: James_F: config patch is https://gerrit.wikimedia.org/r/259258 , btw [15:54:05] Well. Let's not push it out just because. ;-) [15:54:07] Yeah, saw. [15:54:21] I don't see any reason to necessarily hold back, but yeah, we could wait a sec [15:54:42] Translations will take a day or so. [15:54:52] Ah, right, I knew I was forgetting something. [15:54:54] Maybe we should just configure it for all wikis? [15:55:06] I figure we should watch the translations pretty closely [15:55:10] The translations will be done by the time Thursday hits and it's live. [15:55:31] Hitting enwiki will give us a good 50% of the uploads, right MatmaRex? [15:55:57] And in the meantime I'd hate to confuse the studious mw.org contributor who is a native Esperanto speaker. [15:56:21] I dunno. [15:56:36] Giving different experiences to people based on language rather than what we normally do is a bit odd. [15:56:52] marktraceur: yes [15:57:02] If we had a working experience, I'd agree, but it's not ready yet [15:57:04] James_F: i think that would result in much worse upload rate for interfaces 2-4 [15:57:09] since interface 1 is already translated [15:57:31] The translation is explicitly part of the interface and, yes, the experiment [15:57:38] So we'd not only be confusing users but messing with the numbers [15:57:40] also, hmm, should probably enable it for multilingual wikis too? [15:57:51] MatmaRex: Just enable it for all wikis. [15:58:05] By the time they actually see it (Thursday) the big i18n will be done. [15:58:22] hmm. [15:58:40] Also, join prtksxna and me in the Hangout. :-) [15:58:49] yes. [15:58:50] There's a minute left! [15:58:59] Slackers. [16:06:39] prtksxna: https://phabricator.wikimedia.org/T70860 [16:08:17] marktraceur: I'd really like to get https://gerrit.wikimedia.org/r/#/c/257669/ in, which depends on https://gerrit.wikimedia.org/r/#/c/257668/ [16:11:17] In the next -11 minutes? [16:12:40] marktraceur: Cut's nominally in an hour or so. [16:12:48] Oh! [16:12:52] OK reviewing. [16:13:23] marktraceur: You rock. [16:13:39] That's what they tell me [16:14:40] * James_F waits impatiently for TWN to import core today so that our changes can be translated. [16:16:52] marktraceur: https://gerrit.wikimedia.org/r/259273 would be nice to get before the cut too. ;) [16:17:46] MatmaRex: Done. [16:19:43] Complex change requires complex review. ;-) [16:20:46] heh [16:23:44] Also, making Commons happy by doing the right thing is nice. [16:24:04] And yeah, *all* our stuff on this needs config support; this A/B/C/D test is Commons-specific, for instance [16:26:17] James_F: marktraceur: i also just noticed. the WikimediaEvents patch is also in wmf.9 only (not wmf.8). so it'll only start recording things after tomorrow's deployment, when wmf.9 goes to Commons. [16:26:30] OK. [16:26:45] James_F: Done yours, you got MatmaRex's? [16:26:57] OK yes. [16:28:10] marktraceur: James_F: also. did we actually announce/document cross-wiki uploads anywhere, or was it a "dark launch"? i could only find marktraceur's multimedia@ email that we're working on it, but nothing when it was finished [16:29:55] It was kind of dark, I guess [16:30:00] MatmaRex: It was in the quarterly review slides, but… [16:30:04] We didn't really have a big rollout plan [16:30:13] It just rolled. [16:31:53] right. i'll write something about it too, then [16:41:43] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 7JavaScript, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool (A/B test of different upload interfaces) - https://phabricator.wikimedia.org/T120867#1880950 (10Whatamidoing-WMF) >>! In... [16:43:34] prtksxna: merge https://gerrit.wikimedia.org/r/259279 ? i just realized we're embedding both PNG and SVG because of this :o [16:47:12] MatmaRex: Done. [16:47:39] It's great that James_F can be the fourth engineer on our team. [16:47:42] * James_F grins. [16:47:42] okay, hopefully nothing will fall over, i'm going to go get food. brb [16:47:45] also, yes. [16:47:54] Don't tell anyone. [16:48:09] I was going to change {{Staff and Contractors}} [16:48:10] But OK [17:16:55] argh, https://gerrit.wikimedia.org/r/#/c/259279/ failed to merge because of some shitty flaky extension tests [17:18:04] MatmaRex: We clashed on fixing it. [17:18:53] looks like wmf.9 wasn't branched yet, at least. [17:21:21] Yeah. [17:25:33] Uhh, James_F, quick question for you...I'm thinking an OOUI popup (whatever we used to replace tipsy) on the upload button for "hey you have stashed uploads, do you want to resume some of them?" and an OOUI dialog for choosing which ones to resume, sound good? [17:25:46] Makes my life easier, interface work is t3h frustr4t3 [17:26:28] 6Multimedia, 10MediaWiki-General-or-Unknown, 10VisualEditor, 5MW-1.27-release-notes, and 2 others: Show not logged in error before uploading to stash in mw.Upload.BookletLayout - https://phabricator.wikimedia.org/T115866#1881077 (10Jdforrester-WMF) [17:26:43] 6Multimedia, 10MediaWiki-General-or-Unknown, 7Design, 7Tracking: Design improvements for mw.ForeignStructuredUpload.BookletLayout - https://phabricator.wikimedia.org/T115858#1881083 (10Jdforrester-WMF) [17:26:46] 6Multimedia, 10VisualEditor, 10VisualEditor-Media, 5Patch-For-Review: MWMediaDialog: exception "Local uploads are disabled" - https://phabricator.wikimedia.org/T119314#1881080 (10Jdforrester-WMF) [17:26:50] 6Multimedia, 10MediaWiki-General-or-Unknown, 10VisualEditor, 5MW-1.27-release-notes, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Show not logged in error before uploading to stash in mw.Upload.BookletLayout - https://phabricator.wikimedia.org/T115866#1881078 (10Jdforrester-WMF) 5Open>3Resolved [17:27:36] MatmaRex: Sounds good. [17:27:39] Bah [17:27:43] marktraceur: Sounds good. [17:28:04] marktraceur: Clearly you should be TraceurMark for tab completion. [17:28:22] we have *so many* "ma" people, really. [17:28:27] Because my name doesn't confuse people enough already [17:28:36] TheRealMarkTraceur [17:28:41] Ooh. [17:28:49] ™TraceurMark. [17:28:53] Hah [17:29:11] Try tab completing that with an inferior keyboard! [17:37:11] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 5MW-1.27-release-notes, and 2 others: Adding a template in cross-wiki upload if no category is provided - https://phabricator.wikimedia.org/T121268#1881139 (10matmarex) 5Open>3Resolved The bug has been fixed now, and the fix will be deployed to Wikimedia wi... [17:42:51] MatmaRex, James_F, still working out the dialog classes in OOUI, do I want a MessageDialog or a ProcessDialog? I think message but I'm not sure [17:43:32] ProcessDialog seems like dark magic to me [17:44:34] marktraceur: probably ProcessDialog, or plain ol' Dialog. MessageDialog has some strong assumptions about the UI, and it mostly means for yes/no/cancel questions [17:44:39] meant* [17:44:50] is mostly meant*, even. [17:45:35] I guess I could just subclass dialog then, but if ProcessDialog gives me stuff for free then I guess I could go with that [17:46:00] Use ProcessDialog. [17:49:24] Done. [17:49:33] So I'll be in OOUI docs for a bit :) [17:50:48] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-extensions-MultimediaViewer: MediaViewer intermittent image loading errors (2015 Oct-Dec) - https://phabricator.wikimedia.org/T115563#1881303 (10Jdlrobson) p:5High>3Normal [17:58:10] 6Multimedia, 6Commons, 10MediaWiki-Uploading, 7JavaScript, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Large amounts of unwanted files (mostly copyvios) uploaded via cross-wiki upload tool (A/B test of different upload interfaces) - https://phabricator.wikimedia.org/T120867#1881418 (10matmarex) >>! In T120867... [18:24:00] Isn't there a way to get a stashed image's thumbnail without calling the API again... [18:25:37] Hm, no. [18:25:42] Christ I hate MediaWiki sometimes [18:27:30] It loves you so much, though. [18:27:33] <-> much. [18:39:14] Yeah, I'm just fetching them earlier, though I would have preferred to wait [18:39:24] But you gotta show the user what the image looks like. No choice. [18:39:36] Actually I probably have enough to open the dialog now. [18:43:14] OOUI is just so pretty https://lut.im/w5NEHr811V/D29JxjQssA4o5hME.png [18:43:33] Err. [18:43:44] Did you attach the content to the wrong bit of the DOM? [18:44:23] Apparently [18:44:26] I'll sort it out [18:44:38] Mostly I wanted to make sure my thumb requests were working [18:58:51] Hmm. [18:58:59] I have painted myself into a corner. [18:59:08] MatmaRex tried to warn me about the linked list thing, but did I listen? Noooo. [18:59:24] Bloody UploadWizard man [19:02:17] I guess I'll fix the interface and work back to the upload handling business. [19:07:07] I'm guessing the weird file input stuff is preventing the popup widget from functioning properly [19:07:23] * James_F grins. [19:07:55] Hell if I know how. [19:08:01] #wikimedia-marktraceur-monologue [19:11:23] $element instead of $body. Rookie mistake. [19:12:28] * James_F grins. [19:22:41] :o [19:25:30] At least it's *mostly* working. [19:27:02] Screenshot or it doesn't happen. [19:49:39] Wow it worked totally [19:49:43] I'll do you one better. [19:51:25] Better than a screenshot would be… a screencast? [19:51:50] Or a patch. [19:52:44] Eww. [19:52:44] Code. [19:52:46] Who wants that? [19:52:59] (03Restored) 10MarkTraceur: Remove upload handling from UploadWizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/254913 (https://phabricator.wikimedia.org/T93895) (owner: 10MarkTraceur) [19:53:06] * James_F impatiently waits for https://translatewiki.net/wiki/MediaWiki:Foreign-structured-upload-form-2-label-noderiv/en to be real. [19:53:11] (03PS10) 10MarkTraceur: Remove upload handling from UploadWizard object [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/254913 [19:53:13] (03PS1) 10MarkTraceur: [WIP] Resume stashed uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/259320 (https://phabricator.wikimedia.org/T85561) [19:53:41] I may have backpedaled on the parent commit but I'll sort it all out [19:53:44] 6Multimedia, 10MediaWiki-extensions-MultimediaViewer, 10UploadWizard: Add metrics to graphite - https://phabricator.wikimedia.org/T77805#1881943 (10Jdlrobson) p:5Normal>3Lowest [19:53:44] Super exciting stuff [19:55:31] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Resume stashed uploads [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/259320 (https://phabricator.wikimedia.org/T85561) (owner: 10MarkTraceur) [19:55:35] James_F: we should maybe ask raymond to do the import or whatever? [20:08:11] 6Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: When a full image file name / file page title / file URL is entered in VE media dialog search, use that image directly - https://phabricator.wikimedia.org/T121354#1882048 (10Jdforrester-WMF) p:5High>3Normal [20:49:16] 6Multimedia, 10Possible-Tech-Projects, 10Wikimedia-General-or-Unknown: Implement International Image Interoperability Framework (IIIF) prototype service on Wikimedia labs - https://phabricator.wikimedia.org/T89552#1882475 (10Jheald) It seems that the links above (the ones without the diacritics) work **if**... [20:50:15] gods, i forgot how horrific it is to write anything gender-specific in Polish in second person [20:50:16] "Did you create this image (take the photo, sketch the drawing, etc.) yourself?" [20:51:03] that's four {{GENDER:}} invocations :/ [20:53:17] 6Multimedia, 10Possible-Tech-Projects, 10Wikimedia-General-or-Unknown: Implement International Image Interoperability Framework (IIIF) prototype service on Wikimedia labs - https://phabricator.wikimedia.org/T89552#1882518 (10dschwen) Jheald, the code is already in proxy.php to create the cached tile represen... [21:02:14] 6Multimedia, 10Possible-Tech-Projects, 10Wikimedia-General-or-Unknown: Implement International Image Interoperability Framework (IIIF) prototype service on Wikimedia labs - https://phabricator.wikimedia.org/T89552#1882614 (10dschwen) I found and fixed that bug. By the way, URLs with diacritics work without... [21:03:10] 6Multimedia, 10Possible-Tech-Projects, 10Wikimedia-General-or-Unknown: Implement International Image Interoperability Framework (IIIF) prototype service on Wikimedia labs - https://phabricator.wikimedia.org/T89552#1882617 (10dschwen) Details are extracted on the fly and do not require any further storage. [22:12:46] MatmaRex: It's done now. [22:13:14] James_F: yeah, i even managed to translate it ;) [22:13:24] Yay. [22:13:37] James_F: we might want to pepper it with some {{GRAMMAR}} and changes some occurences of 'image' to 'file'. [22:13:45] Perhaps. [22:13:55] * James_F trusts y'all. [22:30:14] 6Multimedia, 10Possible-Tech-Projects, 10Wikimedia-General-or-Unknown: Implement International Image Interoperability Framework (IIIF) prototype service on Wikimedia labs - https://phabricator.wikimedia.org/T89552#1883031 (10Jheald) Daniel, thank you *so* much for fixing this -- so now it should be all syste... [22:40:01] hello multimedia team [22:40:07] there is an instance called 'multimedia-perf' [22:40:28] I think that was gilles's instance at some point [22:40:36] I forget what we were doing with it [22:41:04] yeah [22:41:13] so it is the only one using ssh X forwarding [22:41:22] which I'm going to kill for T101447 [22:41:28] https://phabricator.wikimedia.org/T101447 [22:41:34] nobody has logged into it in forever [22:41:40] so we can bring it back in if someone notices [22:42:38] I was going to say ' marktraceur aren't you in SF in december? it is pretty cold now' before I realized where you were [22:43:00] 6Multimedia, 10Possible-Tech-Projects, 10Wikimedia-General-or-Unknown: Implement International Image Interoperability Framework (IIIF) prototype service on Wikimedia labs - https://phabricator.wikimedia.org/T89552#1883055 (10dschwen) Jheald, the ZoomViewer has currently 86574 cached images, I would guess th... [22:52:50] it has been done! [22:53:13] please send further queries and complaints to Dark and Gloomy Corner, 149 New Montgomery St, SF, CA, USA [22:53:15] Thank you [23:13:01] 6Multimedia, 10MediaWiki-Uploading, 7JavaScript, 5MW-1.26-release: Expand mw.Api.plugin.upload to use File API where available - https://phabricator.wikimedia.org/T103398#1883185 (10matmarex) [23:13:09] 6Multimedia, 10MediaWiki-Uploading, 7JavaScript, 5MW-1.26-release: Expand mw.Api.plugin.upload to stash uploads when requested - https://phabricator.wikimedia.org/T103399#1883189 (10matmarex) [23:13:19] 6Multimedia, 10MediaWiki-Uploading, 7JavaScript: Expand mw.Api.plugin.upload to use chunked uploads when available and selected - https://phabricator.wikimedia.org/T103400#1883194 (10matmarex) [23:40:41] i wrote stuff at https://www.mediawiki.org/wiki/Multimedia/December_2015_cross-wiki_upload_A/B_test