[00:08:35] An easy way to check if it's your changes that are causing the issues is to `git stash` and try again [00:08:41] then `git stash apply` to re-add your changes [00:10:24] It says command not found. [00:10:24] MtDu: ^ [00:10:35] ...in the MMV repository [00:10:48] ...in the shell (Git Bash on silly Windows) [00:11:08] I'm on a Mac right now. I'm cded into MMV [00:11:41] silly mac [00:11:48] You probably don't have git installed [00:12:41] but when I ran git status and git diff, I received results. [00:13:19] `git stash` is a standard command in git. [00:14:56] I just downloaded it and ran the installer package. I still can't run `git stash` [00:15:14] When I run it without the `s, I get no local changes to save. [00:16:02] Eh [00:16:12] I use `'s to delineate commands [00:16:17] don't actually put those... [00:16:33] Ok. Am I supposed to get no local changes to save? [00:18:37] Well, which directory are you in? [00:18:45] MMV [00:19:00] do you have a .git directory? [00:19:09] (ls -a) [00:19:29] Yes [00:19:35] did you modify the files? [00:19:42] does `git diff` show changes? [00:19:42] No [00:20:09] You're supposed to use `git stash` when you have changes in the repository [00:20:24] I use it to compare unmodified version to modified version to isolate the cause of ane rror [00:20:30] Wait. i committed the changes. I think [00:20:34] That's probably why [00:20:53] in which case methinks you can use `git checkout HEAD~1` [00:21:02] and reapply your changes with `git checkout HEAD` [00:21:46] ok [00:21:48] *reapply with `git checkout ` [00:22:06] https://dpaste.de/2vJ4 [00:23:07] I meant to do `git checkout HEAD~1` in the branch where you commited the changes [00:24:55] How do I switch to that branch? [00:25:17] You already did, with git checkout T85685 [00:25:56] But when I run the git checkout command, I get this. https://dpaste.de/tJYB [00:26:19] Yes. that just means you aren't in a branch [00:26:25] you can always get back to your branch [00:26:32] to see if you changes are causing the issues [00:26:38] Yeah. How do I get back to the branch? [00:26:54] Or what am I supposed to do? [00:27:16] Now check to see if MMV works [00:27:20] which it should [00:27:26] then get your changes back with `git checkout T85685` [00:27:37] Yep it works. [00:27:57] Now see if it works again? [00:28:09] Now I get the error. [00:28:39] I think it's the creditParams.push( username ); [00:28:57] Should it be creditParams.push( info.imageInfo.author ); [00:30:31] Hydronium: I'll be back later. Are you calling it a day soon? [00:30:39] Eh, I'm always on [00:30:41] EST [00:31:09] Wait. Is the creditParams what's wrong? [00:31:12] Or is username right? [00:31:23] Can you push all of the changes to a gerrit patch [00:31:28] with [WIP] on the first line [00:31:33] so we can check it out [00:32:04] Ok. [00:32:19] So i just commit all my changes in that branch --amend? [00:32:39] yes, try it out [00:33:07] So like this? [00:33:08] [WIP]Add gender support to Multimediaviewer-text-embed-credit-text-tbls and other related messages [00:33:13] On the first line of the commit? [00:33:47] yes [00:34:08] When I run git remote update. It doesn't fetch gerrit. Only origin [00:34:36] git fetch --all [00:34:44] is what I use [00:35:20] Still only fetches origin. I think its something wrong with a git config file. I had this problem on WIndows. [00:36:57] do you have git review set up? [00:37:49] I think so. When I run git review -s it doesn't do anything [00:38:33] https://dpaste.de/0UBM [00:38:35] what does `git remote -v` say [00:38:48] Dus-iMac:MultimediaViewer Du$ git remote -v origin https://gerrit.wikimedia.org/r/p/mediawiki/extensions/MultimediaViewer.git (fetch) origin https://gerrit.wikimedia.org/r/p/mediawiki/extensions/MultimediaViewer.git (push) [00:38:56] https://dpaste.de/5DAP [00:38:59] eh, your gerrit remote is screwed up again [00:39:08] make an .ssh/config [00:39:22] vagrant ssh? [00:39:25] and `git remote set-url gerrit ssh://.....` [00:39:54] Wait I ran vagrant ssh. [00:39:58] Is that right? [00:40:02] Remember this https://dpaste.de/Jo6Q ? [00:40:49] Yeah. [00:42:31] Set one up on your mac [00:42:51] I can't find the .ssh folder [00:54:20] MtDu: It should be in ~ [00:54:26] If it isn't, make one [00:54:37] and if it isn't there, that means you also have to generate another ssh key for gerrit [00:54:42] Hydronium: I"ll be on in like an hour. Emergency. Got to go. [00:54:47] k [00:54:48] I'll ahve my windows machine with me. [00:55:02] Thanks for all your help. Will get in touch when I can. [01:29:39] Hydronium: When I try to git review, it gives me this error. https://dpaste.de/aquw [01:30:15] I'll try to help but the Dem debate is starting :) [01:30:20] Hydronium: I think the command I need to run is something like git remote detached state? [01:30:42] Hydronium: Yeah man. I take AP Gvmt. Gotta watch that too. But I'd appreciate any help you could give me. [01:31:28] \u2192 is a rightward arrow [01:32:04] So what do I need to fix? [01:32:14] checking... [01:35:25] Do you have any weird characters inside any of the source files or on any of the commit messages? [01:36:41] https://dpaste.de/imev [01:36:53] I don't think I have any weird characters [01:37:37] wait. you are in T85685 branch, right? [01:37:46] Look at the above paste. [01:37:48] It gives me that warning. [01:38:04] `git stash` and checkout [01:39:03] https://dpaste.de/T1z3 [01:42:56] eh, you committed your changes while in "branch-less" mode [01:43:07] git checkout -b [01:43:09] and review that [01:44:26] What should I name it? [01:44:32] it doesn't matter [01:45:09] (03CR) 10Bartosz Dziewoński: [C: 032] Generalize warning system [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/258100 (https://phabricator.wikimedia.org/T120905) (owner: 10Sn1per) [01:45:32] https://dpaste.de/57xb I don't recognize this. [01:45:50] (03PS8) 10Bartosz Dziewoński: Warning when file date is in the future [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257760 (https://phabricator.wikimedia.org/T117117) (owner: 10Sn1per) [01:46:11] (03CR) 10Bartosz Dziewoński: [C: 032] Warning when file date is in the future [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257760 (https://phabricator.wikimedia.org/T117117) (owner: 10Sn1per) [01:46:39] 6Multimedia, 10UploadWizard, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: Add a warning about choosing a date in the future - https://phabricator.wikimedia.org/T117117#1893172 (10matmarex) [01:46:41] 6Multimedia, 10UploadWizard, 7Technical-Debt: Generalize the warning system, improve warning handling - https://phabricator.wikimedia.org/T120905#1893168 (10matmarex) 5Open>3Resolved p:5Triage>3Normal [01:46:47] thanks MatmaRex :) [01:46:50] 6Multimedia, 10UploadWizard, 7Easy, 3Google-Code-In-2015: Add a warning about choosing a date in the future - https://phabricator.wikimedia.org/T117117#1893173 (10matmarex) 5stalled>3Resolved [01:46:59] (03Merged) 10jenkins-bot: Generalize warning system [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/258100 (https://phabricator.wikimedia.org/T120905) (owner: 10Sn1per) [01:47:15] Hydronium: :) [01:47:18] MtDu: ehhhh [01:47:24] thanks for doing that :D [01:47:48] MtDu: what does `git log` say? [01:48:08] (03Merged) 10jenkins-bot: Warning when file date is in the future [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/257760 (https://phabricator.wikimedia.org/T117117) (owner: 10Sn1per) [01:49:14] https://dpaste.de/hpzu I did switch machines btw [01:49:35] `git checkout master` [01:49:38] `git pull` [01:49:44] `git show f0b52bf1dbfc9 | git apply -` [01:50:57] https://dpaste.de/nDMz [01:51:26] `git diff` [01:51:50] who knew you could use a person as a shell proxy [01:52:15] https://dpaste.de/weKn [01:52:35] It has all my qqq changes, but it doesn't have the other changes, such as the loops and the parameter I pushed. [01:52:39] how about `git status` [01:53:47] It shows that the files were edited there. https://dpaste.de/wvkr [01:54:47] And it doesn't have the loop you added before? [01:55:11] In git diff no. [01:55:17] I have the changes in my files. [01:55:39] so they are present? [01:55:46] git add the files that are relevent [01:55:49] Yeah. They're there. [01:55:52] git commit --amend [01:56:02] then git review [01:56:15] Ok [01:56:54] https://dpaste.de/n19b [01:58:10] https://stackoverflow.com/questions/25680921/error-while-submitting-code-to-gerrit-using-git-review-on-windows [01:58:30] Move Python2 ahead of Python3 in %PATH% [01:59:33] Justin@Du MINGW64 ~/vagrant/mediawiki/extensions/MultimediaViewer (master) $ git review -y remote: Resolving deltas: 100% (7538/7538) remote: Processing changes: refs: 1, done To ssh://mdew192837@gerrit.wikimedia.org:29418/mediawiki/extensions/Echo.git ! [remote rejected] HEAD -> refs/publish/master (no common ancestry) error: failed to push some refs to 'ssh://mdew192837@gerrit.wikimedia.org:29418/mediawiki/extensions/Echo [01:59:40] Wait. I ran git review -y [01:59:57] https://dpaste.de/9hbS [02:00:05] ugh [02:00:08] git is the worst [02:00:20] I know. Sorry. [02:00:24] can you show us `git log`? [02:00:55] https://dpaste.de/V6be [02:01:44] where did your commit go [02:02:06] I have no idea. [02:02:08] I didn't do anything. [02:02:10] did you git commit --amend into the previous guy's commit? [02:03:09] Maybe [02:03:28] git reset --soft HEAD@{1} [02:03:41] git status [02:03:51] git status gave me this [02:03:51] https://dpaste.de/knHw [02:03:58] Should I run the git reset now? [02:04:04] I had to add all the files I edited [02:04:07] Are those the right changes? [02:04:15] I have no idea what the other files are there fore. I don't recognize them [02:04:53] try `git rebase gerrit/master` [02:05:19] https://dpaste.de/eEk5 [02:05:44] git commit (WITHOUT amend) [02:05:48] and then run git rebase gerrit/master [02:05:52] and then `git review` [02:06:42] What's the thing I add at the beginning? [02:06:46] [WIN]? [02:07:10] WIP [02:08:04] https://dpaste.de/mHgR [02:08:33] git review -uy [02:08:35] * -y [02:09:20] https://dpaste.de/zGDC [02:09:44] Wait. It's thinking I'm doing it to Echo [02:09:48] But I need to do it to MMV [02:09:52] Which file do I need to change? [02:10:26] you are in the MMV directory? [02:10:41] You need to fix your git remote [02:11:48] I remember adding something to a file when I was having this problem. I made it specifically to the extension I was working on Echo, but I can't remember which file it was. [02:12:10] git remote set-url gerrit ssh://blah blah blah/extensions/MultimediaViewer.git [02:13:06] whats blah blah? [02:13:21] username@gerrit... [02:13:51] git remote set-url gerrit ssh://mdew192837@gerrit.wikimedia.org/extensions/MultimediaViewer.git [02:13:55] I ran that. Is that right? [02:14:06] You forgot the port number, but .ssh config should handle that [02:14:10] git review away [02:14:53] https://dpaste.de/Jaz5 [02:16:32] did you set the gerrit remote url? [02:17:00] yeah. See how it's still trying to push it to Echo? [02:17:11] git remote-v [02:17:12] I remember editing a file and setting it to Echo. [02:17:20] edit ~/.git/config [02:17:38] Not a command [02:18:11] I mean `git remote -v`, but the "file" you're thinking of is ~/.git/config [02:19:15] Yeah I know. That worked. [02:19:25] The edit one didn't. [02:19:28] I didn't literally say 'edit' [02:19:30] I meant it as a verb [02:21:34] https://dpaste.de/ytuR [02:21:45] So what do I need to change? [02:22:03] is this ~/.git/config ? [02:22:46] I believe that is the one you inserted the "Echo" stuff in [02:23:11] Yeah but this one doesn't have the echo stuff in it. [02:23:15] Am I in the wrong file? [02:23:29] I'm in vagrant/mediawiki/.git/config [02:23:32] I said, ~/.git/config probably has the "Echo" stuff in it [02:23:41] as in, C:\users\Name\.git\config [02:24:24] I don't have a .git folder [02:25:21] eh, nevermind [02:25:36] I'm not sure if I'm looking in the right place. [02:25:40] vagrant/mediawiki/extensions/MultimediaViewer/.git/config [02:26:48] This is the thing I inserted. I found it in the log from a few days ago. [02:26:50] [remote "gerrit"] url = ssh://mdew192837@gerrit.wikimedia.org:29418/mediawiki/extensions/Echo.git fetch = +refs/heads/*:refs/remotes/gerrit/* [02:26:59] But I can't the file I inserted it in. [02:27:07] go to C:\Users\User [02:27:19] `grep -rn "mediawiki/extensions/Echo.git"` [02:28:34] Oh I found the file. [02:28:39] It was the .git file in the Echo extension [02:28:53] So do you want me to do that same thing but for the MMV extension? [02:30:15] This is what is in the .git file in the Echo extension. https://dpaste.de/cO3v This is what is currently in the .git file in MMV https://dpaste.de/f9Bk [02:30:40] try git review -y [02:31:12] (03PS1) 10MtDu: [WIP]Add gender support to Multimediaviewer-text-embed-credit-text-tbls and other messages [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260221 (https://phabricator.wikimedia.org/T85685) [02:31:16] bingo [02:31:33] I GOT IT. :) [02:31:54] I don't know how you have put up with me for so long in one day. Thank you so much! [02:32:05] Now I need to find out what's wrong with my code. :p [02:32:18] cheers [02:32:40] If my task is due in like 7 hours, should I just submit it with that link right now? [02:33:06] You can submit it and keep working on it, but the submission won't be approved unti it is merged, usualy [02:33:15] (03CR) 10jenkins-bot: [V: 04-1] [WIP]Add gender support to Multimediaviewer-text-embed-credit-text-tbls and other messages [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260221 (https://phabricator.wikimedia.org/T85685) (owner: 10MtDu) [02:33:17] Yep. [02:34:37] Well. My code is full of errors. [02:34:50] the debate is very exciting [02:35:11] Can you take a look at mwext-qunit FAILURE and try to see what's wrong? I'm fixing the js hint stuff right now. [02:35:19] When you get a chance. Enjoy the debate. [02:35:58] You have an " Uncaught SyntaxError: Unexpected token ," [02:36:08] What causes one test to fail often causes the others [02:41:09] Hydronium: So it's pretty much my syntax. [02:42:08] Hydronium: So I fixed some of them and this is what I have now. https://dpaste.de/g7LZ It says the var throws an error. Is the var line unnecessary? [02:43:08] https://dpaste.de/g7LZ#L10 illegal semicolon [02:43:55] This is the whole list of errors. [02:43:55] https://integration.wikimedia.org/ci/job/jshint/5199/console [02:44:00] I know [02:44:08] Lemme add them to the files on gerrit [02:45:06] What do you mean? [02:46:10] Do you know how to take the jshint log and find where the errors are? [02:46:35] Look at the line numbers? [02:46:53] yes. which 'var' error are you talking about? [02:47:28] 02:31:36 resources/mmv/mmv.js: line 131, col 13, Expected an identifier and instead saw 'var' (a reserved word). [02:47:58] And I don't understand the one before it either. [02:48:26] Btw, here is https://dpaste.de/QRv3. This is the one that I have fixed some of the errors. [02:48:37] I'll be back on in like 20 min. [02:48:40] " for (i = 0, , i " [02:48:43] you botched it [02:48:47] Hm? [02:48:57] "for (i = 0, , i < needGenderMessages.length; i++) {" [02:49:00] the syntax is botched [02:49:55] also, you need to use single quotes '' for the array [02:50:16] Look at my paste. [02:50:17] (I'm not sure if the array is a good idea, but the loop should be ok) [02:50:20] I fixed that. [02:50:22] Ok. [02:50:29] Well, hopefully it works for this. [02:50:41] What do mean by the syntax is botched? What do I need to do? [02:50:43] but the reviewers will point out if the array is a bad idea [02:51:00] 'i' is undefined [02:51:09] also, you need semicolons, not commas [02:51:36] What do I need to add then to define it? [02:51:44] 'var'? [02:52:12] https://dpaste.de/xDY9 [02:52:21] I'm just going to send you new pastes as I fix each error. [02:52:39] you can run jshint locally [02:52:43] How? [02:52:47] do you have node.js installed? [02:52:52] Nope. [02:53:02] http://jshint.com/install/ [02:53:15] install node.js [02:53:23] then `npm install -g jshint` [02:54:46] Ok. Can I just install the sublime plugin? [02:54:51] Or do I still need npm install -g jshint [02:55:08] plugins typically require that you have jshint already installed [02:57:26] Where do I run npm install -g jshint? [02:57:42] I"m doing it in cmd [02:57:50] you need to have installed node.js [02:57:53] then do it in a command prompt [02:57:57] Yep. I have [02:58:08] actually, you might need to do it in a "Node" command prompt [02:58:18] there should be a shortcut in your program folder [02:58:24] Yep. [02:58:32] because I'm not sure if they add Node to the PATH in the installer [02:59:28] then you can install the jshint plugin [02:59:53] Once I ran that npm command, what do I do? [03:00:23] You can install the plugin in ST [03:00:49] I did. [03:00:57] When I lint, it doesn't really tell me anything though. [03:01:29] It just says missing 'use strict' statement for all the errors. [03:01:30] It should give you the same errors, but they should be displayed next to the affected lines [03:02:20] Why is it saying so many errors with code I didn't even touch? [03:02:27] Or you can just run `jshint` in the MMV folder [03:02:35] How do I do that? [03:02:51] there are specific errors that actually address nonexistent issues [03:02:59] a file called .jshintrc tells jshint which errors to ignore [03:03:03] It is in the MMV folder [03:03:10] go to the MMV folder and run jshint in a prompt [03:04:25] So in cmd do what? [03:04:34] run `jshint` [03:04:50] Ok. It doesn't do anything. [03:05:15] So I opened cmd up, then typed in jshint [03:06:01] In MMV folder? [03:06:46] oh sanders and clinton are battling it out [03:06:49] * Hydronium grabs popcorn [03:41:01] (03PS2) 10MtDu: [WIP]Add gender support to Multimediaviewer-text-embed-credit-text-tbls and other messages [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260221 (https://phabricator.wikimedia.org/T85685) [03:42:20] Hydronium: Does it need to be like (var i; i = 0; i < needGenderMessages.length; i++)? How come they don't have to declare the variable here? http://www.w3schools.com/js/js_loop_for.asp [03:43:27] (03CR) 10jenkins-bot: [V: 04-1] [WIP]Add gender support to Multimediaviewer-text-embed-credit-text-tbls and other messages [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260221 (https://phabricator.wikimedia.org/T85685) (owner: 10MtDu) [03:48:24] (03PS3) 10MtDu: [WIP]Add gender support to Multimediaviewer-text-embed-credit-text-tbls and other messages [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260221 (https://phabricator.wikimedia.org/T85685) [03:50:19] (03CR) 10jenkins-bot: [V: 04-1] [WIP]Add gender support to Multimediaviewer-text-embed-credit-text-tbls and other messages [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260221 (https://phabricator.wikimedia.org/T85685) (owner: 10MtDu) [03:56:52] (03PS4) 10MtDu: [WIP]Add gender support to Multimediaviewer-text-embed-credit-text-tbls and other messages [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260221 (https://phabricator.wikimedia.org/T85685) [03:58:52] (03CR) 10jenkins-bot: [V: 04-1] [WIP]Add gender support to Multimediaviewer-text-embed-credit-text-tbls and other messages [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260221 (https://phabricator.wikimedia.org/T85685) (owner: 10MtDu) [04:02:46] Hydronium: I need a lil help. Are you there? [04:04:22] I'm back, what's up [04:05:36] So. [04:05:38] Look at my patches. [04:05:40] 3 and 4. [04:06:10] 3 had one error. I decided to add var i, which was an awful idea, and tons of errors emerged in patch 4. Why does it say i is not defined in patch 3? [04:07:08] "awful idea"? [04:07:17] Not awful. Just not good. [04:07:41] from what I can see the number of failed tests went down when you added 'var i'. [04:07:53] 'var i' is proper Javascript. [04:07:59] Wait. [04:08:11] Look at patch 3, I only had the error of i is not defined. [04:08:19] https://integration.wikimedia.org/ci/job/jshint/5201/console [04:08:40] And the only test that failed was jshint. In patch 4, when I added var i, three tests failed and more errors emerged. [04:09:07] oh, you added var i in patch 4 [04:09:24] Because your JS syntax is botched [04:09:37] JS for loop has same format as C, C++, Java, etc. [04:09:38] How do I fix it in patch 3? [04:09:48] for ( var i = 0; i < needGenderMessages.length; i++ ) [04:10:12] Hm. Ok. I was reading here. http://www.w3schools.com/js/js_loop_for.asp How come it works for them without declaring the var? [04:10:39] var keeps a variable in scope. [04:10:49] Ok. [04:11:01] So this should work? https://dpaste.de/PCsV [04:11:06] without var the variable can "rise" in scope [04:11:11] which is a Bad Thing (tm) [04:11:24] try it [04:12:16] (03PS5) 10MtDu: [WIP]Add gender support to Multimediaviewer-text-embed-credit-text-tbls and other messages [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260221 (https://phabricator.wikimedia.org/T85685) [04:14:30] (03CR) 10jenkins-bot: [V: 04-1] [WIP]Add gender support to Multimediaviewer-text-embed-credit-text-tbls and other messages [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260221 (https://phabricator.wikimedia.org/T85685) (owner: 10MtDu) [04:15:56] Woops. I added that var forgot to delete it. Lol [04:16:03] Let's try once more. [04:16:11] (03CR) 10Sn1per: [C: 04-1] "Just some nitpicks (you should consult someone more experienced on where/whether to use the array)" (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260221 (https://phabricator.wikimedia.org/T85685) (owner: 10MtDu) [04:16:13] (03PS6) 10MtDu: [WIP]Add gender support to Multimediaviewer-text-embed-credit-text-tbls and other messages [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260221 (https://phabricator.wikimedia.org/T85685) [04:17:20] Hydronium: What did you say besides I should consult someone? [04:17:40] that you had the extra var line [04:17:45] and that the array line was waaay too long [04:17:56] you can view inline comments on each patch [04:18:24] Yeah. I realized I added the extra var. So how do you propose that I fix that long line? [04:19:13] Split it up [04:19:35] OK. [04:19:36] I'm surprised jshint didn't go off on that [04:19:45] Lol. Yeah me too. [04:20:48] Is this better? [04:20:48] https://dpaste.de/HqbC [04:23:02] one line per item, please [04:23:16] https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Line_length [04:23:48] Is the spacing on this right? https://dpaste.de/HKBZ [04:25:06] The manual link should tell you all about it :) [04:25:44] Sorry. Just saw that. Didn't realize you sent it. [04:27:33] (03PS7) 10MtDu: [WIP]Add gender support to Multimediaviewer-text-embed-credit-text-tbls and other messages [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260221 (https://phabricator.wikimedia.org/T85685) [04:29:47] Hydronium: So now I just sit tight until one of my mentors reviews it? [04:30:08] some issues with the array [04:30:35] "...objects should...be...split over multiple lines with one line for each segment. Avoid closing a function call or object at a different indentation than its opening." [04:30:43] and each individual line should be one indent over [04:31:57] Also, add your mentors as reviewers [04:33:45] Wait. I don't understand the first part. [04:34:16] You either go big or you go home [04:34:22] You either have one line or one on each line [04:34:37] failed analogy [04:34:39] but you get the idea [04:36:08] Hydronium: Yep. Like this? https://dpaste.de/TkfR [04:36:25] bingo [04:36:30] also, check for trailing whitespace [04:37:04] How so? [04:37:27] Oh. I got you. Lemme do that. [04:39:33] It's good. So now I push a new patch? [04:39:50] if you want [04:43:50] https://dpaste.de/t8NQ I did it again. I restarted vagrant, and accidentally commited before I cded into MMV. What command do I run? [04:45:57] what is on branch master? [04:46:04] and why did you edit on master? [04:47:44] No. my 127 wasn't working, so I restarted vagrant. You told me to fix the array, and I did. When I went to commit, I forgot to cd into MMV. So now when I commit in MMV, it gives me the message that I have unsaved changes. [04:48:25] I forgot the command you told me to run before when I had this problem. [04:51:10]