[01:54:04] (03PS3) 10PranavK: Make "Upload anyway" link a OOjs UI button [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/260900 (https://phabricator.wikimedia.org/T114221) [02:01:40] (03CR) 10PranavK: "@Aklapper: I'm truly sorry if this has been a hassle for you guys! I have set up Vagrant on my machine, but I'm temporarily on a really sl" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/260900 (https://phabricator.wikimedia.org/T114221) (owner: 10PranavK) [02:03:14] (03CR) 10Sn1per: "Check out jshint: http://jshint.com/install/" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/260900 (https://phabricator.wikimedia.org/T114221) (owner: 10PranavK) [02:14:36] tgr: T59308, So what I've got to do now is update the tests in tests/qunit so that they don't check for user. [02:16:12] JadeMaveric: yes [02:16:20] also, probably delete a bunch of tests [02:16:29] since you deleted some classes [02:16:44] How does the test system work? [02:17:08] Does it mimic a user? [02:17:20] we have qunit tests and browser tests [02:17:50] qunit is a unit test framework [02:18:48] in unit tests, you create some small and isolated piece of the system (a single object, typically), pass it fake data, have it perform some task, and verify that the data it returns is correct [02:20:19] this works very nicely with classes which are functional in nature [02:20:51] ie. they get an input, they return an output, and the transformation between the two is pretty much all they do [02:21:03] eg. EmbedFileFormatter is like that [02:21:31] most MediaViewer classes are UI-related so unit testing them is somewhat awkward [02:22:08] a lot of mocking needs to be done [02:22:57] we use SinonJS for mocking, it has very good documentation so reading that is probably the easiest way to understand how mocking works [02:23:16] the other big class of tests is browser tests [02:24:35] those either launch an actual browser at some test wiki and remote-control it and test things that way, or do some simplified version of that [02:25:56] ie. instead of a real browser they us PhantomJS or something similar [02:26:34] you can typically configure in the test what kind of browser or browser emulator to use [03:36:50] tgr: I edited the changes and added them to the staging area but the testing page acts like I never saved them at all [03:37:52] probably some browser cache issue [03:38:01] try reloading with ctrl-f5 [03:38:34] or if you use chrome open the developer console, click on the cogwheel icon and select disable cache [03:38:46] other browsers surely have something similar as well [03:40:50] Thanks `no cached reload` worked. I'll work on the remaining errors [03:43:02] For some weird reason all the messages have shifted to the right border. Not really a problem but it feels uncomfortable. [03:44:58] JadeMaveric: that happens sometimes [03:45:39] Okay, at least it's something common. I thought i broke something [03:46:22] some test sets the RTL class on the page and fails to clean it up [04:23:55] (03PS1) 10Unicornisaurous: Shorten MediaViewer credit lines [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260955 (https://phabricator.wikimedia.org/T119686) [04:26:10] (03CR) 10jenkins-bot: [V: 04-1] Shorten MediaViewer credit lines [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260955 (https://phabricator.wikimedia.org/T119686) (owner: 10Unicornisaurous) [04:28:01] Unicornisaurous: Forgetting the ; is really quite common isn't it? [04:28:13] Ugh, yes. [04:29:12] Well, at least you've passes your other tests. [04:29:16] * JadeMaveric sighs [04:29:41] https://gerrit.wikimedia.org/r/260931 [04:29:56] Yeah I actually ran the qunit tests before submitting to gerrit. Wouldn’t want to inconvenience jenkins-bot one bit, he might get tired of me. [04:30:17] But she's a bot [04:30:48] Besides, my tests aren't automated [04:30:55] Bots have feelings too [04:30:59] I've do have to run them myself [04:31:12] Aww.. Okay, it is Christmas [04:31:32] Goodwill and cheer to all men... and bots [04:32:04] (03PS2) 10Unicornisaurous: Shorten MediaViewer credit lines [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260955 (https://phabricator.wikimedia.org/T119686) [04:32:52] Merry christmas! [04:33:09] Wish you the same! [04:44:38] (03PS3) 10Unicornisaurous: Shorten MediaViewer credit lines [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260955 (https://phabricator.wikimedia.org/T119686) [04:47:04] (03CR) 10Unicornisaurous: "Theres a few things I'm not sure about here." (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260955 (https://phabricator.wikimedia.org/T119686) (owner: 10Unicornisaurous) [04:47:10] JadeMaveric: Do you have $wgResourceLoaderDebug = true; ? [04:47:25] OH-: How do I check? [04:48:09] Well, if QUnit says there are errors in w/index.php?somejunkhere=true&bleh=junk&cravingsome=eggnog&donuts=glazed&password=hunter2 [04:48:13] then you probably don't have it enabled [04:48:34] How do I enable [04:48:53] Mediawiki "minimizes" (shrinks) JavaScript before it's delivered to the browser to save space and time [04:48:59] this is a Bad Thing (tm) if you're debugging [04:49:22] open vagrant/LocalSettings.php and add "$wgResourceLoaderDebug = true;" somewhere in that file [04:49:36] Well if you’re running Qunit tests theres a nice button to enable it, but otherwise you have to add it to LocalSettings.php [04:50:28] Well, $wgResourceLoaderDebug is useful if you're working with JavaScript of other parts of Mediawiki too [04:50:34] it does slow things down a bit, though [04:50:47] more convenient than adding debug=true to the end of URLs [04:50:58] Does anyone know what the best jshint plugin for Sublime Text is? [04:59:59] 'best' is a strong word [05:01:08] OH-: I did enable the &debug=true flag. [10:46:03] (03CR) 10Gergő Tisza: [C: 04-1] "Looks good! The base URL needs to be fixed though." (032 comments) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260955 (https://phabricator.wikimedia.org/T119686) (owner: 10Unicornisaurous) [11:07:47] 6Multimedia, 6Commons, 10MediaWiki-File-management, 10MediaWiki-Vagrant: InstantCommons does not work in Vagrant (again) - https://phabricator.wikimedia.org/T122275#1904051 (10Tgr) 5Open>3Resolved Cannot reproduce anymore, even on the same machine. I there was some temporary change to Commons. Anyway,... [14:32:49] (03CR) 10Aklapper: "@PranavK: Ah great I wasn't aware of that! Please no worries, I'm very happy to hear that you've set up Vagrant and I am sorry for my igno" [extensions/UploadWizard] - 10https://gerrit.wikimedia.org/r/260900 (https://phabricator.wikimedia.org/T114221) (owner: 10PranavK) [14:37:45] (03PS4) 10Unicornisaurous: Shorten MediaViewer credit lines [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260955 (https://phabricator.wikimedia.org/T119686) [14:39:52] (03CR) 10jenkins-bot: [V: 04-1] Shorten MediaViewer credit lines [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260955 (https://phabricator.wikimedia.org/T119686) (owner: 10Unicornisaurous) [14:40:10] jenkins-bot, it’s christmas, cut me a break! [14:41:00] (03PS5) 10Unicornisaurous: Shorten MediaViewer credit lines [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260955 (https://phabricator.wikimedia.org/T119686) [16:54:46] (03PS1) 10TheDJ: Add the videojs-ogvjs Tech module [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/260963 (https://phabricator.wikimedia.org/T119048) [16:58:47] (03CR) 10jenkins-bot: [V: 04-1] Add the videojs-ogvjs Tech module [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/260963 (https://phabricator.wikimedia.org/T119048) (owner: 10TheDJ) [17:15:43] (03CR) 10TheDJ: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/260963 (https://phabricator.wikimedia.org/T119048) (owner: 10TheDJ) [20:35:06] (03PS2) 10Neonowy: Use OO.ui.confirm() for the confirmation dialog in ext.tmh.transcodetable [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/260892 (https://phabricator.wikimedia.org/T117078) [21:51:22] (03CR) 10Paladox: "Needs re c+2 again." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248404 (owner: 10TheDJ) [21:51:38] (03CR) 10Paladox: Remove standalone mwEmbedLoader [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248404 (owner: 10TheDJ) [21:55:12] (03PS1) 10Aaron Schulz: Fix deprecated SquidUpdate calls [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/261027 [21:55:31] (03PS1) 10Aaron Schulz: Remove pointless wfSuppressWarnings() call [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/261028 [21:58:32] (03CR) 10Gergő Tisza: [C: 031] "Great work! I don't want to merge it until URL shortening is finished, but you can't do anything about that right now, so this concludes t" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260955 (https://phabricator.wikimedia.org/T119686) (owner: 10Unicornisaurous) [21:59:49] (03CR) 10jenkins-bot: [V: 04-1] Fix deprecated SquidUpdate calls [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/261027 (owner: 10Aaron Schulz) [22:01:02] (03CR) 10Unicornisaurous: "Fantastic, thanks. I just submitted the task on GCI." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/260955 (https://phabricator.wikimedia.org/T119686) (owner: 10Unicornisaurous) [22:19:17] (03CR) 10TheDJ: [C: 032] Remove standalone mwEmbedLoader [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248404 (owner: 10TheDJ) [22:25:08] (03Merged) 10jenkins-bot: Remove standalone mwEmbedLoader [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/248404 (owner: 10TheDJ)